#instantbird log on 08 09 2016

All times are UTC.

00:03:54 <-- chrisccoulson has quit (Ping timeout: 121 seconds)
01:06:09 --> mconley|livehacking has joined #instantbird
01:11:06 <-- mconley|livehacking has quit (Quit: NO CARRIER)
02:09:52 <-- EionRobb has quit (Ping timeout: 121 seconds)
02:11:14 --> EionRobb has joined #instantbird
03:39:25 --> nhnt11 has joined #instantbird
03:39:25 * ChanServ sets mode +h nhnt11 
04:08:28 <instant-buildbot> build #786 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/786
04:24:27 <-- bgmCoder has quit (Ping timeout: 121 seconds)
04:36:11 <-- nhnt11 has quit (Ping timeout: 121 seconds)
05:55:53 <-- EionRobb has quit (Quit: Leaving.)
06:04:49 --> nhnt11 has joined #instantbird
06:04:49 * ChanServ sets mode +h nhnt11 
06:27:48 --> chrisccoulson has joined #instantbird
06:27:52 <-- chrisccoulson has quit (Connection closed)
06:27:54 --> chrisccoulson_ has joined #instantbird
06:33:41 --> EionRobb has joined #instantbird
06:36:28 <-- nhnt11 has quit (Connection closed)
06:36:33 --> nhnt11 has joined #instantbird
06:36:33 * ChanServ sets mode +h nhnt11 
07:07:04 <-- nhnt11 has quit (Ping timeout: 121 seconds)
07:49:48 <-- EionRobb has quit (Connection closed)
07:50:44 --> EionRobb has joined #instantbird
08:15:20 --> gerard-majax has joined #instantbird
08:33:14 --> Bollebib has joined #instantbird
08:35:20 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:36:40 --> gerard-majax has joined #instantbird
08:57:38 --> nhnt11 has joined #instantbird
08:57:38 * ChanServ sets mode +h nhnt11 
09:02:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:07:23 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:08:19 <-- nhnt11 has quit (Ping timeout: 121 seconds)
09:23:57 --> nhnt11 has joined #instantbird
09:23:57 * ChanServ sets mode +h nhnt11 
09:41:49 --> flo-retina has joined #instantbird
09:41:49 * ChanServ sets mode +qo flo-retina flo-retina 
09:45:49 <-- nhnt11 has quit (Ping timeout: 121 seconds)
09:46:06 --> gerard-majax has joined #instantbird
09:53:45 --> nhnt11 has joined #instantbird
09:53:46 * ChanServ sets mode +h nhnt11 
09:54:26 <-- nhnt11 has quit (Connection closed)
09:54:34 --> nhnt11 has joined #instantbird
09:54:34 * ChanServ sets mode +h nhnt11 
10:06:00 <-- clokep-M has quit (Connection closed)
10:06:00 <-- matthew-M has quit (Connection closed)
10:07:04 --> matthew-M has joined #instantbird
10:07:35 --> aleth has joined #instantbird
10:07:35 * ChanServ sets mode +o aleth 
10:10:27 --> clokep-M has joined #instantbird
10:17:22 <-- Alex1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:33:26 <-- aleth has quit (Quit: Instantbird 51)
10:46:53 --> BWMerlin has joined #instantbird
10:49:47 --> mpmc has joined #instantbird
10:59:25 <-- BWMerlin has quit (Connection closed)
11:07:42 --> BWMerlin has joined #instantbird
11:28:40 --> aleth has joined #instantbird
11:28:40 * ChanServ sets mode +o aleth 
11:36:25 --> abdelrhman has joined #instantbird
11:50:58 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:10:24 <-- abdelrhman has quit (Connection closed)
12:12:39 --> abdelrhman has joined #instantbird
12:33:03 <instantbot> aryx.bugmail@gmx-topmail.de changed the Resolution on bug 1293370 from --- to FIXED.
12:33:04 <instantbot> aryx.bugmail@gmx-topmail.de set status-thunderbird to fixed on bug 1293370.
12:39:06 --> clokep_work has joined #instantbird
12:39:07 * ChanServ sets mode +o clokep_work 
12:39:56 <-- BWMerlin has quit (Ping timeout: 121 seconds)
12:51:23 <-- aleth has quit (Ping timeout: 121 seconds)
12:58:44 --> aleth has joined #instantbird
12:58:44 * ChanServ sets mode +o aleth 
13:10:59 <clokep_work> abdelrhman: See you put up a new patch! :)
13:11:09 <clokep_work> Hopefully I can look today (and maybe nhnt11 too if he has time / inclination.)
13:18:06 <-- abdelrhman has quit (Connection closed)
13:18:10 --> abdelrhman has joined #instantbird
13:23:22 <abdelrhman> aleth: in bug 1292884, will be the section 15.2 (Service Discovery Category/Type) in XEP-0045 sufficient?
13:23:50 * aleth wonders why instantbot no longer gives bug titles :-/
13:24:53 <aleth> abdelrhman: yes, exactly. I think you have to check the identity node?
13:25:22 <abdelrhman> OK.
13:45:45 * nhnt11 is back at home after his graduation
14:01:26 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:01:30 --> nhnt11 has joined #instantbird
14:01:31 * ChanServ sets mode +h nhnt11 
14:04:37 <clokep_work> nhnt11: Congrats. :)
14:05:22 <abdelrhman> aleth: in bug 1292882, I think this already handled in https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1798 or you mean another thing?
14:05:33 <-- nhnt11 has quit (Ping timeout: 121 seconds)
14:07:07 <aleth> abdelrhman: It should be handled without a warning
14:08:46 --> Tonnes has joined #instantbird
14:20:14 <abdelrhman> aleth: "receive presence stanzas for that resource", you mean the "to" attribute?
14:21:07 <aleth> the user's jid but with a different resource
14:23:01 --> bgmCoder has joined #instantbird
14:27:08 <-- abdelrhman has quit (Ping timeout: 121 seconds)
14:28:42 <instantbot> New Chat Core - XMPP bug 1293669 filed by acelists@atlas.sk.
14:48:48 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904])
14:49:18 <clokep_work> abdelrhman, aleth: Did you see http://log.bezut.info/instantbird/160808/#m138?
14:56:26 --> Tonnes has joined #instantbird
15:02:21 <aleth> clokep_work: something for abdelrhman to check, but I suspect it's http://log.bezut.info/instantbird/160808/#m153
15:58:20 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:21:57 --> gerard-majax has joined #instantbird
16:37:14 --> mpmc has joined #instantbird
16:44:22 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:45:02 --> abdelrhman has joined #instantbird
16:48:04 --> gerard-majax has joined #instantbird
17:03:24 <-- flo-retina has quit (Ping timeout: 121 seconds)
17:14:20 --> arlolra has joined #instantbird
17:15:50 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:18:36 --> gerard-majax has joined #instantbird
17:25:31 --> mpmc1 has joined #instantbird
17:41:07 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:46:27 <-- abdelrhman has quit (Connection closed)
17:48:56 --> nhnt11 has joined #instantbird
17:48:57 * ChanServ sets mode +h nhnt11 
17:50:03 --> Logicoma has joined #instantbird
17:52:37 --> abdelrhman has joined #instantbird
18:05:18 <-- abdelrhman has quit (Connection closed)
18:05:43 <-- nhnt11 has quit (Ping timeout: 121 seconds)
18:10:06 --> abdelrhman has joined #instantbird
18:26:02 <-- abdelrhman has quit (Connection closed)
18:26:29 <-- mpmc1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:27:01 --> abdelrhman has joined #instantbird
18:30:06 --> gerard-majax has joined #instantbird
18:38:27 <-- Logicoma has quit (Ping timeout: 121 seconds)
18:40:54 --> Logicoma has joined #instantbird
18:42:29 <-- abdelrhman has quit (Connection closed)
18:49:31 --> abdelrhman has joined #instantbird
18:52:23 <clokep_work> aleth: Ew.
18:52:25 <clokep_work> That change sucks.
18:52:53 <aleth> Not as much as the existence of utilities.js ;)
18:53:14 <clokep_work> aleth: I'm a little surprised about the getIter for im/content/addbuddy.js?
18:53:41 <clokep_work> What's that do?
18:54:00 <clokep_work> Ahhh...
18:54:01 <clokep_work> I see.
18:54:07 <clokep_work> Never mind. :P
18:54:24 <clokep_work> FWIW I find for...in and for...of confusing in JS.
18:54:26 <clokep_work> Why are they different?
18:54:34 <aleth> The problem with it is it's hard to see if you've caught all legacy generators
18:55:14 <clokep_work> Are there none in chat?
18:55:36 <clokep_work> abdelrhman: aleth asked you to review something, not sure you've done that before? But if not, please feel free to ask questions!
18:55:51 <aleth> for...in loops over keys (e.g. property names), for...of loops over an iterable (the iterable protocol is implemented by anything you can loop over, like arrays, strings, generators,...) 
18:55:51 <abdelrhman> OK
18:56:02 <aleth> so for...of basically loops over values
18:56:11 <aleth> that's a reasonable shorthand anyway
18:56:24 <aleth> Doesn't quite fit because objects aren't iterable
18:56:29 <clokep_work> I find it confusing. :P
18:56:38 <clokep_work> Because "in" and "of" don't make sense in English to be doing those things.
18:56:42 <aleth> Right.
18:56:51 <clokep_work> ("in" sounds like values to me FWIW.)
18:57:09 <aleth> I suspect if for...in hadn't already been taken, the naming would be different
18:57:33 <clokep_work> Yeah.
18:57:35 <aleth> You can really tell for...of is the result of straightening out a mess that shouldn't have been there from the start...
18:57:36 * clokep_work is just grumpy today. ;)
18:57:54 <aleth> The notion of an iterable makes a lot of sense though.
18:58:01 <aleth> Just came very late ;)
18:59:04 <aleth> clokep_work: apparently there's an ES7 proposal to add decorators
18:59:05 <clokep_work> Kind of.
18:59:15 <clokep_work> That's exciting. ;)
18:59:22 <clokep_work> JavaScript: We just add everything from every language.
18:59:31 <aleth> At the same time.
18:59:47 <aleth> :D
19:00:39 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:02:06 <-- abdelrhman has quit (Connection closed)
19:03:18 <clokep_work> I like decorators, but they might be confusing in this case.
19:03:46 <aleth> Who knows what JS decorators will look like...
19:04:01 <clokep_work> aleth: So pretty much, if you use yield you need the * now, right?
19:04:08 <clokep_work> That's the difference between legacy and non?
19:04:10 <aleth> Yeah, that's the standard.
19:04:43 <aleth> There are more differences in that the generator you get without the * is also nonstandard (has methods with nonstandard names etc)
19:05:02 <clokep_work> Ahhhh, interesting.
19:05:03 <aleth> I've never used legacy generators, it's good they are gone.
19:05:16 <clokep_work> Do you know if there are any in chat/?
19:05:21 <clokep_work> Or is that a different bug?
19:05:23 <aleth> aceman took care of them
19:05:28 <clokep_work> That's what I thought.
19:05:31 <clokep_work> These bugs are confusing. :(
19:05:36 <clokep_work> Oh, that was the for each one, wasn't it?
19:05:39 <clokep_work> Are those finally disappearing?
19:06:41 <aleth> https://hg.mozilla.org/comm-central/rev/adc56f0cd5b514b27a96cebb31afe02503971b0c
19:06:59 <aleth> not so many hits in chat/ because chat code is not so old ;)
19:07:37 <clokep_work> aleth: Ah, so is bug 1290637 about not making Objects iterable anymore?
19:07:44 <clokep_work> And you have to expliclty use Iterator to do that?
19:08:14 <clokep_work> That diff confuses me though because there are no changes to generators?
19:08:38 <aleth> clokep_work: the changes that made that diff necessary are in mail/ (the forked im/ code)
19:09:02 <clokep_work> Arg.
19:09:05 <clokep_work> That's annoying.
19:09:07 <aleth> clokep_work: I think that bug is about the Iterator() helper function
19:09:29 <aleth> Objects have never been iterable
19:09:40 --> ChaosShrineInn has joined #instantbird
19:10:19 <clokep_work> Sure they are.
19:10:47 --> flo-retina has joined #instantbird
19:10:47 * ChanServ sets mode +qo flo-retina flo-retina 
19:10:48 <aleth> No, only with for...in 
19:11:20 <clokep_work> var x = {'a': 1, 'b': 2}; for (var i in x) { console.log(i); }
19:11:22 <clokep_work> Sure.
19:11:29 <clokep_work> And that's not iterable?
19:11:44 <clokep_work> I'm pretty sure someone in ES-land decided to give "iterable" an "Iterable" (capital I) definition.
19:11:53 <clokep_work> Which is making this conversation confusing.
19:11:57 <aleth> Yeah, I meant "iterable" in the sense of the es6 iterable protocol (i.e. for...of)
19:12:08 <clokep_work> Yeah...
19:12:24 <aleth> All this stuff is super confusing because there are like 3 or 4 old nonstandard implementations that all use the same words :P
19:13:29 <clokep_work> Yay.
19:13:32 <clokep_work> Sorry to be confused. ;)
19:16:11 <clokep_work> aleth: AHHHH I got it now, sorry. I thought that bug was changing things to use Iterator(), but that's non-standard and this switches it to a *standard* way of doing it.
19:16:16 <clokep_work> Sorry, brain isn't working well today. ;)
19:16:54 <aleth> To make things worse, old TB code is full of fixIterator() calls which convert from one kind of iterator standard to another ;)
19:16:59 <-- ChaosShrineInn has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:18:36 <clokep_work> Gah. That's gross.
19:18:46 <clokep_work> I bet it goes from the new kind to the old kind?
19:18:56 * aleth doesn't want to try to remember :P
19:19:27 <clokep_work> ;)
19:19:44 <clokep_work> Maybe I'll try to knock those out at some point just to get rid of them.
19:19:52 <clokep_work> We never fixed drag n drop in the accounts manager. ;(
19:20:09 <aleth> We should just add the missing file for now like TB did
19:20:27 <aleth> Doesn't seem worth spending time on (unless you are feeling bored)
19:22:09 <clokep_work> Not that bored.
19:22:51 --> abdelrhman has joined #instantbird
19:26:15 <clokep_work> aleth, flo-retina: https://timtaubert.de/blog/2016/08/continuous-integration-for-nss/
19:26:18 <clokep_work> Could be interesting.
19:28:31 <clokep_work> Sounds too mozilla embedded for us though.
19:31:55 <aleth> Though if TB ever does get moved to taskcluster, it should be easy to grab that setup.
19:32:19 <aleth> May still be overly complex though/
19:34:10 <clokep_work> Yeah.
19:35:58 <clokep_work> https://docs.taskcluster.net/tutorial/what-is-tc is interesting.
19:36:04 <clokep_work> So yeah, it's not really deployable in other places right now.
19:40:05 <-- abdelrhman has quit (Connection closed)
19:45:37 --> abdelrhman has joined #instantbird
19:51:32 --> mpmc1 has joined #instantbird
19:51:57 <-- Logicoma has quit (Quit: There's nothing dirtier than a giant ball of oil)
20:02:09 <-- EionRobb has quit (Quit: Leaving.)
20:15:16 --> gerard-majax has joined #instantbird
20:21:49 <-- abdelrhman has quit (Connection closed)
20:21:56 --> abdelrhman has joined #instantbird
20:22:05 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:29:21 <-- mpmc1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:33:23 <-- abdelrhman has quit (Connection closed)
20:38:51 <clokep_work> aleth: Does break; work inside of [].forEach()?
20:38:56 <clokep_work> (Looking at https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1293669&attachment=8779503)
20:39:02 --> abdelrhman has joined #instantbird
20:39:21 <clokep_work> No...
20:41:21 <aleth> don't see how it could
20:45:35 <clokep_work> Yeah it doesn't.
20:45:35 <-- abdelrhman has quit (Connection closed)
20:45:36 <clokep_work> I commented.
20:46:08 --> abdelrhman has joined #instantbird
20:48:40 <-- abdelrhman has quit (Connection closed)
20:49:37 --> abdelrhman has joined #instantbird
20:50:18 --> EionRobb has joined #instantbird
21:09:13 <-- abdelrhman has quit (Connection closed)
21:10:29 --> abdelrhman has joined #instantbird
21:13:00 <-- abdelrhman has quit (Connection closed)
21:14:01 --> abdelrhman has joined #instantbird
21:22:44 <-- abdelrhman has quit (Connection closed)
21:26:47 --> abdelrhman has joined #instantbird
21:37:28 <-- abdelrhman has quit (Connection closed)
21:38:51 <-- clokep_work has quit (Ping timeout: 121 seconds)
21:39:40 --> abdelrhman has joined #instantbird
21:49:03 --> gerard-majax has joined #instantbird
21:51:46 <-- abdelrhman has quit (Ping timeout: 121 seconds)
21:51:47 --> abdelrhman has joined #instantbird
21:54:19 <-- abdelrhman has quit (Connection closed)
21:54:31 --> abdelrhman has joined #instantbird
21:55:07 <-- gerard-majax has quit (Ping timeout: 121 seconds)
21:59:57 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:05:19 <-- abdelrhman has quit (Connection closed)
22:05:33 --> abdelrhman has joined #instantbird
22:08:15 <instantbot> ab@abahmed.com changed the Resolution on bug 1292884 from --- to FIXED.
22:08:55 <instantbot> ab@abahmed.com changed the Resolution on bug 1292882 from --- to FIXED.
22:14:50 --> afiksof has joined #instantbird
22:18:53 <-- afiksof has quit (Ping timeout: 121 seconds)
22:19:41 <instantbot> acelists@atlas.sk changed the Resolution on bug 1293669 from --- to FIXED.
22:28:52 <-- abdelrhman has quit (Connection closed)
22:30:36 --> abdelrhman has joined #instantbird
22:33:10 <-- abdelrhman has quit (Connection closed)
22:41:22 --> abdelrhman has joined #instantbird
23:00:00 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:05:12 <-- aleth has quit (Quit: Instantbird 51)
23:15:07 <-- EionRobb has quit (Ping timeout: 121 seconds)
23:15:50 --> EionRobb has joined #instantbird
23:17:27 --> clokep_work has joined #instantbird
23:17:27 * ChanServ sets mode +o clokep_work 
23:21:29 <-- clokep_work has quit (Ping timeout: 121 seconds)
23:37:07 <-- EionRobb has quit (Ping timeout: 121 seconds)
23:38:24 --> EionRobb has joined #instantbird
23:49:43 <-- Bollebib has quit (Ping timeout: 121 seconds)