#instantbird log on 11 05 2019

All times are UTC.

00:03:44 --> clokep has joined #instantbird
00:43:30 <clokep> freaktechnik: Do you know if the patch in bug 1227973 makes any sense with the state of add-ons now?
00:43:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1227973 nor, --, ---, martin, ASSI, Dynamic registration of Protocols
00:43:44 <clokep> I suspect it needs to be re-done in a way similar to how the cloudfile stuff is done.
00:59:12 <freaktechnik> I have no idea, but the underlying problem will still apply.
00:59:47 <freaktechnik> However, extensions would probably use an entirely different registration mechanism and optimally not require the xpcom infrastructure.
01:00:15 <freaktechnik> (I think flo mentioned something similar about a year ago when we talked about it in passing)
01:06:36 <clokep> Yeah, that makes sense.
01:07:01 <clokep> The registation to the chat core still seems to apply.
01:09:07 <clokep> Ugh, the way we handle participant tooltips is janky.
01:09:16 <clokep> We do a lot of passing things as serialized text...
01:09:26 <clokep> I think this is inherited from Pidgin/libpurple.
01:12:48 * clokep needs to think more about how to fix this...
03:04:16 <-- clokep has quit (Ping timeout: 121 seconds)
05:46:45 --> Logicoma has joined #instantbird
06:19:06 --> gerard-majax has joined #instantbird
06:28:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
06:42:31 --> gerard-majax has joined #instantbird
06:47:31 <-- gerard-majax has quit (Ping timeout: 121 seconds)
07:12:16 --> gerard-majax has joined #instantbird
07:59:25 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:13:22 --> gerard-majax has joined #instantbird
09:37:21 <-- Jackneilll has quit (The TLS connection was non-properly terminated.)
09:39:56 --> Jackneill has joined #instantbird
10:06:52 <-- florian has quit (Client exited)
12:12:26 --> clokep has joined #instantbird
12:44:07 --> florian has joined #instantbird
12:44:07 * ChanServ sets mode +qo florian florian 
13:30:14 --> jmaher has joined #instantbird
13:34:00 <-- jmaher has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:47:49 <florian> clokep: hey. I'm not a fan of the "modified text" phrasing as that doesn't convey that a long message might have been split into smaller ones
13:48:08 <clokep> florian: I'm struggling with what to use there, do you have suggestions?
13:48:17 <clokep> I think the original comment there didn't really portray what is to be done there.
13:48:44 <florian> does it really make sense to return an empty array when the original message is fine to send as is?
13:48:52 <florian> should we just return [originalMessage] ?
13:50:41 <clokep> We could make it always return something, with the default of a passthru that isn't really any more work.
13:50:59 <florian> then the empty array would keep the "send nothing" meaning
13:51:31 <florian> sorry for the back and forth
13:52:35 <florian> Windows keeps wanting to restart for updates :(
14:06:16 <clokep> Sorry, I'm not fully following what you mean about the empty array?
14:09:21 <clokep> florian: I'm unsure if you're suggesting updating the comment or the behavior.
14:09:30 <clokep> Note that the patch doesn't really change any behavior.
14:10:09 <florian> the behavior
14:10:12 <florian> but I don't care strongly
14:10:30 <florian> I was just thinking it might be less confusing in the future if the function always returns what we are going to send
14:26:15 <clokep> It should be pretty easy to do.
14:26:19 <clokep> I don't have a strong opinion?
14:27:04 <florian> another solution is to just let the next confused person figure it out ;)
14:27:25 <clokep> Heh. :) I'd like to improve this stuff to be less confusing.
14:28:05 <clokep> So if we made it always return, we could say something like "return the potentially modified message(s)" as the comment?
14:29:38 <florian> seems good
14:32:09 <clokep> Makes sense to me. :)
14:40:30 <clokep> florian: So....unrelated, but I was looking at the tooltip code we have, and it is very odd. There's the `getNormalizedChatBuddyName` on prplIConvChat. Which attempts to map from a name to a name. I think this is for XMPP, but it doesn't work well for e.g. Matrix. It seems like we really want to be using some sort of "ID" in places.
14:40:35 <clokep> Is this just a crazy API inherited from libpurple?
14:41:06 <clokep> https://searchfox.org/comm-central/source/chat/components/public/prplIConversation.idl#161-168
14:41:19 <clokep> https://searchfox.org/comm-central/search?q=getNormalizedChatBuddyName&redirect=false
14:41:22 <florian> I'm not sure if it's crazy from libpurple or from XMPP
14:41:27 <florian> I remember what this does though
14:41:52 <florian> it's because when joining an XMPP MUC you can use a nick in it
14:41:59 <clokep> For example, https://searchfox.org/comm-central/source/chat/content/chat-tooltip.js#422-435 seems weird to me -- we go from an obejct to a string, map it to another string, to get another object?
14:42:12 <florian> but nothing guarantees that the same nick in 2 MUCs on the same server are the same person
14:42:57 <clokep> Right, I understand that (crazy as it is), but it seems like our objects could do a better job of the mapping without having to go through strings first.
14:43:18 <clokep> prplIConvChatBuddy could have an API like "get me a contact" that just returns the contact.
14:43:34 <florian> it's not a contact
14:43:36 <clokep> That doesn't work on the situations where we have tooltips in the HTML though (e.g. on the bubbles or if a nick gets mentioned).
14:43:49 <clokep> Sorry, the account buddy.
14:45:16 <florian> ah, indeed, in that case we start from a string
14:45:36 <florian> I'm afraid it's just ugliness we'll have to live with
14:47:27 <clokep> I'm having trouble adapting it for Matrix.
14:47:43 <clokep> But maybe I'm using our interfaces wrong...
14:48:13 <clokep> Matrix has real "IDs" that are like clokep:matrix.org., but then my display name is clokep. So, the mapping is a bit weird...
14:48:18 <clokep> I'll have to check the XMPP code, I guess.
17:29:59 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:11:17 <-- florian has quit (Client exited)
19:09:45 --> florian has joined #instantbird
19:09:45 * ChanServ sets mode +qo florian florian 
19:17:08 --> gerard-majax has joined #instantbird
19:47:19 <-- gerard-majax has quit (Connection closed)
21:06:06 <-- clokep has quit (Ping timeout: 121 seconds)
22:31:06 <-- Logicoma has quit (Ping timeout: 121 seconds)
23:33:09 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
23:33:22 --> chrisccoulson has joined #instantbird