#instantbird log on 10 18 2019

All times are UTC.

00:03:40 --> clokep has joined #instantbird
02:37:24 <-- clokep has quit (Ping timeout: 121 seconds)
07:58:02 --> Jackneill has joined #instantbird
08:37:51 --> chrisccoulson has joined #instantbird
08:45:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
08:46:50 --> chrisccoulson has joined #instantbird
11:18:54 --> clokep has joined #instantbird
12:04:07 <clokep> Hi florian!
12:04:21 <clokep> I'm unsure if you saw the bug I filed last night (about issues updating the title of a MUC).
12:04:29 <clokep> Do you know if that was ever supposed to be "supported"?
12:09:38 <-- gerard-majax has quit (Ping timeout: 121 seconds)
12:28:01 --> gerard-majax has joined #instantbird
12:43:58 <-- gerard-majax has quit (Ping timeout: 121 seconds)
12:48:47 <clokep> Meh...I can't reproduce that with the IRC code.
12:48:53 <clokep> Which points to something funky w/ the Matrix code. :(
13:03:19 --> gerard-majax has joined #instantbird
13:12:33 <-- gerard-majax has quit (Ping timeout: 121 seconds)
13:24:41 --> gerard-majax has joined #instantbird
13:30:59 --> Logicoma has joined #instantbird
13:49:03 <-- gerard-majax has quit (Ping timeout: 121 seconds)
14:01:47 --> gerard-majax has joined #instantbird
16:13:10 <-- gerard-majax has quit (The TLS connection was non-properly terminated.)
16:13:46 --> gerard-majax has joined #instantbird
16:45:30 <florian> clokep: Hello. We you still seeking an answer from me (no, I haven't seen the bug) or did your last 2 messages mean you found the answer already?
16:46:15 <clokep> florian: I was able to reproduce it using the IRC code.
16:46:21 <clokep> https://bugzilla.mozilla.org/show_bug.cgi?id=1589552
16:46:23 <instantbot> Bug 1589552 nor, --, ---, nobody, UNCO, Conversations list assumes all elements represent a contact
16:46:43 <clokep> I'm unsure if it was an oversight or was designed that way, but either way I think I can fix it.
16:50:37 <florian> is that yet another de-XBL regression?
16:51:57 <clokep> I don't think so. I looked at the commit and that code seems the same-ish.
16:52:51 <florian> the whole contact system is way too complicated for what TB does with it :(
16:52:52 <clokep> I'm not 100% sure on that though.
16:53:00 <clokep> I agree. :-\
16:53:15 <clokep> https://searchfox.org/comm-central/source/mail/components/im/content/chat-group.js#94-102 is the part that is really suspect to me.
16:53:32 <clokep> It is using whether the "contact" has a tag to decide what UI to show.
16:53:40 <clokep> (Note that "contact" here is either a contact OR a conversation.)
16:53:43 <clokep> As far as I can tell.
16:55:08 <florian> when reading your sentences I read "tag" as the tags one adds to contacts. But when reading the code I read "tag" as in "HTML tag"
16:56:01 <florian> the tagName value is "imconv", it's at https://searchfox.org/comm-central/source/mail/components/im/content/chat-messenger.js#427
17:02:03 <florian> clokep: if I had reviewed that de-XBL patch, I would have requested this change: https://paste.mozilla.org/cXy1JeE1
17:02:25 <clokep> florian: AH-HA! I read it as a "tag on a contact" also.
17:04:53 <clokep> It looks like that code used to be |let contactElt = document.createElement(aTagName || "imcontact");|
17:05:00 <clokep> I'm unsure if that's clearer or not. :-D
17:06:19 <florian> so someone broke it while de-XBLing ;)
17:16:50 <clokep> florian: Well that behavior is the same, I think?
17:16:59 <clokep> That's not where the actual bug is though?
17:25:30 <clokep> Looks like the old imgroup.xml binding had the same exact behavior.
17:39:26 <clokep> florian: Why does that code not just *move* the element? Instead it destroys it and recreates it?
17:44:16 <clokep> Alternately, is there a way to get that "is" property off of the XUL element that gets created?
18:48:27 <-- clokep has quit (Ping timeout: 121 seconds)
21:58:47 <-- chrisccoulson has quit (Ping timeout: 121 seconds)
23:07:44 <-- Logicoma has quit (Ping timeout: 121 seconds)