All times are UTC.
00:02:28 <-- clokep_tb has quit (Ping timeout: 121 seconds) 00:07:46 --> clokep_tb has joined #instantbird 00:14:56 <-- FilipMosner has quit (Ping timeout: 121 seconds) 00:22:41 --> FilipMosner has joined #instantbird 00:27:04 <-- clokep_tb has quit (Ping timeout: 121 seconds) 00:28:13 --> clokep_tb has joined #instantbird 00:56:45 <-- FilipMosner has quit (Ping timeout: 121 seconds) 01:02:45 --> FilipMosner has joined #instantbird 01:36:49 <-- FilipMosner has quit (Ping timeout: 121 seconds) 01:42:46 --> FilipMosner has joined #instantbird 02:14:56 <-- clokep_tb has quit (Ping timeout: 121 seconds) 02:16:49 <-- FilipMosner has quit (Ping timeout: 121 seconds) 02:22:43 --> FilipMosner has joined #instantbird 02:56:47 <-- FilipMosner has quit (Ping timeout: 121 seconds) 03:02:40 --> FilipMosner has joined #instantbird 03:36:44 <-- FilipMosner has quit (Ping timeout: 121 seconds) 03:42:44 --> FilipMosner has joined #instantbird 04:16:47 <-- FilipMosner has quit (Ping timeout: 121 seconds) 04:22:43 --> FilipMosner has joined #instantbird 05:06:48 <-- FilipMosner has quit (Ping timeout: 121 seconds) 05:22:43 --> FilipMosner has joined #instantbird 05:56:47 <-- FilipMosner has quit (Ping timeout: 121 seconds) 06:02:44 --> FilipMosner has joined #instantbird 06:13:38 --> Bollebib has joined #instantbird 06:36:48 <-- FilipMosner has quit (Ping timeout: 121 seconds) 06:42:39 --> FilipMosner has joined #instantbird 07:00:48 <-- Bollebib has quit (Ping timeout: 121 seconds) 07:16:48 <Fallen> freaktechnik: if you are interested in taking over the 280 char bug please do. Otherwise I'll put it somewhere on my todo list. 07:47:25 --> chrisccoulson has joined #instantbird 08:25:40 <-- florian has quit (Client exited) 08:30:20 --> fredw has joined #instantbird 08:41:23 --> gerard-majax has joined #instantbird 08:52:06 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:23:09 <instantbot> New Chat Core - Twitter bug 1444040 filed by martin@humanoids.be. 09:23:11 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1444040 enh, --, ---, nobody, NEW, Fully support sending quotes 10:00:20 --> gerard-majax has joined #instantbird 10:14:40 <-- FilipMosner has quit (Ping timeout: 121 seconds) 10:22:47 --> FilipMosner has joined #instantbird 10:23:57 --> BWMerlin has joined #instantbird 10:48:02 <freaktechnik> Fallen: sure, I'll steal it from you, your todolist in patch respect is probably longer than mine ;) 10:48:25 <freaktechnik> (I wanted to file the 280 length bug on the same day you did, btw) 10:48:36 <Fallen> thanks :) I poked a hornets nest and am now refactoring all the things! 10:48:40 <Fallen> (in calendar) 10:49:20 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:58:02 --> florian has joined #instantbird 10:58:02 * ChanServ sets mode +qo florian florian 11:21:34 --> gerard-majax has joined #instantbird 11:34:20 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 11:47:54 --> clokep_tb has joined #instantbird 11:52:16 <-- clokep_tb has quit (Ping timeout: 121 seconds) 12:20:13 <-- BWMerlin has quit (Ping timeout: 121 seconds) 12:35:05 --> chrisccoulson has joined #instantbird 12:35:16 --> clokep_tb has joined #instantbird 13:36:19 <-- fredw has quit (Client exited) 14:42:09 --> fredw has joined #instantbird 14:57:40 --> WaltS48 has joined #instantbird 15:36:54 <-- clokep_tb has quit (Ping timeout: 121 seconds) 16:05:22 --> clokep_tb has joined #instantbird 16:28:37 <clokep_tb> freaktechnik: So which bugs do I need to review for you? 16:29:03 <freaktechnik> currently the twitter one is ready, and I've also fixed a shutdown warning thing that's currently r? on florian, sec. 16:29:15 <freaktechnik> (and you should have an r? on the twitter one) 16:29:36 <freaktechnik> https://bugzilla.mozilla.org/show_bug.cgi?id=1344902 is a cosmetic console fix ;) 16:29:38 <instantbot> Bug 1344902 nor, --, ---, martin, ASSI, Shutdown error: 'Method not implemented' when calling method: [imIAccount::disconnect] 16:31:32 <clokep_tb> I have too much unread bugmail! 16:31:57 <freaktechnik> is that a request to get a link to the twitter patch? 16:32:17 <freaktechnik> because that'd be https://bugzilla.mozilla.org/show_bug.cgi?id=1443933 16:32:20 <instantbot> Bug 1443933 min, --, ---, martin, ASSI, Extended tweet mentions are not expanded 16:32:25 <florian> freaktechnik: so this won't disconnect 'connecting' accounts anymore? 16:32:54 <freaktechnik> florian: no, this won't show an error while shutting down when the accounts were already partially unloaded. 16:33:00 <freaktechnik> but yeah, it wouldn't, true. 16:33:15 <florian> that sounds r- :-P 16:33:17 <freaktechnik> I wonder if checking the second part of the if would be enough, since I hadn't tried that alone, actually. 16:33:32 <freaktechnik> sure. 16:33:33 <florian> I don't have time and energy to try this patch locally in the near future :( 16:34:09 <freaktechnik> it's not really important, as it's mostly cosmetics, imo 16:34:28 <florian> I'm also annoyed by noise in the console when debugging stuff ;) 16:34:37 <florian> but why is this the unknown protocol there? 16:35:27 <freaktechnik> from what I recall the accounts get swapped to unknownaccount on shutdown, and this disconnect essentially happens too late. But I actually didn't look into it deep enough, I was pleased when finding out, that those were just shell imAccounts at shutdown... 16:36:03 <florian> "the accounts get swapped to unknownaccount on shutdown" I'm curious about the reason for doing that 16:36:14 <florian> seems pretty inefficient, shutdown should be just exiting the process ;) 16:36:47 * freaktechnik digs up knowledge he acquired from writing that dynamic accounts patch he wrote ages ago 16:37:00 <freaktechnik> (which may become more relevant again, as overlay extensions disappear) 16:38:48 <florian> ah 16:39:10 <clokep_tb> freaktechnik: So prepareForDisplaying does a bunch of logic to format the tweet, but when is displayTweet used then? 16:39:15 <florian> yeah, so I think the swapping with unknown protocols is actually something you implemented in your patch that I never reviewed :( 16:39:19 <clokep_tb> It seems odd to make that this logic is duplicated all over the place. 16:39:27 <freaktechnik> clokep_tb: you ask things asked myself too when writing the patch. 16:39:39 <clokep_tb> Hahah. 16:39:44 <clokep_tb> That code could use some comments. 16:39:50 * clokep_tb looks at floria n. 16:39:56 <florian> anyway, if this.imAccount.protocol is null, you are not dealing with the UnknownProtocol (the point of it is that it _isn't_ null)Ã 16:40:06 * florian looks at clokep_t b. 16:40:20 <-- WaltS48 has quit (Quit: Leaving) 16:40:55 <freaktechnik> ah, actually... https://dxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#637 16:41:02 <freaktechnik> delete this.protocol; 16:42:28 <freaktechnik> which happens on kQuitApplicationGranted in core. 16:44:28 <florian> sounds like you want to null check this.prplAccount 16:46:21 <florian> freaktechnik: should I put that in bugzilla? 16:46:47 <freaktechnik> you can, though I can remember it for myself, planning on updating the patch when the clock hits 18:00 ;) 16:48:22 <florian> that means in 12 minutes? 16:48:35 <freaktechnik> about, yeah 16:54:15 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 16:56:25 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:02:06 <freaktechnik> ugh, I shouldn't look at the ircv3 drafts: https://ircv3.net/specs/client-tags/reply.html 17:03:18 <freaktechnik> https://ircv3.net/specs/extensions/labeled-response.html may actually be interesting 17:12:10 --> Bollebib has joined #instantbird 17:27:52 --> gerard-majax has joined #instantbird 17:41:52 <clokep_tb> Haha. 18:09:16 <-- fredw has quit (Client exited) 18:11:17 <-- florian has quit (Client exited) 18:13:33 --> fredw has joined #instantbird 18:17:46 <freaktechnik> clokep_tb: oh, and if you still wanted to look at the 280 chars patch, I've just uploaded a new version: https://bugzilla.mozilla.org/show_bug.cgi?id=1441093 18:17:48 <instantbot> Bug 1441093 nor, --, ---, martin, ASSI, Support 280 characters in Twitter 18:17:55 <clokep_tb> Sweet 18:18:06 <freaktechnik> and that one applies for me, though no promises ;) 18:19:09 <freaktechnik> I guess this bug is a big "make it into 60" contender... 18:28:55 <-- FilipMosner has quit (Ping timeout: 121 seconds) 18:33:41 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:42:38 --> FilipMosner has joined #instantbird 18:50:17 <clokep_tb> freaktechnik: The twitter-text is just copied from their repo or whatever, right? 18:52:12 <freaktechnik> clokep_tb: there's one change, this replaced by window in the iife. Forgot to check the license before doing that, else we'd have to wrap it in an extra iife to make the this the window, unless we want it to write to the jsm this. 18:56:31 <clokep_tb> In the life? :P 18:56:44 <clokep_tb> I'm confused. 18:56:47 <clokep_tb> What's an iife? 19:14:04 <-- GeekShadow has quit (Ping timeout: 121 seconds) 19:15:07 --> GeekShadow has joined #instantbird 19:16:46 <-- FilipMosner has quit (Ping timeout: 121 seconds) 19:22:39 --> FilipMosner has joined #instantbird 19:25:01 <clokep_tb> freaktechnik: ^ 19:42:29 --> gerard-majax has joined #instantbird 20:02:33 <freaktechnik> Immediately invoke function expression, clokep_tb 20:02:46 <freaktechnik> (function() {})() 20:02:55 <clokep_tb> OK. 20:03:53 <clokep_tb> I'm not worried about that. :) 20:16:37 --> florian has joined #instantbird 20:16:37 * ChanServ sets mode +qo florian florian 20:18:13 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:25:57 --> WaltS48 has joined #instantbird 20:35:51 <-- WaltS48 has quit (Quit: Leaving) 21:38:52 --> gerard-majax has joined #instantbird 21:43:10 <-- clokep_tb has quit (Ping timeout: 121 seconds) 21:44:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 21:51:16 <-- fredw has quit (Client exited) 22:05:35 --> clokep_tb has joined #instantbird 22:31:08 <-- Bollebib has quit (Ping timeout: 121 seconds) 22:44:30 <freaktechnik> clokep_tb: should I still keep the r? on flo for the 280 chars bug, or should I request it from you? 22:44:44 <clokep_tb> I can look at it. 22:46:04 <freaktechnik> is that a "yes, r? me"? 22:46:41 <freaktechnik> (Asking because I have r= in the commit and would want to change that if I change the r?) 22:51:30 <clokep_tb> Yes, r? me 22:52:00 * freaktechnik hits submit 23:32:11 --> gerard-majax has joined #instantbird 23:43:30 <-- gerard-majax has quit (Ping timeout: 121 seconds)