All times are UTC.
00:07:55 --> clokep_tb has joined #instantbird 00:40:24 <-- FilipMosner has quit (Ping timeout: 121 seconds) 00:42:33 --> FilipMosner has joined #instantbird 00:50:01 <-- clokep_tb has quit (Ping timeout: 121 seconds) 00:52:33 --> clokep_tb has joined #instantbird 01:14:38 <-- FilipMosner has quit (Ping timeout: 121 seconds) 01:22:29 --> FilipMosner has joined #instantbird 01:24:41 <-- clokep_tb has quit (Connection closed) 01:24:43 --> clokep_tb has joined #instantbird 01:31:28 <-- Bollebib has quit (Ping timeout: 121 seconds) 01:51:37 <-- clokep_tb has quit (Ping timeout: 121 seconds) 01:56:35 <-- FilipMosner has quit (Ping timeout: 121 seconds) 01:57:13 --> clokep_tb has joined #instantbird 02:02:30 --> FilipMosner has joined #instantbird 02:36:35 <-- FilipMosner has quit (Ping timeout: 121 seconds) 02:42:30 --> FilipMosner has joined #instantbird 03:06:13 <-- clokep_tb has quit (Ping timeout: 121 seconds) 03:16:34 <-- FilipMosner has quit (Ping timeout: 121 seconds) 03:22:28 --> FilipMosner has joined #instantbird 03:56:32 <-- FilipMosner has quit (Ping timeout: 121 seconds) 04:02:35 --> FilipMosner has joined #instantbird 04:36:40 <-- FilipMosner has quit (Ping timeout: 121 seconds) 04:42:35 --> FilipMosner has joined #instantbird 05:16:39 <-- FilipMosner has quit (Ping timeout: 121 seconds) 05:22:35 --> FilipMosner has joined #instantbird 05:56:40 <-- FilipMosner has quit (Ping timeout: 121 seconds) 06:02:36 --> FilipMosner has joined #instantbird 06:36:41 <-- FilipMosner has quit (Ping timeout: 121 seconds) 06:42:35 --> FilipMosner has joined #instantbird 07:16:40 <-- FilipMosner has quit (Ping timeout: 121 seconds) 07:22:31 --> FilipMosner has joined #instantbird 07:56:35 <-- FilipMosner has quit (Ping timeout: 121 seconds) 08:02:33 --> FilipMosner has joined #instantbird 08:36:37 <-- FilipMosner has quit (Ping timeout: 121 seconds) 08:42:37 --> FilipMosner has joined #instantbird 08:49:33 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:53:28 --> fredw has joined #instantbird 09:12:24 --> Bollebib has joined #instantbird 09:16:43 <-- FilipMosner has quit (Ping timeout: 121 seconds) 09:21:53 --> BWMerlin has joined #instantbird 09:22:27 --> FilipMosner has joined #instantbird 09:56:31 <-- FilipMosner has quit (Ping timeout: 121 seconds) 09:57:50 --> gerard-majax has joined #instantbird 10:02:34 --> FilipMosner has joined #instantbird 10:10:21 <nhnt11> The conversations sidebar needs improvement 10:10:48 <nhnt11> My personal annoyance is related to using Slack's IRC gateway and having two #privacy channels in the list 10:10:51 <nhnt11> It's hard to make out which is which 10:15:03 * freaktechnik would just be happy with keyboard navigation to unread rooms >_> 10:18:16 <nhnt11> freaktechnik: I reviewed your patch ages ago but didn't submit my review comments 10:18:18 <nhnt11> I am dense 10:18:24 <nhnt11> I will submit them right now 10:18:39 <freaktechnik> yay 10:18:58 <nhnt11> freaktechnik: I think at the time, I was hesitating about the logic you were using (if I remember correctly I thought it was a little complicated) 10:19:04 <nhnt11> let me take another look quickly 10:19:57 <freaktechnik> the for loop is pretty fun, yeah, but that's due to wrap-around logic 10:29:06 <freaktechnik> ah, I just noticed an incoming nit 10:29:10 <freaktechnik> } else if ( 10:32:11 <nhnt11> (I'm going to submit this review as soon as I'm done eating, btw, stay tunedz0 10:32:20 <nhnt11> s/z0/) 10:32:43 <freaktechnik> (no rush, I'll probably get to it in like 10h or later either way...) 10:33:21 <freaktechnik> also, keyboard layout confirmed ;) 10:34:01 <nhnt11> note that I am weird and attempted to press left shift and 0 at the same time with one hand 10:44:06 <-- florian has quit (Client exited) 10:46:52 <-- gerard-majax has quit (Ping timeout: 121 seconds) 11:21:16 --> gerard-majax has joined #instantbird 11:48:26 <-- fredw has quit (Client exited) 12:27:45 <nhnt11> damn, this has been a surprisingly hard review! 12:27:46 <nhnt11> :D 12:30:03 <nhnt11> freaktechnik: I've been spending quite a bit of time pondering how we can make this function testable 12:30:20 <nhnt11> without having to initialize an entire UI 12:30:30 * nhnt11 might be overthinking this 12:30:32 <freaktechnik> (rewrite it all from the ground up >_> ) 12:30:36 <nhnt11> lol 12:31:11 <freaktechnik> wouldn't the new approach be to have some manager class that you could then test with an abstract document? 12:31:39 <nhnt11> freaktechnik: I was thinking, the function already accepts a list 12:31:49 <nhnt11> we could also just make it accept the contacts array as an argument 12:31:57 <nhnt11> which would make the logic testable 12:32:09 <nhnt11> in an xpcshell test even 12:32:19 <freaktechnik> yeah, would still need some mocking of XUL elements, but that could work. 12:32:35 <nhnt11> freaktechnik: what I was thinking was 12:32:41 <nhnt11> we can move the actual logic to its own function 12:32:49 <nhnt11> and have it basically accept a list of contacts 12:32:56 <nhnt11> and return the "next" contac 12:32:57 <nhnt11> t 12:33:04 <freaktechnik> my main question, is where would you move it? Some JSM? 12:33:07 <nhnt11> this function would be independently testable 12:33:31 <nhnt11> freaktechnik: good point, don't worry about that for now, I guess 12:33:51 <nhnt11> freaktechnik: I just think it's important to keep testability in mind as much as possible if Tb chat is to have a real futrue 12:33:53 <nhnt11> future* 12:33:53 <freaktechnik> (woah, that coma was a bit too early...) 12:33:58 <freaktechnik> agreed. 12:34:29 <nhnt11> freaktechnik: so do you think this makes sense? 12:34:47 <nhnt11> > for the sake of future testability, move the logical code to its own function 12:34:54 <freaktechnik> yes 12:34:55 <nhnt11> don't worry about actually testing it, for now, unless you find a way 12:35:19 <nhnt11> cool! 12:35:20 <freaktechnik> breaking stuff up to have as much as possible be testable as a unit (i.e. xpcshell) is a good idea imo 12:35:32 <nhnt11> thanks and sorry for the delay in reviewing this 12:35:36 <nhnt11> I've been pretty bogged down 12:38:43 * nhnt11 took a while to understand all this business with the contacts array ;) 12:47:39 <freaktechnik> yeah, a step of abstraction betwen bare XUL and finding the conversation to focus would've been nice, but alas... 12:50:34 <-- BWMerlin has quit (Ping timeout: 121 seconds) 12:59:22 --> florian has joined #instantbird 12:59:22 * ChanServ sets mode +qo florian florian 13:00:06 --> fredw has joined #instantbird 13:00:38 --> clokep_tb has joined #instantbird 13:25:15 <florian> nhnt11: I'm also annoyed by moznet and slack channels being difficult to differentiate. I was thinking doing a Slack prpl would fix it 13:30:58 <clokep_tb> florian: I think that's a long standing bug in IRC that Mook_as complained about a lot. 13:31:02 <clokep_tb> We never came up with a good way to do it. 13:32:03 * freaktechnik once suggested using favicons for protocols 13:32:26 <florian> freaktechnik: you mean for accounts, right? 13:32:33 <florian> for protocols, we already do 13:32:39 <freaktechnik> I guess instead of the protocol specific muc icon, yeah 13:32:41 <florian> that's the reason why I'm suggesting a Slack prpl actually 13:33:04 <florian> freaktechnik: we don't show the muc icon on the left side 13:33:09 <freaktechnik> right, protocols can define their own muc icon and the user conv icon is the protocol icon 13:33:12 <florian> the muc icon has 3 bubbles, the irc one has 2 13:33:24 <freaktechnik> oh, true 13:33:41 <freaktechnik> right, though that wouldn't solve being able to differentiate twitter accounts ;) 13:34:01 <freaktechnik> (yay dms from the same person on two accounts...) 13:34:33 <florian> meh, dms 13:38:20 <clokep_tb> Or two channels that are the same name on different IRC networks. 13:38:23 <clokep_tb> Which I think was Mook's issue. 13:41:34 <freaktechnik> yeah, essentially anything that is from the same provider type with the same name. 13:42:11 <freaktechnik> and then there's having buddies with the same name on multiple networks >_> 13:42:18 * freaktechnik just wanted to be friends with *status 13:46:31 <florian> I'm actually quite annoyed by the case where one ends up with 2 private conversations with the same nick 13:47:24 <florian> that happens when Nick talks to you, then changes his nick to NickAway while you are offline, then talks to you. Then changes the nick back to Nick, which renames the "NickAway" conversation to "Nick" 13:53:43 --> WaltS48 has joined #instantbird 13:59:13 <-- WaltS48 has quit (Quit: Leaving) 14:07:41 --> thrrgilag_ has joined #instantbird 14:12:33 <nhnt11> florian: yeah a prpl would help 14:12:39 <nhnt11> the icon is the point, right? 14:13:35 <florian> yes 14:24:37 --> WaltS48 has joined #instantbird 14:52:08 <-- WaltS48 has quit (Quit: Leaving) 15:01:36 --> WaltS48 has joined #instantbird 15:28:44 --> Logicoma has joined #instantbird 15:30:51 <-- fredw has quit (Client exited) 15:32:23 * WaltS48 is now known as WaltS48-away 16:03:08 <-- WaltS48-away has quit (Quit: Leaving) 16:03:54 <-- Logicoma has quit (Ping timeout: 121 seconds) 16:17:28 --> Logicoma has joined #instantbird 16:52:00 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:05:18 --> fredw has joined #instantbird 17:05:42 <-- fredw has quit (Client exited) 17:25:27 --> gerard-majax has joined #instantbird 17:36:39 <-- FilipMosner has quit (Ping timeout: 121 seconds) 17:42:27 --> FilipMosner has joined #instantbird 17:42:57 <Mook_as> A Slack prpl would (preferably) want some way to display inline media, though 17:43:16 <Mook_as> I wonder if my old one still does anything⦠never got around to making it useful 17:43:30 <-- florian has quit (Client exited) 17:45:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:55:27 <-- Mook_as has quit (Client exited) 17:56:03 --> Mook_as has joined #instantbird 18:02:25 --> mconley|livehacking has joined #instantbird 18:16:33 <-- FilipMosner has quit (Ping timeout: 121 seconds) 18:22:26 --> FilipMosner has joined #instantbird 18:28:30 --> florian has joined #instantbird 18:28:30 * ChanServ sets mode +qo florian florian 18:30:14 <nhnt11> Mook_as: yeah, I'm sure there's plenty of scope, but baby steps! 18:33:45 <Mook_as> \o/ Yeah, getting stuff to work again would be a good start. And then at least do basic formatting. 18:38:16 <nhnt11> woah, who landed new icons for chat toolbar buttons? 18:38:35 <nhnt11> (these buttons should really have tooltips, btw) 18:39:29 * nhnt11 has too many things he wants to do 18:56:33 <-- FilipMosner has quit (Ping timeout: 121 seconds) 19:02:28 --> FilipMosner has joined #instantbird 19:30:55 <-- mconley|livehacking has quit (Quit: NO CARRIER) 19:36:34 <-- FilipMosner has quit (Ping timeout: 121 seconds) 19:42:34 --> FilipMosner has joined #instantbird 19:44:27 * freaktechnik hosts a rebasing party 19:50:43 --> gerard-majax has joined #instantbird 20:16:39 <-- FilipMosner has quit (Ping timeout: 121 seconds) 20:22:03 <freaktechnik> oh no, I don't have comm-central on this machine D: 20:22:26 --> FilipMosner has joined #instantbird 20:23:16 <freaktechnik> oh right, there's clone bundles now :D 21:07:51 <-- Logicoma has quit (Connection closed) 21:29:36 <-- gerard-majax has quit (Ping timeout: 121 seconds) 21:30:12 <-- clokep_tb has quit (Ping timeout: 121 seconds) 22:38:26 --> clokep_tb has joined #instantbird 23:34:02 <freaktechnik> as a for the record thing: https://public.etherpad-mozilla.org/p/chat-webext 23:34:17 <-- clokep_tb has quit (Ping timeout: 121 seconds) 23:39:50 --> clokep_tb has joined #instantbird 23:45:32 <-- Bollebib has quit (Ping timeout: 121 seconds) 23:47:29 * freaktechnik notes that the providers API is missing a lot of things in the declaration (can change topic etc), a way to add and remove participants, display system messages (that maybe shouldn't be provider specific? and start conversations with non-buddies. 23:52:44 <nhnt11> freaktechnik: did you create this document and its content? 23:53:15 <nhnt11> (++, thanks for spending those passive brain resources :)) 23:54:08 <freaktechnik> Yes, it's essentially writing down what I've been rambling about once already (me and clokep talked about some stuff, is what I remember...) 23:54:59 * nhnt11 has to go to bed but will keep it open in a tab for perusing tomorrow 23:55:02 <nhnt11> bye for now!