#instantbird log on 10 30 2017

All times are UTC.

01:26:00 <-- Bollebib has quit (Ping timeout: 121 seconds)
01:30:42 <-- GeekShadow has quit (Ping timeout: 121 seconds)
01:40:36 <florian> nhnt11: you've got a mix of 4-spaces and 2-spaces indent on that chat.css file
01:53:44 --> GeekShadow has joined #instantbird
02:12:41 <nhnt11> I do?
02:13:06 <nhnt11> oh
02:13:10 <nhnt11> yeah sorry about that
02:13:14 <nhnt11> I copy pasted from my userChrome.css
02:13:26 <nhnt11> those rules will probably need to be refined
02:14:08 * nhnt11 fixed it locally
03:51:46 <-- bgmCoder has quit (Ping timeout: 121 seconds)
04:26:21 <-- GeekShadow has quit (Ping timeout: 121 seconds)
04:28:22 --> GeekShadow has joined #instantbird
05:23:13 <-- spiffytech has quit (Ping timeout: 121 seconds)
05:27:46 --> spiffytech has joined #instantbird
08:28:34 --> fredw has joined #instantbird
08:33:27 --> Bollebib has joined #instantbird
09:01:27 --> chrisccoulson has joined #instantbird
09:17:04 --> gerard-majax has joined #instantbird
09:55:17 <-- fredw has quit (Ping timeout: 121 seconds)
10:01:26 --> fredw has joined #instantbird
10:08:35 <-- fredw has quit (Client exited)
10:28:25 <-- florian has quit (Client exited)
10:47:58 --> BWMerlin has joined #instantbird
11:29:58 <-- GeekShadow has quit (Ping timeout: 121 seconds)
11:31:03 --> florian has joined #instantbird
11:31:03 * ChanServ sets mode +qo florian florian 
11:32:27 --> GeekShadow has joined #instantbird
11:55:33 --> clokep_tb has joined #instantbird
12:28:24 * florian wonders if clokep_tb has thoughts about bug 1412710
12:28:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1412710 nor, --, ---, nobody, NEW, Implement a chat-only-mode for users that primarily use Thunderbird for chat
12:43:34 <clokep_tb> I saw the email, but hadn't read it yet.
12:44:16 <-- BWMerlin has quit (Ping timeout: 121 seconds)
12:44:53 <clokep_tb> florian, nhnt11: Seems vaguely reasonable.
12:45:01 <clokep_tb> Do we have thoughts on what other Thunderbird people will think?
13:15:03 <florian> that was mostly what my question is about
13:15:14 <florian> is it acceptable to other TB people, and is it presented correctly to be acceptable
13:15:38 <florian> I think overall it should be acceptable, but we should likely put some more guards on it
13:16:00 <florian> which I assume nhnt11 is planning to do anyway and is the reason for requesting f? rather than r?
13:27:28 --> bgmCoder has joined #instantbird
13:33:20 --> fredw has joined #instantbird
13:46:08 <clokep_tb> Right.
13:46:19 <clokep_tb> I mean I *think* it would be acceptable? It doesn't touch any other code.
13:51:08 <-- florian has quit (Ping timeout: 121 seconds)
13:51:33 --> florian has joined #instantbird
13:51:33 * ChanServ sets mode +qo florian florian 
13:55:40 <-- florian has quit (Ping timeout: 121 seconds)
13:56:05 --> florian has joined #instantbird
13:56:05 * ChanServ sets mode +qo florian florian 
14:07:48 <nhnt11> florian: right, I wanted f? on the general technical approach of the patch
14:08:12 <nhnt11> and in general as a solicitation for your ideas/comments on this
14:08:59 <florian> I'll request that we try harder to never get in the way of someone who may be using TB for email
14:09:21 <nhnt11> yup
14:09:23 <nhnt11> that makes sense
14:09:23 <florian> eg. I'm not sure we should persist the chat-only mode if someone has email accounts configured
14:09:29 <nhnt11> that's a good idea, yeah
14:09:44 <nhnt11> florian: could you please put these thoughts in the bug?
14:09:49 <florian> I will
14:09:49 <nhnt11> I'm afraid I'll forget
14:09:51 <nhnt11> thanks!
14:10:10 <florian> but I'll try to also give some comments about what's in the patch ;)
14:10:11 <nhnt11> florian: we could even just make it a pref
14:10:18 <nhnt11> that's false by default
14:10:19 <florian> I mean, something more thoughtful than "the intend  is a mess in the css file" ;)
14:10:32 <nhnt11> :P
14:10:37 <florian> yeah, sounds nicer. Doesn't require messing with the persist attribute in non-chat code :)
14:11:15 <nhnt11> yeah
14:11:53 <florian> Maybe the button should say something like "Show/Hide email tab"
14:12:06 <florian> in the future I would like us to re-implement the /about command to open eg. about:memory
14:12:15 <florian> I think opening about:memory should unhide the tab bar automatically
14:12:17 <nhnt11> I saw the bug for that
14:12:36 <florian> the keyboard shortcut to switch tab should also unhide the tab bar
14:12:48 <nhnt11> florian: we could make it so that the tab bar is only hidden when the chat tab is selected
14:13:03 <nhnt11> to iterate on that:
14:13:11 <nhnt11> disable chat-only-mode when switching away from the chat tab
14:13:14 <florian> selected and the only tab (except for the first default one)
14:13:45 <florian> I think we'll manage to get something nice that doesn't get in anybody's way :)
14:13:50 <nhnt11> yeah
14:14:10 <nhnt11> florian: the toolbar button is already not a default one, in my patch
14:14:16 <nhnt11> you have to manually add it to the toolbar
14:14:23 <florian> oh
14:14:30 <nhnt11> I'm not sure what we want to do there
14:14:39 <florian> wouldn't we want it in the chat toolbar by default once the thing is polished enough?
14:14:43 <nhnt11> yeah
14:14:44 <nhnt11> I'd say so
14:15:00 <florian> not putting it by default is a nice way to experiment quietly for a little while
14:15:11 <nhnt11> florian: we could even expose the pref in the Chat preference pane
14:15:13 <freaktechnik> is there a bug for a keyboard shortcut to switch conversations?
14:15:16 <nhnt11> the persist-pref I mean
14:15:23 <nhnt11> freaktechnik: Cmd+Up/Down
14:15:28 <freaktechnik> ooh
14:15:49 <florian> freaktechnik: I'm not aware of any such bug :)
14:16:01 <freaktechnik> is there one to go through unreads, like ctrl + shift + up/down?
14:16:21 <freaktechnik> because right now shift doesn't seem to do anything, so it going to the next unread would be a+
14:19:12 * Fallen is now known as Fallen|pto 
14:19:31 <nhnt11> freaktechnik: good idea, could you file a bug? :)
14:21:04 <florian> freaktechnik: I vaguely remember writing code to go to the next unread, but I can't remember the details
14:21:18 * freaktechnik takes a look on dxr
14:21:29 <florian> that was way too long ago :(
14:21:38 <florian> (I wrote the TB chat UI in 2011-2012)
14:23:55 <freaktechnik> probably for the auto focus of the first unread conv?
14:24:38 <nhnt11> I don't expect it'd be too hard to write a patch for thsi
14:24:40 <nhnt11> this*
14:24:41 <freaktechnik> -> https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#865
14:24:46 <freaktechnik> yeah, should be quite simple
14:24:56 <freaktechnik> key handler is https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#1128
14:28:22 <freaktechnik> -> https://bugzilla.mozilla.org/show_bug.cgi?id=1412843
14:28:24 <instantbot> Bug 1412843 enh, --, ---, martin, ASSI, Shortcut to switch through unread conversations
14:28:34 <nhnt11> thanks!
14:29:16 <freaktechnik> time to update my ancient c-c clone
14:30:23 <freaktechnik> who should I r? it to? nhnt11 or florian?
14:30:45 <nhnt11> freaktechnik: you can r? me
14:34:03 <-- florian has quit (Client exited)
14:56:54 --> florian has joined #instantbird
14:56:54 * ChanServ sets mode +qo florian florian 
15:08:50 --> WaltS48 has joined #instantbird
15:09:10 <-- WaltS48 has quit (Quit: Off to use Linux)
16:09:18 --> WaltS48 has joined #instantbird
16:37:13 * WaltS48 is now known as WaltS48-laundry 
16:42:39 <-- mook_as has quit (Quit: )
16:43:15 <-- fredw has quit (Client exited)
16:43:55 --> mook_as has joined #instantbird
17:22:05 <freaktechnik> (turns out updating my c-c is not that simple)
17:28:12 <clokep_tb> freaktechnik: Don't forget to pull m-c?
17:28:23 <freaktechnik> that's the problem...
17:28:37 <freaktechnik> so many changes and something isn't really working when updating, so trying to fix that \o/
17:29:00 <freaktechnik> (also, I use client.py to checkout, well, at least try to)
18:30:13 * nhnt11 also uses client.py
18:30:16 <nhnt11> is there another way?
18:30:25 <nhnt11> (cd mozilla && hg pull?)
18:33:02 <clokep_tb> client.py is the right way. :)
18:33:09 <clokep_tb> It pulls more than just the one repo.
18:42:17 <freaktechnik> so rm -rf mozilla and re-clienting is the solution it seems :( m-c isn't getting smaller...
18:50:45 <florian> we should talk again about merging c-c into m-c :-P
18:51:07 <nhnt11> lol
19:02:22 <freaktechnik> when IB's gone from C-C the worries of adding more stuff to m-c are surely lower...
19:11:10 <-- WaltS48-laundry has quit (Quit: Leaving)
19:17:43 <florian> freaktechnik: there's still suite/
19:18:08 <freaktechnik> I know, I wasn't entirely serious.
19:36:03 <-- chrisccoulson has quit (Connection closed)
19:41:46 --> Logicoma has joined #instantbird
19:46:09 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:08:11 --> chrisccoulson has joined #instantbird
20:28:02 <-- Logicoma has quit (Connection closed)
20:39:01 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:41:08 <-- clokep_tb has quit (Ping timeout: 121 seconds)
20:48:11 --> chrisccoulson has joined #instantbird
20:52:47 --> gerard-majax has joined #instantbird
21:19:11 --> clokep_tb has joined #instantbird
21:37:02 <-- clokep_tb has quit (Ping timeout: 121 seconds)
21:56:39 --> clokep_tb has joined #instantbird
22:35:23 <-- clokep_tb has quit (Ping timeout: 121 seconds)
22:43:24 <-- gerard-majax has quit (Quit: Leaving)