#instantbird log on 03 27 2017

All times are UTC.

00:09:54 --> Alex has joined #instantbird
00:29:21 <-- Bollebib has quit (Ping timeout: 121 seconds)
02:10:11 <instant-buildbot> build #1020 of linux64-nightly-default is complete: Failure [4failed hg]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/1020
02:30:31 <-- florian has quit (Ping timeout: 121 seconds)
02:30:45 --> florian has joined #instantbird
02:30:45 * ChanServ sets mode +qo florian florian 
02:49:57 --> cha-cha has joined #instantbird
03:30:24 <instant-buildbot> build #3499 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3499
04:16:52 --> jsgrant has joined #instantbird
04:44:37 <-- bgmCoder has quit (Ping timeout: 121 seconds)
05:04:15 <-- EionRobb has quit (Quit: Leaving.)
05:19:06 <-- cha-cha has quit (Ping timeout: 121 seconds)
05:23:45 --> EionRobb has joined #instantbird
07:41:49 <-- matrixisreal has quit (Quit: Connection closed for inactivity)
08:25:43 <-- Jackneill has quit (Quit: Leaving)
08:39:31 --> Bollebib has joined #instantbird
08:39:31 --> fredw has joined #instantbird
08:53:43 <-- Bollebib has quit (Ping timeout: 121 seconds)
08:57:09 <-- fredw has quit (Client exited)
09:16:39 --> fredw has joined #instantbird
09:16:54 --> BWMerlin has joined #instantbird
09:34:03 <-- Alex has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
09:55:09 --> gerard-majax has joined #instantbird
09:55:37 <-- gerard-majax has quit (Quit: Leaving)
09:55:49 --> gerard-majax has joined #instantbird
09:57:07 --> Bollebib has joined #instantbird
09:57:23 <-- EionRobb has quit (Quit: Leaving.)
10:01:09 --> EionRobb has joined #instantbird
10:19:09 <-- EionRobb has quit (Quit: Leaving.)
10:19:24 --> EionRobb has joined #instantbird
10:54:35 <-- fredw has quit (Client exited)
11:02:16 <-- florian has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:11:59 --> clokep_work has joined #instantbird
11:11:59 * ChanServ sets mode +o clokep_work 
11:36:10 <-- clokep_work has quit (Ping timeout: 121 seconds)
11:51:01 --> fredw has joined #instantbird
12:11:18 <-- BWMerlin has quit (Ping timeout: 121 seconds)
12:21:57 --> mpmc has joined #instantbird
12:28:20 --> matrixisreal has joined #instantbird
12:37:21 --> clokep_work has joined #instantbird
12:37:21 * ChanServ sets mode +o clokep_work 
13:33:17 --> bgmCoder has joined #instantbird
13:33:36 <clokep_work> matrixisreal: Did you have a question yesterday?
14:16:16 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:16:22 --> clokep_work has joined #instantbird
14:16:22 * ChanServ sets mode +o clokep_work 
14:22:32 <matrixisreal> clokep_work: Oh.. That was about Implementing Seen Receipts..
14:22:53 <clokep_work> matrixisreal: What about it? :)
14:24:12 <matrixisreal> It was just about wheteher its already there or not.you have answered it in the mail. Anyways, I'm pretty much finished with my proposal, I'll send you this evening if you are free..
14:24:49 <matrixisreal> I would like to further discuss and resolve Some parts of it though..
14:29:04 <matrixisreal> One of which is Handling invites..  
14:30:23 <matrixisreal> Here's a bit of context from my proposal.. 
14:30:40 <matrixisreal> https://www.irccloud.com/pastebin/z9Rv0Bqg/Invites
14:31:52 <matrixisreal> The question is "Any suggestions on making this more Riot like?"
14:32:20 <matrixisreal> clokep_work, nhnt11 
14:32:43 <clokep_work> Cool.
14:32:59 <clokep_work> matrixisreal: What about invites?
14:33:16 <clokep_work> So that matches how we do IRC, yes.
14:35:15 <matrixisreal> I was just hoping to make it more Riot like,  Ex: By giving options to users whether ro accept or decline before starting the conversation.
14:35:56 <matrixisreal> I dont know if this behavior is wanted, I too just thought keeping it IRC like would be better..
14:59:13 <matrixisreal> clokep_work : Also see this. https://www.irccloud.com/pastebin/fs5PpFfx/Seen%20Receipt%20for%20Messages%20
15:07:27 <matrixisreal> clokep_work: This should be easy I suppose, Let me know if you find any complications.
15:52:59 <clokep_work> matrixisreal: That's wanted, I think there's a bug for it.
15:53:13 <clokep_work> It would be kind of separate from Matrix though -- it would need to be protocol agnostic.
15:53:21 <clokep_work> It's just uilding some UI and hooking the protocols up to it.
15:53:45 <clokep_work> matrixisreal: That plan for read receipts sounds vaguely sane.
15:56:21 <matrixisreal> clokep_work: How hard would Building the UI for this be ?
15:56:55 <clokep_work> matrixisreal: Not terrible. I think you'd want to open a new conversation tab that says "You've been invited to this conversation" (but without actually joining the conversation), then have buttons for "Accept" or "Reject".
15:57:01 <clokep_work> Did you check Bugzilla?
15:57:45 <matrixisreal> clokep_work: check Bugzilla for what..
15:57:57 <matrixisreal> send receipts /
15:58:19 <matrixisreal> *?
16:00:43 <clokep_work> matrixisreal: Invitations.
16:03:47 <matrixisreal> clokep_work: This  : https://bugzilla.mozilla.org/show_bug.cgi?id=954059  ?
16:03:49 <instantbot> Bug 954059 nor, --, ---, nobody, NEW, Auto-Join option field is hard coded for certain protocols
16:04:01 <clokep_work> Nope.
16:04:09 <clokep_work> Doesn't seem to be a bug about adding UI for invitations, which surprisees me.
16:04:16 <clokep_work> But I think I just gave you a decent gist of what to do. :)
16:07:37 <matrixisreal> clokep_work: Is there any similar UI implementation, to estimate how much time this might take. 
16:08:21 <clokep_work> Hmm.... nhnt11 any idea how hard it would be to do a custom tab like that?
16:08:43 * nhnt11 reads
16:09:40 * nhnt11 is a bit confused by "custom tab"
16:09:51 <nhnt11> I'm in a meeting, br
16:09:52 <nhnt11> brb
16:10:57 <matrixisreal> Sure :)
16:21:45 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:25:39 <clokep_work> nhnt11: Tabs that aren't conversation tabs. :)
16:33:07 <nhnt11> clokep_work: yeah, I thought this was about seen reports
16:33:22 * nhnt11 missed a message
16:33:24 <clokep_work> nhnt11: We're confusingly discussing botha t once. ;)
16:33:45 <nhnt11> it's very easy to make a custom tab
16:33:46 <nhnt11> :)
16:34:02 <nhnt11> we have a few examples of using that api in the codebase
16:34:18 <nhnt11> the new conversation tab of course, and also the about tab
16:34:37 <nhnt11> the latter should probably be a simpler example that can easily be adapted to what you need
16:36:34 <nhnt11> (see https://dxr.mozilla.org/comm-central/source/im/content/aboutPanel.xml and https://dxr.mozilla.org/comm-central/source/im/modules/ibCore.jsm#119)
16:37:13 <nhnt11> I'd expect you to use https://dxr.mozilla.org/comm-central/source/im/modules/ibCore.jsm#201
16:40:14 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:58:30 <matrixisreal> nhnt11: Looks Good :) . What do you think about my design of seen receipts. Is firing seen message on switching the focus to a conversation a good idea? 
17:03:54 <freaktechnik> hmm, I guess I should open a bug about the removal of the add-ons manager as window against instantbird, or is that already filed?
17:15:48 --> Logicoma has joined #instantbird
17:21:46 <-- fredw has quit (Client exited)
17:31:55 --> jsgrant- has joined #instantbird
17:33:06 <-- jsgrant has quit (Ping timeout: 121 seconds)
17:33:16 <-- jsgrant-_ has quit (Ping timeout: 121 seconds)
17:36:14 <clokep_work> freaktechnik: We didn't file that.
17:40:37 <freaktechnik> hmm, is that a depends or blocks? PRobably depends?
17:40:46 <freaktechnik> or just see also
17:44:00 <clokep_work> Depends is fine.
17:44:25 <instantbot> New Instantbird - Other bug 1350992 filed by martin@humanoids.be.
17:44:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1350992 maj, --, ---, nobody, NEW, Move add-on manager to tab
17:44:46 <freaktechnik> see also'd it, feel free to change to dep
17:45:01 <freaktechnik> also just noticed I didn't state anything about how to solve the issue in the actual description >_>
18:36:12 <-- EionRobb has quit (Quit: Leaving.)
18:37:22 <nhnt11> matrixisreal: We have an "unread ruler" that marks where new "unread" messages start in the conversation
18:37:44 <nhnt11> it disappears when the user switches tabs, as long as the tab with the unread messages has been focused for a while
18:38:09 <nhnt11> I don't remember the exact amount of time we wait, but you should be able to reuse some of that code
18:38:23 <nhnt11> at the very least, the timeout should be reused
18:38:49 <nhnt11> the reason we have a small delay/timeout is so that if the user is quickly scrolling through multiple tabs, we don't mark all of them unread 
18:38:53 <nhnt11> all of them read*
18:39:55 <nhnt11> you'll also want to investigate including "seen" timestamps in the metadata of each message when we write it to a log file
18:40:33 <nhnt11> (if we care about that data being available when the user views their logs. I don't see why we shouldn't)
18:40:54 <nhnt11> I mean, I think we should include the seen timestamps in logs.
18:41:17 <clokep_work> It porbbaly just needs to send an event from the UI to the protocol.
18:41:25 <clokep_work> Which seems reasonable.
18:41:28 <nhnt11> yup
18:41:44 <nhnt11> I'm just saying we already have a likely code point from which to generate the event :)
18:42:38 <nhnt11> btw, introducing "seen" timestamps might also require tweaking of our message themes
18:43:05 <nhnt11> I think a very good first step would be to implement "seen" timestamps as a tooltip
18:43:06 <matrixisreal> nhnt11: Yeah, and how tricky is that ?
18:43:22 <nhnt11> and then debate about how we want to make them work with grouped message bubbles and so on
18:43:45 <nhnt11> matrixisreal: what do you think about tooltips?
18:44:06 <nhnt11> the tooltip of a message currently displays the time at which it was sent
18:44:18 <nhnt11> we can easily modify it to also show the time at which it was "seen"
18:45:16 <nhnt11> there are more possibilities, of course
18:45:21 <matrixisreal> Yeah, it would definitely be easy, but I think adding it to the message theme would be more usual
18:45:31 <matrixisreal> which most of the other clients do..
18:45:36 <nhnt11> for example, I think Facebook messenger shows a marker after the last message that a participant has seen
18:46:00 <nhnt11> we could do something like that. maybe something similar to a time bubble, that says "so and so has read up till here"
18:46:30 <nhnt11> matrixisreal: Implementing the tooltip solution in my opinion should be first, because that will give you a simple UI to test the protocol side feature
18:46:56 <nhnt11> UI historically takes time to brainstorm/design/develop/iterate/whatever
18:47:41 <nhnt11> btw, when I say tooltip solution I'm not actually attached to tooltips. I just mean a very quick and easy UI solution, if such a thing exists, can be landed first.
18:49:31 <matrixisreal> Yeah, I got it.
18:49:32 <matrixisreal> So I'll keep adding this as a tooltip as a first target.
18:49:53 <nhnt11> sure, if you agree that it's a good quick and easy solution :)
18:50:08 <nhnt11> (maybe it's not! I haven't looked at that code)
18:50:12 <nhnt11> but I think it should be.
18:51:00 --> gerard-majax has joined #instantbird
18:56:19 <matrixisreal> nhnt11: What do you think about the next target, I mean a better way of doing the same.
18:57:14 <nhnt11> well, for now you should come up with ideas and note them down
18:57:46 <matrixisreal> Doing this in tooltip is easy but its not intuitive to the users, especially it becomes difficult if the lase seen message is some where in the middle.. any ideas abt this..?
18:57:48 <nhnt11> Maybe think of some pros and cons for each one, to help with the decision later
18:58:04 <nhnt11> yeah, it's not intuitive
18:58:11 <nhnt11> I don't think users should see this
18:58:15 <nhnt11> I mean
18:58:33 <nhnt11> We should implement a "real" UI for it
18:58:38 <nhnt11> before we advertise it to users
18:59:24 <nhnt11> Er
18:59:29 <nhnt11> To put it in a very different way
18:59:40 <nhnt11> I never intended the tooltip as something that is good for users
18:59:54 <nhnt11> It's just good for us, to test the backend feature in nightly builds etc
19:00:47 <nhnt11> "especially it becomes difficult if the lase seen message is some where in the middle" I don't think this is a big deal
19:01:03 <nhnt11> If the other party has sent you a message, you can be pretty sure they read all the messages above that
19:01:23 <nhnt11> so you only have to worry about the last block of messages you've sent
19:01:43 <nhnt11> there shouldn't be a huge number of those, unless you keep sending someone messages even if they never reply
19:01:45 <nhnt11> ;)
19:02:51 <nhnt11> But I do agree that it would be nice to have a UI feature that would allow you to see how far the other party has seen your messages with a quick glance
19:03:44 <matrixisreal> Yea :P  . Well, so according to my schedule  I might spend around 2 weeks on this, So do you think  implementing a "real" UI for this would fit in... ?
19:03:52 <matrixisreal> I don't think so..
19:03:54 * nhnt11 doesn't know
19:04:00 <nhnt11> we can see how it goes
19:04:11 <nhnt11> things can vary
19:05:34 <matrixisreal> Cool.
19:16:24 <clokep_work> matrixisreal: Do your best to estimate.
19:18:04 --> florian has joined #instantbird
19:18:04 * ChanServ sets mode +qo florian florian 
19:28:06 <clokep_work> It doesn't need to be exact though.
19:37:53 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:44:54 --> EionRobb has joined #instantbird
19:54:07 --> gerard-majax has joined #instantbird
20:02:29 --> unghost has joined #instantbird
20:09:25 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:19:22 <-- Logicoma has quit (Connection closed)
20:23:24 --> gerard-majax has joined #instantbird
20:36:52 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
20:37:10 --> Bollebib has joined #instantbird
21:04:33 <-- clokep_work has quit (Ping timeout: 121 seconds)
21:17:32 <-- gerard-majax has quit (Ping timeout: 121 seconds)
22:04:01 <-- florian has quit (Connection closed)
22:04:05 --> flo has joined #instantbird
22:04:05 * ChanServ sets mode +qo flo flo 
22:06:28 * flo is now known as florian 
22:28:40 <-- unghost has quit (A TLS packet with unexpected length was received.)
22:51:50 <-- matrixisreal has quit (Quit: Connection closed for inactivity)
23:57:23 --> DGMurdockIII has joined #instantbird