#instantbird log on 02 20 2017

All times are UTC.

00:08:18 <-- freaktechnik has quit (Ping timeout: 121 seconds)
00:11:29 --> Alex1 has joined #instantbird
00:13:49 --> freaktechnik has joined #instantbird
01:27:12 <-- Bollebib has quit (Ping timeout: 121 seconds)
02:31:35 <-- matrixisreal has quit (Quit: Connection closed for inactivity)
03:14:41 <instant-buildbot> build #3462 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3462
04:32:16 <-- EionRobb has quit (Quit: Leaving.)
05:38:24 --> EionRobb has joined #instantbird
06:38:21 <instant-buildbot> build #983 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/983
08:35:04 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:52:51 --> fredw has joined #instantbird
09:11:52 --> Bollebib has joined #instantbird
09:17:32 --> gerard-majax has joined #instantbird
09:21:05 <-- FilipMosner has quit (Connection closed)
09:31:34 <-- gerard-majax has quit (Quit: Leaving)
09:32:17 --> gerard-majax has joined #instantbird
09:38:37 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:39:49 --> gerard-majax has joined #instantbird
09:45:03 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:45:36 --> gerard-majax has joined #instantbird
09:53:06 <-- gerard-majax has quit (Quit: Leaving)
09:53:54 --> gerard-majax has joined #instantbird
10:02:52 <-- Alex1 has quit (Connection closed)
10:07:37 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:46:54 --> gerard-majax has joined #instantbird
10:47:12 --> flo-retina has joined #instantbird
10:47:12 * ChanServ sets mode +qo flo-retina flo-retina 
10:47:36 <-- Bollebib has quit (Connection closed)
10:52:06 --> FilipMosner has joined #instantbird
10:59:55 <-- dx has quit (Quit: leaving)
11:24:29 --> dx has joined #instantbird
11:52:38 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:52:58 --> flo-retina has joined #instantbird
11:52:58 * ChanServ sets mode +qo flo-retina flo-retina 
11:59:50 <-- fredw has quit (Client exited)
13:05:42 --> fredw has joined #instantbird
14:27:19 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:03:24 --> flo-retina has joined #instantbird
15:03:24 * ChanServ sets mode +qo flo-retina flo-retina 
16:18:24 <-- fredw has quit (Client exited)
16:58:45 --> matrixisreal has joined #instantbird
17:00:16 --> Bollebib has joined #instantbird
17:02:27 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:05:53 --> fredw has joined #instantbird
17:31:37 <-- Mook_as has quit (Client exited)
17:36:32 --> Mook_as has joined #instantbird
17:42:16 --> gerard-majax has joined #instantbird
17:49:40 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:53:01 --> gerard-majax has joined #instantbird
17:54:30 <-- fredw has quit (Client exited)
18:37:22 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:52:15 --> unghost has joined #instantbird
19:04:18 <-- EionRobb has quit (Quit: Leaving.)
19:16:24 <matrixisreal> Hi, need some help in writing tests to this bug, bug 1105728
19:16:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105728 nor, --, ---, nobody, NEW, IRC /umode doesn't set user mode
19:19:53 <matrixisreal> I get that I need to run the run() of umode command in irccommands.jsm
19:21:15 <matrixisreal> But I dont see the entry point and what all (proto, account ,conv) I need to initialize beforehand.
19:34:41 --> Logicoma has joined #instantbird
19:35:47 --> newdev has joined #instantbird
19:36:00 <newdev> Hello?
19:36:27 <freaktechnik> matrixisreal: entrypoint to the test?
19:36:43 <freaktechnik> or how ircCommands.jsm gets used?
19:36:47 <newdev> I am a new to open source
19:36:51 <freaktechnik> hi
19:37:09 <newdev> How can I contribute to mozilla if I know some C++?
19:37:45 <newdev> :s
19:38:04 <-- newdev has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:40:26 --> gerard-majax has joined #instantbird
19:40:27 <matrixisreal> freaktechnik: entry pt to irccommands
19:41:02 <freaktechnik> matrixisreal: the commands are registered somewhere in the depths of irc.js. And the handlers will also be called from there (well, dispatched to them)
19:41:39 <matrixisreal> How exactly do I get to run them
19:42:34 <matrixisreal> I spent a lot of time trying to read other tests, but couldn't figureout
19:42:34 --> EionRobb has joined #instantbird
19:43:11 <freaktechnik> give me a sec, I'm a little rusty... been working with other code recently
19:43:25 <matrixisreal> Sure
19:43:40 <freaktechnik> If you just want to test the handler itself you'd probably want to just call the method itself
19:44:45 <freaktechnik> oh right, I remember, commands are hidden away pretty well ;)
19:46:45 <freaktechnik> so they get registered to this component: https://dxr.mozilla.org/comm-central/source/chat/components/src/imCommands.js
19:47:00 <freaktechnik> and then executeCommand "executes" it
19:47:34 <freaktechnik> which happens in the "view": https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#284
19:47:54 <freaktechnik> matrixisreal: I hope that helps you a little. So yeah, directly calling the run function is probably easiest
19:48:51 <matrixisreal> How to call run of umode in tests?
19:49:15 <freaktechnik> oh wait
19:49:25 <freaktechnik> I forgot it registers them to the service
19:49:36 <matrixisreal> Yea
19:49:43 <freaktechnik> so you'd have to create the service and then use executeCommand
19:50:13 <freaktechnik> oh, and I totally linked the wrong file for the commands component, sorry
19:50:21 <freaktechnik> oh, I didnt'
19:50:25 <freaktechnik> >_>
19:51:13 <freaktechnik> so they're not directly registerd. What you'd do is get the "commands" variable from the JSM and then search for the command, I guess.
19:51:55 <freaktechnik> (I guess it's also an assertion that "unmode" is in the array of commands exported by the JSM)
19:54:51 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:56:49 <matrixisreal> freaktechnik: thanks I'll try it out
19:57:38 <freaktechnik> given that it's an O(n) operation in the worst case if you cache the result that seems pretty reasonable
20:01:37 <matrixisreal> Yup, I thought of this but again felt that its a bit hacky
20:33:43 --> fredw has joined #instantbird
20:33:50 <-- fredw has quit (Client exited)
21:11:36 <-- Logicoma has quit (Connection closed)
22:42:39 --> DGMurdockIII has joined #instantbird
23:11:35 <-- matrixisreal has quit (Quit: Connection closed for inactivity)
23:19:50 <-- unghost has quit (A TLS packet with unexpected length was received.)
23:44:08 <-- freaktechnik has quit (Ping timeout: 121 seconds)
23:44:18 --> freaktechnik has joined #instantbird