#instantbird log on 01 17 2017

All times are UTC.

00:24:01 <-- Bollebib has quit (Ping timeout: 121 seconds)
01:04:34 <-- freaktechnik has quit (Ping timeout: 121 seconds)
01:09:41 --> freaktechnik has joined #instantbird
01:21:59 <-- EionRobb has quit (Quit: Leaving.)
02:20:33 --> EionRobb has joined #instantbird
03:12:31 <instant-buildbot> build #949 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/949
03:15:29 <instant-buildbot> build #3428 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3428
03:53:27 <-- EionRobb has quit (Quit: Leaving.)
04:46:18 <-- bgmCoder has quit (Connection closed)
06:23:23 --> qheaden has joined #instantbird
07:48:38 --> Alex has joined #instantbird
08:20:46 --> gerard-majax has joined #instantbird
08:30:22 --> fredw has joined #instantbird
08:50:46 <Fallen> flo-retina: ok, sorry. Which one?
09:14:59 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:15:13 --> gerard-majax has joined #instantbird
09:15:47 --> Bollebib has joined #instantbird
10:04:41 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:24:04 <-- Alex has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:24:12 --> Alex has joined #instantbird
10:25:49 <-- Alex has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:31:00 --> flo-retina has joined #instantbird
10:31:00 * ChanServ sets mode +qo flo-retina flo-retina 
10:35:23 --> mpmc has joined #instantbird
10:42:26 --> BWMerlin has joined #instantbird
11:38:03 <-- fredw has quit (Client exited)
12:00:28 --> EionRobb has joined #instantbird
12:16:38 <-- BWMerlin has quit (Ping timeout: 121 seconds)
12:30:27 <not-freaktechnik> Who wants to r? https://bugzilla.mozilla.org/show_bug.cgi?id=1302537
12:30:30 <instantbot> Bug 1302537 min, --, ---, nobody, NEW, Default time stamp should just forget about ms
12:31:17 <not-freaktechnik> (though it is not even confirmed, but I created the bug after discussion with  clokep)
12:39:28 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:42:06 --> clokep has joined #instantbird
12:42:06 * ChanServ sets mode +o clokep 
12:42:26 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:48:56 <flo-retina> not-freaktechnik: maybe you do? :)
12:59:47 <not-freaktechnik> If I'd feel comfortable reviewing it I'd probably have created the patch myself. Bjt I do not feel like I understand the implications of the change fully. I know it makes timestamps in the ui show the right second but that's about it.
13:01:26 <-- bittin_ has quit (Connection closed)
13:33:09 --> clokep_work has joined #instantbird
13:33:10 * ChanServ sets mode +o clokep_work 
13:34:02 --> mpmc has joined #instantbird
13:36:28 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:03:56 --> flo-retina has joined #instantbird
14:03:56 * ChanServ sets mode +qo flo-retina flo-retina 
14:08:57 <clokep_work> freaktechnik, flo-retina: I think flooring that is fine?
14:09:01 <clokep_work> Do you have any strong thoughts?
14:09:08 <flo-retina> looks ok to me
14:09:15 <flo-retina> I don't mind either way
14:09:39 <flo-retina> what's important to look at in the review is mostly ensuring whatever we do is consistent across all of chat/
14:19:01 <clokep_work> Right.
14:19:05 <clokep_work> I don't think we play with time like that...
14:23:36 <qheaden> Hi all.
14:24:02 <clokep_work> Hello qheaden.
14:26:39 <qheaden> clokep_work: Yesterday, I was able to build Instantbird inside of my building docker image.
14:27:03 <qheaden> I'm going to also work on creating a docker-compose file that will make it easy to use the image.
14:30:00 <clokep_work> qheaden: Yep! I fixed the issue with mintrayr. ;)
14:30:03 <clokep_work> I'm glad it works on Linux too!
14:30:06 <clokep_work> Thanks for confirming. :)
14:30:40 <qheaden> Thanks for fixing the mintrayr issue!
14:33:35 <clokep_work> freaktechnik, flo-retina: So the only other places I know of that we do this is: https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircServerTime.jsm#20
14:33:43 <clokep_work> And that floors, which makes them different right now. ;)
14:33:47 <clokep_work> (Also...leap seconds, meh.)
14:34:03 <clokep_work> qheaden: Sure thing! :)
14:34:47 * qheaden can get to work on that IRC Password improvment.
14:34:54 <clokep_work> :) That'd bea wesome.
14:35:32 <qheaden> Should be pretty simple. The setting is already there. I just to need to expose it in the UI.
14:39:37 <aleth-mob> qheaden: the difficult part is storing the pwd in the password manager instead of in a pref...
14:40:01 <qheaden> Ah. True
14:40:20 <aleth-mob> Not too difficult though, hopefully ;-)
14:41:38 <qheaden> :)
14:51:49 <clokep_work> flo-retina: https://dxr.mozilla.org/comm-central/source/chat/protocols/twitter/twitter.js#270
14:51:54 <clokep_work> We should change that oen too?
14:55:55 <clokep_work> All the others seem to be flooring!
15:00:55 <qheaden> I'm listening to a computer security podcast, and when speaking about chat clients compatible with OTR, Instantbird was mentioned in the list. :)
15:01:23 <clokep_work> Sweet. :)
15:01:25 <clokep_work> What podcast?
15:03:12 <qheaden> TWiT.tv's Security Now
15:03:20 <qheaden> Pretty major podcast.
15:06:03 <flo-retina> :)
15:08:26 <qheaden> https://twit.tv/shows/security-now/episodes/594?autostart=true
15:08:34 <qheaden> Jump to 53:36
15:11:58 * clokep_work assumes that's a yes...on the Twitter thing.
15:12:39 <flo-retina> yes!
16:18:49 --> bgmCoder has joined #instantbird
18:41:52 --> matrixisreal has joined #instantbird
18:42:04 --> bgmCoder1 has joined #instantbird
18:43:41 <-- bgmCoder has quit (Ping timeout: 121 seconds)
18:43:41 * bgmCoder1 is now known as bgmCoder 
18:45:33 <matrixisreal> clokep_work:  Hi, Sorry I was busy the last few days so could'nt work much.
18:45:40 <matrixisreal> on https://bugzilla.mozilla.org/show_bug.cgi?id=1141674
18:45:42 <instantbot> Bug 1141674 maj, --, ---, clokep, ASSI, Reimplement Facebook Chat not using XMPP
18:46:14 <clokep_work> matrixisreal: No need to apologize.
18:46:19 <matrixisreal> So, I have few things to ask.
18:46:26 <clokep_work> OK.
18:46:50 <matrixisreal> while applying ur patch, there were some rejects.
18:47:05 <matrixisreal> and its very cumbersome to manually edit them, 
18:47:30 <matrixisreal> is there any  good approach to handle them
18:47:43 <matrixisreal> Ive never used hg before 
18:48:24 <clokep_work> matrixisreal: You usually need to do it manually, that goes for any version control system
18:48:41 <clokep_work> Although I'd be surprised if that many parts were in conflict.
18:48:48 <clokep_work> I'd expect a couple of moz.build files maybe.
18:49:39 <matrixisreal> clokep_work:  and few Js files too..
18:49:50 <matrixisreal> well, Ill manually do it anyway
18:49:57 <clokep_work> Really?
18:50:00 <clokep_work> What JS files conflicted?
18:50:27 <matrixisreal> chat-prefs.js and facebook.js
18:51:41 <clokep_work> Ah chat-prefs would do it.
18:51:52 <clokep_work> facebook.js you can just use the one from the patch.
18:52:00 <clokep_work> And not manually fix any issues with it.
18:53:25 <matrixisreal> how to use facebook.js from the patch, is there any hg command,
18:53:42 <matrixisreal> or do i need to copy pase and remove all the + and - signs ? :/
18:53:45 <clokep_work> I don't know off the top of my head, sorry.
18:55:14 <clokep_work> Copying and pasting is the easy way. ;)
18:56:57 <matrixisreal> clokep_work:  Okay., Well out of curiosity how does the mozilla release system handles all the patches.?
18:57:13 <clokep_work> What?
18:57:22 <matrixisreal> Do people manually change them in case of conflicts ?
18:57:28 <clokep_work> It's only a patch file during development.
18:59:27 <matrixisreal> I mean, IF an old patch(say one month old) is applied to the main tree, there is a high chance that the files the patch touches might have changed, so there will be conflicts, 
18:59:38 <matrixisreal> clokep_work:  how are they handled ?
18:59:47 <clokep_work> matrixisreal: They land on the tree.
18:59:58 <clokep_work> And then they get included in releases.
19:00:19 <matrixisreal> clokep_work:  but what about the conflicts ?
19:00:33 <clokep_work> They have to be fixed before being merged into the tree.
19:00:43 <matrixisreal> manually ?
19:00:51 <clokep_work> Yes.
19:01:58 <matrixisreal> clokep_work: Oh, thats what I was asking :D, well Im going off topic.
19:02:06 <matrixisreal> So, could you tell me what thrift is ?
19:02:22 <matrixisreal> what does it do in ur code ?
19:04:23 <clokep_work> It's a data packing format or something.
19:04:34 <clokep_work> matrixisreal: https://en.wikipedia.org/wiki/Apache_Thrift
19:05:50 <matrixisreal> clokep_work: The thrift files you added, were they ur implementation or thrift libraries ?
19:06:40 <clokep_work> matrixisreal: Can you be more specific?
19:06:45 <clokep_work> Do you mean facebook.thrift or thrif.js?
19:06:56 <matrixisreal> .js files 
19:07:25 <matrixisreal> I mean thrift.js and compact_protocol.js
19:09:58 <clokep_work> matrixisreal:  https://github.com/apache/thrift/blob/master/lib/nodejs/lib/thrift/thrift.js https://github.com/apache/thrift/blob/master/lib/nodejs/lib/thrift/compact_protocol.js
19:10:25 <clokep_work> matrixisreal: In general, everything under faebook/thrift is from that package or autogenerated, except facebook.thrift, which I wrote.
19:10:32 <clokep_work> (By reverse engineering the libpurple C structus.)
19:11:37 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:11:44 <matrixisreal> clokep_work: hmm,, , Is there any other way other than reverse engineering the libpurple  source 
19:12:12 <clokep_work> matrixisreal: Convince someone at Facebook to give you documentation? :P
19:12:26 <matrixisreal> :P
19:12:38 <matrixisreal> but how did the libpurple people wrote it ?
19:13:27 <qheaden> matrixisreal: Probably by either reverse engineering the network traffic, or someone with background knowledge contributed source code.
19:15:53 <clokep_work> matrixisreal: They reverse engineered the network traffic created by a Facebook application on an android phone.
19:18:05 <clokep_work> It might be easier if you look at one of the documented protocols I suggested. (Although I don't remember the full list...)
19:20:15 <matrixisreal> Thats amazing, :O , But AFIK, That was a GSoC project, is it really?
19:20:58 <matrixisreal> i mean, a Gsoc project, I think 
19:21:09 <matrixisreal> its too much for a gsoc proj :P
19:21:43 <matrixisreal> clokep_work: Ok, so , does any of hangoutt or Bonjour have documentation ?
19:23:26 <clokep_work> matrixisreal: Hangouts is not documented, but there are other implementations that are likely easier to follow than libpurple.
19:23:33 <clokep_work> Bonjour is standardized, although I know very little about it.
19:23:45 <clokep_work> But the libpurple Bonjour code is like 50 lines. :P
19:23:56 <clokep_work> I don't know what you're saying is a GSoC project though.
19:29:36 <matrixisreal> clokep_work : I have a doubt, why dont we use libpurple directly instead of reimplementing?
19:32:03 <clokep_work> A bunch of reasons: we can't use libpurple's code in Thunderbird; libpurple is not working in Instantbird right now; building it for the version of libpurple we're using was a huge PITA because it had lots of dependencies.
19:45:41 <matrixisreal> clokep_work : Okay :P, regarding the bonjour thing, how can it be implemented in just 50 lines? :O
19:46:00 <matrixisreal> and do you think itd be easy for me as a beginner ?
19:46:28 <clokep_work> I'm exaggerating: https://bitbucket.org/pidgin/main/src/c51421b3224e49bb240591d090a4daafce1c3b42/libpurple/protocols/bonjour/?at=release-2.x.y
19:46:41 <clokep_work> Bonjour should just be plugging into a bunch of APIs and hooking them together.
20:23:06 <instantbot> New Chat Core - General bug 1331719 filed by clokep@patrick.cloke.us.
20:23:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1331719 nor, --, ---, clokep, ASSI, Fix building libpurple on Windows with MSVC 2015
20:28:28 <instantbot> New Instantbird - Other bug 1331723 filed by clokep@patrick.cloke.us.
20:28:29 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1331723 nor, --, ---, clokep, ASSI, Fix Windows packaging of Instantbird
20:30:46 <clokep_work> Have fun. ;)
20:35:33 <matrixisreal> clokep_work: you said you have notes about fb protocol, Can u send me whenever possible.. :)
20:35:52 <clokep_work> matrixisreal: I couldn't find them.
20:36:53 <matrixisreal> Okay, 😕
21:23:25 <EionRobb> clokep_work: if you do find them, can you put them up at http://imfreedom.org/wiki/Main_Page ?
21:23:42 <clokep_work> EionRobb: I think they were mostly notes about how the libpurple code works.
21:23:46 <clokep_work> But I'll check.
21:24:44 <clokep_work> freaktechnik: Thanks.
21:33:47 <-- EionRobb has quit (Quit: Leaving.)
21:38:54 <freaktechnik> clokep_work: might also want to look at the commit message. It has Author at the end? Or is that something about the HG format I'm forgetting?
21:39:26 <clokep_work> freaktechnik: Thanks. It'll probably explode when I check it in. :)
21:40:03 <clokep_work> Yeah that'snot part of the patch format.
21:40:06 <clokep_work> Not sure what's up with it.
21:40:32 <freaktechnik> maybe some GUI client that "signs" commits or something. I remember git clients with gui doing stuff like that
21:40:52 <clokep_work> You can sign commits, sure.
21:40:55 <clokep_work> But...yeah...
21:41:37 <freaktechnik> yep, super useful n stuff
21:42:03 <clokep_work> No one wants to deal w/ kes.
21:44:53 <freaktechnik> I have to say. Impressed that they got the patch format right apart from that first try
21:55:24 <clokep_work> It doesn't have 8 lines. ;)
21:55:56 <freaktechnik> that's not something documentation tells you to set up, so I'm not counting that :P
21:56:16 <freaktechnik> documentation just tells you to run mozilla/mach mercurial-setup
22:00:00 <clokep_work> Does that not do that?
22:00:01 <clokep_work> Weird.
22:00:09 * clokep_work bails.
22:00:14 <freaktechnik> no it does not. It only enables git diffs afaik
22:06:12 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:35:36 <matrixisreal> https://www.irccloud.com/pastebin/ODg1LB5D/
22:35:54 <matrixisreal> got this error while building
22:36:04 <matrixisreal> anyway out ?
22:38:54 --> clokep has joined #instantbird
22:38:54 * ChanServ sets mode +o clokep 
22:43:53 <clokep> matrixisreal: That's fixed, pull the latest tip.
22:48:49 <matrixisreal> clokep: that worked, thanks, btw how to build/make individual components
22:49:07 <matrixisreal> in my case /chat
22:49:11 <clokep> matrixisreal: |mach build chat|
22:49:26 <clokep> flo-retina, aleth-mob: Where do installers end up if I run |mach package| I can't seem to find it in objdir/dist
22:50:00 <flo-retina> try find objdir/dist -name '*.exe'
22:50:32 <flo-retina> on windows it used to get created in a sea/ (for SelfExtractingArchive), which I got rid of with makefile hacks that may be broken
22:50:45 <clokep> Ooo I found a zip file, but no installer.
22:51:00 <clokep> flo-retina: Maybe I'm being dumb, on Windows does |mach package| make an installer or just the zip file?
22:51:14 <flo-retina> you may need mach installer
22:51:16 <flo-retina> I don't know
22:51:58 <flo-retina> for nightlies we run http://searchfox.org/comm-central/source/im/build.mk#75 explicitly without using mach, so I don't know...
22:54:23 <clokep>  0:23.25 c:/Users/clokep/comm-central/mozilla/toolkit/mozapps/installer/packager.mk:132: *** "make install" is not supported on this platform. Use "make package" instead..  Stop.
22:54:28 <clokep> When I run |mach install|
22:55:02 <flo-retina> try gmake -C objdir/im/installer installer
22:56:02 <clokep> mozmake instead of gmake is doing something...
22:56:27 <flo-retina> alright, I guess now it's obvious that I haven't tried building on Windows in a long while ;)
22:57:04 <clokep> It failed: https://pastebin.mozilla.org/8964897
22:57:12 <clokep> (See line 10)
23:05:29 <-- nhnt11 has quit (Ping timeout: 121 seconds)
23:06:31 --> nhnt11 has joined #instantbird
23:06:33 * ChanServ sets mode +h nhnt11 
23:15:17 <-- gerard-majax has quit (Ping timeout: 121 seconds)
23:21:38 <aleth-mob> clokep_work: does comparing with a TB build log help?
23:37:36 --> clokep_work has joined #instantbird
23:37:36 * ChanServ sets mode +o clokep_work 
23:39:18 --> EionRobb has joined #instantbird
23:46:04 <-- freaktechnik has quit (Ping timeout: 121 seconds)
23:46:35 --> freaktechnik has joined #instantbird
23:59:44 --> clokep_ has joined #instantbird
23:59:44 * ChanServ sets mode +o clokep_