#instantbird log on 01 16 2017

All times are UTC.

00:01:58 <-- freaktechnik has quit (Ping timeout: 121 seconds)
00:07:25 --> freaktechnik has joined #instantbird
00:23:18 --> Alex has joined #instantbird
01:23:00 <-- EionRobb has quit (Quit: Leaving.)
02:23:27 --> EionRobb has joined #instantbird
03:13:03 <instant-buildbot> build #948 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/948
03:16:52 <instant-buildbot> build #3427 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3427
03:38:14 <-- EionRobb has quit (Quit: Leaving.)
04:31:35 --> EionRobb has joined #instantbird
04:40:06 --> EionRobb1 has joined #instantbird
04:42:22 <-- EionRobb has quit (Ping timeout: 121 seconds)
05:56:59 --> micahg has joined #instantbird
06:18:23 <-- EionRobb1 has quit (Quit: Leaving.)
08:32:42 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:15:44 <qheaden> Yay! I got a Linux build of Ib to complete
09:15:52 <qheaden> And I was using my docker image too.
09:30:07 --> gerard-majax has joined #instantbird
09:43:47 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:44:39 --> gerard-majax has joined #instantbird
09:50:20 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:53:52 --> fredw has joined #instantbird
09:55:44 --> gerard-majax has joined #instantbird
10:08:27 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:18:18 <-- qheaden has quit (Ping timeout: 121 seconds)
10:23:50 <-- Alex has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:24:47 <-- freaktechnik has quit (Ping timeout: 121 seconds)
10:35:05 --> chrisccoulson has joined #instantbird
10:42:40 --> BWMerlin has joined #instantbird
10:48:32 --> gerard-majax has joined #instantbird
10:50:37 --> freaktechnik has joined #instantbird
11:11:31 --> flo-retina has joined #instantbird
11:11:31 * ChanServ sets mode +qo flo-retina flo-retina 
12:32:55 <-- BWMerlin has quit (Ping timeout: 121 seconds)
12:43:55 --> clokep_work has joined #instantbird
12:43:55 * ChanServ sets mode +o clokep_work 
13:30:19 --> fredw1 has joined #instantbird
13:31:22 <-- fredw has quit (Ping timeout: 121 seconds)
13:31:23 * fredw1 is now known as fredw 
13:45:04 <clokep_work> My packaging is failing because of duplicated files...
13:50:13 <aleth-mob> There's an exception list if you can't avoid them...
13:54:16 --> Bollebib has joined #instantbird
14:01:08 <clokep_work> aleth-mob: There's like 50 of them?
14:01:15 <clokep_work> Did we clean this up at some point for the other OSes?
14:01:17 <clokep_work> Or is this a new bustage?
14:04:02 <aleth-mob> It's not new, but we haven't had windows builds for ages 
14:04:58 <aleth-mob> Gecko duplicates on Windows would also affect TB though 
14:11:23 <clokep_work> Right.
14:11:27 <clokep_work> But not if the duplicate is in the IM?
14:11:31 <clokep_work> Is in im/.
14:11:41 <clokep_work> So whats' the 'right' way to do this?
14:11:46 <clokep_work> I need to file a bug to fix purple builds btw.
14:22:32 <aleth-mob> Right 
14:23:12 <aleth-mob> Either you can avoid the duplicate by pointing to one or the other copy in jar.mn
14:23:42 <aleth-mob> Or, you add it to the im/ exceptions 
14:28:12 <-- fredw has quit (Client exited)
14:34:31 <-- micahg has quit (Connection closed)
14:35:25 --> micahg has joined #instantbird
14:38:47 <aleth-mob> 50 seems a lot of dupes...
14:42:21 --> clokep has joined #instantbird
14:42:21 * ChanServ sets mode +o clokep 
14:42:31 <clokep> aleth-mob: https://pastebin.mozilla.org/8964170
14:47:15 <aleth-mob> Looks like dupes within im/, which explains why they were not noticed before 
14:48:04 <aleth-mob> You can probably get rid of them all 
14:48:29 <clokep_work> aleth-mob: By "get rid of them all" does that just mean the packaging lines?
14:48:33 <clokep_work> Or actually removing files?
14:49:16 <aleth-mob> Removing one copy (probably the aero one) and using jar.mn to point at the other 
14:49:46 <aleth-mob> There is some patch by Paengkab that did something similar in mail iirc
14:50:56 <aleth-mob> I don't remember the details 
14:57:17 <clokep_work> Hm. OK. Thanks.
15:08:51 <clokep> Hmm...it looks to me like there's only one of those in the repo?
15:08:58 <clokep> But two lines...do I just get rid of the aero one?
15:09:00 <clokep> flo-retina: Any idea?
15:16:17 <aleth-mob> Ah, so that's the case where it's the packaging that creates the dupe... Iirc the Mail patch had some of those too
15:23:08 * clokep_work is confused. :(
15:41:31 <clokep> So I think there's just no aero stuff left anymore.
15:41:54 --> bgmCoder has joined #instantbird
15:41:55 <clokep> But I'm not really sure.
15:45:22 --> fredw has joined #instantbird
16:57:08 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:07:59 --> nhnt11-phone has joined #instantbird
17:31:59 --> mpmc has joined #instantbird
17:34:25 --> gerard-majax has joined #instantbird
17:42:47 <-- fredw has quit (Client exited)
17:47:13 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:47:55 <-- nhnt11-phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
17:53:56 --> gerard-majax has joined #instantbird
18:18:49 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:22:25 --> gerard-majax has joined #instantbird
18:35:50 <not-freaktechnik> clokep: workaround for the person with znc and the cap problem: downgrade znc ;)
18:38:49 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:44:49 <flo-retina> clokep: we should port whatever Firefox did to get rid of that aero folder
18:45:29 <flo-retina> I think they just removed the aero/ copy, and included only the files that were different, and used overrides in the jar.mn to make the Vista+ Windows version use the different version
18:45:44 <flo-retina> although... now that support for XP is dead, I think the non-aero version has disappeared
18:47:18 <flo-retina> Fallen: I don't understand your comment in bug 1330464
18:47:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1330464 nor, --, Firefox 53, florian, RESO FIXED, Calls to common service methods shouldn't supply additional parameters
18:54:00 <clokep_work> flo-retina: Interesting, how can jar.mn have overrides?
18:54:06 <clokep_work> Isn't it a compile time file?
18:54:11 <flo-retina> no
18:54:28 <flo-retina> well, chrome.manifest can have overrides
18:54:31 <clokep_work> Ah.
18:54:42 <flo-retina> and you just happen to write these lines inside the jar.mn file, which is what is used to generate chrome.manifest
18:55:39 <flo-retina> http://searchfox.org/mozilla-central/search?q=override&case=false&regexp=false&path=browser%2Fthemes%2Fwindows
18:58:15 <clokep_work> I also find it interesting that apparently jar.mn was split in browser/ and mail/ for each OS.
19:00:09 * clokep_work still isn't 100% sure what he has to change.
19:01:44 <clokep_work> It *sounds* like you're saying to just delete https://dxr.mozilla.org/comm-central/source/im/themes/jar.mn#117-161
19:01:58 <clokep_work> But I suspect that's too simplistic.
19:05:25 --> fredw has joined #instantbird
19:05:26 <aleth-mob> clokep_work: found the bug 1317142
19:05:28 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1317142 nor, --, Thunderbird 53.0, richard.marti, RESO FIXED, Remove duplicate files from mail
19:06:02 <clokep_work> aleth-mob: Ah! That's not what I was looking at...
19:07:11 <flo-retina> yes, that's too simplistic
19:07:35 <flo-retina> because the files that used to be aero specific (ie. Vista+) should now be used all the time (as we no longer support anything pre Win7)
19:12:10 <clokep> Yeah OK.
19:19:25 <clokep> Meh, do I need to clobber to test changes to jar.mn?
19:21:07 --> Logicoma has joined #instantbird
19:22:33 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:23:05 <aleth-mob> I don't think so?
19:24:22 <aleth-mob> Not sure though. Maybe you need to run configure?
19:25:04 <clokep> Ah maybe.
19:40:38 <clokep_work> That didn't seem to do it either.
19:42:20 <aleth-mob> Is it still realistic to have a release based on 52? If not you don't have to worry about xp/vista at all
19:42:49 <aleth-mob> Not sure if 'aero' is xp ;-)
19:47:19 --> gerard-majax has joined #instantbird
23:18:08 --> instantbot has joined #instantbird
23:18:09 topic changed by levin.mozilla.org to "Ask about Instantbird (http://instantbird.com) here! :-) | Last version was Instantbird 1.5 | Nightlies: http://nightly.instantbird.im (at your own risk) | News: http://blog.instantbird.org | IRC logs: http://log.bezut.info | Pastebin: http://pastebin.instantbird.org | Bugs: https://bugzilla.mozilla.org"
23:18:09 * ChanServ sets mode +v instantbot 
23:34:04 --> EionRobb has joined #instantbird