All times are UTC.
00:24:22 <-- Bollebib has quit (Ping timeout: 121 seconds) 03:12:47 <instant-buildbot> build #891 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/891 03:41:25 <instant-buildbot> build #3367 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3367 04:17:18 <-- unghost has quit (A TLS packet with unexpected length was received.) 07:02:30 <nhnt11> 12:26:55 - clokep_work: [10:32:36] nhnt11: https://github.com/freaktechnik/twitch-provider/ 07:02:30 <nhnt11> ^ This is neat, I hadn't been paying attention if freaktechnik has been talking about it 07:53:31 --> mpmc has joined #instantbird 09:08:43 --> Bollebib has joined #instantbird 10:13:32 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:17:26 --> mpmc has joined #instantbird 10:25:17 --> gerard-majax has joined #instantbird 11:11:34 <-- mpmc has quit (Ping timeout: 121 seconds) 11:44:07 --> mpmc has joined #instantbird 11:55:04 --> mpmc1 has joined #instantbird 11:59:20 <-- BWMerlin has quit (Ping timeout: 121 seconds) 12:01:11 --> aleth has joined #instantbird 12:01:11 * ChanServ sets mode +o aleth 12:07:12 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:07:12 * mpmc1 is now known as mpmc 12:44:55 --> unghost has joined #instantbird 13:37:06 <instantbot> aleth@instantbird.org changed the Resolution on bug 1318862 from --- to FIXED. 13:37:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1318862 nor, --, Instantbird 53, arlolra, RESO FIXED, Fix path to nss-purple.symbols now NSS is built with gyp 13:47:21 --> Logicoma has joined #instantbird 14:17:43 <flo-retina> heh, aleth has been faster than me! 14:17:55 <flo-retina> I made a local build to see if I could debug the autoscroll bug 14:18:16 <flo-retina> and was going to comment in bug 1318862 "I can confirm this fixed the build for me" and add an r+ 14:18:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1318862 nor, --, Instantbird 53, arlolra, RESO FIXED, Fix path to nss-purple.symbols now NSS is built with gyp 15:14:49 <-- Bollebib has quit (Ping timeout: 121 seconds) 15:15:23 <-- flo-retina has quit (Connection closed) 15:15:28 --> flo-retina has joined #instantbird 15:15:28 * ChanServ sets mode +qo flo-retina flo-retina 15:26:13 --> Bollebib has joined #instantbird 16:20:06 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:37:56 --> clokep_work has joined #instantbird 16:37:56 * ChanServ sets mode +o clokep_work 16:46:00 <-- clokep_work has quit (Ping timeout: 121 seconds) 17:48:29 <-- Logicoma has quit (Connection closed) 18:20:00 <-- EionRobb has quit (Quit: Leaving.) 18:43:22 --> freaktechnik has joined #instantbird 18:47:33 --> chrisccoulson has joined #instantbird 18:51:39 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 19:04:56 --> chrisccoulson has joined #instantbird 19:15:07 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 19:25:42 --> EionRobb has joined #instantbird 19:27:53 --> chrisccoulson has joined #instantbird 19:32:22 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 19:52:35 --> chrisccoulson has joined #instantbird 19:57:04 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 20:16:29 --> chrisccoulson has joined #instantbird 20:20:33 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 20:58:36 --> chrisccoulson has joined #instantbird 21:03:10 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 21:15:59 --> chrisccoulson has joined #instantbird 21:23:24 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 21:36:16 --> chrisccoulson has joined #instantbird 21:42:27 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 22:07:06 <-- gerard-majax has quit (Ping timeout: 121 seconds) 22:17:23 --> chrisccoulson has joined #instantbird 22:21:26 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 22:45:50 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 22:50:56 <flo-retina> do we have ideas about how to reprdoduce the autoscroll bug? 22:51:11 <flo-retina> I've been trying for the last couple minutes, without finding anything conclusive 22:52:26 --> chrisccoulson has joined #instantbird 22:56:36 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 23:00:11 <flo-retina> ah, progress! :) 23:00:54 <flo-retina> aleth: whenever we fail to auto-scroll, aNoAutoScroll is true at http://searchfox.org/comm-central/source/chat/content/convbrowser.xml#593 23:10:12 --> chrisccoulson has joined #instantbird 23:19:53 <aleth> Shouldn't there always be one more message in the queue though, in that case? 23:26:44 * aleth suspects something goes wrong with autoScrollEnabled 23:38:52 <flo-retina> I found the problem 23:39:40 <flo-retina> this._pendingMessages is only cleared when we call getNextPendingMessage in a way that will return null 23:40:17 <flo-retina> when timing.timeRemaining() returns 0, we exit the loop before reaching the end of the array 23:40:30 <flo-retina> so the cleanup of the _pendingMessages array never happens 23:41:22 <flo-retina> which causes max (from getPendingMessagesCount, which comes from that _pendingMessages array) to have a bogus value at the next call, which makes us not autoscroll 23:44:40 <flo-retina> fix coming 23:44:43 <flo-retina> do we have a bug on file? 23:45:07 * nhnt11 guesses the fix is to not be lazy about clearing that array? 23:45:43 <flo-retina> nhnt11: correct 23:47:48 * nhnt11 wonders why that code isn't pop'ing that array in the first place 23:48:04 * nhnt11 wonders if it's just that old 23:48:48 <nhnt11> oh, no, Array.prototype.pop has been around since 1999 23:49:04 * nhnt11 shrugs 23:50:23 <aleth> Interesting 23:51:50 <aleth> nhnt11: pop wouldn't help, you'd need to shift, and that's not being done likely for performance reasons 23:52:35 <nhnt11> aleth: yeah, perf is a good reason 23:52:42 <nhnt11> although... 23:53:02 <nhnt11> If I was implementing a shift algorithm, I'd just increment the array pointer... 23:53:39 <flo-retina> aleth, nhnt11: I think we are not shift'ing because we need the count to remain constant for the sake of updating the progressbar 23:53:39 <nhnt11> I think shift() and pop() make copies of the element returned though, which is expensive 23:53:49 <nhnt11> that's a good reason! 23:54:04 <flo-retina> nhnt11: copy of a pointer to an object? Doesn't sound expensive to me 23:54:34 <aleth> flo-retina: ah yeah, that sounds familiar 23:54:38 <nhnt11> flo-retina: I think it copies the whole object, no? 23:54:42 <flo-retina> aleth: so, do I need to file a bug? 23:54:46 <flo-retina> nhnt11: no. 23:54:50 <aleth> flo-retina: I think so 23:55:00 <flo-retina> nhnt11: JS never copies a whole object or an array, unless you explicitly request it 23:55:03 <nhnt11> yeah ok, makes sense 23:55:26 <nhnt11> If I had references to other objects in an array, I wouldn't expect the objects to be copied when shift'ing 23:55:32 <nhnt11> (like an array of observers for example) 23:55:36 * nhnt11 knew that 23:55:57 <nhnt11> shift and pop certainly sound like pretty cheap operations to me then! 23:56:59 <aleth> They should be, but iirc we optimized that code at one point and had some surprises 23:57:02 <aleth> long time ago though 23:57:09 <flo-retina> that code was full of surprises 23:57:18 <flo-retina> it's complicated and used in several different ways 23:57:38 <flo-retina> aleth: so do we have a bug on file yet? 23:57:43 <aleth> no 23:58:49 <aleth> heh http://searchfox.org/mozilla-central/source/js/src/jit/MCallOptimize.cpp#652