#instantbird log on 11 16 2016

All times are UTC.

00:10:14 <-- aleth has quit (Quit: Instantbird 52)
00:12:58 --> Alex has joined #instantbird
00:30:53 <-- DGMurdockIII has quit (Connection closed)
00:48:36 --> clokep_work has joined #instantbird
00:48:36 * ChanServ sets mode +o clokep_work 
00:52:38 <-- clokep_work has quit (Ping timeout: 121 seconds)
01:03:48 <-- Bollebib has quit (Ping timeout: 121 seconds)
03:15:44 <instant-buildbot> build #887 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/887
03:19:22 <instant-buildbot> build #3363 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3363
04:02:55 <-- bgmCoder has quit (Ping timeout: 121 seconds)
04:19:06 <-- EionRobb has quit (Quit: Leaving.)
04:55:50 --> EionRobb has joined #instantbird
06:21:45 <-- EionRobb has quit (Quit: Leaving.)
06:34:34 --> EionRobb has joined #instantbird
06:53:05 --> fredw has joined #instantbird
07:36:40 --> bogdan_maris has joined #instantbird
07:52:16 <-- fredw has quit (Client exited)
08:04:46 --> Bollebib has joined #instantbird
09:06:12 --> fredw has joined #instantbird
09:19:12 --> BWMerlin has joined #instantbird
09:20:31 --> gerard-majax has joined #instantbird
09:47:22 <-- gerard-majax has quit (Quit: Leaving)
09:47:29 --> gerard-majax has joined #instantbird
10:00:00 <-- Alex has quit (Connection closed)
10:05:05 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:06:53 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:24:12 --> mpmc has joined #instantbird
10:37:25 --> flo-retina has joined #instantbird
10:37:25 * ChanServ sets mode +qo flo-retina flo-retina 
10:38:47 --> gerard-majax has joined #instantbird
11:24:20 --> aleth has joined #instantbird
11:24:20 * ChanServ sets mode +o aleth 
11:26:24 <-- gerard-majax has quit (A TLS packet with unexpected length was received.)
11:31:51 --> gerard-majax has joined #instantbird
11:32:22 --> mpmc1 has joined #instantbird
11:34:20 <-- mpmc has quit (Ping timeout: 121 seconds)
11:34:20 * mpmc1 is now known as mpmc 
11:42:59 --> mpmc1 has joined #instantbird
11:44:33 <-- mpmc has quit (Ping timeout: 121 seconds)
11:44:33 * mpmc1 is now known as mpmc 
12:00:49 --> mpmc1 has joined #instantbird
12:02:36 <-- mpmc has quit (Ping timeout: 121 seconds)
12:02:36 * mpmc1 is now known as mpmc 
12:19:42 <-- BWMerlin has quit (Ping timeout: 121 seconds)
13:19:51 --> FilipMosner1 has joined #instantbird
13:22:39 <-- FilipMosner has quit (Ping timeout: 121 seconds)
13:22:40 * FilipMosner1 is now known as FilipMosner 
13:44:09 --> clokep_work has joined #instantbird
13:44:09 * ChanServ sets mode +o clokep_work 
13:48:09 <clokep_work> Btw from the conversation yesterday (that I just read), yes I think the options are jsctypes or emscripten.
13:48:15 <clokep_work> I've never gotten emscripten to run, personally...
13:51:57 <clokep_work> aleth: Was there something we wanted uplifted into 45.5?
13:52:50 <aleth> Yes
13:53:01 <aleth> But I think it's too late for 45.4
13:53:05 <clokep_work> Looks like those builds will be kicked off today/tomorrow.
13:53:05 <aleth> eh 45.5
14:10:24 <clokep_work> Yeahhhh.
14:19:18 <flo-retina> that auto scrolling bug is such a pain
14:21:16 <aleth> time to fix it? ;)
14:21:36 <flo-retina> right
14:21:54 <flo-retina> if I didn't need to do painting upstairs, I would consider it for my next block of spare time
14:41:50 --> bgmCoder has joined #instantbird
14:51:44 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:29:37 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:26:45 <fredw> Hi aleth and clokep_work , thanks you for your feedback on bug 1199855
16:26:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1199855 nor, --, ---, nobody, NEW, Add Matrix as a supported protocol
16:27:22 <fredw> Just FYI, my patch already uses the globals exposed by Components.utils.importGlobalProperties
16:28:01 <fredw> Also, I just tested it now and indeed I can use Timer.jsm for setTimeout etc
16:29:20 <fredw> I'm not sure yet about replacements for window.document and window.localStorage, though
16:29:48 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:32:55 --> gerard-majax has joined #instantbird
16:40:55 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:44:40 <aleth> fredw: what would you need a document for?
16:45:49 <fredw> aleth: I'm not sure yet. I got an error "document undefined" when running the code but have not debugged yet
16:46:08 <fredw> For localStorage I see https://developer.mozilla.org/en-US/Add-ons/Overlay_Extensions/XUL_School/Local_Storage
16:46:13 <aleth> localStorage is probably not what you want in the TB context (e.g. for account preferences/options there are better methods)
16:46:31 <aleth> I mean, what is the protocol storing?
16:46:59 <aleth> The matrix sdk likely just uses those because it expects to run in a webpage
16:47:24 <fredw> aleth: Yes, I think so. I haven't checked either, I just tried to make it run.
16:47:33 <aleth> sure, thanks :-)
16:47:52 <fredw> I also saw https://github.com/matrix-org/matrix-js-sdk/issues/259 BTW
16:48:40 <aleth> If what's being stored are chat logs, you shouldn't have to worry about that.
16:48:50 <fredw> So basically for now I just make this quick hidden window hack but we'll need to figure out for what all of these are used and try and replaced by something else if possible
16:49:57 <fredw> aleth: that's what I thought, but I also saw https://github.com/matrix-org/matrix-js-sdk/issues/247
16:50:48 <fredw> Anyway, it's probably best to ask someone from matrix who is more familiar about the API/code
16:52:23 <aleth> You may find once you've got it working that you can strip out a lot of the sdk and the dependency goes away ;)
16:54:35 <fredw> aleth: I don't know for now :-) I also saw https://github.com/matrix-org/matrix-js-sdk/issues/244 and tried to get rid of q (promises) and another-json dependency but not sure that will be possible for the latter..
16:55:35 <fredw> I already removed many of the browserify files that did not seem to be used.
16:55:41 <aleth> It's unfortunate people who write libraries like that decide to use such a stack of dependencies in the first place...
16:56:07 <aleth> But I suppose it's standard in the webdev world to not worry too much about that.
16:57:00 <fredw> Yes, another problem is that the lib seems very dependent on browser's javascript stuff :-(
16:57:02 <aleth> The tradeoff is making it run on older browsers...
17:01:57 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:18:43 <clokep_work> fredw, aleth: I think I had hooked into localStorage 'manually' once before...if we really need it.
17:28:24 --> gerard-majax has joined #instantbird
17:30:43 <fredw> clokep_work: thanks for the info.
17:31:13 <clokep_work> I don't remember the details. :)
17:31:15 <clokep_work> But I'm sure I can find it.
17:31:16 <fredw> aleth, clokep_work: so regarding document, it is used here https://github.com/iriscouch/browser-request/blob/master/index.js#L403
17:31:33 <fredw> and actually for a hack in IE. otherwise window.location is needed.
17:31:45 <clokep_work> (o_O)
17:31:51 <clokep_work> That's unfortunately...
17:31:55 <fredw> But I guess we don't care about this, though. Doing is_crossDomain(url) { return false; } seems to work for me.
17:32:44 <fredw> Actually, this is is a third party lib. Matrix has a function to let you replace with your own implementation of browser-request.
17:33:26 <aleth> phew
17:33:40 <fredw> clokep_work: do you have a reference for localStorage?
17:34:18 <aleth> we have our own browser-request http://searchfox.org/comm-central/source/chat/content/browserRequest.js
17:34:21 <fredw> (I'm going to check now where it is used)
17:34:43 <fredw> aleth: oh, great. Is it some kind of standard API?
17:35:03 <aleth> fredw: Pretty much. That's a chat wrapper for it (used by twitter iirc)
17:35:35 <aleth> e.g. http://searchfox.org/comm-central/source/chat/protocols/twitter/twitter.js#945
17:37:27 <fredw> aleth: So in https://bugzilla.mozilla.org/attachment.cgi?id=8810495&action=diff#a/chat/protocols/matrix/matrix-sdk.jsm_sec2 we have this  MatrixSDK.request(require("browser-request")) to setup the request interface to use. I don't know if I can just use ours
17:38:27 <aleth> If you want to pop up a window, you probably should ;)
17:38:53 <fredw> aleth: This is here https://github.com/matrix-org/matrix-js-sdk/blob/master/lib/matrix.js#L72
17:39:42 <fredw> (note that I used https://github.com/matrix-org/matrix-js-sdk/blob/master/package.json#L44 instead of https://github.com/matrix-org/matrix-js-sdk/blob/master/package.json#L47)
17:39:52 <clokep_work> What is browser request used for?
17:40:38 <fredw> To perform HTTP request basically, but I have not checked the details.  I just know that I can not my code work without that :-)
17:41:06 --> flo-retina has joined #instantbird
17:41:06 * ChanServ sets mode +qo flo-retina flo-retina 
17:41:07 <fredw> For example, I doubt that is_crossDomain is really useful...
17:41:09 <aleth> browserRequest in chat/ is used to pop up an oauth dialog
17:41:50 <fredw> OK, so it's unrelated actually...
17:42:00 <clokep_work> Yeah, that was my guess. ;)
17:42:02 <clokep_work> Hence why I asked. :)
17:42:31 <fredw> So that's why I asked "Is it some kind of standard API?"
17:42:52 <fredw> Since the matrix doc seems to assume that people know what browser-request is :-)
17:42:54 <clokep_work> fredw: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/NsIDOMStorageManager
17:43:18 <fredw> Thanks
17:44:40 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:44:57 <aleth> fredw: huh, looks like it's indeed just some wrapper around html https://www.npmjs.com/package/browser-request
17:45:23 <aleth> *http\
17:45:25 <fredw> aleth: I believe this is actually https://www.npmjs.com/package/browser-request
17:45:56 <fredw> The deps come from https://github.com/matrix-org/matrix-js-sdk/blob/master/package.json#L42
17:46:42 <fredw> So you can choose https://www.npmjs.com/package/request or https://www.npmjs.com/package/browser-request but the former has a lot of deps (as said in https://github.com/matrix-org/matrix-js-sdk/issues/244)
17:47:08 <aleth> Or you can do completely without ;)
17:48:03 <aleth> fredw: http://searchfox.org/comm-central/source/mozilla/toolkit/modules/Http.jsm ?
17:48:46 <aleth> we're already using that in various places if you need examples
17:50:19 <clokep_work> aleth: It probably needs a standard interface to plug into though.
17:50:32 <fredw> aleth: Thanks, however my guess is that it is not exactly a drop-in replacement for this "request" API that matrix-js-sdk wants, so we'll have to tweak a bit the code.
17:50:38 <aleth> I agree
17:52:13 <aleth> Hopefully it's not that different
17:53:41 <fredw> Similarly, we have other deps from http://browserify.org/ ; I removed most of them but it remains events, punycode, querystring and url . I suspect we do have replacements for them but it's probably a bit tedious to teach matrix how to use our implementations.
17:55:17 --> gerard-majax has joined #instantbird
17:55:18 <aleth> Would it help to give up on the idea of using the sdk unmodified and instead extract and fix the parts you need?
17:55:26 <aleth> Depends on how stable their protocol is I guess
17:56:51 <fredw> aleth: I think that's what we'll have to do at the end. But I'd prefer not to move too much away from the upstream code.
18:02:52 --> mconley|livehacking has joined #instantbird
18:04:09 <fredw> OK, so it seems localStorage is not actually needed to make my basic smoke tests working.
18:06:24 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:07:39 --> gerard-majax has joined #instantbird
18:12:02 <-- EionRobb has quit (Quit: Leaving.)
18:19:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:19:33 --> chrisccoulson has joined #instantbird
18:41:11 <fredw> aleth, clokep_work: OK, I now have a version working without hwindow
18:41:36 <fredw> Although browser-request is now logging error with the cros stuff
18:41:43 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:41:52 --> chrisccoulson has joined #instantbird
18:42:37 <fredw> For now I'm not sure how to avoid that without modifying browser-request
18:42:57 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:44:39 <-- fredw has quit (Client exited)
18:45:32 --> fredw has joined #instantbird
19:02:16 <-- fredw has quit (Client exited)
19:05:49 --> EionRobb has joined #instantbird
19:25:25 <clokep_work> Cool. :)
20:02:48 <-- mconley|livehacking has quit (A TLS packet with unexpected length was received.)
20:03:14 --> mconley|livehacking has joined #instantbird
20:19:43 <clokep_work> aleth: I just bugged rkent about uplifting https://bugzilla.mozilla.org/show_bug.cgi?id=1298574 to esr45...he didn't see it apparently. :(
20:19:45 <instantbot> Bug 1298574 nor, --, Instantbird 51, nobody, RESO FIXED, vcard-temp infinite loop
20:20:10 <aleth> well, we only added it like a day ago
20:20:11 <aleth> thanks
20:30:44 <instantbot> rkent@caspia.com set status-thunderbird to fixed on bug 1275284.
20:30:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1275284 nor, --, Instantbird 52, aleth, RESO FIXED, Ensure Twitter code will still work after changes to character limit
21:03:37 <freaktechnik> clokep_work: hmm, I just set up hg with mercurial-setup, which usually also sets the diff format, doesn't it?
21:03:47 <clokep_work> freaktechnik: No idea...
21:04:01 <clokep_work> I have:
21:04:01 <clokep_work> [diff]
21:04:01 <clokep_work> git = 1
21:04:01 <clokep_work> unified = 8
21:04:01 <clokep_work> showfunc = 1
21:18:38 <freaktechnik> hm, mercurial-setup just sets git and showfunc, I guess because normally patches go to reviewboard now
21:21:00 <clokep_work> Meh , don't talk to me about reviewboard.
21:24:51 <freaktechnik> I like reviewboard from a dev flow perspective
21:25:12 <freaktechnik> never had the pleasure of using it for reviewing a patch. Hadn't known splinter either until recently ;)
21:26:03 <aleth> once you've had the pleasure, you may be surprised
21:37:07 <clokep_work> I was so happy to be down to one request...and then freaktechnik is too fast for me.
21:38:27 <freaktechnik> :P
21:38:36 * clokep_work wonders if freaktechnik has commit access.
21:38:42 <freaktechnik> only try
21:39:24 <clokep_work> Ah OK.
21:39:35 <clokep_work> I should try those patches quickly...
21:45:24 <clokep_work> freaktechnik: So the xpcshell tests are failing for me.
21:45:37 <freaktechnik> with scope errors?
21:45:52 <freaktechnik> (xyz is undefined)
21:46:21 <clokep_work> Yes.
21:46:25 <freaktechnik> have fun rebuilding
21:46:30 <clokep_work> :P That was my guess.
21:59:57 <-- mconley|livehacking has quit (Quit: NO CARRIER)
22:02:55 <-- Bollebib has quit (Ping timeout: 121 seconds)
22:03:54 --> BWMerlin has joined #instantbird
22:36:09 <-- clokep_work has quit (Ping timeout: 121 seconds)
23:54:08 <-- BWMerlin has quit (Ping timeout: 121 seconds)