All times are UTC.
00:07:04 --> Alex has joined #instantbird 00:56:31 <-- micahg has quit (A TLS packet with unexpected length was received.) 01:27:19 <-- Bollebib has quit (Ping timeout: 121 seconds) 01:46:09 <-- EionRobb has quit (Connection closed) 01:48:07 --> EionRobb has joined #instantbird 02:02:58 <-- bgmCoder has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:00:38 --> DGMurdockIII has joined #instantbird 03:11:11 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:41:37 <instant-buildbot> build #3358 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3358 05:25:44 <instant-buildbot> build #882 of linux64-nightly-default is complete: Failure [4failed shell_6] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/882 05:41:16 <-- DGMurdockIII has quit (Connection closed) 07:39:52 --> gerard-majax has joined #instantbird 07:47:40 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:14:48 --> bogdan_maris has joined #instantbird 08:57:21 --> Bollebib has joined #instantbird 09:26:20 --> gerard-majax has joined #instantbird 09:38:27 <-- stux has quit (Ping timeout: 121 seconds) 09:41:27 --> stux has joined #instantbird 09:56:00 <-- Alex has quit (Connection closed) 09:56:46 --> aleth has joined #instantbird 09:56:47 * ChanServ sets mode +o aleth 10:17:17 <-- aleth has quit (Quit: Instantbird 52) 10:17:25 --> aleth has joined #instantbird 10:17:25 * ChanServ sets mode +o aleth 10:38:04 --> BWMerlin has joined #instantbird 11:23:49 <-- Tonnes has quit (Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]) 11:32:20 --> Logicoma has joined #instantbird 11:58:23 --> Tonnes has joined #instantbird 12:01:34 <-- aleth has quit (Ping timeout: 121 seconds) 12:08:37 --> aleth has joined #instantbird 12:08:37 * ChanServ sets mode +o aleth 12:48:45 <-- BWMerlin has quit (Ping timeout: 121 seconds) 12:53:16 --> clokep_work has joined #instantbird 12:53:16 * ChanServ sets mode +o clokep_work 12:54:29 <-- Bollebib has quit (Connection closed) 12:54:48 --> Bollebib has joined #instantbird 13:18:07 <clokep_work> freaktechnik: Hi. I'm a little confused... What is originalMessage used for in your patch? 13:18:57 <clokep_work> (Inside of writeMessage. It seems to get added, then just deleted) 14:08:44 <freaktechnik> it's so handlers have a reference to the unmodified message string 14:08:51 <freaktechnik> since they can modify message 14:09:19 <freaktechnik> (as tags may reference contents based on the original message and another handler may have already altered the message) 14:37:48 <clokep_work> Hmm...OK. 14:37:56 <clokep_work> I don't think that will work properly the way you ahve it. 14:38:39 <clokep_work> And to be clear, it's a theoretical need, right? 14:38:52 <clokep_work> Do you know if it iwll be needed at some point? 14:39:13 <clokep_work> freaktechnik: So by having message: aMessage, and then a getter for aMessage... 14:39:21 <clokep_work> They're really referencing the same object. 14:39:47 <clokep_work> So if you modify one, I think it will modify the other one. 14:40:42 <aleth> Isn't originalMessage set once http://searchfox.org/comm-central/source/chat/modules/jsProtoHelper.jsm#392 and then never supposed to be changed? 14:40:59 <clokep_work> aleth: We're talking about the changes in https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1302447&attachment=8807834 14:41:06 <clokep_work> Which has a separate "originalMessage" 14:41:13 <clokep_work> ;) 14:41:18 <aleth> at lerast use a different name ;) 14:41:25 <clokep_work> :-D 14:41:42 <aleth> confusing enough as it is, after arlo's changes... 14:42:49 <aleth> but then I haven't read the patch, so ignore my comments! 14:44:50 <freaktechnik> but aMessage is a string, so it doesn't get set by reference 14:44:52 <freaktechnik> JS \o/ 14:47:04 <freaktechnik> also, I do have a non-standard use-case for it, which is why I added it in the first place. 14:55:35 <clokep_work> I thought aMessage was an ircMessage object? :-S 14:55:48 <clokep_work> That function *really* needs a comment. 14:55:59 <clokep_work> What's the use case? :) 14:56:32 <freaktechnik> there's no ircMessage object 14:56:37 <freaktechnik> which is why this whole thing is so fun. 14:57:03 <freaktechnik> this happens between the ircMessage object getting handled and turned into an imMessage object. 14:57:10 <freaktechnik> Which is exactly what writeFunction does. 14:57:16 <freaktechnik> *writeMessage 14:57:30 <freaktechnik> it essentially takes the constructor arguments to imMessage 14:57:40 <freaktechnik> which are origin, content and misc. properties to set 15:01:46 <clokep_work> Yeah. 15:01:52 <clokep_work> I just keep forgetting that when reviewing the code. : 15:01:53 <clokep_work> :P 15:17:52 --> bgmCoder has joined #instantbird 17:05:10 <-- aleth has quit (Quit: Instantbird 52) 17:05:14 --> aleth has joined #instantbird 17:05:14 * ChanServ sets mode +o aleth 17:41:09 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:41:41 <-- Tonnes has quit (Connection closed) 17:44:05 --> Tonnes has joined #instantbird 18:17:16 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:25:41 --> bogdan_maris has joined #instantbird 18:39:19 <instantbot> aleth@instantbird.org changed the Resolution on bug 955642 from FIXED to ---. 18:39:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955642 enh, --, Instantbird 52, arlolra, REOP, Handle Twitter direct messages (DMs) 19:20:26 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 19:39:32 --> arlolra has joined #instantbird 19:39:42 <arlolra> aleth: :( 19:43:25 <arlolra> I specifically tested for that 19:43:42 <arlolra> can you please describe what's wrong? 19:44:44 <-- aleth has quit (Ping timeout: 121 seconds) 19:48:41 <-- arlolra has quit (Client exited) 20:08:22 --> aleth has joined #instantbird 20:08:22 * ChanServ sets mode +o aleth 20:19:13 <clokep_work> aleth: You see arlolra's question? 20:19:58 <aleth> clokep_work: I answered in the bug. I could reproduce the problem in today's IB nightly. 20:20:41 <clokep_work> Oh you replied. 20:20:42 <clokep_work> sorry! :) 20:34:20 <instantbot> aleth@instantbird.org changed the Resolution on bug 1179943 from FIXED to ---. 20:34:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1179943 nor, --, Instantbird 42, aleth, REOP, Themes window positioned too high on OS X 20:45:37 <-- Logicoma has quit (Quit: Leaving) 20:48:04 --> gerard-majax has joined #instantbird 21:10:01 --> Mook has joined #instantbird 21:19:05 <-- Mook has quit (Client exited) 21:19:23 --> Mook has joined #instantbird 21:44:52 --> DGMurdockIII has joined #instantbird 22:05:36 --> BWMerlin has joined #instantbird 22:40:50 <-- DGMurdockIII has quit (Connection closed) 23:08:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 23:13:46 <-- BWMerlin has quit (Ping timeout: 121 seconds) 23:14:47 --> bogdan_maris has joined #instantbird 23:33:17 <-- aleth has quit (Quit: Instantbird 52) 23:52:17 <-- gerard-majax has quit (Ping timeout: 121 seconds)