All times are UTC.
00:27:46 --> clokep_work has joined #instantbird 00:27:46 * ChanServ sets mode +o clokep_work 00:37:21 --> DGMurdockIII has joined #instantbird 01:24:15 <-- unghost has quit (A TLS packet with unexpected length was received.) 01:25:21 --> Alex2 has joined #instantbird 01:56:27 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:44:43 --> EionRobb1 has joined #instantbird 02:47:01 <-- EionRobb has quit (Ping timeout: 121 seconds) 03:15:53 <-- DGMurdockIII has quit (Connection closed) 03:31:34 <-- GeekShadow has quit (Ping timeout: 121 seconds) 03:31:37 --> GeekShadow has joined #instantbird 03:47:53 <instant-buildbot> build #3340 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3340 04:01:14 <-- EionRobb1 has quit (Quit: Leaving.) 04:40:27 <instant-buildbot> build #866 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/866 05:15:25 --> bogdan_maris has joined #instantbird 05:45:09 --> EionRobb has joined #instantbird 05:46:38 --> Bollebib has joined #instantbird 08:26:56 --> gerard-majax has joined #instantbird 08:45:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:46:56 --> gerard-majax has joined #instantbird 09:20:40 <-- EionRobb has quit (Quit: Leaving.) 09:22:15 --> EionRobb has joined #instantbird 09:33:23 --> aleth has joined #instantbird 09:33:23 * ChanServ sets mode +o aleth 10:00:55 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:04:35 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:05:39 --> gerard-majax has joined #instantbird 10:10:18 <-- aleth has quit (Ping timeout: 121 seconds) 10:13:49 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:13:57 --> aleth has joined #instantbird 10:13:57 * ChanServ sets mode +o aleth 10:23:10 --> flo-retina has joined #instantbird 10:23:10 * ChanServ sets mode +qo flo-retina flo-retina 10:29:18 <-- aleth has quit (Ping timeout: 121 seconds) 10:38:33 --> gerard-majax has joined #instantbird 10:51:38 --> aleth has joined #instantbird 10:51:38 * ChanServ sets mode +o aleth 10:54:42 --> BWMerlin has joined #instantbird 12:12:56 --> clokep_work has joined #instantbird 12:12:56 * ChanServ sets mode +o clokep_work 12:19:29 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 12:19:38 --> chrisccoulson has joined #instantbird 12:22:56 <-- BWMerlin has quit (Ping timeout: 121 seconds) 13:47:47 <-- aleth has quit (Quit: Instantbird 52) 13:47:50 --> aleth has joined #instantbird 13:47:50 * ChanServ sets mode +o aleth 14:16:31 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:36:47 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:13:06 --> abdelrhman has joined #instantbird 16:35:06 --> gerard-majax has joined #instantbird 16:43:43 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:49:27 --> gerard-majax has joined #instantbird 16:52:31 <-- FilipMosner has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:55:46 --> arlolra has joined #instantbird 17:02:10 --> mconley|livehacking has joined #instantbird 17:05:32 <-- flo-retina has quit (Ping timeout: 121 seconds) 17:06:59 --> flo-retina has joined #instantbird 17:06:59 * ChanServ sets mode +qo flo-retina flo-retina 17:08:17 <-- abdelrhman has quit (Connection closed) 17:08:40 --> abdelrhman has joined #instantbird 17:12:21 <-- abdelrhman has quit (Connection closed) 17:13:38 --> abdelrhman has joined #instantbird 17:15:09 --> FilipMosner has joined #instantbird 17:20:33 <-- abdelrhman has quit (Connection closed) 17:24:53 --> abdelrhman has joined #instantbird 17:26:14 <flo-retina> Unhandled IRC message: :jib!jib@moz-j7m6lt.dyn.optonline.net NICK jib|away irc.js:682 17:26:14 <flo-retina> Error running command NICK with handler RFC 2812: 17:26:14 <flo-retina> {"rawMessage":":jib|away!jib@moz-j7m6lt.dyn.optonline.net NICK jib","command":"NICK","params":["jib"],"origin":"jib|away","user":"jib","host":"moz-j7m6lt.dyn.optonline.net","tags":{},"source":"jib@moz-j7m6lt.dyn.optonline.net"} 17:26:14 <flo-retina> msg is not defined 17:26:17 <flo-retina> is that known? 17:26:27 <flo-retina> "msg is not defined" seems like a JS error 17:27:53 <freaktechnik> does it dare to give line numbers? 17:28:01 <freaktechnik> oh, I see it 17:28:02 <freaktechnik> I'm blind 17:29:08 <arlolra> flo-retina: can I bug you to look at the two remaining patches in https://bugzilla.mozilla.org/show_bug.cgi?id=955642 ? 17:29:11 <instantbot> Bug 955642 enh, --, ---, arlolra, ASSI, Handle Twitter direct messages (DMs) 17:29:11 <freaktechnik> oh wait, that's just where the error gets printed. 17:30:47 <freaktechnik> flo-retina: that must be https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#1313 17:31:27 <freaktechnik> where msg was probably supposed to be the nick change message in the buddy conv? 17:35:06 <-- abdelrhman has quit (Ping timeout: 121 seconds) 17:37:23 <flo-retina> arlolra: I r+'ed the trivial one. I don't understand the other one; where is this large block of code handling entities being moved to? 17:38:18 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:39:21 <arlolra> flo-retina: it's relying on twitter-text.jsm 17:40:21 <flo-retina> arlolra: alright, more specific question. Where are the title= HTML attributes being created after applying your patchset? 17:44:42 <arlolra> like https://github.com/mozilla/releases-comm-central/blob/master/chat/protocols/twitter/twitter-text.jsm#L457 17:45:42 <arlolra> sorry, it's been like 3months waiting for review 17:50:57 <arlolra> in one of the comment I wrote, "* Uses Twitter's autoLinker (rather than the custom parser) to add mentions and links" 17:54:50 <aleth> freaktechnik: looks like nothing is defining msg in that function, indeed. Surprising this hasn't been spotted before 17:55:07 <freaktechnik> and it's been like this since a long time from what I can tell 17:55:19 <flo-retina> aleth: there's enough noise in the error console that looking at it is demotivating :( 17:55:35 <freaktechnik> I guess nobody missed the nick change message in buddy convs. 17:57:21 <flo-retina> arlolra: I doubt twitter's autolinker is going to add <span class="ib-person"> 17:57:25 <aleth> flo-retina: maybe updateNick writes a message too? 17:57:53 <aleth> eh, that was for freaktechnik 17:58:05 <freaktechnik> no idea 17:58:17 <freaktechnik> irc.js confuses me every time 17:58:23 <freaktechnik> so many things happening all over the place 18:00:24 <aleth> arlolra: I suspect that patch has bitrotted a bit anyway, so you can put back the ib-person span when you update it 18:02:16 <arlolra> flo-retina: aha, thanks. can you add that as review on the bug though and r- 18:02:50 <arlolra> it would be helpful to have a complete review to go on before reworkingit 18:03:24 <instantbot> New Chat Core - IRC bug 1313137 filed by aleth@instantbird.org. 18:03:26 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1313137 nor, --, ---, nobody, NEW, "msg is not defined" error in irc.js:changeBuddyNick 18:03:43 <arlolra> aleth: will do 18:09:32 <clokep_work> Doesn't changeBuddyNick actually have tests? :-S 18:09:59 <clokep_work> Ah I was thinking of https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/test/test_tryNewNick.js 18:11:29 <flo-retina> arlolra: the main review comment is: before reviewing line by line, I would like to be sure the behavior stays the same or similar (ie. doesn't regress) when hovering and clicking links, @mentions and #hashtags 18:11:31 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:18:53 <clokep_work> aleth: Did you test that? 18:18:59 <clokep_work> Looks fine to me, but I don't have time to test it right now. 18:19:00 <aleth> No. 18:19:03 <clokep_work> Heh. 18:19:10 <aleth> I don't have time to test it right now either ;) 18:19:21 <aleth> But it should be tested before landing... 18:23:46 <clokep_work> I can't find when it changed either, but that's OK. 18:39:56 <-- EionRobb has quit (Quit: Leaving.) 18:43:38 <-- Mook_as has quit (Ping timeout: 121 seconds) 18:44:04 --> Mook_as has joined #instantbird 18:52:33 <-- Mook_as has quit (Ping timeout: 121 seconds) 18:54:40 --> Mook_as has joined #instantbird 19:02:43 <-- Mook_as has quit (Ping timeout: 121 seconds) 19:17:44 * aleth is now known as alethaleth 19:18:24 * alethaleth is now known as aleth 19:23:48 * aleth is now known as alethaleth 19:24:03 * alethaleth is now known as aleth 19:27:48 <instantbot> aleth@instantbird.org changed the Resolution on bug 1313137 from --- to FIXED. 19:27:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1313137 nor, --, Instantbird 52, aleth, RESO FIXED, "msg is not defined" error in irc.js:changeBuddyNick 19:35:53 <clokep_work> Thanks. :) 20:09:21 --> Mook_as has joined #instantbird 20:10:49 <-- mconley|livehacking has quit (Quit: NO CARRIER) 20:11:00 <-- arlolra has quit (Client exited) 20:27:08 --> EionRobb has joined #instantbird 21:14:08 --> flo-retina has joined #instantbird 21:14:09 * ChanServ sets mode +qo flo-retina flo-retina 21:20:03 <-- aleth has quit (Quit: Instantbird 52) 21:20:29 --> aleth has joined #instantbird 21:20:29 * ChanServ sets mode +o aleth 21:29:15 <-- Bollebib has quit (Ping timeout: 121 seconds) 21:41:23 <-- clokep_work has quit (Ping timeout: 121 seconds) 22:26:06 --> Mook_ib has joined #instantbird 22:27:35 <-- Mook_as has quit (Ping timeout: 121 seconds) 22:27:35 * Mook_ib is now known as Mook_as 22:30:20 --> unghost has joined #instantbird 23:41:50 --> clokep_work has joined #instantbird 23:41:51 * ChanServ sets mode +o clokep_work 23:44:40 <-- aleth has quit (Quit: Instantbird 52)