All times are UTC.
00:03:10 --> Alex2 has joined #instantbird 00:10:51 --> clokep_work has joined #instantbird 00:10:51 * ChanServ sets mode +o clokep_work 00:17:27 <-- clokep_work has quit (Ping timeout: 121 seconds) 00:19:55 --> clokep_work has joined #instantbird 00:19:55 * ChanServ sets mode +o clokep_work 00:23:57 <-- clokep_work has quit (Ping timeout: 121 seconds) 00:51:51 --> clokep_work has joined #instantbird 00:51:51 * ChanServ sets mode +o clokep_work 00:54:02 <-- unghost has quit (A TLS packet with unexpected length was received.) 00:55:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:09:52 --> clokep_work has joined #instantbird 01:09:52 * ChanServ sets mode +o clokep_work 01:13:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:19:58 --> clokep_work has joined #instantbird 01:19:58 * ChanServ sets mode +o clokep_work 01:24:00 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:38:52 --> clokep_work has joined #instantbird 01:38:52 * ChanServ sets mode +o clokep_work 01:42:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:50:57 --> clokep_work has joined #instantbird 01:50:57 * ChanServ sets mode +o clokep_work 01:54:59 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:01:51 --> clokep_work has joined #instantbird 02:01:51 * ChanServ sets mode +o clokep_work 02:05:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:31:48 --> clokep_work has joined #instantbird 02:31:48 * ChanServ sets mode +o clokep_work 02:35:50 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:52:04 --> clokep_work has joined #instantbird 02:52:04 * ChanServ sets mode +o clokep_work 02:56:06 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:01:02 --> clokep_work has joined #instantbird 03:01:02 * ChanServ sets mode +o clokep_work 03:05:04 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:11:01 --> clokep_work has joined #instantbird 03:11:01 * ChanServ sets mode +o clokep_work 03:15:02 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:21:51 --> clokep_work has joined #instantbird 03:21:51 * ChanServ sets mode +o clokep_work 03:25:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:29:56 --> clokep_work has joined #instantbird 03:29:56 * ChanServ sets mode +o clokep_work 03:33:58 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:40:51 --> clokep_work has joined #instantbird 03:40:51 * ChanServ sets mode +o clokep_work 03:42:44 <instant-buildbot> build #3339 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3339 03:44:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:01:55 --> clokep_work has joined #instantbird 04:01:55 * ChanServ sets mode +o clokep_work 04:05:57 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:10:51 --> clokep_work has joined #instantbird 04:10:51 * ChanServ sets mode +o clokep_work 04:14:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:23:06 --> clokep_work has joined #instantbird 04:23:06 * ChanServ sets mode +o clokep_work 04:27:08 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:29:50 --> clokep_work has joined #instantbird 04:29:50 * ChanServ sets mode +o clokep_work 04:31:09 <instant-buildbot> build #865 of linux64-nightly-default is complete: Failure [4failed shell_6] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/865 04:33:52 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:42:50 --> clokep_work has joined #instantbird 04:42:50 * ChanServ sets mode +o clokep_work 04:46:52 <-- clokep_work has quit (Ping timeout: 121 seconds) 05:15:07 --> EionRobb1 has joined #instantbird 05:15:24 <-- EionRobb1 has quit (Quit: Leaving.) 05:15:46 --> EionRobb1 has joined #instantbird 05:18:22 <-- EionRobb has quit (Ping timeout: 121 seconds) 05:20:48 --> clokep_work has joined #instantbird 05:20:48 * ChanServ sets mode +o clokep_work 05:22:03 <-- EionRobb1 has quit (Ping timeout: 121 seconds) 05:24:50 <-- clokep_work has quit (Ping timeout: 121 seconds) 05:30:04 --> clokep_work has joined #instantbird 05:30:04 * ChanServ sets mode +o clokep_work 05:31:54 --> EionRobb has joined #instantbird 05:34:05 <-- clokep_work has quit (Ping timeout: 121 seconds) 05:40:50 --> clokep_work has joined #instantbird 05:40:50 * ChanServ sets mode +o clokep_work 05:44:52 <-- clokep_work has quit (Ping timeout: 121 seconds) 05:51:00 --> clokep_work has joined #instantbird 05:51:00 * ChanServ sets mode +o clokep_work 05:55:02 <-- clokep_work has quit (Ping timeout: 121 seconds) 06:01:05 --> clokep_work has joined #instantbird 06:01:05 * ChanServ sets mode +o clokep_work 06:05:07 <-- clokep_work has quit (Ping timeout: 121 seconds) 06:09:51 --> clokep_work has joined #instantbird 06:09:51 * ChanServ sets mode +o clokep_work 06:13:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 06:21:01 --> clokep_work has joined #instantbird 06:21:01 * ChanServ sets mode +o clokep_work 06:25:03 <-- clokep_work has quit (Ping timeout: 121 seconds) 06:32:15 --> Bollebib has joined #instantbird 06:39:52 --> clokep_work has joined #instantbird 06:39:52 * ChanServ sets mode +o clokep_work 06:43:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 06:45:43 --> bogdan_maris has joined #instantbird 07:20:51 --> clokep_work has joined #instantbird 07:20:51 * ChanServ sets mode +o clokep_work 07:24:45 <-- bogdan_maris has quit (Connection closed) 07:24:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 07:46:56 --> clokep_work has joined #instantbird 07:46:56 * ChanServ sets mode +o clokep_work 07:50:59 <-- clokep_work has quit (Ping timeout: 121 seconds) 08:00:37 --> bogdan_maris has joined #instantbird 08:15:35 --> clokep_work has joined #instantbird 08:15:35 * ChanServ sets mode +o clokep_work 08:19:37 <-- clokep_work has quit (Ping timeout: 121 seconds) 08:31:51 --> clokep_work has joined #instantbird 08:31:51 * ChanServ sets mode +o clokep_work 08:35:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 08:37:36 --> gerard-majax has joined #instantbird 08:56:57 --> clokep_work has joined #instantbird 08:56:57 * ChanServ sets mode +o clokep_work 09:00:59 <-- clokep_work has quit (Ping timeout: 121 seconds) 09:10:17 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:10:23 --> aleth has joined #instantbird 09:10:23 * ChanServ sets mode +o aleth 09:10:52 --> clokep_work has joined #instantbird 09:10:52 * ChanServ sets mode +o clokep_work 09:14:54 <-- clokep_work has quit (Ping timeout: 121 seconds) 09:43:43 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:51:57 --> gerard-majax has joined #instantbird 09:56:28 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 10:23:00 --> flo-retina has joined #instantbird 10:23:00 * ChanServ sets mode +qo flo-retina flo-retina 10:37:50 --> BWMerlin has joined #instantbird 10:48:30 --> unghost has joined #instantbird 12:23:51 --> clokep_work has joined #instantbird 12:23:51 * ChanServ sets mode +o clokep_work 12:40:10 <-- BWMerlin has quit (Ping timeout: 121 seconds) 14:29:11 <flo-retina> is http://pastebin.instantbird.com/ down? 14:31:11 <clokep_work> flo-retina: Yes. 14:31:16 <clokep_work> Has been for a few days, I think. 14:31:35 <flo-retina> :-S 14:31:53 <aleth> You could close it down and redirect to pastebin.mozilla.org? 14:32:06 <flo-retina> yeah 15:02:42 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:58:42 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:12:01 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:12:05 --> clokep_work has joined #instantbird 16:12:05 * ChanServ sets mode +o clokep_work 16:26:05 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:31:55 --> gerard-majax has joined #instantbird 16:43:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:46:45 --> gerard-majax has joined #instantbird 17:09:17 --> dxdx has joined #instantbird 17:09:19 <-- dxdx has quit (Quit: leaving) 17:40:33 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:48:07 --> flo-retina has joined #instantbird 17:48:07 * ChanServ sets mode +qo flo-retina flo-retina 18:46:16 --> DGMurdockIII has joined #instantbird 19:10:35 <-- EionRobb has quit (Quit: Leaving.) 19:48:16 --> EionRobb has joined #instantbird 19:50:04 <-- DGMurdockIII has quit (Quit: Leaving) 19:51:02 --> EionRobb1 has joined #instantbird 19:53:52 <-- EionRobb has quit (Ping timeout: 121 seconds) 20:14:04 <freaktechnik> Is there a bug for favoriting tweets? If there is I'd like to take that one, I miss faving 20:40:01 <clokep_work> freaktechnik: I doubt it. It should be a few lines of code. 20:40:28 <freaktechnik> adding two context menu items, showing them when appropriate and adding the actions, yeah 20:42:04 <clokep_work> freaktechnik: https://dxr.mozilla.org/comm-central/source/chat/protocols/twitter/twitter.js#53-99 21:07:33 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:09:59 --> abdelrhman has joined #instantbird 21:17:53 <abdelrhman> aleth: After removing an account from account manager (in im), it's difficult to notify the account manager (accounts setting page) that the account is deleted. Any suggestions? 21:19:36 <abdelrhman> accounts setting page in Thunderbird 21:20:05 <-- abdelrhman has quit (Connection closed) 21:31:07 --> abdelrhman has joined #instantbird 21:38:04 <-- abdelrhman has quit (Connection closed) 21:38:46 --> abdelrhman has joined #instantbird 21:43:14 <aleth> abdelrhman: what needs to happen in response to the notification? 21:46:13 <aleth> iirc in your last patch imAccounts.js already got notified 21:48:48 <-- abdelrhman has quit (Connection closed) 21:48:53 --> abdelrhman has joined #instantbird 21:55:21 <abdelrhman> aleth: re-build of the account's tree (https://dxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/AccountManager.js#1579) 21:56:40 <aleth> You mean at the moment after successful deletion the entry doesn't disappear from the account list? 21:57:22 <abdelrhman> Yes 21:57:53 <aleth> Without your patch, after the account is deleted, an account-removed notification is fired that removes the entry 21:58:04 <aleth> so check why after your changes that doesn't happen 21:58:26 <aleth> e.g. https://dxr.mozilla.org/comm-central/source/im/content/accounts.js#142 21:59:50 <aleth> I'm surprised your changes affect this 22:02:35 <abdelrhman> This file is related to IB and this (https://dxr.mozilla.org/comm-central/source/mail/components/im/content/imAccounts.js#146) is for Chat status page in TB, but what I'm talking about is account setting page that has mail and im accounts together 22:02:59 <aleth> Ah, so it works, but not in that Thunderbird dialog? 22:03:09 <abdelrhman> Yes 22:04:12 <aleth> Sounds like a Thunderbird bug that's independent of your patch then 22:04:25 <aleth> i.e. the same problem should happen if you delete an IRC account 22:04:37 <aleth> If that's the case, file a separate bug for this 22:05:16 <abdelrhman> And when it tries to re-build the list, this error happens (https://dxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/AccountManager.js#1579) 22:06:06 <aleth> :-( 22:09:25 <-- abdelrhman has quit (Ping timeout: 121 seconds) 22:10:04 --> abdelrhman has joined #instantbird 22:10:30 <aleth> clearly something somewhere in mail is not listening to account-removed and should ;) 22:14:51 <aleth> does this get called? https://dxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/AccountManager.js#1463 22:31:07 <abdelrhman> you mean "onServerUnloaded"? 22:31:16 <aleth> yes 22:32:16 <abdelrhman> I don't know what this is for? 22:32:46 <aleth> I'm guessing that's what gets called when a mail account is removed 22:35:07 <abdelrhman> yes, you're right 22:36:05 <aleth> So when a chat account gets removed, it should probably be called as well, when account-removed fires from chat/. But something doesn't seem to be wired up correctly 22:37:18 <aleth> note the imAccount in TB is a property of an incomingServer 22:38:17 <abdelrhman> yes, it's called 22:38:48 <aleth> but does it get called after account-removed (correct) or before? 22:39:49 --> clokep_work has joined #instantbird 22:39:49 * ChanServ sets mode +o clokep_work 22:39:51 <abdelrhman> account-removed in https://dxr.mozilla.org/comm-central/source/mail/components/im/content/imAccounts.js#146? 22:40:12 <aleth> no, that's the listener of the account manager dialog 22:40:28 <aleth> if I'm not mistaken ;) 22:41:33 <aleth> Here's where the notification is sent from https://dxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#1083 22:41:33 <abdelrhman> Ah, I got what you mean 22:42:09 <aleth> I'm guessing things aren't happening in the right order for some reason 22:43:00 <aleth> account-removed also seems to be observed here, but at first glance that doesn't seem to affect the incomingServer 22:43:01 <aleth> https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#975 22:44:48 <aleth> here's where the incomingServer is created, for comparison https://dxr.mozilla.org/comm-central/source/mail/components/im/content/imAccountWizard.js#322 22:45:06 <-- EionRobb1 has quit (Connection closed) 22:45:59 --> EionRobb has joined #instantbird 22:47:45 <-- Bollebib has quit (Ping timeout: 121 seconds) 22:49:01 <abdelrhman> onServerUnloaded is called before account-removed 22:54:27 <aleth> so removing an IRC account seems to work for me 22:56:01 <aleth> but that may be because calling onServerUnloaded early never mattered before 22:56:53 <abdelrhman> yes 22:57:05 <abdelrhman> https://dxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgAccountManager.cpp#556,565 22:57:12 <abdelrhman> https://dxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#44 22:59:32 <aleth> Probably imIncomingServer.js needs to be improved 23:01:56 <aleth> it seems clearAllValues is intended to be pretty final https://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgIncomingServer.idl#333 23:06:15 <aleth> abdelrhman: I'd never noticed before that it's not possible to delete a chat account from the account manager dialog in TB 23:08:23 <aleth> I wonder why that is 23:09:29 <aleth> abdelrhman: this might be interesting https://dxr.mozilla.org/comm-central/source/mailnews/base/public/nsIMsgIncomingServer.idl#440 23:09:51 <aleth> I don't know how it's used 23:10:50 <abdelrhman> Seems it's used for IMAP 23:11:16 <aleth> hmm, it probably refers to emails, not to the account 23:11:44 <abdelrhman> yes 23:14:52 <aleth> assuming one tries to manage without touching nsMsgAccountManager.cpp, it's possible the imIncomingServer.js might have to recreate/reregister the incomingserver object if the delete on server process goes wrong 23:16:33 <aleth> there may be a better way of course 23:17:11 <aleth> If it looks like the TB part of this bug is getting super complicated, it might be better to focus on the in band registration stuff first, which probably doesn't need much TB specific stuff 23:17:28 <abdelrhman> The account is not removed while trying to delete on server 23:17:42 <abdelrhman> so I think there is no need for recreation 23:17:58 <-- abdelrhman has quit (Connection closed) 23:18:31 <-- clokep_work has quit (Ping timeout: 121 seconds) 23:18:37 --> abdelrhman has joined #instantbird 23:19:16 <aleth> abdelrhman: well, that's because currently https://dxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#44 doesn't call deleteAccount with the deleteOnServer boolean set, right? ;) 23:19:47 --> clokep_work has joined #instantbird 23:19:47 * ChanServ sets mode +o clokep_work 23:19:57 <aleth> in which case I'm even more surprised you're seeing errors 23:21:42 <aleth> gtg 23:22:10 <-- aleth has quit (Quit: Instantbird 52) 23:22:39 <-- abdelrhman has quit (Ping timeout: 121 seconds) 23:22:51 --> abdelrhman has joined #instantbird 23:23:49 <-- clokep_work has quit (Ping timeout: 121 seconds) 23:32:40 <-- abdelrhman has quit (Connection closed) 23:33:08 --> abdelrhman has joined #instantbird 23:58:02 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)