All times are UTC.
01:37:23 --> Alex1 has joined #instantbird 02:27:27 <-- EionRobb has quit (Ping timeout: 121 seconds) 02:36:48 --> EionRobb has joined #instantbird 02:40:12 --> clokep_work has joined #instantbird 02:40:12 * ChanServ sets mode +o clokep_work 03:17:36 <-- EionRobb has quit (Quit: Leaving.) 03:22:35 <-- clokep_work has quit (Ping timeout: 121 seconds) 03:45:48 <instant-buildbot> build #3335 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3335 03:50:29 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:50:39 --> nhnt11 has joined #instantbird 03:50:39 * ChanServ sets mode +h nhnt11 03:50:41 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:50:51 --> nhnt11 has joined #instantbird 03:50:51 * ChanServ sets mode +h nhnt11 04:12:30 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:15:31 <instant-buildbot> build #861 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/861 04:23:20 --> Bollebib has joined #instantbird 05:03:10 --> EionRobb has joined #instantbird 05:06:32 <-- EionRobb has quit (Connection closed) 05:07:00 --> EionRobb has joined #instantbird 05:29:33 <-- Bollebib has quit (Ping timeout: 121 seconds) 05:30:47 --> bogdan_maris has joined #instantbird 05:45:13 <-- DGMurdockIII has quit (Quit: Leaving) 06:08:26 --> nhnt11 has joined #instantbird 06:08:27 * ChanServ sets mode +h nhnt11 07:08:24 --> chrisccoulson has joined #instantbird 07:15:56 --> aleth has joined #instantbird 07:15:56 * ChanServ sets mode +o aleth 07:26:24 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 07:38:10 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:38:31 --> nhnt11 has joined #instantbird 07:38:31 * ChanServ sets mode +h nhnt11 07:45:40 --> chrisccoulson has joined #instantbird 08:12:17 --> gerard-majax has joined #instantbird 08:37:53 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:40:39 --> gerard-majax has joined #instantbird 09:02:13 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:21:55 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 09:24:34 --> bogdan_maris has joined #instantbird 09:43:21 --> gerard-majax has joined #instantbird 10:00:53 <-- Tonnes has quit (Connection closed) 10:02:12 --> Tonnes has joined #instantbird 10:07:09 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 10:27:05 <-- Alex1 has quit (Connection closed) 10:55:25 --> clokep_work has joined #instantbird 10:55:26 * ChanServ sets mode +o clokep_work 11:20:18 --> Bollebib has joined #instantbird 11:31:12 --> chrisccoulson has joined #instantbird 11:32:39 <clokep_work> So who wants to review something dumb? :P 11:40:53 <-- clokep_work has quit (Ping timeout: 121 seconds) 12:12:34 --> clokep_work has joined #instantbird 12:12:34 * ChanServ sets mode +o clokep_work 12:49:23 --> bogdan_maris1 has joined #instantbird 12:49:29 <-- bogdan_maris has quit (Connection closed) 12:50:05 * bogdan_maris1 is now known as bogdan_maris 13:00:22 <-- dustinm` has quit (A TLS packet with unexpected length was received.) 13:32:08 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 13:38:08 --> dustinm` has joined #instantbird 14:11:58 <-- aleth has quit (Ping timeout: 121 seconds) 14:25:36 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:14:02 <clokep_work> nhnt11, Fallen|pto: Do you know if there's a way to extend the amount of data shown to me during failed unit tests? 15:14:13 <clokep_work> E.g. I'm trying to do an equals...and it only shows half the stuff. 15:14:17 <clokep_work> And they look equal to me. :-D 15:14:53 <nhnt11> clokep_work: I'll need more context :( 15:15:00 <nhnt11> what data do you want and what is it providing? 15:15:07 * nhnt11 is tempted to just say "add dumps" 15:16:30 <Fallen|pto> do_print() ? 15:16:58 <clokep_work> OK. So there's no way to extend what deepEqual prints thoug? 15:17:03 <clokep_work> When I add dumps they look the same. 15:17:05 <Fallen|pto> and for most assertions there is a third parameter that allows you to display a message on failure 15:17:34 <Fallen|pto> (which would have to contain a serialized copy of the data) 15:19:43 <clokep_work> https://pastebin.mozilla.org/8920724 15:19:46 <clokep_work> It truncates it. :( 15:19:50 <clokep_work> Meh I'll figure it out. 15:21:35 <nhnt11> clokep_work: ah, would you like some better indication of what exactly doesn't match? 15:21:53 <clokep_work> Yes. 15:23:33 * nhnt11 doesn't know of anything that would help you, sorry :( 15:24:08 <nhnt11> If you could attach a debugger set a breakpoint in the test and use an object explorer or something, that might help I suppose 15:26:06 <clokep_work> Meh....OK 15:26:13 <clokep_work> So the strinigifed versions *are* equal. 15:26:15 <clokep_work> The obejcts are not. 15:26:30 <nhnt11> huh 15:26:34 <nhnt11> can you share code? 15:27:43 <clokep_work> Oh I see... 15:27:51 <clokep_work> There's a Map. I bet that's the problem. 15:28:01 <nhnt11> ah, that would make sense 15:28:36 <nhnt11> clokep_work: If that's the case, you might want to file a bug reporting that deepEqual doesn't work with Maps 15:28:48 <nhnt11> Personally I would expect it to compare the contents of the Maps 15:28:52 <clokep_work> Yep! 15:29:23 <clokep_work> Meh...it doesn't seem to work though. :-S 15:40:54 <clokep_work> Doing deepEqual(new Map(), new Map()) works fine... 15:56:23 <clokep_work> So turns out there was a couple of keys missing. 15:56:32 <clokep_work> But they weren't printed out via JSON.stringify. 15:56:35 <clokep_work> Because the values were undefined. 15:56:37 <clokep_work> Which is shitty. 15:58:29 <Fallen|pto> deepEqual probably converts it into a string or something 15:59:12 --> aleth has joined #instantbird 15:59:12 * ChanServ sets mode +o aleth 15:59:24 <Fallen|pto> I'd go with for (let [k,v] of map.entries()) { equal(othermap.get(k), v, `Mismatch in ${k} property`); } 15:59:29 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:05:11 <nhnt11> "21:26:27 - clokep_work: But they weren't printed out via JSON.stringify. 16:05:11 <nhnt11> 21:26:30 - clokep_work: Because the values were undefined." 16:05:18 <nhnt11> that sucks :(\ 16:05:31 <nhnt11> sorry for the pings 16:05:58 <clokep_work> It's fine. ;) 16:06:07 <clokep_work> Fallen|pto: It doesn't. 16:06:14 <clokep_work> The whole point is that it does it recursively via objects. 16:06:45 <Fallen|pto> ah ok. If you want to use JSON.stringify, maybe you can use one of those replacer functions to replace undefined with null? 16:07:05 <aleth> JSON.stringify doesn't work for Maps at all, no matter what the value 16:07:16 <clokep_work> I don't *want* to use it. 16:07:22 <clokep_work> I was just trying to add dump statements. 16:07:25 <clokep_work> To debug WTF was happening. 16:07:57 <aleth> Fallen|pto: if I understand right, the problem is that deepEqual uses it for its error output 16:08:58 <Fallen|pto> hm ok, sounds like a complicated solution for a seemingly simple thing :-( 16:11:28 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:11:57 <clokep_work> Meh. I just found an unrelated bug. :( 16:30:35 <clokep_work> I'm finding this super frustrating. 16:30:46 <clokep_work> It's disappointing that my experiences with JS have all been terrible recently. 16:30:53 <clokep_work> Makes me want to give up on the language for anything "real". 16:32:47 <aleth> iirc I filed some bug about Maps but it turned out they were behaving according to the agreed spec so... 16:33:05 <clokep_work> Typical. 16:33:12 * clokep_work wonders if he can run Python via JavaScript. :P 16:34:50 <aleth> bring back pyxpcom! ;) 16:35:00 <clokep_work> :P 16:35:12 <clokep_work> Maybe https://github.com/pybee/batavia? :P 16:35:22 <clokep_work> Oh right, GitHub doesn't work right now... 16:36:11 <freaktechnik> wouldn't you just deepEqual the .values() of a map or simiar? 16:36:38 <freaktechnik> though I guess if it can deepEqual iterators it would do that with maps in the first place... 16:36:46 <aleth> clokep_work: http://pyjs.org/ ? 16:37:03 <clokep_work> OK, so to be clear: deepEqual works fine on maps. :) 16:37:28 <clokep_work> aleth: Hah, yeah...I've seen that before too. 16:37:59 <freaktechnik> oh, now I see what was frustrating. 16:46:42 <-- clokep_work has quit (Ping timeout: 121 seconds) 16:52:14 --> gerard-majax has joined #instantbird 17:20:38 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:21:52 --> clokep_work has joined #instantbird 17:21:52 * ChanServ sets mode +o clokep_work 17:21:57 --> gerard-majax has joined #instantbird 17:25:59 <-- gerard-majax has quit (Connection closed) 17:26:03 --> gerard-majax has joined #instantbird 17:41:20 <-- aleth has quit (Ping timeout: 121 seconds) 17:42:17 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:50:34 --> aleth has joined #instantbird 17:50:34 * ChanServ sets mode +o aleth 18:53:34 --> gerard-majax has joined #instantbird 18:57:44 --> nhnt11 has joined #instantbird 18:57:44 * ChanServ sets mode +h nhnt11 19:19:05 --> Logicoma has joined #instantbird 19:21:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:25:21 --> gerard-majax has joined #instantbird 19:31:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:33:58 --> gerard-majax has joined #instantbird 19:40:15 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:40:49 --> gerard-majax has joined #instantbird 20:09:47 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:13:36 --> gerard-majax has joined #instantbird 20:18:22 <-- gerard-majax has quit (Ping timeout: 121 seconds) 21:10:16 <-- Logicoma has quit (Connection closed) 22:59:01 <-- Bollebib has quit (Ping timeout: 121 seconds) 23:03:00 <-- aleth has quit (Quit: Instantbird 52)