#instantbird log on 09 26 2016

All times are UTC.

00:14:40 --> Alex2 has joined #instantbird
03:30:35 --> BWMerlin has joined #instantbird
03:37:46 <-- EionRobb has quit (Ping timeout: 121 seconds)
03:41:21 <instant-buildbot> build #3307 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3307
03:41:22 --> EionRobb has joined #instantbird
04:41:14 <instant-buildbot> build #835 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/835
05:00:47 <-- EionRobb has quit (Quit: Leaving.)
05:27:44 --> EionRobb has joined #instantbird
06:17:42 --> bogdan_maris has joined #instantbird
06:57:16 <-- EionRobb has quit (Ping timeout: 121 seconds)
07:00:07 --> EionRobb has joined #instantbird
07:25:27 --> Bollebib has joined #instantbird
07:41:01 --> gerard-majax has joined #instantbird
07:47:32 <-- gerard-majax has quit (Ping timeout: 121 seconds)
07:52:16 --> gerard-majax has joined #instantbird
07:59:04 --> nhnt11 has joined #instantbird
07:59:04 * ChanServ sets mode +h nhnt11 
08:05:04 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:07:44 --> gerard-majax has joined #instantbird
08:18:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:21:18 --> gerard-majax has joined #instantbird
08:27:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:27:49 --> gerard-majax has joined #instantbird
09:00:27 --> aleth has joined #instantbird
09:00:27 * ChanServ sets mode +o aleth 
09:04:45 --> chrisccoulson has joined #instantbird
09:29:47 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
09:37:15 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:40:32 --> chrisccoulson has joined #instantbird
09:51:11 <-- Tonnes has quit (Connection closed)
09:52:02 <-- nhnt11 has quit (Ping timeout: 121 seconds)
09:52:27 --> Tonnes has joined #instantbird
10:01:23 --> nhnt11 has joined #instantbird
10:01:23 * ChanServ sets mode +h nhnt11 
10:02:33 --> flo-retina has joined #instantbird
10:02:33 * ChanServ sets mode +qo flo-retina flo-retina 
10:05:27 <-- nhnt11 has quit (Ping timeout: 121 seconds)
11:41:22 <-- spiffytech has quit (Ping timeout: 121 seconds)
11:42:01 <-- bittin_ has quit (Ping timeout: 121 seconds)
11:44:04 --> bittin_ has joined #instantbird
11:44:50 --> nhnt11 has joined #instantbird
11:44:50 * ChanServ sets mode +h nhnt11 
11:48:04 --> spiffytech has joined #instantbird
12:00:35 <-- GeekShadow has quit (Ping timeout: 121 seconds)
12:02:39 --> GeekShadow has joined #instantbird
12:06:38 <-- Suiseiseki has quit (Ping timeout: 121 seconds)
12:08:49 <-- nhnt11 has quit (Ping timeout: 121 seconds)
12:10:06 --> Suiseiseki has joined #instantbird
12:10:22 --> mpmc has joined #instantbird
12:10:23 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:16:47 --> clokep_work has joined #instantbird
12:16:47 * ChanServ sets mode +o clokep_work 
12:17:08 --> nhnt11 has joined #instantbird
12:17:08 * ChanServ sets mode +h nhnt11 
12:26:18 <clokep_work> Sorry to everyone I owe reviews to!
12:26:23 <clokep_work> I've been very bad at it recently. ;(
12:29:13 <-- nhnt11 has quit (Ping timeout: 121 seconds)
12:38:36 --> nhnt11 has joined #instantbird
12:38:36 * ChanServ sets mode +h nhnt11 
12:51:27 <clokep_work> aleth: So...instead of just modifying the tweet to contain more data they added an additional attribute?! (o_O)
12:54:43 <instantbot> aryx.bugmail@gmx-topmail.de changed the Resolution on bug 1304135 from --- to FIXED.
12:54:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1304135 tri, --, Instantbird 52, aryx.bugmail, RESO FIXED, remove obsolete .toLowerCase() from .localName.toLowerCase()
12:55:14 <instantbot> aryx.bugmail@gmx-topmail.de changed the Resolution on bug 1303720 from --- to FIXED.
12:55:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1303720 enh, --, Instantbird 52, aryx.bugmail, RESO FIXED, Use addEventListener(..., {once: true}) in im and chat code
13:09:25 * clokep_work wonders if he still has that half finished branch adding the facebook prpl...
13:20:03 <-- BWMerlin has quit (Ping timeout: 121 seconds)
13:35:57 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:38:55 <-- nhnt11 has quit (Ping timeout: 121 seconds)
14:00:49 <-- EionRobb has quit (Connection closed)
14:01:25 --> EionRobb has joined #instantbird
14:02:21 --> flo-retina has joined #instantbird
14:02:21 * ChanServ sets mode +qo flo-retina flo-retina 
14:22:02 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
14:22:06 --> chrisccoulson has joined #instantbird
14:24:10 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:24:13 --> clokep_work has joined #instantbird
14:24:13 * ChanServ sets mode +o clokep_work 
14:32:57 --> micahg has joined #instantbird
15:05:09 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:30:21 <instantbot> New Instantbird - Other bug 1305443 filed by aryx.bugmail@gmx-topmail.de.
15:30:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1305443 nor, --, ---, aryx.bugmail, ASSI, Port Bug 843579 - Remove prefix from :any-link
15:53:04 --> nhnt11 has joined #instantbird
15:53:04 * ChanServ sets mode +h nhnt11 
15:57:06 <-- nhnt11 has quit (Ping timeout: 121 seconds)
15:57:36 --> Kommet has joined #instantbird
16:03:35 --> nhnt11 has joined #instantbird
16:03:35 * ChanServ sets mode +h nhnt11 
16:18:47 --> Kagami has joined #instantbird
16:21:33 <-- Suiseiseki has quit (Ping timeout: 121 seconds)
16:31:41 <-- Kommet has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:38:31 <-- Mook_as has quit (Client exited)
16:38:48 --> Mook_as has joined #instantbird
17:05:41 <aleth> clokep_work: apparently there is some mode that sends tweets in a new format without the encapsulation but you can't get that for streams
17:06:09 <clokep_work> Bah Twitter's API sucks.
17:06:19 <clokep_work> aleth: Thanks for the patch. :) It looks good by eye.
17:06:22 <clokep_work> I'll test it...
17:07:35 <clokep_work> I should kick off a build...
17:08:27 <aleth> Btw, in case anyone feels inspired, it looks like there are things like quoted tweets and embedded media in the received JSON that IB doesn't support
17:08:34 <aleth> not sure if those have always been there ;)
17:10:14 * aleth looks vaguely in the direction of freaktechnik
17:10:43 <freaktechnik> those have always been there.
17:10:51 <freaktechnik> they're just links though, which is fine IMP
17:10:53 <freaktechnik> *IMO
17:11:20 <freaktechnik> (to quote a tweet you even just add the permalink to the tweet to the end of the tweet... soo)
17:11:33 <aleth> the quoted tweet seems to be actually there in JSON sometimes
17:12:14 <freaktechnik> I would when you're allowed to see the contents you'd see them. At least that's how I'd expect it to work
17:12:19 <aleth> not sure what a good way to display it in the UI would be... I suppose one could add the text
17:12:44 <freaktechnik> quoting is not really something that can be displayed nicely atm, yeah
17:12:59 <aleth> The media I suppose would mean adding and whitelisting img tags, that might not be too hard
17:14:45 <freaktechnik> I currently use https://github.com/freaktechnik/twitch-provider/blob/master/lib/twitch/conversation.js#L72-L80 to be able to insert custom remote emotes.
17:15:21 <freaktechnik> (I can't use the smiley system for that from what I understand, since the actual emotes are user or channel specific)
17:16:53 <aleth> I think the way to formalize that would be to add an extra mode here that permits images https://dxr.mozilla.org/comm-central/source/chat/modules/imContentSink.jsm?q=path%3Aimcontentsink&redirect_type=single#73
17:17:45 <aleth> You could then turn it on in Preferences/Content
17:18:44 <freaktechnik> some protocols have explicit image attachments, I think the prplIMessage even has a field for one image, so the conversation view would then just have to figure out if it's allowed to make images based on that pref? Or would that be exempt because it happens in the XBL binding and not the provider?
17:20:11 <aleth> it does?
17:20:41 <aleth> That would be another way to do it I suppose - expand the idl and then add code to the frontend to make use of it
17:21:02 <aleth> The difference is where the img tag gets added - in the prpl or in the frontend
17:22:49 <aleth> If you did it via a field in prplIMessage, you'd add it when the message gets converted for displaying, in imThemes.jsm
17:23:40 <freaktechnik> I was wrong, prplIMessage only has a containsImage flag.
17:23:59 <freaktechnik> yeah, I know a couple protocols like twitter and slack would use that.
17:24:01 <freaktechnik> I assume skype too
17:24:15 <aleth> I'm not sure how libpurple expects containsImage to be used
17:24:45 <aleth> flo-retina probably knows more about this
17:27:18 <freaktechnik> -> for reference of the discussion about this a year ago https://bugzilla.mozilla.org/show_bug.cgi?id=1209854
17:27:20 <instantbot> Bug 1209854 enh, --, ---, nobody, NEW, Have some way of displaying messages which have images
17:27:59 * flo-retina doesn't remember containsImage
17:28:17 <aleth> It seems to me the first approach I suggested would be easiest, but I haven't thought about it much
17:36:33 <freaktechnik> I think having a field for attachments is generally better for being themeable.
17:38:00 <clokep_work> Does the location of the image matter at all?
17:40:21 <aleth> Themes generally work via CSS rules, so as long as imThemes adds appropriate classes to any img you should be fine
17:45:48 <freaktechnik> but if protocols can add images anywhere a theme may break the message layout, or has to account for the image being able to be everywhere. Most "attachment" images would always be after the message on their own line.
17:47:37 <aleth> you shouldn't usually do anything that will completely break in themes that are missing custom code
17:47:46 <aleth> For twitter, adding images at the end seems fine though?
17:48:02 <aleth> Twitch is harder...
17:49:28 <aleth> Twitch sounds less like "add an image" than "add custom smileys" so it's probably easier to tweak imSmiley.jsm for that use case
17:50:10 <freaktechnik> not really
17:50:27 <freaktechnik> since I have emote sets per user and per conversation.
18:01:24 --> DGMurdockIII has joined #instantbird
18:13:40 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:15:01 <-- nhnt11 has quit (Connection closed)
18:15:07 --> nhnt11 has joined #instantbird
18:15:07 * ChanServ sets mode +h nhnt11 
18:17:48 --> Logicoma has joined #instantbird
18:29:08 <clokep_work> Meh, my build failed...
18:33:43 <-- EionRobb has quit (Quit: Leaving.)
18:49:44 <aleth> nightlies were ok
18:54:28 <-- chrisccoulson has quit (Connection closed)
19:20:41 --> chrisccoulson has joined #instantbird
19:25:15 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:30:50 --> chrisccoulson has joined #instantbird
19:32:04 --> gerard-majax has joined #instantbird
19:38:46 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:41:50 --> gerard-majax has joined #instantbird
19:42:58 --> EionRobb has joined #instantbird
19:47:52 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:27:04 <-- Logicoma has quit (Ping timeout: 121 seconds)
20:27:29 --> Logicoma has joined #instantbird
20:27:43 <-- Logicoma has quit (Connection closed)
21:02:15 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:05:56 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
22:10:37 --> chrisccoulson has joined #instantbird
22:17:31 <-- nhnt11 has quit (Ping timeout: 121 seconds)
22:31:35 --> gerard-majax has joined #instantbird
22:37:55 <-- gerard-majax has quit (Ping timeout: 121 seconds)
22:38:45 --> gerard-majax has joined #instantbird
22:40:18 <-- aleth has quit (Quit: Instantbird 52)
22:44:55 <-- gerard-majax has quit (Ping timeout: 121 seconds)
23:35:59 <-- Bollebib has quit (Ping timeout: 121 seconds)