All times are UTC.
00:21:17 --> Alex2 has joined #instantbird 00:39:57 --> abdelrhman has joined #instantbird 00:48:00 <-- abdelrhman has quit (Ping timeout: 121 seconds) 00:53:08 --> abdelrhman has joined #instantbird 00:59:19 <-- abdelrhman has quit (Ping timeout: 121 seconds) 01:25:13 --> EionRobb1 has joined #instantbird 01:26:46 <-- EionRobb has quit (Ping timeout: 121 seconds) 03:02:49 <instant-buildbot> build #3212 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3212 03:26:03 <-- micahg has quit (Ping timeout: 121 seconds) 03:31:05 --> micahg has joined #instantbird 04:03:24 <instant-buildbot> build #743 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/743 05:19:46 <-- Alex2 has quit (Ping timeout: 121 seconds) 05:26:10 <-- EionRobb1 has quit (Quit: Leaving.) 06:10:38 --> gerard-majax has joined #instantbird 06:12:54 --> EionRobb has joined #instantbird 06:15:41 --> bogdan_maris has joined #instantbird 06:29:57 <-- gerard-majax has quit (Ping timeout: 121 seconds) 06:30:42 --> gerard-majax has joined #instantbird 06:41:52 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:23:41 --> abdelrhman has joined #instantbird 07:58:50 --> gerard-majax has joined #instantbird 08:10:50 --> aleth has joined #instantbird 08:10:50 * ChanServ sets mode +o aleth 08:56:44 --> BWMerlin has joined #instantbird 09:10:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:12:15 --> chrisccoulson has joined #instantbird 09:12:35 <-- chrisccoulson has quit (Connection closed) 09:14:01 <-- stux has quit (Ping timeout: 121 seconds) 09:14:22 --> chrisccoulson has joined #instantbird 09:16:49 --> stux has joined #instantbird 10:16:00 <aleth> Looks like it's time to replace the error console 10:16:10 <aleth> ah http://log.bezut.info/instantbird/160626#m34 10:19:56 --> flo-retina has joined #instantbird 10:19:56 * ChanServ sets mode +qo flo-retina flo-retina 10:32:44 <-- aleth has quit (Ping timeout: 121 seconds) 10:41:34 --> aleth has joined #instantbird 10:41:34 * ChanServ sets mode +o aleth 10:42:06 <aleth> so IB will be busted until bug 1243550 is ported 10:42:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1243550 enh, --, Thunderbird 50.0, philipp, RESO FIXED, Bring Browser Console to Thunderbird 11:01:25 <flo-retina> looks like it 11:20:50 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:34:01 <abdelrhman> aleth: I want use xmppParser in parsing text stanzas as I'll use it for testing data forms (parse function), is that OK? 11:36:38 <aleth> Are you writing tests? 11:37:44 <aleth> I'm a bit confused by your question as that parser already handles all stanzas coming from the server, doesn't it? 11:38:23 <abdelrhman> Yes, I finished the parsing function and I want to write some tests for it 11:39:06 <abdelrhman> a test like that (http://pastebin.instantbird.com/3089455) 11:39:40 <aleth> Sure, use the parser as that's what will be parsing the real stanzas as well 11:39:49 <aleth> Tests should always be as close to the real use case as you can get 11:40:34 <abdelrhman> this one is from XEP and I'll get another one from any server 11:41:06 <aleth> The XEP examples make good test cases, right. 12:24:38 --> clokep_work has joined #instantbird 12:24:38 * ChanServ sets mode +o clokep_work 12:28:25 --> flo-retina has joined #instantbird 12:28:25 * ChanServ sets mode +qo flo-retina flo-retina 12:28:27 <-- clokep_work has quit (Connection closed) 12:28:31 --> clokep_work has joined #instantbird 12:28:31 * ChanServ sets mode +o clokep_work 12:31:09 <-- aleth has quit (Quit: Instantbird 50) 12:31:12 --> aleth has joined #instantbird 12:31:12 * ChanServ sets mode +o aleth 12:34:18 <clokep_work> abdelrhman, aleth: So...the difference between invite and inviteto is one you can specify a room? 12:35:02 <abdelrhman> yes and you can provide a password 12:35:12 <clokep_work> How do we tell whether the option parameters are password / message? 12:35:26 <aleth> Heh, I just wrote that in a review comment... 12:38:53 <aleth> clokep_work: the main distinction to keep in mind is that /inviteto is for 1:1 convs so you have to specify a room 12:39:06 <clokep_work> Interesting... 12:39:09 <clokep_work> How did we do this for IRC? 12:39:23 <clokep_work> (We probably guess...) 12:39:48 <clokep_work> Bah I need to purge mxr from my history. 12:39:59 <clokep_work> https://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircCommands.jsm#197-227 12:40:02 <aleth> For IRC, the channel is an optional second parameter (and there is no message) 12:41:09 <clokep_work> Ah, yeah. It's a little more complicated though because we allow multiple nicks. 12:41:12 <clokep_work> Because libpurple. 12:41:15 <aleth> Yeah 12:41:19 <aleth> And no passwords 12:41:37 <clokep_work> That command should be invite <nick>[,<nick>] [<channel>] 12:41:38 <clokep_work> Oh well. 12:41:45 <clokep_work> I'd love for that stuff to be GUIable too. 12:42:17 <aleth> There comes a point when there are too many optionals and a command becomes tricky 12:42:29 --> mpmc has joined #instantbird 12:43:02 <clokep_work> Yep! 12:44:09 <clokep_work> abdelrhman: Well keep up the good work. :) 12:44:22 <aleth> Hmm... personally I don't think we need to support "an optional message" as we provide other ways to send messages ;) 12:45:27 <aleth> If that simplifies things. 12:49:08 <clokep_work> It's probably a message that goes along w/ th einvite. 12:49:19 * clokep_work mumbles about XMPP being too complicated. 12:49:35 <aleth> Yes, and it's OK to handle it when incoming, but do we need to support it in our command? 12:50:44 <aleth> XMPP inherits from XML an attitude of "you can add as many optional tags as you like" 12:54:38 <clokep_work> aleth: So are we busted in that IB won't build or just that the error console doesn't work? 12:54:46 <aleth> Both 12:54:55 <clokep_work> Fancy. 12:55:19 <clokep_work> That changeset doesn't look terrible. I wonder how hard it would be to port to IB. 12:55:30 <aleth> probably not too difficult 12:55:39 * aleth hasn't got time though after doing reviews 12:56:00 <clokep_work> I'll try to get to it today. 12:56:11 <clokep_work> I need to do a build first though. 12:56:30 <aleth> you might even get the debugger, dom inspector etc for free 12:56:36 <aleth> not sure 13:08:42 <-- aleth has quit (Ping timeout: 121 seconds) 13:11:37 <-- abdelrhman has quit (Ping timeout: 121 seconds) 13:17:01 --> abdelrhman has joined #instantbird 13:20:02 <-- abdelrhman has quit (Connection closed) 13:21:07 --> abdelrhman has joined #instantbird 13:22:14 --> aleth has joined #instantbird 13:22:14 * ChanServ sets mode +o aleth 13:25:08 <-- abdelrhman has quit (Ping timeout: 121 seconds) 13:32:13 --> abdelrhman has joined #instantbird 14:01:21 <-- EionRobb has quit (Connection closed) 14:01:48 --> EionRobb has joined #instantbird 14:09:45 <clokep_work> Bah...my build worked fine, as did packaging... 14:09:49 <clokep_work> Because I didn't clobber. :( 14:18:27 <-- aleth has quit (Ping timeout: 121 seconds) 14:30:15 --> aleth has joined #instantbird 14:30:15 * ChanServ sets mode +o aleth 14:45:50 <-- abdelrhman has quit (Connection closed) 14:45:54 --> abdelrhman has joined #instantbird 14:53:35 <aleth> abdelrhman: I guess you can land Bug 1282099 yourself now ;) 14:53:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1282099 nor, --, ---, ab, ASSI, Update NetUtil.asyncFetch calls in chat/ 14:54:01 <clokep_work> abdelrhman: Ah you got commit access? Congrats. :) 14:54:11 <abdelrhman> Thanks ;) 14:54:55 <abdelrhman> I'll land it tonight as I'm working on Data forms now 14:55:07 <clokep_work> :) 14:55:10 <clokep_work> Cool. How's that goign? 14:55:28 * clokep_work keeps forgetting to check your notes on the wiki. :( 14:57:04 <abdelrhman> I finished the parsing function, added the test case of XEP and now trying to get a test case from a real server 14:57:11 <clokep_work> :) Nice. 15:14:10 <-- aleth has quit (Quit: Instantbird 50) 15:14:13 --> aleth has joined #instantbird 15:14:13 * ChanServ sets mode +o aleth 15:16:02 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:40:45 --> bgmCoder has joined #instantbird 15:47:35 <-- aleth has quit (Ping timeout: 121 seconds) 15:48:48 <clokep_work> :( I can't reproduce the packaging failure. 15:52:30 <-- abdelrhman has quit (Ping timeout: 121 seconds) 15:53:14 --> abdelrhman has joined #instantbird 15:53:53 --> aleth has joined #instantbird 15:53:53 * ChanServ sets mode +o aleth 15:58:34 <-- abdelrhman has quit (Connection closed) 15:58:44 --> abdelrhman has joined #instantbird 16:00:31 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:01:41 --> Mnyromyr has joined #instantbird 16:07:15 <-- abdelrhman has quit (Connection closed) 16:07:39 --> abdelrhman has joined #instantbird 16:09:33 <instantbot> ab@abahmed.com changed the Resolution on bug 1282099 from --- to FIXED. 16:09:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1282099 nor, --, ---, ab, RESO FIXED, Update NetUtil.asyncFetch calls in chat/ 16:10:23 <abdelrhman> landed :) 16:12:54 <clokep_work> aleth: So I can't reproduce the failure from the buildbots. 16:13:12 <aleth> clokep_work: it's only a packaging failure, right? 16:13:30 <clokep_work> aleth: I ran mach package. ;) 16:13:34 <aleth> Huh. 16:14:40 <clokep_work> Even https://hg.mozilla.org/comm-central/rev/4da79677dea3 doesn't show anything removed from package-manifest... 16:16:49 <clokep_work> Ah looks like they were remoeed from mail in a different commit OK. 16:18:31 <aleth> toolkit/components/console certainly no longer exists. 16:20:18 <aleth> https://hg.mozilla.org/mozilla-central/rev/bb34ab2ea11b 16:21:57 <clokep_work> Fuck. 16:22:00 <clokep_work> I was building TB. 16:22:28 <flo-retina> :-/ 16:22:41 <clokep_work> I pretty much do that *every* time I sti down to do things for IB/TB. :( 16:22:46 <clokep_work> It's *really* frustrating. 16:24:11 * aleth uses two local checkouts (hg share) of the repos to avoid that frustration 16:24:43 <clokep_work> I probably should do something like that too. 16:24:55 <clokep_work> I still run into annoying things though where I forget which tree is up to date, etc. 16:25:14 <aleth> It used to be expensive (you'd need two local clones), hg share makes it cheap 16:25:45 <aleth> yeah, though I've got myself in the habit of hg wip which helps a lot with that 16:26:02 --> gerard-majax has joined #instantbird 16:32:06 --> nhnt11 has joined #instantbird 16:32:06 * ChanServ sets mode +h nhnt11 16:34:44 <abdelrhman> nhnt11: Hi :), could you check my WIP patch for data forms today? 16:36:41 <nhnt11> abdelrhman: I have it open in a tab, should be able to look at it later today :) 16:37:17 <abdelrhman> Thanks :) 16:48:07 <clokep_work> Well I'm halfway through a new build now. :P 16:52:50 --> arlolra has joined #instantbird 17:00:19 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:02:41 <-- flo-retina has quit (Ping timeout: 121 seconds) 17:04:41 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:20:42 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:23:16 --> gerard-majax has joined #instantbird 17:30:28 <-- Mnyromyr has quit (Ping timeout: 121 seconds) 17:30:37 --> abdelrhman has joined #instantbird 17:32:08 <-- aleth has quit (Ping timeout: 121 seconds) 17:32:49 --> Mnyromyr has joined #instantbird 17:39:00 <clokep_work> aleth: \o/ reproduced! 17:39:46 * abdelrhman working on supporting room discovery 17:39:56 --> aleth has joined #instantbird 17:39:56 * ChanServ sets mode +o aleth 17:51:12 <-- arlolra has quit (Client exited) 17:56:49 <clokep_work> aleth: I was able to reproduce. :) Working on fixing it now. 17:56:50 <-- mpmc has quit (A TLS packet with unexpected length was received.) 17:56:55 <-- aleth has quit (Quit: Instantbird 50) 17:56:59 <clokep_work> BAH 17:57:02 --> aleth has joined #instantbird 17:57:02 * ChanServ sets mode +o aleth 17:57:14 <clokep_work> aleth: ^^ 17:57:35 <aleth> :-) 17:58:30 <aleth> clokep_work: TB already pulled in some devtools stuff before F allen's recent patch, you probably have to port that too (though I guess you can ask him) 17:59:48 <-- abdelrhman has quit (Connection closed) 18:00:02 --> abdelrhman has joined #instantbird 18:00:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:12:19 <-- aleth has quit (Quit: Instantbird 50) 18:12:27 --> aleth has joined #instantbird 18:12:27 * ChanServ sets mode +o aleth 18:14:01 --> nhnt11 has joined #instantbird 18:14:01 * ChanServ sets mode +h nhnt11 18:19:40 <-- aleth has quit (Ping timeout: 121 seconds) 18:26:01 --> gerard-majax has joined #instantbird 18:34:45 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:47:14 --> aleth has joined #instantbird 18:47:14 * ChanServ sets mode +o aleth 18:51:59 <clokep_work> aleth: Works. :) 18:52:15 <clokep_work> Do we have a bug on file? 18:53:16 <-- aleth has quit (Quit: Instantbird 50) 18:53:17 --> aleth has joined #instantbird 18:53:17 * ChanServ sets mode +o aleth 18:54:41 <clokep_work> Heh I already filed one. 18:57:27 <clokep_work> Patch is up. :) 18:57:35 <clokep_work> Bug 1278553 18:57:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1278553 maj, --, ---, clokep, ASSI, Switch Instantbird to use the Browser Console instead of the deprecated Error Console 18:58:21 <aleth> clokep_work++ :-) 18:59:51 <clokep_work> Is there any other way that we can open the console besides the menu btw? 18:59:55 <clokep_work> I didn't really look deep. 19:00:06 <aleth> I suppose there's some shortcut? 19:00:24 <aleth> command line option maybe? 19:00:59 <clokep_work> The shorcut should just go through the menu. 19:01:04 <clokep_work> Hm...there is a command line option. 19:03:42 <aleth> clokep_work: why are you including preferences.xul? 19:04:05 <clokep_work> Including? Huh? 19:04:21 <aleth> in menus.js 19:04:51 <clokep_work> It's unused. 19:04:56 <aleth> exactly 19:05:01 <clokep_work> I'm confused. 19:05:06 <clokep_work> What do you mean "including preferences.xul"? 19:05:13 <aleth> Let me rephrase: Why did you include that line. 19:05:35 <clokep_work> I'm not following. 19:05:38 <clokep_work> What line are you talking about.] 19:05:46 <aleth> If it's unused, why did you add that variable? 19:05:48 <clokep_work> The line that remoes the preferencesWindow variable? 19:05:51 <clokep_work> I didn't add a variable. 19:05:54 <aleth> bah 19:05:55 <aleth> ignore me 19:06:00 <clokep_work> I *removed* it. 19:06:17 * aleth was looking at the diff wrong 19:07:31 <aleth> clokep_work: I suspect that TB webconsole-overlay file is for the command line option 19:07:48 <clokep_work> Maybe. 19:08:10 <clokep_work> Bug 1279874 sounds sketchy though. :) 19:08:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1279874 nor, --, ---, nobody, NEW, -jsconsole not starting new Browser console in TB on Windows 19:08:32 <aleth> Fallen would know more ;) 19:08:37 <clokep_work> I'll test doing that in a second. 19:09:06 <aleth> lgtm otherwise :-) 19:09:28 <clokep_work> aleth: The -jsconsole options seems to work for that patch as-is. 19:09:31 <Fallen> whats up? :) 19:09:34 --> abdelrhman has joined #instantbird 19:10:06 <clokep_work> Fallen: What's that webconsole-overlay doing in bug 1243550? 19:10:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1243550 enh, --, Thunderbird 50.0, philipp, RESO FIXED, Bring Browser Console to Thunderbird 19:10:09 <clokep_work> It's non-obvious to me... 19:10:19 <clokep_work> (And we're debating whether we need it for Instantbird) 19:10:47 <abdelrhman> aleth: seems we can't get |participantCount| when discovering rooms 19:11:05 <clokep_work> abdelrhman: That's OK if XMPP just doesn't support that. 19:11:07 <Fallen> as long as devtools hardcodes navigator:browser, you need it 19:11:13 <clokep_work> abdelrhman: nhnt11 can probably tell you what to use instead. 19:11:41 <Fallen> it first tries to find the browser window for viewSourceUtils and the openUILinkIn, if it doesn't find that it falls back to the actual webconsole 19:11:42 <aleth> abdelrhman: just don't include that info then. Maybe you need to tidy up some code so it doesn't get displayed if it's -1 or something 19:12:11 <aleth> Fallen: ah, is this for clicking on source links in the console? 19:12:22 <clokep_work> Ahhhh I see now. :) 19:12:26 <clokep_work> Fallen: Thanks! :) I'll port that too. 19:12:35 <Fallen> what you really want though is bug 1279834 though :-) 19:12:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1279834 enh, --, ---, philipp, ASSI, Integrate devtools client UI into Thunderbird 19:12:38 * clokep_work wonders how hard it would be to include the inspector and stuff. 19:12:43 <clokep_work> Heh! 19:12:46 <aleth> Fallen: Yes we do :-) 19:12:48 <clokep_work> You read my mind. 19:12:59 <Fallen> its pretty easy actually. A few minor dependent bugs 19:18:58 <clokep_work> aleth: Any opinions about where that overlay should be? 19:19:57 <aleth> If we need a devtools folder anyway for the inspector stuff later, you might as well make one? 19:22:16 <clokep_work> I guess so. 19:22:32 <clokep_work> I do like things being the same across products. 19:22:39 <aleth> Yes 19:25:49 <-- abdelrhman has quit (Connection closed) 19:26:01 --> abdelrhman has joined #instantbird 19:27:20 --> arlolra has joined #instantbird 19:28:41 <clokep_work> aleth: So I'm tempted to land that and then do a second patch? 19:28:54 <aleth> clokep_work: Fine by me (that's why the r+) ;) 19:29:00 <clokep_work> I need to make a openUILinkIn method... 19:29:04 <clokep_work> And I'm not sure how easy that is. :-\ 19:29:16 <clokep_work> Do we have any place where we open a window with a URL? 19:29:36 <aleth> About:addons maybe? 19:29:50 <aleth> /about opens stuff in tabs 19:30:16 <clokep_work> Ah good one! 19:33:39 <Fallen> aleth: clokep_work: I'd suggest opening that url in the browser, not a tab in the app. 19:33:57 <Fallen> the urls opened there are e.g. MDN, so they are meant to be actionable afterwards and better fit for a real browser 19:40:42 <-- aleth has quit (Quit: Instantbird 50) 19:40:44 --> aleth has joined #instantbird 19:40:44 * ChanServ sets mode +o aleth 19:43:43 <clokep_work> OH? Interesting...I would've expected it read it off disk. 19:53:44 <Fallen> clokep_work: openUILinkIn is not used to open links to source files, gViewSourceUtils is used for that 19:53:58 <clokep_work> Oh. 19:54:04 <clokep_work> Interesting... 19:54:08 <clokep_work> So I'm still not sure what the file is doing. :( 19:54:27 <Fallen> openUILinkIn is used for the [Learn More] links 19:54:44 <Fallen> gViewSourceUtils is added in that overlay so that source files can be opened 19:55:12 <Fallen> https://dxr.mozilla.org/comm-central/source/mozilla/devtools/client/webconsole/hudservice.js#438 19:55:36 <Fallen> line 427 does openUILinkIn 19:56:41 <Fallen> https://dxr.mozilla.org/comm-central/source/mozilla/devtools/client/webconsole/webconsole.js#1666 and a few others in that file call openLink 20:01:47 <clokep_work> Hmm...OK. So where are the internal links shown in Thunderbird? 20:02:58 * clokep_work can't look at this more now. 20:03:34 <nhnt11> hey, I was having lunch, sorry 20:03:38 <nhnt11> reading scrollback 20:08:06 --> mpmc has joined #instantbird 20:11:07 <-- EionRobb has quit (Quit: Leaving.) 20:24:53 --> aleth1 has joined #instantbird 20:24:53 * ChanServ sets mode +o aleth1 20:28:36 <-- aleth has quit (Ping timeout: 121 seconds) 20:28:36 * aleth1 is now known as aleth 20:29:47 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]) 20:33:41 --> Tonnes has joined #instantbird 20:34:05 <-- arlolra has quit (Client exited) 20:41:53 <clokep_work> Fallen: You mind if I push a missing semi-colon onto https://hg.mozilla.org/comm-central/rev/4da79677dea3#l2.13? 20:42:15 <Fallen> clokep_work: please do! :) 20:43:43 <Fallen> there is an eslint rule for that, but once you go down that rabbithole you end up fixing the whole tree :) 20:44:15 <aleth> clokep_work: bug 1280896 fyi 20:44:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1280896 nor, --, Thunderbird 50.0, philipp, RESO FIXED, Make mach eslint work for comm-central 20:44:41 <Fallen> 216 files changed, 6969 insertions(+), 6492 deletions(-) is my running count in calendar/ 20:45:43 <clokep_work> =-o 20:45:51 <clokep_work> That enforces a particular style? Interesting. 20:45:51 <aleth> Fallen: do those rules cover XBL too? 20:46:03 <Fallen> aleth: yes, there is a preprocessor for xbl 20:46:22 <Fallen> mach eslint --fix does not work for xbl files, but it does find issues in it 20:47:02 <Fallen> there are two bugs I fixed in the preprocessor for the no-unused-vars and no-unreachable rules to work 20:48:28 <clokep_work> :) 20:48:38 <clokep_work> We should run that at some point. 20:50:18 <Fallen> im/ is not that bad actually, I ran it with the calendar config and there are only 1421 problems 20:52:56 <-- abdelrhman has quit (Connection closed) 20:53:15 --> abdelrhman has joined #instantbird 20:55:36 <clokep_work> That's not terrible. 20:55:40 <clokep_work> They're probably all IRC. :P 20:56:04 * aleth guesses wrongly indented files 20:56:40 <Fallen> I don't have that rule enabled, too much hits in calendar :-} 20:56:59 <Fallen> I think it was something like 8k hits, and there is a bug in eslint that comments are not correctly reindented when using --fix 21:03:18 <-- BWMerlin has quit (Ping timeout: 121 seconds) 21:03:56 <Fallen> im/ mostly has issues with the curly rule, deduct 655 problems if you don't want brackets for single-line block bodys 21:05:09 <Fallen> here is a summary of number of issues https://irccloud.mozilla.com/pastebin/5ibxh2Tu 21:06:55 --> EionRobb has joined #instantbird 21:07:58 <clokep_work> Fallen: Cool. :) 21:09:13 <Fallen> running it in chat/ breaks the xbl preprocessor :-P 21:12:23 <clokep_work> :-D 21:12:25 <clokep_work> Yay. 21:12:32 <clokep_work> 8-) 21:12:45 <Fallen> 3927 problems there after fixing it. convbrowser.xml has methods that don't have a <body> tag 21:13:10 <Fallen> but I am stopping now, otherwise I will spend the next day fixing all the things :) 21:14:33 <clokep_work> Heh. 21:15:42 --> clokep_work1 has joined #instantbird 21:15:42 * ChanServ sets mode +o clokep_work1 21:18:35 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:18:35 * clokep_work1 is now known as clokep_work 21:24:45 <aleth> sounds almost manageable :D 21:28:01 <instantbot> New Chat Core - XMPP bug 1282588 filed by aleth@instantbird.org. 21:28:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1282588 nor, --, ---, nobody, NEW, Handle failure when trying to join private rooms 21:28:29 <Fallen> indeed, calendar has almost 9k issues :) 21:34:43 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:37:44 <abdelrhman> aleth: can this happen in XMPP MUC with no participants? 21:37:56 <aleth> Can what happen? 21:40:59 <abdelrhman> "MUC with no participants" 21:42:07 <nhnt11> Interesting 21:42:56 <nhnt11> The only reason that would happen is if MUCs have attributes that can/need to be persisted 21:43:24 <nhnt11> like in IRC, channels can continue to exist without participants, because they have a topic, and flags, and possibly other things that are useful to persist for when people rejoin 21:43:35 * nhnt11 should learn more about XMPP 21:48:14 <aleth> abdelrhman: You mean, can there be a MUC with no participants? I don't know 21:48:28 <aleth> the specs might say? 21:48:41 <abdelrhman> seems yes 21:48:52 <abdelrhman> XEP-0045: "If the room is not persistent and this occupant is the last to exit, the service is responsi- 21:48:52 <abdelrhman> ble for destroying the room" 21:49:12 <-- EionRobb has quit (Ping timeout: 121 seconds) 21:49:31 <abdelrhman> also "Persistent Room A room that is not destroyed if the last occupant exits; antonym: Temporary Room" 21:51:28 --> EionRobb has joined #instantbird 22:10:20 <-- aleth has quit (Ping timeout: 121 seconds) 22:16:52 --> aleth has joined #instantbird 22:16:52 * ChanServ sets mode +o aleth 22:18:31 <-- aleth has quit (Quit: Instantbird 50) 22:55:58 <-- Mnyromyr has quit (Connection closed) 23:30:17 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:46:12 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 23:56:48 <-- abdelrhman has quit (Connection closed) 23:56:53 --> abdelrhman has joined #instantbird