All times are UTC.
00:03:27 <-- abdelrhman has quit (Connection closed) 00:03:43 --> abdelrhman has joined #instantbird 00:10:50 <-- abdelrhman has quit (Connection closed) 00:18:28 --> Alex2 has joined #instantbird 00:24:41 <-- Tonnes has quit (Connection closed) 00:56:51 --> Tonnes has joined #instantbird 01:52:40 --> nhnt11 has joined #instantbird 01:52:40 * ChanServ sets mode +h nhnt11 01:53:27 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:53:28 --> nhnt11 has joined #instantbird 01:53:28 * ChanServ sets mode +h nhnt11 01:57:31 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:15:14 <instant-buildbot> build #718 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/718 04:33:29 --> Bollebib has joined #instantbird 05:33:37 <-- Bollebib has quit (Ping timeout: 121 seconds) 05:35:47 --> EionRobb has joined #instantbird 05:40:30 --> bogdan_maris has joined #instantbird 07:29:57 --> gerard-majax has joined #instantbird 08:51:53 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:52:49 --> nhnt11 has joined #instantbird 08:52:49 * ChanServ sets mode +h nhnt11 08:56:32 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:47:59 --> abdelrhman has joined #instantbird 09:48:03 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:48:18 --> abdelrhman has joined #instantbird 09:52:53 --> flo-retina has joined #instantbird 09:52:54 * ChanServ sets mode +qo flo-retina flo-retina 09:55:03 --> BWMerlin has joined #instantbird 09:55:06 <-- chrisccoulson has quit (Quit: Ex-Chat) 09:55:13 --> chrisccoulson has joined #instantbird 10:04:31 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 10:09:17 --> gerard-majax has joined #instantbird 10:10:49 --> mpmc has joined #instantbird 10:18:37 <-- nhnt11 has quit (Ping timeout: 121 seconds) 10:24:22 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:25:14 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:25:24 --> gerard-majax has joined #instantbird 10:27:56 --> aleth has joined #instantbird 10:27:57 * ChanServ sets mode +o aleth 10:30:49 --> EionRobb1 has joined #instantbird 10:30:52 <-- EionRobb has quit (Ping timeout: 121 seconds) 10:39:29 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:44:43 --> gerard-majax has joined #instantbird 10:48:44 --> abdelrhman has joined #instantbird 11:04:17 <-- gerard-majax has quit (Quit: Leaving) 11:04:22 --> gerard-majax has joined #instantbird 11:20:44 --> Bollebib has joined #instantbird 11:21:54 <-- gerard-majax has quit (Ping timeout: 121 seconds) 11:22:41 --> nhnt11 has joined #instantbird 11:22:42 * ChanServ sets mode +h nhnt11 11:37:22 <-- BWMerlin has quit (Ping timeout: 121 seconds) 11:39:15 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:40:19 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:54:59 <-- nhnt11 has quit (Ping timeout: 121 seconds) 12:01:33 --> nhnt11 has joined #instantbird 12:01:34 * ChanServ sets mode +h nhnt11 12:14:56 <-- nhnt11 has quit (Ping timeout: 121 seconds) 12:27:09 --> gerard-majax has joined #instantbird 12:41:10 --> nhnt11 has joined #instantbird 12:41:11 * ChanServ sets mode +h nhnt11 12:44:57 <-- aleth has quit (Quit: Instantbird 49) 12:46:12 <-- bittin- has quit (Ping timeout: 121 seconds) 12:47:13 --> bittin- has joined #instantbird 12:58:46 --> clokep_work has joined #instantbird 12:58:47 * ChanServ sets mode +o clokep_work 13:34:25 <-- nhnt11 has quit (Ping timeout: 121 seconds) 13:36:22 <-- bittin- has quit (Ping timeout: 121 seconds) 13:36:44 <-- EionRobb1 has quit (Quit: Leaving.) 13:37:25 --> bittin- has joined #instantbird 14:37:04 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:40:15 --> mpmc has joined #instantbird 15:23:00 --> aleth has joined #instantbird 15:23:01 * ChanServ sets mode +o aleth 15:47:02 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:12:59 --> gerard-majax has joined #instantbird 16:15:51 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:28:55 --> arlolra has joined #instantbird 16:36:30 <-- gerard-majax has quit (Quit: Leaving) 16:36:34 --> gerard-majax has joined #instantbird 16:38:21 --> mpmc has joined #instantbird 16:49:41 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:12:34 <-- flo-retina has quit (Ping timeout: 121 seconds) 17:13:01 --> flo-retina has joined #instantbird 17:13:01 * ChanServ sets mode +qo flo-retina flo-retina 17:25:42 <clokep_work> aleth: I haven't been following conversation on the SASL SCRAM stuff. 17:25:45 <clokep_work> Anything I need to knwo? 17:29:36 <aleth> clokep_work: Not really, hopefully the patch is self-explanatory. Some spec links at the top of the bug if you need them 17:32:16 <clokep_work> WTF does [^]+ match in a regex? 17:34:00 <aleth> any character 17:34:02 <flo-retina> I would say it's the same as .+ 17:34:17 <aleth> it's more general than . 17:34:33 <flo-retina> isn't '.' "any character" ? 17:35:11 <aleth> iirc it excludes line break characters 17:36:10 <aleth> clokep_work: tbh I was wondering if that line in the patch really needs to be a regex, but I didn't comment on it in the end. 17:36:29 <clokep_work> aleth: It at least needs a comment. :P 17:36:39 <clokep_work> Considering I like to think I know regex *really* well and had no idea what that's doing. 17:37:07 <aleth> see, that's why fresh eye second reviews are useful ;) 17:45:04 <clokep_work> aleth: Was the this.next = this._init change just to make it clear what the initial thing was? 17:46:48 <aleth> clokep_work: in PLAIN? No, it's because I asked him to change the logic (handling success stanzas in the auth mech) and that meant adding a second _finish step 17:47:44 <aleth> hmm, now you say it, it could make sense to get rid of that line and just start with next=_init as the default (s/_init/init) 17:48:32 <clokep_work> aleth: The second thing you said is my comment. 17:48:47 <aleth> OK 17:52:38 <clokep_work> aleth: Although having it be _init is maybe clearer? IDK> 17:53:15 <aleth> The question is where you move that initialization line to. 17:53:59 <aleth> (i.e. initializing this.next) 17:57:18 <aleth> if there's no good place, I guess it's clear enough as it is 17:58:29 <aleth> clokep_work: What would you think of converting the authmechs to generator functions? 17:59:37 <aleth> The whole .next mechanism could just be replaced by using yield 17:59:38 <clokep_work> aleth: That could be neat. :) 18:00:08 <aleth> Let's do that then :-) 18:02:54 <clokep_work> aleth: Not sure if we shold ask him to rearchitect the whole thing? 18:02:58 <clokep_work> Maybe a follow-up. IDK. 18:03:00 <clokep_work> That's your call. :) 18:03:44 <clokep_work> I left a review though. 18:03:46 <clokep_work> Hopefully it made sense. 18:03:51 <aleth> Thanks. 18:04:28 <arlolra> [^] is equivalent to [\S\s] 18:04:30 <arlolra> (The dot, the decimal point) matches any single character except line terminators: \n, \r, \u2028 or \u2029. 18:04:51 <aleth> idk, the only existing auth mech is PLAIN and that's already being rearchitected. imho changing to a function* should only take a couple minutes (assuming you know what a function* is already) 18:06:16 <clokep_work> arlolra: Yes, I always use [\S\s]. 18:06:18 <clokep_work> I find it clearer. 18:06:29 <clokep_work> aleth: Rgr that. 18:10:16 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:26:04 --> gerard-majax has joined #instantbird 19:00:46 <instantbot> New Chat Core - XMPP bug 1277931 filed by aleth@instantbird.org. 19:00:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1277931 nor, --, ---, nobody, NEW, Show a better server default on account creation than jabber.org 19:06:39 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:17:31 --> Golden1 has joined #instantbird 19:23:50 --> flo-retina has joined #instantbird 19:23:50 * ChanServ sets mode +qo flo-retina flo-retina 19:27:54 --> nhnt11 has joined #instantbird 19:27:54 * ChanServ sets mode +h nhnt11 19:29:13 <-- aleth has quit (Quit: Instantbird 49) 19:51:41 <-- bittin- has quit (Ping timeout: 121 seconds) 20:03:13 --> bittin- has joined #instantbird 20:08:21 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:08:26 --> nhnt11 has joined #instantbird 20:08:27 * ChanServ sets mode +h nhnt11 20:08:57 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:39:16 <-- Mook_as has quit (Client exited) 20:39:44 --> Mook_as has joined #instantbird 21:06:07 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:24:51 --> abdelrhman has joined #instantbird 21:29:33 <-- abdelrhman has quit (Connection closed) 21:31:36 --> abdelrhman has joined #instantbird 21:44:03 --> clokep_work has joined #instantbird 21:44:03 * ChanServ sets mode +o clokep_work 21:57:01 <-- abdelrhman has quit (Connection closed) 21:57:07 --> abdelrhman has joined #instantbird 22:09:41 <clokep_work> abdelrhman: Great work on the SCRAM stuff. :) 22:10:27 <abdelrhman> thanks :) 22:10:29 <-- mpmc has quit (A TLS packet with unexpected length was received.) 22:17:19 <-- abdelrhman has quit (Connection closed) 22:17:25 --> abdelrhman has joined #instantbird 22:23:42 <-- chrisccoulson has quit (Connection closed) 22:30:10 --> chrisccoulson has joined #instantbird 22:32:15 <abdelrhman> clokep_work: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp#Special_characters_meaning_in_regular_expressions for the [^]+ 22:32:29 <clokep_work> abdelrhman: Yes, we figured it out earlier. 22:32:32 <abdelrhman> check the table Character Classes for . character 22:32:36 <abdelrhman> OK 22:32:39 <clokep_work> It is non obvious. 22:33:42 <abdelrhman> It seems it only works for JavaScript 22:33:45 <abdelrhman> http://stackoverflow.com/questions/6711971/regular-expressions-match-anything 22:39:16 <clokep_work> Yes, I suggested using [\s\S]* on IRC. 22:58:22 <-- abdelrhman has quit (Connection closed) 22:58:35 --> abdelrhman has joined #instantbird 23:01:09 <-- abdelrhman has quit (Connection closed) 23:01:17 --> abdelrhman has joined #instantbird 23:11:32 <-- arlolra has quit (Connection closed) 23:16:57 <clokep_work> abdelrhman: Did you see aleht's idea of using a generator? 23:18:07 <abdelrhman> yes, I think it's good 23:21:04 <clokep_work> Probably will make it clearer.