All times are UTC.
00:14:29 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:17:00 <-- mpmc has quit (A TLS packet with unexpected length was received.) 00:18:12 --> Alex3 has joined #instantbird 00:42:38 --> EionRobb1 has joined #instantbird 00:44:17 <-- EionRobb has quit (Ping timeout: 121 seconds) 00:48:10 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 00:50:01 --> nhnt11 has joined #instantbird 00:50:01 * ChanServ sets mode +h nhnt11 00:51:25 <-- clokep_work has quit (Ping timeout: 121 seconds) 00:52:53 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 02:02:34 <-- Alex3 has quit (Ping timeout: 121 seconds) 02:11:18 --> Alex2 has joined #instantbird 02:27:57 <instant-buildbot> build #3165 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3165 03:06:52 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:06:59 --> nhnt11 has joined #instantbird 03:06:59 * ChanServ sets mode +h nhnt11 03:25:21 --> EionRobb has joined #instantbird 03:27:09 <-- EionRobb1 has quit (Ping timeout: 121 seconds) 03:50:30 <-- nhnt11 has quit (Ping timeout: 121 seconds) 03:56:43 <instant-buildbot> build #693 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/693 04:37:20 <-- bgmCoder has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 05:22:42 <-- EionRobb has quit (Quit: Leaving.) 05:28:58 --> mpmc has joined #instantbird 05:32:57 --> bogdan_maris has joined #instantbird 05:51:03 --> Bollebib has joined #instantbird 06:17:38 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:33:00 --> chrisccoulson has joined #instantbird 07:14:20 --> nhnt11 has joined #instantbird 07:14:20 * ChanServ sets mode +h nhnt11 07:53:00 <-- nhnt11 has quit (Ping timeout: 121 seconds) 08:11:01 --> gerard-majax has joined #instantbird 08:33:52 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:48:51 <-- flo-retina has quit (Ping timeout: 121 seconds) 09:03:34 --> gerard-majax has joined #instantbird 09:25:28 --> Bollebib has joined #instantbird 09:42:46 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:44:09 <-- chrisccoulson has quit (Quit: Ex-Chat) 09:45:03 --> chrisccoulson has joined #instantbird 10:21:56 <-- Alex2 has quit (Connection closed) 10:23:11 --> gerard-majax has joined #instantbird 10:31:18 --> flo-retina has joined #instantbird 10:31:18 * ChanServ sets mode +qo flo-retina flo-retina 11:11:33 <-- mpmc has quit (A TLS packet with unexpected length was received.) 11:16:19 --> abdelrhman has joined #instantbird 11:16:59 --> Bollebib1 has joined #instantbird 11:17:03 <-- Bollebib has quit (Connection closed) 11:36:20 --> Mnyromyr has joined #instantbird 11:40:37 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.40/20160118183220]) 11:43:09 <-- abdelrhman has quit (Connection closed) 11:43:45 --> abdelrhman has joined #instantbird 12:01:04 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]) 12:12:18 --> Tonnes has joined #instantbird 12:52:54 --> clokep_work has joined #instantbird 12:52:54 * ChanServ sets mode +o clokep_work 13:06:13 <-- abdelrhman has quit (Connection closed) 13:08:15 --> abdelrhman has joined #instantbird 13:30:01 --> bgmCoder has joined #instantbird 13:59:47 <-- abdelrhman has quit (Connection closed) 13:59:56 --> abdelrhman has joined #instantbird 14:15:39 <-- abdelrhman has quit (Connection closed) 14:15:44 --> abdelrhman has joined #instantbird 14:47:58 <-- chrisccoulson has quit (Quit: Ex-Chat) 14:48:00 <-- abdelrhman has quit (Ping timeout: 121 seconds) 14:48:59 --> abdelrhman has joined #instantbird 14:50:53 --> chrisccoulson has joined #instantbird 14:53:23 <-- abdelrhman has quit (Connection closed) 14:53:34 --> abdelrhman has joined #instantbird 15:09:37 --> qheaden has joined #instantbird 15:27:54 --> mpmc has joined #instantbird 15:33:50 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:58:37 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:17:36 <-- chrisccoulson has quit (Quit: Ex-Chat) 16:26:21 --> chrisccoulson has joined #instantbird 16:26:27 <-- abdelrhman has quit (Connection closed) 16:26:31 --> abdelrhman has joined #instantbird 16:27:10 --> gerard-majax has joined #instantbird 16:32:12 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:36:51 <-- abdelrhman has quit (Connection closed) 16:37:09 --> abdelrhman has joined #instantbird 16:41:55 <-- abdelrhman has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:42:57 --> mconley|livehacking has joined #instantbird 16:45:16 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:47:30 --> gerard-majax has joined #instantbird 16:58:05 --> flo-retina has joined #instantbird 16:58:05 * ChanServ sets mode +qo flo-retina flo-retina 17:13:30 --> arlolra has joined #instantbird 17:17:34 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:23:48 --> gerard-majax has joined #instantbird 17:27:35 <-- arlolra has quit (Ping timeout: 121 seconds) 17:30:20 --> arlolra has joined #instantbird 17:31:17 --> bogdan_maris has joined #instantbird 17:37:52 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:04:36 <-- arlolra has quit (Ping timeout: 121 seconds) 18:06:13 --> arlolra has joined #instantbird 18:51:17 <-- mconley|livehacking has quit (Quit: NO CARRIER) 18:58:14 --> gerard-majax has joined #instantbird 19:07:05 --> nhnt11 has joined #instantbird 19:07:06 * ChanServ sets mode +h nhnt11 19:10:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:22:44 --> aleth has joined #instantbird 19:22:44 * ChanServ sets mode +o aleth 19:24:08 <aleth> flo-retina: probably the quickest way to explain why that vbox is needed: https://puu.sh/oOkCj/f126e9ab6b.png 19:24:35 <aleth> without it, the fixed height of the icon limits the height of the whole row 19:36:05 --> abdelrhman has joined #instantbird 19:43:28 <flo-retina> aleth: that doesn't feel great :-/ 19:46:01 <-- nhnt11 has quit (Ping timeout: 121 seconds) 19:49:36 <-- abdelrhman has quit (Connection closed) 19:51:37 --> abdelrhman has joined #instantbird 19:58:51 <flo-retina> aleth: isn't there like a CSS property we need to set on the stack or its parent to avoid that? 19:59:05 <flo-retina> (thanks for the explanatory screenshot though!) 20:00:27 <aleth> such as? 20:04:21 <flo-retina> well... 20:04:25 <flo-retina> why is the vbox helping? 20:05:49 <flo-retina> https://developer.mozilla.org/fr/docs/Web/CSS/-moz-stack-sizing 20:06:11 <flo-retina> is that property somehow not set to the correct value somewhere? 20:07:00 <aleth> the stack has the right size though 20:07:11 <flo-retina> I was more thinking about the label 20:07:35 <-- abdelrhman has quit (Connection closed) 20:07:43 <flo-retina> well, if that property applies only to xul:stack elements it's not gonna be helpful 20:07:46 --> abdelrhman has joined #instantbird 20:08:07 --> nhnt11 has joined #instantbird 20:08:07 * ChanServ sets mode +h nhnt11 20:08:21 <aleth> I've noticed before that sometimes when a stack is used surrounding xul sizing can get a bit tricky 20:11:58 <flo-retina> aleth: is that thing you wrote in the bug something that should be in a comment in the xul markup? 20:12:31 <aleth> Probably. 20:12:41 <flo-retina> I still don't understand that comment after reading it 3 times though :( 20:13:21 <aleth> Previously you had the icon aligned with the top, and next to it a box with two lines of texxt 20:13:57 <aleth> Once you want the icon to be centered with respect to a single line height, obviously it can't span two lines of text any more. 20:14:26 <flo-retina> hmm 20:14:51 <flo-retina> I'm not pretending yet that I have fully understood, but it's starting to make sense :) 20:15:54 <aleth> maybe there's something better to use as a spacer in the second line than a blank img? 20:16:55 * aleth didn't worry too much about it 20:17:21 <flo-retina> what worries me is mostly the obscurity/complexity of this all 20:17:49 --> gerard-majax has joined #instantbird 20:17:54 <aleth> yeah 20:19:08 <flo-retina> wait if it's just to align the text horizontally, can't we just add a -moz-margin-start on the contact-hbox? 20:19:40 <aleth> yes, but then you'd have to have a different class for the second line, and that's just as obscure 20:20:34 <flo-retina> why is that obscure? 20:20:39 <-- mpmc has quit (A TLS packet with unexpected length was received.) 20:20:47 <flo-retina> that line can have another class in addition to the existing one 20:20:54 <flo-retina> and the name can be descriptive 20:21:11 <aleth> The way it is now, at least to me it was clear that each line had the same structure. If you do it with a class, it's less obvious. 20:21:23 <aleth> Obviously it wasn't clear to you though anyway ;) 20:21:44 --> mpmc has joined #instantbird 20:22:41 --> Mnyromyr has joined #instantbird 20:24:16 --> unghost has joined #instantbird 20:27:14 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.40/20160118183220]) 20:28:59 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:29:28 <flo-retina> aleth: I'm really unsure what to do with this patch. 20:29:31 <aleth> Hmm, I might have an idea. Not sure it's worth the effort though 20:29:53 <flo-retina> on one hand I'm tempted to r=I-trust-you,whatever-let's-unblock-this. 20:30:09 <aleth> (an idea for getting rid of the extra vbox) 20:30:15 <flo-retina> on the other hand, I'm not convinced landing XUL hackery that I'm not able to understand is doing the project a great service 20:32:41 <clokep_work> abdelrhman: I don't follow your comment. 20:32:42 <aleth> that's probably part of why kill-xul got some momentum. as soon as it gets a bit complicated, you run into odd edge cases that are hard to fully understand 20:33:00 <clokep_work> "No, as we use arrow to get benefits of "Lexical this"." if you just refernece the function than this should work properly. 20:33:17 <aleth> abdelrhman: this.function.bind(this) will do 20:34:04 <abdelrhman> OK 20:35:49 <clokep_work> Wait wait wait. 20:35:54 <clokep_work> I don't understand why you need to bind in this case. 20:36:04 <clokep_work> If so, I'd rather the fat-arrow than a bind. 20:37:00 <-- abdelrhman has quit (Connection closed) 20:37:36 --> abdelrhman has joined #instantbird 20:40:11 <-- abdelrhman has quit (Connection closed) 20:41:04 --> abdelrhman has joined #instantbird 20:41:13 <flo-retina> aleth: alright. If you can find something better, that's nice. If not or you think it's not worth your time, I'm ok with r+ing the current patch (even though I still can't claim to fully understand it) 20:41:53 <aleth> ok 20:48:18 <flo-retina> aleth: so bug 1060891 is the next one in your priority list? 20:48:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1060891 nor, --, ---, aleth, ASSI, Stats service uses too much memory 20:48:36 <-- clokep_work has quit (Ping timeout: 121 seconds) 20:49:33 <aleth> flo-retina: yes, ab will need to use those interfaces, changed or not 20:49:52 <abdelrhman> clokep_work: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Functions/Arrow_functions 20:49:55 * flo-retina wonders if an hour is enough to review that 20:50:13 <aleth> I can't really remember. 20:51:53 <-- abdelrhman has quit (Ping timeout: 121 seconds) 20:52:18 --> abdelrhman has joined #instantbird 20:54:08 <-- qheaden has quit (Quit: leaving) 21:04:14 --> EionRobb has joined #instantbird 21:09:20 <flo-retina> I'm unsure if I should re-read all the comments in the bug, or just the patch 21:11:57 --> clokep_work has joined #instantbird 21:11:58 * ChanServ sets mode +o clokep_work 21:15:54 <-- abdelrhman has quit (Connection closed) 21:16:01 --> abdelrhman has joined #instantbird 21:25:01 <-- abdelrhman has quit (Connection closed) 21:25:06 --> abdelrhman has joined #instantbird 21:32:15 <-- Bollebib1 has quit (Ping timeout: 121 seconds) 21:32:21 <-- arlolra has quit (Client exited) 21:37:14 <-- abdelrhman has quit (Connection closed) 21:37:19 --> abdelrhman has joined #instantbird 21:39:49 <-- abdelrhman has quit (Connection closed) 21:40:02 --> abdelrhman has joined #instantbird 21:41:17 <clokep_work> abdelrhman: I know how arrow functions work. 21:41:22 <clokep_work> I don't see why you need to bind this in this situation. 21:41:27 <clokep_work> You're not in a scope that will eat this. 21:42:43 <-- abdelrhman has quit (Connection closed) 21:47:53 <aleth> flo-retina: thanks for the reviews! 21:48:02 <flo-retina> np, sorry for the huge delays 21:51:16 --> abdelrhman has joined #instantbird 21:52:20 --> EionRobb1 has joined #instantbird 21:54:01 <-- EionRobb has quit (Ping timeout: 121 seconds) 22:18:27 <-- nhnt11 has quit (Ping timeout: 121 seconds) 22:20:30 <-- abdelrhman has quit (Connection closed) 22:20:36 --> abdelrhman has joined #instantbird 22:27:55 <abdelrhman> clokep_work: Do you have other comments on the latest patch? (I want to be landed it sooner ;)) 22:31:18 <clokep_work> abdelrhman: Can you name your patches slightly different in the next bug? 22:31:21 <clokep_work> E.g. v1 v2. 22:31:37 <abdelrhman> OK 22:32:17 <clokep_work> abdelrhman: I don't think so. 22:32:24 <clokep_work> At least the interdiff looks pretty good! 22:32:29 <clokep_work> I'll do a more thorough review soon. 22:32:33 <clokep_work> (I'm on my way out.) 22:36:38 <-- clokep_work has quit (Ping timeout: 121 seconds) 22:41:58 <-- abdelrhman has quit (Connection closed) 22:42:03 --> abdelrhman has joined #instantbird 22:44:48 <-- abdelrhman has quit (Connection closed) 22:45:06 --> abdelrhman has joined #instantbird 22:49:43 <-- abdelrhman has quit (Connection closed) 22:49:48 --> abdelrhman has joined #instantbird 22:57:24 <-- unghost has quit (A TLS packet with unexpected length was received.) 23:01:25 --> nhnt11 has joined #instantbird 23:01:26 * ChanServ sets mode +h nhnt11 23:02:43 <-- abdelrhman has quit (Connection closed) 23:03:46 --> abdelrhman has joined #instantbird 23:06:26 <-- abdelrhman has quit (Connection closed) 23:08:27 --> abdelrhman has joined #instantbird 23:27:23 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 23:38:19 --> mpmc1 has joined #instantbird 23:51:59 <-- aleth has quit (Quit: Instantbird 49)