All times are UTC.
00:10:49 --> nhnt11 has joined #instantbird 00:10:49 * ChanServ sets mode +h nhnt11 00:13:19 <-- mpmc has quit (Connection closed) 00:13:20 --> mpmc has joined #instantbird 00:14:53 <-- nhnt11 has quit (Ping timeout: 121 seconds) 00:18:37 <-- AlexanderSalas has quit (Connection closed) 00:24:17 --> AlexanderSalas has joined #instantbird 00:26:27 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:26:43 --> AlexanderSalas has joined #instantbird 00:30:05 <-- AlexanderSalas has quit (Connection closed) 00:30:13 --> AlexanderSalas has joined #instantbird 00:34:01 <-- AlexanderSalas has quit (Connection closed) 00:36:41 --> AlexanderSalas has joined #instantbird 01:18:24 <-- AlexanderSalas has quit (Connection closed) 01:31:36 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:32:31 --> AlexanderSalas has joined #instantbird 01:37:59 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:46:17 <-- unghost has quit (A TLS packet with unexpected length was received.) 01:48:02 --> AlexanderSalas has joined #instantbird 01:48:21 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:19:00 <-- freaktechnik has quit (Ping timeout: 121 seconds) 02:22:37 --> nhnt11 has joined #instantbird 02:22:37 * ChanServ sets mode +h nhnt11 02:26:30 --> freaktechnik has joined #instantbird 02:49:55 --> nhnt12 has joined #instantbird 02:49:55 * ChanServ sets mode +h nhnt12 02:53:14 <-- nhnt11 has quit (Ping timeout: 121 seconds) 02:53:59 <-- nhnt12 has quit (Ping timeout: 121 seconds) 03:20:45 <-- clokep has quit (Ping timeout: 121 seconds) 03:24:03 --> nhnt11 has joined #instantbird 03:24:03 * ChanServ sets mode +h nhnt11 03:45:47 <-- nhnt11 has quit (Ping timeout: 121 seconds) 03:55:06 --> nhnt11 has joined #instantbird 03:55:06 * ChanServ sets mode +h nhnt11 04:03:42 <-- EionRobb has quit (Ping timeout: 121 seconds) 04:16:09 --> nhnt12 has joined #instantbird 04:16:09 * ChanServ sets mode +h nhnt12 04:16:27 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:16:27 * nhnt12 is now known as nhnt11 04:35:53 --> EionRobb has joined #instantbird 04:50:01 <instant-buildbot> build #625 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/625 04:53:17 <instant-buildbot> build #3095 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3095 04:53:30 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:53:35 --> nhnt11 has joined #instantbird 04:53:35 * ChanServ sets mode +h nhnt11 05:32:01 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 06:08:51 --> CuriousLearner has joined #instantbird 06:39:37 <-- CuriousLearner has quit (Ping timeout: 121 seconds) 06:39:49 --> MikkCZ has joined #instantbird 06:41:52 <-- MikkCZ has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:53:41 --> CuriousLearner has joined #instantbird 07:18:37 --> Alex1 has joined #instantbird 07:26:37 --> jsmaniac has joined #instantbird 07:32:37 --> malayaleecoder has joined #instantbird 07:40:20 --> MikkCZ has joined #instantbird 07:40:25 <-- MikkCZ has quit (Connection closed) 07:40:37 <-- CuriousLearner has quit (Ping timeout: 121 seconds) 08:12:10 <-- jsmaniac has quit (Quit: CGI:IRC (Ping timeout)) 09:24:07 --> BWMerlin has joined #instantbird 09:34:56 <-- Alex1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 09:45:01 --> Bollebib has joined #instantbird 19:54:12 --> instantbot has joined #instantbird 19:54:12 topic changed by fripp.mozilla.org to "Ask about Instantbird (http://instantbird.com) here! :-) | Last version was Instantbird 1.5 | Nightlies: http://nightly.instantbird.im (at your own risk) | News: http://blog.instantbird.org | IRC logs: http://log.bezut.info | Pastebin: http://pastebin.instantbird.org | Bugs: https://bugzilla.mozilla.org" 19:54:12 * ChanServ sets mode +v instantbot 20:52:00 --> instantbot has joined #instantbird 20:52:00 topic changed by fripp.mozilla.org to "Ask about Instantbird (http://instantbird.com) here! :-) | Last version was Instantbird 1.5 | Nightlies: http://nightly.instantbird.im (at your own risk) | News: http://blog.instantbird.org | IRC logs: http://log.bezut.info | Pastebin: http://pastebin.instantbird.org | Bugs: https://bugzilla.mozilla.org" 20:52:00 * ChanServ sets mode +v instantbot 20:52:31 --> satdav has joined #instantbird 20:52:39 --> AlexanderSalas has joined #instantbird 20:57:06 <-- jsmaniac has quit (Quit: CGI:IRC (Ping timeout)) 20:58:30 <-- bittin- has quit (Ping timeout: 121 seconds) 20:59:31 --> bittin- has joined #instantbird 21:15:54 --> jsmaniac has joined #instantbird 21:20:23 <jsmaniac> hello all, greetings from India !, I am trying to build a debug version on my ubuntu machine using hg bundles. Once i have a successful build , what are the further steps I must take for fixing bugs, please guide 21:26:00 --> nhnt11 has joined #instantbird 21:26:00 * ChanServ sets mode +h nhnt11 21:28:31 <clokep_work> jsmaniac: That depends on the bug you're interested in fixing. 21:29:52 <jsmaniac> @clokep_work I am new to this , can you please guide me to where I can find bugs listed , I tried on bugzilla . 21:31:06 <clokep_work> jsmaniac: http://www.joshmatthews.net/bugsahoy/?instantbird=1 might be a good place to find easy bugs 21:31:14 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:31:20 <clokep_work> I'd suggest playing with it and seeing what you don't like too. 21:31:24 <clokep_work> Or if there's abug that bothers you. 21:32:04 --> nhnt11 has joined #instantbird 21:32:04 * ChanServ sets mode +h nhnt11 21:32:56 <jsmaniac> ok thanks for the advice, the playing approach will be better i guess , am on it . 21:35:00 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:35:12 --> AlexanderSalas has joined #instantbird 21:36:30 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:38:28 --> nhnt11 has joined #instantbird 21:38:28 * ChanServ sets mode +h nhnt11 21:39:01 <clokep_work> Alright. :) 21:39:05 <clokep_work> Let us know if you have questions. 21:46:04 <-- jsmaniac has quit (Quit: CGI:IRC (Ping timeout)) 21:48:47 <mdhr> aleth: I've been at this for quite a while now, so its a little embarrassing. I used conversationErrorMessage to show an error message to the user in case of a 501. But, this is shown in a new tab with the title 't', when running '/mode +t' to reproduce, when ideally, it should display that in the same conversation. Upon debugging this, I looked into the code for conversationErrorMessage and found that the parameter it considers never c 21:49:11 <clokep_work> mdhr: Part of your message was cut off. 21:49:18 <clokep_work> The last word we got were "the parameters it considers never c" 21:49:29 <clokep_work> FWIW Instantbird doesn't do that and will split messages. :P Maybe try it for IRC? 21:50:26 <mdhr> the parameter it considers never contains the name of the current conversation, so it can never show messages onto that one, at least for 501. The parameters only contain the current user nick, the mode value I'm trying to set, and some raw error message. 21:50:46 <mdhr> It seems like a simple thing to do but somehow I'm missing it. 21:51:50 <-- freaktechnik has quit (Ping timeout: 121 seconds) 21:51:59 <aleth> The easy answer is to put the error in the server tab 21:52:09 <mdhr> @clokep_work I'm using irssi on an aws right now and its bad internet day today at college. :( 21:52:33 <mdhr> @aleth:: but wouldnt we want the user to know that directly? and more explicitly? 21:52:37 <aleth> The harder answer would be to somehow remember which conversation the mode command was sent from 21:53:17 <aleth> mdhr: ideally, yes 21:54:02 * nhnt11 idly wonders what mdhr is working on 21:54:18 <mdhr> aMessage variable, that reaches the handler for 501 never contains it. So I might have to look even beyond that. But I tried looking for other errors which might log on to the same conversation, like channel privilige issues. 21:54:21 * nhnt11 doens't see anything in the logs 21:54:26 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]) 21:55:03 <aleth> mdhr: Other error messages have the same problem if the error the server sends doesn't reference the conversation. 21:55:37 <mdhr> @nhnt11: Hi! I'm working on https://bugzilla.mozilla.org/show_bug.cgi?id=1105797 21:55:39 <instantbot> Bug 1105797 nor, --, ---, nobody, NEW, Unhandled IRC message 501: unknown mode char 21:55:42 <aleth> It would be nice to improve that but it's not completely simple 21:55:49 <clokep_work> mdhr: That mode message isn't really referring to a specific conversation, it's really server wide configuration. 21:56:10 <clokep_work> By which aleth means...we've wanted to do that for a long time and haven't figured out how to. :) 21:56:10 <aleth> If you'd like to do that, I'd suggest doing it in a separate bug as a followup for all the error messages that are currently put in the server tab but shouldn't be 21:57:06 <-- nhnt11 has quit (A TLS packet with unexpected length was received.) 21:57:38 <mdhr> @aleth: Sure. I'll add a new bug for this? @clokep_work: really? But it says 'channel mode' set by xyz. 21:57:47 --> Tonnes has joined #instantbird 21:57:57 <clokep_work> mdhr: What is "it" in that sentence? 21:58:12 <aleth> mdhr: well, for a *channel* mode obviously you know which tab to put the message in ;) 21:58:34 --> mpmc has joined #instantbird 21:58:39 <clokep_work> mdhr: Also...IRC reuses the "MODE" command for like 8 different things. 21:58:41 <clokep_work> So it's confusing. 21:58:53 --> nhnt11 has joined #instantbird 21:58:53 <aleth> MODE is a pain. 21:58:53 * ChanServ sets mode +h nhnt11 21:59:08 <mdhr> Oh. Did not know that. 22:01:13 <aleth> 501 is only sent in response to user modes though 22:01:17 <aleth> ERRUMODEUNKNOWNFLAG 22:01:30 <clokep_work> Yep. 22:01:39 <mdhr> There's also a lot of TODOs in that file, for these error messages. Maybe we should add those in the bug as well? 22:02:02 <mdhr> Some of them might be rarer though. 22:02:56 <-- nhnt11 has quit (Ping timeout: 121 seconds) 22:03:08 --> nhnt11 has joined #instantbird 22:03:08 * ChanServ sets mode +h nhnt11 22:04:35 <clokep_work> mdhr: Theoretically we'd want those all to disappear, yes. 22:04:45 <clokep_work> Some of them we didn't try to create, some we've just never seen. 22:04:59 <clokep_work> Some probably aren't sent by servers. 22:05:05 <mdhr> haha theoretically? :P 22:05:28 <clokep_work> It's not very fun work. ;) 22:05:41 <clokep_work> We've generally hit the ones that happen 'in the wild' often. 22:05:55 --> freaktechnik has joined #instantbird 22:07:03 <mdhr> So should I begin with adding a bug to address the parameters that are sent to the error handlers, to include the conversation name as well? 22:07:24 <mdhr> And then we can have another about separating server errors that are really conversation erorrs, like aleth suggested? 22:09:45 <clokep_work> I'm not sure what the first thing means. 22:09:56 <clokep_work> That's why we have the conversationErrorHandler vs. serverErrorHandler. 22:09:59 <clokep_work> One has the conversation name. 22:10:29 <instantbot> New Instantbird - Account manager bug 1254305 filed by aryx.bugmail@gmx-topmail.de. 22:10:30 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1254305 nor, --, ---, nobody, NEW, addOptions method takes 3 arguments, 4 given 22:11:32 <mdhr> The conversationErrorHandler is called with an object that does not contain the name of the conversation, at least in the case of 501. 22:12:37 <clokep_work> Yep! 22:12:48 <clokep_work> So what would the new bug be fixing? 22:13:25 <mdhr> It would add the name of the conversation to the param passed to that handler, so that it knows which conversation to log it to... 22:13:45 <clokep_work> mdhr: Where would it get that name? 22:14:27 <mdhr> I dont know right now. :P This is the param as of now: {"rawMessage":":fripp.mozilla.org 501 testuser n :is unknown mode char to me","command":"501","params":["testuser","n","is unknown mode char to me"],"origin":"fripp.mozilla.org","tags":{},"source":""} 22:14:51 <mdhr> I'm guessing origin is the key which stores the channel name ideally? 22:15:11 <mdhr> params[1] is what the handler reads for conversation name 22:15:52 <mdhr> Why is origin ftipp.mozilla.org in this case though. 22:15:54 <clokep_work> mdhr: I think you're a bit confused at where that data is coming from, that's a parsed message that we're getting back from the IRC server. 22:15:58 <clokep_work> We can't just inject new data into it. 22:16:11 <mdhr> I am, admittedly, confused about it. 22:16:19 <aleth> mdhr: It might help to look at a debug log to see what an IRC session actually looks like 22:16:59 <aleth> (Use the /debug command) 22:17:24 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:18:34 <mdhr> I see. 22:18:51 <mdhr> Okay, that makes things clearer. 22:20:19 <clokep_work> mdhr: The IRC code is designed to be completely async, we send something to the server and then just parse the results. There's no mechanism to 'store' a sent command and wait for a response. 22:20:30 <clokep_work> XMPP has that, however, as does some other protocols. (Each message has an ID) 22:20:31 <mdhr> We have no control over the param. We're just getting it from the server. Right. 22:21:27 <clokep_work> Yep! :) 22:21:46 <clokep_work> So that's why aleth suggested making it log to the server tab like we do with a bunch of other instances of that situation. 22:21:54 <clokep_work> And then filing a bug saying "fix this for all the places where it can occur" 22:22:31 <mdhr> And 'this' would be logging errors to the server tab when they could go in the conversation? 22:22:33 <-- freaktechnik has quit (Ping timeout: 121 seconds) 22:23:15 <clokep_work> Yes. 22:23:27 <clokep_work> (We might even have that bug on file, not sure.) 22:23:56 <mdhr> I will confirm before I add :) 22:25:02 --> nhnt11 has joined #instantbird 22:25:02 * ChanServ sets mode +h nhnt11 22:25:06 <clokep_work> Thanks! 22:25:37 <mdhr> So should I submit a patch with the logging done to servertab, after verifying it works? 22:27:36 <aleth> Yes 22:28:44 <mdhr> Cool, will do. Thanks for your patience today, @aleth and @clokep_work. :') 22:33:41 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.39/20151103174305]) 22:35:23 <-- bittin- has quit (Ping timeout: 121 seconds) 22:35:37 --> nhnt12 has joined #instantbird 22:35:37 * ChanServ sets mode +h nhnt12 22:36:25 --> bittin- has joined #instantbird 22:37:29 <clokep_work> mdhr: No problem. :) 22:37:32 <-- nhnt11 has quit (Ping timeout: 121 seconds) 22:37:32 * nhnt12 is now known as nhnt11 22:39:31 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 22:43:30 --> nhnt12 has joined #instantbird 22:43:30 * ChanServ sets mode +h nhnt12 22:46:51 <-- nhnt11 has quit (Ping timeout: 121 seconds) 22:46:51 * nhnt12 is now known as nhnt11 22:50:23 <-- clokep_work has quit (Ping timeout: 121 seconds) 22:58:04 <-- bittin- has quit (Ping timeout: 121 seconds) 22:59:05 --> bittin- has joined #instantbird 23:18:42 <-- bittin- has quit (Ping timeout: 121 seconds) 23:19:43 --> bittin- has joined #instantbird 23:20:36 --> clokep has joined #instantbird 23:20:36 * ChanServ sets mode +o clokep 23:28:43 <instantbot> New Chat Core - IRC bug 1254333 filed by mrinal.dhar@gmail.com. 23:28:44 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1254333 nor, --, ---, nobody, NEW, Some error messages logged in Server tab should go in Conversations instead 23:32:11 <-- unghost has quit (A TLS packet with unexpected length was received.) 23:51:03 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:51:16 --> AlexanderSalas has joined #instantbird