All times are UTC.
00:01:39 <-- gerard-majax has quit (Ping timeout: 121 seconds) 00:28:35 --> myk1 has joined #instantbird 00:28:36 <-- myk has quit (Connection closed) 00:28:36 * myk1 is now known as myk 00:58:03 <-- chrisccoulson has quit (Connection closed) 01:10:24 <flo-retina> aleth: do you have hints of things I should try for that linux event thing? 01:11:30 <aleth> http://log.bezut.info/instantbird/160121/#m146 /might/ be the easiest 01:11:47 <aleth> I'd look for something similar (generate a mouse event and dispatch it) on dxr 01:18:10 <flo-retina> why is this event stuff so non-obvious :( 01:18:51 <aleth> and why did they make that change... 01:19:17 <flo-retina> so the interface inherits, right? http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/events/nsIDOMMouseEvent.idl 01:19:31 <aleth> not any more it doesn't 01:20:07 <aleth> bug 1230216 01:20:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1230216 nor, --, mozilla46, aidin, RESO FIXED, Consider changing nsIDOM*Event interfaces so that they don't inherit nsIDOMEvent 01:20:21 <aleth> that's the change that broke it 01:20:58 <flo-retina> "external code can always QI to the right interface." 01:24:32 <freaktechnik> you can try to QueryInterface it to an nsIDOMEvent... 01:24:48 <freaktechnik> the AsEvent() that is returned is the internal non-xpcom type of nsIDOMEvent 01:25:13 <freaktechnik> (mozilla::dom::Event) 01:28:03 <flo-retina> so QI on the return value of AsEvent? 01:28:29 <freaktechnik> not sure you can QI that, since that's not a type the "user space" code knows implements nsISupports, afaik 01:29:19 <freaktechnik> I tried static_casts earlier, likey they do in Event.h (where mozilla::dom::Event is implemented), however that doesn't work, and including Event.h would be a pain, since it uses internal_nsString and such things. 01:46:28 <flo-retina> has GetInternalNSEvent()->AsMouseEvent(); beeb tried? 01:49:42 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:52:08 <flo-retina> bah, this didn't need any QI at all 01:52:53 <flo-retina> see what we have here? http://mxr.mozilla.org/comm-central/source/im/components/mintrayr/trayToolkit.cpp#246 01:53:57 <flo-retina> aleth: https://pastebin.mozilla.org/8857426 r? 02:00:04 <flo-retina> I'm going to bed. 02:00:13 <flo-retina> If anybody feels like r+'ing, feel free to land it 02:07:02 <-- aleth has quit (Quit: :tiuQ) 02:20:19 <-- arlolra has quit (Client exited) 02:58:15 --> mpmc has joined #instantbird 03:43:59 --> clokep_work has joined #instantbird 03:43:59 * ChanServ sets mode +o clokep_work 03:48:02 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:05:02 <-- Hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:51:38 <-- Suiseiseki has quit (Ping timeout: 121 seconds) 04:52:56 <instant-buildbot> build #580 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/580 04:54:18 <instant-buildbot> build #3049 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3049 05:18:08 <-- myk has quit (Connection closed) 05:19:17 --> myk has joined #instantbird 05:38:45 --> BWMerlin has joined #instantbird 05:39:20 --> Suiseiseki has joined #instantbird 05:42:08 <-- myk has quit (Ping timeout: 121 seconds) 05:48:40 <-- Suiseiseki has quit (Quit: Leaving) 05:52:47 <-- freaktechnik has quit (Quit: Loosing power...) 05:57:33 --> BWMerlin1 has joined #instantbird 06:00:34 --> Suiseiseki has joined #instantbird 06:00:52 <-- BWMerlin has quit (Ping timeout: 121 seconds) 06:00:52 * BWMerlin1 is now known as BWMerlin 06:01:26 --> freaktechnik has joined #instantbird 06:21:36 --> myk has joined #instantbird 06:26:48 --> myk1 has joined #instantbird 06:26:49 <-- myk has quit (Connection closed) 06:26:49 * myk1 is now known as myk 06:42:57 <-- myk has quit (Ping timeout: 121 seconds) 06:44:27 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:58:44 --> Bollebib has joined #instantbird 08:25:40 <-- PingWiN has quit (Ping timeout: 121 seconds) 08:39:15 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 08:52:17 --> gerard-majax has joined #instantbird 08:58:05 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:11:52 --> gerard-majax has joined #instantbird 11:25:00 --> mpmc has joined #instantbird 11:29:51 <-- mpmc has quit (Connection closed) 11:31:36 --> mpmc has joined #instantbird 11:53:16 <-- gerard-majax has quit (Ping timeout: 121 seconds) 11:55:15 --> aleth has joined #instantbird 11:55:15 * ChanServ sets mode +o aleth 11:58:31 <aleth> flo-retina: won't this fail at runtime? http://mxr.mozilla.org/comm-central/source/im/components/mintrayr/trayToolkit.cpp#250 11:59:57 <flo-retina> why? 12:00:24 <flo-retina> the nsIDOMEvent is created as a "MouseEvents" so I would hope it creates the right kind of object 12:00:41 <flo-retina> but I won't pretend to understand everything related to how events work... 12:00:46 <aleth> If nsiDOMMouseEvents are no longer nsiDOMEvents, I don't see how you can magically turn the latter into the former, as that code seems to be doing 12:00:52 <aleth> but I am probably just confused 12:02:33 <flo-retina> it's all confusing 12:02:55 <flo-retina> I'm assuming the initial comment in the bug that said "external code can just QI" was correct. 12:03:08 <aleth> I don't understand how that comment can be true 12:05:56 --> gerard-majax has joined #instantbird 12:11:48 <aleth> Did you run your build to check if it worked? 12:16:11 <flo-retina> no 12:16:22 <flo-retina> I'm not convinced the tray icon ever worked with unity anyway 12:17:07 <aleth> No idea. We could land it and ask for feedback 12:37:40 <-- gerard-majax has quit (Ping timeout: 121 seconds) 12:38:02 --> gerard-majax has joined #instantbird 12:45:57 --> Mnyromyr has joined #instantbird 12:54:52 --> unghost has joined #instantbird 12:59:51 <freaktechnik> I wonder if external code -> web level code, since there it still has to inherit DOMEvent, though that's handled via webIDL now, right? 13:01:57 <flo-retina> "external code" means "external linkage" (ie. not MOZILLA_INTERNAL_API) 13:05:25 <aleth> freaktechnik: can you try flo's patch and confirm that it works? 13:05:49 <freaktechnik> it's landed in cc? 13:05:57 <aleth> no, it's in a pastebin 13:06:07 <aleth> https://pastebin.mozilla.org/8857426 13:06:11 <freaktechnik> okay, thanks 13:06:39 <flo-retina> oh yes, if someone could try that would be awesome :) 13:08:09 <freaktechnik> I don't think I can confirm if it works, the tray thing doesn't work on my distro. 13:08:26 <freaktechnik> but I can try... 13:08:39 <flo-retina> ahah 13:08:42 <flo-retina> Ubuntu with unity? 13:08:58 <freaktechnik> nope, elementaryOS with pantheon with wingpanel 13:09:14 <freaktechnik> (the ubuntu patched wingpanel, though) 13:09:49 <freaktechnik> at least it builds, so that's an improvment... 13:13:18 <freaktechnik> minimize to tray and it's gone ;) 13:15:16 <freaktechnik> just no way to restore it other than killing the process, because I don't actually get the tray icon. 13:29:35 <aleth> well, let's land it and see what happens ;) 14:22:53 --> chrisccoulson has joined #instantbird 14:26:03 --> clokep_work has joined #instantbird 14:26:03 * ChanServ sets mode +o clokep_work 14:31:49 --> pWnnn has joined #instantbird 14:33:52 --> PingWiN has joined #instantbird 14:35:51 <-- pWnnn has quit (Ping timeout: 121 seconds) 14:44:42 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1237385 from --- to FIXED. 14:44:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1237385 nor, --, Instantbird 46, ab, RESO FIXED, deduplicate populateProtoSpecificBox 14:45:19 <clokep_work> flo-retina: Did you manage to try anything w/ the mintaryr stuff? 14:48:20 <flo-retina> what do you mean by "try"? 14:50:40 <clokep_work> flo-retina: Did you look into fixing the bustage? 14:50:52 <flo-retina> I pastebined a fix last night, aleth landed it http://hg.mozilla.org/comm-central/rev/038cb3717ea1 14:50:56 <flo-retina> it fixes the compile error 14:51:08 <flo-retina> we aren't sure if it actually fixes the tray or will fail at run time 15:15:41 <-- gerard-majax has quit (Ping timeout: 121 seconds) 15:18:47 --> gerard-majax has joined #instantbird 15:34:13 <-- fredy has quit (Quit: ZNC - http://znc.in) 15:44:04 <instant-buildbot> build #581 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/581 15:47:38 <flo-retina> oh! 16:03:43 <instantbot> aleth@instantbird.org changed the Resolution on bug 1237385 from FIXED to ---. 16:03:44 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1237385 nor, --, Instantbird 46, ab, REOP, deduplicate populateProtoSpecificBox 16:43:57 <-- mpmc has quit (A TLS packet with unexpected length was received.) 16:56:50 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:14:40 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:09:51 --> fredy has joined #instantbird 18:14:34 --> myk has joined #instantbird 18:19:28 --> myk1 has joined #instantbird 18:21:44 <-- myk1 has quit (Connection closed) 18:22:40 <-- myk has quit (Ping timeout: 121 seconds) 18:23:28 --> myk has joined #instantbird 19:21:04 --> abdelrhman has joined #instantbird 19:46:47 --> Bollebib has joined #instantbird 20:34:53 --> mpmc has joined #instantbird 21:18:52 <-- Suiseiseki has quit (Quit: Leaving) 22:03:32 --> freaktechnik_ has joined #instantbird 22:05:03 <-- freaktechnik has quit (Ping timeout: 121 seconds) 22:05:03 * freaktechnik_ is now known as freaktechnik 22:05:22 <-- mpmc has quit (A TLS packet with unexpected length was received.) 22:08:44 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.39/20151103174305]) 22:20:50 <-- aleth has quit (Ping timeout: 121 seconds) 22:22:07 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 43.0.4/20160105164030]) 22:26:02 --> aleth has joined #instantbird 22:26:02 * ChanServ sets mode +o aleth 22:34:07 <-- aleth has quit (Ping timeout: 121 seconds) 22:38:20 --> aleth has joined #instantbird 22:38:20 * ChanServ sets mode +o aleth 22:42:57 --> Tonnes has joined #instantbird 23:14:11 <-- abdelrhman has quit (A TLS packet with unexpected length was received.) 23:22:01 <-- aleth has quit (Quit: :tiuQ) 23:22:06 --> aleth has joined #instantbird 23:22:06 * ChanServ sets mode +o aleth