#instantbird log on 01 14 2016

All times are UTC.

00:03:30 --> EionRobb1 has joined #instantbird
00:05:08 <-- EionRobb has quit (Ping timeout: 121 seconds)
00:31:43 --> Alex2 has joined #instantbird
00:49:50 <-- myk has quit (Ping timeout: 121 seconds)
00:51:29 --> PingWiN has joined #instantbird
00:52:30 <-- pWnnn has quit (Ping timeout: 121 seconds)
00:54:01 <-- aleth has quit (Quit: :tiuQ)
01:53:53 <-- arlolra has quit (Client exited)
02:10:10 --> mpmc has joined #instantbird
02:39:46 --> dgmurdockiii has joined #instantbird
02:39:52 <dgmurdockiii> hi
02:40:03 <dgmurdockiii> how it going
03:45:23 <instant-buildbot> build #3037 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/3037
04:22:55 <-- dgmurdockiii has quit (Quit: Leaving)
04:47:04 <-- EionRobb1 has quit (Quit: Leaving.)
05:00:06 <instant-buildbot> build #568 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/568
05:43:28 <-- PingWiN has quit (Ping timeout: 121 seconds)
05:43:55 --> pWnnn has joined #instantbird
05:44:47 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
05:58:03 --> Bollebib has joined #instantbird
06:19:57 --> EionRobb has joined #instantbird
06:38:18 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
06:49:42 --> BWMerlin has joined #instantbird
08:21:53 --> robert_alxndr has joined #instantbird
08:28:02 <-- robert_alxndr has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
09:14:19 --> gerard-majax has joined #instantbird
09:18:31 <-- Mook_as has quit (Connection closed)
09:18:34 --> Mook_as has joined #instantbird
09:26:08 <-- gerard-majax has quit (Quit: Leaving)
09:26:13 --> gerard-majax has joined #instantbird
09:37:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:46:58 --> gerard-majax has joined #instantbird
10:03:06 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:04:42 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:19:04 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:21:06 --> aleth has joined #instantbird
10:21:06 * ChanServ sets mode +o aleth 
10:44:56 --> flo-retina has joined #instantbird
10:44:56 * ChanServ sets mode +qo flo-retina flo-retina 
10:48:05 --> gerard-majax has joined #instantbird
11:38:34 --> flo-retina1 has joined #instantbird
11:38:34 * ChanServ sets mode +qo flo-retina1 flo-retina1 
11:39:18 <-- flo-retina has quit (Ping timeout: 121 seconds)
11:39:38 * flo-retina1 is now known as flo-retina 
11:40:55 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:41:33 --> flo-retina has joined #instantbird
11:41:33 * ChanServ sets mode +qo flo-retina flo-retina 
11:54:02 --> mpmc has joined #instantbird
12:00:36 <-- BWMerlin has quit (Client exited)
13:42:09 --> GeKo has joined #instantbird
13:43:40 <GeKo> i was wondering how much dependent instantbird is on thunderbird code?
13:44:08 <GeKo> would it be possible to build instantbird just on top of mozilla as firefox is?
13:45:26 <freaktechnik> Instantbird initially was completely independent from thunderbird and some of the code was then shared with thunderbird for the chat integration. But all UI code is still separate. But others in here are more qualified to answer this question.
13:46:34 <GeKo> thanks, interesting.
13:48:56 <flo-retina> GeKo: Instantbird and Thunderbird are 2 completely separate products.
13:49:23 --> MikkCZ has joined #instantbird
13:49:29 <GeKo> i know but you still need comm-central for instantbird AFAICT
13:49:47 <GeKo> so i was wondering whether one could get rid of that requirement
13:49:51 <freaktechnik> you also need comm-central for seamonkey...
13:50:05 <flo-retina> GeKo: The Instantbird code is stored in comm-central.
13:51:14 <GeKo> i see. so, you basically just share the same repo but not code
13:51:18 <GeKo> ?
13:51:56 <flo-retina> the chat/ folder is used by both Instantbird and Thunderbird.
13:52:03 <flo-retina> im/ is the Instantbird UI.
13:52:12 <flo-retina> mail/ is the Thunderbird UI.
13:52:33 <flo-retina> mailnews/ is the email back-end used by Thunderbird and SeaMonkey
13:54:34 <GeKo> okay, thanks.
13:58:40 --> clokep_work has joined #instantbird
13:58:40 * ChanServ sets mode +o clokep_work 
14:02:38 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:02:55 --> flo-retina has joined #instantbird
14:02:55 * ChanServ sets mode +qo flo-retina flo-retina 
14:07:08 <clokep_work> flo-retina, aleth: Do you guys remember why http://mxr.mozilla.org/comm-central/source/im/confvars.sh#27 is Windows only?
14:07:16 <clokep_work> It seems like Mac needs those symbols too based on the failures?
14:07:22 <clokep_work> Was it because SIPE is linked differently on Mac?
14:08:49 <flo-retina> the description in bug 1082537 makes me assume that MOZ_FOLD_LIBS may not have been set on Mac
14:08:50 <aleth> hmm, it doesn't say in bug 1082537
14:08:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1082537 blo, --, 1.6, clokep, RESO FIXED, Instantbird Windows build busted due to missing nss symbols
14:12:35 <clokep_work> :-S
14:12:46 <clokep_work> Alright...so is it reasonable to assume that ifdef needs to include Mac now?
14:14:18 <flo-retina> it makes some sense
14:14:30 <flo-retina> would be nice if we know what change caused our current build failure
14:14:40 <flo-retina> but I don't want to block on us figuring out that
14:15:05 <aleth> iirc clokep_work's bug links to the breaking bug
14:15:18 <-- MikkCZ has left #instantbird ()
14:15:34 <flo-retina> ah
14:17:25 <clokep_work> flo-retina: I already figured that out, yeah.
14:17:36 <flo-retina> there are several ifdef windows in the changeset clokep linked in the bug
14:17:45 <flo-retina> several *removed* ifdef windows
14:17:55 <clokep_work> bug 1235132 caused the bustage
14:17:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1235132 nor, --, mozilla46, mh+mozilla, RESO FIXED, Add support for a more-or-less cross-platform symbols file
14:18:05 <flo-retina> so yeah, it's reasonable to assume we should remove the confvar ifdef
14:18:19 <flo-retina> eg https://hg.mozilla.org/mozilla-central/rev/186450f22aab#l1.14
14:18:23 <aleth> that on its own won't fix it though (I tried)
14:18:26 <flo-retina> clokep_work: yes, sorry for not paying enough attention
14:18:43 <flo-retina> aleth: well, it's busted on Windows, so removing the ifdef certainly won't fix it all
14:19:26 <aleth> ah, I didn't know about Windows because it hasn't been building nightlies
14:20:06 <flo-retina> IIRC the last ones it tried to build had that bustage
14:21:33 <clokep_work> flo-retina: Yeah that was my thought too, OK. :)
14:21:44 <clokep_work> That bug alreaedy has a fix, but it was r-ed.
14:21:50 <clokep_work> They want me to change it an AC_DEFINE.
14:21:55 <clokep_work> But that did weird things, I think.
14:31:35 <-- flo-retina has quit (Ping timeout: 121 seconds)
14:45:40 --> flo-retina has joined #instantbird
14:45:40 * ChanServ sets mode +qo flo-retina flo-retina 
15:00:32 <clokep_work> flo-retina: So the current changes I was trying were http://pastebin.instantbird.com/2326627
15:00:56 <clokep_work> That seems to be the naive changeset needed, but I get an error when compiling. (I'll need to recompile to get that error.)
15:01:04 <clokep_work> But I wanted someone to look and tell me that that's not crazy first. :)
15:02:46 --> EionRobb1 has joined #instantbird
15:03:30 <flo-retina> hmm, I don't understand how http://mxr.mozilla.org/mozilla-central/source/config/external/nss/nss.symbols#695 is supposed to work
15:03:43 <clokep_work> What do you mean? :-S
15:03:53 <clokep_work> It's an ifdef.
15:03:58 <flo-retina> my guess is there's a typo and it never worked
15:04:01 <clokep_work> That includes an extra file?
15:04:06 <clokep_work> It has *never* worked...
15:04:13 <flo-retina> you need the AC_SUBST to have @NSS_EXTRA_SYMBOLS_FILE@ replaced
15:04:15 <clokep_work> flo-retina: Have you read over bug 1237140?
15:04:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1237140 nor, --, ---, clokep, ASSI, nss.symbols cannot include NSS_EXTRA_SYMBOLS_FILE: not in context
15:04:22 <clokep_work> Specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1237140#c2
15:04:25 <flo-retina> and you need AC_DEFINE for #ifdef NSS_EXTRA_SYMBOLS_FILE to pass
15:04:43 <flo-retina> so my guess would be you cant to AC_DEFINE, and remove the two '@' characters there.
15:05:24 <-- EionRobb has quit (Ping timeout: 121 seconds)
15:05:26 <flo-retina> clokep_work: so I think you need what's in your pastebin, + remove the two '@'
15:06:44 <clokep_work> flo-retina: So with the above changes, after running configure:     (''' NSS_EXTRA_SYMBOLS_FILE ''', ' 1 '),
15:06:49 <flo-retina> s/you cant to/you want to/
15:06:52 <clokep_work> That's what I get in config.status...which is wrong.
15:07:04 <clokep_work> And I have no idea where that 1 is coming from.
15:07:08 <aleth> "you need AC_DEFINE for #ifdef NSS_EXTRA_SYMBOLS_FILE to pass" only in C++ files though, right?
15:07:09 <instantbot> c++ is e-- ah, nevermind.
15:07:45 <-- mpmc has quit (A TLS packet with unexpected length was received.)
15:08:00 <aleth> hmm, I guess the preprocessor doesn't care.
15:09:46 <flo-retina> http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Defining-Symbols.html "If neither value nor description are given, then value defaults to 1 instead of to the empty string."
15:10:28 <clokep_work> :-S
15:10:31 <flo-retina> clokep_work: looks like you need AC_DEFINE(NSS_EXTRA_SYMBOLS_FILE,$NSS_EXTRA_SYMBOLS_FILE)
15:10:43 <clokep_work> flo-retina: Thanks I assumed I was doing something stupid.
15:10:50 <aleth> flo-retina: isn't that already in mozilla/configure?
15:11:07 <flo-retina> aleth: clokep is hacking the mozilla configure
15:11:16 <aleth> there's that long bit at the end with sed 's/$/,/' >> $CONFIG_STATUS <<EOF ...
15:11:59 <aleth> it contains NSS_EXTRA_SYMBOLS_FILE, maybe it conflicts with AC_DEFINE?
15:12:29 <flo-retina> aleth: if you mean http://mxr.mozilla.org/mozilla-central/source/configure.in#8943 then that's what clokep is replacing.
15:12:36 <flo-retina> or maybe I'm confused and don't understand what you mean :-S
15:14:03 <aleth> bah, I was looking at configure (which is generated) instead of configure.in
15:14:36 <clokep_work> Hah, now I have (''' NSS_EXTRA_SYMBOLS_FILE ''', r''' $NSS_EXTRA_SYMBOLS_FILE '''),
15:14:40 <clokep_work> So...that's something. ;)
15:15:45 <flo-retina> hmm, maybe that was ${foo} rather than $foo
15:15:51 <flo-retina> my autoconf is rusty ;)
15:17:30 <clokep_work> :-D
15:19:22 <aleth> I always forget the difference between [..] or not
15:20:10 <freaktechnik> one executes the contents and one doesn't, something like that.
15:22:12 <aleth> clokep_work: another pattern which is common in mozilla code is e.g.
15:22:12 <aleth> AC_SUBST(MOZ_LINKER)
15:22:12 <aleth> if test -n "$MOZ_LINKER"; then
15:22:12 <aleth>   AC_DEFINE(MOZ_LINKER)
15:22:12 <aleth> fi
15:22:15 <aleth> maybe that would work?
15:22:23 <clokep_work> Maybe.
15:22:52 <flo-retina> hmm, maybe we actually need a test indeed
15:23:06 <flo-retina> otherwise we'll define to '1'
15:23:10 <flo-retina> which will fail to build
15:26:49 <clokep_work> flo-retina: We likely do need a test, yes.
15:26:54 <clokep_work> That's the one that worked &
15:33:08 <clokep_work> Anyone know what AC_DEFINE vs AC_DEFINE_UNQUOTED is? :-D
15:34:31 <aleth> _UNQUOTED will evaluate $... I guess
15:39:16 <clokep_work> flo-retina: What're rules for getting checked into m-c now? Do I need to push to try?
15:39:46 <flo-retina> that's required for setting the checkin-needed keyword
15:40:04 <flo-retina> if you are pushing yourself, you can push to mozilla-inbound without a try run being required
15:40:12 <flo-retina> (although in this case I would probably push to try just to be sure)
15:40:28 <flo-retina> well, either push to try or build Firefox locally, but I assume pushing to try is less effort for you right now
15:42:50 <clokep_work> Yeah I'm waiting to make sure it works first for Instantbird. :-D
15:43:14 <flo-retina> Instantbird first, then Firefox. Seems like the priorities are in the correct order :)
15:45:41 --> MikkCZ has joined #instantbird
15:51:23 <clokep_work> flo-retina: For a try test on this, you think I should do all platforms?
15:51:31 <clokep_work> I don't want to waste resources... :-D
15:51:44 <flo-retina> I would do a linux and windows and a mac build
15:51:49 <flo-retina> probably don't need both opt and debug
15:51:54 <flo-retina> and no tests
15:52:18 <clokep_work> I was thinking just xpcshell, but you're right...if it compiles it's fine.
15:52:30 <flo-retina> I was actually wondering if I would run xpcshell or not
15:52:35 <flo-retina> to ensure the binary at least starts
15:52:48 <flo-retina> whatever :)
15:57:55 <clokep_work> I'm in the process of trying to remember how to use try. :-[
16:00:22 <clokep_work> aleth, flo-retina: Thanks for the help btw. :)
16:00:26 <flo-retina> np
16:00:38 <clokep_work> https://treeherder.mozilla.org/#/jobs?repo=try&revision=234ccfe878a1
16:00:47 <clokep_work> (And I have a local IB build going.)
16:01:13 <flo-retina> :)
16:15:32 --> Bollebib has joined #instantbird
16:19:45 <-- MikkCZ has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
16:27:45 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:27:58 --> flo-retina has joined #instantbird
16:27:58 * ChanServ sets mode +qo flo-retina flo-retina 
16:42:50 <clokep_work> flo-retina, aleth: My IB build worked! :)
16:42:56 <aleth> :-)
16:43:05 <flo-retina> clokep_work++ :)
16:43:25 <clokep_work> I'll wait for the try stuff to finish now. Is there any way to get a guess on the amount of time there?
16:43:50 <flo-retina> "13% - 7 in progress"
16:43:53 <freaktechnik> klick on a job and it sometimes tells you
16:44:06 <freaktechnik> for linux opt, for example it's ETA to completed: ~ 9 minutes
16:44:21 <freaktechnik> (on the first one, whatever that is)
16:44:31 <flo-retina> clokep_work: ETA is about 15 minutes, except for mac that's 37 minutes
16:44:34 <clokep_work> Ah, I didn't think of clicking on indivudal jobs.
16:44:39 <clokep_work> But that makes sense of course.
16:45:01 <flo-retina> ETA is sometimes significantly off though
17:00:51 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:07:33 --> myk has joined #instantbird
17:09:58 <clokep_work> Linux and win64 have completed successfully.
17:11:59 <clokep_work> And Mac.
17:12:14 <-- myk has quit (Connection closed)
17:12:18 <flo-retina> but tests are just starting
17:13:37 --> myk has joined #instantbird
17:27:51 --> gerard-majax has joined #instantbird
17:30:10 --> myk1 has joined #instantbird
17:31:06 <-- myk has quit (Ping timeout: 121 seconds)
17:31:06 * myk1 is now known as myk 
17:42:21 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:49:53 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:00:08 --> gerard-majax has joined #instantbird
18:19:31 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:23:41 --> gerard-majax has joined #instantbird
18:29:32 --> arlolra has joined #instantbird
18:39:22 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:50:30 <-- EionRobb1 has quit (Quit: Leaving.)
19:27:20 --> Mnyromyr has joined #instantbird
19:37:46 --> gerard-majax has joined #instantbird
19:43:25 --> EionRobb has joined #instantbird
19:53:43 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:01:23 --> mpmc has joined #instantbird
20:09:02 --> flo-retina has joined #instantbird
20:09:02 * ChanServ sets mode +qo flo-retina flo-retina 
20:09:14 <flo-retina> clokep: so removing the @ wasn't needed after all?
20:12:45 --> gerard-majax has joined #instantbird
20:19:11 <-- clokep_work has quit (Ping timeout: 121 seconds)
20:50:24 <-- GeKo has left #instantbird ()
21:02:38 --> clokep_work has joined #instantbird
21:02:39 * ChanServ sets mode +o clokep_work 
21:16:22 <clokep_work> flo-retina: Didn't seem to be.
21:19:51 <flo-retina> ok :)
21:25:26 <clokep_work> flo-retina: btw the im patch is just removing the ifdef, not sure if that's "OK" or not for Linux?
21:27:41 <-- gerard-majax has quit (Ping timeout: 121 seconds)
21:28:42 <flo-retina> try and see? :)
21:29:29 --> Mook_ib has joined #instantbird
21:29:46 <-- Mook_as has quit (Connection closed)
21:29:47 * Mook_ib is now known as Mook_as 
21:30:21 <-- Bollebib has quit (Ping timeout: 121 seconds)
21:53:39 <clokep_work> I'm unsure I have a Linux box ATM. ;)
21:53:56 <aleth> land it and see? ;)
22:03:23 --> freaktechnik_ has joined #instantbird
22:05:10 <-- freaktechnik has quit (Ping timeout: 121 seconds)
22:05:10 * freaktechnik_ is now known as freaktechnik 
22:17:19 --> EionRobb1 has joined #instantbird
22:19:53 <-- EionRobb has quit (Ping timeout: 121 seconds)
22:23:15 <-- aleth has quit (Ping timeout: 121 seconds)
22:25:25 --> aleth has joined #instantbird
22:25:25 * ChanServ sets mode +o aleth 
22:32:36 <flo-retina> that's what I meant, yes
22:32:54 <flo-retina> the linux build is busted anyway, so the worst that can happen is tomorrow we find a differetn error message
22:35:01 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:36:32 --> clokep_work has joined #instantbird
22:36:32 * ChanServ sets mode +o clokep_work 
22:41:54 <-- clokep_work has quit (Ping timeout: 121 seconds)