#instantbird log on 12 05 2015

All times are UTC.

00:04:53 --> BWMerlin has joined #instantbird
00:39:40 --> Bollebib has joined #instantbird
00:51:28 --> Mnyromyr has joined #instantbird
01:10:35 --> myk1 has joined #instantbird
01:10:52 <-- myk has quit (Ping timeout: 121 seconds)
01:10:52 * myk1 is now known as myk 
01:16:55 <-- myk has quit (Ping timeout: 121 seconds)
01:17:48 <-- Bollebib has quit (Ping timeout: 121 seconds)
01:18:10 <-- aleth has quit (Quit: :tiuQ)
01:30:38 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.39/20151103174305])
01:54:18 --> clokep_ has joined #instantbird
01:54:18 * ChanServ sets mode +o clokep_ 
01:56:20 <-- clokep has quit (Ping timeout: 121 seconds)
01:56:20 * clokep_ is now known as clokep 
02:06:18 <-- Yoric has quit (Connection closed)
02:39:50 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:40:05 --> clokep has joined #instantbird
02:40:05 * ChanServ sets mode +o clokep 
03:21:55 <-- clokep has quit (Ping timeout: 121 seconds)
04:58:48 <instant-buildbot> build #2996 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2996
05:29:15 <instant-buildbot> build #528 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/528
05:45:09 <instant-buildbot> build #1825 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1825
07:34:12 --> pWnnn has joined #instantbird
08:16:42 --> myk has joined #instantbird
09:06:47 --> mpmc has joined #instantbird
09:08:40 --> EionRobb has joined #instantbird
09:11:08 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:12:41 <-- myk has quit (Ping timeout: 121 seconds)
09:18:53 --> mpmc has joined #instantbird
09:29:18 <-- EionRobb has quit (Connection closed)
09:30:12 --> EionRobb has joined #instantbird
09:34:48 --> Bollebib has joined #instantbird
09:45:23 <-- mpmc has quit (A TLS packet with unexpected length was received.)
09:45:40 --> mpmc has joined #instantbird
09:52:41 <-- freaktechnik has quit (Ping timeout: 121 seconds)
09:55:09 --> freaktechnik has joined #instantbird
10:03:52 --> Yoric has joined #instantbird
10:08:02 --> gerard-majax has joined #instantbird
11:10:41 --> abdelrhman has joined #instantbird
12:28:29 --> aleth has joined #instantbird
12:28:29 * ChanServ sets mode +o aleth 
13:24:24 <-- EionRobb has quit (Quit: Leaving.)
13:36:46 --> Mnyromyr has joined #instantbird
14:32:54 <-- aleth has quit (Ping timeout: 121 seconds)
14:47:12 --> aleth has joined #instantbird
14:47:13 * ChanServ sets mode +o aleth 
14:50:14 <-- gerard-majax has quit (Ping timeout: 121 seconds)
15:12:09 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:12:15 --> mpmc has joined #instantbird
15:31:50 <-- BWMerlin has quit (Client exited)
16:41:24 --> clokep has joined #instantbird
16:41:24 * ChanServ sets mode +o clokep 
16:46:55 <-- clokep has quit (Ping timeout: 121 seconds)
16:49:25 <-- mpmc has quit (Connection closed)
16:49:27 --> mpmc has joined #instantbird
16:55:22 <-- abdelrhman has quit (Quit: Leaving)
17:32:49 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.39/20151103174305])
17:48:03 --> Mnyromyr has joined #instantbird
17:56:49 --> michele1L has joined #instantbird
17:57:06 <-- michele1L has left #instantbird ()
18:04:54 <-- Mnyromyr has quit (Ping timeout: 121 seconds)
18:06:39 --> Mnyromyr has joined #instantbird
18:08:33 --> myk has joined #instantbird
18:25:09 <-- myk has quit (Ping timeout: 121 seconds)
18:26:09 --> mpmc1 has joined #instantbird
18:26:53 --> myk has joined #instantbird
18:31:58 --> abdelrhman has joined #instantbird
18:33:05 <abdelrhman> aleth: What did you mean by "prpls"?
18:33:57 <aleth> prpl = protocol plugin
18:34:56 <-- myk has quit (Ping timeout: 121 seconds)
18:35:34 <aleth> Backend code in chat/protocols can't do UI stuff. It can only notify the frontend that it needs something.
18:41:04 <aleth> I didn't realize the in-band registration was so variable in what the server could ask for :-| That makes it complicated.
18:41:50 <abdelrhman> It's too complicated!
18:42:22 <aleth> Yes, it's really not the best API.
18:43:45 <aleth> :-(
18:44:12 <aleth> I thought you'd send name and password and you'd get a "success" or "fail" back ;)
18:45:19 <aleth> Do you have a screenshot of what the dialog looks like when you register with some server?
18:49:10 <abdelrhman> Yes, How can I share it?
18:50:08 <aleth> imgur maybe?
18:51:38 <abdelrhman> http://imgur.com/51koCvj
18:52:10 <aleth> with Japanese instructions? :D
18:53:03 <abdelrhman> This is the language of that server (the instructions are in text we show)
18:53:09 <aleth> Right.
18:54:34 <aleth> So, in this case, the dialog would be unnecessary, because the protocol already knows the desired username/password
18:55:02 <abdelrhman> Yes, It will be like a confirmation to create the account
18:55:57 <aleth> I don't think that's needed as the user has already checked the checkbox.
18:56:19 <aleth> But I suppose it's required if there are other registration fields.
18:56:38 <aleth> Have you seen a server which actually asks for one?
18:59:16 <abdelrhman> No, I think sukhe may be worked on something like that
18:59:50 <aleth> Maybe ask him about that as it would be useful to document in a bug comment, also for when you test your changes.
19:01:54 <aleth> Is the registration process completely independent of the rest of the account connection?
19:02:04 <aleth> i.e. does registration complete and then you connect normally?
19:04:02 <abdelrhman> No, you need to reconnect as we miss a stanza here (https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp-session.jsm#286) to start registration
19:05:10 <aleth> Complicated.
19:07:40 <aleth> OK, so one way to do this would be to look at the browser-request notification (which is what twitter oauth uses to show its registration form) and do something similar.
19:08:32 <aleth> i.e. instead of calling Services.ww.openWindow (which is instant r-), you send a notification along with an object containing the data the dialog needs.
19:09:11 <aleth> The frontend listens for the notification and calls Services.ww.openWindow etc.
19:09:58 <aleth> Note the dialog XUL/js files should be in chat/content not im/content (or Thunderbird will never get them)
19:20:26 <abdelrhman> OK, but why it's not allowed to call ( Services.ww.openWindow) directly? (Is that related to design)
19:22:06 <aleth> It's a general design principle that the prpls don't know anything about what is going on in the UI. The prpl has no clue about the state the UI is in, what else is going on in all the other prpls and the app itself, what the user is doing at the moment, etc.
19:23:03 <aleth> Also, completely different frontends may want to use the JS prpl implementations (currently there are two, which are very similar but not identical). That's why you communicate via an API.
19:25:55 <aleth> By sending a notification and allowing the UI frontend to decide when and how to handle it, you avoid a lot of potential problems.
19:32:23 <aleth> abdelrhman: btw, doing that way also avoids horrible hacks like "args.wrappedJSObject = args;" ;)
19:33:00 <aleth> That line already wants to be a notification ;)
19:34:34 <abdelrhman> Ah
19:35:30 <aleth> It's passing a parameter.
19:38:47 <aleth> abdelrhman: https://dxr.mozilla.org/comm-central/search?q=browser-request&=comm-central&redirect=true already gives all the relevant places in the code
19:39:39 <abdelrhman> Thanks aleth :-)
19:45:00 <-- abdelrhman has quit (Ping timeout: 121 seconds)
19:45:19 --> abdelrhman has joined #instantbird
20:05:02 <-- abdelrhman has quit (Ping timeout: 121 seconds)
20:05:34 --> abdelrhman has joined #instantbird
20:36:47 <-- Mnyromyr has quit (Connection closed)
20:40:28 --> myk has joined #instantbird
20:48:33 <-- myk has quit (Ping timeout: 121 seconds)
21:06:08 --> Mnyromyr has joined #instantbird
21:33:49 <-- abdelrhman has quit (Quit: Leaving)
22:22:50 <-- Mnyromyr has quit (Connection closed)
22:40:40 <-- mpmc1 has quit (A TLS packet with unexpected length was received.)
22:41:01 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)