#instantbird log on 11 29 2015

All times are UTC.

02:01:52 --> BWMerlin has joined #instantbird
02:12:59 <-- bogdan_maris has quit (Ping timeout: 121 seconds)
03:41:04 <instant-buildbot> build #2987 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2987
04:47:03 <instant-buildbot> build #1818 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1818
04:52:18 <instant-buildbot> build #519 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/519
07:44:22 --> pWnnn has joined #instantbird
07:56:03 <-- nhnt11 has quit (Connection closed)
07:57:49 --> nhnt11 has joined #instantbird
07:57:50 * ChanServ sets mode +h nhnt11 
08:20:22 --> mpmc has joined #instantbird
08:47:00 <-- pWnnn has quit (Connection closed)
08:49:05 --> pWnnn has joined #instantbird
09:52:50 <-- freaktechnik has quit (Ping timeout: 121 seconds)
09:53:59 --> freaktechnik has joined #instantbird
09:56:14 <-- nhnt11 has quit (Ping timeout: 121 seconds)
10:20:04 --> nhnt11 has joined #instantbird
10:20:04 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:20:11 --> nhnt12 has joined #instantbird
10:20:12 * ChanServ sets mode +h nhnt12 
10:22:44 * nhnt12 is now known as nhnt11 
10:52:10 <-- EionRobb1 has quit (Quit: Leaving.)
10:53:23 <-- nhnt11 has quit (Ping timeout: 121 seconds)
11:00:40 <-- Mook_as has quit (Connection closed)
11:01:54 --> Mook_as has joined #instantbird
11:28:15 --> nhnt11 has joined #instantbird
11:28:15 * ChanServ sets mode +h nhnt11 
11:28:32 <-- pWnnn has quit (Connection closed)
11:33:58 <-- Mook_as has quit (Ping timeout: 121 seconds)
11:37:27 --> pWnnn has joined #instantbird
11:42:53 --> Mook_as has joined #instantbird
11:47:08 <-- nhnt11 has quit (Ping timeout: 121 seconds)
12:07:57 <-- BWMerlin has quit (Client exited)
12:30:09 --> Bollebib has joined #instantbird
13:04:01 --> nhnt11 has joined #instantbird
13:04:01 * ChanServ sets mode +h nhnt11 
13:49:06 <-- nhnt11 has quit (Ping timeout: 121 seconds)
14:19:59 --> Mnyromyr has joined #instantbird
14:58:56 <-- pWnnn has quit (Ping timeout: 121 seconds)
15:13:54 --> clokep has joined #instantbird
15:13:54 * ChanServ sets mode +o clokep 
15:14:27 --> pWnnn has joined #instantbird
15:17:16 <-- pWnnn has quit (Connection closed)
15:36:42 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:38:30 --> clokep has joined #instantbird
15:38:30 * ChanServ sets mode +o clokep 
15:39:10 --> pWnnn has joined #instantbird
15:51:08 --> PingWiN has joined #instantbird
15:52:57 <-- pWnnn has quit (Ping timeout: 121 seconds)
16:38:52 --> gerard-majax has joined #instantbird
16:50:07 --> afiksof has joined #instantbird
17:05:55 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:50:44 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:40:20 --> unghost has joined #instantbird
19:16:59 --> aleth has joined #instantbird
19:16:59 * ChanServ sets mode +o aleth 
19:49:30 --> EionRobb has joined #instantbird
19:51:31 --> anqur has joined #instantbird
19:51:58 <-- anqur has left #instantbird ("")
20:05:43 --> clokep_ has joined #instantbird
20:05:43 * ChanServ sets mode +o clokep_ 
20:08:30 <-- clokep has quit (Ping timeout: 121 seconds)
20:08:31 * clokep_ is now known as clokep 
20:17:18 <-- afiksof has quit (Ping timeout: 121 seconds)
20:52:06 --> flo-retina has joined #instantbird
20:52:06 * ChanServ sets mode +qo flo-retina flo-retina 
21:10:28 --> satdav has joined #instantbird
21:15:57 <-- satdav has quit (Quit: Leaving)
21:22:51 --> abdelrhman has joined #instantbird
21:35:48 <-- abdelrhman has quit (Ping timeout: 121 seconds)
21:48:27 --> abdelrhman has joined #instantbird
21:51:38 <abdelrhman> aleth: According your comments on bug 955317, I see it's good to place the check of account creation in options as this will reduce a lot of modifications with respect to current mechanisms
21:51:41 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955317 enh, --, ---, nobody, NEW, Support XEP-0077 (In-Band Registration/Password Change)
21:53:01 <abdelrhman> On the other hand, I think it will not be clear to user or he/she might think that we do not support it if the check is in options
21:53:16 <aleth> The best place would be on the first page when setting up a new account
21:53:49 <aleth> I agree leaving it until the "advanced options" step seems a bit confusing
21:54:26 <aleth> Can't the prpl configure what to ask for on the first page? I'm pretty sure "Domain" is XMPP-specific for example
21:56:27 <abdelrhman> Let me check that.
21:56:52 * aleth has never touched that code
22:02:53 <-- Bollebib has quit (Ping timeout: 121 seconds)
22:06:14 --> Bollebib has joined #instantbird
22:06:26 <instantbot> aleth@instantbird.org changed the Resolution on bug 954491 from --- to WORKSFORME.
22:06:28 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954491 nor, --, ---, nobody, RESO WORKSFORME, xmpp autojoin chat room with a password are not supported by the current auto-join feature.
22:09:35 <aleth> abdelrhman: https://dxr.mozilla.org/comm-central/source/chat/locales/en-US/xmpp.properties#208
22:12:20 <abdelrhman> Thanks aleth, I found them and I am checking if this supports checkboxes (https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.js#32)
22:12:48 <aleth> I wouldn't be surprised if it needs extending a bit
22:13:03 <aleth> But there's already boolean-typed options which are probably checkboxes
22:13:45 <aleth> The question is why the 'Domain' option appears on the username page and not on the advanced options page
22:14:13 <aleth> My guess is that's due to https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.js#33
22:15:24 <abdelrhman> https://dxr.mozilla.org/comm-central/source/im/content/accountWizard.js#136 inside method showUsernamePage
22:16:21 <abdelrhman> check also the implementation of getProtoUserSplits in the same file
22:16:24 <aleth> Right
22:17:06 <aleth> So you'd need to add a way to add a boolean checkbox to the username page.
22:17:21 <abdelrhman> Yes
22:17:39 <aleth> Maybe "usernameOptions" in Protocol.prototype
22:20:02 <aleth> Yeah, it can already do checkboxes in Advanced Options https://dxr.mozilla.org/comm-central/source/im/content/accountWizard.js#286
22:21:27 <-- abdelrhman has quit (Ping timeout: 121 seconds)
22:21:44 --> abdelrhman has joined #instantbird
22:23:11 <aleth> Before you code this, let's discuss what happens if something goes wrong.
22:23:32 <aleth> What happens if the account can't be created?
22:23:37 --> gerard-majax has joined #instantbird
22:28:23 <abdelrhman> I think it should be deleted as there is not use for it
22:29:36 <aleth> How does the user get feedback about what went wrong?
22:31:31 <aleth> In the account manager?
22:31:31 <abdelrhman> Currently, In the account page (e.g. Not Connected), but this won't work if we deleted it so we can use dialogs instead
22:32:35 <aleth> Ideally, you wouldn't delete it, you'd allow the user to modify it
22:33:05 <aleth> I hope XMPP provides a better error message than "not connected" ;)
22:33:56 <aleth> Modifying it would require fixing the rename account bug though. And that's hard.
22:34:18 <aleth> bug 953870
22:34:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=953870 enh, --, ---, nobody, NEW, Rename accounts (i.e. change the username)
22:34:49 <abdelrhman> Yes, sure. I used this example to determine where it will be shown
22:35:14 <aleth> So for now probably the best solution is not to delete it, so the user can see the error message in red at least.
22:37:53 <abdelrhman> OK
22:38:33 <aleth> In a followup one could improve that, e.g. allowing username modifications for accounts that have never succesfully connected (I think we track that)
22:39:00 <abdelrhman> Yes, that would be better
22:39:04 <aleth> Since "renaming" accounts that have never successfully connected is way easier than for those who have existed for a while
22:40:16 <abdelrhman> but we need to check about duplication if renamed account matches existing one
22:42:21 <abdelrhman> Also, I worked on XMPP and it's about to be finished, but the current implementation of OCR is not complete / cover all possible cases as there is dedicated XEP for this.
22:42:49 <abdelrhman> I think we can add a todo for that.
22:44:19 <-- gerard-majax has quit (Ping timeout: 121 seconds)
22:46:03 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:46:15 <abdelrhman> XEP-0158 and there are many ways used in CAPTCHA (solving puzzles, performing optical character recognition, identifying audio or video samples, etc.)
22:50:48 <abdelrhman> I want also to inquiry about the patches as I work on patch which is the top of sukhe's patches to improve them. Is that right?
22:51:25 <aleth> OCR?
22:52:05 <aleth> I don't think you have to cover all those extra CAPTCHA things in this initial bug!
22:52:40 <aleth> Yes, working with a patch series is one way to do it.
22:53:21 <abdelrhman> OK
23:32:03 <-- abdelrhman has quit (Ping timeout: 121 seconds)
23:32:44 <-- Mnyromyr has quit (Connection closed)