#instantbird log on 10 02 2015

All times are UTC.

00:20:05 --> Alex1 has joined #instantbird
01:06:16 <-- clokep_work has quit (Ping timeout: 121 seconds)
01:23:13 <-- hadi has quit (Ping timeout: 121 seconds)
02:11:42 --> Mook has joined #instantbird
03:07:08 <instant-buildbot> build #1538 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1538
03:31:05 <instant-buildbot> build #448 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/448
03:57:29 <instant-buildbot> build #2923 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2923
04:12:18 --> myk has joined #instantbird
04:14:34 <-- EionRobb has quit (Quit: Leaving.)
04:42:21 --> afiksof has joined #instantbird
04:43:03 --> Bollebib has joined #instantbird
04:58:37 <-- myk has quit (Ping timeout: 121 seconds)
04:59:31 --> myk has joined #instantbird
05:26:25 --> EionRobb has joined #instantbird
05:27:14 <-- Bollebib has quit (Ping timeout: 121 seconds)
05:28:41 <instant-buildbot> build #1761 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1761
05:35:05 <-- EionRobb has quit (Connection closed)
05:36:17 --> EionRobb has joined #instantbird
07:21:57 <-- myk has quit (Ping timeout: 121 seconds)
07:39:31 --> gerard-majax has joined #instantbird
07:49:49 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:04:52 --> gerard-majax has joined #instantbird
08:18:41 --> mpmc has joined #instantbird
08:20:10 <flo-retina> clokep: I saw there was some discussion last night between you and Joshua about js-ctype'ing purplexpcom.
08:20:40 <flo-retina> at this point I wonder if the most attractive option wouldn't be to emscripten-compile libpurple, with each prpl linked statically into a separate instance of libpurple.
08:20:58 <flo-retina> If it works, that means each libpurple prpl would automatically become a standalone js-prpl.
08:21:14 <flo-retina> The only downside would be that their JS code wouldn't be debuggable
08:21:35 <EionRobb> ooh
08:21:39 <flo-retina> well, of course the giant downside is that nobody's figured out yet how to emscripten compile libpurple...
08:22:31 <EionRobb> wouldn't it be all the deps that would make emscripten'ing it tricky?
08:22:52 <flo-retina> glib would probably suck.
08:23:10 <flo-retina> libxml2 isn't a very useful dep if we get rid of the libpurple xmpp implementation.
08:23:40 <EionRobb> its used for html parsing too?
08:23:57 <flo-retina> (and prevent libpurple from writing xml files to disk, which we currently mostly do, and would have to fully do with emscripten, as emscrpten-compiled code has to use only a virtual file system)
08:24:01 <flo-retina> really?
08:24:13 <EionRobb> my vote's for js-ctypes :)
08:24:17 <flo-retina> anyway, if we have to keep it, I don't expect xml2 to be the worst part
08:24:22 <flo-retina> EionRobb: there's no vote.
08:24:25 <EionRobb> hehehe
08:24:28 <EionRobb> oh, I know
08:24:35 <flo-retina> EionRobb: whoever writes working code first wins.
08:24:51 <EionRobb> an enscripten version would be badass :)
08:25:33 <flo-retina> EionRobb: yes, as it couldn't crash anymore at all. And we could start each prpl in a separate JS worker, so everything would be naturally async.
08:29:41 <EionRobb> I just realised that I totally missed the comedic moment to say "you don't vote for a king!"  alas
08:29:56 <EionRobb> although wouldn't you be able to help prevent crashes with a ctypes version too?
08:31:35 <EionRobb> and if any of you fine lads and lasses decide you're bored and want something to do, we're looking for help getting seedjs (that's mozilla right?) working with gplugin since they dropped support for the c-only api and none of us are very good with the ol c++'s
08:35:43 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:35:48 <flo-retina> ctypes would probably add crashes (because we would lose the static typing checks of the compiler; and still have a real binary libpurple that could party within the memory). It would reduce the security risk of crashes though, as the memory space of libpurple would be unlikely to access the main process's space (we could sandbox)
08:36:43 <flo-retina> I've never seen the 'seedjs' name before
08:37:18 <flo-retina> "SeedJS is built on node.js and Google V8" according to https://changelog.com/seedjs-flexible-javascript-package-manager-on-node-js/
08:46:49 <flo-retina> anyway, the work to use jsctypes or to empscripten would be very similar, as I expect the biggest piece of the work to be to reduce the libpurple API to 1-2 symbols (mostly a message passing API) that could then be used through js-ctypes, or exposed through emscripten.
09:08:03 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:27:17 <EionRobb> whoops, not seedjs
09:37:24 <EionRobb> gjs is the one I was thinking of
09:41:12 --> flo-retina has joined #instantbird
09:41:12 * ChanServ sets mode +qo flo-retina flo-retina 
10:10:10 <-- Alex1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
10:11:26 --> gerard-majax has joined #instantbird
10:22:24 <-- EionRobb has quit (Connection closed)
10:24:17 --> EionRobb has joined #instantbird
10:26:06 <-- EionRobb has quit (Quit: Leaving.)
10:30:17 --> freaktechnik_ has joined #instantbird
10:32:08 <-- freaktechnik has quit (Ping timeout: 121 seconds)
10:32:08 * freaktechnik_ is now known as freaktechnik 
10:42:05 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:43:02 --> afiksof1 has joined #instantbird
10:44:42 <-- afiksof has quit (Ping timeout: 121 seconds)
10:44:44 * afiksof1 is now known as afiksof 
10:45:12 --> gerard-majax has joined #instantbird
10:47:31 --> afiksof1 has joined #instantbird
10:48:46 <-- afiksof has quit (Ping timeout: 121 seconds)
10:48:50 * afiksof1 is now known as afiksof 
11:00:31 --> afiksof1 has joined #instantbird
11:03:01 <-- afiksof has quit (Ping timeout: 121 seconds)
11:03:05 * afiksof1 is now known as afiksof 
11:03:57 --> afiksof1 has joined #instantbird
11:06:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
11:07:06 <-- afiksof has quit (Ping timeout: 121 seconds)
11:07:06 * afiksof1 is now known as afiksof 
11:17:13 --> clokep has joined #instantbird
11:17:13 * ChanServ sets mode +o clokep 
11:21:10 --> aleth has joined #instantbird
11:21:10 * ChanServ sets mode +o aleth 
11:22:00 --> abdelrhman has joined #instantbird
11:35:55 --> afiksof1 has joined #instantbird
11:39:29 <-- afiksof has quit (Ping timeout: 121 seconds)
11:39:29 * afiksof1 is now known as afiksof 
11:51:43 --> gerard-majax has joined #instantbird
11:56:41 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:03:18 <-- aleth has quit (Ping timeout: 121 seconds)
12:26:18 --> aleth has joined #instantbird
12:26:18 * ChanServ sets mode +o aleth 
12:37:32 --> clokep_work has joined #instantbird
12:37:32 * ChanServ sets mode +o clokep_work 
12:39:17 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:39:20 --> clokep_work has joined #instantbird
12:39:20 * ChanServ sets mode +o clokep_work 
12:41:13 <abdelrhman> flo-retina: here?
12:41:19 <flo-retina> yes
12:42:17 <abdelrhman> Does FB provides name attribute in responding to roster query? (regardless of bug 1176667)
12:42:19 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1176667 nor, --, ---, nobody, UNCO, Facebook connection attempt fails after roster request
12:45:21 <clokep_work> flo-retina: emscripten is also an option, yes. I'm afraid of all the dependencies of that, yes.
12:45:37 <clokep_work> libxml, glib, plus how do things like sockets work in that land?
12:45:45 <clokep_work> I guess someone would need to try it and see what happens.
12:48:32 --> afiksof1 has joined #instantbird
12:49:36 <clokep_work> It's never been super clear to me how you go from "compile with emscripten" to actually calling that code. :-D
12:49:46 <clokep_work> But I suppose that's cause I'eve never tried to do it.
12:50:46 <flo-retina> clokep_work: I think we would use socket.jsm, and transmit the data over an array buffer
12:51:08 <clokep_work> flo-retina: Doesn't libpurple have a socket in it though? What happens to that code?
12:51:22 <clokep_work> Or do you provide some sort of interface saying "I'll write this code by hand"?
12:51:30 <flo-retina> we'll need to get rid of it / make it call our own API
12:51:49 <flo-retina> (that's already almost what we need to do just to fix the proxy mess)
12:52:08 <-- afiksof has quit (Ping timeout: 121 seconds)
12:52:08 * afiksof1 is now known as afiksof 
12:52:32 --> qheaden has joined #instantbird
12:53:13 <clokep_work> Cool, OK. I think I understand then.
12:53:29 <clokep_work> Good morning qheaden.
12:53:34 <flo-retina> our debug logs are too hard to read :(
12:53:41 <clokep_work> nhnt11?
12:53:48 <qheaden> Good morning!
12:53:56 <flo-retina> we should have obvious color codes for incoming data / outgoing data
12:55:52 <clokep_work> They're colored by level IIRC?
12:55:55 <flo-retina> abdelrhman: Facebook roster items look like this:
12:55:55 <flo-retina> <item xmlns="jabber:iq:roster" jid="-1432413461@chat.facebook.com" name="Alexis Brooks" subscription="both">
12:55:55 <flo-retina> <group xmlns="jabber:iq:roster">
12:55:55 <flo-retina> Facebook Friends
12:55:55 <flo-retina> </group>
12:55:55 <flo-retina> </item> 
12:55:59 <flo-retina> clokep_work: right
12:56:08 <clokep_work> (I agree they're not the best.)
12:59:39 <flo-retina> I don't understand what that code does from looking at the debug log
12:59:54 <flo-retina> when we connect to facebook, we receive <presence> stanzas for the currently-online friends
12:59:55 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
12:59:58 <abdelrhman> flo-retina: Thanks. I think we can make a temporary fix for flood of vcard requests by adding check for name attribute (https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1943)
13:00:08 <flo-retina> when I last connected (ie. the debug log I'm looking at), I had 18 online friends.
13:00:13 --> chrisccoulson has joined #instantbird
13:00:20 <flo-retina> somehow we receive these <presence> stanzas _before_ the roster
13:00:31 <flo-retina> then in the roster I have several hundred friends
13:00:51 <flo-retina> then after we get the roster, we request vcards for 12 jids. (why 12?)
13:01:38 <flo-retina> err, that's actually 11
13:02:02 <flo-retina> and we receive 11 times the error stanza:
13:02:02 <flo-retina> <error xmlns="jabber:client" code="404" type="cancel">
13:02:02 <flo-retina> <item-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
13:02:02 <flo-retina> </error> 
13:02:27 <flo-retina> I wonder why my contacts displayed in the contacts window have an icon, as there's no icon received for them at any time in my debug log
13:02:40 <flo-retina> maybe we just rely on old icons already stored in my profile :-S
13:03:00 <flo-retina> next time I have a recent friend who's online, I'll see if they have an icon visible
13:05:03 <abdelrhman> I hope that's not related to shutting down xmpp for FB
13:06:13 <flo-retina> I don't know what's happening, so your guesses are as good as mine ;)
13:07:35 <aleth> are those 11 the ones that are online?
13:08:09 <aleth> if there's also 11 errors, maybe fb doesn't provide vcards
13:08:12 <flo-retina> I would assume they are out of the 18 online ones
13:08:19 <abdelrhman> flo-retina: Can you test that on Pidgin?
13:08:28 <flo-retina> aleth: all the vcard requests are indeed rejected
13:08:30 <flo-retina> abdelrhman: no
13:09:12 * flo-retina hasn't seen Pidgin in years
13:10:16 <flo-retina> I have 33 conversations on hold
13:10:22 <flo-retina> maybe I'm abusing the feature a little bit :)
13:11:59 <clokep_work> Bug 921040 is interesting.
13:12:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=921040 nor, --, ---, ted, RESO FIXED, Cross-compile Firefox for Mac on Linux
13:13:49 <clokep_work> 161 comments, nice.
13:14:47 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:15:05 --> chrisccoulson has joined #instantbird
13:15:34 <abdelrhman> so I think the fix would help us get rid of these useless requests and the flooding of requests 
13:15:50 <abdelrhman> Do you agree?
13:18:14 <-- aleth has quit (Ping timeout: 121 seconds)
13:18:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:18:38 --> chrisccoulson has joined #instantbird
13:19:42 --> aleth has joined #instantbird
13:19:42 * ChanServ sets mode +o aleth 
13:19:56 <flo-retina> abdelrhman: seems reasonable
13:29:48 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:30:53 --> chrisccoulson has joined #instantbird
13:33:06 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
13:43:44 --> chrisccoulson has joined #instantbird
13:57:37 <abdelrhman> flo-retina, aleth: check (https://code.google.com/p/vacuum-im/issues/detail?id=778)
13:59:01 <flo-retina> we are not affected by this issue
13:59:17 <flo-retina> the stuff related to the user's vCard is the only vCard exchange that actually seems to work
14:07:47 <-- aleth has quit (Ping timeout: 121 seconds)
14:10:44 --> aleth has joined #instantbird
14:10:44 * ChanServ sets mode +o aleth 
14:24:39 <-- aleth has quit (Quit: :tiuQ)
14:27:55 --> hadi has joined #instantbird
14:38:01 <-- flo-retina has quit (Ping timeout: 121 seconds)
14:59:15 --> flo-retina has joined #instantbird
14:59:15 * ChanServ sets mode +qo flo-retina flo-retina 
15:18:03 <-- hadi has quit (Ping timeout: 121 seconds)
15:34:18 <-- abdelrhman has quit (Ping timeout: 121 seconds)
16:00:22 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:01:15 --> nhnt12 has joined #instantbird
16:01:15 * ChanServ sets mode +h nhnt12 
16:02:53 <-- nhnt11 has quit (Ping timeout: 121 seconds)
16:02:53 * nhnt12 is now known as nhnt11 
16:11:50 --> Bollebib has joined #instantbird
16:15:13 <-- nhnt11 has quit (Ping timeout: 121 seconds)
16:21:16 <-- Yoric has quit (G-Lined: don't spam us)
16:23:52 --> Yoric has joined #instantbird
16:25:35 --> gerard-majax has joined #instantbird
16:28:04 --> nhnt11 has joined #instantbird
16:28:04 * ChanServ sets mode +h nhnt11 
16:43:43 --> afiksof1 has joined #instantbird
16:47:11 <-- afiksof has quit (Ping timeout: 121 seconds)
16:47:41 * afiksof1 is now known as afiksof 
16:48:43 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:53:26 --> gerard-majax has joined #instantbird
17:00:20 --> afiksof1 has joined #instantbird
17:00:26 --> myk has joined #instantbird
17:01:56 --> myk1 has joined #instantbird
17:02:06 <-- afiksof has quit (Ping timeout: 121 seconds)
17:02:06 * afiksof1 is now known as afiksof 
17:02:09 <-- myk has quit (Connection closed)
17:02:09 * myk1 is now known as myk 
17:03:29 <-- gerard-majax has quit (Quit: Leaving)
17:03:43 --> gerard-majax has joined #instantbird
17:06:41 --> afiksof1 has joined #instantbird
17:06:49 <-- afiksof has quit (Connection closed)
17:06:49 * afiksof1 is now known as afiksof 
17:10:51 <-- afiksof has quit (Ping timeout: 121 seconds)
17:11:23 --> afiksof has joined #instantbird
17:16:45 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:19:34 <-- afiksof has quit (Ping timeout: 121 seconds)
17:21:41 --> afiksof has joined #instantbird
17:24:30 --> gerard-majax has joined #instantbird
17:39:59 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:55:09 <-- myk has quit (Ping timeout: 121 seconds)
18:00:17 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:01:43 --> myk has joined #instantbird
18:02:51 --> myk1 has joined #instantbird
18:05:46 <-- myk has quit (Ping timeout: 121 seconds)
18:05:46 * myk1 is now known as myk 
18:12:38 <-- myk has quit (Connection closed)
18:12:38 --> myk1 has joined #instantbird
18:12:40 * myk1 is now known as myk 
18:14:44 --> myk1 has joined #instantbird
18:15:16 <-- Tonnes has quit (Connection closed)
18:16:42 <-- myk has quit (Ping timeout: 121 seconds)
18:16:42 * myk1 is now known as myk 
18:23:09 --> aleth has joined #instantbird
18:23:09 * ChanServ sets mode +o aleth 
18:29:10 --> Tonnes has joined #instantbird
18:38:53 <-- myk has quit (Ping timeout: 121 seconds)
18:39:00 --> myk has joined #instantbird
18:48:15 <Mook_as> Odd, it looks like people's typing notification isn't timing out (i.e. they're stuck as if they're typing)
18:49:19 <Mook_as> ... And of course it times out right when I talk about it on IRC. nevermind.
18:50:45 <clokep_work> :P
18:50:55 <clokep_work> It can get broken sometimes, I think we mostly fixed it for GTalk.
18:51:54 <freaktechnik> I've been looking into dynamic protocol registration (so restartless extensions work as prpl providers). Do accounts get disconnected before extensions are unloaded on shutdown? I'd guess so, since else you'd have a problem already, right?
18:53:36 <clokep_work> freaktechnik: http://mxr.mozilla.org/comm-central/source/chat/components/src/imCore.js#286
18:54:08 <freaktechnik> clokep_work: that doesn't tell me where this is ran compared to extensions getting unloaded.
18:54:27 <clokep_work> freaktechnik: Sorry, I thought you were asking for build in protocols.
18:54:37 <clokep_work> freaktechnik: I don't think we enforce any connection between those.
18:54:45 <clokep_work> aleth might know?
18:54:58 <freaktechnik> hmm, it's in quit-application-granted. Now to find out when add-ons unload.
18:55:12 <clokep_work> I think add-ons have a signal before that.
18:55:32 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:55:55 <aleth> no idea when addons get the shutdown() call
18:56:09 <aleth> I'd assume after the uninit's
18:56:14 <clokep_work> (Mook_as probably knows, he's been in Mozilla land far too long. :-D)
18:56:17 <freaktechnik> I'd hope so too...
18:56:28 <freaktechnik> because else it'd be a pretty ugly shutdown^^
18:57:22 <Mook_as> I don't think extension unload happens on shutdown at all?
18:57:32 <Mook_as> BRB, food
18:57:59 <freaktechnik> it does for bootstrapped ones at least. And overlay extensions's compartments get destroyed at some point too...
18:59:42 --> myk1 has joined #instantbird
19:03:13 <-- myk has quit (Ping timeout: 121 seconds)
19:03:13 * myk1 is now known as myk 
19:08:36 --> flo-retina has joined #instantbird
19:08:36 * ChanServ sets mode +qo flo-retina flo-retina 
19:21:45 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:23:01 --> afiksof has joined #instantbird
19:30:48 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:42:47 --> BWMerlin1 has joined #instantbird
19:44:18 <-- BWMerlin has quit (Ping timeout: 121 seconds)
19:44:18 * BWMerlin1 is now known as BWMerlin 
19:47:13 <-- myk has quit (Ping timeout: 121 seconds)
19:47:48 --> myk has joined #instantbird
19:57:23 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:01:26 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:06:21 --> myk has joined #instantbird
20:10:24 <-- myk has quit (Ping timeout: 121 seconds)
20:15:24 --> myk has joined #instantbird
20:17:01 --> pimpdugger has joined #instantbird
20:24:45 <-- myk has quit (Connection closed)
20:24:48 --> myk has joined #instantbird
20:26:31 --> myk1 has joined #instantbird
20:28:51 <-- myk has quit (Ping timeout: 121 seconds)
20:28:56 --> myk has joined #instantbird
20:29:05 <-- myk1 has quit (Connection closed)
20:33:48 <-- pimpdugger has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:34:53 --> clokep has joined #instantbird
20:34:53 * ChanServ sets mode +o clokep 
21:00:47 --> myk1 has joined #instantbird
21:00:55 <-- myk has quit (Ping timeout: 121 seconds)
21:01:22 --> myk has joined #instantbird
21:03:16 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:04:21 <-- clokep has quit (Ping timeout: 121 seconds)
21:04:49 <-- myk1 has quit (Ping timeout: 121 seconds)
21:05:50 --> clokep_work has joined #instantbird
21:05:50 * ChanServ sets mode +o clokep_work 
21:14:20 * clokep_work wonders if flo-retina has ever set-up emscripten.
21:45:33 <clokep_work> aleth: What for?
21:46:14 <aleth> bug 1207551
21:46:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1207551 nor, --, ---, nobody, NEW, Remove obsolete libpurple prpls
21:46:40 <aleth> ah no, I mean bug 1193643	
21:46:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1193643 nor, --, ---, aleth, ASSI, Allow requestBuddyInfo to return some info immediately
21:49:00 <clokep_work> aleth: I'm unsure if bug 1207551 has a good solution (unless qheaden finds time to fix those last couple issues).
21:49:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1207551 nor, --, ---, nobody, NEW, Remove obsolete libpurple prpls
21:49:53 <aleth> clokep_work: right, for now let's wait on that
21:50:23 <aleth> If we actually got to the point where we could release, I don't think it would block, ultimately. But until then we can keep it in mind
21:50:28 <clokep_work> aleth: So why the rename from equestBuddyInfo to requestCurrentWhois?
21:51:18 <clokep_work> (Specifically the one on the accountbuddy?)
21:51:21 <clokep_work> Is that just to match APIs?
21:51:23 <aleth> Because requestBuddyInfo is in the API, but internal IRC consumers only want a single notification with the new data
21:51:52 <clokep_work> Right, but only on the account, right?
21:52:14 <aleth> I thought if I had to rename it there I should do it consistently
21:52:28 <clokep_work> OK, just making sure that's it.
21:53:22 <aleth> Maybe you have a better name or whatever
21:53:58 <clokep_work> Nah.
21:55:08 <aleth> You're right about the comment, I was being unneccesarily specific
21:55:28 <clokep_work> :)
21:55:44 <clokep_work> I'm glad I understood what I was reading haha
21:55:57 <aleth> I don't think sending a notification for each line of WHOIS is a good idea (might cause too much flicker)
21:56:25 <clokep_work> Fair enough.
21:57:01 <aleth> If we had someone here who liked playing with CSS transitions, we could make the tooltip resize smoother I guess
21:57:15 <clokep_work> aleth: How do we actually fire the notification: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircBase.jsm#760 :-S
21:57:49 <clokep_work> Ah I'm an idiot.
21:57:58 <clokep_work> It's RPL_ENDOFWHOIS
21:58:03 <clokep_work> Not RPL_ENDOFWHO ;)
21:58:21 * clokep_work goes back to his corner.
21:58:26 * clokep_work is now known as clokep 
22:31:40 <aleth> clokep: Thanks
22:34:11 <clokep> aleth: No problem. :)
22:34:31 <clokep> aleth: So what was that fixing again? :-D
22:35:34 <aleth> that notification patch?
22:37:56 <-- Bollebib has quit (Connection closed)
22:37:58 --> Bollebib has joined #instantbird
22:39:51 <clokep> Yeah
22:42:37 <aleth> mainly you get the status in the js-xmpp tooltips immediately now
22:42:56 <aleth> though I suspect you will notice with IRC too if you've been connected for a bit
22:43:41 <clokep> Cool.
22:43:59 <aleth> mainly, low hanging fruit, etc
22:44:09 <freaktechnik> rolling up and down in the buddy list should look way better
22:44:21 <freaktechnik> because whoises you already have appear immediately, right?
22:44:23 <aleth> yes, that too
22:45:38 <instantbot> aleth@instantbird.org changed the Resolution on bug 1179866 from --- to FIXED.
22:45:39 <instantbot> aleth@instantbird.org changed the Resolution on bug 1193643 from --- to FIXED.
22:45:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1179866 nor, --, Instantbird 44, nobody, RESO FIXED, Commands with numbers in them don't get executed
22:45:41 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1193643 nor, --, Instantbird 44, aleth, RESO FIXED, Allow requestBuddyInfo to return some info immediately
22:46:30 <-- Bollebib has quit (Connection closed)
22:46:33 --> Bollebib has joined #instantbird
22:50:12 <-- micahg has quit (Connection closed)
23:00:57 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
23:04:35 <aleth> Thoughts on bug 1209777
23:04:36 <aleth> ?
23:04:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1209777 nor, --, ---, mkmelin+mozilla, ASSI, comm-central will undoubtedly break when bug 589199 lands
23:04:40 <aleth> It's ugly...
23:08:21 <clokep> I thought jcranmer said it isn't too bad?
23:08:54 <aleth> All the const becoming var isn't pretty imho
23:09:11 <clokep> Oh.
23:09:41 <clokep> Wish that had been split into smaller ones...
23:09:53 <nhnt11> "My god, this patch is humongous." is right...
23:11:19 <clokep> Ah nhnt11 just volunteered to review it!
23:11:20 <clokep> :P
23:11:25 <clokep> aleth: So what do you want thoughts on though?
23:11:28 <clokep> Besides that it kind of sucks.
23:11:45 * freaktechnik thinks it's kind of a kill the fly with fire approach
23:11:49 <aleth> Whether there's any clever alternatives I guess
23:12:12 <aleth> e.g. only do this for const {Cu... } = Components;
23:14:04 <clokep> aleth: "(You can also easily run the script yourself for the dir you review.)" is probably the way to do it.
23:14:26 <clokep> If you want to write the patch. :-D
23:43:01 --> Mnyromyr has joined #instantbird
23:48:25 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.38/20150923193515])