All times are UTC.
00:10:40 --> Alex1 has joined #instantbird 00:25:53 <-- abdelrhman has quit (Quit: Leaving) 01:01:04 <freaktechnik> I'm confused. I get errors, that my IRC handlers have too much recursion. 01:17:50 <freaktechnik> does it keep retrying handlers until it gets an exception? 03:05:07 <instant-buildbot> build #1537 of linux-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1537 03:43:13 <Mook> Hmm, unclear how I would get the conversation binding with which to call addTextModifier. 03:44:13 <Mook> I guess in general trying to hack around this thing is no good, and I should just try to solve the thing inside IB first. 03:48:14 <Mook> freaktechnik: Okay, trying to confirm what you're looking for (to see if I can think of something that might satisfy us both): you have some untrusted message gunk, and you're inserting an image or two inside of that that you do want to show up? Can you give an example of what it would look like / what sort of thing you want to insert? 03:48:26 --> myk has joined #instantbird 03:54:08 <-- myk has quit (Connection closed) 03:54:13 --> myk has joined #instantbird 03:56:16 <Mook> Looking at bug 955011, it looks more like it wants to be able to attach multiple things to a message; some of those things are links (e.g. bug links), and some of those are media (images, videos), all out-of-line and scraped for. 03:56:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955011 enh, --, ---, nobody, NEW, Inline received media 03:56:27 <Mook> So, essentially, multiple attachments. 03:56:52 * Mook is assuming bug links are provided by an addon, rather than being built in 03:57:44 <Mook> Though I guess in the bug link case it'd be more useful to provide the summary + status as the link text, rather than just "2". 03:57:52 <instant-buildbot> build #2922 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2922 03:58:40 <Mook> Which still doesn't seem to match freaktechnik's requirements; more clarity on that would probably help. 04:11:44 --> myk1 has joined #instantbird 04:12:25 <-- myk has quit (Ping timeout: 121 seconds) 04:12:25 * myk1 is now known as myk 04:17:18 --> myk1 has joined #instantbird 04:17:24 <-- myk has quit (Connection closed) 04:17:25 * myk1 is now known as myk 04:17:52 <-- myk has quit (Connection closed) 04:17:52 --> myk1 has joined #instantbird 04:20:22 * myk1 is now known as myk 04:21:05 --> myk1 has joined #instantbird 04:21:05 <-- myk has quit (Connection closed) 04:21:07 * myk1 is now known as myk 04:26:46 --> nhnt12 has joined #instantbird 04:26:46 * ChanServ sets mode +h nhnt12 04:26:59 <-- nhnt11 has quit (Connection closed) 04:26:59 * nhnt12 is now known as nhnt11 04:29:47 --> nhnt12 has joined #instantbird 04:29:47 * ChanServ sets mode +h nhnt12 04:29:50 <-- nhnt11 has quit (Connection closed) 04:29:50 * nhnt12 is now known as nhnt11 04:31:03 <instant-buildbot> build #1759 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1759 04:37:18 <-- myk has quit (Connection closed) 04:37:52 --> myk has joined #instantbird 04:41:07 --> afiksof has joined #instantbird 04:46:11 <-- myk has quit (Ping timeout: 121 seconds) 04:46:50 --> myk has joined #instantbird 04:49:44 --> myk1 has joined #instantbird 04:50:17 <-- myk has quit (Connection closed) 04:50:17 * myk1 is now known as myk 04:56:01 <-- myk has quit (Connection closed) 04:56:09 <-- EionRobb has quit (Quit: Leaving.) 04:57:02 --> myk has joined #instantbird 05:01:05 <-- myk has quit (Ping timeout: 121 seconds) 05:31:58 <instant-buildbot> build #447 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/447 05:36:34 <-- Bollebib has quit (Ping timeout: 121 seconds) 05:50:42 <-- Mook has quit (Client exited) 07:08:03 --> gerard-majax has joined #instantbird 07:24:12 --> afiksof1 has joined #instantbird 07:25:42 <-- afiksof has quit (Ping timeout: 121 seconds) 07:25:42 * afiksof1 is now known as afiksof 07:29:46 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:31:42 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:11:21 --> gerard-majax has joined #instantbird 08:21:10 --> afiksof has joined #instantbird 08:30:41 --> mpmc has joined #instantbird 08:39:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:42:26 --> gerard-majax has joined #instantbird 08:47:11 <freaktechnik> Mook_as: I've linked a screenshot in my comment in the bug. I get mtadata on messages that tell me what parts of the measssage (character indexes) have to be replaced with an image, because the allowed replacements vary by user. Only outgoung messages have generic patterns. 09:04:27 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:12:29 --> aleth has joined #instantbird 09:12:29 * ChanServ sets mode +o aleth 09:20:52 --> afiksof1 has joined #instantbird 09:24:08 <-- afiksof has quit (Ping timeout: 121 seconds) 09:24:08 * afiksof1 is now known as afiksof 09:24:56 <-- Tobin has quit (Connection closed) 09:24:57 <-- pWnnn has quit (Ping timeout: 121 seconds) 09:26:31 --> Tobin has joined #instantbird 09:31:27 <-- BWMerlin has quit (Client exited) 09:31:46 --> BWMerlin has joined #instantbird 09:34:06 --> pWnnn has joined #instantbird 09:35:56 <-- Alex1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 09:47:42 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:48:00 --> gerard-majax has joined #instantbird 10:13:00 <-- nhnt11 has quit (Ping timeout: 121 seconds) 10:16:36 --> flo-retina has joined #instantbird 10:16:36 * ChanServ sets mode +qo flo-retina flo-retina 10:21:01 <-- pWnnn has quit (Ping timeout: 121 seconds) 10:22:08 --> hadi has joined #instantbird 10:25:38 --> pWnnn has joined #instantbird 10:32:33 --> freaktechnik_ has joined #instantbird 10:32:54 <-- freaktechnik has quit (Ping timeout: 121 seconds) 10:32:55 * freaktechnik_ is now known as freaktechnik 10:46:51 --> clokep has joined #instantbird 10:46:51 * ChanServ sets mode +o clokep 10:54:57 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:55:13 --> clokep has joined #instantbird 10:55:13 * ChanServ sets mode +o clokep 11:02:24 --> mikk_s has joined #instantbird 11:11:15 --> Bollebib has joined #instantbird 11:12:42 <clokep> freaktechnik: Yeah the handlers get registered when the ircProtocol object is instantiated. 11:12:58 <clokep> Which I think is a singleton. 11:13:30 <freaktechnik> clokep: it was my fault, I instantiated it manually. And no, protocols aren't singletons but the protocol manager makes sure they are only instantiated once. 11:13:44 <clokep> Is that different than a singleton? ;) 11:13:50 <clokep> The comment at the top of https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircHandlers.jsm should be helpful. 11:14:21 <clokep> http://patrick.cloke.us/posts/2012/06/11/irc-auto-performs/ might vaguely be useful too. 11:14:23 <freaktechnik> oh, I should use isEnabled. 11:14:28 <freaktechnik> that's exactly what I need. 11:14:46 <freaktechnik> because I only want to use them for accounts I created. 11:15:15 <clokep> :-D 11:15:25 <clokep> Yeah it's a function that takes the account object. 11:15:29 <clokep> So you can check the network essentially. 11:15:40 <freaktechnik> exactly 11:15:47 <clokep> Mook_as: Yeah so the one usecase is a bit different. 11:16:01 <clokep> It's scraping content for links that are known to be 'safe', e.g. YouTube can be rendered as a preview. 11:16:38 <freaktechnik> clokep: so if all handlers return false it seems it just retries them? Because I get recursion errors when my handlers return false and there is no default handler for a command 11:19:18 <clokep> freaktechnik: It shouldn't. 11:19:20 <-- mikk_s has quit (Ping timeout: 121 seconds) 11:19:47 <clokep> I think it's just a loop. 11:20:00 <clokep> https://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircHandlers.jsm#104 11:20:05 <freaktechnik> well, I think the circumstances were, that a handler threw instead of returning. 11:20:59 <-- hadi has quit (Connection closed) 11:21:03 --> hadi has joined #instantbird 11:23:22 <freaktechnik> (I've fixed it by fixing the exceptions in the first place, which sounds like a sensible idea either way ;) ) 11:25:49 <clokep> I'm still surprised (even w/ an exception ) that it would recurse 11:26:26 <freaktechnik> yeah, I was wonder where there is recursion 11:27:52 <freaktechnik> *wondering 11:28:20 <-- hadi has quit (Connection closed) 11:28:42 --> hadi has joined #instantbird 11:34:17 <clokep> Yeah I don't see how there can be recursion in there. :-\ 11:34:40 * clokep also wonders if it was an IRC message or if it was CTCP or something else. 11:38:06 <-- hadi has quit (Connection closed) 11:39:11 --> hadi has joined #instantbird 11:49:32 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:53:51 <-- hadi has quit (Connection closed) 11:53:55 --> hadi has joined #instantbird 11:57:57 <-- hadi has quit (Ping timeout: 121 seconds) 12:00:30 <-- Tobin has quit (Connection closed) 12:02:10 --> Tobin has joined #instantbird 12:04:41 --> MattATobin has joined #instantbird 12:07:22 <-- Tobin has quit (Ping timeout: 121 seconds) 12:09:10 <freaktechnik> it was IRC messages (PRVMSG and JOINs) 12:09:42 <freaktechnik> (and ROOMSTATE, which is a custom command on that network...) 12:09:50 <-- aleth has quit (Quit: :tiuQ) 12:09:56 --> aleth has joined #instantbird 12:09:56 * ChanServ sets mode +o aleth 12:10:39 --> afiksof1 has joined #instantbird 12:13:03 <-- afiksof has quit (Ping timeout: 121 seconds) 12:13:03 * afiksof1 is now known as afiksof 12:14:08 <-- aleth has quit (Ping timeout: 121 seconds) 12:27:36 --> clokep_work has joined #instantbird 12:27:36 * ChanServ sets mode +o clokep_work 12:33:15 --> aleth has joined #instantbird 12:33:15 * ChanServ sets mode +o aleth 12:33:52 --> mikk_s has joined #instantbird 12:46:50 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:46:54 --> clokep_work has joined #instantbird 12:46:54 * ChanServ sets mode +o clokep_work 13:15:54 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 14:22:27 --> nhnt11_phone has joined #instantbird 14:34:58 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 15:14:12 <-- clokep_work has quit (Ping timeout: 121 seconds) 15:47:39 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:58:39 --> Mnyromyr has joined #instantbird 16:04:09 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:10:38 --> flo-retina has joined #instantbird 16:10:38 * ChanServ sets mode +qo flo-retina flo-retina 16:26:35 --> gerard-majax has joined #instantbird 16:54:53 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:00:04 --> gerard-majax has joined #instantbird 17:14:45 --> myk has joined #instantbird 17:22:53 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:23:30 <Mook_as> Thanks for pointing me at the screenshot. So it's... sort of more like emoticons? 17:24:26 <freaktechnik> well, kind of, just very sophisticated. 17:25:07 <Mook_as> Right. UI-wise, I mean. 17:25:10 <freaktechnik> for incoming messages it works like desctibed under emotes. http://test-ipv6.com/ 17:25:14 <freaktechnik> wrong pasta 17:25:18 <freaktechnik> https://github.com/justintv/Twitch-API/blob/master/IRC.md#privmsg 17:25:52 <freaktechnik> well, in theory people can assign any image to it, but in the end it's an image directly in the text, so I guess it'll always be an emoticon/emoji like usage. 17:27:50 --> gerard-majax has joined #instantbird 17:29:58 <freaktechnik> How would I write tests for 1179866, since the current tests don't run through the code bit the bug affects 17:31:08 <freaktechnik> bug 1179866 17:31:10 --> myk1 has joined #instantbird 17:31:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1179866 nor, --, ---, nobody, UNCO, Commands with numbers in them don't get executed 17:31:10 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:31:11 * myk1 is now known as myk 17:36:55 <aleth> freaktechnik: IB currently doesn't have any UI tests, sadly. So if the backend part is fine, I guess you could just fix up that regex 17:37:23 <freaktechnik> well, it's not an UI test per se, since it's in the commands component, but I guess I see what you mean 17:37:53 <aleth> oh, sorry! it's imCommands, not conversation.xml 17:38:05 <aleth> Yes, that does have tests you could add to 17:38:47 <aleth> That would be good. 17:40:09 <aleth> test_commands.js 17:41:00 <freaktechnik> but those tests don't run the method the change is in. That code never gets ran with those tests. 17:41:33 <freaktechnik> and I don't see how you'd run tests on that method just from looking at it. 17:41:43 <aleth> Right, you'd have to write a new test to cover that function 17:42:18 <aleth> But that could probably be done by extending the existing test (reusing/adding to the test data there) 17:43:36 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:43:44 <aleth> You'd probably have to add some things (e.g. run() methods to the example commands in the test) 17:44:40 <aleth> If you're not sure about xpcshell tests, there's some useful mdn pages 17:46:52 <aleth> I guess I'm not sure what the problem is? 18:05:01 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 18:12:04 --> Bollebib has joined #instantbird 18:16:06 <-- Bollebib has quit (Ping timeout: 121 seconds) 18:21:39 --> gerard-majax has joined #instantbird 18:22:09 --> clokep_work has joined #instantbird 18:22:09 * ChanServ sets mode +o clokep_work 18:22:39 --> clokep has joined #instantbird 18:22:40 * ChanServ sets mode +o clokep 18:38:41 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:39:39 <-- myk has quit (Ping timeout: 121 seconds) 19:15:33 <-- Mnyromyr has quit (Ping timeout: 121 seconds) 19:16:40 --> Mnyromyr has joined #instantbird 19:25:31 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.38/20150923193515]) 19:26:49 <-- afiksof has quit (Connection closed) 19:35:59 <clokep_work> instantbot: uuid 19:36:00 <instantbot> c80e7e5b-04d5-4837-bd8c-376fd9986c7c (/msg instantbot cid for CID form) 19:38:27 <-- mpmc has quit (Connection closed) 20:07:29 --> Bollebib has joined #instantbird 20:18:55 --> myk has joined #instantbird 20:35:34 <flo-retina> clokep_work: ./mozilla/mach uuid 20:41:54 --> EionRobb has joined #instantbird 20:43:43 <clokep> flo-retina: ...? 20:43:50 <clokep> Is that easier? :P 20:44:05 <flo-retina> clokep: it works when you are hacking in a flight ;) 20:44:20 * clokep isn't on a plane to his knowledge. 20:44:25 <clokep> I didn't have a shell open. ;) 20:44:26 <freaktechnik> you can also have uuid directly^^ 20:44:40 <clokep> See point above. ;) 20:45:08 <flo-retina> I think developing a xulrunner app to generate uuids without a terminal should be possible :-P 20:45:18 <freaktechnik> there is no such thing as not having an open shell^^ 20:45:34 <freaktechnik> and I'm sure there's a firefox extension to generate uuids in a panel somewhere ;) 20:47:44 <clokep_work> :-) 20:50:13 <aleth> There's probably a number you can text to get a uuid back in a SMS? 20:50:45 <freaktechnik> 1-800-uuid? nah, that's too short. 20:53:53 <Mook_as> 1-800-uuid-gen? 20:54:09 * freaktechnik has no idea how long US numbers are supposed to be, tbh 20:54:16 <clokep_work> flo-retina: 7 digits. 20:54:21 <clokep_work> freaktechnik: 7-digits. 20:54:29 <clokep_work> Apparently the Canadians (Mook_as) stole that from us. 20:54:52 <Mook_as> We also stole your country code! 20:55:02 <flo-retina> +1-800- numbers are too expensive for me, sorry 20:55:08 <freaktechnik> as if it was a code for the continent. 20:55:09 <clokep_work> Mook_as: The US doesn't have a country code, we just dial without it. ;) 20:55:11 <Mook_as> (and yes, `uuidgen` is an actual binary you might have) 20:55:18 <aleth> clokep_work: :D 20:55:25 <clokep_work> I think all of this really points to Canada being part of the US. ;) 20:55:32 <flo-retina> Mook_as: it outputs uppercase for me :( 20:55:34 <Mook_as> ... Or the other way around 20:55:45 <flo-retina> Mook_as: I actually use: uuidgen|tr A-Z a-z 20:57:41 * clokep_work usually uses: uuidgen | sed s/\-//g | grep -o . | sort | tr -d "\n" 21:01:20 <-- myk has quit (Ping timeout: 121 seconds) 21:02:22 --> hadi has joined #instantbird 21:07:17 <-- clokep has quit (Ping timeout: 121 seconds) 21:13:24 --> myk has joined #instantbird 21:15:42 <clokep_work> aleth: You have any opinions about 0-9 or \d in regex? 21:16:02 <aleth> clokep_work: not really, if you have a preference, put it in the bug! 21:16:15 <clokep_work> a-z0-9 looks better than a-z\d. :) 21:16:26 <aleth> lgtm too. 21:20:57 <-- hadi has quit (Connection closed) 21:21:13 --> hadi has joined #instantbird 21:53:51 <-- Bollebib has quit (Ping timeout: 121 seconds) 21:55:57 --> nhnt11 has joined #instantbird 21:55:57 * ChanServ sets mode +h nhnt11 22:35:10 <-- BWMerlin has quit (Client exited) 22:35:27 --> BWMerlin has joined #instantbird 22:59:51 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:59:53 --> myk has joined #instantbird 23:05:57 <-- myk has quit (Ping timeout: 121 seconds) 23:08:37 <-- aleth has quit (Quit: :tiuQ) 23:44:36 <-- hadi has quit (Connection closed) 23:44:59 --> hadi has joined #instantbird