#instantbird log on 09 30 2015

All times are UTC.

00:05:50 --> Alex2 has joined #instantbird
00:06:53 --> clokep has joined #instantbird
00:06:53 * ChanServ sets mode +o clokep 
00:09:14 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:09:16 --> clokep has joined #instantbird
00:09:16 * ChanServ sets mode +o clokep 
00:13:40 <-- myk has quit (Ping timeout: 121 seconds)
00:53:11 --> EionRobb1 has joined #instantbird
00:55:43 <-- EionRobb has quit (Ping timeout: 121 seconds)
00:57:44 <-- clokep_work has quit (Ping timeout: 121 seconds)
01:54:52 <-- aleth has quit (Ping timeout: 121 seconds)
02:06:59 <-- clokep has quit (Ping timeout: 121 seconds)
02:58:44 <Mook> Hmm, are there message themes that actually show the date (possibly on first message after midnight)?
03:06:19 <-- Tobin has quit (Ping timeout: 121 seconds)
03:08:02 --> Tobin has joined #instantbird
03:10:25 <instant-buildbot> build #1536 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1536
03:32:55 <Mook> https://dxr.mozilla.org/comm-central/source/chat/components/src/imConversations.js#28 doesn't allow me to get the original prplIMessage does it :| (trying to handle text attachments...)
03:41:37 <Mook> (Working around it by holding a temporary map based on msg.id)
03:57:19 <instant-buildbot> build #2921 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2921
04:20:25 <instant-buildbot> build #1758 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1758
04:46:25 <instantbot> New Chat Core - General bug 1209854 filed by mook.moz+mozbz@gmail.com.
04:46:26 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1209854 enh, --, ---, nobody, NEW, Have some way of displaying messages which have images
04:51:03 <-- EionRobb1 has quit (Quit: Leaving.)
05:08:49 --> mpmc has joined #instantbird
05:21:09 --> afiksof has joined #instantbird
05:21:51 <instant-buildbot> build #446 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/446
05:22:30 <-- nhnt11 has quit (Ping timeout: 121 seconds)
05:38:05 --> EionRobb has joined #instantbird
05:42:43 --> Bollebib has joined #instantbird
05:50:09 --> gerard-majax has joined #instantbird
05:53:22 <-- dustinm` has quit (*.net *.split)
05:53:22 <-- Bollebib has quit (*.net *.split)
05:53:22 <-- mikef has quit (*.net *.split)
05:53:22 <-- Fallen has quit (*.net *.split)
05:53:22 <-- gerard-majax has quit (*.net *.split)
05:53:45 --> gerard-majax has joined #instantbird
05:53:45 --> Fallen has joined #instantbird
05:53:45 --> Bollebib has joined #instantbird
05:53:45 --> mikef has joined #instantbird
05:53:45 --> dustinm` has joined #instantbird
06:00:18 <-- gerard-majax has quit (Ping timeout: 121 seconds)
06:02:30 --> myk has joined #instantbird
06:13:51 <-- BWMerlin has quit (Client exited)
06:14:10 --> BWMerlin has joined #instantbird
07:09:55 <-- myk has quit (Ping timeout: 121 seconds)
07:24:25 --> mikk_s has joined #instantbird
07:46:28 <freaktechnik> flo-retina: how would I then apply a filterset only to a certain URI scheme? I could only find the global ruleset/cloning stuff and nobody that was around then could tell me much more than that I should look at the content sink rulesets.
07:47:22 <flo-retina> you should create a derived ruleset, and then apply it to the current convbrowser binding
07:48:09 <freaktechnik> how would I get the convbrowser binding? Do I get that in the prplIConversation somewhere?
07:48:28 <flo-retina> certainly not :)
07:48:37 <freaktechnik> or do I have to search it in the browser windows? :S
07:48:47 <flo-retina> changing the markup you are allowed to display is a UI thing. prpl should not access that kind of stuff
07:49:26 <flo-retina> (sorry I can't find the relevant pieces of code as quickly as I thought I would; I haven't used this in years)
07:50:20 <freaktechnik> well, if I'm going to mess with the conversation binding I might as well start messing with the user color algorithm :S
07:50:41 <freaktechnik> (since that's another property that doesn't get respected)
07:51:18 <flo-retina> ok, there's a bug in convbrowser.xml right now
07:51:41 <flo-retina> what's the problem with colors?
07:51:50 <flo-retina> or do you have a prpl that specifies custom colors for each nick?
07:51:54 <freaktechnik> yep
07:52:41 <flo-retina> so at http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#350 there's a _textModifiers field
07:52:56 <flo-retina> next to it we should have a _filteringRules field, that should be null by default.
07:52:58 <freaktechnik> oh nice, "private" properties :)
07:53:07 <flo-retina> and in this call: http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#534
07:53:19 <flo-retina> the 'null' should actually be this._filteringRules
07:53:22 <freaktechnik> oh, there's addTextModifiers.
07:53:44 <flo-retina> this way, an add-on could override the rules for the conversation without needing to override the whole 'displayMessages' method.
07:54:19 <flo-retina> well, one could add a setFilteringRules method, but that's just sugar above it.
07:55:59 <freaktechnik> I guess adding a textModifier would also work, since smileTextNodes inserts imgs too.
07:56:21 <flo-retina> that's probably how mic did it at the time, yes.
07:56:37 <freaktechnik> and those then don't get filtered.
07:56:46 <freaktechnik> But yeah, that makes it hard to only run for one prpl, for example.
07:57:00 <flo-retina> so the point of filtering is to sanitize data that's coming from the network
07:57:06 <freaktechnik> I know
07:57:09 <flo-retina> text modifiers are local, they don't need filtering.
07:57:56 <freaktechnik> but they don't know anything about the message context anymore. Well, you could do some DOM magic to find out I guess, but that's major acrobatics, IMO
07:57:57 <flo-retina> of course if you just escape the image tags on the prpl side and then unescape them with a text modifier, that's going to get an r- ;)
08:02:44 <freaktechnik> well, the solution then is to escape everything, insert the img tags and don't filter at all ;)
08:03:16 <freaktechnik> oh, wait, that's how it's supposed to work, just that the prpl has nothing to say in it.
08:25:57 --> gerard-majax has joined #instantbird
08:33:35 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:39:21 --> gerard-majax has joined #instantbird
08:44:07 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:53:20 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
09:00:08 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:03:50 --> nhnt11 has joined #instantbird
09:03:51 * ChanServ sets mode +h nhnt11 
09:06:15 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:27:23 --> aleth has joined #instantbird
09:27:24 * ChanServ sets mode +o aleth 
09:33:54 <-- Alex2 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
09:37:29 --> flo-retina has joined #instantbird
09:37:30 * ChanServ sets mode +qo flo-retina flo-retina 
09:46:31 <-- nhnt11 has quit (Ping timeout: 121 seconds)
09:57:38 --> gerard-majax has joined #instantbird
10:23:45 <-- EionRobb has quit (Quit: Leaving.)
10:30:09 --> freaktechnik_ has joined #instantbird
10:30:21 * freaktechnik_ is now known as freaktechnik1 
10:30:39 <-- freaktechnik has quit (NickServ (RECOVER command used by freaktechnik1))
10:30:39 * freaktechnik1 is now known as freaktechnik 
10:36:04 --> mpmc has joined #instantbird
10:36:15 <-- aleth has quit (Quit: :tiuQ)
10:36:22 --> aleth has joined #instantbird
10:36:23 * ChanServ sets mode +o aleth 
10:53:53 --> nhnt11 has joined #instantbird
10:53:54 * ChanServ sets mode +h nhnt11 
10:54:09 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:54:15 --> nhnt11 has joined #instantbird
10:54:16 * ChanServ sets mode +h nhnt11 
11:06:25 --> clokep has joined #instantbird
11:06:25 * ChanServ sets mode +o clokep 
11:09:52 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:10:05 --> clokep has joined #instantbird
11:10:05 * ChanServ sets mode +o clokep 
11:24:08 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:24:12 --> nhnt11 has joined #instantbird
11:24:12 * ChanServ sets mode +h nhnt11 
11:24:52 <clokep> freaktechnik, Mook, Mook_as: I'd be pretty thriller if you got inline images working. :)
11:25:12 <freaktechnik> well, they work, but very, very hacked together.
11:25:25 <freaktechnik> as in, not safe at all.
11:25:42 <freaktechnik> (but I guess there are worse things than tracking pixels ;) )
11:26:16 <aleth> I guess there'll always be a tradeoff if you allow images from all origins
11:27:23 <freaktechnik> as long as the onload attribute isn't allowed I don't see many issues that wouldn't affect firefox too...
11:27:41 <freaktechnik> (as in in-image exploits)
11:27:48 <clokep> freaktechnik: There are some differences though.
11:27:58 <clokep> freaktechnik: In an IM client it's easy to directly target an individual.
11:28:07 <clokep> The security scope isn't identical.
11:28:21 <freaktechnik> but the problem is, on some networks you don't want <img> in the text to get rendered, while you want some explicit images to be images.
11:28:33 <clokep> True!
11:28:34 <aleth> You could add a new entry to the Preferences->Content->Formatting dropdown
11:28:41 <clokep> To be clear what you and Mook want is a bit different than Mic's example.
11:28:49 <freaktechnik> yes and no
11:28:54 <clokep> You're handling <img> tags that are in the content, that was about taking a random link to an image and rendering.
11:29:01 <freaktechnik> I still don't want <img> in plaintext to be rendered as an image node.
11:29:16 <clokep> What defines plaintext is that sentence? :-D
11:29:20 <clokep> It's all just bytes on the wire at some point.
11:29:26 <freaktechnik> message content you get from the server
11:29:52 <freaktechnik> images are explicitly replaced over certain parts of the messages as specified by the server.
11:29:58 <aleth> freaktechnik: are you thinking about some specific prpl that has ways to embed images?
11:30:27 <freaktechnik> no, that has custom emoticon rules and infrastrucutre, but well, essentially its a image embedding system.
11:30:36 <clokep> Right, so they're trusted.
11:30:52 <freaktechnik> the problem is, that text that comes from the server alone isn't trusted.
11:31:22 <freaktechnik> so I'd have to pre-escape any existing <img> tags in my prpl.
11:32:05 <freaktechnik> (though I could probably generically replace < and > with &gt; and &lt;, since there is no HTML content at all)
11:33:52 <freaktechnik> (which is probably what one'd have to do with .containsImages either way)
11:51:18 <-- nhnt11 has quit (Ping timeout: 121 seconds)
11:59:53 --> bogdan_maris has joined #instantbird
12:06:29 --> nhnt11 has joined #instantbird
12:06:29 * ChanServ sets mode +h nhnt11 
12:11:12 <flo-retina> isn't there images embedded in tweets?
12:11:23 <clokep> Sometimes.
12:31:02 <-- clokep has quit (Ping timeout: 121 seconds)
13:08:34 <-- nhnt11 has quit (Ping timeout: 121 seconds)
13:09:50 --> clokep_work has joined #instantbird
13:09:50 * ChanServ sets mode +o clokep_work 
13:10:19 --> qheaden has joined #instantbird
13:11:09 <qheaden> Hi all!
13:19:02 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:36:34 --> nhnt11 has joined #instantbird
13:36:35 * ChanServ sets mode +h nhnt11 
13:45:28 <clokep_work> qheaden: Welcome!
13:47:40 <qheaden> clokep_work: I had a question about bug 1000469
13:47:42 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1000469 maj, --, ---, nobody, NEW, Yahoo doesn't normalize anything
13:47:49 <qheaden> It has been a while, and I need a refresher on that one.
13:47:54 <clokep_work> qheaden: I might or might not have an answer. :-D
13:48:08 <qheaden> For usernames, we basically normalize by making the username all lowercase right?
13:48:38 <clokep_work> qheaden: I'm not 100% sure how Yahoo works, but I *think* that's what you do, yes.
13:49:00 <qheaden> clokep_work: Also, I forgot if the JS protocols have a method defined in the interface for normalization.
13:49:22 * qheaden just sees aleth's message. :P
13:49:54 <qheaden> When and where is normalize called internally?
13:51:18 <clokep_work> qheaden: There's a couple of normalize methods, but mostly it's the Maps that are used.
13:52:34 <qheaden> Okay.
13:52:40 <clokep_work> So you do nicks = Map(), nicks.set("QHEADEN", <nick obj>); nicks.get("qheaden")
13:52:44 <clokep_work> That won't work. :-D
13:53:21 <-- afiksof has quit (Ping timeout: 121 seconds)
13:53:27 <qheaden> Right, okay.
13:54:31 <clokep_work> aleth: can exaplin the other normalization stuff.
13:57:32 --> flo-retina has joined #instantbird
13:57:33 * ChanServ sets mode +qo flo-retina flo-retina 
13:58:26 <qheaden> NormalizedMap seems to be the best thing to use.
13:59:37 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:59:41 <aleth> qheaden: basically normalize() is used to compare against the various normalizedNames, which are supposed to be unique identifiers
13:59:45 <aleth> oops
13:59:47 --> qheaden has joined #instantbird
13:59:54 <aleth> qheaden: basically normalize() is used to compare against the various normalizedNames, which are supposed to be unique identifiers
14:00:06 <aleth> https://dxr.mozilla.org/comm-central/source/chat/components/public/imIAccount.idl#129
14:00:33 <aleth> What exactly normalize() does should depend on what Yahoo considers "the same name"
14:00:52 <qheaden> Ah okay.
14:01:59 <aleth> So if e.g. buddy names were case sensitive, then a normalize = toLowerCase would break things
14:20:45 <-- nhnt11 has quit (Ping timeout: 121 seconds)
14:29:39 --> afiksof has joined #instantbird
14:35:46 <clokep_work> qheaden: Does that all make sense?
14:35:49 <clokep_work> Sorry for disappearing, work...
14:36:31 <qheaden> clokep_work: Yep. Makes perfect sense now! Thanks to you and aleth.
14:36:55 <qheaden> I'll continue working on that bug after I get off work. ;)
14:37:09 <clokep_work> :-D
14:37:11 <clokep_work> Awesome.
14:54:04 <-- afiksof has quit (Connection closed)
15:10:18 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:27:38 --> myk has joined #instantbird
15:31:26 <-- Tobin has quit (Connection closed)
15:31:42 --> Tobin has joined #instantbird
16:04:18 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:29:41 --> mconley|livehacking has joined #instantbird
16:35:31 --> gerard-majax has joined #instantbird
16:47:08 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:55:56 --> gerard-majax has joined #instantbird
17:01:32 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:08:09 --> gerard-majax has joined #instantbird
17:12:48 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:13:29 <-- Tonnes has quit (Connection closed)
17:14:29 --> gerard-majax has joined #instantbird
17:18:30 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:23:34 --> myk1 has joined #instantbird
17:23:34 <-- myk has quit (Connection closed)
17:23:35 * myk1 is now known as myk 
17:24:48 --> gerard-majax has joined #instantbird
17:34:14 <freaktechnik> so clokep_work suggested I should load irc.js as subscript to create a prpl base on irc. Problem is, that this also registers the handlers again, which then aren't properly unregistered when the extension is unloaded/uninstalled.
17:37:42 <freaktechnik> I guess the double registration would "only" eat some RAM and cause no other harm?
17:37:54 --> Tonnes has joined #instantbird
17:37:58 <freaktechnik> (until the extension is unloaded and the handlers don't exist anymore)
17:48:42 <Mook_as> Re: the image discussion: Yeah, I don't want any <img>s in the incoming text to display.  I only want images if they come from the special attachment data side-loaded in the XMPP stanza (outside the <body>).
18:00:38 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:02:57 <clokep_work> freaktechnik: "register the handlers again"...we should probably ensure a single handler is only added once.
18:03:07 <clokep_work> Mook_as: Cool! :)
18:04:08 <freaktechnik> (I also realized that the IRC conversation already sanitizes all the incoming text, so I don't have to do that myself, i.e. all the html in the messages is willingly in there)
18:06:39 <Mook_as> clokep_work: I don't have it working yet... :p
18:07:25 <Mook_as> And the closest seems to be playing with text filters, and that's... ugly :(
18:08:01 <freaktechnik> yeah, I can't think of a nice solution for prpls with how the security model works.
18:08:40 <freaktechnik> if it's protocol independent it's a lot easier...
18:09:41 <Mook_as> Yeah. And since I need to support not-image attachments too, ideally I'd be able to just attach a url, possibly with a thumbnail, and possibly with a mime type, and let the UI handle it for me
18:17:30 <clokep_work> freaktechnik, Mook_as: OK...so what needs to be done to make it possible?
18:17:36 <clokep_work> What about the security model doesn't work?
18:18:06 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:18:21 --> afiksof has joined #instantbird
18:20:13 <freaktechnik> Well, for starters it's currently impossible to add a protocol specific rule - which partially makes sense, and to some degree doesn't. Secondly you have to be very careful with escaping on your side if you allow a tag, but don't want possible tags coming directly from user messages to be rendered. (As in, <img> shouldn't be rendered, whereas your inserted ones are rendered). I realize that cleaning is already a thing that's
18:20:52 --> gerard-majax has joined #instantbird
18:21:08 <freaktechnik> happening, but it's - except for links way less bothersome if a tag got through (in fact, for example in XMPP, I think most of the tags come from the server, right?)
18:22:01 <clokep_work> freaktechnik: OK, let me rephrase my question.
18:22:06 <clokep_work> How would you *want* it to look?
18:22:19 <freaktechnik> I'm not sure, that's why I said I couldn't think of a nice solution
18:23:05 * clokep_work wonders if flo-retina has an idea.
18:29:19 <freaktechnik> I'd guess I'd already be happy if there was a more legit way of embedding images in the messages from a prpl than what I currently do (allow images in the global content rules). Though I am talking non-attached images, so in-content. So I guess the containsImages flag would fit for me, from an API standpoint. But I have no idea how you would implement that in the current situation of things.
18:31:50 <Mook_as> For HipChat, the way I'd want things to look: Some messages may have special formatting (in the UI, I don't care about how it gets there yet) that indicates it's an attachment.  Some attachments are images, and have an inline thumbnail.  All attachments have links; image ones might open in the same UI, instead of triggering a download?
18:32:53 <clokep_work> Mook_as, freaktechnik: So do you need a way to not escape HTML and say that that HTML is "safe"?
18:33:37 <freaktechnik> clokep_work: well, not escaping html is easy. You just don't escape it in the displayMessage. The hard part is saying "I know all the HTML in my message is safe, because I only have html that I inserted."
18:34:30 <freaktechnik> (Which is actually half a lie, because some of it gets inserted by the formatter thing that makes stuff bold and all that)
18:34:49 <freaktechnik> (but I might get rid of that, since the network I'm writing the prpl for doesn't do that stuff)
18:35:47 <Mook_as> clokep_work: _maybe_. I think for my purposes it'd be better if the UI had special support for the things I care about instead, so the style can actually match the rest of the message theme.
18:36:16 <clokep_work> Huh I see...
18:36:21 <Mook_as> Attachments in bubbles should not look like attachments in Simple.
18:36:40 <clokep_work> So you almost want their to be an extra field on the prplIMessage saying "ATTACH THIS STUFF"
18:36:45 <Mook_as> Yeah
18:36:45 <clokep_work> And the UI handles how to display that?
18:36:59 <clokep_work> That wouldn't work for inline things, of course.
18:38:18 <Mook_as> Of course. But I'm not trying to have inline things; freaktechnik sounds like he is :p
18:38:53 <freaktechnik> well, I have inline things. Trouble is, it also enables <img> tags in all the protocols.
18:38:58 <freaktechnik> which doesn't sound like a good idea.
18:39:24 <Mook_as> Right. I don't have inline things, just attachments.
18:50:10 <-- mconley|livehacking has quit (Quit: NO CARRIER)
19:00:47 --> nhnt11 has joined #instantbird
19:00:47 * ChanServ sets mode +h nhnt11 
19:01:56 * clokep_work is unsure.
19:07:33 --> Mnyromyr has joined #instantbird
19:20:52 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:22:44 <-- Mnyromyr has quit (Ping timeout: 121 seconds)
19:24:04 --> Mnyromyr has joined #instantbird
19:48:14 --> EionRobb has joined #instantbird
19:49:23 --> gerard-majax has joined #instantbird
20:26:55 <-- afiksof has quit (Connection closed)
21:00:14 <-- gerard-majax has quit (Ping timeout: 121 seconds)
21:06:36 <-- qheaden has quit (A TLS packet with unexpected length was received.)
21:48:09 <-- Bollebib has quit (Ping timeout: 121 seconds)
21:50:03 <-- clokep_work has quit (Ping timeout: 121 seconds)
21:56:00 --> myk1 has joined #instantbird
21:56:54 <-- myk has quit (Connection closed)
21:56:54 * myk1 is now known as myk 
22:03:17 --> myk1 has joined #instantbird
22:03:38 <-- myk has quit (Connection closed)
22:03:38 * myk1 is now known as myk 
22:09:37 --> myk1 has joined #instantbird
22:09:37 <-- myk has quit (Connection closed)
22:09:38 * myk1 is now known as myk 
22:13:39 <-- myk has quit (Ping timeout: 121 seconds)
22:23:07 <-- Mnyromyr has quit (Connection closed)
23:07:12 --> Bollebib has joined #instantbird
23:08:13 --> abdelrhman has joined #instantbird
23:12:17 --> myk has joined #instantbird
23:15:28 <freaktechnik> hmm, I guess the IRC handlers get registered per IRC network :O
23:15:58 <freaktechnik> oh wait, no
23:16:03 <freaktechnik> I'm tired.
23:22:04 <instantbot> New Chat Core - XMPP bug 1210226 filed by a.ahmed1026@gmail.com.
23:22:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1210226 nor, --, ---, nobody, NEW, Handle nicknames that contain spaces for msg and kick commands in XMPP
23:22:49 <-- aleth has quit (Quit: :tiuQ)
23:28:22 <-- myk has quit (Ping timeout: 121 seconds)
23:45:04 <abdelrhman> flo-retina: Does FB provides name attribute in responding to roster query?