All times are UTC.
00:03:38 <abdelrhman> Actually, messages are went out in HTML format with limited info. with each message that will be used (e.g. message time) 00:09:34 --> Alex has joined #instantbird 00:29:33 <clokep_work> Mook_as: We also cannot delete messages. Likely open bugs on both of those. 00:34:25 <-- clokep_work has quit (Ping timeout: 121 seconds) 00:53:43 <-- abdelrhman has quit (Ping timeout: 121 seconds) 00:59:04 <-- aleth has quit (Ping timeout: 121 seconds) 01:47:38 <-- afiksof has quit (Connection closed) 02:19:28 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:02:28 <instant-buildbot> build #1528 of linux-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1528 03:21:56 <instant-buildbot> build #2910 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2910 03:39:07 --> mpmc has joined #instantbird 04:23:44 --> nhnt12 has joined #instantbird 04:23:44 * ChanServ sets mode +h nhnt12 04:25:16 <-- nhnt12 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:26:03 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:35:35 <Mook> Bah, why can't https://dxr.mozilla.org/comm-central/rev/8b519841303fa74b7154b393d4a60dc40794a7d5/chat/components/public/imIAccount.idl#124 pass in an optional prplIRoomInfo if it already has one. 04:35:51 <Mook> Though I guess it's only useful if it's also passed through https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#1088 ... 04:36:33 <Mook> I'll guess I'll take the hit and spend an API request. (There's a rate limit on those.) 05:17:23 --> afiksof has joined #instantbird 05:26:56 --> bogdan_maris has joined #instantbird 05:39:17 <-- EionRobb1 has quit (Connection closed) 05:59:28 <-- unghost has quit (A TLS packet with unexpected length was received.) 06:03:20 --> myk has joined #instantbird 06:21:30 <-- myk has quit (Ping timeout: 121 seconds) 06:22:32 <instant-buildbot> build #438 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/438 06:25:05 <-- bogdan_maris has quit (Ping timeout: 121 seconds) 06:25:50 --> EionRobb has joined #instantbird 06:32:21 --> myk has joined #instantbird 06:34:27 <-- EionRobb has quit (Connection closed) 06:34:46 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 06:35:02 --> EionRobb has joined #instantbird 06:54:08 <-- myk has quit (Ping timeout: 121 seconds) 07:14:58 --> bogdan_maris has joined #instantbird 07:46:17 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:58:12 --> Bollebib has joined #instantbird 07:59:09 <flo-retina> I've received the memory for the minis! \o/ 08:01:10 --> gerard-majax has joined #instantbird 08:06:13 <-- Tonnes has quit (Connection closed) 08:09:58 --> Tonnes has joined #instantbird 08:24:56 --> bogdan_maris1 has joined #instantbird 08:25:43 <-- bogdan_maris1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:34:23 --> bogdan_maris1 has joined #instantbird 08:44:38 --> aleth has joined #instantbird 08:44:38 * ChanServ sets mode +o aleth 09:06:14 <-- EionRobb has quit (Connection closed) 09:07:06 --> EionRobb has joined #instantbird 09:16:18 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:25:15 --> nhnt11 has joined #instantbird 09:25:15 * ChanServ sets mode +h nhnt11 09:45:21 --> flo-retina has joined #instantbird 09:45:21 * ChanServ sets mode +qo flo-retina flo-retina 09:54:56 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:55:40 --> afiksof has joined #instantbird 10:07:36 <-- Alex has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 10:16:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:17:00 --> flo-retina has joined #instantbird 10:17:00 * ChanServ sets mode +qo flo-retina flo-retina 10:30:18 --> mpmc has joined #instantbird 10:30:19 --> freaktechnik_ has joined #instantbird 10:32:17 <-- freaktechnik has quit (Ping timeout: 121 seconds) 10:32:18 * freaktechnik_ is now known as freaktechnik 10:34:20 <-- EionRobb has quit (Quit: Leaving.) 10:49:51 <-- flo-retina has quit (Ping timeout: 121 seconds) 10:55:46 --> flo-retina has joined #instantbird 10:55:47 * ChanServ sets mode +qo flo-retina flo-retina 11:06:43 --> clokep has joined #instantbird 11:06:43 * ChanServ sets mode +o clokep 11:25:48 <-- flo-retina has quit (Ping timeout: 121 seconds) 11:27:49 --> flo-retina has joined #instantbird 11:27:49 * ChanServ sets mode +qo flo-retina flo-retina 11:34:45 <-- flo-retina has quit (Ping timeout: 121 seconds) 11:35:40 --> flo-retina has joined #instantbird 11:35:40 * ChanServ sets mode +qo flo-retina flo-retina 11:40:14 <-- afiksof has quit (Connection closed) 11:45:59 <-- mpmc has quit (Ping timeout: 121 seconds) 11:49:01 <-- flo-retina has quit (Ping timeout: 121 seconds) 11:50:14 --> flo-retina has joined #instantbird 11:50:14 * ChanServ sets mode +qo flo-retina flo-retina 11:50:55 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:56:33 --> mpmc has joined #instantbird 11:57:35 --> afiksof has joined #instantbird 11:57:44 <-- flo-retina has quit (Ping timeout: 121 seconds) 12:28:15 <-- dustinm` has quit (Ping timeout: 121 seconds) 12:43:32 --> abdelrhman has joined #instantbird 12:49:45 --> clokep_work has joined #instantbird 12:49:45 * ChanServ sets mode +o clokep_work 12:57:46 <abdelrhman> aleth: In invite command, if user left the muc, why should we return false? as we return true for other commands in this check 13:00:35 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:02:05 --> flo-retina has joined #instantbird 13:02:05 * ChanServ sets mode +qo flo-retina flo-retina 13:07:11 --> dustinm` has joined #instantbird 13:09:54 <-- bogdan_maris1 has quit (Ping timeout: 121 seconds) 13:20:14 <-- spiffytech has quit (Ping timeout: 121 seconds) 13:27:25 --> spiffytech has joined #instantbird 13:28:50 <aleth> abdelrhman: You can return true if you add a system message to tell the user the invite wasn't sent. But it's not good to provide no feedback at all when the command failed. Return false isn't great but at least it's clear then it didn't work. 13:33:15 <abdelrhman> OK, so we will need a common message for all commands tell that a command failed (e.g. command is not executed as you left the room) 13:34:00 <abdelrhman> returning false may make user suspect that he/she does not provide correct parameters 13:49:10 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:50:52 --> flo-retina has joined #instantbird 13:50:52 * ChanServ sets mode +qo flo-retina flo-retina 13:56:55 <-- flo-retina has quit (Ping timeout: 121 seconds) 14:13:16 <-- dustinm` has quit (Ping timeout: 121 seconds) 14:16:04 <-- afiksof has quit (Ping timeout: 121 seconds) 14:23:58 --> dustinm` has joined #instantbird 14:39:13 <clokep_work> Hm... Mac failed w/ runxpcshelltests.py: error: unrecognized arguments: --tests-root-dir=/Users/buildbot/buildslave/macosx/build/obj-instantbird/i386/_tests/xpcshell 14:42:59 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 14:43:08 --> chrisccoulson has joined #instantbird 14:43:14 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:43:20 --> clokep_work has joined #instantbird 14:43:20 * ChanServ sets mode +o clokep_work 14:51:52 --> flo-retina has joined #instantbird 14:51:52 * ChanServ sets mode +qo flo-retina flo-retina 15:17:13 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:17:17 --> flo-retina has joined #instantbird 15:17:17 * ChanServ sets mode +qo flo-retina flo-retina 15:50:12 <clokep_work> nhnt11: You'll probably be happy to know that your awesometab is unicode compliant http://puu.sh/kkieB/d4f732fb76.png 16:03:11 <-- flo-retina has quit (Ping timeout: 121 seconds) 16:08:58 --> myk has joined #instantbird 16:20:52 --> flo-retina has joined #instantbird 16:20:52 * ChanServ sets mode +qo flo-retina flo-retina 16:35:30 <abdelrhman> aleth: I have some modifications to patches that pushed for nick, kick commands. can I put them in patch of invite and me commands? 16:43:53 <aleth> Yes, if the same change appears for invite/me 16:45:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:47:53 <abdelrhman> I also noticed the nick command splits the new nick and this does not follow the spec as the new nick can contain spaces 16:48:47 <abdelrhman> I wanted to include this fix in invite/me 16:50:57 --> arlolra has joined #instantbird 16:51:57 <aleth> Might be better to separate that one out (it's not related to invite/me) 16:52:05 <abdelrhman> OK 16:53:23 <abdelrhman> clokep_work: Do you allow spaces for IRC nicks? 16:54:10 <clokep_work> abdelrhman: Spaces are not legal in IRC nicks. 16:54:14 <clokep_work> According to the RFC. 16:54:19 <clokep_work> (And just...the protocol and general :)) 16:54:37 <abdelrhman> OK, you are lucky ;) 16:54:56 <-- myk has quit (Ping timeout: 121 seconds) 16:55:18 <abdelrhman> Now, I realized why XMPP is complicated! 16:55:28 --> myk has joined #instantbird 16:55:33 <clokep_work> abdelrhman: :-D 16:55:38 <clokep_work> Yeah XMPP is a bit more complicated. 16:56:53 <abdelrhman> Spaces are allowed in nicknames of MUC or resources, because this will cause problem with kick, ban and all commands take nickname as a parameter 16:57:43 <aleth> abdelrhman: I actually thought of that when reviewing the patches, but couldn't come up with a good solution 16:58:07 --> mikk_s has joined #instantbird 16:59:02 <abdelrhman> we would use regex to overcome that 17:00:12 <clokep_work> It's just trying to parse malformed aata. 17:00:14 <clokep_work> Tough thing to fix. 17:00:16 <aleth> How do you distinguish between the second word of a nick with a space, and the first word of the second parameter? 17:00:22 <clokep_work> We should likely have 'real' UI for some of this stuff. 17:00:46 <aleth> It would be fairly straightforward to add kick, ban, etc to the participant context menu 17:01:18 <clokep_work> I think I filed a bug on that. 17:03:01 <abdelrhman> Or we can use startsWith method, but we need to iterate over participants array 17:04:46 <aleth> abdelrhman: Oh, that's a good idea actually, if the command can only be used on people in the room (not the case for IRC) 17:10:26 <abdelrhman> currently, we could do that only for msg and kick commands. as ban command needs a jid 17:12:42 <clokep_work> aleth: Yeah that's a stupid design decision on that command. ;) 17:12:45 <clokep_work> (That we didn't make) 17:20:00 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:26:24 <abdelrhman> I want to check the complexity of string.prototype.startswith. I suspect if it's O(N) 17:31:39 <clokep_work> Likely! 17:37:41 <-- Tonnes has quit (Quit: ChatZilla 0.9.92 [Firefox 40.0.3/20150826023504]) 17:38:34 <nhnt11> clokep_work: :D 17:43:40 --> flo-retina has joined #instantbird 17:43:40 * ChanServ sets mode +qo flo-retina flo-retina 17:46:47 --> unghost has joined #instantbird 17:51:51 --> Tonnes has joined #instantbird 17:53:18 <-- Bollebib has quit (Ping timeout: 121 seconds) 17:53:43 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 18:04:38 --> gerard-majax has joined #instantbird 18:34:09 <-- myk has quit (Ping timeout: 121 seconds) 18:55:44 --> Mnyromyr has joined #instantbird 18:57:07 <abdelrhman> aleth: I check parameters to avoid log messages about accessing index in array does not exist 18:57:53 <abdelrhman> I do trim to avoid while spaces in each element (e.g. jid@domain test message) 18:58:29 <abdelrhman> there are two spaces between jid and the message, so I do trim for the second space 19:03:55 --> mpmc has joined #instantbird 19:04:17 <clokep_work> aleth: Do I have anythign to say in TB's meeting? 19:06:06 --> myk has joined #instantbird 19:08:43 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:09:27 <clokep_work> (or flo-retina for that matter) 19:09:34 <clokep_work> (Or anyone else who wants to comment :P) 19:09:50 <abdelrhman> :D 19:12:42 <-- Mnyromyr has quit (Ping timeout: 121 seconds) 19:14:13 --> Mnyromyr has joined #instantbird 19:17:28 <-- arlolra has quit (Client exited) 19:43:36 --> aleth1 has joined #instantbird 19:43:36 * ChanServ sets mode +o aleth1 19:43:50 <-- aleth has quit (Ping timeout: 121 seconds) 19:43:50 * aleth1 is now known as aleth 20:31:43 <aleth> abdelrhman: e.g. |ban(...params)| shouldn't give any warnings 20:40:08 <abdelrhman> aleth: If you do not provide the second parameter, it would generate this warning in the console (http://pastebin.instantbird.com/2000736) 20:40:28 <aleth> That's why I suggested using the spread operator ;) 20:42:15 <abdelrhman> OK 21:01:40 --> EionRobb has joined #instantbird 21:03:53 --> Bollebib has joined #instantbird 21:21:58 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:28:43 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.92 [SeaMonkey 2.35/20150825182814]) 21:30:24 <-- myk has quit (Ping timeout: 121 seconds) 21:39:08 <-- abdelrhman has quit (Ping timeout: 121 seconds) 21:58:03 --> myk has joined #instantbird 22:08:39 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 22:08:45 --> chrisccoulson has joined #instantbird 22:13:28 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 22:13:30 --> chrisccoulson has joined #instantbird 22:33:24 --> clokep has joined #instantbird 22:33:24 * ChanServ sets mode +o clokep 22:48:55 <clokep> bug 1206238 22:48:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1206238 nor, --, ---, nobody, NEW, Improve XMPP handleErrors function to display error system messages more easily 22:49:05 <clokep> instantbot is getting slow 22:49:07 <instantbot> clokep: Sorry, I've no idea what 'is getting slow' might be. 22:49:14 <clokep> instantbot: shhh 22:49:17 <instantbot> clokep: Sorry, I've no idea what 'shhh' might be. 22:49:18 <instantbot> clokep: no 22:49:58 <clokep> aleth: I'd *really* like to see us enforce some testing around the XMPP code. 22:52:43 <aleth> clokep: imho the way to go is xml-parsing tests -> stanza handling tests 22:54:41 <aleth> I filed a bug for it. 22:58:31 <aleth> (the latter would include a test for error handling callbacks) 22:59:27 <-- Bollebib has quit (Connection closed) 23:03:34 <aleth> clokep: "This is a terrible, terrible hack to work around the fact that ClassInfo.implementationLanguage has gone" ? ;) 23:03:50 <clokep> aleth: Sure. ;) 23:06:10 <clokep> I think we're on 44 now? 23:06:18 <clokep> Was there another merge? 23:10:09 <clokep> flo-retina: AH-HA! 23:10:34 <clokep> I changed |UPLOAD_CMD='echo $(UPLOAD_FILES) echo $(INSTALLER_PACKAGE)'| 23:10:53 <clokep> And $(INSTALLER_PACKAGE) seems correct, so I suspect breakage in our app-rules.mk. 23:11:22 <flo-retina> ah :) 23:12:08 <clokep> Now I need to figure out that insane make statement. 23:17:04 <clokep> Actually, maybe it's not right. 23:17:21 <clokep> instantbird-1.6a1pre.en-US.win32.zip dist/instantbird-1.6a1pre.en-US.win32.installer.exe 23:17:25 <clokep> One has the dist/ one doesn't. 23:18:01 <flo-retina> ah, that could explain it I guess :) 23:20:00 <clokep> Yeah one is getting dist/dist 23:20:33 <aleth> I think you've found the problem :-) 23:22:54 <clokep> Now I need to find the minimum amount of changes to 'fix' it. 23:22:59 <clokep> And hope it works? 23:30:50 <clokep> aleth: I suspect you'd like me to r?flo-retina on that patch? 23:31:11 <aleth> Windows build stuff? definitely 23:31:48 <clokep> Bah, where's Mook? :P 23:31:50 <flo-retina> clokep: that review shouldn't take too long 23:31:59 <flo-retina> (although I'm going to bed nowish) 23:32:13 <clokep> flo-retina: The Windows builder is offline. 23:32:17 <clokep> So no reason you should bother tonight. 23:32:23 <flo-retina> ok 23:34:14 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 23:37:09 <aleth> why do I hate looking at mozreview diffs if mozreview diffs are supposed to be a big improvement :-S 23:37:39 <aleth> I guess it's the extra clutter 23:39:59 <clokep> aleth: What you looking at? 23:40:24 <aleth> the OSX failure 23:40:52 <clokep> Ahhhhh. 23:40:55 <aleth> was looking at https://bugzilla.mozilla.org/show_bug.cgi?id=1206073 23:40:58 <instantbot> Bug 1206073 blo, --, mozilla43, ahalberstadt, RESO FIXED, Can't run various tests due to importing of resource://testing-common/... failing 23:41:23 <aleth> Looks unrelated. 23:42:01 <aleth> Ah, it's bug 1193224 23:42:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1193224 nor, --, mozilla43, nobody, RESO FIXED, Remove --tests-root-dir option 23:42:53 <clokep> :) 23:42:56 <clokep> Thanks for looking at it. 23:42:59 <clokep> Is that Instantbird only? 23:44:11 <clokep> I think this just started running *all* tests. 23:44:14 <clokep> That ain't good. 23:47:01 <aleth> The simple fix is likely to use mach 23:47:41 * clokep feels like he accomplished something. 23:48:06 <aleth> clokep: yup, that's one blocker less :-) 23:49:30 <clokep> :) 23:49:48 <clokep> Hopefully flo thinks it's OK. 23:50:11 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:50:19 --> clokep has joined #instantbird 23:50:19 * ChanServ sets mode +o clokep