#instantbird log on 08 10 2015

All times are UTC.

00:49:53 <-- Bollebib has quit (Connection closed)
01:23:52 --> EionRobb1 has joined #instantbird
01:26:01 <-- EionRobb has quit (Ping timeout: 121 seconds)
01:51:49 --> myk has joined #instantbird
02:04:07 <-- myk has quit (Ping timeout: 121 seconds)
02:11:55 <instant-buildbot> build #1489 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1489
04:15:19 <instant-buildbot> build #2829 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2829
05:39:33 --> myk has joined #instantbird
06:11:12 <-- EionRobb1 has quit (Quit: Leaving.)
06:18:04 <-- myk has quit (Ping timeout: 121 seconds)
06:32:19 <instant-buildbot> build #403 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/403
07:26:36 <-- gerard-majax has quit (Ping timeout: 121 seconds)
07:33:04 --> EionRobb has joined #instantbird
07:43:58 * MattATobin is now known as AnjohlTennan 
08:01:25 --> Bollebib has joined #instantbird
08:12:42 --> gerard-majax has joined #instantbird
08:33:36 --> nhnt11 has joined #instantbird
08:33:36 * ChanServ sets mode +h nhnt11 
08:36:58 --> chrisccoulson has joined #instantbird
08:44:24 --> aleth has joined #instantbird
08:44:24 * ChanServ sets mode +o aleth 
08:56:40 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:29:33 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:37:33 --> gerard-majax has joined #instantbird
09:45:23 --> flo-retina has joined #instantbird
09:45:23 * ChanServ sets mode +qo flo-retina flo-retina 
09:52:34 <-- aleth has quit (Ping timeout: 121 seconds)
10:09:15 <-- Alex has quit (Connection closed)
10:57:07 --> clokep has joined #instantbird
10:57:07 * ChanServ sets mode +o clokep 
11:00:50 --> aleth has joined #instantbird
11:00:50 * ChanServ sets mode +o aleth 
11:01:29 <-- aleth has quit (Connection closed)
11:01:30 --> aleth has joined #instantbird
11:01:30 * ChanServ sets mode +o aleth 
11:07:50 <-- afiksof has quit (Ping timeout: 121 seconds)
11:10:15 --> afiksof has joined #instantbird
11:18:52 --> abdelrhman has joined #instantbird
11:28:50 <-- abdelrhman has quit (Ping timeout: 121 seconds)
11:30:20 --> abdelrhman has joined #instantbird
11:48:33 <clokep> So I think we could have Windows nightlies with the patch I put up.
11:48:38 <clokep> + Even turning on the Windows builder. ;)
11:49:00 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
11:49:19 --> chrisccoulson has joined #instantbird
11:54:34 <abdelrhman> aleth: in getting x elements, can I use one filter instead of filtering getChildrenByNS result?
11:55:34 <aleth> I don't understand the question
11:56:19 <abdelrhman> the implementation of getChildrenByNS uses filter, and I want to filter with NS and localname of elements
11:56:56 <abdelrhman> I mean using on filter instead of calling aStanza.getChildrenByNS(...).filter(...)
11:57:10 <abdelrhman> * one filter
11:57:27 <aleth> "using one filter" you mean something like aStanza.children.filter(...)
11:57:34 <abdelrhman> yes
11:57:40 <aleth> Sure, why not
11:57:50 <abdelrhman> OK
11:57:53 --> chrisccoulson_ has joined #instantbird
11:58:24 <-- chrisccoulson has quit (Ping timeout: 121 seconds)
12:12:25 <-- afiksof has quit (Ping timeout: 121 seconds)
12:16:36 <abdelrhman> aleth: for username property, it can be assigned from the information that may be provided when a participant joins a room
12:16:54 <abdelrhman> check XEP-0045 example 123
12:17:06 <aleth> Yes, I know. But not at that point in the code.
12:17:33 <aleth> Check out what happens when in your code ;)
12:18:38 <abdelrhman> In the callback of querying vcard temp
12:22:13 <aleth> In parseVCard, it's impossible for it to be set
12:22:52 <aleth> You're adding stuff to an empty object.
12:23:14 <abdelrhman> Ah, sorry for that!
12:30:52 <aleth> clokep: thanks for fixing up Windows :-)
12:34:10 <clokep> aleth: Don't thank me yet.
12:35:05 --> afiksof has joined #instantbird
12:37:17 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:41:51 <clokep> flo-retina: Thank you!
12:43:57 <-- aleth has quit (Ping timeout: 121 seconds)
12:47:53 <-- clokep has quit (Ping timeout: 121 seconds)
12:54:03 --> aleth has joined #instantbird
12:54:03 * ChanServ sets mode +o aleth 
13:19:49 --> clokep_work has joined #instantbird
13:19:49 * ChanServ sets mode +o clokep_work 
13:30:49 --> aleth1 has joined #instantbird
13:30:49 * ChanServ sets mode +o aleth1 
13:34:20 <-- aleth has quit (Ping timeout: 121 seconds)
13:34:30 --> aleth has joined #instantbird
13:34:30 * ChanServ sets mode +o aleth 
13:34:52 <-- aleth1 has quit (Ping timeout: 121 seconds)
13:55:43 --> afiksof1 has joined #instantbird
13:57:38 <-- afiksof has quit (Ping timeout: 121 seconds)
14:01:46 <-- afiksof1 has quit (Ping timeout: 121 seconds)
14:14:12 <clokep_work> aleth, abdelrhman: Do either of you know if tip of m-c/c-c builds right now?
14:14:18 <clokep_work> (If not, can you give me a rev that does.)
14:16:57 <-- aleth has quit (Ping timeout: 121 seconds)
14:17:10 --> aleth has joined #instantbird
14:17:10 * ChanServ sets mode +o aleth 
14:17:50 <-- aleth has quit (Connection closed)
14:17:52 --> aleth has joined #instantbird
14:17:52 * ChanServ sets mode +o aleth 
14:24:28 * clokep_work wonders if aleth saw that last message. ;)
14:25:01 <aleth> no
14:25:14 <aleth> idk, but I'd say it builds as it built last night
14:25:27 <clokep_work> Hm...might need to clobber.
14:28:20 --> flo-retina has joined #instantbird
14:28:21 * ChanServ sets mode +qo flo-retina flo-retina 
14:35:51 <abdelrhman> clokep_work: what is the meaning of "tip of"? I'm sorry for misunderstanding that!
14:36:04 <clokep_work> abdelrhman: "tip" is the newest revision in Mercurial.
14:38:04 <abdelrhman> Ah
14:40:50 <abdelrhman> clokep_work: I'll try to pull and build. it may take 45 min.
14:40:56 <clokep_work> abdelrhman: No need.
14:40:59 <clokep_work> I'm doing one now.
14:41:03 <abdelrhman> OK
14:41:03 <clokep_work> And it only takes 20 minutes. ;)
14:41:17 <clokep_work> But thank you. :)
14:44:55 --> mpmc has joined #instantbird
14:46:17 <-- aleth has quit (Quit: :tiuQ)
14:47:10 --> aleth has joined #instantbird
14:47:10 * ChanServ sets mode +o aleth 
14:57:46 <-- aleth has quit (Ping timeout: 121 seconds)
15:00:58 --> aleth has joined #instantbird
15:00:58 * ChanServ sets mode +o aleth 
15:25:32 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1189247 from --- to FIXED.
15:25:33 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1189247 cri, --, ---, clokep, RESO FIXED, Windows bustage from bug 964828 in libgg
15:27:44 <clokep_work> flo-retina: Is there a way to clear pending requests from a buildbot builder?
15:27:57 * clokep_work suspects we don't want to do 13 builds on the windows builder at once. :-D
15:28:10 <flo-retina> yes, but the windows slave won't do 12 builds
15:28:47 <flo-retina> for some (mostly unknown?) reason, whenever a nightly finishes, all the builds that were pending (I guess those that were queued before the job started) get cleared
15:29:08 <clokep_work> Ah, buildbot. :)
15:29:20 <clokep_work> I wonder if I should kill the build that's going and start a new one or let that one fail.
15:29:36 <flo-retina> if you request a build now, I think (but won't promise it) that it'll start a new build once it's done with the current job
15:29:45 <flo-retina> why will it fail?
15:30:04 <flo-retina> did it start before you pushed that fix?
15:30:06 <clokep_work> Yes.
15:30:10 <clokep_work> It started when Even rebooted the machine.
15:30:18 <flo-retina> hmm
15:30:26 <flo-retina> I would let this build finish
15:30:38 <flo-retina> my experience of killing windows jobs has never been satisfying with buildbot
15:31:06 <clokep_work> Fair enough.
15:37:55 <-- abdelrhman has quit (Quit: Leaving)
15:47:13 --> afiksof has joined #instantbird
15:51:49 <-- gerard-majax has quit (Ping timeout: 121 seconds)
15:55:02 --> Mnyromyr has joined #instantbird
15:55:40 <-- afiksof has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
15:56:09 --> afiksof has joined #instantbird
15:56:32 --> nhnt11 has joined #instantbird
15:56:32 * ChanServ sets mode +h nhnt11 
15:58:40 <-- afiksof has quit (Connection closed)
15:58:42 --> afiksof has joined #instantbird
16:02:07 --> EionRobb1 has joined #instantbird
16:03:22 <nhnt11> aleth: I'm afraid I'm too tired to answer that needinfo tonight :(
16:03:29 * nhnt11 will try to give you an answer tomorrow
16:04:29 <-- EionRobb has quit (Ping timeout: 121 seconds)
16:13:40 <aleth> nhnt11: it's not urgent at all
16:14:26 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:17:00 --> gerard-majax has joined #instantbird
16:22:44 <instant-buildbot> build #1736 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1736
16:22:58 <clokep_work> BOOM.
16:23:18 <clokep_work> New build started.
16:31:29 <-- EionRobb1 has quit (Quit: Leaving.)
16:32:50 <-- chrisccoulson_ has quit (Ping timeout: 121 seconds)
16:36:31 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:37:15 * clokep_work debated about forking libgadu to instantbird instead of clokep
16:40:46 --> gerard-majax has joined #instantbird
16:43:37 --> arlolra has joined #instantbird
16:52:45 <clokep_work> Meh...it'd be nice if XMPP had join/part messages.
17:04:43 <aleth> clokep_work: Is that a review ping?
17:05:02 * aleth knows he has something xmpp to review
17:05:12 <clokep_work> aleth: A complaint. :-D
17:08:18 --> Mook_as has joined #instantbird
17:09:32 <flo-retina> is the devel Pidgin MUC usable btw? All I have in that log is "12:52:29 - Could not join the room devel@conference.pidgin.im as the server the room is hosted on could not be reached."
17:09:57 <clokep_work> flo-retina: Is it from a gmail account?
17:10:03 <clokep_work> I had to use a jabber.org account.
17:10:10 <flo-retina> yes
17:11:01 <aleth> flo-retina: you can't reach it as google doesn't do syndication
17:11:04 <clokep_work> I'm unsure if that works from gmail anymore.
17:11:21 <aleth> more precisely, it only does it insecurely, and many servers reject that
17:11:57 <aleth> don't use gtalk for XMPP ;)
17:14:16 <clokep_work> Damn, I never looked at bug 1192629. :-\
17:14:19 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1192629 nor, --, ---, thomas, NEW, [yosemite][Instantbird] Simplified Chinese shows up in Traditional Chinese mode when saving an image
17:14:52 * flo-retina looked today and decided he was happy for you to review it :-P
17:15:19 <flo-retina> seriously, I had enough unread bugmail this morning that I wondered for a moment if I had taken a couple days off before the week-end or something
17:38:07 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:50:26 --> mconley_ has joined #instantbird
17:55:32 <clokep_work> Meh I'm unsure I *know* how to review that.
17:55:34 <-- aleth has quit (Ping timeout: 121 seconds)
18:11:23 --> Defman has joined #instantbird
18:11:30 <Defman> sup guys
18:11:48 <Defman> does instantbird support automatic identify?
18:12:07 <clokep_work> What protocol are we talking about?
18:12:11 <Defman> irc
18:12:15 <clokep_work> (And what does that mean? ::P)
18:12:29 <clokep_work> It should automatically identify you to e.g. NickServ via SASL.
18:12:32 <clokep_work> Or a few other commands.
18:12:40 <clokep_work> Are you having problems on a network?
18:12:47 <Defman> I'm not
18:12:49 <Defman> just asking
18:12:58 <Defman> what is SASL?
18:13:30 <clokep_work> A way to exchange username / password during the initial protocol negotiation.
18:14:26 <Defman> I set username and password for my account, will that identify me during the initial protocol negotiation?
18:14:41 <clokep_work> It should, yes.
18:14:54 <clokep_work> Assuming by "set username and password" you mean you went through the normal account registration.
18:17:22 <clokep_work> (I mean the account wizard in Instantbird.)
18:17:30 <clokep_work> It should "just work" on most networks.
18:17:50 <Defman> yep I did
18:22:57 <Defman> okay, thank you clokep_work :)
18:24:40 <clokep_work> You're welcome.
18:24:45 <clokep_work> Any way we could have made this more obvious?
18:26:13 <-- afiksof has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
18:26:31 --> afiksof has joined #instantbird
18:29:22 --> gerard-majax has joined #instantbird
18:31:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:32:11 <Defman> I'm not sure
18:32:22 <Defman> or...
18:33:24 <Defman> you guys could add a simple label on Account Settings page contains "If you're registered in NickServ, you can enter your password for automatic identify"
18:33:32 <Defman> or something like that in proper English :P
18:50:39 <instant-buildbot> build #1737 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1737
18:54:17 <clokep_work> \o/
18:54:18 <clokep_work> BOOM!
18:54:31 <clokep_work> Defman: Yeah, maybe...what part was confusing? Were yo unsure what the password is for?
18:54:38 <clokep_work> It's tough cause that same wizard is used in all protocols.
18:55:11 <Defman> I just didn't know that Mozilla has this feature in their servers 
18:55:44 <Defman> and I thought that password is something that Instantbird will ask when I would want to connect to the server via my account
18:55:51 <Defman> like a secure thing
18:56:46 <clokep_work> It will prompt you on most protocols, but not IRC.
18:57:58 <Defman> no, u don't understand me
18:58:23 <clokep_work> OK, please describe what you mean then.
18:58:28 <clokep_work> Do you mean like a master password?
18:58:31 <Defman> yeah
18:58:34 <Defman> something like that
18:58:36 <clokep_work> Like something that won't let it connect without you typing it in.
18:58:41 <Defman> yep!
19:08:42 <clokep_work> Yeah that'd be the master password.
19:24:15 <flo-retina> clokep_work: congrats on the Windows build! :)
19:27:24 <clokep_work> flo-retina: Thank you. :)
19:27:27 * clokep_work is excited to install it.
19:27:38 <flo-retina> I hope it won't crash at startup :)
19:27:51 <flo-retina> (that used to happen after libpurple updates ;))
19:29:26 --> aleth has joined #instantbird
19:29:26 * ChanServ sets mode +o aleth 
19:30:08 <-- aleth has quit (Connection closed)
19:30:10 --> aleth has joined #instantbird
19:30:10 * ChanServ sets mode +o aleth 
19:33:19 <clokep_work> :-D
19:33:27 <clokep_work> I ran my custom build briefly yesterday.
19:33:32 <flo-retina> :)
19:39:43 <clokep_work> mconley_: I can't say that not having nightly builds for 3 months is a 'favorite' thing of mine. ;)
19:40:57 <mconley_> heh
19:41:00 <mconley_> just glad to see it working
19:43:01 <clokep_work> It was painful. :-\
19:43:12 * clokep_work needs to figure out why they're not uploading now. :(
19:43:17 <clokep_work> I'd like to do that tomorrow night.
19:49:42 --> chrisccoulson has joined #instantbird
19:53:33 <clokep_work> flo-retina: Are the buildbot scripts available somewhere?
19:53:41 <clokep_work> I might need to look at those to figure that part out.
19:53:53 <flo-retina> not that I'm aware of
19:54:00 <flo-retina> they should definitely be versionned :(
19:54:22 <flo-retina> and no, you don't need access to the buildbot scripts to figure out why something is not working
19:54:37 <flo-retina> each buildbot log contains the exact command that was launched, and a whole dump of the environment variables
19:54:46 <clokep_work> Alright.
19:54:48 <flo-retina> you may need access to the buildbot config to _fix_ it though
19:55:05 <clokep_work> Those are the same thing to me. ;)
19:58:24 --> myk has joined #instantbird
19:59:12 <flo-retina> clokep_work: are you volunteering to be the new buildbot maintainer?
19:59:18 <clokep_work> No.
19:59:26 <clokep_work> I just want buildbot to upload windows nightlies.
19:59:46 <flo-retina> http://hg.canardbox.com/ looks like it's not useful
20:00:11 <flo-retina> wait, weren't you saying a few minutes ago that you were installing a nightly?
20:00:43 <flo-retina> ah, it uploaded only the mar files :-D
20:02:19 <-- myk has quit (Connection closed)
20:02:19 --> myk has joined #instantbird
20:02:45 <clokep_work> Yes.
20:02:59 <clokep_work> And I am not installing a new update on a Mac. :P
20:04:13 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 954015 from --- to WONTFIX.
20:04:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954015 nor, --, ---, nobody, RESO WONTFIX, QQ - Hangs when trying to get Captcha from server
20:04:28 <flo-retina> so, the variable with the list of files to upload is UPLOAD_FILES
20:04:33 <flo-retina> the installer seems to be added at http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/upload-files.mk#782
20:04:37 <clokep_work> Bug 1161333 is what I'm talking about.
20:04:39 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1161333 nor, --, ---, nobody, NEW, Windows installer is not being updated in nightlies
20:04:52 <flo-retina> err, no http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/mozapps/installer/upload-files.mk#699
20:05:41 <flo-retina> we are emptying PKG_INST_PATH in a bunch of places, eg http://mxr.mozilla.org/comm-central/source/im/installer/windows/Makefile.in#7
20:05:43 <freaktechnik> tab close button is now borken on win 10 in the new nightly.
20:05:51 <clokep_work> Sweet. :-D
20:05:54 <flo-retina> http://mxr.mozilla.org/comm-central/source/im/locales/Makefile.in#62
20:06:02 <clokep_work> freaktechnik: Can you file a bug?
20:06:11 <flo-retina> and http://mxr.mozilla.org/comm-central/source/im/build.mk#80
20:06:11 <freaktechnik> well, clicking it still works, it just looks wrong.
20:06:15 <clokep_work> Oh.
20:06:33 <flo-retina> clokep_work: the first thing I would try is to add PKG_INST_PATH= at the end of this line: http://mxr.mozilla.org/comm-central/source/im/build.mk#104
20:06:37 <freaktechnik> I had to disable vertical tabs, and now it's just the image that seems off...
20:06:44 <flo-retina> clokep_work: no idea why that would now be needed
20:06:49 <flo-retina> but it seems like it should be a reasonable fix
20:07:04 <clokep_work> freaktechnik: That guy who maintains vertical tabs is a huge jerk so...good luck getting him to fix it. ;)
20:07:23 <freaktechnik> clokep_work: well, I'm using a nightly, so it's my fault...
20:07:30 <flo-retina> it's also not entirely impossible that the reason (which I don't remember) why we needed that variable to be empty no longer exists and that we could be fine with the default installer path used by other mozilla applications
20:07:34 <clokep_work> I haven't touched that code in a long.
20:07:46 <clokep_work> flo-retina: That would be convenient. :)
20:08:27 <flo-retina> I almost suspect the reason was for the sake of simplicity when we had our own custom uploader code, before that code moved to toolkit
20:10:07 <freaktechnik> so should I open a bug for this? http://i.imgur.com/vxQSBq8.png
20:11:31 <flo-retina> yes please
20:11:42 <freaktechnik> Instantbird :: Conversation?
20:13:16 <clokep_work> Psh, looks OK to me. ;)
20:13:19 <clokep_work> freaktechnik: Yes, that's fine.
20:13:32 <clokep_work> I don't thinkw e have a theme component.
20:13:43 <freaktechnik> well, if it wouldn't mirror it to the right side on hover it'd be fine, but this way it's super jumpy...
20:18:33 <clokep_work> Ah are you on a hidpi display?
20:19:31 <clokep_work> aleth: Sounds like that XMPP auth code needs tests. :P
20:19:42 --> nhnt11 has joined #instantbird
20:19:42 * ChanServ sets mode +h nhnt11 
20:19:44 <aleth> All of XMPP needs tests :P
20:20:10 <-- afiksof has left #instantbird ()
20:20:39 <aleth> clokep_work: Actually, in this case it's servers ignoring the spec, strictly speaking...
20:20:49 <clokep_work> I'll need to think about it more.
20:20:52 <instantbot> New Instantbird - Conversation bug 1192999 filed by martin@humanoids.be.
20:20:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1192999 nor, --, ---, nobody, UNCO, Close Tab Icon mispositioned
20:20:55 <clokep_work> Too dsitracted
20:21:24 <freaktechnik> clokep_work: nope.
20:22:12 <freaktechnik> (the screenshot is full resolution...)
20:22:37 --> afiksof has joined #instantbird
20:23:20 <clokep_work> Thanks. :)
20:23:27 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:25:26 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:25:41 --> nhnt11 has joined #instantbird
20:25:41 * ChanServ sets mode +h nhnt11 
20:26:02 --> afiksof has joined #instantbird
20:28:59 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:29:03 --> nhnt11 has joined #instantbird
20:29:03 * ChanServ sets mode +h nhnt11 
20:29:27 <-- nhnt11 has quit (Connection closed)
20:29:29 --> nhnt11 has joined #instantbird
20:29:29 * ChanServ sets mode +h nhnt11 
20:35:44 <-- nhnt11 has quit (Ping timeout: 121 seconds)
20:39:31 * aleth wonders if IB needs the equivalent of paenglab's big aero-removing patch series to fix the win10 stuff
20:40:03 <-- chrisccoulson has quit (Connection closed)
20:41:11 --> EionRobb has joined #instantbird
20:41:13 <freaktechnik> I won't deny that the border radiuses don't look too good with the white window decorations. And the border on the side is kind of weird too
20:42:50 <aleth> Porting Australis would probably fix this stuff for free...
20:43:07 <aleth> well, not free, as it would be forked :-/
20:45:30 <freaktechnik> oh, close button thing in the im groups has the same issue.
20:45:48 <freaktechnik> (I just never use that...)
20:46:57 <aleth> freaktechnik: I don't suppose firefox or thunderbird have the same problem?
20:47:28 <freaktechnik> I don't have nightlies of those, since I don't have the save whitelisted certs issue there ;)
20:47:35 <aleth> uh oh, there was a merge today?
20:48:23 <aleth> already?
20:48:53 <flo-retina> uh, does that mean I haven't replied to that needinfo about the version number soon enough?
20:49:04 <instantbot> aleth@instantbird.org changed the Resolution on bug 1171691 from --- to FIXED.
20:49:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1171691 nor, --, Instantbird 43, a.ahmed1026, RESO FIXED, Improve the participant tooltips for XMPP
20:49:40 <aleth> It also means a lot of what lands from now we'll likely have to uplift...
20:51:38 <flo-retina> :(
20:51:49 <flo-retina> I need to fix whatever crap is needed to do aurora/beta builds :(
20:53:22 <-- afiksof has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:56:00 <clokep_work> I assume we can land on beta for im/ with our own approval.
20:56:35 <flo-retina> we never asked that
20:56:44 <flo-retina> but I don't see why anybody would complain
20:56:55 <flo-retina> maybe we should not even bother asking, and just take it for granded
20:56:57 <flo-retina> *granted
20:57:06 <flo-retina> but chat/ is where it gets more complicated I guess
20:57:12 <clokep_work> Yep.
20:57:19 <clokep_work> I vote don't ask.
20:57:24 <clokep_work> And assume the three of us can do approvals.
20:57:26 <clokep_work> Bam, policy set.
20:58:03 <flo-retina> I dislike that policy.
20:58:07 <flo-retina> for aurora that makes sense
20:58:26 <flo-retina> for beta, I think we should have one specific person responsible of each release, and coordinating what we take or don't take
20:58:49 <flo-retina> (and we should probably rotate who that person is, to not have too much of a burden on a specific person)
20:59:17 <flo-retina> all of that assumes we can produce aurora/beta builds of course...
21:01:49 <clokep_work> flo-retina: I more of meant for aurora right at this moment.
21:02:10 <flo-retina> clokep_work: ok. You said 'beta' explicitly though :)
21:02:18 <clokep_work> Sorry. :-\
21:02:24 <clokep_work> I forgot about aurora.
21:05:34 <freaktechnik> so yep, the close button thing is related to the theme changes in tb :)
21:06:20 <aleth> I don't think chat/ uplifts will be a problem as long as we don't uplift all the way to esr, which we won't
21:09:18 <flo-retina> aleth: I don't think it would be a problem, but we may still need to request permission for it
21:10:11 <-- clokep_work has quit (Ping timeout: 121 seconds)
21:29:47 <-- Defman has left #instantbird ()
21:36:21 --> clokep has joined #instantbird
21:36:21 * ChanServ sets mode +o clokep 
21:36:28 <-- mconley_ has quit (Connection closed)
21:39:11 <-- clokep has quit (Connection closed)
21:39:20 --> clokep has joined #instantbird
21:39:20 * ChanServ sets mode +o clokep 
21:40:02 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:40:18 --> clokep has joined #instantbird
21:40:18 * ChanServ sets mode +o clokep 
21:41:45 * clokep is on a new nightly. :-D
21:44:28 <clokep> Ah random people fixing IB things. :-D
21:55:03 <-- Mnyromyr has quit (Quit: ChatZilla [SeaMonkey 2.33.1/20150321194827])
21:59:53 <clokep> aleth: So that encrypted thing.
22:00:00 <clokep> What's the new behavior?
22:00:21 <aleth> Only pick PLAIN if you really have to.
22:01:19 --> myk1 has joined #instantbird
22:01:20 <aleth> With the current code, if the server offers [PLAIN, MD5] we'll pick PLAIN
22:01:22 <-- myk has quit (Connection closed)
22:01:22 * myk1 is now known as myk 
22:01:53 <aleth> Of course, the server should follow spec and offer [MD5, PLAIN], but you know servers...
22:02:01 <clokep> :-\
22:04:17 <clokep> I'm not really following that change, unfortunately.
22:04:26 <clokep> It seems like it should only use PLAIN if it's the only option before and after.
22:05:47 <aleth> only if _encrypted==false
22:08:45 <aleth> otherwise the loop breaks.
22:09:09 <clokep> I can't process this code right now. :(
22:09:17 <clokep> Is it me or is it confusing?
22:09:48 <aleth> It was confusing, I thought after the change and with the extra comment, it was ok ;)
22:10:47 <flo-retina> which patch is that?
22:11:57 <aleth> https://bugzilla.mozilla.org/show_bug.cgi?id=1163541#c6
22:11:59 <instantbot> Bug 1163541 nor, --, ---, nobody, NEW, JS XMPP debug logs shouldn't contain the user's password
22:12:09 <clokep> 90% of it is simple.
22:12:15 <clokep> I don't like hiding other changes in bugs like this FWIW.
22:12:29 <flo-retina> clokep: I think you just said why you'll r- ;)
22:12:46 <aleth> I didn't think it was complicated, or I would have filed it separately
22:13:02 <aleth> But sure, we can split it out if you like
22:13:17 <flo-retina> the question isn't "is it complicated"
22:13:26 <flo-retina> but could it cause regression that we would want to track separately
22:13:47 <flo-retina> a change of which auth method we use shouldn't be in something titled "blah blah debug log blah"
22:15:37 <clokep> (I also suspect we shouldn't change that right before release. :))
22:15:53 <clokep> Although it shouldn't even be used in IB.
22:16:13 <flo-retina> aleth: why does it matter to not use plain, if the socket is encrypted?
22:16:30 <flo-retina> the only case I can think of is if the user has accepted a crappy self signed cert
22:17:10 <aleth> flo-retina: It doesn't matter much one way or the other, that's why I didn't think it was a big deal ;)
22:17:36 <flo-retina> alright, I'll pretend I haven't seen, and let clokep review then ;)
22:17:50 <aleth> You've convinced me to not be lazy and split it out though
22:17:52 <clokep> I'll pretend flo-retina gave you an r- and not review it. ;)
22:18:06 <clokep> (I think we just made a loop. :-D)
22:18:29 <flo-retina> clokep: you just demonstrated why patches with 2 review requests for "whoever gets to it first" never get reviewed quickly ;)
22:18:34 * clokep kind f likes the new close button in the tabbar on Mac btw...
22:18:42 <clokep> kind of
22:19:45 --> freaktechnik_ has joined #instantbird
22:21:14 <-- freaktechnik has quit (Ping timeout: 121 seconds)
22:21:14 * freaktechnik_ is now known as freaktechnik 
22:24:06 <clokep> The patch in bug 1192629 looks like a hack. :-\
22:24:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1192629 nor, --, ---, thomas, NEW, [yosemite][Instantbird] Simplified Chinese shows up in Traditional Chinese mode when saving an image
22:24:18 <clokep> But matches the Firefx patch...so I guess r+?
22:25:33 <instant-buildbot> build #1738 of win32-nightly-default is complete: Failure [4failed shell_6]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1738
22:28:20 <-- clokep has quit (Ping timeout: 121 seconds)
22:56:28 <-- EionRobb has quit (Ping timeout: 121 seconds)
22:57:02 --> EionRobb has joined #instantbird
22:58:47 --> aleth1 has joined #instantbird
22:58:47 * ChanServ sets mode +o aleth1 
23:01:48 <-- aleth has quit (Ping timeout: 121 seconds)
23:01:48 * aleth1 is now known as aleth 
23:07:28 --> EionRobb1 has joined #instantbird
23:09:19 <-- EionRobb has quit (Ping timeout: 121 seconds)
23:21:39 --> clokep_work has joined #instantbird
23:21:39 * ChanServ sets mode +o clokep_work 
23:44:35 <-- Bollebib has quit (Ping timeout: 121 seconds)
23:44:39 --> Bollebib has joined #instantbird