All times are UTC.
00:00:24 <arlolra> moz.build in the chat/libraries/dummy 00:00:27 <aleth> arlolra: you may need 00:00:51 <aleth> EXPORTS.libraryname += [ 00:00:51 <aleth> 'libraryname/file.h', ... ] 00:00:52 <arlolra> mach is the it 00:01:22 <arlolra> aleth: the headers are exported already in the libs 00:01:24 <clokep_fr> arlolra: Why is "chat/libraries/dummy" a thing? 00:01:27 <clokep_fr> What are you trying to do? 00:01:35 <clokep_fr> The tests should be done inside of the otr library moz.build. 00:01:39 <arlolra> so chat/libraries/otr/moz.build has that 00:01:52 --> BlueMaxima has joined #instantbird 00:02:33 <arlolra> i'm just trying to build this dummy client 00:02:34 <arlolra> https://github.com/off-the-record/libotr/tree/master/test_suite/otr_c_client 00:04:35 <arlolra> alright, i'll move it until /otr 00:04:44 <arlolra> gotta head out for a bit 00:04:48 <-- arlolra has quit (Client exited) 00:14:23 <clokep_fr> Doing it in otr seems simpler, yes. 00:14:28 <clokep_fr> OK. We're going to bed. 00:15:24 <aleth> nhnt11: The +1 is there because we don't want to scroll even for the last message 00:15:52 <nhnt11> aleth: ah, ok, so the log viewer wants to scroll at the end? 00:16:03 <nhnt11> I was going to ask why the log viewer /doesn't/ use the +1 00:17:26 <aleth> Hmm, no 00:18:56 <aleth> I didn't investigate exactly why count.value seems to do the job for the log viewer, it overrides other some things too 00:19:22 <aleth> I guess I could look at it again tomorrow if needed 00:23:01 <nhnt11> OK 00:25:25 <-- aleth has quit (Ping timeout: 121 seconds) 00:33:36 <-- clokep_fr has quit (Ping timeout: 121 seconds) 00:36:47 <-- myk has quit (Ping timeout: 121 seconds) 00:56:35 <-- freaktechnik has quit (Quit: Loosing power...) 01:02:16 --> freaktechnik has joined #instantbird 01:07:34 <-- Mook_as has quit (Client exited) 01:33:21 --> arlolra has joined #instantbird 01:36:50 <-- indolering has quit (Ping timeout: 121 seconds) 01:52:02 <-- freaktechnik has quit (Quit: Loosing power...) 01:52:20 --> freaktechnik has joined #instantbird 02:06:01 --> Tobin has joined #instantbird 02:12:06 <instant-buildbot> build #1470 of linux-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1470 02:12:10 <instant-buildbot> build #384 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/384 02:42:39 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:22:35 <-- arlolra has quit (Client exited) 03:44:31 <instant-buildbot> build #2784 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2784 03:59:14 --> indolering has joined #instantbird 04:37:42 <-- indolering has quit (Ping timeout: 121 seconds) 04:51:56 --> Bollebib has joined #instantbird 05:16:48 <-- EionRobb has quit (Quit: Leaving.) 05:20:46 --> indolering has joined #instantbird 05:50:58 <-- indolering has quit (Ping timeout: 121 seconds) 05:54:20 <-- Bollebib has quit (Ping timeout: 121 seconds) 06:36:05 <-- afiksof has quit (Ping timeout: 121 seconds) 06:46:49 --> EionRobb has joined #instantbird 07:28:22 --> clokep_work has joined #instantbird 07:28:22 * ChanServ sets mode +o clokep_work 07:34:03 * Fallen|away is now known as Fallen 07:45:53 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1179943 from --- to FIXED. 07:46:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1179943 nor, --, 1.6, aleth, RESO FIXED, Themes window positioned too high on OS X 07:46:34 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1186523 from --- to FIXED. 07:46:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186523 tri, --, 1.6, clokep, RESO FIXED, Normalize does not exist for UnknownProtocol 07:46:38 --> bogdan_maris has joined #instantbird 07:59:05 --> aleth has joined #instantbird 07:59:05 * ChanServ sets mode +o aleth 07:59:08 <-- aleth has quit (Connection closed) 07:59:09 --> aleth has joined #instantbird 07:59:10 * ChanServ sets mode +o aleth 08:00:24 <-- aleth has quit (Quit: :tiuQ) 08:00:31 --> aleth has joined #instantbird 08:00:31 * ChanServ sets mode +o aleth 08:00:31 <-- aleth has quit (Connection closed) 08:00:33 --> aleth has joined #instantbird 08:00:33 * ChanServ sets mode +o aleth 08:00:43 <-- aleth has quit (Quit: :tiuQ) 08:00:57 --> aleth has joined #instantbird 08:00:57 * ChanServ sets mode +o aleth 08:09:02 <-- aleth has quit (Ping timeout: 121 seconds) 08:11:17 --> aleth has joined #instantbird 08:11:18 * ChanServ sets mode +o aleth 08:11:18 <-- aleth has quit (Connection closed) 08:11:19 --> aleth has joined #instantbird 08:11:20 * ChanServ sets mode +o aleth 08:18:34 --> gerard-majax has joined #instantbird 08:30:11 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:30:17 --> clokep_work has joined #instantbird 08:30:17 * ChanServ sets mode +o clokep_work 08:36:20 <-- aleth has quit (Ping timeout: 121 seconds) 08:38:22 <-- clokep_work has quit (Ping timeout: 121 seconds) 08:43:22 --> clokep_work has joined #instantbird 08:43:23 * ChanServ sets mode +o clokep_work 08:43:23 <-- clokep_work has quit (Connection closed) 08:43:24 --> clokep_work has joined #instantbird 08:43:24 * ChanServ sets mode +o clokep_work 08:47:28 <-- clokep_work has quit (Ping timeout: 121 seconds) 08:48:56 --> clokep_work has joined #instantbird 08:48:56 * ChanServ sets mode +o clokep_work 08:48:57 <-- clokep_work has quit (Connection closed) 08:48:58 --> clokep_work has joined #instantbird 08:48:58 * ChanServ sets mode +o clokep_work 08:51:39 --> aleth has joined #instantbird 08:51:39 * ChanServ sets mode +o aleth 08:58:19 <-- aleth has quit (Quit: :tiuQ) 08:58:29 --> aleth has joined #instantbird 08:58:29 * ChanServ sets mode +o aleth 09:07:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:08:13 <-- bogdan_maris has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:08:17 --> bogdan_maris has joined #instantbird 09:11:55 <-- aleth has quit (Ping timeout: 121 seconds) 09:12:03 <-- clokep_work has quit (Ping timeout: 121 seconds) 09:30:27 --> abdelrhman has joined #instantbird 09:45:38 <instant-buildbot> build #2785 of macosx-nightly-default is complete: Failure [4failed shell_2] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2785 09:56:33 --> clokep_work has joined #instantbird 09:56:33 * ChanServ sets mode +o clokep_work 09:58:09 --> aleth has joined #instantbird 09:58:09 * ChanServ sets mode +o aleth 09:59:34 --> gerard-majax has joined #instantbird 10:05:14 <-- BlueMaxima has quit (Quit: Leaving) 10:16:26 <-- abdelrhman has quit (Quit: Leaving) 10:44:31 <flo-retina> warning: implicit declaration of function 'BUG' is invalid in C99 10:48:27 <flo-retina> gcrypt-shim.c:401:14: error: use of undeclared identifier 'false' 10:59:00 <flo-retina> http://pastebin.instantbird.com/180350 10:59:21 <flo-retina> http://pastebin.instantbird.com/1803504 11:05:55 <flo-retina> http://pastebin.instantbird.com/1803525 11:10:21 --> Bollebib has joined #instantbird 11:16:03 --> abdelrhman has joined #instantbird 11:49:36 <clokep_work> Hello abdelrhman. :) 11:51:20 <instantbot> New Instantbird - Account manager bug 1187281 filed by aleth@instantbird.org. 11:51:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187281 nor, --, ---, nobody, NEW, Only show "close" button on Windows 11:54:40 <abdelrhman> clokep_work: hello :-) 11:55:28 <clokep_work> abdelrhman: We filed a bunch of XMPP issues that we thought you might be interested in! 11:55:36 <clokep_work> We CC'd you to them. :) 11:55:57 <aleth> Also, some things landed now we are no longer busted. 11:57:52 <abdelrhman> OK, I'll work on them this week 12:01:29 <clokep_work> :) 12:05:58 <aleth> Well, you can pick your own bugs! 12:08:52 <abdelrhman> OK 12:09:41 <aleth> We just keep finding/filing more ;) 12:18:00 <-- abdelrhman has quit (Ping timeout: 121 seconds) 12:18:19 --> abdelrhman has joined #instantbird 12:21:30 <abdelrhman> XMPP has a lot of specs! 12:23:21 <clokep_work> It does! :-D 12:26:17 <instantbot> New Instantbird - Account manager bug 1187286 filed by florian@queze.net. 12:26:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187286 nor, --, ---, nobody, NEW, "No account configured yet!" message flashing for a split second 12:28:43 <-- abdelrhman has quit (Ping timeout: 121 seconds) 12:30:53 --> abdelrhman has joined #instantbird 12:34:34 --> Mnyromyr has joined #instantbird 12:35:41 <abdelrhman> I assigned some bugs to me from here (https://bugzilla.mozilla.org/buglist.cgi?component=XMPP&product=Chat%20Core&bug_status=__open__&list_id=12417461). did they you mean? 12:36:39 <flo-retina> you don't have to assign them all to yourself at once :) 12:37:12 <abdelrhman> sure not all, only I will work on 12:37:13 <flo-retina> usually we only assign bugs to ourselves once we have started working on them, so that if someone else is interested in fixing them before we start, they are not worried about 'stealing' them 12:37:36 <flo-retina> (I don't think you need to worry about ever running out of things to look at, right? :)) 12:38:09 <abdelrhman> yes :-) 12:38:37 <flo-retina> don't go unassigning yourself from half of them now though, I was just saying this for 'in the future...' :) 12:38:50 <abdelrhman> OK 12:39:02 <flo-retina> and thanks for all the excellent xmpp fixes! :) 12:39:18 <abdelrhman> :-) 12:39:34 <abdelrhman> I just wanted to make sure if these bugs that aleth and clokep_work were talking about ;) 12:40:12 <clokep_work> abdelrhman: Yes, those were the ones. ;) 12:40:26 <clokep_work> And yeah, just notifying you since you seem to enjoy the XMPP ones and I don't think you watch the component for new bugs! 12:40:52 <aleth> Looks like we're getting close to turning on JS-XMPP :-) 12:43:11 <clokep_work> Fallen: Whatever happened to that DNS-SRV patch? ;) 12:46:06 --> MattATobin has joined #instantbird 12:47:32 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 955738 from --- to FIXED. 12:47:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955738 nor, --, 1.6, clokep, RESO FIXED, Port 'Bug 733632 - Remove TLS version UI (Options > Advanced > Encryption > Protocols)' 12:47:59 <aleth> mikef: Any ideas about why the server disconnects us (cf bug 1186463) ? 12:48:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186463 nor, --, ---, aleth, UNCO, Thunderbird Chat and Slack XMPP gateway don't connect 12:48:03 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1186627 from --- to FIXED. 12:48:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186627 tri, --, 1.6, clokep, RESO FIXED, Update top protocols list for 1.6 12:49:02 <-- Tobin has quit (Ping timeout: 121 seconds) 12:52:04 <Fallen> clokep_work: it sits on my harddrive waiting for someone in this channel to ask about it again :-P 12:52:27 <clokep_work> Fallen: I'm willing to review it if we want it in tree. 12:52:43 <flo-retina> JavaScript error: resource:///modules/jsProtoHelper.jsm, line 296: TypeError: this._account.normalize is not a function 12:53:15 <flo-retina> JavaScript strict warning: file:///.../InstantbirdDebug.app/Contents/Resources/components/imContacts.js, line 972: ReferenceError: reference to undefined property "getScriptableHelper" 12:53:21 <Fallen> clokep_work: I think the best thing to do would be to push it with the first consumer of that script, otherwise it will sit around and rot. Does ib need it now? 12:53:36 <clokep_work> Fallen: We *could* use it. 12:53:42 <clokep_work> But we don't *need* it. 12:53:58 <clokep_work> So...I guess I'd be interested in playing with it? 12:53:59 <aleth> Fallen: We could slot it into JS-XMPP, which fails to connect to some servers currently due to the lack of DNSSRV 12:54:03 <clokep_work> And seeing if I can hook it up XMPP. 12:54:13 <Fallen> sounds good :) 12:59:06 <Fallen> clokep_work: https://pastebin.mozilla.org/8840536 13:06:51 <clokep_work> Thanks! 13:10:49 <-- EionRobb has quit (Quit: Leaving.) 13:14:48 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 955107 from --- to INCOMPLETE. 13:14:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955107 maj, --, ---, nobody, RESO INCOMPLETE, Couldn't look up SRV record. DNS name not found (9003) 13:17:11 <clokep_work> Random old bgs... 13:36:50 <-- aleth has quit (Ping timeout: 121 seconds) 13:44:26 --> afiksof has joined #instantbird 13:44:26 --> Tobin has joined #instantbird 13:48:02 <-- MattATobin has quit (Ping timeout: 121 seconds) 14:04:36 --> MattATobin has joined #instantbird 14:05:08 <-- Tobin has quit (Connection closed) 14:14:31 <-- MattATobin has quit (Connection closed) 14:15:30 --> BinaryOutcast has joined #instantbird 14:16:20 <-- bogdan_maris has quit (A TLS packet with unexpected length was received.) 14:19:32 <-- BinaryOutcast has quit (Ping timeout: 121 seconds) 14:21:11 --> BinaryOutcast has joined #instantbird 14:40:06 --> MattATobin has joined #instantbird 14:43:20 <-- BinaryOutcast has quit (Ping timeout: 121 seconds) 14:53:33 --> aleth has joined #instantbird 14:53:33 * ChanServ sets mode +o aleth 14:54:53 --> BinaryOutcast has joined #instantbird 14:56:41 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:56:46 --> flo-retina has joined #instantbird 14:56:46 * ChanServ sets mode +qo flo-retina flo-retina 14:58:21 <-- MattATobin has quit (Ping timeout: 121 seconds) 15:01:02 <abdelrhman> aleth: in xmpp tooltip, we will only query about vcard, Do I need to parse the whole response as it can be too much for the tooltip? 15:01:48 <abdelrhman> check (http://xmpp.org/extensions/xep-0054.html) 15:07:01 <abdelrhman> clokep_work: in bug 1176958, what do you mean by "combined"? 15:07:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1176958 nor, --, ---, a.ahmed1026, ASSI, participants list does not delete old nick when a participant changes it in XMPP MUC 15:12:15 <-- aleth has quit (Ping timeout: 121 seconds) 15:28:15 <-- BinaryOutcast has quit (Quit: Our job is to state the truth and let the facts attend to themselves.) 15:40:16 --> Tobin has joined #instantbird 15:40:18 <-- gerard-majax has quit (Ping timeout: 121 seconds) 15:44:02 <instant-buildbot> build #1728 of win32-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1728 15:50:01 --> arlolra has joined #instantbird 15:55:36 --> indolering has joined #instantbird 15:59:13 --> aleth has joined #instantbird 15:59:13 * ChanServ sets mode +o aleth 16:00:08 <clokep_work> abdelrhman: Does it need to exist separately for that protocol or is it part of all protocols? 16:00:12 <clokep_work> That's what my question means. 16:00:34 --> mpmc has joined #instantbird 16:00:54 <aleth> abdelrhman: It's OK if you pick what is reasonable for a tooltip! 16:03:28 <abdelrhman> clokep_work: ah, it can be for all and also there is a bug in xmpp for that bug 1172355 16:03:30 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172355 nor, --, ---, a.ahmed1026, NEW, Add system messages when someone joins or leaves a room 16:03:36 --> gerard-majax has joined #instantbird 16:10:32 --> myk has joined #instantbird 16:20:21 <-- aleth has quit (Ping timeout: 121 seconds) 16:26:15 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:29:42 --> aleth has joined #instantbird 16:29:42 * ChanServ sets mode +o aleth 16:30:14 --> gerard-majax has joined #instantbird 16:30:40 <clokep_work> arlolra: Good morning. 16:30:57 <clokep_work> arlolra: Did yyou see Florian's comments on the bug? 16:31:07 <aleth> abdelrhman: If you like, you could also add a /whois command that prints the complete info (as system messages) 16:31:08 <arlolra> mornin'. trying to catch up on all the work you did 16:31:14 <clokep_work> I think there's been a bit of a disconnect, we were not really sure how to compile it, etc. 16:31:25 <aleth> It didn't link for us this morning 16:34:01 <arlolra> aleth: yeah, same here 16:35:28 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:36:33 --> gerard-majax has joined #instantbird 16:39:11 <arlolra> clokep_work: right ... do you know why that might be? 16:39:41 <clokep_work> arlolra: No. Does the patch on the bug match *exactly* what you are using? 16:39:45 <clokep_work> What sort of errors are you getting? 16:41:29 <arlolra> diff says the only changes are assert(0) => assert(false) 16:41:41 <clokep_work> false doesn't exist in C. 16:41:52 <clokep_work> But OK. 16:41:53 <arlolra> FALSE 16:42:03 <clokep_work> And what are the errors? 16:42:12 <arlolra> there are no errors, mach builds it 16:42:48 <clokep_work> But it doesn't link, thus there are errors. 16:43:01 <clokep_work> What does the linker say? 16:43:04 <clokep_work> Why don't you pastebin it to me? 16:43:07 <arlolra> although, trying to use it in ctypes or for that dummy client says it can't find symbols 16:45:19 <clokep_work> arlolra: Can you |cd <your objdir>/chat/libraries/otr && make clean && make| and show us the output? 16:45:31 <arlolra> sure 16:46:07 <arlolra> λ hg log -l 1 16:46:07 <arlolra> changeset: 18120:f72b324f3cbc 16:46:07 <arlolra> tag: tip 16:46:07 <arlolra> user: Florian Quèze <florian@queze.net> 16:46:07 <arlolra> date: Fri Jul 24 13:08:39 2015 +0200 16:46:07 <arlolra> summary: Bug 1147369 - Add libotr to build system 16:46:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1147369 nor, --, ---, nobody, NEW, Add libotr to build system 16:50:04 <clokep_work> arlolra: Cool, that looks like the right changeset, let us know when you have the output of make 16:50:55 <arlolra> you want /otr or /gcrypt? 16:51:37 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:52:11 --> gerard-majax has joined #instantbird 16:52:18 <clokep_work> arlolra: otr, the command I gave you above should work. 16:53:52 <arlolra> https://gist.github.com/arlolra/abbe5c70fa7e434ed3d3 16:59:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:01:35 <clokep_work> Hm. That seems to imply it worked correctly... 17:02:04 <-- indolering has quit (Ping timeout: 121 seconds) 17:02:13 <clokep_work> Does |mach build chat/libraries/otr| have similar results or is that where you saw linking issues? 17:04:11 <arlolra> let me try 17:04:31 <clokep_work> Thanks! 17:05:03 <arlolra> λ ./mozilla/mach build chat/libraries/otr 17:05:03 <arlolra> 0:00.15 /usr/bin/make -C /Users/arlolra/Work/Tor/comm-central/obj-x86_64-apple-darwin14.4.0 -sj4 -j4 -s backend.RecursiveMakeBackend 17:05:03 <arlolra> 0:00.61 /usr/bin/make -C chat/libraries/otr -sj4 -j4 -s 17:05:03 <arlolra> 0:01.03 make[2]: Circular /Users/arlolra/Work/Tor/comm-central/mozilla/CLOBBER <- /Users/arlolra/Work/Tor/comm-central/mozilla/CLOBBER dependency dropped. 17:05:03 <arlolra> 0:01.53 /usr/bin/make -C im/app -sj4 -j4 -s 17:05:03 <arlolra> 0:02.45 make[2]: Circular /Users/arlolra/Work/Tor/comm-central/mozilla/CLOBBER <- /Users/arlolra/Work/Tor/comm-central/mozilla/CLOBBER dependency dropped. 17:05:03 <arlolra> 0:03.69 Your build was successful! 17:05:03 <arlolra> λ 17:05:03 <abdelrhman> aleth: we can let that for a follow up bug, as it needs more info. 17:05:18 <aleth> abdelrhman: sure 17:05:32 --> indolering has joined #instantbird 17:05:57 --> gerard-majax has joined #instantbird 17:06:32 <arlolra> clokep_work: the issues I saw were only when trying to use the dylib it produces. the complaint was not being able to find the otr_* symbols 17:06:56 <clokep_work> arlolra: Hm...OK, so can you give us steps to reproduce this issue? 17:07:05 <clokep_work> I know you were trying to compile a prgoram, but you didn't show us any of that. 17:07:11 <clokep_work> So it's *really* hard for us to comment on it at all. 17:09:00 <arlolra> what i did was added a dir called dummy 17:09:06 <arlolra> put this file in it 17:09:06 <arlolra> https://github.com/off-the-record/libotr/blob/master/test_suite/otr_c_client/dummy_client.c 17:09:24 <arlolra> put a moz.build file in as well 17:09:31 <arlolra> that depended on gcrypt and otr 17:09:34 <-- indolering has quit (Ping timeout: 121 seconds) 17:09:54 <arlolra> and added Program('...') 17:10:03 <clokep_work> arlolra: Give me a patch. 17:10:05 <arlolra> k 17:10:09 <clokep_work> I don't want to guess what you're doing. :) 17:10:25 <arlolra> one question for you first 17:10:32 <arlolra> or two 17:10:41 <arlolra> when you say, "it didn't link for you" 17:10:48 <arlolra> what were you seeing? 17:11:14 <arlolra> why couldn't you reproduce what mach does for me above? 17:11:25 <arlolra> also ... in /otr, you have a Makefile 17:11:31 <arlolra> where did that come from? 17:12:05 <clokep_work> Makefile or Makefile.in? 17:12:26 <clokep_work> arlolra: When I say "it didn't link for me" I mean the linker complained about missing symbols while trying to build the library. 17:13:37 <arlolra> which symbols 17:13:42 <arlolra> Makefile.in, yes 17:15:45 <clokep_work> arlolra: I likely made it at some point. 17:15:49 <clokep_work> It does not mean it's right. 17:16:15 <clokep_work> flo-retina has the actual log of a failing build. 17:16:15 <-- mpmc has quit (Ping timeout: 121 seconds) 17:19:25 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:23:40 <flo-retina> this is what a build (failure) log looks like for me: http://pastebin.instantbird.com/1803906 17:32:54 <clokep_work> arlolra: ^ 17:41:17 <instantbot> New Chat Core - IRC bug 1187398 filed by kush.varade.19@gmail.com. 17:41:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187398 nor, --, ---, nobody, UNCO, IRC: irc.mozilla,org websirte is not loading 17:47:29 <aleth> arlolra: Some quick questions for the UI: 17:47:34 <arlolra> clokep_work: https://gist.github.com/arlolra/605c34df34c58bf573ff 17:47:47 <aleth> What are the use cases for "end private conversation"? 17:48:33 <aleth> What's the rationale for not showing the unencrypted message when the following system message is printed: "We received an unencrypted message from <username>"? 17:48:55 <arlolra> clokep_work: also https://gist.github.com/arlolra/605c34df34c58bf573ff#gistcomment-1507341 17:48:57 <aleth> What if an OTR connect negotiation fails? Is there a timeout or...? 17:49:21 <aleth> arlolra: Those are just for clarification, you don't have to answer right now as you are busy 17:49:58 <arlolra> aleth: the rationale for not showing unencrypted ... is on pad https://etherpad.mozilla.org/otr-todo 17:50:17 <aleth> arlolra: Thanks! 17:50:59 <arlolra> aleth: if the negotiation fails, an error is displayed / sent to the contact 17:52:21 <arlolra> aleth: probably this one https://github.com/arlolra/ctypes-otr/blob/master/chrome/content/otr.js#L702-L704 17:52:51 <aleth> arlolra: So that also happens if e.g. the other side goes offline during the negotiation? 17:54:44 <arlolra> i'm not exactly sure ... there is a heartbeat https://github.com/arlolra/ctypes-otr/blob/master/chrome/content/otr.js#L720-L722 (but that may just be for rotating keys) 17:55:19 <arlolra> if the user goes offline, it'll be apparent why a negotiation hung 17:55:49 <arlolra> it's a state machine, so if they come back online and try again it'll handle that gracefully 17:57:43 <arlolra> aleth: one use case for "end private conversation" is in xmpp when you are having a conversation with a contact and they go offline, but then you want to send them a msg for when they come back 17:59:42 <aleth> arlolra: OK, so we're hoping that "end conversation" can be automated so it doesn't require user action. 17:59:50 <aleth> Seems that should be possible... 18:00:04 <arlolra> that's a bad idea 18:01:16 <clokep_work> arlolra: You need to expand. 18:01:19 <clokep_work> That's not enough information. 18:01:37 <arlolra> i'm trying to see if i've already explained this 18:01:43 <arlolra> maybe this one https://github.com/arlolra/ctypes-otr/issues/51#issuecomment-114990311 18:01:55 <arlolra> " the contact has to be made explicitly aware that we're switching back to sending in plaintext. Requiring the user action here is for their benefit." 18:04:33 <flo-retina> that doesn't make any sense 18:04:59 <flo-retina> the contact needs to know we are switching back to plain text 18:05:03 <flo-retina> so the UI should provide feedeback 18:05:10 <aleth> Let me see if I can disentangle this. If the user is in "require OTR" mode, then you would never send messages when not OTR-connected. If not, then the UI has to provide feedback. 18:05:18 <flo-retina> a system message makes sense in that case, so does changing the appearance of the button. 18:05:19 <clokep_work> arlolra: OK. I moved a lot of your code around, but I'm getting link errors for that file too. 18:05:26 <flo-retina> but a user-action that doesn't have any effect doesn't make sense. 18:06:02 --> Mook_as has joined #instantbird 18:06:20 --> nhnt11 has joined #instantbird 18:06:20 * ChanServ sets mode +h nhnt11 18:07:21 <arlolra> flo-retina: i think the idea is that it's easy to ignore system msgs and the little icon changing ... but making you remember that, oh ya, i need to end the otr session, is obvious 18:07:49 <flo-retina> where is that idea coming from? 18:08:07 <flo-retina> is it something you came up with? something you copied from the pidgin plugin? 18:08:59 <arlolra> the pidgin plugin that the author of the inventor wrote. not sure if that was from a user study or of his own creatoin 18:09:14 <arlolra> inventor of otr 18:09:19 <arlolra> so, no, not my idea 18:09:22 <flo-retina> ok 18:09:32 <aleth> arlolra: You're right that the UI has to be clear about it, but it doesn't seem like a good idea to force the user to jump through hoops 18:09:33 <flo-retina> so I hope he was good at crypto :). 18:10:03 <flo-retina> I'm not sure he was the best UX designer ever, so we should probably not hesitate to arrange the UI so that it fits. 18:10:04 <aleth> arlolra: If the user is worried he might send unencrypted messages, then "require OTR" is the right mode to use 18:10:39 <aleth> arlolra: If the concern is that a system message isn't visible enough, a notification bar or something could be considered. 18:11:10 <flo-retina> arlolra: if your concern is that a message may be sent unencrypted by accident, shouldn't sending another message after that just restart the encryption, and delay sending the actual message until an encrypted session is actually usable again? 18:11:16 <arlolra> the notification bar seems like a reasonable compromise that the user has to dismiss 18:11:52 <arlolra> flo-retina: not in opportunistic encryption ... that always leaks the first message 18:12:01 <arlolra> and attaches whitespace tags 18:12:11 <arlolra> (except when the user is offline, thanks to aleth) 18:12:12 <arlolra> :) 18:12:16 <flo-retina> the notification bar is about fingerprints that haven't been verified, right? It doesn't have anything to do with ending sessions. 18:12:38 <arlolra> i thought the notification bar was for notifications 18:13:45 <arlolra> i think switching back to plaintext is something we want to be explicit about 18:14:03 <arlolra> but don't let that be a blocker 18:16:42 <aleth> OK, I'm sure we can find a good solution to this issue 18:18:47 <flo-retina> yeah, let's not block on this. I think there could be other solutions (eg. coloring the background of the input box, or something). 18:19:33 <arlolra> that's also a nice idea 18:21:33 <arlolra> flo-retina: the paste you had above, was your build -Inss ? 18:21:45 <flo-retina> I don't have -lnss 18:21:49 <flo-retina> where did you add that? 18:23:16 * nhnt11 is clobber building Ib 18:25:17 <nhnt11> flo-retina: Do we still need the 10.8 sdk to build? 18:25:28 <arlolra> flo-retina: i didn't add it but search https://gist.github.com/arlolra/abbe5c70fa7e434ed3d3 18:25:32 <arlolra> nhnt11: no 18:25:36 <flo-retina> nhnt11: I think we need it only for official builds 18:25:42 <nhnt11> thanks! 18:25:42 <arlolra> oh 18:25:48 * nhnt11 removes it from his mozconfig 18:25:53 <aleth> Release builds need it 18:25:54 <nhnt11> flo-retina: so that it will run on older OS X versions? 18:26:02 <aleth> Right 18:26:08 <nhnt11> cool 18:26:12 * nhnt11 restarts his clobber build 18:26:20 --> gerard-majax has joined #instantbird 18:26:25 <flo-retina> arlolra: that gist doesn't show -lnss 18:29:03 <arlolra> sorry, i wasn't being clear 18:29:04 <arlolra> -I/Users/arlolra/Work/Tor/comm-central/obj-x86_64-apple-darwin14.4.0/dist/include/nss 18:30:09 <flo-retina> this is the include for header files, it's not a linker parameter, right? 18:32:02 --> nhnt12 has joined #instantbird 18:32:02 * ChanServ sets mode +h nhnt12 18:32:16 <-- aleth has quit (Quit: :tiuQ) 18:32:24 --> aleth has joined #instantbird 18:32:25 * ChanServ sets mode +o aleth 18:32:29 <-- nhnt12 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:34:37 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:36:34 --> clokep_work has joined #instantbird 18:36:35 * ChanServ sets mode +o clokep_work 18:39:06 --> nhnt12 has joined #instantbird 18:39:06 * ChanServ sets mode +h nhnt12 18:42:54 <-- nhnt12 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:43:25 --> nhnt12 has joined #instantbird 18:43:25 * ChanServ sets mode +h nhnt12 18:43:26 <-- nhnt12 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:46:46 * clokep_work is trying a clobber build 18:51:48 <arlolra> flo-retina: ah, yes. are you doing anything different so that the linker complains? 18:52:31 <clokep_work> arlolra: Taking that patch and running "mach build" is what he's doing, I believe. 18:55:11 * nhnt11 just saw a leth's xor function and cloke p's != suggestoin 18:55:19 <nhnt11> fun! 18:56:09 <clokep_work> ;) 18:56:10 <clokep_work> r-! 18:56:12 <clokep_work> r--! 18:56:19 <clokep_work> r--+=1 19:02:04 <clokep_work> So the Windows issue looks like we need to bump the Visual Studio version. 19:02:19 <arlolra> maybe we need to add 'nss' to USE_LIBS for gcrypt 19:13:08 <-- nhnt11 has quit (Ping timeout: 121 seconds) 19:14:06 <clokep_work> Huh my clobber build worked. :-S 19:14:09 <clokep_work> So...I'm not sure. 19:14:29 <clokep_work> I have concern that I've had libotr installed previously while flo-retina has not. 19:14:34 <clokep_work> So...that could be part of the difference. 19:14:57 <clokep_work> But I uninstalled it and that should be gone. 19:26:09 <clokep_work> arlolra: So yesterday you mentioned something about having to compile gpg-error...? 19:26:33 <clokep_work> Can you expand upon that. 19:27:18 <arlolra> we still depend on libgpg-error 19:27:35 <clokep_work> arlolra: That was not an answer to my question. 19:27:41 <clokep_work> What does that mean that we "stlil depend on it"? 19:29:03 <arlolra> the gcrypt-shim doesn't implement any of the necessary symbols from libgpg-error, so we need to add that library to the build 19:30:11 <clokep_work> arlolra: Right...what's the status of that? 19:30:27 <clokep_work> Have you looked at doing that? 19:32:08 <arlolra> nope. yesterday you said it does all sorts of crazy with awk that you weren't happy about. and in the email you sent, you thought about some other approach to start with something that depends on my platform 19:34:36 <arlolra> the status is pretty much, i'm grasping at straws when it comes to moz build 19:34:54 <-- abdelrhman has quit (Ping timeout: 121 seconds) 19:35:27 --> abdelrhman has joined #instantbird 19:38:34 --> mpmc has joined #instantbird 19:42:13 <arlolra> clokep_work: can you take care of that? 19:46:25 <-- abdelrhman has quit (Ping timeout: 121 seconds) 19:50:32 --> abdelrhman has joined #instantbird 19:50:51 <-- aleth has quit (Ping timeout: 121 seconds) 19:52:36 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:54:31 --> nhnt11 has joined #instantbird 19:54:31 * ChanServ sets mode +h nhnt11 19:54:33 <-- nhnt11 has quit (Connection closed) 19:54:34 --> nhnt11 has joined #instantbird 19:54:35 * ChanServ sets mode +h nhnt11 19:55:08 --> nhnt11-testing has joined #instantbird 19:56:20 --> aleth has joined #instantbird 19:56:20 * ChanServ sets mode +o aleth 19:57:03 <clokep_work> I'll see if I can do anything. 19:58:14 --> gerard-majax has joined #instantbird 19:58:31 <nhnt11> aleth: ping 19:58:38 <aleth> nhnt11: hello 19:59:11 <nhnt11> aleth: I like the typing indicator on the right patch 19:59:20 <nhnt11> But I think it can be improved 19:59:32 <nhnt11> For example, what about making the panel translucent until it's hovered on? 20:00:17 <aleth> We inherit the styling from Firefox 20:00:22 <nhnt11-testing> OK 20:00:27 <nhnt11-testing> I certainly think it's good enough to ship 20:00:29 <aleth> I'm not sure transparency would be very legible, but you could experiment 20:00:48 <clokep_work> arlolra: Do you hae a list of the c files it actually needs? 20:00:57 <nhnt11-testing> Firefox's context is different, websites rarely have text at the very bottom of the page 20:01:07 <clokep_work> nhnt11I think the goal was to very quickly get something better. 20:01:18 <nhnt11-testing> clokep_work: yes, I think it should land as is like I said 20:01:40 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:02:28 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:02:34 <flo-retina> "maybe we need to add 'nss' to USE_LIBS for gcrypt" sounds reasonable 20:03:09 <arlolra> flo-retina: also, the in otr/moz.build, it says EXPORT.libotr = [ ... 20:03:20 <arlolra> i'm thinking that should be EXPORT.otr = [ 20:03:59 <arlolra> clokep_work: no. i was under the impression that it's mostly a bunch of header files for generating platform specific error codes 20:04:20 <clokep_work> arlolra: So you haven't even looked at it? 20:05:33 <arlolra> i have 20:06:01 <arlolra> i'm probably just not expressing myself clearly 20:06:13 <arlolra> s/i was under the impression that// 20:10:31 <clokep_work> nhnt11: Yeah I suggested in person keeping xor as a function still. :) 20:10:37 <clokep_work> nhnt11: So what were you working on today then? 20:10:46 <nhnt11> clokep_work: uploading new split logs patch in a sec 20:10:52 <clokep_work> BOOM! 20:11:52 <nhnt11> aleth: Do you remember my response to https://bugzilla.mozilla.org/show_bug.cgi?id=1025522#c39? 20:11:54 <instantbot> Bug 1025522 nor, --, ---, nhnt11, ASSI, Split log files to prevent them from growing too large 20:12:05 <nhnt11> (I do, and will find and link you to it or explain again if you don't) 20:12:18 <aleth> nhnt11: Didn't we discuss it in the logs? 20:12:32 <nhnt11> right, so I'll find it and link you if you don't remember 20:12:39 <aleth> I remember us deciding on a solution, but I don't remember what it was exactly :-/ 20:12:41 <nhnt11> link it in the bug I mean 20:12:46 <aleth> OK, cool 20:12:52 <aleth> Thanks for the review btw 20:12:59 <nhnt11> Well, slice(-2) won't work, because there's the edge case where there's been more than one new log file 20:13:11 <nhnt11> I changed it to store only the length of the array as you suggested 20:13:52 <aleth> Maybe just paste the relevant part of the logs in the bug with the new patch. 20:15:21 <nhnt11> I updated the comment right above that line, I think that's enough explanation. 20:17:26 <nhnt11> aleth: interdiff: http://pastebin.mozilla.org/8840579 20:18:31 <nhnt11> diff'd https://pastebin.mozilla.org/8840580 20:19:33 <aleth> Thanks! 20:19:45 <instantbot> New Instantbird - Conversation bug 1187460 filed by florian@queze.net. 20:19:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187460 nor, --, ---, nobody, NEW, Implement UI for OTR 20:22:07 <aleth> ^^ arlolra 20:22:15 --> nhnt11-testing has joined #instantbird 20:22:24 <nhnt11-testing> Just testing to make sure logs still work ;) 20:22:37 <nhnt11-testing> though I've done this already, I figured I'd test it again before it lands 20:22:43 <nhnt11-testing> Seems to work fine ;) 20:23:06 <arlolra> what's PTO? 20:23:39 <clokep_work> arlolra: Paid Time Off. 20:24:16 <clokep_work> nhnt11: Correct is better than rushed! :) 20:24:41 <arlolra> thanks 20:25:47 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:29:12 * nhnt11 is unbitrotting indexed logs 20:30:26 <clokep_work> :) 20:31:16 <arlolra> back in a bit 20:34:44 --> nhnt11-testing has joined #instantbird 20:34:45 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:39:04 <abdelrhman> aleth: in bug related to version, it's required to respond to the queries or query and parse the result? 20:41:08 <abdelrhman> bug 1186658 20:41:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186658 nor, --, ---, a.ahmed1026, NEW, Handle XEP-0092: jabber:iq:version 20:43:08 <nhnt11> done, building! :D 20:44:13 <nhnt11> does imIAccountBuddy not exist anymore/ :S 20:45:21 <nhnt11> aha, indeed! 20:45:46 <-- arlolra has quit (Client exited) 20:46:40 --> nhnt11-testing has joined #instantbird 20:47:44 <nhnt11> "Error indexing log file at null:" fun! 20:47:53 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:49:05 --> nhnt11-testing has joined #instantbird 20:49:24 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:49:35 --> nhnt11-testing has joined #instantbird 20:50:25 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:50:39 --> nhnt11-testing has joined #instantbird 20:51:11 <-- aleth has quit (Ping timeout: 121 seconds) 20:51:31 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:51:42 --> nhnt11-testing has joined #instantbird 20:52:42 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:53:26 --> nhnt11-testing has joined #instantbird 20:53:45 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:54:45 --> nhnt11-testing has joined #instantbird 20:55:32 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:56:52 --> nhnt11-testing has joined #instantbird 20:57:22 <-- nhnt11-testing has quit (A TLS packet with unexpected length was received.) 20:59:42 * nhnt11 wonders why this [scriptable, function] callback interface isn't working with a function 21:00:09 --> nhnt11-testing has joined #instantbird 21:01:14 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:02:22 <nhnt11> well, indexed logs works! 21:02:25 <nhnt11> (still) 21:05:38 <nhnt11> It appears that I can't pass a Task.async() function to a function that accepts an object implements an interface that is [scriptable, function..] for some reaosn 21:05:40 <nhnt11> reason* 21:10:35 --> nhnt11-testing has joined #instantbird 21:15:47 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.33.1/20150321194827]) 21:21:15 <-- abdelrhman has quit (Quit: Leaving) 21:35:49 * nhnt11 wonders if flo-retina will have time to review a new indexed logs patch 21:35:55 <nhnt11> I can supply an interdiff, that should help 21:36:07 <nhnt11> this is probably the best time for me to get a patch up :) 21:41:56 --> aleth has joined #instantbird 21:41:57 * ChanServ sets mode +o aleth 21:48:56 <clokep_work> nhnt11: Hopefully he can look at some point soon. :) 21:57:16 <instantbot> aleth@instantbird.org changed the Resolution on bug 1186414 from --- to FIXED. 21:57:18 <instantbot> aleth@instantbird.org changed the Resolution on bug 1187286 from --- to FIXED. 21:57:19 <instantbot> aleth@instantbird.org changed the Resolution on bug 1136396 from --- to FIXED. 21:57:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186414 tri, --, 1.6, a.ahmed1026, RESO FIXED, prpl-gtalk: Could not get services for this server: gmail.com 21:57:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1187286 nor, --, 1.6, florian, RESO FIXED, "No account configured yet!" message flashing for a split second 21:57:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1136396 nor, --, 1.6, aleth, RESO FIXED, Typing indicator makes latest message hard to read 22:09:03 <-- Bollebib has quit (Ping timeout: 121 seconds) 22:21:21 --> freaktechnik_ has joined #instantbird 22:23:05 <-- freaktechnik has quit (Ping timeout: 121 seconds) 22:23:06 * freaktechnik_ is now known as freaktechnik 22:37:13 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:46:36 --> arlolra has joined #instantbird 23:01:33 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:06:02 * Fallen is now known as Fallen|away 23:10:52 <aleth> nhnt11: OK with the split log review comments? 23:11:34 <nhnt11> aleth: yeah, good catch 23:12:02 <nhnt11> about the ===, I only did == undefined because !a is true when a is 0 23:12:25 <nhnt11> I can change it to ===, np 23:16:17 <aleth> ah, if you're only concerned about 0 == undefined, then that's OK I think 23:18:55 <nhnt11> cool 23:30:48 <-- myk has quit (Ping timeout: 121 seconds) 23:35:21 --> BlueMaxima has joined #instantbird 23:38:17 <instantbot> aleth@instantbird.org changed the Resolution on bug 1176958 from --- to FIXED. 23:38:19 <instantbot> aleth@instantbird.org changed the Resolution on bug 1186463 from --- to FIXED. 23:38:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1186463 nor, --, 1.6, aleth, RESO FIXED, Thunderbird Chat and Slack XMPP gateway don't connect 23:38:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1176958 nor, --, 1.6, a.ahmed1026, RESO FIXED, participants list does not delete old nick when a participant changes it in XMPP MUC 23:42:11 <clokep_work> nhnt11: Soon? :) 23:42:15 <clokep_work> That bug annoys me frequently! 23:42:43 <nhnt11> clokep_work: which bug? 23:42:52 <nhnt11> soon what? 23:43:15 <clokep_work> nhnt11: Split logs. 23:43:17 <clokep_work> I hope it's done soon! 23:43:23 <nhnt11> aha 23:48:19 <clokep_work> :-D 23:49:54 <-- aleth has quit (Quit: :tiuQ) 23:50:02 --> aleth has joined #instantbird 23:50:02 * ChanServ sets mode +o aleth 23:54:05 <-- aleth has quit (Ping timeout: 121 seconds)