#instantbird log on 07 14 2015

All times are UTC.

00:21:03 <-- myk has quit (Ping timeout: 121 seconds)
01:20:49 <-- aleth has quit (Ping timeout: 121 seconds)
01:27:29 <-- Mook_as has quit (Client exited)
01:34:36 --> clokep has joined #instantbird
01:34:36 * ChanServ sets mode +o clokep 
01:34:54 <-- clokep has quit (Connection closed)
01:35:03 --> clokep has joined #instantbird
01:35:03 * ChanServ sets mode +o clokep 
01:37:51 <-- clokep_work has quit (Ping timeout: 121 seconds)
02:19:30 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:30:22 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:43:46 <instant-buildbot> build #2768 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2768
03:17:57 --> nhnt11 has joined #instantbird
03:17:57 * ChanServ sets mode +h nhnt11 
03:36:19 --> BlueMaxima has joined #instantbird
03:41:58 <-- nhnt11 has quit (Ping timeout: 121 seconds)
03:43:18 <instant-buildbot> build #1458 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1458
04:28:28 --> nhnt11 has joined #instantbird
04:28:28 * ChanServ sets mode +h nhnt11 
04:28:29 <-- nhnt11 has quit (Connection closed)
04:28:30 --> nhnt11 has joined #instantbird
04:28:30 * ChanServ sets mode +h nhnt11 
04:47:25 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:47:28 --> nhnt11 has joined #instantbird
04:47:28 * ChanServ sets mode +h nhnt11 
05:05:36 <-- EionRobb has quit (Quit: Leaving.)
05:06:20 --> EionRobb has joined #instantbird
05:06:23 <-- EionRobb has quit (Quit: Leaving.)
05:20:17 --> afiksof has joined #instantbird
05:25:25 <-- nhnt11 has quit (Ping timeout: 121 seconds)
06:18:46 * Fallen|away is now known as Fallen 
06:34:29 <-- Tobin has quit (Connection closed)
06:51:47 --> mpmc has joined #instantbird
06:55:30 --> EionRobb has joined #instantbird
07:06:01 --> myk has joined #instantbird
07:26:52 <-- myk has quit (Ping timeout: 121 seconds)
07:30:25 <instant-buildbot> build #373 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/373
07:38:36 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:44:55 --> gerv1 has joined #instantbird
07:46:03 <-- gerv has quit (Ping timeout: 121 seconds)
07:46:03 * gerv1 is now known as gerv 
07:47:09 --> aleth has joined #instantbird
07:47:09 * ChanServ sets mode +o aleth 
07:47:17 <-- aleth has quit (Connection closed)
07:47:19 --> aleth has joined #instantbird
07:47:19 * ChanServ sets mode +o aleth 
08:34:57 --> mpmc has joined #instantbird
08:59:35 <-- aleth has quit (Ping timeout: 121 seconds)
09:05:36 --> aleth has joined #instantbird
09:05:36 * ChanServ sets mode +o aleth 
09:08:09 --> gerv1 has joined #instantbird
09:08:37 <-- gerv has quit (Ping timeout: 121 seconds)
09:08:37 * gerv1 is now known as gerv 
09:10:30 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:10:31 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:13:15 --> chrisccoulson has joined #instantbird
10:23:54 <-- afiksof has quit (Connection closed)
10:57:29 --> clokep has joined #instantbird
10:57:29 * ChanServ sets mode +o clokep 
10:58:25 --> gerard-majax has joined #instantbird
11:41:08 * Fallen is now known as Fallen|away 
12:05:17 <-- clokep has quit (Ping timeout: 121 seconds)
12:14:31 * Fallen|away is now known as Fallen 
12:39:47 <-- aleth has quit (Quit: :tiuQ)
12:39:54 --> aleth has joined #instantbird
12:39:54 * ChanServ sets mode +o aleth 
12:43:26 --> clokep_work has joined #instantbird
12:43:26 * ChanServ sets mode +o clokep_work 
12:45:16 * Fallen is now known as Fallen|away 
12:45:31 * Fallen|away is now known as Fallen 
12:47:49 <-- EionRobb has quit (Quit: Leaving.)
12:48:04 <-- gerv has quit (Connection closed)
12:48:13 --> afiksof has joined #instantbird
12:57:56 <-- gerard-majax has quit (Ping timeout: 121 seconds)
13:02:49 <-- afiksof has quit (Connection closed)
13:02:55 --> afiksof has joined #instantbird
13:37:57 * Fallen is now known as Fallen|away 
13:43:23 <-- BlueMaxima has quit (Quit: Leaving)
13:53:05 --> ecmuller has joined #instantbird
14:05:52 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:22:29 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
14:22:42 --> chrisccoulson has joined #instantbird
14:29:08 <-- aleth has quit (Ping timeout: 121 seconds)
14:30:45 --> Tobin has joined #instantbird
14:34:34 --> aleth has joined #instantbird
14:34:34 * ChanServ sets mode +o aleth 
15:38:15 --> Mnyromyr has joined #instantbird
15:42:36 --> gerard-majax has joined #instantbird
16:08:31 --> myk has joined #instantbird
16:18:49 --> arlolra has joined #instantbird
16:26:54 <arlolra> clokep_work: you aorund?
16:27:37 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:27:41 --> clokep_work has joined #instantbird
16:27:42 * ChanServ sets mode +o clokep_work 
16:29:22 <clokep_work> arlolra: _working, but yes.
16:31:06 <arlolra> ok. wanted to discuss this shim but I'll come back later
16:40:36 <-- afiksof has quit (Ping timeout: 121 seconds)
16:49:18 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
16:49:31 --> chrisccoulson has joined #instantbird
16:51:35 <clokep_work> arlolra: Sure, leaves some questions?
16:51:41 <clokep_work> I should be more free soon.
16:53:28 <arlolra> ok. first off, you have a symbols-implemented.log, but there's no evidence those were actually done. maybe I'm reading that wrong
16:57:47 <clokep_work> arlolra: What do you mean "those were done"?
16:57:50 <clokep_work> Can you link me the bug again?
16:58:37 <arlolra> https://bugzilla.mozilla.org/show_bug.cgi?id=1147369
16:58:58 <arlolra> implemented
16:59:14 <clokep_work> Huh bugzilla isn't resolving.
16:59:18 <clokep_work> Rather, not loading.
17:00:24 <clokep_work> arlolra: So that was a list of symbols I pulled out.
17:00:29 <clokep_work> They're *not implemented*, that's the point.
17:00:58 <arlolra> oh, cause there's also a symbols.log
17:01:27 <arlolra> so you're saying they are the same info, just different formatting
17:01:34 <arlolra> and i shouldn't read anything into the names
17:01:35 <arlolra> ok
17:01:48 <clokep_work> arlolra: I think one of them has things like tabbed in?
17:01:52 <clokep_work> Those are 'implemented'?
17:02:27 <instantbot> Bug 1147369 nor, --, ---, nobody, NEW, Add libotr to build system
17:02:44 <arlolra> ah, ok
17:02:48 <arlolra> thanks
17:02:54 <arlolra> i see that now
17:02:57 <clokep_work> I think that's what my code meant. :)
17:03:47 <arlolra> ya, checks out, for the most part
17:03:58 <arlolra> bugzilla is back u
17:04:00 <arlolra> p
17:05:50 <arlolra> ok, second thing
17:07:34 <arlolra> there's all this crazy, architecture specific stuff about the limb sizes in the mpis
17:07:48 <arlolra> i think the right thing to do is just `#define gcry_mpi mp_int;`
17:08:06 <arlolra> and then rewrite the serialization code
17:08:26 <arlolra> that way internally we only work with freebl's mpis
17:08:38 <clokep_work> Hm...I don't have that patch.
17:09:13 <arlolra> what do you mean?
17:11:05 <arlolra> mpi = multi-precision integer
17:13:40 --> Mook_as has joined #instantbird
17:17:46 <clokep_work> arlolra: I can't get on Bugzilla.
17:17:51 <clokep_work> So I don't have any idea what you're talking about.
17:18:51 <clokep_work> I might have it locally, let me check.
17:20:01 <clokep_work> arlolra: OK, I found it.
17:20:14 <clokep_work> I don't know what "there's all this crazy, architecture specific stuff about the limb sizes in the mpis" means though.
17:20:23 <clokep_work> Why do we need that?
17:20:31 <arlolra> i don't think you need the patch. let me try to explain. each of the two crypto libraries (freebl and gcrypt) have their own internal representation of an mpi
17:21:10 <clokep_work> Ah, it finally loaded.
17:21:17 <clokep_work> What is "freebl"?
17:21:37 <arlolra> it's the part of nss that actually wraps the low level crypto operations
17:21:51 <arlolra> like modular inverses and whatnot
17:22:16 <arlolra> nss/lib/freebl
17:24:42 <clokep_work> Alright.
17:24:52 <clokep_work> I'm surprised you need to actually look that low at operations.
17:25:03 <arlolra> ya, this is a nightmare
17:25:30 <clokep_work> I'd expect you to be able to just use NSS level operations.
17:26:12 <arlolra> nope
17:26:36 <arlolra> see all the uses of gcry_mpi_t
17:29:34 <clokep_work> Inside of libotr?
17:29:41 <arlolra> ya
17:29:53 <clokep_work> Hm...I wonder why those didn't show up as unresolved.
17:30:38 <arlolra> it's a struct, probably defined in the header you included
17:31:53 --> nhnt11 has joined #instantbird
17:31:53 * ChanServ sets mode +h nhnt11 
17:32:57 --> afiksof has joined #instantbird
17:33:03 <arlolra> the representation of an mpi is usually an array with a length and sign and size and a number of slots used. that's usually what's being talked about by "limb"
17:33:30 <arlolra> anyways, so freebl and gcrypt have similar yet subtly varying representations
17:33:46 <arlolra> i think trying to convert between the two is the wrong approach
17:34:02 <arlolra> instaed, we should just worry about that serializing / parsing
17:34:26 <arlolra> and then just `#define gcry_mpi mp_int;` and work with mp_int internally
17:36:56 --> Bollebib has joined #instantbird
17:37:56 <-- clokep_work has quit (Ping timeout: 121 seconds)
17:41:02 --> clokep_work has joined #instantbird
17:41:02 * ChanServ sets mode +o clokep_work 
17:42:14 <clokep_work> arlolra: Sorry, had to restart.
17:42:32 <arlolra> np, can you access the logs so i don't need to type that again :)
17:42:41 <clokep_work> Yes.
17:42:46 <clokep_work> I don't see what your question is. ;)
17:43:19 <arlolra> mainly i'm asking if you think this is a good approach
17:47:28 <clokep_work> It sounds reasonable.
17:47:34 <clokep_work> I haven't looked at it close enough to know though.
17:50:29 <aleth> arlolra: maybe someone who knows either/both nss and grcypt better can help?
17:50:40 <arlolra> ok. and for other things like `gcry_cipher_open` which are only ever called with one cipher / mode, i'm just going to assert that it's AES and then use the equivalent in nss rather than trying to shim more than we need to
17:51:35 <clokep_work> arlolra: Yes, that's what I had done in the code I wrote.
17:51:50 <clokep_work> But we should verify it's the expected type, yup! :)
17:52:02 <arlolra> k, thanks
17:52:04 * aleth wonders if there are gcrypt tests you can run to test the shim once it exists
17:52:05 <arlolra> aleth: any idea who that would be?
17:52:27 <arlolra> there are libotr tests to run
17:52:43 <aleth> arlolra: no, but there's bound to be an irc channel for crypto somewhere ;) possibly ask on #security
17:53:05 <aleth> arlolra: ah, good, if there are decent tests then that gives confidence.
17:56:03 <arlolra> i'm pretty sure the people in #security are going to laugh and say this is a horrible idea
17:56:04 <arlolra> :)
17:57:05 <aleth> as long as they have a better one...
17:58:49 <arlolra> i mean shimming gcrypt
18:32:09 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:33:54 --> sawrubh has joined #instantbird
19:03:46 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:12:47 --> chrisccoulson has joined #instantbird
19:25:32 * Fallen|away is now known as Fallen 
19:57:45 <-- afiksof has quit (Ping timeout: 121 seconds)
20:29:26 <-- arlolra has quit (Client exited)
20:41:00 --> EionRobb has joined #instantbird
20:48:57 <-- Tonnes has quit (Connection closed)
20:49:34 <-- sawrubh has quit (Quit: Connection closed for inactivity)
21:08:37 <clokep_work> Btw if people didn't see, there's a bug filed that will fix our bsutage
21:11:57 --> mpmc has joined #instantbird
21:18:18 --> Tonnes has joined #instantbird
21:20:57 --> arlolra has joined #instantbird
21:27:07 --> sawrubh has joined #instantbird
21:51:20 <-- Mnyromyr has quit (Quit: ChatZilla [SeaMonkey 2.33.1/20150321194827])
22:02:37 --> abdelrhman has joined #instantbird
22:06:11 <abdelrhman> clokep_work: I hope if you have a time can review these bugs: bug 1177902, bug 1176958
22:06:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1177902 nor, --, ---, a.ahmed1026, ASSI, Add test for _parseJID in XMPP
22:06:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1176958 nor, --, ---, a.ahmed1026, ASSI, participants list does not delete old nick when a participant changes it in XMPP MUC
22:06:30 <clokep_work> abdelrhman: Sorry. I keep being lazy.
22:06:36 <clokep_work> abdelrhman: Please keep bothering me until I do it. :)
22:06:38 <clokep_work> Like daily.
22:07:25 <abdelrhman> OK :-)
22:09:02 <aleth> abdelrhman: bug 1171691 might be a fun one that could be done now (very visible improvement) if you're looking for another bug ;)
22:09:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1171691 nor, --, ---, nobody, NEW, Improve the participant tooltips for XMPP
22:09:05 <abdelrhman> aleth: for bug 1180435, can you provide received stanzas for that?
22:09:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1180435 min, --, ---, nobody, NEW, Topic system message is duplicated on joining a room
22:09:42 <abdelrhman> aleth: OK, I will work on ;)
22:10:33 <aleth> abdelrhman: You can just join the chatroom mentioned in the bug description to experiment
22:10:46 <abdelrhman> Ah, OK
22:11:53 <aleth> There's probably only one stanza but somehow there are two places were a system message gets printed
22:15:20 <abdelrhman> Ah, which one of them should we keep printed?
22:16:46 <aleth> Whatever makes more sense.
22:21:33 <abdelrhman> after checking that, it seems the problem of body!
22:22:56 --> freaktechnik_ has joined #instantbird
22:23:19 <aleth> Ah, a server behaving badly?
22:23:35 <-- myk has quit (Ping timeout: 121 seconds)
22:23:56 <-- freaktechnik has quit (Ping timeout: 121 seconds)
22:23:56 * freaktechnik_ is now known as freaktechnik 
22:24:08 <abdelrhman> yes, http://pastebin.instantbird.com/1723325
22:24:39 <clokep_work> abdelrhman: Yeah that's what I expected. ;)
22:24:51 <clokep_work> The unfortunate thing there is that the <body> is the one with more information. :(
22:24:51 <abdelrhman> ;)
22:25:06 <clokep_work> One r+ :P
22:25:57 <abdelrhman> :D
22:26:33 <aleth> It might be WONTFIX then
22:26:54 <aleth> abdelrhman: why is the message in the body printed as a system message?
22:27:15 * Fallen is now known as Fallen|away 
22:27:29 <clokep_work> aleth: Nope! We should definitely print only one of them.
22:27:39 <clokep_work> abdelrhman: Does my comment make sense btw?
22:27:47 <clokep_work> Not sure we've given you an "r+ with these changes" before?
22:28:30 <aleth> clokep_work: ok, probably it's just a matter of ignoring the body in that case then
22:28:31 <abdelrhman> aleth: https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#1381
22:28:57 <abdelrhman> this stanza passes subject condition and body also.
22:29:10 <abdelrhman> so it's printed twice.
22:29:33 <clokep_work> aleth: Yes, that's justunfortunate. :(
22:29:43 <clokep_work> We should probably ignore the body if the other one is there.
22:29:45 <aleth> abdelrhman: yes, the answer to the question I asked was https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#271 though (I just found it)
22:29:49 <clokep_work> It just sucks that 9in this case) it has more info.
22:29:57 <abdelrhman> clokep_work: yes, for this bug 1011226
22:30:00 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1011226 nor, --, 1.6, a.ahmed1026, RESO FIXED, Support setting the topic in XMPP MUCs
22:30:17 <aleth> abdelrhman: ok, so it has an easy fix then :-)
22:30:27 <clokep_work> abdelrhman: Anyway, you get what my r+ meant, right?
22:32:53 <abdelrhman> yes ;)
22:34:28 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:41:42 <-- arlolra has quit (Client exited)
22:43:08 <-- EionRobb has quit (Connection closed)
22:55:03 --> EionRobb has joined #instantbird
22:55:23 <abdelrhman> aleth: preventing it from printing (the body)?
22:55:48 <aleth> yes
22:56:13 <aleth> it shouldn't have a body anyway, after all ;)
23:00:59 <abdelrhman> yes, this is temporary.
23:01:31 <abdelrhman> we can check if the type is message e.g(<message/>) and it has subject then return.
23:22:04 <-- Bollebib has quit (Connection closed)
23:22:49 --> Bollebib has joined #instantbird
23:27:32 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
23:50:06 <-- aleth has quit (Quit: :tiuQ)