All times are UTC.
00:07:11 <-- arlolra has quit (Client exited) 00:17:26 <-- myk has quit (Ping timeout: 121 seconds) 00:24:23 --> Alex1 has joined #instantbird 00:30:36 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:31:01 <-- Mook_as has quit (Client exited) 00:43:53 --> MattATobin has joined #instantbird 00:45:02 * MattATobin is now known as AnjohlTennan 00:45:16 * AnjohlTennan is now known as MattATobin 00:46:49 <-- Tobin has quit (Ping timeout: 121 seconds) 01:05:07 <-- Bollebib has quit (Connection closed) 01:13:25 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:22:44 <instantbot> New Instantbird - Conversation bug 1175374 filed by arlolra@gmail.com. 01:22:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1175374 nor, --, ---, nobody, UNCO, Make noLog an editable attribute of the imIMessage interface. 01:24:22 --> nhnt12 has joined #instantbird 01:24:22 * ChanServ sets mode +h nhnt12 01:24:23 <-- nhnt12 has quit (Connection closed) 01:24:25 <-- nhnt11 has quit (Ping timeout: 121 seconds) 01:24:46 --> nhnt11 has joined #instantbird 01:24:47 * ChanServ sets mode +h nhnt11 01:29:18 --> nhnt12 has joined #instantbird 01:29:18 * ChanServ sets mode +h nhnt12 01:30:51 <-- nhnt11 has quit (Ping timeout: 121 seconds) 01:30:51 * nhnt12 is now known as nhnt11 01:36:41 <-- Alex1 has quit (Ping timeout: 121 seconds) 01:46:25 --> nhnt12 has joined #instantbird 01:46:26 * ChanServ sets mode +h nhnt12 01:49:17 <-- nhnt11 has quit (Ping timeout: 121 seconds) 01:49:18 * nhnt12 is now known as nhnt11 01:52:36 --> nhnt12 has joined #instantbird 01:52:36 * ChanServ sets mode +h nhnt12 01:53:19 <-- nhnt11 has quit (Ping timeout: 121 seconds) 01:53:20 * nhnt12 is now known as nhnt11 02:07:26 <-- nhnt11 has quit (Ping timeout: 121 seconds) 02:13:31 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:24:28 --> AlexanderSalas has joined #instantbird 02:32:41 --> nhnt11 has joined #instantbird 02:32:41 * ChanServ sets mode +h nhnt11 03:00:45 --> micahg has joined #instantbird 03:11:37 <-- sukhe has quit (Quit: leaving) 03:14:58 <-- nhnt11 has quit (Ping timeout: 121 seconds) 03:35:56 --> tabris has joined #instantbird 04:28:00 <instant-buildbot> build #1430 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1430 04:35:16 --> nhnt11 has joined #instantbird 04:35:16 * ChanServ sets mode +h nhnt11 04:40:56 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 04:48:16 --> afiksof has joined #instantbird 04:55:39 <instant-buildbot> build #2717 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2717 05:13:58 <-- nhnt11 has quit (Ping timeout: 121 seconds) 05:52:07 <-- Widdershins has quit (Ping timeout: 121 seconds) 05:58:29 --> myk has joined #instantbird 05:58:52 --> nhnt11 has joined #instantbird 05:58:52 * ChanServ sets mode +h nhnt11 06:14:39 --> sukhe has joined #instantbird 06:15:41 <-- nhnt11 has quit (Ping timeout: 121 seconds) 07:09:23 <-- Mook has quit (Client exited) 07:15:06 --> EionRobb has joined #instantbird 07:37:42 * Fallen|away is now known as Fallen 07:56:05 <-- tabris has left #instantbird ("http://pidgin.renatosilva.me - Pidgin++") 08:06:33 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:11:10 --> gerard-majax has joined #instantbird 08:15:46 --> mpmc has joined #instantbird 08:16:16 --> aleth has joined #instantbird 08:16:17 * ChanServ sets mode +o aleth 09:03:00 <-- EionRobb has quit (Quit: Leaving.) 09:05:47 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:32:09 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:38:56 <-- Tonnes has quit (Connection closed) 09:57:48 --> Tonnes has joined #instantbird 10:02:54 <instant-buildbot> build #344 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/344 10:08:41 --> gerard-majax has joined #instantbird 10:14:54 --> akronix has joined #instantbird 10:18:40 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:19:42 --> flo-retina has joined #instantbird 10:19:42 * ChanServ sets mode +qo flo-retina flo-retina 10:20:02 --> AlexanderSalas has joined #instantbird 10:20:51 <flo-retina> a Linux64 build! \o/ 10:24:17 --> gerard-majax has joined #instantbird 10:30:11 <instantbot> New Chat Core - XMPP bug 1175462 filed by aleth@instantbird.org. 10:30:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1175462 nor, --, ---, nobody, NEW, Automatic MUC rejoins don't always work 10:30:43 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:42:26 --> clokep has joined #instantbird 10:42:26 * ChanServ sets mode +o clokep 10:44:01 --> gerard-majax has joined #instantbird 10:45:00 --> Bollebib has joined #instantbird 11:01:08 <clokep> akronix: Hello. 11:09:14 <-- gerard-majax has quit (Ping timeout: 121 seconds) 11:17:33 <clokep> flo-retina: You see the emails on the l10n mailing list? 11:18:01 <flo-retina> yes 11:18:41 <flo-retina> Tonnes: the project isn't dead at all ;). 11:19:49 * Fallen is now known as Fallen|away 11:28:43 <-- MattATobin has quit (Connection closed) 11:31:56 <clokep> Bah that bug caused a lot of regressions. :-[ 11:33:07 --> Tobin has joined #instantbird 11:33:45 <flo-retina> which bug? 11:34:07 <clokep> aleth: Does touching tab completion scare you at this point? It feels like we have hacks-on-hacks. 11:34:30 <flo-retina> I'm not sure what's not translated about the 1.5 release notes; I don't remember hearing about that issue 11:34:47 <aleth> clokep: Yes, we've discussed that many times. The patch I put up yesterday doesn't really touch tab complete though, it just disables it 11:35:01 <flo-retina> tests, tests, tests! ;) 11:35:40 <clokep> flo-retina: My guess is that updates weren't pushed to the website? 11:35:45 <clokep> But I don't remember hearing about that either. 11:36:02 <flo-retina> possibly a line missing in a crontab after one of the few server moves we had to do 11:37:03 <clokep> aleth: So my understanding is that there are two if-statements, one is the thing that undoes tab-completion when you backspace, the other is tab-completion when you press tab? 11:37:10 <clokep> And we disable either of them if anything is selected? 11:37:15 <clokep> s/either/both/ 11:37:15 <aleth> right 11:37:22 <clokep> Pretty straight forward. :) 12:00:45 <Tonnes> flo-retina: good :) 12:01:32 <Tonnes> sorry about the tone - it may look a bit unfriendly when reading it. not my style ;) 12:07:06 * Fallen|away is now known as Fallen 12:08:27 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:11:39 --> gerard-majax has joined #instantbird 12:20:18 <flo-retina> Tonnes: that previous email that was left unanswered was also not really friendly; we are sorry about that. 12:21:23 <Tonnes> flo-retina: we're all humans, I guess :) 12:21:41 <flo-retina> indeed! :) 12:52:43 <-- afiksof has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 12:52:56 --> afiksof has joined #instantbird 12:59:51 --> clokep_work has joined #instantbird 12:59:51 * ChanServ sets mode +o clokep_work 13:10:36 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:10:41 --> clokep_work has joined #instantbird 13:10:41 * ChanServ sets mode +o clokep_work 13:18:35 <-- micahg has quit (A TLS packet with unexpected length was received.) 13:46:22 <flo-retina> akronix: ping 14:06:58 <-- aleth has quit (Ping timeout: 121 seconds) 14:20:51 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 14:25:30 --> AlexanderSalas has joined #instantbird 14:59:19 --> myk has joined #instantbird 15:00:34 * Fallen is now known as Fallen|away 15:20:20 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:37:30 --> myk1 has joined #instantbird 15:38:10 <-- myk has quit (Ping timeout: 121 seconds) 15:38:11 * myk1 is now known as myk 15:48:38 <-- myk has quit (Ping timeout: 121 seconds) 15:54:42 <-- gerard-majax has quit (Ping timeout: 121 seconds) 15:55:46 --> flo-retina has joined #instantbird 15:55:47 * ChanServ sets mode +qo flo-retina flo-retina 16:12:15 --> myk has joined #instantbird 16:16:09 --> myk1 has joined #instantbird 16:17:33 <-- myk1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:17:36 --> myk1 has joined #instantbird 16:18:18 <-- myk has quit (Ping timeout: 121 seconds) 16:18:18 * myk1 is now known as myk 16:18:45 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:18:48 --> myk has joined #instantbird 16:19:22 --> Widdershins has joined #instantbird 16:19:34 --> gerard-majax has joined #instantbird 16:28:55 --> mconley_ has joined #instantbird 16:29:54 * mconley_ is now known as mconley|livehacking 16:37:39 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:42:53 --> gerard-majax has joined #instantbird 16:44:20 --> mconley|_ has joined #instantbird 16:45:28 * mconley|_ is now known as mconley|livehacking_ 16:47:49 --> Mook_as has joined #instantbird 16:47:51 <-- mconley|livehacking has quit (Ping timeout: 121 seconds) 16:52:34 * Fallen|away is now known as Fallen 16:53:55 --> nhnt11 has joined #instantbird 16:53:55 * ChanServ sets mode +h nhnt11 16:55:51 * mconley|livehacking_ is now known as mconley|livehacking 16:59:38 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 17:10:00 --> arlolra has joined #instantbird 17:13:20 --> aleth has joined #instantbird 17:13:20 * ChanServ sets mode +o aleth 17:13:21 <-- aleth has quit (Connection closed) 17:13:22 --> aleth has joined #instantbird 17:13:23 * ChanServ sets mode +o aleth 17:15:09 --> AlexanderSalas has joined #instantbird 17:18:32 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:23:33 --> gerard-majax has joined #instantbird 17:37:34 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:57:37 <arlolra> aleth: thanks for the review 17:59:08 <aleth> arlolra: I'm not sure what's going on with the readonly on overriding that flag 17:59:11 <clokep_work> arlolra: In the future, if you have a patch that you know won't pass review, it usually makes more sense to request feedback and give the reason *why* you did something, e.g. "it didn't work" doesn't really give us enough information to help you figure out what way *will* work. 18:03:31 <arlolra> clokep_work: that's true, I should have flagged that for review 18:04:35 <aleth> arlolra: you might want to ask e.g. bholley if he has any idea why you seem to need to remove the readonly. seems wrong to me 18:04:35 <arlolra> sorry about that 18:05:05 <aleth> at least bholley will know who to ask ;) 18:05:15 <arlolra> where would I find this person? 18:06:39 <aleth> on IRC 18:07:06 <aleth> e.g ping him on #jsapi 18:07:12 <arlolra> right, which channel 18:07:12 <arlolra> ok 18:07:14 <arlolra> thanks 18:11:16 --> gerard-majax has joined #instantbird 18:19:22 <arlolra> clokep_work, aleth: the response from bz in jsapi was, "xpidl flattens everything onto the most-derived prototype, so there's no way to make that work" 18:22:49 <clokep_work> Interesting. I'm not 100% sure what that means. 18:23:30 <flo-retina> probably that xpidl sucks :-/ 18:23:39 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:24:01 <arlolra> ha 18:25:03 <flo-retina> which error did you get when you tried? 18:25:28 <arlolra> no error, it just wouldn't update the attribute 18:26:13 <arlolra> I did im.noLog = true; // Cu.reportError(im.noLog.toString); // false 18:26:57 <flo-retina> would doing |im.imIMessage.noLog = true| help? 18:27:28 <arlolra> i can try 18:30:35 <-- afiksof has quit (Connection closed) 18:30:50 --> afiksof has joined #instantbird 18:32:21 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:32:41 <-- mconley|livehacking has quit (Quit: NO CARRIER) 18:33:34 * Fallen is now known as Fallen|away 18:33:43 <arlolra> flo-retina: doesn't seem to :( 18:38:44 * Fallen|away is now known as Fallen 18:48:20 <arlolra> flo-retina: I can do |im.wrappedJSObject.noLog = true| 18:49:45 <flo-retina> that seems reasonable. Unfortunate, but reasonable. 18:49:46 <aleth> I don't think that'll work for libpurple prpls 18:50:04 <flo-retina> arlolra: it's the imIMessage object 18:50:09 <flo-retina> err, that was for aleth 18:50:14 <arlolra> :) 18:50:50 <aleth> flo-retina: hmm 18:50:55 <aleth> then that really is unfortunate... 18:51:51 <arlolra> but? 18:51:52 <freaktechnik> .QueryInterface ? 18:52:47 <aleth> arlolra: so you're proposing to not change any interfaces at all, but just use wrappedJSObject from OTR to override the flag? 18:53:38 <arlolra> i was going to change the imIMessage interface to document that expectation 18:54:01 <aleth> Yes, a comment there would be nice. 18:54:17 <aleth> Or should it be a method? 18:54:19 * aleth ponders 18:55:01 <aleth> im.setNoLog(value) 18:56:10 --> Mnyromyr has joined #instantbird 18:58:46 <arlolra> freaktechnik: what are you proposing with QueryInterface? 18:58:55 <arlolra> aleth: is that preferable? 18:59:13 <aleth> flo-retina: any thoughts? 18:59:36 <arlolra> also, about the defineProperty change https://bugzilla.mozilla.org/show_bug.cgi?id=1175374#c2 18:59:38 <instantbot> Bug 1175374 nor, --, ---, nobody, UNCO, Make noLog an editable attribute of the imIMessage interface. 18:59:49 <arlolra> which would apply to displayMessage as well 19:00:12 <flo-retina> aleth: I'm close to suggesting we make the logger code fire a notification so that logging of a specific message can be prevented or modified 19:00:49 <flo-retina> aleth: would it be useful for add-ons to be able to add arbitrary data to the JSON object we are about to write to disk? 19:00:55 <aleth> Isn't that a lot of overhead in comparison? 19:01:32 <aleth> I don't think anyone has asked for that so far 19:01:32 <flo-retina> it is 19:01:45 <aleth> which isn't to say it might not be useful for something 19:01:48 <flo-retina> aleth: twitter kinda needs it, but it's different 19:02:16 <flo-retina> aleth: it would be really useful to log the tweet id with each tweet, so that we can have "copy link to tweet" work for tweets from the logs 19:03:01 <flo-retina> I guess the twitter case would be better addressed by an additional property on the prplIMessage, that would be a jsval 19:03:09 <aleth> yes, but it would be a complicated way to solve that issue (as opposed to providing a way for prpls to add loggable data to messages from the start) 19:03:15 <aleth> right 19:03:27 <flo-retina> hmm, would a read/write jsval be useful for this? 19:03:57 <flo-retina> msg.logData.OMGOTRDoNotLog = true 19:04:07 <flo-retina> the logger would have to check that boolean of course... 19:04:29 <aleth> two noLog flags :-/ 19:04:57 <flo-retina> the noLog getter from imMessage could check both values 19:05:24 <aleth> Having stuff in logData that makes nothing get logged seems confusing 19:05:30 * aleth is disappointed in xpidl ;) 19:05:33 <flo-retina> yeah... 19:05:44 <flo-retina> I was just sharing thoughts (like you asked), not solutions :-P. 19:05:51 <aleth> sure! 19:07:04 <aleth> A cancelLog attribute on imIMessage, and the noLog getter checks that value too? 19:08:02 <flo-retina> :( 19:08:07 <aleth> that's an extra boolean per message though :-( 19:08:17 <flo-retina> would be nice if we could design something that solve real problems, rather than just add more hacks 19:08:21 <aleth> indeed 19:09:24 <aleth> Or should we go with the original "send a notification to logger.js to turn off/on logging for a given conversation"? 19:10:00 <arlolra> we could try that 19:11:37 <clokep_work> I'm not a big fan of using wrappedJSObject. 19:11:56 <flo-retina> or add a per-conversation flag that the logger would check for each message? 19:12:14 <flo-retina> bah, that would be on the prplIConversation, so that would suck too ( 19:12:16 <flo-retina> *:( 19:15:58 <instantbot> aleth@instantbird.org changed the Resolution on bug 1175462 from --- to FIXED. 19:16:00 <instantbot> aleth@instantbird.org changed the Resolution on bug 1172361 from --- to FIXED. 19:16:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1175462 nor, --, 1.6, aleth, RESO FIXED, Automatic MUC rejoins don't always work 19:16:02 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172361 nor, --, 1.6, a.ahmed1026, RESO FIXED, Change localization of XMPP commands 19:16:09 <instantbot> aleth@instantbird.org changed the Resolution on bug 1174843 from --- to FIXED. 19:16:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1174843 nor, --, 1.6, aleth, RESO FIXED, Disable tab completion keys if the user has selected some text 19:17:00 --> gerard-majax has joined #instantbird 19:18:29 <instantbot> aleth@instantbird.org set status-thunderbird to affected on bug 1175462. 19:18:31 <instantbot> aleth@instantbird.org set status-thunderbird to affected on bug 1175462. 19:18:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1175462 nor, --, 1.6, aleth, RESO FIXED, Automatic MUC rejoins don't always work 19:20:33 <clokep_work> aleth: K thx. 19:24:37 <aleth> arlolra: I'd say go the notification route. 19:24:53 <aleth> flo-retina: clokep_work? 19:25:12 * clokep_work can't think of a better solution. 19:25:26 <aleth> least hackish, costs nothing extra per message. 19:25:48 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:25:58 <flo-retina> aleth: are there complications related to log splitting? (nhnt11^) 19:26:29 <aleth> potentially yes, but if arlolra is quick he can land his patch before nhnt11 lands his :P 19:28:27 <arlolra> hmm, reading the logging code, it looks like if i disable logging while a conversation is already started, it'll happily continue to log that conversation 19:30:49 <-- afiksof has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 19:31:33 <arlolra> gLogWritersById should be cleared when the pref changes 19:31:39 <arlolra> nhnt11: ^ 19:31:50 <arlolra> should I submit a patch for that? 19:39:22 * nhnt11 reads everything 19:39:47 * arlolra is working on the patch 19:40:20 <aleth> well, you don't want logger.js to deal with any pref. You just add another notification to the observe method 19:40:54 <nhnt11> aleth: logger.js already checks the pref when creating a new logwriter 19:40:56 <flo-retina> aleth: I think arlolra is talking about the existing prefs 19:41:06 <nhnt11> I think it's reasonable to observe that pref 19:41:23 <nhnt11> arlolra: r? me on the patch :) 19:41:27 <arlolra> k 19:41:50 <aleth> nhnt11: the pref is for logging overall and not for turning logging on/off per-conversation 19:41:56 <flo-retina> arlolra said that one of the reason for wanting to not log OTR convs is that logging is enabled by defualt possibly without the user knowing 19:42:28 <nhnt11> aleth: I know. The current code doesn't close existing log writers if that pref changes 19:42:31 <flo-retina> one thing I've been considering doing about that for a while is to disable logging by default, but log in memory, and display a system message at the top of conversations taht aren't logged, prompting the user to tweak the settings if they want to keep a record of the conv 19:42:34 <nhnt11> which is what arlo is writing a patch for now 19:43:12 <aleth> nhnt11: you can have simultaneously conversations with OTR and ones without 19:43:27 <aleth> even within a single conversation, you can turn OTR mode on and off 19:43:40 <nhnt11> aleth: the thing arlo is working on is not OTR related, it's an improvement to the current codee 19:43:44 <nhnt11> as far as I understood 19:43:46 <arlolra> yes 19:43:52 <aleth> Sure 19:44:08 <aleth> logger.js shouldn't know about OTR. 19:44:15 <nhnt11> agreed 19:44:20 <arlolra> it won't 19:44:24 <arlolra> there's 2 patches here 19:44:41 <aleth> ok 19:45:10 * nhnt11 thinks a flag on the conversation would be fine. 19:53:24 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 19:57:28 <freaktechnik> clokep_work: haven't had instantbird crash since I removed my icq account. 20:01:21 --> AlexanderSalas has joined #instantbird 20:07:07 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 20:07:35 --> gerard-majax has joined #instantbird 20:10:28 <-- arlolra has quit (Client exited) 20:10:37 --> arlolra has joined #instantbird 20:17:30 <-- AlexanderSalas has quit (Ping timeout: 121 seconds) 20:19:33 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:23:33 <-- clokep_work has quit (Ping timeout: 121 seconds) 20:33:11 * Fallen is now known as Fallen|away 20:37:03 --> EionRobb has joined #instantbird 20:40:25 <-- Widdershins has quit (Connection closed) 20:44:13 --> AlexanderSalas has joined #instantbird 20:45:02 --> Widdershins has joined #instantbird 21:06:24 <-- arlolra has quit (Client exited) 21:06:36 --> arlolra has joined #instantbird 21:07:48 <-- nhnt11 has quit (Ping timeout: 121 seconds) 21:12:28 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:30:35 <instantbot> New Instantbird - Preferences bug 1175706 filed by arlolra@gmail.com. 21:30:36 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1175706 nor, --, ---, nobody, UNCO, Listen for logging pref changes 21:35:47 <-- aleth has quit (Quit: :tiuQ) 21:42:51 --> nhnt11 has joined #instantbird 21:42:51 * ChanServ sets mode +h nhnt11 21:43:04 <-- nhnt11 has quit (Connection closed) 21:43:05 --> nhnt11 has joined #instantbird 21:43:05 * ChanServ sets mode +h nhnt11 21:44:47 <-- Mnyromyr has quit (Connection closed) 21:45:45 <nhnt11> arlolra: What's the reason for your changes to the appendtoFile function? 21:46:02 <arlolra> it's based on the conversation start time 21:46:26 <arlolra> so if you start the conversation with logging enabled 21:46:30 <arlolra> disable 21:46:35 <arlolra> then re-enabled 21:46:45 <arlolra> it errs that the file already exists 21:48:07 <nhnt11> arlolra: It should be opening a new file, afaik 21:48:18 <nhnt11> hmmm 21:48:21 <nhnt11> I get what you're saying 21:48:21 <arlolra> same filename 21:48:44 <flo-retina> nhnt11: how does that interact with log splitting? 21:49:20 <nhnt11> flo-retina: I'll have to figure it out. 21:49:32 <nhnt11> This issue crops up because of Arlo's pref observing stuff 21:49:58 * nhnt11 is looking at the split logs patch 21:50:41 <arlolra> i'm also wondering how i'm going to get the logger to stay disabled going the notification route. if i've swapped in a dummy and someone flips the pref twice 21:51:27 <nhnt11> split logs adds a startTime parameter to getLogFileNameForConversation. 21:51:45 <nhnt11> But the constructor still uses the conv's startDate. 21:52:26 --> Bollebib has joined #instantbird 21:52:33 <nhnt11> arlolra: "stay disabled"? 21:52:45 <nhnt11> If they flip the pref twice, the dummy will be removed, will it not? 21:52:55 <arlolra> right 21:53:13 <arlolra> so say in the otr code, i emit an event to disable logging for a conversation 21:53:22 <flo-retina> arlolra: so what's the status of building libotr? 21:53:41 <flo-retina> logging or not logging seems a trivial detail compared to actually having the library built in 21:54:25 <arlolra> flipping the pref shouldn't clear that 21:54:32 <arlolra> flo-retina: hmm 21:54:40 <arlolra> you're right 21:54:46 <arlolra> i should be working on that instead 21:54:58 <nhnt11> arlolra: flipping the pref will unset the logger from the Map. Doesn't mean that it will open a new log writer next time a message is received. 21:57:24 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 21:57:39 <nhnt11> By the way, did anyone else see an article about Diffie-Hellman being compromised somehow? 21:57:43 <nhnt11> I recall reading something... 21:58:44 --> aleth has joined #instantbird 21:58:44 * ChanServ sets mode +o aleth 21:58:49 <nhnt11> https://weakdh.org/imperfect-forward-secrecy.pdf 21:59:54 * nhnt11 didn't bother reading that whole thing but registered clearly "We investigate the security of Diffie-Hellman [...] and find it to be less secure than widely believed." 22:00:33 <arlolra> up to 1024 bit DH over a finite field is subject to some precomputation attack 22:00:46 <arlolra> by a nation state 22:01:19 <nhnt11> flo-retina: Can we get rid of txt logs? 22:01:28 <nhnt11> Not reading, but writing 22:01:33 <arlolra> currently, libotr use 1536 22:01:39 <nhnt11> Er, s/Can/Do we want to/ 22:01:51 <nhnt11> arlolra: cool 22:02:53 <aleth> can we land those pending patches before adding/removing more stuff? ;) 22:03:10 <flo-retina> nhnt11: it's not like we have ever been able to read them ;) 22:03:22 <nhnt11> flo-retina: Really? :O 22:03:27 * nhnt11 thought we displayed them "as is" 22:03:31 <flo-retina> right 22:03:37 <flo-retina> we just throw them as is into the user's face 22:03:43 <nhnt11> yeah 22:04:12 <nhnt11> I'm now wondering if LogWriters even obey that logging format pref :S 22:04:30 <flo-retina> I think they do 22:04:37 <nhnt11> Yeah they do 22:04:38 <nhnt11> bah 22:04:39 <nhnt11> ok 22:04:44 <flo-retina> I won't r- a patch removing plain text log writing 22:04:54 <flo-retina> but I'm way more interested in splitting and indexing 22:04:55 <aleth> I don't think we should support on-the-fly changes of that format pref, if that's what you're asking 22:04:57 <nhnt11> another bug for that though 22:05:18 <nhnt11> aleth: That's the context in which I was asking yeah 22:05:51 <aleth> it's just asking for trouble 22:06:40 <nhnt11> I'm wondering if it'll lead to weird issues with the filename 22:07:03 <nhnt11> especially that we are "continuing" the existing log file in the case where the conversation starts with logging enabled, and the user toggles the pref twice. 22:07:25 <aleth> anyone who really wants to change that can and will restart 22:07:41 * nhnt11 feels like that would need tests. 22:08:41 * nhnt11 feels like this needs tests in any case. 22:09:06 <aleth> yeah 22:10:11 * flo-retina wonders if libotr has basic tests we could run to ensure it works right 22:10:37 <aleth> that would be helpful for the switch to NSS 22:17:59 <-- akronix has quit (Quit: Leaving.) 22:21:31 --> freaktechnik_ has joined #instantbird 22:23:11 <nhnt11> arlolra: I just realized your aCreateIfNeeded is unnecessary. 22:23:25 <nhnt11> I believe OS.File.open works if the file doesn't already exist. 22:23:52 <nhnt11> That create parameter is there to ensure that an error it thrown when trying to open an existing file, to prevent weird things from happening. 22:24:00 <-- freaktechnik has quit (Ping timeout: 121 seconds) 22:24:01 * freaktechnik_ is now known as freaktechnik 22:24:48 <nhnt11> I don't like continuing a log in the same file after closing the log writer :-/ 22:24:58 <nhnt11> this would be much easier to do once we have split logs 22:26:30 <arlolra> flo-retina: yes, libotr has a test suite 22:26:37 --> akronix has joined #instantbird 22:27:23 <arlolra> nhnt11: ok, no rush on it 22:28:55 <flo-retina> nhnt11: why don't we have split logs again? 22:29:33 <nhnt11> flo-retina: Because after unbitrotting it I haven't built Instantbird. 22:29:40 <nhnt11> I would like to test it at least once before landing it 22:29:48 <nhnt11> I can probably land it tonight 22:29:53 <flo-retina> so it seems fixable within less than an hour? 22:30:01 <nhnt11> It doesn't have r+ though, which makes me nervous 22:30:07 <flo-retina> hmm 22:30:37 <flo-retina> ah, "I'll re-request review after bug 1103647 lands." 22:30:39 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1103647 maj, --, Thunderbird 38.0, nhnt11, RESO FIXED, Chat logs no longer being indexed by gloda 22:30:58 <nhnt11> flo-retina: The patch right before patch v6 was r+ 22:31:18 <nhnt11> that's why the lack of r+ only makes me a little "nervous" 22:31:36 <flo-retina> v6 is like 11kB more than the previous one :-S 22:31:45 <flo-retina> is that just due to making a diff with more context or something? 22:31:56 <nhnt11> flo-retina: It patches gloda 22:32:13 <nhnt11> that's cause for nervousness if you ask me :P 22:32:40 <flo-retina> I probably don't want to review it then :-P 22:33:11 <flo-retina> the next TB won't be released before months though :) 22:34:02 <aleth> the gloda code is in a better state now than when you wrote the patch though, so you should be less nervous than you were at the time ;) 22:34:18 <nhnt11> true 22:35:20 <flo-retina> aleth: turns out people are only nervous after having been burnt once, not when they are about to actually get burnt ;) 22:35:49 <nhnt11> it's an adaptive algorithm :P 22:46:24 --> MattATobin has joined #instantbird 22:49:18 <-- Tobin has quit (Ping timeout: 121 seconds) 22:57:52 <-- akronix has quit (Quit: Leaving.) 22:58:33 <-- aleth has quit (Quit: :tiuQ) 23:03:06 --> tmowizard has joined #instantbird 23:03:21 <-- tmowizard has left #instantbird ("") 23:04:06 --> mpmc has joined #instantbird 23:59:39 --> clokep has joined #instantbird 23:59:39 * ChanServ sets mode +o clokep