#instantbird log on 06 07 2015

All times are UTC.

00:22:59 <-- abdelrhman has quit (Quit: Leaving)
00:25:09 <-- nhnt11 has quit (Ping timeout: 121 seconds)
00:36:48 <-- Bollebib has quit (Connection closed)
00:49:08 --> EionRobb has joined #instantbird
01:07:50 <-- Yoric has quit (Connection reset by peer)
02:01:04 --> AlexanderSalas has joined #instantbird
02:11:37 <instant-buildbot> build #1419 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1419
02:11:45 <instant-buildbot> build #332 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/332
02:12:25 <-- Mnyromyr has quit (Connection closed)
02:33:47 <instant-buildbot> build #2697 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2697
03:26:24 <-- AlexanderSalas has quit (Ping timeout: 121 seconds)
03:45:47 --> nhnt11 has joined #instantbird
03:45:47 * ChanServ sets mode +h nhnt11 
04:14:47 --> AlexanderSalas has joined #instantbird
04:25:57 <-- nhnt11 has quit (Ping timeout: 121 seconds)
04:34:27 --> Widdershins has joined #instantbird
04:38:15 --> nhnt11 has joined #instantbird
04:38:15 * ChanServ sets mode +h nhnt11 
04:42:18 <-- nhnt11 has quit (Ping timeout: 121 seconds)
04:46:26 --> nhnt11 has joined #instantbird
04:46:26 * ChanServ sets mode +h nhnt11 
04:48:39 * nhnt11 is un-bitrotting split logs
05:19:01 --> afiksof has joined #instantbird
05:20:12 <-- nhnt11 has quit (Connection closed)
05:20:14 --> nhnt11 has joined #instantbird
05:20:14 * ChanServ sets mode +h nhnt11 
06:15:30 --> mpmc has joined #instantbird
06:36:51 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:42:13 --> nhnt11-testing has joined #instantbird
06:42:57 <-- nhnt11-testing has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:56:20 <-- nhnt11 has quit (Ping timeout: 121 seconds)
07:21:38 <-- afiksof has quit (Ping timeout: 121 seconds)
07:56:24 --> mikk_s has joined #instantbird
08:27:20 --> Bollebib has joined #instantbird
08:57:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
10:29:16 <-- EionRobb has quit (Quit: Leaving.)
10:32:58 --> Yoric has joined #instantbird
10:39:29 --> AlexanderSalas has joined #instantbird
10:42:47 <AlexanderSalas> Hi everyone
10:42:56 <AlexanderSalas> I'm working with OAuth
10:43:01 <AlexanderSalas> I have a question
10:43:54 <AlexanderSalas> Can I store the Token in the LoginManager or I need refresh the token on every connection?
10:45:37 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:32:53 --> afiksof has joined #instantbird
11:47:30 <-- BWMerlin has quit (Client exited)
12:01:41 --> Mnyromyr has joined #instantbird
12:37:13 --> clokep has joined #instantbird
12:37:13 * ChanServ sets mode +o clokep 
13:05:54 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:19:18 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:21:58 --> clokep has joined #instantbird
13:21:58 * ChanServ sets mode +o clokep 
13:33:45 --> abdelrhman has joined #instantbird
14:03:01 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
15:17:49 <-- abdelrhman has quit (Ping timeout: 121 seconds)
15:18:30 --> abdelrhman has joined #instantbird
15:23:20 <-- abdelrhman has quit (Ping timeout: 121 seconds)
15:56:29 --> abdelrhman has joined #instantbird
17:02:52 <-- Widdershins has quit (Ping timeout: 121 seconds)
17:03:53 --> mpmc has joined #instantbird
17:29:07 --> aleth has joined #instantbird
17:29:08 * ChanServ sets mode +o aleth 
17:36:35 <-- abdelrhman has quit (Ping timeout: 121 seconds)
17:41:09 --> abdelrhman has joined #instantbird
17:45:37 <-- abdelrhman has quit (Ping timeout: 121 seconds)
18:05:55 <clokep> aleth: Theoretically you can likely change an IRC topic even if you're not in the channel. ;)
18:07:54 <clokep> (We likely don't care.)
18:09:48 <aleth> Actually you get a 442 error ;)
18:10:32 <aleth> Hmm, there's actually a bug there.
18:12:07 <-- aleth has left #instantbird ()
18:12:09 --> aleth has joined #instantbird
18:12:09 * ChanServ sets mode +o aleth 
18:14:18 <aleth> or maybe not, I can't reproduce it
18:14:48 <-- aleth has quit (Quit: :tiuQ)
18:15:20 <clokep> Haha.
18:20:14 --> abdelrhman has joined #instantbird
18:23:27 --> unghost has joined #instantbird
18:26:42 <-- abdelrhman has quit (Ping timeout: 121 seconds)
18:32:20 --> abdelrhman has joined #instantbird
18:33:10 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
18:36:22 <-- abdelrhman has quit (Ping timeout: 121 seconds)
18:36:48 --> abdelrhman has joined #instantbird
18:50:06 --> chrisccoulson has joined #instantbird
19:02:22 --> aleth has joined #instantbird
19:02:23 * ChanServ sets mode +o aleth 
19:05:19 <-- abdelrhman has quit (Ping timeout: 121 seconds)
19:07:04 --> abdelrhman has joined #instantbird
19:10:03 <abdelrhman> aleth: for topicSettable in our case will always return true and in conversation.xml will check left flag and this means we need to notify the UI after every change in left flag
19:10:25 <abdelrhman> not topicSettable, right?
19:10:31 <aleth> abdelrhman: yes, but don't worry, the UI is already notified.
19:11:52 <abdelrhman> so we need to notify that topicSettable is changed using notifyObservers(..., "chat-update-topic");
19:11:54 <aleth> https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1841
19:12:07 <abdelrhman> can we add that with constructor of conversation?
19:12:13 <aleth> You don't have to send any extra notifications
19:12:41 <aleth> especially as topicSettable will always be true ;)
19:13:54 <aleth> It's just a matter of modifying what happens when the relevant notifications are observed.
19:16:34 <aleth> You're basically proposing updateTopic() should take the left flag into account, not just topicSettable.
19:17:07 <clokep> I'd really like it if we rendered links as links...we should do that some day too.
19:17:14 <clokep> A bit outside of the XMPP realm, but hey.
19:17:16 <aleth> Yeah.
19:17:19 <aleth> Also, much harder ;)
19:17:25 <abdelrhman> yes, that I meant
19:17:41 <aleth> Would be nice though!
19:19:30 <aleth> abdelrhman: https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1916, in case you haven't found it yet
19:20:14 <aleth> By the way, please put the conversation.xml changes in a separate bug, if you fix this, as it's a UI bug, not an XMPP bug :-)
19:20:29 <abdelrhman> I added it, but I face a problem after modifying that. that sometimes topic is editable while testing
19:20:39 <-- afiksof has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
19:20:52 <aleth> How did you modify it?
19:21:20 <abdelrhman> https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1469
19:21:33 <aleth> That's not a pastebin
19:21:46 <abdelrhman> added checking for left flag (... && !this._conv.left)
19:21:47 <aleth> we know what the current code does ;)
19:22:31 <abdelrhman> so every time left flag changes need to use notify for that, to allow editing in case of true
19:22:45 <aleth> the conversation is already notified when the left flag changes
19:24:18 <aleth> I gave you a link to the observer earlier
19:24:36 <abdelrhman> I know, but I wonder from this behavior.
19:24:58 <aleth> You'll have to change the observer to call updateTopic when the left flag changes
19:25:43 <aleth> Otherwise of course nothing will change when you /part
19:30:27 <abdelrhman> ah, I got it :-) thanks aleth
19:39:17 <-- abdelrhman has quit (Ping timeout: 121 seconds)
19:39:45 --> abdelrhman has joined #instantbird
19:41:09 <-- aleth has quit (Quit: :tiuQ)
19:44:22 <-- abdelrhman has quit (Ping timeout: 121 seconds)
19:46:18 --> abdelrhman has joined #instantbird
20:09:27 <instantbot> New Chat Core - XMPP bug 1172350 filed by a.ahmed1026@gmail.com.
20:09:28 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172350 nor, --, ---, nobody, NEW, Implement Service Discovery Extensions (XEP-0128)
20:19:52 <instantbot> New Chat Core - XMPP bug 1172352 filed by a.ahmed1026@gmail.com.
20:19:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172352 nor, --, ---, nobody, NEW, Handle topicSettable according to configuration obtained by Service Discovery Extensions for a room
20:29:46 <instantbot> New Instantbird - Conversation bug 1172353 filed by a.ahmed1026@gmail.com.
20:29:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172353 nor, --, ---, nobody, NEW, Use left flag in checking of updateTopic method in conversation.xml
20:44:58 <abdelrhman> clokep: for next xmpp command which is better bug for each command, or bug for all commands?
20:45:17 <clokep> abdelrhman: Depends how related they are, in my opinion.
20:47:05 <abdelrhman> ok
20:47:13 <clokep> abdelrhman: What did you want to add?
20:47:54 <abdelrhman> clokep: ban, kick, invite, msg, nick
20:48:13 <clokep> abdelrhman: If you think you can do them all in one then go for it. ;)
20:48:24 <clokep> But if they start getting too complicated, I'd suggest splitting them out.
20:49:13 <abdelrhman> clokep: no :-) I just want to open bugs for them :D
20:49:36 <clokep> abdelrhman: Open a single bug.
20:49:43 <clokep> If someone starts doing work they can split it out to more if they want.
20:49:55 <abdelrhman> ok, thanks clokep :)
20:50:06 <clokep> Yep! :)
20:50:10 <clokep> Do you need a review by me still?
20:51:31 <abdelrhman> As you like.
20:54:51 <instantbot> New Chat Core - XMPP bug 1172354 filed by a.ahmed1026@gmail.com.
20:54:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172354 nor, --, ---, nobody, NEW, Add ban, kick, invite, msg, nick commands for XMPP MUCs
20:56:22 <clokep> wasn't sure if aleth fulfilled your needs or not.
20:57:46 --> EionRobb has joined #instantbird
20:58:43 <instantbot> New Chat Core - XMPP bug 1172355 filed by a.ahmed1026@gmail.com.
20:58:44 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172355 nor, --, ---, nobody, NEW, Add system messages when someone joins or leaves a room
20:59:20 <clokep> ;)
20:59:22 <clokep> :)
21:00:21 <abdelrhman> I think yes he fulfilled them. but if you think anything can be added or corrected just tell me :)
21:10:22 <clokep> Done.
21:12:18 <abdelrhman> thanks :-)
21:15:24 <abdelrhman> clokep: do you mean with "here", the end of the file?
21:16:00 <clokep> abdelrhman: I mean in commands.
21:17:15 <abdelrhman> ah, to allow localization also for commands ;)
21:18:09 <clokep> No.
21:18:15 <clokep> Because the commands *aren't* localizable.
21:18:23 <clokep> Even on different languages it's still /join
21:18:33 <clokep> So we don't want to let a translator mistakenly translate "join" to something else.
21:18:48 <abdelrhman> ah
21:20:12 <clokep> Make sense? :)
21:20:16 <clokep> Check how the IRC ones are done.
21:20:37 <abdelrhman> yes.
21:20:45 <abdelrhman> you are right
21:21:21 <clokep> Sorry I missed this last time. :-\
21:22:20 <abdelrhman> no problem, but that's good you noticed it early ;)
21:25:02 <clokep> abdelrhman: I'd say definitely fix it for the string you're adding.
21:25:09 <clokep> We should likely fix it for th eold ones too, but in a separate bug.
21:26:45 <abdelrhman> currently, I fixed it in same patch. ok, I'll move them to new patch
21:26:50 <clokep> That's fine then.
21:26:57 <clokep> JUst didn't want to cause more work for you.
21:27:11 <abdelrhman> no problem :)
21:33:29 <-- Mnyromyr has quit (Quit: ChatZilla [SeaMonkey 2.33.1/20150321194827])
21:35:06 <instantbot> New Chat Core - XMPP bug 1172360 filed by a.ahmed1026@gmail.com.
21:35:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172360 nor, --, ---, nobody, NEW, Handle in _parseJID if domain is not provided
21:38:17 <instantbot> New Chat Core - XMPP bug 1172361 filed by a.ahmed1026@gmail.com.
21:38:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1172361 nor, --, ---, nobody, NEW, Change localiztion of xmpp commands
21:54:57 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:00:35 <-- clokep has quit (Connection closed)
22:00:43 --> clokep has joined #instantbird
22:00:43 * ChanServ sets mode +o clokep 
22:05:03 --> EionRobb1 has joined #instantbird
22:05:35 <-- EionRobb has quit (Ping timeout: 121 seconds)
22:16:18 --> aleth-mac has joined #instantbird
22:16:29 <aleth-mac> Wow, abdelrhman has been busy :-)
22:17:02 <abdelrhman> :D
22:20:13 <clokep> aleth-mac: got mail bombed. ;)
22:20:25 <-- aleth-mac has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:20:30 --> aleth has joined #instantbird
22:20:31 * ChanServ sets mode +o aleth 
22:21:58 --> myk has joined #instantbird
22:36:00 <clokep> aleth: So do we have any idea about the current bustage?
22:36:02 <clokep> On Mac at least....
22:39:13 <abdelrhman> because of me!, I'm sorry for that :/
22:39:45 <clokep> No.
22:39:48 <clokep> Not because of you?
22:40:49 <abdelrhman> :) I thought you got a lot of emails because of bugs I opened.
22:41:46 <aleth> Not sure why xmlOnceInit has disappeared...
22:42:45 <clokep> aleth: My *guess* is that threads are magically enabled somehow.
22:43:01 <aleth> there's clearly some magic which has broken
22:43:29 <aleth> I got as far as checking that LIBXML_THREAD_ENABLED is never set
22:45:56 <clokep> aleth: Comparing http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2684 and http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2697 now
22:46:49 <clokep> I don't see anything about threads.c in the passing build.
22:48:29 <clokep> Although looks like it's always been built so...
22:49:25 <clokep> aleth: My guess is that HAVE_PTHREAD_H is now true.
22:49:28 <clokep> http://hg.mozilla.org/users/florian_queze.net/purple/file/d0ee48a13a15/libraries/xml2/threads.c#l651
22:49:53 <aleth> I wonder if $(THREADSCFLAGS) has changed somehow
22:51:03 <aleth> clokep: it has to be true for there to be an error, but I don't see why it is set
22:56:54 <clokep> Huh.
22:57:04 <clokep> HAVE_PTHREAD_H seems to only be set to try in media/?
22:57:07 <clokep> Dafuq.
22:58:22 <aleth> there's https://dxr.mozilla.org/mozilla-central/source/memory/jemalloc/src/configure#6685 but that hasn't changed recently
23:01:13 <clokep> m-c has protobuf in it now? https://dxr.mozilla.org/mozilla-central/source/toolkit/components/protobuf (o_O)
23:01:32 <clokep> Apparently it has for over 2 years...
23:02:10 <aleth> huh
23:03:10 <aleth> what's using it?
23:07:06 <clokep> Initially imported in bug 812238
23:07:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=812238 nor, --, mozilla20, mmc.bugzilla, RESO FIXED, import protocol buffer library
23:07:36 <aleth> Ah, the google malware blocker
23:07:39 <clokep> https://bugzilla.mozilla.org/show_bug.cgi?id=812238#c3
23:07:41 <clokep> Yep.
23:21:00 <clokep> Anyway, that doesn't help us understand what's going on..
23:25:23 <aleth> I'm out of ideas at the moment
23:25:31 <aleth> or at least tired
23:26:35 <clokep> Well I think we successfully ruled out the asy things.
23:26:35 <clokep> easy
23:28:23 <aleth> Does mozregression work with Instantbird?
23:29:45 <aleth> probably doing a bisect is just as quick/slow anyway
23:36:48 <clokep> I've done hg bisects before.
23:36:54 <clokep> There's a lot of changesets. :-\
23:37:02 <clokep> Well I guesswe could do it just between the good and failure one?
23:37:05 <clokep> I'll try to set that up in a minute.
23:39:22 <aleth> If you've got another movie to watch while it runs ;)
23:48:08 <-- aleth has quit (Quit: :tiuQ)
23:52:18 --> clokep_work has joined #instantbird
23:52:19 * ChanServ sets mode +o clokep_work