#instantbird log on 04 22 2015

All times are UTC.

00:01:52 --> arlolra has joined #instantbird
00:01:55 <-- arlolra has quit (Client exited)
00:07:20 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:07:28 <-- chrisccoulson has quit (Connection closed)
00:09:09 --> Widdershins has joined #instantbird
00:50:08 <-- myk has quit (Ping timeout: 121 seconds)
02:12:33 <instant-buildbot> build #285 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/285
02:12:34 <instant-buildbot> build #1373 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1373
02:16:24 <instant-buildbot> build #2632 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2632
02:33:19 --> AlexanderSalas has joined #instantbird
05:19:22 <-- EionRobb has quit (Quit: Leaving.)
06:13:16 --> EionRobb has joined #instantbird
06:18:05 --> qheaden has joined #instantbird
06:18:11 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:54:01 --> myk has joined #instantbird
07:06:08 <-- myk has quit (Ping timeout: 121 seconds)
07:31:37 --> Bollebib has joined #instantbird
07:47:37 * Fallen|away is now known as Fallen 
07:54:04 --> myk has joined #instantbird
08:12:23 --> chrisccoulson has joined #instantbird
08:15:50 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
08:48:26 <-- myk has quit (Ping timeout: 121 seconds)
08:51:46 --> Bollebib has joined #instantbird
08:54:53 --> aleth has joined #instantbird
08:54:53 * ChanServ sets mode +o aleth 
08:55:19 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:34:15 --> flo-retina has joined #instantbird
09:34:15 * ChanServ sets mode +qo flo-retina flo-retina 
09:59:44 --> BWMerlin has joined #instantbird
10:17:39 --> clokep has joined #instantbird
10:17:40 * ChanServ sets mode +o clokep 
10:47:51 <clokep> Hmm....Facebook Chat seems to still be working.
10:49:36 <EionRobb> neat
10:52:57 <flo-retina> clokep: and Google Talk too ;)
10:55:02 <clokep> flo-retina: I'm unsure which to be more surprised about. :P
10:55:22 <flo-retina> I would be surprised about MSN :)
10:56:15 <clokep> Ahhhh April 30th, not April 20th.
10:57:20 <clokep> PS I always find it weird that they call it the "XMPP API" at Facebook.
11:05:46 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:32:32 --> mpmc has joined #instantbird
11:54:22 --> clokep_work has joined #instantbird
11:54:22 * ChanServ sets mode +o clokep_work 
12:06:38 <-- EionRobb has quit (Quit: Leaving.)
12:16:51 --> qheaden has joined #instantbird
12:38:58 <-- BWMerlin has quit (Client exited)
12:41:50 * Tobin is now known as MattATobin 
13:05:15 <-- AlexanderSalas has quit (Connection closed)
13:07:46 --> sherief has joined #instantbird
13:10:41 --> AlexanderSalas has joined #instantbird
14:06:48 * Fallen is now known as Fallen|away 
14:15:02 --> AlexanderSalas1 has joined #instantbird
14:18:25 <-- AlexanderSalas has quit (Ping timeout: 121 seconds)
14:38:32 <-- AlexanderSalas1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:57:35 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
14:57:39 --> chrisccoulson has joined #instantbird
15:12:55 --> Widders has joined #instantbird
15:15:53 <-- Widdershins has quit (Ping timeout: 121 seconds)
15:35:00 --> arlolra has joined #instantbird
15:37:53 <-- Widders has quit (Ping timeout: 121 seconds)
15:39:24 --> myk has joined #instantbird
16:00:33 <-- qheaden has quit (A TLS packet with unexpected length was received.)
16:24:39 <aleth> clokep_work: I think watchLength is always NaN because it's never initialized before being incremented...
16:25:08 <clokep_work> :-D
16:25:11 <clokep_work> That's clever of us.
16:25:32 <aleth> now we know what undefined + 10 is ;)
16:26:32 <clokep_work> :)
16:26:35 <flo-retina> :)
16:30:15 <clokep_work> Who's filing the bug? :P
16:30:29 <aleth> flo-retina has a debug log ;)
16:31:41 <aleth> clokep_work: of course, if watchLength was a number it would still fail, just with a friendlier warning printed first, like you said
16:31:43 * flo-retina _had_ a debug log
16:43:25 --> mconley_ has joined #instantbird
16:44:24 * mconley_ is now known as mconley|livehacking 
16:59:10 --> mikk_s has joined #instantbird
17:05:49 <aleth> sherief: I can't find the bug you filed for your textbox problem. do you have your xpi somewhere?
17:07:20 <sherief> aleth: I didn't create any tickets but I can send you and email that includes everything
17:07:32 <sherief> pm your email please
17:07:38 <aleth> sherief: OK
17:07:49 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
17:17:52 <clokep_work> flo-retina: http://mail.jabber.org/pipermail/standards/2015-April/029781.html
17:19:06 <flo-retina> :)
17:21:53 --> sukhe has joined #instantbird
17:29:06 <aleth> since when has connecting to twitter produced a SHA-1 weak cert warning?
17:32:22 <clokep_work> Always? :-D
17:32:25 <clokep_work> I don't know. :(
17:32:28 <clokep_work> Probably witht he changes to m-c.
17:39:33 <aleth> We should have nightlies tomorrow.
17:41:43 <flo-retina> :)
17:41:55 <flo-retina> _our_ cert no longer causes SHA1 warnings btw
17:45:42 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:16:27 <aleth> So I helped sherief diagnose his l10n textbox problem, looks like there's some ar strings missing in m-c, m-a and m-b
18:16:47 <sherief> sukhe: ^
18:16:53 <sherief> arlolra: ^
18:17:13 <sherief> Thanks aleth!
18:17:25 <arlolra> :)
18:17:39 <sukhe> is it resolved/
18:18:00 <sherief> the revision (38) is in beta
18:18:15 <sherief> not sure how to pull it and generate an xpi with it
18:18:51 <aleth> sherief: you don't have to worry about 38, they need to land the string in the m-c repo too anyway
18:19:30 <aleth> Ask on #l10n about m-c localisation and how it works, and flo-retina should be able to tell you later how to patch the string locally for IB
18:19:44 <aleth> Of course the FX ar localizers should be worrying about 38 ;)
18:22:40 <aleth> sherief: Are you using l10n-central/ar to build the xpi?
18:23:12 <sherief> aleth: https://wiki.instantbird.org/Instantbird:Creating_a_new_localization_%28Mercurial%29#Get_the_locale_files
18:23:19 <sherief> yup
18:23:39 <aleth> OK, then hopefully you could just make the changes to those files locally before building your xpi
18:25:20 <aleth> Patch up textcontext.dtd and extensions.dtd and see if that fixes things.
18:26:59 <sherief> working on it atm
18:33:02 <-- mconley|livehacking has quit (Quit: NO CARRIER)
18:36:53 <sherief> aleth: adding <!ENTITY searchTextBox.clear.label "Clear"> to m-c's textcontext.dtd fixed the textboxes bug
18:36:59 <aleth> :-)
18:37:08 <sherief> I can't believe it was so trivial
18:37:15 <sherief> aleth: Thanks a bunch!
18:37:23 <aleth> It's usually trivial ... once you figure it out ;)
18:37:35 <sherief> :D
18:37:48 <sukhe> thanks aleth!
19:22:37 --> Mnyromyr has joined #instantbird
19:30:00 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:31:04 <-- clokep_work has quit (Ping timeout: 121 seconds)
20:31:09 <-- sherief has quit (Ping timeout: 121 seconds)
20:39:58 <-- arlolra has quit (Client exited)
20:50:40 --> EionRobb has joined #instantbird
21:21:01 <-- myk has quit (Ping timeout: 121 seconds)
21:25:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
21:31:02 --> chrisccoulson has joined #instantbird
21:36:43 --> arlolra has joined #instantbird
22:06:55 --> myk has joined #instantbird
22:16:52 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:34:20 <-- Mnyromyr has quit (Connection closed)
22:34:58 <nhnt11> aleth: Not sure if you remember, but I think I actually replied to your review comments on IRC (which sucks that I didn't post them on the bug)
22:35:03 <nhnt11> I'm posting on the bug now.
22:36:14 <nhnt11> http://log.bezut.info/instantbird/150404/#m307
22:36:55 <-- aleth has quit (Quit: :tiuQ)
22:37:15 --> aleth has joined #instantbird
22:37:16 * ChanServ sets mode +o aleth 
22:42:14 <nhnt11> aleth: Okay, so the current patch in that bug is nearly finished by the look of it, and fixes the issue in the bug description. It can probably be checked in with a couple more review iterations.
22:42:33 <aleth> Yup.
22:42:43 <nhnt11> If you think nuking the database might lead to trouble with bug 1146698, it might be better to just get the current patch finished up and check it in
22:42:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1146698 nor, --, ---, nobody, NEW, Chat Messages added to logs just before shutdown may not be indexed by gloda
22:43:32 <aleth> If the current patch is almost done, then that seems the best way forward.
22:43:47 <nhnt11> I'm not saying we should totally forget nuking, just that we should probably get the current patch done first
22:43:48 <nhnt11> Cool.
22:44:30 <aleth> As you now know how to send sql queries to the gloda dbm bug 1146698 might be doable too for 38 for you (it basically requires writing a function that looks up the id given the path)
22:44:45 <nhnt11> Yes.
22:45:18 <aleth> At that point we'll at least not be faced with missing data anymore :-)
22:45:56 <nhnt11> aleth: Can you try the current patch in bug 1135291 and confirm that the version flag isn't getting written to the cache file?
22:45:59 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1135291 nor, --, ---, nhnt11, NEW, Re-index chat log files since bug 955292
22:46:12 <aleth> nhnt11: I did try it
22:46:26 <aleth> That's why I wrote the review comment ;)
22:46:33 <nhnt11> Right, that was on the other day, right?
22:46:43 <nhnt11> From the conversation we had, it was working for me and not for you
22:46:47 <nhnt11> which is super weird
22:46:48 <aleth> I'm not sure my presumed explanation was correct
22:47:11 <nhnt11> That the cache save is never written?
22:47:22 <aleth> no, that it's due to your cacheSaveTimer = 1 line
22:47:31 <nhnt11> I answered that btw
22:47:32 <nhnt11> http://log.bezut.info/instantbird/150404/#m307
22:47:40 <aleth> Ah ight
22:47:49 <nhnt11> The clearBadEntries function calls saveCacheNow, which cleares the timer
22:48:09 <aleth> Maybe if you build it now, you can reproduce?
22:48:09 <nhnt11> Well, sets it to null.
22:48:22 <nhnt11> A clobber build is running as we speak
22:48:24 <nhnt11> should take another 5 mintues
22:48:26 <nhnt11> minutes*
22:48:36 * aleth hopes he still has a copy of the bad profile
22:49:31 <nhnt11> aleth: I actually resorted to manually adding bad entries after I "lost" my bad profile :]
22:58:58 --> nhnt11-tb has joined #instantbird
23:12:27 <-- nhnt11-tb has quit (Client exited)
23:12:45 --> nhnt11-tb has joined #instantbird
23:13:55 <nhnt11> aleth: Seems you're right. I don't see a version in my cache file
23:14:05 <nhnt11> But I dumped the version in saveCacheNow, and it's equal to 1 (expected)
23:14:11 <nhnt11> weird... :-/
23:14:14 <aleth> OK good, so at least you can reproduce
23:14:28 <-- nhnt11-tb has quit (A TLS packet with unexpected length was received.)
23:14:45 --> nhnt11-tb has joined #instantbird
23:16:19 <nhnt11> Interesting
23:16:28 <nhnt11> I dumped the actual JSON data that is being written to the file
23:16:35 <nhnt11> And I'm seeing /two/ dumps in the error console
23:16:40 <nhnt11> One with the version and one without
23:16:48 <nhnt11> I don't know where the second one is coming from
23:18:09 <-- nhnt11-tb has quit (A TLS packet with unexpected length was received.)
23:18:26 --> nhnt11-tb has joined #instantbird
23:19:04 <nhnt11> Second time around, this.cacheVersion seems to be undefined
23:19:16 <nhnt11> Which leads me to think that "this" isn't what it's expected to be
23:19:29 <nhnt11> Ah, got it
23:19:30 <aleth> yeah, in saveCacheNow you shouldn't use this
23:19:34 <nhnt11> It's in a Timer
23:19:55 <aleth> so?
23:20:10 <nhnt11> aleth: scheduleCacheSave does not bind() this._saveCacheNow
23:20:12 <nhnt11> That's the issue
23:20:21 <aleth> right, it doesn't need to bind it
23:20:36 <nhnt11> It does if we want to use the cache version :-S
23:20:52 <aleth> you can use GlodaIMIndexer.cacheVersion
23:20:53 <nhnt11> or we need to pass it as a parameter (I think binding is easier)
23:20:56 <nhnt11> oh
23:20:59 <nhnt11> Right
23:21:03 * nhnt11 forgot about that
23:21:22 <nhnt11> thanks!
23:21:52 <nhnt11> That's already done for knownFiles, I should've seen it.
23:21:54 <-- nhnt11-tb has quit (A TLS packet with unexpected length was received.)
23:22:16 --> nhnt11-tb has joined #instantbird
23:22:40 <-- nhnt11-tb has quit (A TLS packet with unexpected length was received.)
23:22:46 <nhnt11> Cool, it works now.
23:23:42 <aleth> :-)
23:33:01 <aleth> nhnt11: if you use OS.path.split to split the path components, will that fail on WIndows?
23:34:26 <nhnt11> aleth: Better not risking it, I'm changing it to row.getString(1).split("/").length
23:34:31 <nhnt11> Should've done that from the start.
23:34:41 <aleth> OK
23:35:15 <nhnt11> s/.length//
23:37:09 <aleth> I'll try to do a final test/review tomorrow. Good night!
23:37:16 <nhnt11> Thanks! Good night!
23:40:11 <nhnt11> aleth: Is bug 1135588 fixed?
23:40:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1135588 nor, --, ---, aleth, ASSI, New conversations get indexed twice by gloda, leading to duplicate search results
23:40:15 <nhnt11> i.e. can we mark it as resolved?
23:41:02 <aleth> Uh yes, it's fixed. Thanks
23:42:49 <-- arlolra has quit (Client exited)