All times are UTC.
00:00:20 <flo-retina> clokep_work: I like step 4 btw :) 00:00:43 <clokep> flo-retina: Infinite recursion as aleth pointed out. ;) 00:00:54 <flo-retina> you can certainly file another bug on that ;) 00:01:43 <flo-retina> but it doesn't have to be infinite: you don't have to file the exact same bug each time :) 00:02:24 <aleth> The STR get a step 0, "read bug XXX" ;) 00:04:59 --> hal has joined #instantbird 00:05:29 <-- hal has quit (Quit: http://www.mibbit.com ajax IRC Client) 00:06:51 <clokep_work> Meh...I can't do anything until my build finishes. :\ 00:07:26 <aleth> This is why I have two local clones of c-c ;) 00:07:56 <clokep_work> Haha. 00:08:53 <aleth> It's cheap, mostly symlinks. 00:10:13 <clokep_work> aleth: Well my build is done so. :P 00:11:39 * Fallen is now known as Fallen|away 00:13:45 <clokep_work> aleth: I still got two hits. :( 00:14:06 <aleth> :-( 00:14:19 <aleth> I don't suppose you know why? 00:14:51 <clokep> No, hah. 00:14:56 <clokep> Let me make sure the patch is applied. ;) 00:16:09 <-- myk has quit (Ping timeout: 121 seconds) 00:16:39 <clokep> aleth: But just reproduced again. 00:16:45 <clokep> Where should I put debug statements? 00:17:39 <aleth> When a save is scheduled (i.e. when the indexing has happened) and when the save happens, I guess. 00:17:56 * aleth tries with a fresh profile 00:22:47 <clokep> aleth: I'm using #testib to put messages into things. 00:23:34 <aleth> I can't reproduce. 00:24:26 <clokep> :-\ 00:24:35 <clokep> I'm using a 'dirty' profile fwiw. 00:25:41 <aleth> Shouldn't really affect search results for new conversations, but you never know 00:27:56 <aleth> clokep: maybe also dump the contents of the file at various points? 00:28:10 <clokep> OK. 00:28:25 <clokep> I see a ton of cache saves being scheduled, but it never seems to actuallyt save. 00:29:43 <aleth> hmm, maybe there is a bug if the file doesn't exist yet :-S 00:29:47 <aleth> does it? 00:30:22 <clokep> I have to find my profile. :-[ 00:31:05 <aleth> you are using a fairly recent tree? 00:31:28 <clokep> Just pulled 00:31:38 * aleth just clobbered 00:32:24 <clokep> aleth: I don't have that file. 00:32:58 <clokep> aleth: AH! 00:33:02 <clokep> That's the bug! 00:33:35 <aleth> :-) 00:33:39 <clokep> I think. 00:33:40 <clokep> One second. 00:34:16 <aleth> yeah, I should set initialized=true also if the file doesn't exist 00:35:31 <clokep> Dammit. :( 00:38:34 <aleth> so does moving this._cacheInitialized = true; fix it for you? 00:38:59 <clokep> aleth: I moved it outside the if statement. 00:38:59 <aleth> just one bracket down should do it 00:39:01 <clokep> (Below it) 00:39:06 <clokep> Yeah...but I'm still seeing it. :_S 00:39:09 <clokep> Testing now 00:41:32 --> DGMurdockIII has joined #instantbird 00:47:14 <clokep> aleth: Sorry, nothing I try seems to help this. 00:47:23 <clokep> I even have a file now and it doesn't seem to get upated. 00:49:28 <aleth> thanks for testing 00:51:51 <clokep> aleth: So the 'newest' file doesn't seem to ever end up in knownFiles. 00:52:07 <clokep> I.e. the file that gets created for this session. 00:52:56 <aleth> sounds like another gloda bug... 00:53:10 <aleth> russian dolls! 00:53:59 <clokep> aleth: Inside of _beginIndexingJob...do we care about that promise at all? 00:55:35 <aleth> that's all a bit convoluted to track as the gloda async stuff has its own async mechanism (predating promises) 00:56:07 <-- Mook_as has quit (Client exited) 00:57:14 * clokep reads that as "I don't know" :P 00:58:37 <aleth> I don't think we care, but I'm not sure about this code ;) 00:59:17 <aleth> Ah, I can reproduce that problem, that's something. 00:59:33 <aleth> It's a bit late now though. 01:01:26 <aleth> Thanks for finding the issue. 01:02:09 <aleth> I have an idea as to wha might be causing it 01:02:24 <clokep> :) 01:02:34 <clokep> Something I can look at or? 01:03:39 <-- aleth has quit (Quit: :tiuQ) 01:05:28 --> Widdershins has joined #instantbird 01:33:02 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:46:08 --> clokep_work has joined #instantbird 01:46:08 * ChanServ sets mode +o clokep_work 01:53:07 <-- DGMurdockIII has quit (Ping timeout: 121 seconds) 01:53:56 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:59:53 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:36:00 <instantbot> rkent@caspia.com set status-thunderbird to fixed on bug 1143238. 02:36:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1143238 nor, --, ---, aleth, ASSI, Rejoining an existing MUC fails 02:41:46 --> mconley has joined #instantbird 02:48:44 <-- micahg has quit (Connection closed) 02:51:28 <-- mconley has quit (Connection closed) 02:56:43 <-- Bollebib has quit (Connection closed) 03:15:53 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 03:20:04 <-- clokep has quit (Ping timeout: 121 seconds) 03:24:14 <instantbot> clokep@patrick.cloke.us changed the Resolution on bug 1143238 from --- to FIXED. 03:24:15 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1143238 nor, --, ---, aleth, RESO FIXED, Rejoining an existing MUC fails 03:29:43 <instant-buildbot> build #2589 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2589 04:11:38 --> mconley has joined #instantbird 04:12:08 <-- EionRobb has quit (Quit: Leaving.) 04:28:51 <instant-buildbot> build #1338 of linux-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1338 04:38:22 <-- mconley has quit (Connection closed) 04:40:12 --> EionRobb has joined #instantbird 04:57:57 <instant-buildbot> build #1661 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1661 05:38:00 <instant-buildbot> build #249 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/249 06:32:20 --> DGMurdockIII has joined #instantbird 07:02:05 <-- DGMurdockIII has quit (Connection closed) 07:07:04 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 07:07:10 --> Even has joined #instantbird 07:07:10 * ChanServ sets mode +o Even 07:19:50 <-- mudpit has quit (Ping timeout: 121 seconds) 08:02:04 --> gerard-majax has joined #instantbird 08:09:52 --> myk has joined #instantbird 08:28:02 <-- myk has quit (Ping timeout: 121 seconds) 08:35:55 --> aleth has joined #instantbird 08:35:55 * ChanServ sets mode +o aleth 08:41:07 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:03:13 * Fallen|away is now known as Fallen 09:17:44 * Fallen is now known as Fallen|away 09:18:24 --> gerard-majax has joined #instantbird 09:20:31 * Fallen|away is now known as Fallen 09:23:47 <-- EionRobb has quit (Quit: Leaving.) 09:29:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:31:05 --> gerard-majax has joined #instantbird 09:34:58 * Fallen is now known as Fallen|away 09:35:26 --> nhnt11 has joined #instantbird 09:35:26 * ChanServ sets mode +h nhnt11 09:35:39 --> Bollebib has joined #instantbird 09:36:53 <-- gerard-majax has quit (Ping timeout: 121 seconds) 09:38:29 * Fallen|away is now known as Fallen 09:43:25 --> gerard-majax has joined #instantbird 09:53:22 <-- gerard-majax has quit (Quit: Leaving) 09:57:30 --> gerard-majax has joined #instantbird 10:03:30 <-- gerard-majax has quit (Ping timeout: 121 seconds) 10:24:01 <-- Bollebib has quit (Ping timeout: 121 seconds) 10:24:56 --> BWMerlin has joined #instantbird 10:28:48 --> Bollebib has joined #instantbird 10:29:50 <-- nhnt11 has quit (Ping timeout: 121 seconds) 10:31:23 --> clokep has joined #instantbird 10:31:24 * ChanServ sets mode +o clokep 10:31:56 <-- clokep has quit (Connection closed) 10:32:08 --> clokep has joined #instantbird 10:32:08 * ChanServ sets mode +o clokep 10:32:57 <-- Bollebib has quit (Ping timeout: 121 seconds) 10:33:59 --> Bollebib has joined #instantbird 10:42:51 --> gerard-majax has joined #instantbird 10:46:42 <clokep> aleth: You were right, some things were getting saved in the database with my patches: but the account buddies, not the buddies. 10:55:07 --> nhnt11 has joined #instantbird 10:55:07 * ChanServ sets mode +h nhnt11 10:58:36 <-- aleth has quit (Connection closed) 10:58:38 --> aleth has joined #instantbird 10:58:38 * ChanServ sets mode +o aleth 10:59:48 <-- clokep has quit (Ping timeout: 121 seconds) 11:19:28 --> mudpit has joined #instantbird 11:31:30 <-- mudpit has quit (Ping timeout: 121 seconds) 11:39:28 <-- nhnt11 has quit (Ping timeout: 121 seconds) 11:44:30 --> qheaden has joined #instantbird 11:57:48 <-- Bollebib has quit (Connection closed) 11:57:51 --> Bollebib has joined #instantbird 12:03:17 --> mpmc has joined #instantbird 12:09:28 --> nhnt11 has joined #instantbird 12:09:28 * ChanServ sets mode +h nhnt11 12:14:47 --> clokep_work has joined #instantbird 12:14:47 * ChanServ sets mode +o clokep_work 12:27:27 <-- nhnt11 has quit (Ping timeout: 121 seconds) 12:29:15 <-- BWMerlin has quit (Client exited) 12:41:33 --> nhnt11 has joined #instantbird 12:41:33 * ChanServ sets mode +h nhnt11 12:51:39 <-- nhnt11 has quit (Ping timeout: 121 seconds) 12:56:25 <-- swills has quit (Quit: Coyote finally caught me) 13:17:49 --> bernard has joined #instantbird 13:35:21 --> bernard1 has joined #instantbird 13:37:22 <-- bernard has quit (Ping timeout: 121 seconds) 13:46:36 <-- Tonnes has quit (Connection closed) 13:47:49 --> Tonnes has joined #instantbird 13:53:45 <-- bernard1 has quit (Quit: Leaving.) 14:19:31 --> bernard has joined #instantbird 14:20:09 --> mconley has joined #instantbird 14:40:08 * Fallen is now known as Fallen|away 15:01:46 --> bogdan_maris has joined #instantbird 15:02:20 <-- bogdan_maris has quit (A TLS packet with unexpected length was received.) 15:11:37 --> micahg has joined #instantbird 15:17:05 <-- aleth has quit (Ping timeout: 121 seconds) 15:19:35 <-- bernard has quit (Ping timeout: 121 seconds) 15:26:45 --> aleth has joined #instantbird 15:26:45 * ChanServ sets mode +o aleth 15:28:46 --> myk has joined #instantbird 15:30:18 * Fallen|away is now known as Fallen 15:31:33 --> nhnt11 has joined #instantbird 15:31:33 * ChanServ sets mode +h nhnt11 15:42:20 <nhnt11> aleth, clokep_work: Thanks for looking at gloda, btw :( 15:43:15 <nhnt11> FYI I can probably do a quick review or two if you need a second opinion 15:43:30 <aleth> You don't need to, it's r- due to a russian doll of gloda bugs 15:43:53 <nhnt11> :( 15:46:40 <aleth> If you have some time, fixing that other bug would be better ;) 15:47:54 <clokep_work> aleth: What did you think the newest issue was? 15:47:57 <clokep_work> nhnt11: You're welcome. 15:49:31 * clokep_work wonders if we should make :)))))))))) into a happier smiley face. :P 15:49:40 <aleth> clokep_work: I suspect we're reading the cache file after some indexing has already occured 15:50:09 <clokep_work> aleth: Would your patch + lots of logging be helpful? 15:50:44 <aleth> clokep_work: I'm not sure, I might get a look tonight 15:51:54 <clokep_work> aleth: http://pastebin.instantbird.com/1230017 15:52:20 <aleth> Thanks 15:58:05 <-- qheaden has quit (A TLS packet with unexpected length was received.) 16:01:15 * Fallen is now known as Fallen|away 16:15:39 <-- Bollebib has quit (Ping timeout: 121 seconds) 16:17:44 --> Bollebib has joined #instantbird 16:22:50 --> Defman has joined #instantbird 16:24:21 --> bernard has joined #instantbird 16:24:31 <-- bernard has quit (Quit: Leaving.) 16:24:33 --> bernard has joined #instantbird 16:34:20 <-- myk has quit (Ping timeout: 121 seconds) 16:38:49 --> bernard1 has joined #instantbird 16:41:13 --> bernard2 has joined #instantbird 16:42:07 <-- bernard has quit (Ping timeout: 121 seconds) 16:42:51 <-- bernard1 has quit (Ping timeout: 121 seconds) 16:46:09 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:56:37 --> Mook_as has joined #instantbird 16:56:52 --> mudpit has joined #instantbird 17:01:07 * mconley is now known as mconley|livehacking 17:02:39 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:04:57 <-- mudpit has quit (Ping timeout: 121 seconds) 17:04:57 <-- aleth has quit (Ping timeout: 121 seconds) 17:05:37 --> aleth has joined #instantbird 17:05:37 * ChanServ sets mode +o aleth 17:14:38 --> gerard-majax has joined #instantbird 17:23:46 <-- nhnt11 has quit (Ping timeout: 121 seconds) 17:26:56 --> mudpit has joined #instantbird 17:29:50 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:31:06 --> bernard has joined #instantbird 17:32:46 <-- bernard2 has quit (Ping timeout: 121 seconds) 17:34:51 --> gerard-majax has joined #instantbird 17:39:57 --> arlolra has joined #instantbird 17:45:35 --> harshit has joined #instantbird 17:47:45 <-- harshit has quit (Quit: Leaving) 17:47:52 --> harshit has joined #instantbird 17:55:05 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:58:23 <-- Widdershins has quit (Ping timeout: 121 seconds) 18:03:25 --> bernard1 has joined #instantbird 18:03:38 <-- bernard has quit (Ping timeout: 121 seconds) 18:04:01 --> Nazadel has joined #instantbird 18:04:14 <-- bernard1 has quit (Quit: Leaving.) 18:04:14 --> bernard has joined #instantbird 18:07:06 --> gerard-majax has joined #instantbird 18:18:01 <-- bernard has quit (Quit: Leaving.) 18:18:02 --> bernard has joined #instantbird 18:19:10 <-- bernard has quit (Quit: Leaving.) 18:19:24 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:23:02 --> flo-retina has joined #instantbird 18:23:02 * ChanServ sets mode +qo flo-retina flo-retina 18:23:25 <flo-retina> do we have any idea of why the last mac nightly failed? 18:23:33 <flo-retina> the linux64 one really looks to me like OOM. 18:33:38 --> bernard has joined #instantbird 18:36:06 --> myk has joined #instantbird 18:40:10 * mconley|livehacking is now known as mconley 18:53:18 --> nhnt11 has joined #instantbird 18:53:18 * ChanServ sets mode +h nhnt11 18:54:13 <-- bernard has quit (Connection closed) 18:54:13 --> bernard1 has joined #instantbird 18:57:22 <-- nhnt11 has quit (Ping timeout: 121 seconds) 18:57:32 --> nhnt11 has joined #instantbird 18:57:32 * ChanServ sets mode +h nhnt11 18:58:20 --> gerard-majax has joined #instantbird 18:58:29 <-- bernard1 has quit (Connection closed) 19:00:46 --> bernard has joined #instantbird 19:11:30 * Fallen|away is now known as Fallen 19:14:57 <-- harshit has quit (Quit: Leaving) 19:23:53 <-- bernard has quit (Quit: Leaving.) 19:36:34 --> DGMurdockIII has joined #instantbird 19:48:32 --> EionRobb has joined #instantbird 19:48:46 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:17:55 --> bernard has joined #instantbird 20:22:07 <-- bernard has quit (Ping timeout: 121 seconds) 20:24:33 --> flo-retina has joined #instantbird 20:24:33 * ChanServ sets mode +qo flo-retina flo-retina 20:34:14 <clokep_work> flo-retina: No idea. Didn't look into it. 20:38:16 <-- clokep_work has quit (Ping timeout: 121 seconds) 20:40:04 <-- nhnt11 has quit (Ping timeout: 121 seconds) 21:00:07 <-- gerard-majax has quit (Ping timeout: 121 seconds) 21:23:53 --> abdelrhman has joined #instantbird 21:28:55 <abdelrhman> aleth: In the second review for line 991, you mean move handling code to onPresenceStanza of muc 21:29:23 <abdelrhman> and just make else if of muc like buddies 21:29:38 <aleth> yes 21:29:52 <aleth> unless you have a good reason not to of course 21:30:56 <abdelrhman> :) that really would be better 21:33:14 <aleth> I think there used to be a reason it had to be there, but other changes that happened make it no longer necessary 21:38:25 <abdelrhman> I thought to move it before submitting this patch because I was always thinking about code complexity if we added/implemented the rest of XEP-0045 21:39:00 <abdelrhman> it's better to keep everything organized from now as you said 21:40:58 <abdelrhman> but this needs to have entire overview of spec to keep in mind that 21:41:36 <aleth> You don't have to read *everything*, but getting a rough idea of what can happen is useful 21:42:25 <aleth> e.g. take the XEP and search for "presence"... 21:44:14 <aleth> should give a lot of example stanzas. 21:46:19 <-- abdelrhman has quit (Ping timeout: 121 seconds) 21:48:09 --> abdelrhman has joined #instantbird 21:50:29 <abdelrhman> ok, I'll try that 21:52:09 <aleth> also, look at debug logs for joining existing rooms (with other people in them) of course 21:53:59 --> mpmc has joined #instantbird 21:57:04 --> Mnyromyr has joined #instantbird 22:01:20 <-- abdelrhman has quit (Ping timeout: 121 seconds) 22:03:23 --> abdelrhman has joined #instantbird 22:04:30 <abdelrhman> ok, I think when I finish working on this bug, I can forward faster in implementing xep-0045 22:08:38 <abdelrhman> in method parseError in account. I think we can move it also to XMPPMUCConversationPrototype 22:09:46 <abdelrhman> no, sorry, it's also used for buddies 22:10:09 <-- mconley has quit (Connection closed) 22:15:21 <-- abdelrhman has quit (Ping timeout: 121 seconds) 22:15:57 --> clokep has joined #instantbird 22:15:57 * ChanServ sets mode +o clokep 22:16:17 --> abdelrhman has joined #instantbird 22:17:12 <clokep> abdelrhman: Looks like you're making good progres. :-D 22:18:14 <-- arlolra has quit (Client exited) 22:20:22 <-- abdelrhman has quit (Ping timeout: 121 seconds) 22:22:39 --> abdelrhman has joined #instantbird 22:22:52 <abdelrhman> clokep: I hope that ;) 22:28:24 <-- Defman has quit (A TLS packet with unexpected length was received.) 22:29:37 <-- flo-retina has quit (Ping timeout: 121 seconds) 22:30:49 <-- EionRobb has quit (Ping timeout: 121 seconds) 22:31:53 --> EionRobb has joined #instantbird 22:36:47 <-- myk has quit (Ping timeout: 121 seconds) 22:46:32 --> flo-retina has joined #instantbird 22:46:32 * ChanServ sets mode +qo flo-retina flo-retina 22:49:29 <abdelrhman> aleth: it seems that all received presence for MUC has x element 22:49:52 <abdelrhman> so I'll break if condition if (x && x.uri == Stanza.NS.muc_user) 22:50:25 <abdelrhman> into if (!x) error and return, if (x.uri == Stanza.NS.muc_user) 22:52:10 <aleth> abdelrhman: That sounds OK. By the way, as it's in answer to my question in the bug, it's a good idea to answer in a bug comment, so that the answer is recorded on bugzilla for future reference. You don't have to check it with me here, just answer together with the next version of the patch. 22:52:40 <abdelrhman> ok 22:53:27 <-- DGMurdockIII has quit (Quit: Leaving) 23:08:38 --> mpmc1 has joined #instantbird 23:10:19 <-- mpmc has quit (Ping timeout: 121 seconds) 23:10:19 * mpmc1 is now known as mpmc 23:14:13 * Fallen is now known as Fallen|away 23:18:15 <-- flo-retina has quit (Connection closed) 23:18:47 --> flo-retina has joined #instantbird 23:18:47 * ChanServ sets mode +qo flo-retina flo-retina 23:19:35 <-- abdelrhman has quit (Quit: Leaving) 23:23:21 * Fallen|away is now known as Fallen 23:27:18 --> myk has joined #instantbird 23:31:38 <-- flo-retina has quit (Ping timeout: 121 seconds) 23:33:23 --> flo-retina has joined #instantbird 23:33:23 * ChanServ sets mode +qo flo-retina flo-retina 23:38:49 * Fallen is now known as Fallen|away