#instantbird log on 03 17 2015

All times are UTC.

00:07:51 * Fallen is now known as Fallen|away 
00:09:32 --> aleth has joined #instantbird
00:09:33 * ChanServ sets mode +o aleth 
00:12:40 <-- aleth has quit (Quit: :tiuQ)
00:15:04 --> nhnt11 has joined #instantbird
00:15:04 * ChanServ sets mode +h nhnt11 
00:22:42 --> nhnt12 has joined #instantbird
00:22:42 * ChanServ sets mode +h nhnt12 
00:23:27 <-- nhnt11 has quit (Connection closed)
00:26:45 <-- nhnt12 has quit (Ping timeout: 121 seconds)
00:41:01 <-- mconley has quit (Connection closed)
00:44:57 --> clokep has joined #instantbird
00:44:57 * ChanServ sets mode +o clokep 
00:49:34 <-- myk has quit (Ping timeout: 121 seconds)
00:53:11 --> AlexanderSalas has joined #instantbird
01:03:12 <-- Bollebib1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:50:30 <-- clokep has quit (Ping timeout: 121 seconds)
02:22:25 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
02:23:30 --> AlexanderSalas has joined #instantbird
02:40:24 <-- micahg has quit (Ping timeout: 121 seconds)
02:50:14 --> nhnt11 has joined #instantbird
02:50:14 * ChanServ sets mode +h nhnt11 
02:50:45 --> sherief has joined #instantbird
03:04:21 <-- nhnt11 has quit (Ping timeout: 121 seconds)
03:10:09 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
03:23:35 --> Widdershins has joined #instantbird
03:56:51 --> mconley has joined #instantbird
04:03:14 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
04:22:47 <-- EionRobb has quit (Quit: Leaving.)
04:28:25 <instant-buildbot> build #1337 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1337
04:29:00 <-- mconley has quit (Connection closed)
04:55:19 --> EionRobb has joined #instantbird
04:57:55 <instant-buildbot> build #1660 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1660
05:05:42 <instant-buildbot> build #2588 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2588
05:22:48 --> flo-retina has joined #instantbird
05:22:48 * ChanServ sets mode +qo flo-retina flo-retina 
05:54:30 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
06:15:50 <instant-buildbot> build #248 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/248
06:32:21 --> nhnt11 has joined #instantbird
06:32:21 * ChanServ sets mode +h nhnt11 
06:38:25 <-- nhnt11 has quit (Ping timeout: 121 seconds)
06:41:02 --> myk has joined #instantbird
06:42:48 --> myk1 has joined #instantbird
06:45:04 <-- myk has quit (Ping timeout: 121 seconds)
06:45:05 * myk1 is now known as myk 
06:48:33 <-- sherief has quit (Ping timeout: 121 seconds)
06:57:10 <-- myk has quit (Ping timeout: 121 seconds)
07:12:58 --> nhnt11 has joined #instantbird
07:12:58 * ChanServ sets mode +h nhnt11 
07:43:31 <-- nhnt11 has quit (Ping timeout: 121 seconds)
08:05:34 * Fallen|away is now known as Fallen 
08:25:52 --> Bollebib has joined #instantbird
09:17:04 <-- mudpit has quit (Ping timeout: 121 seconds)
09:43:37 <-- Tonnes has quit (Connection closed)
09:44:34 --> Tonnes has joined #instantbird
09:49:01 --> chrisccoulson has joined #instantbird
09:55:42 <-- EionRobb has quit (Quit: Leaving.)
09:56:26 --> nhnt11 has joined #instantbird
09:56:27 * ChanServ sets mode +h nhnt11 
10:04:16 <nhnt11> Hello
10:04:39 <nhnt11> So I'm disappointed to say this, but it looks like I'll be too busy till the end of March to look at gloda further :(
10:05:41 * nhnt11 tried, but thinks it's now time to accept his lack of time and motivation regarding this.
10:05:43 --> aleth has joined #instantbird
10:05:43 * ChanServ sets mode +o aleth 
10:12:12 <aleth> nhnt11: I don't have time to do it for you. Did you ever talk to asuth about how best to fix it?
10:12:37 <nhnt11> No, to be honest I've barely been on IRC
10:13:21 <nhnt11> aleth: When's the next merge day?
10:13:42 <aleth> End of March
10:16:00 <aleth> It's also possible to uplift to beta of course. But there should be a plan, as in effect that raises the stakes if there are bugs in the fix...
10:17:25 <nhnt11> aleth: Okay, so I'm almost certainly not going to be available this week, too many academic commitments. Monday and Tuesday next week should be relatively free, I'll see what I can do.
10:19:05 <aleth> OK
10:23:37 --> clokep has joined #instantbird
10:23:37 * ChanServ sets mode +o clokep 
10:28:22 --> mudpit has joined #instantbird
10:38:00 <-- nhnt11 has quit (Ping timeout: 121 seconds)
10:38:24 <-- mudpit has quit (Ping timeout: 121 seconds)
10:44:48 --> mudpit has joined #instantbird
11:11:36 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:17:26 --> mpmc has joined #instantbird
11:19:32 <-- aleth has quit (Ping timeout: 121 seconds)
11:21:33 --> aleth has joined #instantbird
11:21:33 * ChanServ sets mode +o aleth 
11:41:09 --> BWMerlin has joined #instantbird
12:16:39 <-- BWMerlin has quit (Client exited)
12:27:49 --> clokep_work has joined #instantbird
12:27:49 * ChanServ sets mode +o clokep_work 
12:41:41 <-- Tonnes has quit (Connection closed)
12:54:40 --> Tonnes has joined #instantbird
12:58:04 <clokep_work> aleth: So this right click menu for a non-buddy...where's that generated?
12:58:13 <clokep_work> (Vaguely at least... :) I don't even know where to start looking...)
12:59:06 <aleth> context menu on what?
12:59:26 <aleth> nicks?
13:01:21 * Fallen is now known as Fallen|away 
13:01:22 <clokep_work> On tabs.
13:01:36 <clokep_work> (The "Add contact..." element)
13:01:59 <clokep_work> Hmm...apparently it's on participants too.
13:03:12 <aleth> https://dxr.mozilla.org/comm-central/source/im/content/nsContextMenu.js#204 ?
13:04:34 <clokep_work> I guess I'm trying to figure out where it is decided what to show or not.
13:04:39 <clokep_work> But that code is close enough likely! :)
13:05:38 <aleth> Yes, that should be in the same file
13:06:01 <aleth> https://dxr.mozilla.org/comm-central/source/im/content/nsContextMenu.js#177
13:09:08 <aleth> I can't remember if tabs use the same context menu though
13:11:04 <aleth> looks like it's not: https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1576
13:11:18 <clokep_work> :-\
13:11:24 <clokep_work> That's annoying.
13:12:13 <aleth> Difference between MUCs and PMs...
13:12:44 <clokep_work> Yeah...
13:13:48 <aleth> at least the condition doesn't look complicated ;) https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1572
13:18:43 <clokep_work> Yeah. THat one looks easy. :)
13:19:58 <clokep_work> https://dxr.mozilla.org/comm-central/source/im/content/nsContextMenu.js#188 looks painful. :-\
13:20:12 <aleth> it may not apply to your case
13:24:29 <aleth> depends on how you fix that bug I guess ;)
13:24:45 <clokep_work> Yeah...
13:25:48 <aleth> I guess you wouldn't want getAccountBuddy... methods to find fake account buddies anyway
13:28:45 <clokep_work> No.
13:29:40 * clokep_work sighs.
13:39:38 <clokep_work> Bah.
13:39:56 <clokep_work> I can't seem to properly replace a fake imIBuddy with the real one when adding it. :-\
14:16:19 --> mconley has joined #instantbird
14:30:52 --> micahg has joined #instantbird
15:12:05 --> Mnyromyr has joined #instantbird
15:15:32 --> sherief has joined #instantbird
15:16:02 --> myk has joined #instantbird
15:17:47 <-- Widdershins has quit (Ping timeout: 121 seconds)
15:19:37 <-- sherief has quit (Ping timeout: 121 seconds)
15:21:20 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:21:23 --> myk has joined #instantbird
15:30:13 <-- aleth has quit (Ping timeout: 121 seconds)
15:33:05 --> sherief has joined #instantbird
15:43:14 <-- gerard-majax has quit (Ping timeout: 121 seconds)
15:45:11 --> qheaden has joined #instantbird
16:38:29 --> arlolra has joined #instantbird
16:40:42 <-- sherief has quit (Quit: either an outage or my isp is being shit)
16:44:05 --> Nazadel has joined #instantbird
16:52:58 --> gerard-majax has joined #instantbird
16:55:02 --> flo-retina has joined #instantbird
16:55:02 * ChanServ sets mode +qo flo-retina flo-retina 
16:58:30 --> nhnt11 has joined #instantbird
16:58:30 * ChanServ sets mode +h nhnt11 
16:58:33 --> aleth has joined #instantbird
16:58:33 * ChanServ sets mode +o aleth 
17:00:31 <-- nhnt11 has quit (Connection closed)
17:01:07 --> nhnt11 has joined #instantbird
17:01:07 * ChanServ sets mode +h nhnt11 
17:03:12 --> nhnt12 has joined #instantbird
17:03:12 * ChanServ sets mode +h nhnt12 
17:05:08 <-- nhnt11 has quit (Ping timeout: 121 seconds)
17:05:57 --> nhnt11 has joined #instantbird
17:05:57 * ChanServ sets mode +h nhnt11 
17:07:14 <-- nhnt12 has quit (Ping timeout: 121 seconds)
17:20:03 <-- nhnt11 has quit (Ping timeout: 121 seconds)
17:21:47 --> nhnt11 has joined #instantbird
17:21:47 * ChanServ sets mode +h nhnt11 
18:09:00 * Fallen|away is now known as Fallen 
18:15:31 --> Mook_as has joined #instantbird
18:44:33 <-- Tonnes has quit (Connection closed)
18:52:44 --> Tonnes has joined #instantbird
18:59:01 --> Defman has joined #instantbird
19:24:24 <-- myk has quit (Connection closed)
19:24:36 --> myk has joined #instantbird
19:38:40 <-- gerard-majax has quit (Ping timeout: 121 seconds)
19:39:58 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:40:07 --> nhnt11 has joined #instantbird
19:40:07 * ChanServ sets mode +h nhnt11 
20:02:52 <-- qheaden has quit (A TLS packet with unexpected length was received.)
20:11:48 <-- nhnt11 has quit (Ping timeout: 121 seconds)
20:19:35 --> gerard-majax has joined #instantbird
20:22:05 <-- mpmc has quit (Connection closed)
20:22:06 --> mpmc has joined #instantbird
20:32:04 <flo-retina> I got access to the result of a coverity scan of Instantbird
20:33:45 --> DGMurdockIII has joined #instantbird
20:34:19 <flo-retina> nothing looks too scary, but quite a few of these things are real bugs in the code
20:34:41 <aleth> useful scan then!
20:34:45 <arlolra> fun
20:35:26 <-- gerard-majax has quit (Ping timeout: 121 seconds)
20:35:58 <flo-retina> eg. use of uninitialized memory
20:44:27 --> nhnt11 has joined #instantbird
20:44:27 * ChanServ sets mode +h nhnt11 
20:48:17 <-- DGMurdockIII has quit (Ping timeout: 121 seconds)
20:48:56 --> DGMurdockIII has joined #instantbird
21:10:33 <Fallen> flo-retina: how did you get that done? Do you think it could be run for Lightning too?
21:11:11 <flo-retina> do you still have compiled code there?
21:11:52 <flo-retina> If it's useful, I see no reason why it couldn't be done for lightning
21:22:47 <Fallen> yeah, libical. hard to shake off
21:26:46 <clokep_work> Fallen: Aren't they running it for TB already?
21:27:13 <Fallen> yeah, maybe its being run for calendar then too, unless it just descends into the mail/ subdir
21:27:28 <clokep_work> Ah, yeah...
21:27:39 <clokep_work> flo-retina: So are the issues all libpurple? Is there a 'way' we should report them?
21:31:57 <flo-retina> clokep_work: well, I guess it would be useful if aleth and you could have an account there
21:32:07 <-- arlolra has quit (Client exited)
21:32:09 <flo-retina> clokep_work: and no, not all libpurple. Quite a few are in purplexpcom.
21:32:14 --> arlolra has joined #instantbird
21:32:25 <flo-retina> one is in im/app/nsMain.cpp (but I don't think that one is a real bug). And 2 in mintrayr
21:32:58 <clokep_work> Interesting.
21:33:18 --> EionRobb has joined #instantbird
21:33:21 <flo-retina> the stuff in libpurple is mostly in sipe and in libgg
21:33:40 <flo-retina> + 1 in msn and 1 in oscar
21:34:01 <flo-retina> small enough number that I suspect some Pidgin developers have already had access to this tool, and fixed warnings :).
21:34:12 <flo-retina> (it's free for open source projects)
21:34:55 <-- Defman has quit (Connection closed)
21:34:59 --> Defman has joined #instantbird
21:35:49 <clokep_work> Oooo, interesting. :)
21:35:55 <clokep_work> They could even be fixed if we update. :-\
21:37:52 * clokep_work would be interested in the results.
21:37:54 <flo-retina> https://scan.coverity.com/projects/192
21:38:18 <flo-retina> "559 Fixed"
21:38:55 <-- nhnt11 has quit (Ping timeout: 121 seconds)
21:39:45 <flo-retina> looks like I actually have enough rights to invite new members on the "Instantbird" coverity project
21:40:00 <flo-retina> clokep_work: I'm confused with all your recent email changes, which address should I invite you on? ;)
21:40:34 <clokep_work> flo-retina: Things forward OK so not a big deal. :)
21:40:50 <flo-retina> @ib.org works?
21:41:34 <clokep_work> Umm... clokep @ that should work yes.
21:41:39 <clokep_work> It'll get forwarded like 8 times, but yeah. :-D
21:41:56 <flo-retina> 8? O_O
21:42:09 <clokep_work> Twice. :)
21:42:29 <flo-retina> I can change that email redirect so that it skips gmail if you like
21:42:44 <clokep_work> OK.
21:43:05 <flo-retina> maybe not the best thing to look at now, but remind me at some point if you care about it :)
21:44:10 <clokep_work> flo-retina: Should 'fixes' for this be security sensitive or whatever?
21:44:37 <flo-retina> clokep_work: alright, done it now.
21:44:39 <flo-retina> so that I don't forget
21:44:42 <clokep_work> Thanks. :)
21:44:54 <flo-retina> clokep_work: they should be if we have reasons to believe they cause security risks
21:45:04 <flo-retina> but stuff like memory leaks... no reason to be security sensitive
21:47:09 <clokep_work> Alright.
22:03:39 <-- Even has quit (Connection closed)
22:07:32 <-- clokep_work has quit (Ping timeout: 121 seconds)
22:09:53 <flo-retina> this nightly seems very broken for me :(
22:10:13 <flo-retina> the content of the chat window doesn't refresh unless I resize the window :(
22:18:01 <-- mconley has quit (Connection closed)
22:47:27 --> clokep has joined #instantbird
22:47:27 * ChanServ sets mode +o clokep 
22:47:58 <clokep> aleth: Want one more or can I review it now? :P
22:48:52 <aleth> clokep: That's it from me ;) 
22:48:56 <-- Defman has quit (A TLS packet with unexpected length was received.)
22:49:10 <clokep> Meh...this is more painful then I thought.
22:49:48 <aleth> That was my thought as well between v2 and v3
22:50:10 * clokep isn't sure he's comfotable reviewing this.
22:50:19 <aleth> yeah, but who is?
22:50:46 <clokep> flo-retina :P
22:51:23 <aleth> hmm true -- I guess he did write it :D
22:51:42 * flo-retina denies
22:51:53 <flo-retina> I don't know what you are talking about, but I certainly didn't write it
22:52:03 * flo-retina is struggling to display an X icon, and feels like a newbie
22:52:20 <-- Nazadel has quit (Quit: Bye)
22:53:06 <aleth> flo-retina: hg blame disagrees ;)
22:53:33 <clokep> aleth: So when does _scheduleCacheSave get called?
22:54:20 <clokep> This is going to need to be an interactive review. :-D
22:54:37 <aleth> After a file is indexed.
22:54:51 <aleth> Well, dxr would also tell you ;)
22:55:25 <clokep> OK...
22:56:01 <clokep> aleth: So the cache file is what exactly?
22:56:40 <aleth> JSON file storing https://dxr.mozilla.org/comm-central/source/mail/components/im/modules/index_im.js#248
22:56:54 <-- arlolra has quit (Client exited)
22:57:21 <flo-retina> aleth: hg blames returned 503 a few hours ago, that was convenient to not feel guilty ;)
23:01:32 <clokep> aleth: It's confusing to me that it's called _knownFiles and "_cacheFile" But OK> ;D_
23:01:36 <clokep> Eek...
23:01:49 <aleth> Yes, that confused me too
23:06:40 <-- Mnyromyr has quit (Quit: ChatZilla [SeaMonkey 2.33/20150308222602])
23:09:03 <clokep> aleth: Is there a nicer place to add the shutdownBlocker?
23:09:51 <aleth> suggestions welcome... I wanted to keep it lazy though
23:11:01 <aleth> Please also test the patch if you can just to double-check as my profile may be borked by now or something.
23:11:10 <clokep> OK.
23:11:20 <clokep> I don't know if I have a built TB...
23:11:51 <-- DGMurdockIII has quit (Quit: Leaving)
23:12:03 * clokep kicks off a build. ;)
23:12:13 <clokep> aleth: Can you give specifics of what to test?
23:13:12 <aleth> The STR in the bug would be a good place to start? Basically have conversations, restart a couple of times and check that stuff doesn't appear in the search results more than once
23:18:59 --> Even has joined #instantbird
23:18:59 * ChanServ sets mode +o Even 
23:21:27 <clokep> aleth: Why the " GlodaIMIndexer._cacheSaveTimer = null;" line in saveCacheNow?
23:21:30 <clokep> Besides that it looks good.
23:22:54 <aleth> clokep: So if a save is scheduled later, it actually happens.
23:23:15 <clokep> Oh duh.
23:23:16 <clokep> I'm stupid.
23:23:28 <aleth> That was the main cause of the duplicate entries
23:23:46 <aleth> (that that line was missing)
23:26:22 <clokep> aleth: So I've played with this a bit and unsure what to do...any hints on how to swap in a dummy buddy for a real buddy?
23:26:55 <aleth> where are you storing the dummy buddy?
23:27:04 <clokep> ...as the buddy. :)
23:27:12 <aleth> so it gets saved to the database?
23:27:17 <clokep> I don't think so.
23:27:25 <clokep> Well it shouldn't.
23:27:40 <aleth> good... I guess my question is how it is labeled a dummy
23:28:11 <clokep> It has a negative ID.
23:28:21 <clokep> I hesitate to uplaod a partial patch.
23:28:25 <clokep> But I can if you'd like.
23:28:57 <aleth> so you need a way to change the id?
23:31:21 <clokep> I think I need to replace the entire buddy?
23:31:31 <clokep> But maybe that makes more sense. :)
23:31:45 --> clokep_work has joined #instantbird
23:31:45 * ChanServ sets mode +o clokep_work 
23:33:42 <clokep_work> aleth:, flo-retina might be interested too... http://pastebin.instantbird.com/1229726
23:33:45 <clokep_work> Ooooo auto-complete bug! :-D
23:33:55 <aleth> There's already some mechanism that replaces dummy contacts, maybe that is useful?
23:34:10 <aleth> huh, that's a new one
23:34:23 <clokep_work> Yeah...I should look at that, I guess.
23:34:24 <clokep_work> One second.
23:35:03 <flo-retina> cool, now we are getting dummy buddies in addition to dummy contacts :-D
23:35:56 <clokep_work> flo-retina: I like talking to dummies, so what'd you expect?
23:36:11 * flo-retina wonders if he should take that as an insult
23:36:39 <instantbot> New Instantbird - Conversation bug 1144443 filed by clokep@patrick.cloke.us.
23:36:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1144443 min, --, ---, nobody, NEW, [tab complete] Weird behavior when using parens
23:36:45 <clokep_work> flo-retina: Well from the amount I talk to myself... ;)
23:36:48 <clokep_work> aleth: ^
23:37:53 <clokep_work> Poor title. Sorry.
23:37:57 <aleth> clokep_work: that's very meta, the STR lead to even more bugs ;)
23:38:05 <clokep_work> :-D
23:42:17 <aleth> clokep_work: are you sure new AccountBuddy doesn't fire off a bunch of notifications you don't want fired for dummies?
23:43:12 <aleth> i.e. I'm surprised you don't have to create the dummy buddy first (but buddy code always confuses me)
23:46:03 <clokep> aleth: You *can't* do that.
23:46:29 <clokep> For some reason.
23:46:34 <clokep> Which I can't remember the details of right now.
23:47:26 <-- clokep_work has quit (Ping timeout: 121 seconds)
23:48:44 <clokep> aleth: The issue is that prpls don't make imIBuddies, I think.
23:49:35 <aleth> hmm yeah,  they're not allowed
23:50:05 <aleth> shouldn't know about buddies/contacts at all ;)
23:51:18 <clokep> Hence the API I came up w/.
23:52:45 <clokep> aleth: So the approach I was going to do was just replace buddy on the prplIaccountBuddy (which points back to imIBuddy.)
23:57:44 --> clokep_work has joined #instantbird
23:57:44 * ChanServ sets mode +o clokep_work 
23:58:56 <aleth> clokep: just check new accountBuddy doesn't already generate a buddy
23:59:22 <aleth> But I guess you would have noticed it in the contact list.
23:59:30 <clokep> Yep.