#instantbird log on 03 15 2015

All times are UTC.

00:02:28 <-- DGMurdockIII has quit (Quit: Leaving)
00:05:05 <-- abdelrhman has quit (Quit: Leaving)
00:20:47 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.33/20150308222602])
00:36:36 <-- Nazadel has quit (Quit: Bye)
00:42:37 * Fallen is now known as Fallen|away 
02:22:38 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:29:57 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
03:10:18 --> micahg has joined #instantbird
03:17:42 --> Widdershins has joined #instantbird
03:40:13 --> Widders has joined #instantbird
03:43:24 <-- Widdershins has quit (Ping timeout: 121 seconds)
04:26:59 <instant-buildbot> build #1335 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1335
05:19:57 <instant-buildbot> build #2586 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2586
05:27:41 <instant-buildbot> build #1658 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1658
05:55:00 --> sherief has joined #instantbird
06:10:03 --> DGMurdockIII has joined #instantbird
06:48:16 --> nhnt11 has joined #instantbird
06:48:16 * ChanServ sets mode +h nhnt11 
06:48:24 <-- DGMurdockIII has quit (Quit: Leaving)
06:57:08 <-- nhnt11 has quit (Connection closed)
06:57:21 --> nhnt11 has joined #instantbird
06:57:21 * ChanServ sets mode +h nhnt11 
07:00:26 --> nhnt12 has joined #instantbird
07:00:26 * ChanServ sets mode +h nhnt12 
07:01:29 <-- nhnt11 has quit (Ping timeout: 121 seconds)
07:01:29 * nhnt12 is now known as nhnt11 
07:12:43 --> DGMurdockIII has joined #instantbird
07:15:27 <-- nhnt11 has quit (Connection closed)
07:15:33 --> nhnt11 has joined #instantbird
07:15:33 * ChanServ sets mode +h nhnt11 
07:22:41 <-- nhnt11 has quit (Connection closed)
07:22:46 --> nhnt11 has joined #instantbird
07:22:46 * ChanServ sets mode +h nhnt11 
07:24:21 * Fallen|away is now known as Fallen 
07:30:19 <-- nhnt11 has quit (Ping timeout: 121 seconds)
07:47:51 --> nhnt11 has joined #instantbird
07:47:51 * ChanServ sets mode +h nhnt11 
07:50:23 <-- nhnt11 has quit (Connection closed)
07:50:27 --> nhnt11 has joined #instantbird
07:50:27 * ChanServ sets mode +h nhnt11 
08:01:34 * nhnt11 is working on a gloda patch or two
08:02:28 <-- nhnt11 has quit (Connection closed)
08:02:32 --> nhnt11 has joined #instantbird
08:02:32 * ChanServ sets mode +h nhnt11 
08:02:39 <nhnt11> 13:31:20 * nhnt11 is working on a gloda patch or two
08:09:58 <-- micahg has quit (Ping timeout: 121 seconds)
08:19:18 <-- nhnt11 has quit (Connection closed)
08:19:22 --> nhnt11 has joined #instantbird
08:19:22 * ChanServ sets mode +h nhnt11 
08:21:53 <-- nhnt11 has quit (Connection closed)
08:21:57 --> nhnt11 has joined #instantbird
08:21:57 * ChanServ sets mode +h nhnt11 
08:32:00 <-- nhnt11 has quit (Ping timeout: 121 seconds)
08:55:44 --> Tonnes has joined #instantbird
09:38:19 --> Bollebib has joined #instantbird
09:43:44 <instant-buildbot> build #246 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/246
10:16:47 <-- EionRobb has quit (Quit: Leaving.)
11:55:47 <-- mudpit has quit (Ping timeout: 121 seconds)
12:13:25 --> mudpit has joined #instantbird
12:19:13 <-- BWMerlin has quit (Client exited)
13:00:56 <-- mudpit has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:01:05 --> mudpit has joined #instantbird
13:31:06 --> gerard-majax has joined #instantbird
14:18:24 --> micahg has joined #instantbird
14:35:49 * Fallen is now known as Fallen|away 
14:43:25 --> Mnyromyr has joined #instantbird
14:57:52 <-- Tonnes has quit (Connection closed)
15:02:50 --> Tonnes has joined #instantbird
15:06:26 <-- mudpit has quit (Ping timeout: 121 seconds)
15:13:17 --> mudpit has joined #instantbird
15:28:32 --> mconley has joined #instantbird
15:28:47 <-- mconley has quit (Connection closed)
15:29:18 --> Nazadel has joined #instantbird
15:31:59 --> swills has joined #instantbird
15:32:29 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:07:59 --> gerard-majax has joined #instantbird
16:45:21 --> mpmc has joined #instantbird
16:51:39 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:51:47 --> flo-retina has joined #instantbird
16:51:47 * ChanServ sets mode +qo flo-retina flo-retina 
18:22:44 --> aleth has joined #instantbird
18:22:44 * ChanServ sets mode +o aleth 
18:29:43 <-- Widders has quit (Ping timeout: 121 seconds)
18:40:34 --> Defman has joined #instantbird
19:09:07 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:09:11 --> myk has joined #instantbird
19:09:22 --> flo-retina has joined #instantbird
19:09:22 * ChanServ sets mode +qo flo-retina flo-retina 
19:11:28 --> abdelrhman has joined #instantbird
19:13:05 <abdelrhman> aleth: in bug 954960, It works fine but I does not follow standard as described in xep-0045 and comment 1
19:13:08 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954960 enh, --, ---, nobody, NEW, It should be possible to create a new XMPP MUC from Instantbird
19:13:28 <abdelrhman> for Instant rooms and reserved rooms
19:13:50 <abdelrhman> http://xmpp.org/extensions/xep-0045.html#createroom
19:13:58 <-- aleth has quit (Ping timeout: 121 seconds)
19:22:39 --> aleth has joined #instantbird
19:22:39 * ChanServ sets mode +o aleth 
19:28:13 <abdelrhman> aleth: in bug 954960, It works fine but I does not follow standard as described in xep-0045 and comment 1
19:28:16 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=954960 enh, --, ---, nobody, NEW, It should be possible to create a new XMPP MUC from Instantbird
19:28:29 <abdelrhman> so we need to change that, right?
19:28:33 <abdelrhman> for Instant rooms and reserved rooms
19:29:23 <aleth> Yes, it should follow the XEP. It probably means you are connecting to a server that is tolerating IB not doing the right thing, but other servers might not be so friendly ;)
19:29:43 <aleth> What's a reserved room? One with a password?
19:30:05 <abdelrhman> no, it needs to be configured once is created
19:30:33 <abdelrhman> but instant tells the server to apply defaults
19:30:39 <aleth> Maybe you can do reserved rooms in a separate bug once you get the more easier "standard" rooms working.
19:31:28 <abdelrhman> aha, the room acknowledges client with code 201 to tell this room needs to be configured
19:31:55 <abdelrhman> then client must send one of 2 ways instant or reserved
19:32:26 <aleth> OK
19:37:25 <-- myk has quit (Ping timeout: 121 seconds)
19:42:46 --> EionRobb has joined #instantbird
19:52:04 <abdelrhman> aleth: in example 154 (http://xmpp.org/extensions/xep-0045.html#createroom). what is the best way to catch all status elements
19:54:35 <-- aleth has quit (Quit: :tiuQ)
19:54:39 --> aleth has joined #instantbird
19:54:39 * ChanServ sets mode +o aleth 
19:56:46 <aleth> abdelrhman: getElements?
19:56:58 <aleth> Look at xmpp-xml.jsm
19:59:17 <abdelrhman> thanks :)
20:04:35 <-- Tonnes has quit (Connection closed)
20:07:46 --> Tonnes has joined #instantbird
20:36:48 <-- aleth has quit (Ping timeout: 121 seconds)
20:56:11 --> aleth has joined #instantbird
20:56:11 * ChanServ sets mode +o aleth 
20:56:17 <-- aleth has quit (Quit: :tiuQ)
20:56:38 --> aleth has joined #instantbird
20:56:38 * ChanServ sets mode +o aleth 
21:20:24 <abdelrhman> aleth: in example 160 after receiving successful creation, do we need to print system message on this coversation?
21:22:07 <aleth> abdelrhman: No, the expectation is that things will work. When receiving this you can mark the room as joining=false, left=false.
21:24:06 <aleth> But maybe that only applies to reserved rooms
21:24:17 <abdelrhman> ok
21:25:47 <aleth> Looks like example 154 already acts as room creation confirmation for instant rooms?
21:26:29 <aleth> Hmm, no, because the room is locked until example 155 is sent
21:26:47 <abdelrhman> no, It acknowledges only
21:27:12 <aleth> Yes, looks like there's a whole sequence of messages needed until the room is fully joined.
21:27:42 <abdelrhman> but here I depend only on code 201 to illustrate it needs configured, right?
21:28:11 <abdelrhman> the room MUST include extended presence information indicating the user's status as an owner and acknowledging that the room has been created (via status code 201)
21:28:13 <aleth> There are a huge number of codes, you can't handle them all in one bug ;)
21:28:31 <aleth> Just include what's needed for this.
21:28:38 <abdelrhman> aha, ok
21:28:50 <aleth> see section 11
21:34:48 <aleth> ok, not that huge: http://xmpp.org/registrar/mucstatus.html
21:36:48 <aleth> some of those we clearly should implement in other bugs (e.g. removal from room)
21:40:13 <abdelrhman> ok, I want ask about example 153
21:40:57 <abdelrhman> https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#700
21:41:14 <abdelrhman> in the case of if not
21:41:41 <abdelrhman> x will be null
21:41:45 <aleth> looks like a bug
21:41:54 <abdelrhman> but per xep-0045
21:42:04 <abdelrhman> <x xmlns='http://jabber.org/protocol/muc'/>
21:42:27 <aleth> yes, you are completely right. fix it?
21:42:28 <abdelrhman> I handled that in this bug
21:42:56 <abdelrhman> I just want to check if it's accepted to be sent without it
21:43:43 <aleth> No, we should always follow the spec. The current XMPP code is still quite incomplete
21:44:39 <aleth> If you spot a mistake, fix it :-)
21:44:50 <abdelrhman> ok
21:59:50 --> mconley has joined #instantbird
22:03:30 <-- abdelrhman has quit (Quit: Leaving)
22:14:33 <-- EionRobb has quit (Ping timeout: 121 seconds)
22:14:48 --> EionRobb has joined #instantbird
22:15:17 --> abdelrhman has joined #instantbird
22:22:07 <abdelrhman> can I save muc.onPresenceStanza(aStanza) based on ack. message till receiving confirmation of success
22:22:48 <abdelrhman> example 154
22:24:26 <aleth> what do you mean by "save"?
22:25:16 <-- Defman has quit (A TLS packet with unexpected length was received.)
22:26:05 <abdelrhman> adding :)
22:26:06 <abdelrhman> https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#1016
22:26:25 <abdelrhman> because confirmation of success comes as iq
22:26:49 <abdelrhman> which is received at https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#947
22:33:50 <aleth> When you send the iq stanza, provide a callback to handle the result
22:35:11 <aleth> Then you don't need to touch onIQStanza
22:36:35 <aleth> A bit like this, only your callback will probably be a bit more complicated https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#
22:36:48 <aleth> https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm?from=xmpp.jsm#1628
22:37:46 <aleth> look at https://dxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp-session.jsm#104
22:39:23 <abdelrhman> and this will not pass anything to onIQStanza to avoid warning message. right?
22:39:46 <aleth> if you return true, yes
22:40:14 <abdelrhman> I think currently callback won't be complicated (instant room)
22:44:17 <-- sherief has quit (Ping timeout: 121 seconds)
22:46:44 <abdelrhman> for example
22:46:45 <abdelrhman> this.sendStanza(s, aStanza => aStanza.attributes["type"] == "result");
22:46:56 <abdelrhman> firstly s will be sent
22:47:54 <abdelrhman> then if a astanza is received  with same id
22:48:06 <abdelrhman> this callback will be executed
22:48:24 <abdelrhman> right?
22:48:26 <aleth> yes
22:49:12 <abdelrhman> this kind of async. so the code will continue in execution in all cases
22:49:21 <aleth> yes
22:49:28 <abdelrhman> ok, thanks :)
22:49:47 <aleth> It has to be async, because you don't know when the server will respond, or the internet connection might die, or whatever...
22:50:15 <abdelrhman> aha
22:50:38 <aleth> You should never "wait" synchronously
22:51:03 <aleth> That goes for any kind of I/O
22:51:07 <abdelrhman> sure :)
22:52:44 --> mudpit1 has joined #instantbird
22:52:55 <-- mudpit has quit (Ping timeout: 121 seconds)
22:53:03 --> mudpit has joined #instantbird
22:54:20 --> myk has joined #instantbird
22:56:46 <-- mudpit1 has quit (Ping timeout: 121 seconds)
23:06:31 <-- Even has quit (Ping timeout: 121 seconds)
23:08:04 * Fallen|away is now known as Fallen 
23:13:24 <-- abdelrhman has quit (Quit: Leaving)
23:25:18 <-- mudpit has quit (Ping timeout: 121 seconds)
23:29:32 * Fallen is now known as Fallen|away 
23:30:25 <-- aleth has quit (Quit: :tiuQ)
23:30:39 <-- myk has quit (Ping timeout: 121 seconds)