All times are UTC.
00:04:18 * Fallen|away is now known as Fallen 00:09:27 <abdelrhman> http://pastebin.instantbird.com/1208297 00:10:18 <-- Tonnes has quit (Ping timeout: 121 seconds) 00:11:28 <aleth> abdelrhman: that looks much better already, have you tested it? 00:11:39 <abdelrhman> Yes :) worked well 00:11:55 <aleth> Great :-) Please attach it to the bug and request review 00:12:11 <aleth> It's easier to give feedback there. 00:12:48 <abdelrhman> ok. I just want to check this this.account.protocol._name (line 495). Is that right?! 00:14:51 <aleth> there is no line 495 in the pastebin. Let's do this on BMO. 00:14:57 <aleth> Not sure what you need the protocol name for though. 00:17:33 * Fallen is now known as Fallen|away 00:20:58 <abdelrhman> patch is attached for bug 1127596 00:21:00 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1127596 nor, --, ---, a.ahmed1026, ASSI, First incoming message from someone who is not a contact is dropped on the floor 00:21:16 <aleth> thanks 00:25:25 <-- mudpit has quit (Ping timeout: 121 seconds) 00:37:26 <-- aleth has quit (Quit: :tiuQ) 00:51:28 --> mudpit has joined #instantbird 01:11:23 --> myk has joined #instantbird 01:16:41 --> mudpit1 has joined #instantbird 01:19:31 <-- mudpit has quit (Ping timeout: 121 seconds) 01:19:31 * mudpit1 is now known as mudpit 01:23:47 <-- abdelrhman has quit (Quit: Leaving) 01:42:46 --> mconley has joined #instantbird 01:48:17 <-- Bollebib has quit (Connection closed) 01:54:45 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 02:21:25 <-- Nazadel has quit (Quit: Bye) 02:26:02 <-- myk has quit (Ping timeout: 121 seconds) 02:33:11 <-- mconley has quit (Connection closed) 03:25:00 <instant-buildbot> build #1642 of win32-nightly-default is complete: Failure [4failed hg_1] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1642 03:31:44 --> sawrubh has joined #instantbird 04:58:37 <instant-buildbot> build #1321 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1321 05:07:42 --> mconley has joined #instantbird 05:11:47 --> harshit has joined #instantbird 05:16:18 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 05:18:17 <-- mconley has quit (Connection closed) 05:27:28 <instant-buildbot> build #2565 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2565 05:33:22 --> DGMurdockIII has joined #instantbird 05:43:45 <-- sawrubh has quit (Quit: Connection closed for inactivity) 06:51:43 --> sherief has joined #instantbird 06:57:03 <-- sherief has quit (Ping timeout: 121 seconds) 07:00:12 * Fallen|away is now known as Fallen 07:55:34 <instant-buildbot> build #232 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/232 07:58:49 --> nhnt11 has joined #instantbird 07:58:49 * ChanServ sets mode +h nhnt11 08:05:32 <-- nhnt11 has quit (Connection closed) 08:05:47 --> nhnt11 has joined #instantbird 08:05:47 * ChanServ sets mode +h nhnt11 08:11:51 <-- nhnt11 has quit (Ping timeout: 121 seconds) 08:12:27 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:12:38 --> Even has joined #instantbird 08:12:38 * ChanServ sets mode +o Even 08:12:47 <-- Even has quit (A TLS packet with unexpected length was received.) 08:12:58 --> Even has joined #instantbird 08:12:58 * ChanServ sets mode +o Even 08:13:17 --> mpmc has joined #instantbird 08:41:23 --> Defman has joined #instantbird 09:35:19 --> gerard-majax has joined #instantbird 09:52:37 --> Bollebib has joined #instantbird 10:28:25 --> hadi has joined #instantbird 10:29:54 <-- hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:30:33 --> hadi has joined #instantbird 10:38:23 <-- EionRobb has quit (Quit: Leaving.) 10:42:37 <-- hadi has quit (Ping timeout: 121 seconds) 10:47:58 --> sherief has joined #instantbird 10:50:02 --> hadi has joined #instantbird 11:00:02 <-- gerard-majax has quit (Ping timeout: 121 seconds) 11:03:02 --> aleth has joined #instantbird 11:03:03 * ChanServ sets mode +o aleth 11:29:05 <-- aleth has quit (Ping timeout: 121 seconds) 11:31:47 <-- hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:45:49 --> aleth has joined #instantbird 11:45:49 * ChanServ sets mode +o aleth 11:46:24 <harshit> aleth, I wanted some help regarding https://bugzilla.mozilla.org/show_bug.cgi?id=1011226 11:46:27 <instantbot> Bug 1011226 nor, --, ---, nobody, NEW, Support setting the topic in XMPP MUCs 11:49:20 --> nhnt11 has joined #instantbird 11:49:20 * ChanServ sets mode +h nhnt11 11:57:02 --> Nazadel has joined #instantbird 12:05:18 <aleth> harshit: You can just ask the questions directly here and whoever knows will help. 12:05:36 <harshit> Got it. 12:06:41 <harshit> I just wanted to confirm if all topic related events are handled here : https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#2073 12:07:09 <harshit> relevant to setting the topic 12:08:22 <aleth> What happens is that the backend (the prpl) sends a notification and the conversation binding listens for it https://dxr.mozilla.org/comm-central/source/im/content/conversation.xml#1910 12:09:02 <aleth> The line you pointed at is just the property getter. 12:09:38 <aleth> https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Tutorial/Adding_Properties_to_XBL-defined_Elements 12:11:14 --> hadi has joined #instantbird 12:12:25 <-- nhnt11 has quit (Connection closed) 12:12:31 --> nhnt11 has joined #instantbird 12:12:31 * ChanServ sets mode +h nhnt11 12:12:44 <-- BWMerlin has quit (Client exited) 12:18:37 <-- Defman has quit (A TLS packet with unexpected length was received.) 12:32:53 <-- sherief has quit (Ping timeout: 121 seconds) 12:50:37 <-- nhnt11 has quit (Ping timeout: 121 seconds) 12:51:20 <-- harshit has quit (Ping timeout: 121 seconds) 13:03:53 --> harshit has joined #instantbird 13:09:12 <-- harshit has quit (Ping timeout: 121 seconds) 13:16:09 --> gerard-majax has joined #instantbird 13:19:21 <-- aleth has quit (Ping timeout: 121 seconds) 13:21:02 --> aleth has joined #instantbird 13:21:02 * ChanServ sets mode +o aleth 13:37:40 <-- hadi has quit (Ping timeout: 121 seconds) 13:43:12 <-- aleth has quit (Ping timeout: 121 seconds) 13:58:57 --> clokep has joined #instantbird 13:58:57 * ChanServ sets mode +o clokep 14:19:33 --> aleth has joined #instantbird 14:19:33 * ChanServ sets mode +o aleth 14:34:46 --> MattATobin has joined #instantbird 14:35:35 <-- Tobin has quit (Ping timeout: 121 seconds) 15:02:14 --> Mnyromyr has joined #instantbird 15:11:00 <-- DGMurdockIII has quit (Quit: Leaving) 15:17:45 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:45:54 <-- Widdershins has quit (Ping timeout: 121 seconds) 15:52:35 <-- MattATobin has quit (Ping timeout: 121 seconds) 16:16:37 --> sawrubh has joined #instantbird 16:27:41 <clokep> Meh someone updated Simple TB build. 16:27:45 <clokep> I should see if I need to port. 16:55:23 --> abdelrhman has joined #instantbird 16:56:33 <abdelrhman> aleth: I attached updated patch for bug 1127596 16:56:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1127596 nor, --, ---, a.ahmed1026, ASSI, First incoming message from someone who is not a contact is dropped on the floor 16:56:42 <clokep> Thanks! :) 16:56:54 <aleth> abdelrhman: I know, I get emails ;) 16:57:06 <abdelrhman> :) 17:09:33 <aleth> abdelrhman: by the way, if you don't understand why a particular review comment, please ask/ 17:10:09 --> nhnt11 has joined #instantbird 17:10:09 * ChanServ sets mode +h nhnt11 17:15:55 --> Defman has joined #instantbird 17:17:30 <-- aleth has quit (Connection closed) 17:17:34 --> aleth has joined #instantbird 17:17:34 * ChanServ sets mode +o aleth 17:22:46 <abdelrhman> I know what you mean :) 17:22:48 <abdelrhman> https://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm?from=jsProtoHelper.jsm#506 17:23:20 <abdelrhman> but I added that to be like userName, contactDisplayName 17:24:19 <aleth> But you can check (which is a good idea - I might have overlooked something) that what you added always gives the same result, so the extra code is not needed. 17:24:56 --> harshit has joined #instantbird 17:27:30 <abdelrhman> I'm little confused because I'm new to work on this(XMPP). but soon I'll get used to it ;) 17:28:10 <aleth> That's normal ;) 17:28:57 <abdelrhman> :) 17:43:51 <clokep> Some of that code is a web to get through. :) 17:44:00 <clokep> I think ale th and I know it fairly well now though. 17:44:09 <clokep> I still get surprised occasionally! 17:44:53 <-- nhnt11 has quit (Ping timeout: 121 seconds) 17:45:05 <abdelrhman> :D 17:46:09 <aleth> Anything with buddies is complicated ;) 17:46:14 <abdelrhman> aleth: I think commit message is ok 17:46:19 <abdelrhman> https://bug1127596.bugzilla.mozilla.org/attachment.cgi?id=8571057 17:46:21 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1127596 nor, --, ---, a.ahmed1026, ASSI, First incoming message from someone who is not a contact is dropped on the floor 17:50:18 <abdelrhman> Aha, you meant the message itself (to be more specific) .. sorry for missing that! 17:51:27 * clokep sighs. 17:54:27 --> clokep_work has joined #instantbird 17:54:27 * ChanServ sets mode +o clokep_work 17:54:38 <clokep_work> aleth: So did we have ideas about the mac failure on that push? 17:54:42 <clokep_work> Or you think it's intermittant? 17:55:17 <aleth> I don't know, I'd just push to try with the Linux fix and find out. 17:55:45 <aleth> But I didn't spend a lot of time staring at the Mac log, so... 17:56:22 <clokep> OK. 17:56:25 <clokep> I didn't know what else to try... 17:56:27 <clokep> Hm... 17:57:44 * clokep_work pushed! 18:01:46 <-- clokep_work has quit (Ping timeout: 121 seconds) 18:12:16 --> nhnt11 has joined #instantbird 18:12:16 * ChanServ sets mode +h nhnt11 18:21:12 <-- nhnt11 has quit (Ping timeout: 121 seconds) 18:22:18 --> myk has joined #instantbird 18:25:16 <instantbot> aleth@instantbird.org changed the Resolution on bug 1127596 from --- to FIXED. 18:25:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1127596 nor, --, 1.6, a.ahmed1026, RESO FIXED, First incoming message from someone who is not a contact is dropped on the floor 18:26:20 <-- myk has quit (Ping timeout: 121 seconds) 18:28:13 --> myk has joined #instantbird 18:28:45 <abdelrhman> now I'm going to work on bug 1087357. Do you have rooms to test on it ? 18:28:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1087357 nor, --, ---, nobody, NEW, XMPP does not detect when rooms are private and cannot be joined 18:30:23 --> flo-retina has joined #instantbird 18:30:23 * ChanServ sets mode +qo flo-retina flo-retina 18:30:56 <aleth> abdelrhman: No, you'll have to find some and/or make your own rooms. 18:31:28 <aleth> It should be possible to create rooms using "Join Chat" 18:32:13 <aleth> Don't forget to look at the spec to see how this should work http://xmpp.org/extensions/xep-0045.html 18:32:20 <clokep> That's currently supported or do you mean that it'd be nice if we did... 18:32:49 <aleth> If it's not supported, then a bug should be filed and it should probably be fixed too ;) 18:33:01 <aleth> MUC support is pretty incomplete at the moment. 18:33:11 * clokep is 87% sure we don't support it... 18:36:00 <abdelrhman> Do I need to handle all cases or this case ("Registration Required")? 18:37:36 <instantbot> New Chat Core - XMPP bug 1138183 filed by aleth@instantbird.org. 18:37:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1138183 nor, --, ---, aleth, ASSI, Get rid of the XMPP account buddy contactDisplayName 18:38:20 <aleth> abdelrhman: what are the other cases? 18:38:37 <aleth> Start by looking at the spec and figure out what error handling code is missing. 18:38:50 <abdelrhman> ok 18:39:34 <aleth> Also look at a debug log for this case and you'll likely discover what incoming stanza is not being handled. 18:40:33 --> mconley has joined #instantbird 18:46:24 <clokep> aleth: Thanks for not r?ing me on that. :) 18:52:29 --> AlexanderSalas has joined #instantbird 18:53:16 <flo-retina> aleth: did you remove (r+'ed the removal) of a normalizedName getter in xmpp.jsm? 18:53:41 <aleth> Yes 18:54:41 <flo-retina> is there another normalizedName getter inherited somehow? 18:54:52 <aleth> From jsProtoHelper. 18:55:40 <flo-retina> ah, "get normalizedName() this._account.normalize(this.name)" 18:56:01 <flo-retina> MUC private messages will be 'interesting' :-/ 18:56:04 <clokep> Don't question aleth on normalizing things. ;) 18:56:26 <flo-retina> clokep: I was shocked to see aleth was now denormalizing things ;) 18:58:54 <-- aleth has quit (Ping timeout: 121 seconds) 19:00:35 <clokep> Meh, my Mac try-build busted again. 19:01:34 <flo-retina> is it the same error? 19:02:40 --> clokep_work has joined #instantbird 19:02:40 * ChanServ sets mode +o clokep_work 19:02:40 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:02:44 --> clokep_work has joined #instantbird 19:02:44 * ChanServ sets mode +o clokep_work 19:02:49 <clokep_work> flo-retina: No. New one. 19:02:57 --> sherief has joined #instantbird 19:03:24 <clokep_work> Failed during configure. 19:03:40 <clokep_work> flo-retina: You have any idea about the failed Windows nightly? 19:03:43 <clokep_work> It failed during hg? 19:07:33 --> mudpit1 has joined #instantbird 19:09:27 <flo-retina> clokep_work: yeah 19:09:32 <flo-retina> clokep_work: it's a good old buildbot bug 19:09:42 <clokep_work> Buildbot has no bugs! :P 19:09:54 <flo-retina> if the hg pull fails for some reason (and it did 2 days ago), buildbot rm -rf the whole tree 19:10:15 <flo-retina> which means it then has to hg clone the whole repo, which more or less never works for m-c, as all bundle users know very well ;) 19:10:45 <-- mudpit has quit (Ping timeout: 121 seconds) 19:10:45 * mudpit1 is now known as mudpit 19:11:00 <flo-retina> we could retrigger until we are lucky and the clone finishes 19:11:24 <flo-retina> or if we are persistently unlucky, someone will have to vnc into that VM and clone (err, unbundle) by hand. 19:12:35 <clokep_work> That's really annoying. :( 19:15:10 <flo-retina> note that we already have a work around in place for the most common occurrence of that bug 19:15:43 <flo-retina> whenever we switch between building nightlies and building RCs, buildbot sees that the configuration has changed, so it rm -rf's the whole tree... 19:16:23 <flo-retina> to save on the m-c clone failures for that case, we actually have more buildbot steps so that we have a separate m-c local cache at a different path, and that one isn't removed (in theory) 19:16:36 <flo-retina> failing to pull still causes it to be destroyed, as we just saw 19:16:47 <-- myk has quit (Ping timeout: 121 seconds) 19:18:19 <-- harshit has quit (Quit: Leaving) 19:19:41 <clokep_work> :-\ 19:19:54 <clokep_work> Well it's not a huge deal. 19:22:31 <flo-retina> pulling a day of changesets is usually fast enough that it's unlikely to fail 19:23:55 <clokep_work> Right but repulling m-c takes a while. 19:23:59 <clokep_work> I don't think I've ever done it hahah. 19:26:17 <flo-retina> with a 100Mbps connection it's in theory not that bad 19:26:34 --> EionRobb has joined #instantbird 19:28:47 --> aleth has joined #instantbird 19:28:47 * ChanServ sets mode +o aleth 19:29:54 <aleth> ugh, aliases :-/ 19:31:30 --> unghost has joined #instantbird 19:32:29 * aleth knew it wasn't a good sign to see that XMPP prpl setting _alias 19:32:30 <clokep_work> I still don't understand our aliases. :-[ 19:34:22 <aleth> flo-retina: yes, it was because MUC participants will be tricky that I thought it was a good idea to reduce the amount of current complexity 19:35:57 <aleth> I'm not sure I understand the expected behaviour of aliases 19:37:35 --> bernard has joined #instantbird 19:37:45 <-- bernard has quit (Quit: Leaving.) 19:38:08 --> bernard has joined #instantbird 19:38:27 <-- bernard has quit (Quit: Leaving.) 19:39:57 <EionRobb> how many aliases do you have? 19:40:34 <-- clokep_work has quit (Ping timeout: 121 seconds) 19:42:19 <flo-retina> EionRobb: probably about 4? :-P 19:42:26 <EionRobb> yeah, that's about right 19:43:23 <aleth> 4? 19:43:59 * aleth knows about the contact display name and a server alias 19:44:58 <EionRobb> what kind of server alias? the alias the other buddy has set for themselves, or the alias you've set them. there's also a local alias for setting the other buddy's alias if its not server-stored 19:48:09 * aleth sighs 19:50:43 <flo-retina> and you missed the account alias 19:50:51 <flo-retina> that's how you get to 4 :) 19:50:52 <EionRobb> oh yeah 19:50:58 <EionRobb> that's 5, right? 19:51:23 --> abdelrhman_ has joined #instantbird 19:52:50 <clokep> Can someone like draw a diagram of this stuff for me? :-S 19:53:49 <clokep> (Connecting those to what they are on the interfaces ;)) 19:53:56 <-- abdelrhman has quit (Ping timeout: 121 seconds) 19:54:26 <flo-retina> I thought I wrote a wiki page about that at some point 19:55:06 <flo-retina> clokep: it unfortunately gets a lot more complicated when looking at the interfaces 19:55:19 <flo-retina> because each interface has only one kind of alias 19:55:59 <flo-retina> the name as the other person wants it to appear is on the prplIAccountBuddy 19:56:05 <flo-retina> the server stored alias is on the imIBuddy 19:56:12 <flo-retina> the local alias is on the imIContact 19:56:21 <flo-retina> and the account alias is on the imIAccount 19:57:14 <flo-retina> so there's code dancing around between the interfaces to access the right alias in some places (that's what aleth just hit btw. Code on the prplIAccountBuddy attempting to access something that's only on the imIContact... which in theory should never be accessed by the prpls) 19:59:18 <EionRobb> what about your own server-set alias? 19:59:40 <clokep> Yeah...it seems like the prplIAccountBuddy should have two... 20:01:04 <EionRobb> (in libpurple that's done via prpl_info->{get|set}_public_alias) 20:02:39 <flo-retina> EionRobb: aaah! 20:02:46 <flo-retina> EionRobb: I had completely missed that one 20:03:02 <EionRobb> I think we need more aliases 20:03:06 <EionRobb> :) 20:03:08 <flo-retina> EionRobb: we don't have UI to set it per-account, it's the global user display name in the IB UI. 20:03:29 <flo-retina> but I'm pretty sure the idl interfaces support setting it per account 20:05:28 <-- mconley has quit (Connection closed) 20:10:38 <EionRobb> do you treat "real name" separate from aliases? :) 20:12:13 <flo-retina> in this conversation, no. 20:12:26 <flo-retina> in the code, half the things we mentioned aren't 'alias' 20:12:44 <EionRobb> oh 20:31:54 <-- EionRobb has quit (Connection closed) 20:33:45 <-- sawrubh has quit (Quit: Connection closed for inactivity) 20:34:34 --> myk has joined #instantbird 20:34:57 --> abdelrhman__ has joined #instantbird 20:37:22 <-- abdelrhman_ has quit (Ping timeout: 121 seconds) 20:43:05 --> EionRobb has joined #instantbird 20:44:25 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 20:49:32 --> mudpit1 has joined #instantbird 20:50:31 <-- mudpit has quit (Ping timeout: 121 seconds) 20:50:31 * mudpit1 is now known as mudpit 20:54:56 <-- clokep has quit (Ping timeout: 121 seconds) 21:02:22 <-- abdelrhman__ has quit (Quit: Leaving) 21:06:54 --> DGMurdockIII has joined #instantbird 21:09:25 <-- DGMurdockIII has quit (Quit: Leaving) 21:10:53 <-- myk has quit (Ping timeout: 121 seconds) 21:18:25 <-- Bollebib has quit (Connection closed) 21:21:18 --> myk has joined #instantbird 21:29:23 <-- myk has quit (Ping timeout: 121 seconds) 21:33:06 <-- mudpit has quit (Connection closed) 21:34:44 --> mudpit has joined #instantbird 21:44:08 <-- flo-retina has quit (Ping timeout: 121 seconds) 21:50:25 <-- Defman has quit (A TLS packet with unexpected length was received.) 22:46:17 --> Tonnes has joined #instantbird 22:53:06 <-- aleth has quit (Quit: :tiuQ) 23:00:20 --> aleth has joined #instantbird 23:00:20 * ChanServ sets mode +o aleth 23:02:51 <instantbot> New Instantbird - Conversation bug 1138244 filed by aleth@instantbird.org. 23:02:52 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1138244 nor, --, ---, nobody, NEW, Contact display name changes don't propagate to open conversations 23:12:49 <-- unghost has quit (A TLS packet with unexpected length was received.) 23:25:12 <-- aleth has quit (Quit: :tiuQ) 23:48:01 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.91.1 [SeaMonkey 2.32/20150112202503])