All times are UTC.
00:17:31 <EionRobb1> its like most software, its either really technically awesome/secure/pretty or it has all the users 00:56:56 --> mconley has joined #instantbird 01:11:38 <-- Nazadel has quit (Quit: Bye) 01:18:12 <-- arlolra has quit (Client exited) 01:22:44 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:37:16 <-- EionRobb1 has quit (Quit: Leaving.) 01:46:33 <-- aleth has quit (Ping timeout: 121 seconds) 01:54:52 <-- Mook_as has quit (Client exited) 02:01:04 <-- mconley has quit (Connection closed) 02:21:46 <-- Rym has quit (Connection closed) 02:22:04 --> Rym has joined #instantbird 02:38:31 --> sawrubh has joined #instantbird 02:38:44 --> EionRobb has joined #instantbird 02:47:07 --> harshit has joined #instantbird 02:57:27 <-- Mnyromyr has quit (Connection closed) 03:15:06 --> mconley has joined #instantbird 03:18:39 <instant-buildbot> build #1632 of win32-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1632 03:27:45 <-- sherief has quit (Ping timeout: 121 seconds) 03:38:27 --> clokep_work has joined #instantbird 03:38:27 * ChanServ sets mode +o clokep_work 04:28:46 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:39:10 --> arlolra has joined #instantbird 04:39:27 <-- arlolra has quit (Client exited) 04:50:02 <-- mconley has quit (Connection closed) 04:50:35 <-- harshit has quit (Quit: Leaving) 04:55:40 --> Bollebib has joined #instantbird 05:01:23 <instant-buildbot> build #1312 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1312 05:01:23 <-- EionRobb has quit (Quit: Leaving.) 05:06:49 <instant-buildbot> build #2547 of macosx-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2547 05:45:42 <-- Bollebib has quit (Connection closed) 06:05:13 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 06:05:21 --> AlexanderSalas has joined #instantbird 06:17:42 --> mudpit has joined #instantbird 06:59:53 <instant-buildbot> build #223 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/223 07:00:35 --> mudpit1 has joined #instantbird 07:02:53 <-- mudpit has quit (Ping timeout: 121 seconds) 07:02:53 * mudpit1 is now known as mudpit 07:05:41 --> gerard-majax has joined #instantbird 07:11:31 <-- AlexanderSalas has quit (Connection closed) 07:11:35 --> AlexanderSalas has joined #instantbird 07:24:33 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 07:31:28 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:33:29 <-- mudpit has quit (Ping timeout: 121 seconds) 07:34:14 --> gerard-majax has joined #instantbird 07:47:54 --> mudpit has joined #instantbird 07:49:36 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:57:45 --> gerard-majax has joined #instantbird 08:07:13 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:07:28 --> gerard-majax has joined #instantbird 08:13:04 <-- gerard-majax has quit (Ping timeout: 121 seconds) 08:33:15 * Fallen|away is now known as Fallen 08:45:54 --> Defman has joined #instantbird 08:55:07 --> gerard-majax has joined #instantbird 09:05:24 --> aleth has joined #instantbird 09:05:24 * ChanServ sets mode +o aleth 09:11:02 <-- flo-retina has quit (Connection closed) 09:11:45 --> flo-retina has joined #instantbird 09:11:45 * ChanServ sets mode +qo flo-retina flo-retina 09:14:09 <-- aleth has quit (Quit: :tiuQ) 09:14:19 --> aleth has joined #instantbird 09:14:19 * ChanServ sets mode +o aleth 09:44:56 --> BWMerlin has joined #instantbird 09:49:18 <-- Rym has quit (Ping timeout: 121 seconds) 10:11:54 --> Nazadel has joined #instantbird 10:16:39 --> Rym has joined #instantbird 10:21:07 <-- Rym has quit (Ping timeout: 121 seconds) 10:22:38 <nhnt11> That distribution fail is intermittent right? 10:22:46 <nhnt11> flo-retina: Can we fire a new mac nightly if so?^ 10:23:08 <nhnt11> Normally I wouldn't mind too much but the lack of commands is... rather annoying 10:23:45 <nhnt11> ah yeah, it's a "lost connection" fail 10:24:28 <flo-retina> yeah, just the wifi not being reliable 10:24:56 <flo-retina> I retriggered it 10:24:59 <nhnt11> Thanks! 10:25:03 <flo-retina> the Windows error looks like it needs to be investigated though 10:27:17 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:29:48 <aleth> flo-retina: bug 1134618 10:29:50 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1134618 maj, --, ---, wgianopoulos, ASSI, Windows build fails with LINK : fatal error LNK1320: /MAXILKSIZE value 0x7FFFFFFF must be between 0x 10:35:46 <nhnt11> aleth: btw I've got no idea about bug 783619 10:35:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=783619 nor, --, ---, nobody, NEW, Some IM conversations are not fully indexed 10:36:16 <nhnt11> I've been keeping an eye out for it for a while now 10:37:06 <nhnt11> bbl 10:55:24 --> flo-retina has joined #instantbird 10:55:24 * ChanServ sets mode +qo flo-retina flo-retina 10:57:04 --> Widders has joined #instantbird 11:10:49 --> Rym has joined #instantbird 11:15:17 <-- Rym has quit (Ping timeout: 121 seconds) 11:23:39 <-- sawrubh has quit (Quit: Connection closed for inactivity) 11:26:32 --> mpmc has joined #instantbird 11:32:10 <-- mudpit has quit (Ping timeout: 121 seconds) 11:42:53 <-- Tonnes has quit (Connection closed) 11:44:48 --> Tonnes has joined #instantbird 12:05:00 --> Rym has joined #instantbird 12:08:45 --> AlexanderSalas has joined #instantbird 12:09:30 <-- Rym has quit (Ping timeout: 121 seconds) 12:10:53 <-- Defman has quit (A TLS packet with unexpected length was received.) 12:12:54 --> sawrubh has joined #instantbird 12:21:54 --> Bollebib has joined #instantbird 12:34:00 <-- aleth has quit (Ping timeout: 121 seconds) 12:37:35 <flo-retina> that wifi is really a PITA :( 12:39:02 <flo-retina> https://wiki.mozilla.org/Community:SummerOfCode15:Brainstorming#Instantbird so is nhnt11 actually willing to mentor a student? 12:53:05 <-- BWMerlin has quit (Client exited) 12:53:26 <-- Tobin has quit (Ping timeout: 121 seconds) 12:59:10 --> Rym has joined #instantbird 13:04:50 <-- Rym has quit (Ping timeout: 121 seconds) 13:12:28 <-- Nazadel has quit (A TLS packet with unexpected length was received.) 13:15:41 --> Nazadel has joined #instantbird 13:17:24 --> clokep_work has joined #instantbird 13:17:24 * ChanServ sets mode +o clokep_work 13:18:19 --> deOmega has joined #instantbird 13:19:47 <deOmega> Good day. Man, I hope that you guys can get the issue with gtalk resolved soon. This is the only instant messenger that simply works to my liking 13:20:35 <deOmega> I have tried so many over the recent past... I just cannot get going. 13:31:42 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 13:37:27 <clokep_work> deOmega: I sent some packet captures yesterday,hopefully that'll help. 13:37:37 <clokep_work> But if you're using nightly builds...flipping that preference fixes it, mostly. 13:50:21 <flo-retina> clokep_work: https://bugzil.la/1134618 â ASSIGNED, wgianopoulos@gmail.com â Windows build fails with LINK : fatal error LNK1320: /MAXILKSIZE value 0x7FFFFFFF must be between 0x 13:50:30 <clokep_work> Thanks. 13:55:07 --> Rym has joined #instantbird 13:57:38 <instant-buildbot> build #2549 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2549 13:59:02 <clokep_work> Oh. :) 13:59:10 <clokep_work> Aha! A partial. 13:59:20 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:59:22 --> clokep_work has joined #instantbird 13:59:22 * ChanServ sets mode +o clokep_work 13:59:26 * clokep_work is happy again! 13:59:36 <-- Rym has quit (Ping timeout: 121 seconds) 14:00:08 <clokep_work> flo-retina: I think nhnt11 said he doesn't think he'll have time to actually mentor a student. 14:00:22 <flo-retina> so why is he listed as mentor on the brainstorm page? 14:00:27 <flo-retina> that's why I didn't move that project over 14:00:36 <nhnt11> Yeah, I'm uncomfortable committing to being a mentor 14:00:41 <nhnt11> I'll definitely be around 14:01:11 <nhnt11> But probably won't be dependable 14:01:39 <clokep_work> flo-retina: Because I didn't get any feedback from people who'd be willing to mentor that. :P 14:02:18 <nhnt11> sorry if I wasn't clear about me being a mentor before btw. I think I only just decided for sure that I'm not comfortable with the idea :) 14:02:33 <nhnt11> Ah, a nightly 14:02:42 <clokep_work> You did put yourself in the spot on the etherpad. ;) 14:03:07 <flo-retina> clokep_work: do you like http://pastebin.instantbird.com/1189431 ? 14:03:16 <clokep_work> flo-retina: So likely aleth would be in a better place to mentor that than me...but I'm sure either of us could do it... 14:03:35 <nhnt11> I guess I was juggling with the idea up till now :] 14:03:45 <flo-retina> oops, wrong channel :-/ 14:07:01 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:07:11 --> nhnt11 has joined #instantbird 14:07:12 * ChanServ sets mode +h nhnt11 14:07:21 * nhnt11 can /me again \o/ 14:08:06 --> aleth_web has joined #instantbird 14:08:35 * clokep_work \o/ 14:08:46 <clokep_work> nhnt11: You can even do that ^ since (you?) fixed that bug! 14:09:01 <nhnt11> :P 14:09:05 <nhnt11> That was me, yeah 14:09:10 <nhnt11> (and atuljangra?) 14:09:10 <deOmega> clokep_work: thank you. I will get it 14:11:34 <clokep_work> deOmega: Not sure what I did, but you're welcome! :) 14:11:46 <clokep_work> Sorry it's been frustrating, it just isn't even clear what needs fixng... 14:20:01 <deOmega> clokep_work: ah, I thought you said you did something or the other :) that if I do nightly and the string in config. that it would resolve it :). 14:20:26 <clokep_work> deOmega: Yes, it's been like that since you first talked to us about the problem. 14:20:32 <clokep_work> I've been running w/o issues reconnecting for a while now. 14:21:05 <deOmega> hmm, i wonder what I could be doing wrong. I just cannot get it to reconnect at all using that string 14:22:55 <clokep_work> "that string"? 14:23:00 <clokep_work> It should be a boolean element, not a string. 14:23:04 <clokep_work> And what version are you on? 14:23:08 <clokep_work> The exact build ID. 14:27:03 --> Mnyromyr has joined #instantbird 14:29:22 <-- Tonnes has quit (Connection closed) 14:29:34 <-- nhnt11 has quit (Ping timeout: 121 seconds) 14:30:19 --> Tonnes has joined #instantbird 14:39:11 <clokep_work> aleth_web: Sorry for the run around on that code. 14:39:15 <clokep_work> I figured while we were touching it... 14:40:46 <aleth_web> No worries. I only noticed later looking at the diff that someone at some point had already made some of those changes in TB. 14:41:13 <aleth_web> It just took longer to make those additional changes than it did to do the port ;) 14:41:35 --> DGMurdockIII has joined #instantbird 14:42:39 <clokep_work> :) 14:42:48 <clokep_work> That was why I wanted the changes done btw. 14:42:51 <clokep_work> So that TB/IB matched. 14:44:08 <aleth_web> :-) 14:49:20 --> Rym has joined #instantbird 14:53:46 <-- Rym has quit (Ping timeout: 121 seconds) 14:58:14 --> nhnt11 has joined #instantbird 14:58:14 * ChanServ sets mode +h nhnt11 15:01:39 <clokep_work> flo-retina: With WebRTC...the connection that gets created is secure, even to a server listening in on the signaling protocol? 15:02:07 <flo-retina> clokep_work: yes and no 15:02:18 <clokep_work> At least the IPs would be leaked, I realize. 15:02:27 <flo-retina> clokep_work: the server handling the signaling could change the SDP, and give its own, and relay 15:02:38 <clokep_work> Ah, true. 15:02:53 <flo-retina> clokep_work: as long as you are sure the signaling server isn't tampering with the SDP, it's secure / encrypted end to end. 15:03:02 <aleth_web> That's actually how those webrtc chatroom servers work afaik 15:03:09 <clokep_work> flo-retina: Is there a reasonable way to ensure it isn't tampering with the SDP? 15:03:33 <flo-retina> clokep_work: having an encrypted signaling server 15:03:42 <flo-retina> OR having keys for the contact you are talking to 15:03:47 <flo-retina> (ie. signing the SDPs) 15:04:16 <aleth_web> If the SDPs go over OTR for example, I suspect the server can't do anything. 15:04:17 <clokep_work> OK. 15:06:21 <aleth_web> Hmm, with our current code I don't think the SDP equivalents would be handled by OTR at all actually, so that was wrong. 15:08:49 <clokep_work> Hmm... aleth_web so, what is the signaling of WebRTC then? 15:09:05 <clokep_work> Alice sends Bob an SDP, Bob then sends Alice an SDP, they then connect over something? 15:09:08 <clokep_work> Is that the whole thing? 15:09:13 <aleth_web> We use XMPP as the signalling channel. 15:09:22 --> mconley has joined #instantbird 15:09:28 <aleth_web> (or IRC in the future...) 15:09:42 <clokep_work> That's not my question. 15:10:05 <clokep_work> I understand that's how we *can* use a signaling channel. 15:10:06 <aleth_web> Once the SDP exchange is complete, you establish a p2p peerConnection, right. 15:10:11 <clokep_work> But I don't know what needs to be sent. 15:11:24 <aleth_web> clokep_work: look at the diagram here https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Architecture/Connectivity 15:12:00 <aleth_web> basically in the simplest case you send an offer, the other side sends back an answer, and then webrtc does the rest. 15:12:24 <clokep_work> aleth_web: https://github.com/clokep/ircv3-specifications/blob/webrtc/webrtc.md 15:12:32 <clokep_work> Yeah, I see. 15:12:36 <clokep_work> That diagram helps. :) 15:13:04 <aleth_web> All we need for IRC is a way to send SDPs (i.e. a bunch of lines of text) 15:13:34 <clokep_work> Oh boo. I didn't format that markdown sanely. 15:13:53 <aleth_web> iirc we had a useful email thread about that? 15:14:08 <-- Widders has quit (Quit: Leaving) 15:14:17 --> Widdershins has joined #instantbird 15:15:23 <clokep_work> We had an email thread about how to encode the SDP. 15:15:44 <clokep_work> IIRC. 15:16:09 <clokep_work> https://groups.google.com/forum/#!topic/mozilla.dev.chat/2lP0WZiflQI 15:16:41 <aleth_web> Yup! And that's more or less all that needs doing I think (apart from the capability detection stuff). 15:16:45 <-- DGMurdockIII has quit (Connection closed) 15:16:56 <aleth_web> Much simpler than XMPP, where we translate SDP to Jingle 15:16:58 <clokep_work> Yeah... 15:17:10 <clokep_work> Ah I do have a netflow in there. 15:17:19 <clokep_work> It's very CTCP centric, which isn't bad...since we'd likely want to support that. 15:17:24 <clokep_work> But isn't very IRCv3. 15:17:27 <clokep_work> I'm unsure I care. :P 15:17:57 <aleth_web> Btw is there a way to edit the draft in a gist or something? 15:18:41 <clokep_work> I don't think I've ever used a gist. 15:18:42 * aleth_web not sure IRCv3 has a good alternative 15:19:39 <clokep_work> https://github.com/ircv3/ircv3-specifications/blob/master/specification/message-intents-3.2.md and https://github.com/ircv3/ircv3-specifications/blob/master/specification/metadata-3.2.md 15:19:42 <clokep_work> Are the closest I see... 15:20:06 <clokep_work> I think the "intents" stuff is how we'd want to do it. 15:20:19 <clokep_work> But it's just a translation, it isn't anything huge. 15:21:06 <clokep_work> Hmm...I need to go in a second. 15:35:48 <-- nhnt11 has quit (Ping timeout: 121 seconds) 15:35:56 --> nhnt11 has joined #instantbird 15:35:57 * ChanServ sets mode +h nhnt11 15:43:25 --> Rym has joined #instantbird 15:47:05 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:47:55 <-- Rym has quit (Ping timeout: 121 seconds) 15:50:18 --> sherief has joined #instantbird 15:52:54 <clokep_work> aleth_web: https://github.com/clokep/ircv3-specifications/blob/webrtc/webrtc.md is a bit more updated now. :) 15:53:17 <clokep_work> Probably needs a bit of links, etc. 15:54:12 --> myk has joined #instantbird 15:55:07 <clokep_work> aleth_web: https://gist.github.com/clokep/f7a07fa9e0bdcfe8cf6a actually. 15:58:15 <clokep_work> Since you wanted a gist. :P 16:01:19 <clokep_work> That should work better for comments and such. 16:01:34 <clokep_work> OH NO IT WAS FORKED. 16:02:28 <aleth_web> Bah, I thought gist was like an etherpad. But noooo... it forks. 16:02:44 <clokep_work> Yeah. 16:03:08 <clokep_work> I don't think I can add you as an author. :( 16:03:12 <clokep_work> We can do it in etherpad if you want? 16:03:14 <aleth_web> ...github :-( 16:05:00 <aleth_web> Whatever is easiest. I've got to go for a bit tho 16:05:10 <clokep_work> I'm going to leave it for the moment. 16:05:13 <clokep_work> Cause I'm lazy. 16:05:16 <clokep_work> And I like that it renders it. 16:21:22 <-- clokep_work has quit (Ping timeout: 121 seconds) 16:29:46 --> Defman has joined #instantbird 16:29:53 <-- nhnt11 has quit (Ping timeout: 121 seconds) 16:37:35 --> Rym has joined #instantbird 16:39:27 --> mudpit has joined #instantbird 16:40:44 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:42:04 <-- Rym has quit (Ping timeout: 121 seconds) 16:46:37 <-- myk has quit (Connection closed) 16:46:41 --> myk has joined #instantbird 16:50:43 <-- myk has quit (Ping timeout: 121 seconds) 16:58:14 --> kapy has joined #instantbird 17:00:23 <-- kapy has quit (Connection closed) 17:06:15 --> myk has joined #instantbird 17:09:59 --> kapy has joined #instantbird 17:12:53 --> gerard-majax has joined #instantbird 17:18:54 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:18:56 --> myk has joined #instantbird 17:26:02 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:26:47 --> Mook_as has joined #instantbird 17:27:03 --> gerard-majax has joined #instantbird 17:30:34 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:31:45 --> Rym has joined #instantbird 17:32:10 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:32:58 <Mook_as> And today is the first day I get to see the dashed red line! Thanks again! 17:38:37 --> gerard-majax has joined #instantbird 17:48:29 <-- kapy has quit (Quit: ) 17:51:06 <-- Bollebib has quit (Ping timeout: 121 seconds) 17:53:46 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:55:23 --> gerard-majax has joined #instantbird 18:02:42 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:08:30 --> gerard-majax has joined #instantbird 18:17:49 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:20:48 --> gerard-majax has joined #instantbird 18:35:19 <-- gerard-majax has quit (Ping timeout: 121 seconds) 18:40:51 --> aleth has joined #instantbird 18:40:52 * ChanServ sets mode +o aleth 18:41:03 <-- aleth_web has left #instantbird ("") 18:41:47 --> Rym_ has joined #instantbird 18:42:49 <-- Rym has quit (Ping timeout: 121 seconds) 18:58:23 <-- Defman has quit (Quit: Bye.) 18:58:26 --> Defman has joined #instantbird 19:09:09 --> nhnt11 has joined #instantbird 19:09:09 * ChanServ sets mode +h nhnt11 19:09:44 --> AlexanderSalas has joined #instantbird 19:15:03 <nhnt11> I'm actually rather surprised by bug 1069845 19:15:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1069845 maj, --, ---, nobody, NEW, Viewing logs from faceted search results is broken 19:15:19 <nhnt11> Seems like I "missed a spot" with async logs 19:15:38 <nhnt11> But I'm rather sure I did a thorough MXR search and replaced every usage of the logger.js api 19:16:11 <aleth> At least that probably means the fix is easy? 19:16:13 * nhnt11 starts debugging 19:16:21 <nhnt11> Well, that's my current gues 19:16:23 <nhnt11> guess* 19:16:25 <nhnt11> let's see.. 19:19:32 --> gerard-majax has joined #instantbird 20:10:22 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:29:50 --> gerard-majax has joined #instantbird 20:31:51 <-- Rym_ has quit (Ping timeout: 121 seconds) 20:34:45 <-- gerard-majax has quit (Ping timeout: 121 seconds) 20:41:07 --> Rym_ has joined #instantbird 20:43:17 <-- aleth has quit (Ping timeout: 121 seconds) 20:44:03 <-- AlexanderSalas has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 20:45:52 --> aleth has joined #instantbird 20:45:53 * ChanServ sets mode +o aleth 20:47:54 --> Bollebib has joined #instantbird 20:56:19 <instantbot> New Instantbird - Conversation bug 1135224 filed by arlolra@gmail.com. 20:56:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1135224 nor, --, ---, nobody, UNCO, Be consistent about which conversation is set on the outgoing message 21:12:00 <-- Defman has quit (A TLS packet with unexpected length was received.) 21:14:55 --> EionRobb has joined #instantbird 21:21:13 --> nhnt11-tb has joined #instantbird 21:27:54 <aleth> nhnt11: current state of play is grab the addon from Fallen and use that. 21:28:09 <nhnt11> aleth: I think it'd be nice to have the conversations/contacts side bar in Thunderbird chat to be vibrant like what Fallen did with the Ib participant list 21:28:52 <aleth> nhnt11: yes, the TB UI needs a bit of TLC. Paenglab said he might look into it 21:29:47 <nhnt11> hmm 21:29:51 * nhnt11 adds some stack dumps 21:29:53 <-- nhnt11-tb has quit (Client exited) 21:30:49 <nhnt11> aleth: I assume |mach build mail| builds chat/ too. that right? 21:30:57 --> nhnt11-tb has joined #instantbird 21:31:11 <nhnt11> it does, cool 21:31:12 <aleth> No, nobody has ever added the dependencies for TB like I did for IB. 21:31:24 <-- myk has quit (Ping timeout: 121 seconds) 21:31:25 <aleth> If it works that's surprising! 21:31:36 <nhnt11> I made a change to logger.js and it got picked up. 21:32:09 <-- nhnt11-tb has quit (Client exited) 21:32:14 <aleth> It's certainly clever enough to pick up on idl changes these days 21:32:48 --> nhnt11-tb has joined #instantbird 21:32:56 <aleth> nhnt11: maybe logger.js is just symlinked into dist anyway 21:33:08 <nhnt11> Maybe. 21:33:20 <nhnt11> Wait what? 21:33:33 <nhnt11> you mean if I just make a change there and run without building it'd work? 21:33:41 <aleth> try it? 21:33:44 <nhnt11> I'm running Daily.app from dist btw 21:33:47 <nhnt11> okay, I will 21:33:49 <nhnt11> that'd be interesting 21:33:55 <nhnt11> I'm pretty sure other files aren't like that though 21:34:08 <nhnt11> I was modifying index_im.js and forgot to build once. changes didn't get picked up iirc 21:34:20 <-- nhnt11-tb has quit (Client exited) 21:34:24 --> nhnt11-tb has joined #instantbird 21:34:35 <nhnt11> nope, doesn't work. needs a build. 21:34:37 <-- nhnt11-tb has quit (Client exited) 21:34:43 <aleth> or a --purgecaches? 21:35:18 --> myk has joined #instantbird 21:35:48 <nhnt11> maybe 21:36:18 <nhnt11> looks like getLogFromFile is trying to create an imILog instance from an empty list of entries 21:36:19 <nhnt11> :S 21:36:37 <nhnt11> brb 21:43:50 <-- myk has quit (Ping timeout: 121 seconds) 21:53:40 <-- sawrubh has quit (Quit: Connection closed for inactivity) 21:53:44 --> myk has joined #instantbird 21:56:48 <-- deOmega has quit (Quit: So easy...but yet complicated.) 21:58:20 <nhnt11> re 22:10:42 <-- Tonnes has quit (Connection closed) 22:13:56 <-- Nazadel has quit (Ping timeout: 121 seconds) 22:34:25 <-- sherief has quit (A TLS packet with unexpected length was received.) 22:41:45 --> nhnt11-tb has joined #instantbird 22:42:36 <nhnt11> re (for real) 22:42:46 <nhnt11> Just added another dump, and got a weird result 22:43:14 <nhnt11> It seems the path passed to getLogFromFile() is |/Users/nhnt11/Library/Thunderbird/Profiles/co03j2sz.default/logs,,Users,nhnt11,Library,Thunderbird,Profiles,co03j2sz.default,logs,irc,nhnt11-tb@irc.mozilla.org,nhnt11,2015-02-19.124609+0530.json| 22:43:24 <nhnt11> What's up with those commas :S 22:43:51 <aleth> :-S 22:43:56 <nhnt11> Oh no 22:44:06 * nhnt11 sighs 22:44:06 <nhnt11> https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#605 22:44:21 <nhnt11> I think I'm using OS.Path.join wrong.. 22:45:09 <nhnt11> I think I want |...path.split("/")| there 22:45:12 <-- nhnt11-tb has quit (Client exited) 22:45:41 <nhnt11> That shouldn't have passed review :( 22:45:47 --> nhnt11-tb has joined #instantbird 22:46:02 <nhnt11> Okay, it's using the right path now. 22:46:10 <aleth> yeah 22:46:32 <nhnt11> Nope, it's not 22:47:00 <nhnt11> it seems I expect |item.log.path| to be a path relative to the logs dir 22:47:04 <nhnt11> but it's not. 22:47:16 <aleth> Have a look at your gloda code to remind you of what format it's in? 22:47:24 <nhnt11> It's a full path 22:47:46 <-- nhnt11-tb has quit (Client exited) 22:47:49 <aleth> uh, so gloda breaks if you move your profile? :-S 22:47:50 --> nhnt11-tb has joined #instantbird 22:48:03 <nhnt11> I don't think so 22:48:04 <aleth> or just the IM index? 22:48:10 <nhnt11> I'm investigating item.log 22:49:01 <-- nhnt11-tb has quit (Client exited) 22:49:20 --> nhnt11-tb has joined #instantbird 22:49:54 <nhnt11-tb> okay, so I've got the bug fixed by giving item.log.path directly to OS.path 22:50:03 <nhnt11-tb> but I want to investigate further why that path isn't relative 22:50:28 <nhnt11-tb> I'm seeing quite a few |TypeError: convView.switchingAwayFromPanel is not a function| btw 22:50:32 <-- nhnt11-tb has quit (Client exited) 22:50:51 <aleth> File a bug for those if they don't go away after you fix things please 22:51:07 <aleth> I never tested search results pages as I knew they were broken... 22:51:24 <aleth> Btw https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#606 not sure you want grouping for paths from gloda results 22:51:27 <nhnt11> Wow, chat-messenger-overlay is full of functions that accept arguments called.... "aArgs" 22:51:52 <aleth> It's not the most fun file ever to work with. 22:51:54 <nhnt11> aleth: I think we want grouping there, for a bit of context 22:52:01 <nhnt11> It'll probably be useful after split logs too 22:52:23 <aleth> Then check the grouping code in logger.js works if the path isn't the first of a group. 22:53:08 <nhnt11> It does ;) 22:53:16 <nhnt11> That code is clever enough :) 22:53:46 <aleth> What I'm worried about is there being a mismatch between the way we refer to a grouped log (first path) and some path sticking around from where getLogFromFile is called. 22:53:47 <nhnt11> IIRC it uses the given file name to calculate the day (by dividing by number of seconds in a day and flooring) and then matches the day to the rest of the files in that directory 22:54:04 --> nhnt11-tb has joined #instantbird 22:54:05 <nhnt11> Yeah, that's what it does 22:54:16 <-- nhnt11-tb has quit (Client exited) 22:54:19 <aleth> So for example this._showLog passes the path 22:54:40 --> nhnt11-tb has joined #instantbird 22:54:43 <aleth> Anyway... 22:54:58 <-- mconley has quit (Connection closed) 22:56:13 <-- nhnt11-tb has quit (Client exited) 22:56:35 <-- EionRobb has quit (Quit: Leaving.) 22:56:51 <aleth> yeah, I suspect using path in https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#608 is not ideal 22:57:12 <aleth> But maybe I'm missing something. 22:58:10 --> mudpit1 has joined #instantbird 22:58:47 <nhnt11> aleth: This is weird 22:58:56 <nhnt11> aleth: This is from before async logs: https://hg.mozilla.org/comm-central/file/0450f5bc266d/mail/components/im/content/chat-messenger-overlay.js#l550 22:59:14 <nhnt11> Which suggests that item.log.path was a relative path before I came along 22:59:25 * nhnt11 is poking around 23:00:12 --> AlexanderSalas has joined #instantbird 23:00:50 <aleth> I suspect there's a bug in index_im and gloda is saving full paths. Which should have been caught on review. 23:01:32 <nhnt11> that line has been assuming that the path is relative since chat-messenger-overlay.js was created. 23:01:45 <nhnt11> Time to see where item.log.path is getting set 23:01:49 <-- mudpit has quit (Ping timeout: 121 seconds) 23:01:49 * mudpit1 is now known as mudpit 23:04:19 <nhnt11> This is no fun :( 23:04:41 <aleth> turning out to be a nasty regression after all :-( 23:05:47 <nhnt11> The "log" object is set over here: https://dxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#117 23:06:01 <nhnt11> I'm trying to follow the trail to _handleArgs() 23:06:07 <nhnt11> Why am I doing this from the source code? 23:06:10 * nhnt11 adds a stack dump 23:06:40 <nhnt11> --purge-caches doesn't work btw, still needs a build 23:06:53 <nhnt11> oh, is it --purgecaches without the hyphen? 23:06:59 --> nhnt11-tb has joined #instantbird 23:06:59 * nhnt11 will try that next time 23:12:42 <nhnt11> Okay, so |item.log| is actually the message property of this binding: https://dxr.mozilla.org/comm-central/source/mail/base/content/glodaFacetBindings.xml#1531 23:13:00 --> mpmc has joined #instantbird 23:13:05 <nhnt11> That line is the onclick listener that opens the search result 23:13:26 <aleth> what a labyrinth... 23:13:47 <nhnt11> So now I need to find out where the message property is set 23:13:47 <aleth> https://hg.mozilla.org/comm-central/diff/946e17f54a95/mail/components/im/modules/index_im.js makes me think index_im has always used full paths as log ids, sadly :-( 23:14:08 <nhnt11> Does that mean faceted log results never worked? :S 23:14:16 <aleth> unless getLogFileForOngoingConversation used to return partial paths? 23:14:53 <aleth> I'd be surprised if it never worked. 23:15:07 <nhnt11> I should try on the Tb stable build I have 23:15:11 <-- nhnt11-tb has quit (Client exited) 23:15:23 --> nhnt11-tb has joined #instantbird 23:15:26 <nhnt11> Async logs hasn't been in a release yet rihgt? 23:15:36 <nhnt11> aleth: It's broken in the stable build 23:15:37 <aleth> I don't think so. Hence the rush now... 23:15:39 <nhnt11> Wow. This sucks 23:15:43 <aleth> Wow indeed. 23:16:04 <nhnt11> I'm using Thunderbird 31.2.0 23:16:06 <nhnt11> which isn't even the latest 23:16:08 <-- nhnt11-tb has quit (Client exited) 23:16:47 * nhnt11 is a bit relieved he didn't cause this bug 23:17:08 <aleth> |let dis = this| o_O 23:17:23 <nhnt11> Where did you find that? :O 23:17:31 <nhnt11> lol 23:17:32 <nhnt11> found it 23:17:33 <nhnt11> wow 23:17:51 * nhnt11 is still chuckling 23:25:05 <nhnt11> So now I'm at https://dxr.mozilla.org/comm-central/source/mail/base/content/glodaFacetView.js#544 23:25:30 <nhnt11> this._activeSet seems to be populated in build" https://dxr.mozilla.org/comm-central/source/mail/base/content/glodaFacetView.js#418 23:27:08 <nhnt11> I think I'm being stupid following this trail 23:27:40 <nhnt11> My hunch is that the path is the same one that's set over here: https://dxr.mozilla.org/comm-central/source/mail/components/im/modules/index_im.js#486 23:27:44 <aleth> You don't really need to know this stuff. 23:27:44 <aleth> Right 23:28:14 <aleth> What's important is whether at any point gloda used to store relative paths. If it didn't then at least index_im is consistent (even if unfortunately so) 23:29:40 <nhnt11> aaaaah 23:29:51 <nhnt11> looks like the stored path was relative indeed: https://hg.mozilla.org/comm-central/file/8a50d60dd7a0/mail/components/im/modules/index_im.js#l425 23:30:11 <nhnt11> Bah, now I'm really annoyed with myself again 23:30:35 <nhnt11> So the reason it's broken for me in 31.2 is because full paths got stored while indexing 23:30:41 <aleth> Right 23:31:07 <aleth> Oh dear, so now we need to worry about migrating the incorrect gloda entries after fixing this. 23:31:36 * aleth wonders if there is a way to trigger a re-sweep 23:31:42 <nhnt11> Is there a way to reindex everything 23:31:42 <nhnt11> yeah 23:34:48 <nhnt11> I'm going to ask on #maildev 23:35:00 <nhnt11> I wonder if anyone'll be online around now.. 23:36:04 <aleth> That won't do you any good. 23:36:18 <nhnt11> Why not? 23:36:19 <aleth> Gloda doesn't even have an active peer right now. 23:36:29 <nhnt11> uh. 23:36:38 <nhnt11> Still worth a shot. 23:37:07 <aleth> You don't want to trigger a reindex of all emails anyway, just the IMs 23:37:11 <aleth> Try asking asuth 23:40:05 <nhnt11> aleth: If gloda doesn't have a way we can make it work from index_im.js 23:40:13 --> mconley has joined #instantbird 23:40:16 <nhnt11> we have a cache of already indexed files. All we have to do is destroy it 23:40:55 <aleth> That doesn't remove the entries from the database though 23:41:09 <nhnt11> hmm, right 23:41:39 <aleth> Might be worth taking a look at sshagarwaal's log deletion patch that's waiting on your patches. It has a gloda part iirc. 23:42:12 <nhnt11> okay 23:42:45 <aleth> bug 997211 23:42:47 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=997211 nor, --, ---, nobody, NEW, Implement removal of deleted chat logs from Gloda 23:42:56 <nhnt11> oh, the gloda bit is in a separate bug? thanks! 23:43:52 <aleth> the bug comments seem useful 23:44:51 <nhnt11> this is painful :'( 23:45:09 <aleth> No kidding. 23:45:59 <aleth> On the plus side, after zapping everything with a path that starts with the profile dir, reindexing what's missing should happen automatically, right? 23:46:20 <nhnt11> The impression I get from Suyash's bug is that there isn't already an easy way to remove stuff from the gloda index 23:46:41 <nhnt11> a *complete* way rather 23:47:17 <nhnt11> aleth: No :( the cache is stored by filename, so we'd have to zap the cache in index_im too 23:47:26 <aleth> I'm not sure, a lot of what's in the bug seems unnecessarily complicated by factors that don't apply to you 23:47:36 <nhnt11> I'll do more research 23:48:30 <nhnt11> aleth: For now, let's land a quick fix please. A fix for non-Release users can be thought out with a teeny bit less urgency.. 23:48:32 <aleth> Yeah, but zapping everything in the cache with a full path is comparatively easy 23:48:53 <nhnt11> Even zapping the entire cache is acceptable vs. zapping everything in gloda 23:49:05 --> Nazadel has joined #instantbird 23:49:10 <aleth> nhnt11: Sure, first fix up the code so it works OK as is then worry about migration in a separate bug. 23:49:58 <aleth> I didn't mean to suggest anything else... 23:50:30 <nhnt11> Not saying you did. Just wanted to make sure we were on the same page. 23:50:34 --> mudpit1 has joined #instantbird 23:51:11 <nhnt11> Weirdly, I never even thought to actually /open/ a search result when I was testing async logs 23:51:40 <nhnt11> Like, I don't think I realized that there was more to search than viewing the results page. :S 23:51:43 <nhnt11> bah 23:52:30 <aleth> This is why in Fx everything lands with tests ;) 23:53:13 <aleth> But yeah, you still have to realize something needs testing in the first place. 23:53:42 <-- mudpit has quit (Ping timeout: 121 seconds) 23:53:42 * mudpit1 is now known as mudpit 23:58:48 <-- Bollebib has quit (Ping timeout: 121 seconds)