#instantbird log on 01 19 2015

All times are UTC.

00:06:18 <-- Nazadel has quit (Quit: Bye)
00:08:15 --> Rym_ has joined #instantbird
00:22:45 <-- aleth has quit (Quit: :tiuQ)
00:24:22 --> nhnt11 has joined #instantbird
00:24:22 * ChanServ sets mode +h nhnt11 
00:28:39 <-- mconley has quit (Connection closed)
01:46:33 <-- Bollebib has quit (Connection closed)
01:53:20 <-- Tonnes has quit (Ping timeout: 121 seconds)
02:11:15 <Widdershins> any news about the issue with the gtalk reconnects?
02:11:28 <Widdershins> also 1.5 is 13 months old
02:11:31 <Widdershins> :(
02:25:22 <-- mpmc has quit (Connection closed)
02:51:00 --> Tonnes has joined #instantbird
03:31:43 --> myk has joined #instantbird
04:16:40 <-- EionRobb has quit (Quit: Leaving.)
04:23:27 --> Rym has joined #instantbird
04:24:08 <-- Rym_ has quit (Ping timeout: 121 seconds)
04:27:28 <instant-buildbot> build #1294 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1294
05:01:04 <instant-buildbot> build #1605 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1605
05:02:54 <instant-buildbot> build #2498 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2498
05:22:27 <-- Rym has quit (Ping timeout: 121 seconds)
05:49:20 --> Rym has joined #instantbird
05:53:48 <-- Rym has quit (Ping timeout: 121 seconds)
06:28:39 --> EionRobb has joined #instantbird
06:31:12 <-- myk has quit (Ping timeout: 121 seconds)
06:43:26 --> Rym has joined #instantbird
06:47:58 <-- Rym has quit (Ping timeout: 121 seconds)
07:01:00 * Fallen|away is now known as Fallen 
07:06:04 <-- nhnt11 has quit (Ping timeout: 121 seconds)
07:27:44 * Fallen is now known as Fallen|away 
07:37:35 --> Rym has joined #instantbird
07:42:05 <-- Rym has quit (Ping timeout: 121 seconds)
07:48:55 --> myk has joined #instantbird
07:58:56 --> mudpit1 has joined #instantbird
08:02:35 <-- mudpit has quit (Ping timeout: 121 seconds)
08:02:58 <-- mudpit1 has quit (Ping timeout: 121 seconds)
08:08:54 --> Bollebib has joined #instantbird
08:17:30 <-- gerard-majax has quit (Ping timeout: 121 seconds)
08:25:07 * Fallen|away is now known as Fallen 
08:25:16 <-- myk has quit (Ping timeout: 121 seconds)
08:31:45 --> Rym has joined #instantbird
08:36:17 <-- Rym has quit (Ping timeout: 121 seconds)
08:48:05 <instant-buildbot> build #190 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/190
09:04:43 --> panther7 has joined #instantbird
09:04:50 <panther7> hi all
09:06:13 <panther7> i was update last nightly, and my jabber connection failed "Error: SSL Handshake Failed", before was ok
09:06:32 <-- EionRobb has quit (Quit: Leaving.)
09:11:12 --> nhnt11 has joined #instantbird
09:11:12 * ChanServ sets mode +h nhnt11 
09:13:26 <-- panther7 has quit (Connection closed)
09:14:17 --> gerard-majax has joined #instantbird
09:14:58 --> mpmc has joined #instantbird
09:15:46 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:15:54 --> nhnt11 has joined #instantbird
09:15:55 * ChanServ sets mode +h nhnt11 
09:18:50 --> panther7 has joined #instantbird
09:19:10 <panther7> v2014-11-28-04 works correctly
09:25:55 --> Rym has joined #instantbird
09:30:25 <-- Rym has quit (Ping timeout: 121 seconds)
09:32:01 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:45:39 <-- gerard-majax has quit (Ping timeout: 121 seconds)
09:47:00 --> Nazadel has joined #instantbird
09:48:15 --> gerard-majax has joined #instantbird
09:57:05 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
10:02:50 --> chrisccoulson has joined #instantbird
10:06:58 <-- gerard-majax has quit (Ping timeout: 121 seconds)
10:08:38 --> BWMerlin has joined #instantbird
10:11:29 <-- Tonnes has quit (Connection closed)
10:20:04 --> Rym has joined #instantbird
10:24:34 <-- Rym has quit (Ping timeout: 121 seconds)
10:29:29 --> aleth has joined #instantbird
10:29:29 * ChanServ sets mode +o aleth 
10:30:26 <-- Even has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:45:47 --> gerard-majax has joined #instantbird
10:52:01 <-- flo-retina has quit (Ping timeout: 121 seconds)
11:10:35 <-- aleth has quit (Ping timeout: 121 seconds)
11:14:11 --> Rym has joined #instantbird
11:18:10 --> aleth has joined #instantbird
11:18:10 * ChanServ sets mode +o aleth 
11:18:42 <-- Rym has quit (Ping timeout: 121 seconds)
11:29:22 --> flo-retina has joined #instantbird
11:29:22 * ChanServ sets mode +qo flo-retina flo-retina 
11:29:30 <flo-retina> after a restart the animations in the account manager WFM
11:29:36 <flo-retina> the partial update didn't work though
11:30:03 <flo-retina> after looking at the build log, there's clearly no chance of partial updates working, we are updating a whole lot of pointless files related to update generation instead of uploading partial mars: http://ftp.instantbird.com/instantbird/nightly/2015/01/2015-01-19-04-instantbird/
11:31:35 <flo-retina> given that we are uploading "instantbird-1.6a1pre.en-US.mac.tests.zip 119M" and "instantbird-1.6a1pre.en-US.mac.crashreporter-symbols.zip 53M", there should be no surprised that the upload over wifi sometimes fails; it's more surprising that it ever finishes successfully!
11:31:44 <aleth> o_O
11:33:00 <flo-retina> we already uploaded that nonsense on january first
11:33:41 <aleth> It starts 18/12
11:33:56 <flo-retina> that's what I was going to say
11:34:06 <flo-retina> have we filed a bug?
11:34:10 <aleth> no
11:34:32 <aleth> I only mentioned partial updates in the logs
11:34:43 <flo-retina> I remember we discussed it failing
11:34:43 <aleth> Then forgot to follow up on that
11:34:59 <aleth> Yeah
11:35:33 * aleth wonders what broke
11:35:47 <aleth> There haven't been any buildbot updates, have there?
11:35:50 <flo-retina> some build magic ;)
11:35:56 <flo-retina> nope
11:39:14 <aleth> panther7: possibly a problem with the site's certificate
11:41:11 <aleth> I don't think we landed any changes in that area though maybe m-c did
11:43:13 * Fallen is now known as Fallen|away 
11:48:19 <aleth> flo-retina: "ssh: Could not resolve hostname ls -1t  | grep mac.complete.mar$ | head -n 1: nodename nor servname provided, or not known" ?
11:48:26 * Fallen|away is now known as Fallen 
11:48:41 <flo-retina> where is that?
11:48:47 <aleth> http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2498/steps/shell_5/logs/stdio
11:49:31 <flo-retina> wget -O ../../dist/update//previous.mar http:////$latestmar
11:49:32 <flo-retina> hmm
11:50:06 <flo-retina>   LIST_PREVIOUS_MAR_CMD=ssh $(SSH_USERNAME)@$(SSH_SERVER) /usr/bin/php /home/ib_main/home/updates/get_previous_mars.php $(MOZ_APP_VERSION) $(MOZ_PKG_PLATFORM)
11:50:26 <flo-retina>   SSH_SERVER=ftp4.instantbird.org
11:50:58 <flo-retina> that's supposed to be used at http://mxr.mozilla.org/comm-central/source/im/build.mk#96
12:02:39 <-- BWMerlin has quit (Client exited)
12:08:23 --> Rym has joined #instantbird
12:11:24 <-- aleth has quit (Ping timeout: 121 seconds)
12:12:53 <-- Rym has quit (Ping timeout: 121 seconds)
12:36:13 --> aleth has joined #instantbird
12:36:13 * ChanServ sets mode +o aleth 
13:02:33 --> Rym has joined #instantbird
13:07:03 <-- Rym has quit (Ping timeout: 121 seconds)
13:09:31 --> Tonnes has joined #instantbird
13:56:43 --> Rym has joined #instantbird
14:01:13 <-- Rym has quit (Ping timeout: 121 seconds)
14:01:31 --> qheaden has joined #instantbird
14:07:06 --> sawrubh has joined #instantbird
14:16:35 --> mconley has joined #instantbird
14:19:10 <-- mconley has quit (Connection closed)
14:45:40 --> iamjayakumars has joined #instantbird
14:48:25 --> Mnyromyr has joined #instantbird
14:50:51 --> Rym has joined #instantbird
15:04:52 --> mconley has joined #instantbird
15:20:40 --> AlexanderSalas has joined #instantbird
15:20:55 <AlexanderSalas> Hi everybody
15:21:24 <AlexanderSalas> I need a feedback for my new prpl addon
15:21:36 <-- Mnyromyr has quit (Connection closed)
15:21:49 <AlexanderSalas> https://addons.instantbird.org/en-US/instantbird/addon/372
15:21:49 <AlexanderSalas> https://github.com/alexsalas/instantbird-protocol-p18x/issues
15:21:58 <-- iamjayakumars has quit (Quit: )
15:23:17 <AlexanderSalas> I need users reviews and developer reviews for a new version
15:23:17 <AlexanderSalas> https://addons.instantbird.org/en-US/instantbird/reviews/add/372
15:24:35 <AlexanderSalas> The source code it's here:
15:24:35 <AlexanderSalas> https://github.com/alexsalas/instantbird-protocol-p18x/blob/master/components/p18x.js
15:25:57 <flo-retina> AlexanderSalas: Hello :). Which kind of feedback are you looking for? It seems a specific device is needed to use your prpl, so I'm not sure any of us can try it.
15:27:12 <AlexanderSalas> flo-retina: Can you make a developer reviews for a better "Coding Guidelines"
15:27:49 <AlexanderSalas> If you want, you can make comments in the commit here:
15:27:49 <AlexanderSalas> https://github.com/alexsalas/instantbird-protocol-p18x/commit/c0f8f39951ee6b7b3c30c8a01ed46df81e069a80
15:28:33 <AlexanderSalas> It's a practice to make more prpl addons 
15:36:00 <flo-retina> AlexanderSalas: With a quick look, overall it looks good (ie. it looks like a prpl :-)). I wrote a few comments to help you improve.
15:36:14 <AlexanderSalas> I can see now
15:36:48 <AlexanderSalas> Thank you very much flo-retina :D
15:36:53 <flo-retina> there are also coding style inconsistencies that you would need to fix if you were writing this as a patch that should be included in comm-central, but if you intend to keep it as an add-on, the coding style is your business, not mind :)
15:38:47 <AlexanderSalas> Yes, I prefer a consistent coding style
15:39:42 <AlexanderSalas> I will take in mind
15:40:07 <AlexanderSalas> What's about the new logger?
15:40:53 <AlexanderSalas> We need take the controll of the logger to read sms in the device, 
15:40:53 <AlexanderSalas> or for example, to work with Telegram, we need read from the cloud all msgs
15:48:32 <flo-retina> AlexanderSalas: so things that are inconsistent in your coding style: you sometimes have "if(" and sometimes "if (" (Instantbird code has a space there usually)
16:00:49 <-- Widdershins has quit (Ping timeout: 121 seconds)
16:07:32 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:07:45 --> AlexanderSalas has joined #instantbird
16:08:57 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:09:27 --> AlexanderSalas has joined #instantbird
16:09:54 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:10:08 --> AlexanderSalas has joined #instantbird
16:10:09 * Fallen is now known as Fallen|away 
16:10:54 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:11:06 --> AlexanderSalas has joined #instantbird
16:12:35 --> kapy has joined #instantbird
16:16:22 <aleth> AlexanderSalas: what is your concern about logging? offline messages?
16:16:48 * aleth thinks that's probably the first add-on with chinese localisation :-)
16:16:57 <AlexanderSalas> lol
16:17:09 <AlexanderSalas> take a control of all messages of the logger
16:17:25 <aleth> what does that mean?
16:17:32 <AlexanderSalas> example
16:17:44 <AlexanderSalas> Telegram have cloud with all messages
16:18:15 <AlexanderSalas> We need donwload messeges with infinite scroll
16:18:37 <AlexanderSalas> https://telegram.org/
16:18:37 <AlexanderSalas> Telegram is Cloud-Based
16:18:37 <AlexanderSalas> Telegram lets you access your messages from multiple devices.
16:19:03 <AlexanderSalas> Telegram can delete a messege or fordware
16:19:40 <AlexanderSalas> forward*
16:19:47 <aleth> But that doesn't affect local logging.
16:20:12 <AlexanderSalas> The local logging need sync with the cloud logging
16:20:16 <aleth> Though I take your point about infinite scroll - currently you'd have to download all the "missing" messages
16:20:28 <AlexanderSalas> Yes!
16:20:39 <aleth> What you'd do with the current setup is set the "delayed" flag on those messages
16:21:02 <aleth> That's no different to e.g. tweets that were sent before you log on
16:21:49 <AlexanderSalas> Yes, are waiting to send
16:22:21 <AlexanderSalas> Like as the same app on the Android or Desktop app
16:22:32 <aleth> Fetching more messages on demand will be much harder to implement, especially as IB doesn't have infinite scroll yet.
16:22:49 <aleth> But fetching all the messages since you last connected with IB shouldn't be too hard.
16:23:05 <AlexanderSalas> yes, to beging we need take a control of the logger
16:23:17 <aleth> No, to begin with nhnt11 has to land his patches ;)
16:23:22 <aleth> That should help you too.
16:23:23 <AlexanderSalas> yessssssss
16:23:24 <AlexanderSalas> haha
16:23:45 <AlexanderSalas> I'm asking about the status
16:23:55 <AlexanderSalas> To help and improve 
16:26:07 <aleth> For now, as I said, the best approach is to grab the missing messages and use the delayed flag, and not worry about changing logging.
16:26:26 <flo-retina> prpls shouldn't mess with logging
16:26:28 <aleth> Infinite scroll is a big project that would have to be done in stages. It's not related to logging.
16:28:33 <aleth> "Logging" just generates a local copy of whatever you've seen in a conversation. I don't see why you would have to change that.
16:29:52 <AlexanderSalas> perhaps another solution is more complicated
16:32:58 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:33:00 <aleth> AlexanderSalas: I didn't know there was a -cn localisation of Instantbird?
16:33:32 <aleth> It would be nice to have one http://instantbird.com/download-all.html
16:37:40 <AlexanderSalas> I love use https://www.transifex.com/ to make translation for addons and mozilla based-apps 
16:38:20 <aleth> well, if you translate Instanstbird, let us know ;)
16:38:21 <AlexanderSalas> We can translate  in short time for very much languages...
16:40:43 <AlexanderSalas> Ok, God willing.
16:40:43 <AlexanderSalas> I can see "Brazilian Portuguese"
16:40:43 <AlexanderSalas> I can translate for "Venezuelan Spanish"
16:40:43 <AlexanderSalas> And "Egyptian Arabic"
16:44:29 <aleth> pt-BR already exists, and there is someone working on ar, though Egyptian Arabic might be different again. Similarly there is es-ES but not Venezuelan.
16:45:16 <aleth> Currently there are infrastructure issues with localisation that make testing a new localisation difficult. Hopefully that will get fixed soon-ish.
16:45:51 <aleth> http://hg.instantbird.org/l10n/locales-status.html
16:49:42 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:52:32 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:52:51 --> AlexanderSalas has joined #instantbird
16:53:41 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:53:52 --> AlexanderSalas has joined #instantbird
17:00:45 --> flo-retina has joined #instantbird
17:00:45 * ChanServ sets mode +qo flo-retina flo-retina 
17:02:43 * Fallen|away is now known as Fallen 
17:09:20 <-- aleth has quit (Ping timeout: 121 seconds)
17:13:13 --> mudpit has joined #instantbird
17:18:39 --> Defman has joined #instantbird
17:20:37 --> clokep has joined #instantbird
17:20:37 * ChanServ sets mode +o clokep 
17:23:51 --> myk has joined #instantbird
17:30:47 * Fallen is now known as Fallen|away 
17:31:32 --> hadi has joined #instantbird
17:35:34 <-- hadi has quit (Ping timeout: 121 seconds)
17:37:16 --> hadi has joined #instantbird
17:42:11 --> aleth has joined #instantbird
17:42:11 * ChanServ sets mode +o aleth 
17:42:42 * Fallen|away is now known as Fallen 
17:46:19 --> Mook_as has joined #instantbird
17:51:34 <clokep> AlexanderSalas: I have no idea what you want me to look at in the log
17:52:05 <AlexanderSalas> I make a new prpl
17:52:25 <AlexanderSalas> I want to share with you the source code to make a developer review
17:53:14 <AlexanderSalas> clokep: 
17:53:14 <AlexanderSalas> https://github.com/alexsalas/instantbird-protocol-p18x
17:53:14 <AlexanderSalas> https://addons.instantbird.org/en-US/instantbird/addon/372
17:56:46 <-- kapy has quit (Quit: )
18:00:42 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
18:00:44 <-- Rym has quit (Ping timeout: 121 seconds)
18:03:44 --> mpmc has joined #instantbird
18:07:25 --> sukhe has joined #instantbird
18:13:10 --> mudpit1 has joined #instantbird
18:13:44 <clokep> AlexanderSalas: I'll try to look "soon".
18:14:05 <AlexanderSalas> Don't worry
18:15:00 <AlexanderSalas> I'm learning to make others prpl.
18:16:40 <-- mudpit has quit (Ping timeout: 121 seconds)
18:16:40 * mudpit1 is now known as mudpit 
18:24:35 --> Rym has joined #instantbird
18:31:54 <-- nhnt11 has quit (Ping timeout: 121 seconds)
18:48:55 --> nhnt11 has joined #instantbird
18:48:55 * ChanServ sets mode +h nhnt11 
18:56:42 <AlexanderSalas> Hi everybody,
18:56:42 <AlexanderSalas> I have a collection on Behance about the new ideas for Instantbird themes
18:56:42 <AlexanderSalas> https://www.behance.net/collection/25081641/Instantbird
18:56:47 <nhnt11> flo-retina, aleth, clokep: Did you say there was an etherpad up for GSoC brainstorming?
18:56:59 <flo-retina> I think you just did :-P
18:57:02 <flo-retina> are you creating one? :)
18:57:13 <flo-retina> nhnt11: we certainly had one last year though
18:57:33 <nhnt11> Yes, but I vaguely recalled someone mentioning it recently
18:57:46 <clokep> nhnt11: https://etherpad.mozilla.org/ib-gsoc-2014
18:57:53 <clokep> nhnt11: I jus tmentioned we should think abou tit.
18:57:55 <aleth> nhnt11: you mean https://wiki.mozilla.org/Community:SummerOfCode15:Brainstorming
18:59:41 <nhnt11> ok
18:59:47 <nhnt11> bbia
18:59:48 <nhnt11> bbiab*
19:12:03 <flo-retina> why is there asyncFetch and asyncFetch2? :(
19:14:04 <aleth> https://dxr.mozilla.org/mozilla-central/source/netwerk/base/src/NetUtil.jsm#179
19:14:32 <flo-retina> ah, so that means it will change _again_ :(
19:14:35 <flo-retina> thanks
19:14:40 <aleth> yes :-/
19:23:33 <-- AlexanderSalas has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:26:43 <clokep> aleth: So... https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=955441&attachment=8550724 ...what exactly is that doing.
19:27:56 <aleth> umm.... it sets the URL panel text to the empty string and does so without potential delays?
19:28:25 <aleth> https://dxr.mozilla.org/comm-central/source/im/content/instantbird.js#174
19:28:28 <clokep> aleth: Hm....I guess the "hideOverLinkImmediately" is what is confusing me.
19:28:40 <aleth> I didn't invent that, we inherit it from FX
19:29:35 <clokep> I don't understand what it's doing. :)
19:29:50 <aleth> Well, usually when you move the mouse away from the link, it hides the panel, but with a delay.
19:30:22 <aleth> When we close the tab we don't want that delay.
19:30:24 <clokep> Ah...I've never noticed that before.
19:30:55 <aleth> The idea I guess it to avoid flicker when the mouse moves away from the link and then back to it due to jittering
19:31:02 <clokep> Yeah.
19:31:58 --> EionRobb has joined #instantbird
19:32:46 <clokep> Anything else I owe people? :P
19:33:12 <aleth> Thanks for all the reviews!
19:33:19 <aleth> Lots of little bugs...
19:33:20 <clokep> panther7: We recently changed some of the default SSL settings.
19:33:30 <aleth> clokep: That hasn't landed yet
19:33:38 <clokep> Oh?
19:33:42 <clokep> I thought I saw it go in..
19:34:29 <clokep> Never mind then. :)
19:35:02 <aleth> We have some bugs about that error message and it seems to be DNS SRV/cert stuff
19:37:43 --> sherief has joined #instantbird
19:45:11 <instantbot> aleth@instantbird.org changed the Resolution on bug 1122666 from --- to FIXED.
19:45:12 <instantbot> aleth@instantbird.org changed the Resolution on bug 955441 from --- to FIXED.
19:45:13 <instantbot> aleth@instantbird.org changed the Resolution on bug 1122514 from --- to FIXED.
19:45:14 <instantbot> aleth@instantbird.org changed the Resolution on bug 1122567 from --- to FIXED.
19:45:15 <instantbot> aleth@instantbird.org changed the Resolution on bug 1123093 from --- to FIXED.
19:45:16 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1122514 nor, --, 1.6, aleth, RESO FIXED, 'LoadInfo arguments must be undefined' errors from xmpp-xml.jsm
19:45:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1123093 enh, --, 1.6, aleth, RESO FIXED, Include build ID and version info in debug logs
19:45:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955441 min, --, 1.6, aleth, RESO FIXED, URLs sometimes get stuck in the status bar
19:45:19 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1122666 enh, --, 1.6, clokep, RESO FIXED, Default IRC to using SSL
19:45:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1122567 nor, --, 1.6, aleth, RESO FIXED, Change JS-XMPP default to require encryption
19:46:09 <clokep> =-o
19:47:46 <clokep> Lots of stuff.
19:48:30 --> gerard-majax has joined #instantbird
19:50:32 <clokep> aleth: Thanks for all the patches aleth. :)
19:52:59 * aleth looks at mq
19:53:17 <aleth> flo-retina: gentle review ping on bug 1060891
19:53:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1060891 nor, --, ---, aleth, ASSI, Stats service uses too much memory
19:53:42 <flo-retina> oh, aleth fixed all the bugs? :-o
19:53:45 <clokep> aleth: Eventually you need to stop being gentle and get a crowbar. ;)
19:54:00 <aleth> lots of small bugs...
19:54:07 * clokep fixed one! :P
20:21:32 --> Mnyromyr has joined #instantbird
20:25:26 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
20:26:32 --> Rym_ has joined #instantbird
20:27:29 <-- Rym has quit (Ping timeout: 121 seconds)
20:35:24 <flo-retina> aleth: I don't really remember that bug/patch unfortunately :(
20:35:41 <flo-retina> from what I remember, we weren't sure of what was actually wasting the memory :-S
20:40:13 --> DGMurdockIII has joined #instantbird
20:44:37 <-- aleth has quit (Ping timeout: 121 seconds)
20:50:17 --> aleth has joined #instantbird
20:50:17 * ChanServ sets mode +o aleth 
20:52:58 <aleth> flo-retina: iirc (it's a long time ago now) the *what* was fairly clear, but the *why* was sadly impenetrable. iirc the patch is an acceptable workaround that saves tens of Mb
20:54:01 <flo-retina> yeah... I remember that we didn't understand, but it was an empirical improvement
20:56:22 <aleth> yeah... 40M savings for a single connected freenode account isn't bad
20:56:38 <flo-retina> I didn't remember it was that large
20:56:46 <flo-retina> why isn't that reviewed yet then? :-P
20:56:55 <aleth> I just looked at the bug again
20:57:30 <flo-retina> or did it get lost in the search rush?
20:57:54 <aleth> probably, the last comment was mid-october?
20:58:38 <flo-retina> that's strange, I seem to remember this bug like if it was one year ago...
20:59:04 <aleth> yes, it seems a logn time ago to me too
21:13:58 --> clokep_work has joined #instantbird
21:13:58 * ChanServ sets mode +o clokep_work 
21:14:16 <clokep_work> aleth: What XMPP error handling?
21:14:33 <aleth> clokep_work: yes.
21:15:08 <aleth> clokep_work: more seriously, what error handling there currently is is very much case-by-case and so the more of it gets added, the more there is duplication
21:15:33 <clokep_work> aleth: So for *some* error handling, you could just *not* error check.
21:15:35 <aleth> clokep_work: to be clear, I mean "dealing with type="error" stanzas"
21:15:38 <clokep_work> And throw a top-level try-catch.
21:15:52 <aleth> not JS errors.
21:16:14 <clokep_work> Hmm...
21:16:17 <clokep_work> I'm not sure. :-\
21:16:23 <clokep_work> I only pretend to know XMPP. :-[
21:16:27 <clokep_work> Did flo-retina not have any ideas?
21:18:42 <-- hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:20:42 <flo-retina> clokep_work: webrtc over IRC
21:21:00 <aleth> I have an idea, but I wasn't motivated to add it yet
21:21:05 <clokep_work> flo-retina: Decided to take a look at Skype again.
21:21:23 <flo-retina> :)
21:24:34 <EionRobb> clokep_work: yay :)
21:30:39 <clokep_work> I don't understand some of these comments. :(
21:33:06 <aleth> there's an app for that!
21:54:20 --> mudpit1 has joined #instantbird
21:54:42 <-- mudpit has quit (Connection closed)
21:54:42 * mudpit1 is now known as mudpit 
21:54:46 <-- mudpit has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:54:50 --> mudpit has joined #instantbird
21:57:35 <-- Rym_ has quit (Ping timeout: 121 seconds)
21:58:38 <-- Defman has quit (Connection closed)
22:05:52 --> mudpit1 has joined #instantbird
22:06:05 --> Rym_ has joined #instantbird
22:06:15 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
22:06:23 --> mudpit1 has joined #instantbird
22:07:10 <clokep_work> aleth: Ah, this isn't as bad as I thought...there's a lot of duplicated comments in here. :)
22:08:07 <aleth> Yes, sorry for not tidying up
22:08:09 <flo-retina> so if a comment doesn't make sense, duplicating it several times makes it less scary? :-P
22:08:44 <clokep_work> Also, I think you think I know more about some of this stuff then I do...
22:08:53 <-- mudpit has quit (Ping timeout: 121 seconds)
22:08:53 * mudpit1 is now known as mudpit 
22:09:03 <clokep_work> I dont know the difference between display_name, skypename and fullname. :P
22:09:10 <clokep_work> Maybe EionRobb does, but I have a feeling it's just vague.
22:09:29 <aleth> But you probably have examples you can put in a comment? Or at least add a comment saying "TODO: figure out the difference"?
22:09:47 <clokep_work> Yeah.
22:11:10 <clokep_work> aleth: "NB The serverAlias setter will send a displayname-changed notification." what does "NB" mean?
22:11:15 <aleth> nota bene
22:11:55 <aleth> maybe that's not used in US English?
22:12:03 <clokep_work> That didn't help. :)
22:12:31 <aleth> http://www.oxforddictionaries.com/definition/english/nota-bene?q=nota+bene
22:12:56 <clokep_work> Alright.
22:17:19 <aleth> The wikipedia entry is better but doesn't mention anything US specific either https://en.wikipedia.org/wiki/Nota_bene
22:18:00 <-- Rym_ has quit (Ping timeout: 121 seconds)
22:18:08 --> chrisccoulson has joined #instantbird
22:26:47 <mudpit> As a dutch person, i think NB is usually used to that is not directly relevant to the point at hand. It's meaning is the same is PS (postscript) in english i think.
22:26:59 <mudpit> i have no idea what NB actually stands for.
22:27:35 <mudpit> by the way, has there been any progress in debugging the google talk reconnect issue?
22:28:20 <aleth> There has been some debugging, but no real progress. The problem is google doesn't send us any useful error response
22:29:41 <clokep_work> We tried a few things to work around it, but nothing worked.
22:32:23 <mudpit> Sucks. If i was better at js i would lend a hand.
22:32:45 <mudpit> my gut feeling tells me the problem is related to slient side caching of connection details.
22:32:46 <flo-retina> clokep_work: so what do we know about it?
22:32:52 <mudpit> nothing.
22:32:57 <flo-retina> clokep_work: have we seriously tried disabling SSL session tickets?
22:33:09 <mudpit> i'm a back-end person. C/C++ a bit of python.
22:33:24 <flo-retina> mudpit: then you are lucky, there's probably only C and C++ involved here ;)
22:33:25 * instantbot mumbles something about c++ being evil
22:33:55 <mudpit> in that case i might be of use.
22:34:19 <clokep> flo-retina: We didn't try, much less seriously.
22:34:23 <mudpit> do we have an 'isolated' test case flying around somewhere yet?
22:34:33 <clokep> I don't understand the quesiton
22:34:59 <mudpit> do we have an unit test that replicates the problem?
22:35:31 <clokep> No, that can't really exist since it involves interacting with the Google server
22:36:05 <mudpit> Do we have an integration test that replicates the problem (:P)
22:36:19 <flo-retina> no
22:37:11 <mudpit> well, that's usually step 1 in solving a problem.
22:37:40 <flo-retina> setting security.ssl.disable_session_identifiers to true sounds like it would disable session tickets
22:39:37 <clokep> mudpit: You could try that and report back. :)
22:40:12 <mudpit> on it.
22:40:19 --> mudpit1 has joined #instantbird
22:43:32 --> mudpit2 has joined #instantbird
22:43:35 <flo-retina> clokep: setting that pref to true "solves" the problem
22:44:06 * aleth wonders what recently changed around session tickets then
22:44:08 <mudpit2> Okay that doesn't work. I was actually unable to connect to irc after i swithced wifi networks a few times.
22:44:14 <-- mudpit has quit (Ping timeout: 121 seconds)
22:44:14 * mudpit2 is now known as mudpit 
22:44:21 <-- mudpit1 has quit (Ping timeout: 121 seconds)
22:45:01 <clokep> aleth: Or on the server?
22:45:17 <aleth> maybe they added RC4? :P
22:45:24 --> Rym_ has joined #instantbird
22:45:28 <clokep> It might be...
22:45:32 <flo-retina> I hope it's not the same change that fixed freenode and broke gtalk
22:46:06 <clokep> Freenode has been fixed for a longggg time, I think.
22:46:07 <flo-retina> to see if the problem is on the server, maybe someone can try to reproduce the bug with an old release?
22:46:22 <clokep> flo-retina: I had asked a friend to do that with 1.5, it was a problem ther etoo
22:48:43 <flo-retina> heh, that pref has been added in moz35: https://bugzilla.mozilla.org/show_bug.cgi?id=967977
22:48:45 <instantbot> Bug 967977 nor, --, mozilla35, arthuredelstein, RESO FIXED, Add a pref to disable SSL Session cache (Disable sending session IDs and sending session tickets)
22:49:06 <flo-retina> when I saw how easily I found that pref, I got puzzled that I didn't manage to find it at the time we were annoyed by freenode... :-D
22:49:10 <flo-retina> now it's obvious
22:49:52 <aleth> maybe we should just change the default for it then?
22:50:36 <aleth> what's the downside?
22:50:54 <clokep_work> aleth: Trying to get TB to accept it? ;)
22:51:06 <-- Bollebib has quit (Ping timeout: 121 seconds)
22:51:42 --> Bollebib has joined #instantbird
22:52:56 <flo-retina> aleth: I'm happy to rs that for 1.6 if needed, but that's not a fix, just hiding the problem.
22:53:20 <aleth> flo-retina: sure
22:54:03 <flo-retina> anybody's got suggestions for how we can figure out what actually happens?
22:54:18 <aleth> ask on #necko how to figure out what actually happens? :P
22:54:42 <aleth> I wonder if there's something we should be doing in socket.jsm on disconnect
22:55:32 <flo-retina> I'm not motivated to do that right now
22:55:55 <aleth> me neither
23:14:53 <-- sawrubh has quit (Quit: Connection closed for inactivity)
23:51:22 * Fallen is now known as Fallen|away