All times are UTC.
00:15:50 <-- nhnt11 has quit (Ping timeout: 121 seconds) 00:36:21 --> aleth has joined #instantbird 00:36:21 * ChanServ sets mode +o aleth 00:50:08 <-- Suiseiseki has quit (Ping timeout: 121 seconds) 00:52:42 <-- Defman has quit (Connection closed) 00:58:05 * Fallen is now known as Fallen|away 00:58:20 --> mconley has joined #instantbird 01:04:41 <-- aleth has quit (Ping timeout: 121 seconds) 01:08:39 --> Suiseiseki has joined #instantbird 01:24:41 --> Defman has joined #instantbird 01:36:25 <-- Mook_as has quit (Client exited) 01:38:27 --> Widdershins has joined #instantbird 01:48:46 <-- Bollebib has quit (Connection closed) 01:57:35 <-- Defman has quit (Connection closed) 02:02:17 <-- myk has quit (Ping timeout: 121 seconds) 02:02:35 --> clokep_work has joined #instantbird 02:02:35 * ChanServ sets mode +o clokep_work 02:06:07 --> nhnt11 has joined #instantbird 02:06:07 * ChanServ sets mode +h nhnt11 02:43:54 * redDragon|away is now known as redDragon 03:33:38 <-- nhnt11 has quit (Connection closed) 03:33:38 --> nhnt12 has joined #instantbird 03:33:38 * ChanServ sets mode +h nhnt12 03:36:11 * nhnt12 is now known as nhnt11 03:44:15 <-- nhnt11 has quit (Ping timeout: 121 seconds) 04:40:38 <-- clokep_work has quit (Ping timeout: 121 seconds) 04:59:50 <instant-buildbot> build #1277 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1277 05:14:42 <instant-buildbot> build #2481 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2481 06:00:08 <-- mconley has quit (Connection closed) 06:19:11 --> myk has joined #instantbird 06:32:25 --> mpmc has joined #instantbird 07:01:42 <-- myk has quit (Ping timeout: 121 seconds) 07:08:26 <instant-buildbot> build #173 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/173 07:11:40 --> myk has joined #instantbird 07:17:33 <-- Suiseiseki has quit (Ping timeout: 121 seconds) 07:18:54 --> Suiseiseki has joined #instantbird 07:44:04 <-- myk has quit (Ping timeout: 121 seconds) 08:00:57 --> kapy_ has joined #instantbird 08:18:12 <-- kapy_ has quit (Quit: ) 08:23:07 <-- Tonnes has quit (Connection closed) 08:25:50 --> Tonnes has joined #instantbird 09:07:24 <-- Tobin has quit (Ping timeout: 121 seconds) 09:07:43 --> Tobin has joined #instantbird 09:11:03 --> MattATobin has joined #instantbird 09:13:54 --> BinaryOutcast has joined #instantbird 09:14:57 <-- Tobin has quit (Ping timeout: 121 seconds) 09:15:44 <-- MattATobin has quit (Ping timeout: 121 seconds) 09:45:43 --> sherief has joined #instantbird 09:56:37 * Fallen|away is now known as Fallen 10:16:25 <-- BinaryOutcast has quit (Connection closed) 10:16:31 --> Tobin has joined #instantbird 10:59:32 --> Bollebib has joined #instantbird 11:00:17 --> gerard-majax_ has joined #instantbird 11:00:35 --> mudpit1 has joined #instantbird 11:02:56 <-- mudpit has quit (Ping timeout: 121 seconds) 11:02:57 * mudpit1 is now known as mudpit 11:04:08 <-- Even has quit (A TLS packet with unexpected length was received.) 11:04:18 --> Even has joined #instantbird 11:04:18 * ChanServ sets mode +o Even 11:07:28 --> aleth has joined #instantbird 11:07:28 * ChanServ sets mode +o aleth 11:09:50 <-- EionRobb has quit (Quit: Leaving.) 11:11:50 --> mudpit1 has joined #instantbird 11:12:16 <-- mudpit has quit (Ping timeout: 121 seconds) 11:12:16 * mudpit1 is now known as mudpit 11:21:17 --> mudpit1 has joined #instantbird 11:24:42 <-- mudpit has quit (Ping timeout: 121 seconds) 11:25:19 <-- mudpit1 has quit (Ping timeout: 121 seconds) 11:31:35 <-- aleth has quit (Ping timeout: 121 seconds) 11:32:57 <-- Even has quit (A TLS packet with unexpected length was received.) 11:32:57 --> Even1 has joined #instantbird 11:32:57 * ChanServ sets mode +o Even1 11:36:11 --> Defman has joined #instantbird 11:41:35 --> mudpit has joined #instantbird 11:42:28 <-- Tobin has quit (Connection closed) 11:42:36 --> Tobin has joined #instantbird 11:50:25 <-- Tobin has quit (Ping timeout: 121 seconds) 11:53:30 --> Tobin has joined #instantbird 11:54:47 --> aleth has joined #instantbird 11:54:47 * ChanServ sets mode +o aleth 12:03:05 --> mudpit1 has joined #instantbird 12:05:41 <-- mudpit has quit (Ping timeout: 121 seconds) 12:05:41 * mudpit1 is now known as mudpit 12:21:39 <-- aleth has quit (Ping timeout: 121 seconds) 12:27:25 --> aleth has joined #instantbird 12:27:25 * ChanServ sets mode +o aleth 12:29:02 <-- Tobin has quit (Connection closed) 12:29:08 --> Tobin has joined #instantbird 12:31:27 <-- aleth has quit (Ping timeout: 121 seconds) 12:36:20 --> mudpit1 has joined #instantbird 12:38:25 <-- Tobin has quit (Ping timeout: 121 seconds) 12:38:42 <-- mudpit has quit (Ping timeout: 121 seconds) 12:38:42 * mudpit1 is now known as mudpit 12:39:07 --> Tobin has joined #instantbird 12:50:47 --> aleth has joined #instantbird 12:50:47 * ChanServ sets mode +o aleth 13:17:50 --> mudpit1 has joined #instantbird 13:20:02 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 13:20:25 <-- Tobin has quit (Ping timeout: 121 seconds) 13:21:26 <-- mudpit has quit (Ping timeout: 121 seconds) 13:21:26 * mudpit1 is now known as mudpit 14:10:21 <-- aleth has quit (Connection closed) 14:10:36 --> aleth has joined #instantbird 14:10:36 * ChanServ sets mode +o aleth 14:18:16 <-- Bollebib has quit (Connection closed) 14:25:12 <-- gerard-majax_ has quit (Ping timeout: 121 seconds) 14:41:15 <-- aleth has quit (Ping timeout: 121 seconds) 14:52:40 --> gerard-majax_ has joined #instantbird 14:53:56 --> mpmc has joined #instantbird 15:47:09 --> aleth has joined #instantbird 15:47:09 * ChanServ sets mode +o aleth 15:57:19 * gerard-majax_ is now known as gerard-majax 15:59:48 * Fallen is now known as Fallen|away 16:07:49 --> Tobin has joined #instantbird 16:10:44 * Fallen|away is now known as Fallen 16:21:55 --> myk has joined #instantbird 16:23:54 --> mudpit1 has joined #instantbird 16:24:14 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:24:19 --> mudpit1 has joined #instantbird 16:25:52 <-- mudpit has quit (Ping timeout: 121 seconds) 16:25:52 * mudpit1 is now known as mudpit 16:34:51 --> mudpit1 has joined #instantbird 16:37:54 <-- mudpit has quit (Ping timeout: 121 seconds) 16:38:53 <-- mudpit1 has quit (Ping timeout: 121 seconds) 16:41:27 --> mudpit has joined #instantbird 16:50:59 <-- mudpit has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:51:02 --> mudpit has joined #instantbird 16:52:22 <-- sherief has quit (Ping timeout: 121 seconds) 17:19:40 --> nhnt11 has joined #instantbird 17:19:40 * ChanServ sets mode +h nhnt11 17:20:18 <-- myk has quit (Ping timeout: 121 seconds) 17:41:16 --> mudpit1 has joined #instantbird 17:43:33 <-- mudpit has quit (Ping timeout: 121 seconds) 17:43:33 * mudpit1 is now known as mudpit 17:51:06 <-- nhnt11 has quit (Connection closed) 17:51:11 --> nhnt11 has joined #instantbird 17:51:11 * ChanServ sets mode +h nhnt11 17:51:59 --> clokep has joined #instantbird 17:52:00 * ChanServ sets mode +o clokep 17:59:16 <-- nhnt11 has quit (Ping timeout: 121 seconds) 18:00:06 --> mudpit1 has joined #instantbird 18:00:33 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:00:37 --> mudpit1 has joined #instantbird 18:02:24 --> mudpit2 has joined #instantbird 18:03:41 <-- mudpit has quit (Ping timeout: 121 seconds) 18:03:41 * mudpit2 is now known as mudpit 18:04:39 <-- mudpit1 has quit (Ping timeout: 121 seconds) 18:05:17 --> mconley has joined #instantbird 18:27:01 * redDragon is now known as redDragon|away 18:27:35 * Fallen is now known as Fallen|away 18:58:41 --> mudpit1 has joined #instantbird 19:00:21 <-- mudpit has quit (Ping timeout: 121 seconds) 19:00:24 * mudpit1 is now known as mudpit 19:06:15 --> mudpit1 has joined #instantbird 19:06:43 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:06:46 --> mudpit1 has joined #instantbird 19:09:41 <-- mudpit has quit (Ping timeout: 121 seconds) 19:09:41 * mudpit1 is now known as mudpit 19:17:41 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:20:57 --> nhnt11 has joined #instantbird 19:20:57 * ChanServ sets mode +h nhnt11 19:29:21 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:39:25 <-- aleth has quit (Quit: :tiuQ) 19:39:28 --> aleth has joined #instantbird 19:39:28 * ChanServ sets mode +o aleth 20:06:21 <-- nhnt11 has quit (Ping timeout: 121 seconds) 20:46:40 --> mudpit1 has joined #instantbird 20:47:47 --> EionRobb has joined #instantbird 20:48:39 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 20:48:42 --> mudpit1 has joined #instantbird 20:49:48 <-- mudpit has quit (Ping timeout: 121 seconds) 20:49:48 * mudpit1 is now known as mudpit 21:09:12 <-- EionRobb has quit (Quit: Leaving.) 21:09:19 --> EionRobb has joined #instantbird 21:09:36 <-- aleth has quit (Ping timeout: 121 seconds) 21:36:25 --> aleth has joined #instantbird 21:36:25 * ChanServ sets mode +o aleth 21:44:25 <flo-retina> in the ok and equal functions of xpcshell tests, is there an argument to provide a comment about what's being tested? 21:45:10 <aleth> yes 21:46:12 <flo-retina> I'm surprised https://bug1071166.bugzilla.mozilla.org/attachment.cgi?id=8516180 has 2 r+ flags then :-S 21:46:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1071166 nor, --, ---, nobody, NEW, Outgoing messages not escaped correctly 21:49:19 <flo-retina> I don't really understand the "// Pass an object here, instead of just a function, because coercion to an nsIObserver won't happen in the JS tests." thing either. 21:49:36 <flo-retina> Changing the implementation because of tests (except for bug fixes of course) usually makes me frown 21:50:28 <aleth> Well, do we insist on using that optional parameter now? Last time I suggested it to clokep he didn't seem excited 21:51:03 <flo-retina> really? 21:51:17 <clokep> I don't see how it helps, it gives you the line number... 21:51:37 <flo-retina> well, if you don't use the parameter, I'll ask for a comment above each line asking what you intend to test ;) 21:51:49 <aleth> fwiw I used it in my latest patch, but I agree the xpcshell output is badly structured 21:52:11 <flo-retina> because when the test breaks a few months later, having a plain-english version of what's being tested is sometimes the only way to figure out if the test or the implementation is broken 21:54:15 <flo-retina> Looks like we never remove that observer: http://mxr.mozilla.org/comm-central/source/chat/components/src/imConversations.js#128 21:54:45 <clokep> Btw I never meant that comment to mean "we shouldn't use it" ;) 21:54:48 <flo-retina> that will be interesting for whoever is ever brave enough to attempt to make conversation tabs have a non crazy behavior when an unmerging buddies 21:54:51 <clokep> Just that I don't find it useful. 21:55:07 <flo-retina> s/when an/when 21:55:51 <flo-retina> Is this known/fixed? Error: [Exception... "LoadInfo arguments must be undefined" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource:///modules/xmpp.jsm :: XMPPAccountPrototype._cacheUserIcon :: line 1296" data: no] 21:55:51 <flo-retina> Source File: resource:///modules/xmpp-xml.jsm 21:55:51 <flo-retina> Line: 387 21:55:55 <aleth> I wonder if it already leaks 21:56:25 <aleth> ha, is that the change which someone didn't want to r- the patch for? 21:56:27 <flo-retina> aleth: I don't think it does, there's no way for the UIConv to stop observering a prplConv once they've been attached. 21:56:41 <flo-retina> aleth: looks like it ;) 21:56:47 <flo-retina> aleth: I didn't r+ either ;) 21:59:33 <clokep> flo-retina: I haven't seen that XMPP error before. 22:04:13 <flo-retina> I don't know the steps to reproduce, the timestamp is from 24/12/2014 22:04:44 <aleth> I would guess reproducing is just connecting an XMPP account after restart 22:04:50 <aleth> I see it too 22:07:19 --> myk has joined #instantbird 22:12:55 <flo-retina> ok 22:15:53 <flo-retina> that review takes longer than I had expected 22:23:24 <-- mconley has quit (Connection closed) 22:25:58 <aleth> I remember it being confusing and asking for lots of comments... 22:28:48 <flo-retina> I hope my comments make sense :) 22:29:30 <flo-retina> I wonder what happened to my plans of hacking things during the holidays 22:29:32 <aleth> ah yeah, using QueryInterface is much better there 22:36:29 --> Bollebib has joined #instantbird 22:38:50 <flo-retina> hmm, maybe I should have reviewed the implementation patch before the test patch :-S 22:44:25 <clokep> I did that to aleth recently. :( 22:46:59 <flo-retina> alright, the implementation patch looks good (minus comment typos) 22:47:10 <flo-retina> it just made me think of something else that the test should ensure 22:47:52 <aleth> Just goes to show multiple pairs of eyes on that patch was not a waste of time ;) 22:55:54 --> mudpit1 has joined #instantbird 22:57:51 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 22:57:55 --> mudpit1 has joined #instantbird 22:58:05 <-- mudpit has quit (Ping timeout: 121 seconds) 22:58:07 --> mudpit has joined #instantbird 23:01:57 <-- mudpit1 has quit (Ping timeout: 121 seconds) 23:05:27 --> mudpit1 has joined #instantbird 23:06:02 <-- mudpit1 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:06:06 --> mudpit1 has joined #instantbird 23:08:13 <-- mudpit has quit (Ping timeout: 121 seconds) 23:08:13 * mudpit1 is now known as mudpit 23:15:33 <flo-retina> aleth: btw, at midnight + a few minutes, I was surprised to see a full date in the tooltip when hovering a message that was like 5 minutes old. 23:15:59 <flo-retina> I wonder if the test shouldn't be something like "not the same day AND at least an hour old" or something 23:16:05 <flo-retina> or maybe I'm just overthinking this :) 23:16:35 --> nhnt11 has joined #instantbird 23:16:35 * ChanServ sets mode +h nhnt11 23:20:13 <aleth> arguably, you only need the date when it 23:20:30 <aleth> s more than 24 hours ago, but I think the current behaviour is clearer and discoverable 23:21:04 <flo-retina> well, if it's 10 hours ago and you scrolled a bunch, you may need the date 23:22:38 <-- nhnt11 has quit (Ping timeout: 121 seconds) 23:39:56 <-- aleth has quit (Ping timeout: 121 seconds) 23:42:42 --> aleth has joined #instantbird 23:42:42 * ChanServ sets mode +o aleth 23:48:17 <-- aleth has quit (Connection closed) 23:48:24 --> aleth has joined #instantbird 23:48:24 * ChanServ sets mode +o aleth 23:52:49 <-- aleth has quit (Ping timeout: 121 seconds) 23:59:26 --> aleth has joined #instantbird 23:59:27 * ChanServ sets mode +o aleth