#instantbird log on 12 04 2014

All times are UTC.

00:05:05 * mconley_ is now known as mconley 
00:10:36 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
00:13:14 <-- mconley has quit (Ping timeout: 121 seconds)
00:15:47 <EionRobb> wow, that's crazy :)
00:16:08 <clokep> You again?
00:16:18 <EionRobb> nope, the other one
00:16:27 --> mconley has joined #instantbird
00:16:58 <EionRobb> why don't you either just apply a diff on libpurple, or have an instantbird branch in the hg.pidgin.im that you can merge versions into?
00:17:35 <-- mconley has quit (Connection closed)
00:17:48 <EionRobb> or split out libpurple into its own plugin :)
00:17:53 --> mconley has joined #instantbird
00:18:20 <EionRobb> clokep: how goes the skypething?
00:18:31 <clokep> EionRobb: Cause this is what we had when you guys were on mtn...and never changed our ways yet.
00:18:40 <clokep> Not sure what you mean by "split into its own plugin"?
00:18:45 <clokep> EionRobb: Looking at your code now!
00:19:00 <EionRobb> do the ctypes thing, like the otr plugin, and keep it out of tree
00:19:14 <clokep_work> Ah, yeah...welll....that's an option.
00:21:36 * clokep_work doesn't like your skypeweb_post_or_get method. ;)
00:21:41 <clokep_work> It seems very overloaded.
00:24:07 <clokep> aleth: BTW My thought is that "date" could (in the future) be used for *just* the date.
00:24:20 <aleth> clokep: yes, makes sense.
00:24:44 <clokep> :)
00:24:48 <clokep> I thought so. :-D
00:24:58 <aleth> In fact I initially had it for just the date but then added the time to avoid two calls per message
00:25:15 --> flo-retina has joined #instantbird
00:25:15 * ChanServ sets mode +qo flo-retina flo-retina 
00:25:22 * nhnt11 has about enough time to look at Not Today! before bed
00:26:57 <-- arlolra has quit (Client exited)
00:27:46 <clokep> nhnt11: :) Is the source of that even somewhere? :-S
00:27:54 <clokep> I have a feeling it essentially needs to be rewritten though
00:27:57 <nhnt11> clokep: I just unzipped the XPI
00:28:06 <nhnt11> Nah, I can borrow the code that does the actual link-replacing
00:28:14 <clokep> True!
00:28:28 <nhnt11> Even if that couldn't be reused, not a big deal
00:30:06 <nhnt11> clokep: What's the difference between "preparing-message" and "sending-message"
00:30:08 <instantbot> aleth@instantbird.org changed the Resolution on bug 1105798 from FIXED to ---.
00:30:09 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105798 nor, --, 1.6, nhnt11, REOP, Copying from a debug log tab loses line breaks
00:30:33 <nhnt11> Was it really necessary to have one for before calling prepareForSending on the prpl and one for after?
00:30:43 <nhnt11> (I'm assuming that was the reason, I may be wrong)
00:30:59 <nhnt11> aleth: Did you reopen that just for backing it out or is it still broken with the hack?
00:31:09 * nhnt11 stops being lazy and opens it
00:31:13 <nhnt11> cool
00:31:20 <nhnt11> I'll back it out and test before bed :)
00:31:29 <clokep> nhnt11: Umm...it's necessary. :)
00:31:34 <-- mconley has quit (Connection closed)
00:31:49 <nhnt11> Okay wait, I think I got it
00:31:59 <nhnt11> Using preparing-message allows stuff to shorten it before it gets split
00:32:10 <nhnt11> Using sending-message lets stuff like otr encrypt each split message
00:32:14 <nhnt11> (right?)
00:33:04 <clokep> Yes.
00:33:18 <nhnt11> Why not just let the prpl listen for sending-message?
00:33:26 <clokep> nhnt11: https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=1071166&attachment=8516180
00:33:28 <nhnt11> Oh hmm, order...
00:33:31 <clokep> The tests there might be helpful.
00:33:36 <clokep> What?
00:34:15 <nhnt11> I mean, if the prpl listens for sending-message, there's no way for something to ensure it gets to modify the message /before/ the prpl
00:34:33 <nhnt11> (the prpl would likely have added itself as an observer before anything else)
00:35:03 * nhnt11 is reading the tests
00:35:57 <clokep> Right....but....prpls don't really observe things IIRC.
00:36:02 <clokep> They have methods called on them.
00:36:31 <aleth> nhnt11: there are also lots of helpful comments in the idl
00:36:48 <clokep> I couldn't find the right one. :-\
00:37:23 <aleth> lots and lots of comments ;)
00:37:38 <clokep> aleth: Which IDL is it?
00:37:46 <clokep> nhnt11: I'd like a block diagram drawn though, yes. :-D
00:38:04 <nhnt11> Yeah, I'm looking at both the IDL's in the patch and not seeing anything too helpful...
00:38:18 <clokep_work> EionRobb: Just for the record, I hate anythign that has a JSON API that isn't JS. :)
00:38:19 <nhnt11> Btw, I'm not confused about the flow of things
00:38:19 <aleth> I thought imIConversationsService
00:38:29 * clokep_work was looking at some Java code which used *TWO* different JSON libraries today.
00:38:30 <nhnt11> I'm a little confused about the reason for things to flow the way they do.
00:39:22 <aleth> There's a lot of discussion in bug 983347 if it helps
00:39:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=983347 nor, --, 1.6, arlolra, RESO FIXED, Need different paths for displaying to the screen and sending over the wire
00:39:54 --> mconley has joined #instantbird
00:39:58 <nhnt11> A lot indeed... don't have time to read through that at the moment
00:40:00 * nhnt11 shrugs
00:40:13 <nhnt11> I can live in with the teeny confusion, doesn't affect what I'm doing :)
00:41:09 <aleth> fwiw I also don't think prpls are going to listen to sending-message, as clokep said
00:41:59 <nhnt11> I'm not too curious about the answer to this at the moment, but why not?
00:42:52 <aleth> Why would they have to?
00:43:04 --> iamjayakumars has joined #instantbird
00:43:12 <nhnt11> Right now they don't, because there's a prepareForSending function
00:43:14 <aleth> They get it anyway after sendin-message is handled
00:43:50 <nhnt11> You're right, now I'm more confused
00:44:11 <clokep> Where's arlo when we need him? :P
00:44:22 <aleth>  /summon arlo
00:46:15 <nhnt11> Hmm, well they aren't guaranteed to get the original message after sending-message is handled because something could have modified it
00:46:51 <-- gerard-majax_ has quit (Ping timeout: 121 seconds)
00:47:33 <clokep> nhnt11: http://dxr.mozilla.org/comm-central/source/chat/components/src/imConversations.js#348
00:47:46 <nhnt11> I'm already looking at that function
00:49:04 <clokep> nhnt11: Pretty much it goes: 1. add-ons can modify raw message from the user, 2. the prpl gets to modify a message (i.e. split into smaller parts, escape HTML, etc.), 3. add-ons get to modify the prpl-ified message, 4. the add-on sends the message over it's transport.
00:49:16 <nhnt11> I understood that
00:49:22 <nhnt11> I'm just confused about why there are so many steps
00:49:34 <clokep> Which step is confusing you? :-\
00:49:37 <-- iamjayakumars has quit (Quit: )
00:49:45 <nhnt11> clokep: Btw, if OTR listens to sending-message, then doesn't that mean that sending-message is useless to everything else?
00:49:47 <clokep> I assume 1 and 4 are obvious. :)
00:50:04 <clokep> nhnt11: Not necessarily, no.
00:50:12 <nhnt11> Why would anything want to encrypted message?
00:50:27 <clokep> There's an ordering problem there though, yes.
00:50:30 <nhnt11> want the*
00:50:33 <clokep> Why are you assuming OTR happens first? ;)
00:50:46 <nhnt11> clokep: I assume that OTR registers itself as an observer at startup
00:50:51 <nhnt11> And that's not a bad assumption, I think
00:51:07 <clokep> ...
00:51:32 <nhnt11> If it registers itself first, it will be notified first
00:51:52 <nhnt11> And therefore by the time anything else is notified, the message is unreadable
00:52:37 <clokep> I'm unsure why you're worried about this. :-\
00:52:45 <clokep> That is pretty much added for encryption, yes.
00:52:53 <clokep> You could use a different method of encryption instead of OTR.
00:53:14 <clokep> I don't think we could come up with a better way to allow multiple handlers there though, os it's left up to the implementer to deal w/.
00:54:12 <nhnt11> To me, as an add-on writer, it took a bit of thinking to realize that sending-message is probably useless to me and that I should use preparing-message.
00:54:34 <clokep> nhnt11: I think that we need to improve documentation, yes.
00:56:01 <nhnt11> Also earlier when i was saying the prpl should listen for the notification too instead of having its own API, I forgot about libpurple prpls...
00:56:33 <clokep_work> EionRobb: So...does the Skype code not keep an HTTP connection open? It polls?
00:57:15 <nhnt11> Also by the way, "If an add-on wants to split a message, it should truncate the first message, and insert new messages using the conversation's sendMsg method." <-- This implies recursion, which bothers me.
00:58:07 <clokep_work> Why?
00:58:46 <Mook_astb> Ooh, that means I can blow up the (JS) stack by trying to send an obscenely long message? :D
00:58:49 <clokep_work> Hmm...that sounds wrong anyway, it seems to me like it should *cancel* the messages.
00:59:07 <clokep_work> Mook_astb: Not unless someone has a really crappy split method...
00:59:25 <clokep_work> (I.e. if it only splits into two messages each time.)
01:00:17 <nhnt11> clokep_work: with the current API, it should certainly not cancel the messages
01:00:43 <nhnt11> The apparent idea seems to be that the first of the split will get parsed as normal, and then more messages get added
01:01:23 <nhnt11> clokep: Here's the problem with recursion. I split the message into 10 parts, and call sendMsg on each of them. Now, the first message doesn't finish parsing until the last one is done
01:01:28 <nhnt11> (If I'm not wrong)
01:01:43 <nhnt11> So the order of the messages gets totally messed up...
01:02:07 <Mook_astb> Ah, so it's smart enough? Okay.
01:02:42 <clokep_work> Mook_astb: I don't know about "smart enough", someone can always write bad code. ;)
01:03:07 <nhnt11> In addition to that, if the addon is splitting the messages in a way that each /split/ message can always be further split, this will result in infinite recusion.
01:03:09 <Mook_astb> Now I'm wondering if that means the new messages will hit preparing-message again
01:03:29 <nhnt11> Mook_astb: They will, that's my point (if we're talking about the same thing)
01:03:30 <clokep_work> nhnt11: Yeah that's what Mook_astb is saying. I'm saying "don't do that"
01:03:48 <nhnt11> "You're holding it wrong"? ;)
01:03:50 <nhnt11> sorry couldn't resist
01:04:04 <clokep_work> nhnt11: It's expected that consumers of that API are async.
01:04:13 <clokep_work> "Clear the message, call something async, return"
01:04:23 * nhnt11 will try to improve the documentation for this later :)
01:05:03 * Mook_astb wonders what would happen with a URL that's long enough that |<a href="${url}">| by itself takes up exactly one split-size
01:05:14 <Mook_astb> (assuming a protocol that uses <a href>s of course)
01:05:38 <nhnt11> link shortener addon!
01:09:22 <-- flo-retina has quit (Ping timeout: 121 seconds)
01:10:01 <nhnt11> aleth, clokep_work: What's the procedure to "take over" an addon?
01:10:16 <nhnt11> Should I change the email on the install.rdf? (I'm leaving Mic's name as a creator)
01:10:33 --> Hoony has joined #instantbird
01:11:01 <clokep> nhnt11: Add yourself as an author, get one of us to give you access on addons.instantbird.org.
01:11:13 <clokep> (Note, don't *change* him as the author, there's a way to add additional authors.)
01:11:21 <clokep> nhnt11: And make sure *not* to change the ID.
01:11:27 <nhnt11> Yeah, keeping the id
01:11:44 --> gerard-majax_ has joined #instantbird
01:11:58 <-- mconley has quit (Connection closed)
01:12:33 <clokep_work> nhnt11: Should be able to upload a new version to https://addons.instantbird.org/en-US/instantbird/addon/344/ now
01:12:55 <nhnt11> Okay, thanks
01:13:12 <nhnt11> Cool, seeing it in my dashboard
01:13:15 <clokep> nhnt11: Don't forget to bump the MIN version btw. :)
01:13:20 <nhnt11> Already did
01:14:47 <clokep> Just making sure.
01:17:30 <clokep_work> EionRobb: Btw you said something about...websocket support did you have any more pointers to that?
01:18:13 <clokep> nhnt11: Btw we should totally...make that not experimental. :)
01:18:52 <clokep> nhnt11: Btw if you do have concerns about the API...please do bring them up, we can certainly revise it. And it's good to get input from someone *actually* using it. :)
01:18:59 <nhnt11> Sure.
01:19:11 <clokep> Best to do it while arlo is here though!
01:19:12 <nhnt11> I'll bring it up when I see arlo around and I'm not too busy studying :)
01:19:17 <nhnt11> yeah
01:19:18 <clokep> Yes, exactly. :)
01:20:48 * clokep needs a way to ignore messages from his other nick.
01:22:50 * clokep_work wants a version of Not Today! for bugzilla. :-D
01:22:51 <Mook_astb> Hmm. I can think of three levels of ignoring (don't show in log, don't allow highlighting, or just don't show in unread message counts)
01:23:14 <-- myk has quit (Ping timeout: 121 seconds)
01:24:35 <clokep> Mook_astb: Don't show unread message counts is what I want...but that probably only counts if there isn't already unread messages.
01:26:09 <nhnt11> BAH
01:26:21 <nhnt11> errors in addons are displayed in the "Messages" tab in teh error console
01:26:22 <nhnt11> :(
01:27:29 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:27:39 --> nhnt11 has joined #instantbird
01:27:39 * ChanServ sets mode +h nhnt11 
01:27:49 <nhnt11> Ah, I've reahed the string replacing function
01:27:51 <nhnt11> Should work next try :)
01:28:50 <clokep> :)
01:28:55 <clokep> "should", final last word.
01:29:25 <nhnt11> This is weird
01:29:36 <nhnt11> the OutgoingMessage seems to be null :S
01:31:18 <EionRobb> clokep: something about websockets... I don't have a good way of intercepting them yet
01:31:50 <clokep> EionRobb: Hmm...OK....I guess I'm wondering if you saw a reference somewhere or whatever? I think making a websocket for me is as easy as "new WebSocket()"?
01:33:06 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:33:17 --> nhnt11 has joined #instantbird
01:33:17 * ChanServ sets mode +h nhnt11 
01:33:59 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:34:08 --> nhnt11 has joined #instantbird
01:34:08 * ChanServ sets mode +h nhnt11 
01:35:27 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:35:37 --> nhnt11 has joined #instantbird
01:35:37 * ChanServ sets mode +h nhnt11 
01:36:22 <nhnt11> Ah, it's working :)
01:36:26 <EionRobb> clokep: yeah there's socket.io requests to go.trouter.io - don't know how any of that works or what that's used for
01:36:47 <nhnt11> http://log.bezut.info/instantbird/141204/
01:36:48 <nhnt11> :)
01:36:54 <clokep> Ah, interesting.
01:37:14 <-- gerard-majax_ has quit (Ping timeout: 121 seconds)
01:37:15 --> Widders has joined #instantbird
01:37:15 --> Widdershins has joined #instantbird
01:37:45 <-- Widders has quit (Quit: Leaving)
01:43:00 <-- aleth has quit (Ping timeout: 121 seconds)
01:43:53 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:44:02 --> nhnt11 has joined #instantbird
01:44:02 * ChanServ sets mode +h nhnt11 
01:44:32 --> flo-retina has joined #instantbird
01:44:32 * ChanServ sets mode +qo flo-retina flo-retina 
01:49:09 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
01:49:16 --> nhnt11 has joined #instantbird
01:49:16 * ChanServ sets mode +h nhnt11 
01:49:28 <-- flo-retina has quit (A TLS packet with unexpected length was received.)
01:49:48 <nhnt11> Testing if it's working with convs already existing after installing the addon: http://log.bezut.info/instantbird/141204
01:49:50 <nhnt11> Cool
01:50:42 <nhnt11> Okay,edge cases seem fine, shutdown is working, time to ship :)
01:53:15 <nhnt11> Uploaded. https://addons.instantbird.org/en-US/instantbird/addon/344/
01:56:35 <nhnt11> Time to backout that debug log copy hack..
01:56:39 * nhnt11 starts a clobber build
02:07:17 --> Widders has joined #instantbird
02:09:19 <-- Widdershins has quit (Ping timeout: 121 seconds)
02:09:59 <-- Mook_astb has quit (Client exited)
02:13:56 --> Widder has joined #instantbird
02:13:59 <-- Widder has quit (Connection closed)
02:16:04 <nhnt11> aww, backing it out seems to break it again :(
02:16:16 <nhnt11> looks like that fix in bug 1105798 didn't work :S
02:16:18 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105798 nor, --, 1.6, nhnt11, REOP, Copying from a debug log tab loses line breaks
02:16:32 <nhnt11> Um, I meant bug 116083
02:16:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=116083 nor, --, mozilla37, ehsan.akhgari, RESO FIXED, copy paste of CSS "white-space: pre;" content does not preserve whitespace
02:16:48 <nhnt11> unless I'm missing something...
02:16:55 <-- Widders has quit (Ping timeout: 121 seconds)
02:17:33 <clokep_work> :-S
02:17:40 <clokep_work> I just ahd the weirdest bug....
02:21:46 <nhnt11> breakfast time, bbl
02:23:56 <clokep_work> (o_O)
02:24:04 <clokep_work> Hope it's something good. :)
02:31:20 <EionRobb> what's the weirdest bug?
02:40:02 <clokep> Something weird about concating arrays...
02:40:30 <clokep> [].concat([[1, 2] [3, 4]]) had me end up with [null, [1, 2], [3, 4]] or something.
02:40:47 <-- clokep_work has quit (Ping timeout: 121 seconds)
02:40:52 <EionRobb> oh, not something like https://www.destroyallsoftware.com/talks/wat ? :)
02:41:11 <clokep> No, but I love that video.
02:41:16 <EionRobb> :D
02:46:15 --> Widdershins has joined #instantbird
03:07:12 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:32:48 <-- EionRobb has quit (Quit: Leaving.)
04:56:14 <instant-buildbot> build #1247 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1247
05:03:13 --> mommlers has joined #instantbird
05:03:44 <-- momiga has quit (Ping timeout: 121 seconds)
05:05:41 <instant-buildbot> build #2449 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2449
05:39:37 --> mconley has joined #instantbird
05:40:34 --> mpmc has joined #instantbird
05:41:09 <instant-buildbot> build #143 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/143
05:54:09 --> Bollebib has joined #instantbird
06:32:56 <-- Hoony has quit (Ping timeout: 121 seconds)
06:35:48 <-- Bollebib has quit (Connection closed)
06:39:31 --> Hoony has joined #instantbird
06:53:08 --> Defman has joined #instantbird
07:55:52 <-- mconley has quit (Connection closed)
08:02:01 * Fallen|away is now known as Fallen 
08:46:03 --> aleth has joined #instantbird
08:46:03 * ChanServ sets mode +o aleth 
08:48:38 <-- aleth has quit (Quit: :tiuQ)
08:48:41 --> aleth has joined #instantbird
08:48:41 * ChanServ sets mode +o aleth 
09:06:59 <instantbot> aleth@instantbird.org changed the Resolution on bug 955312 from --- to FIXED.
09:07:00 <instantbot> aleth@instantbird.org changed the Resolution on bug 1106917 from --- to FIXED.
09:07:01 <instantbot> aleth@instantbird.org changed the Resolution on bug 1106328 from --- to FIXED.
09:07:02 <instantbot> aleth@instantbird.org changed the Resolution on bug 1106246 from --- to FIXED.
09:07:03 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1106328 nor, --, 1.6, aleth, RESO FIXED, JS-XMPP never sends typing notifications
09:07:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1106246 min, --, 1.6, aleth, RESO FIXED, Improve SASL error messages
09:07:05 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1106917 nor, --, 1.6, aleth, RESO FIXED, Content font size setting affects various UI elements too, breaking the layout
09:07:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955312 enh, --, 1.6, aleth, RESO FIXED, Date information should be available for messages and status messages
09:08:47 <-- Defman has quit (Quit: My Double-Powered Atomic Reactor has gone to sleep. caaBOOOOM! ZZZzzz....)
10:01:15 --> BWMerlin has joined #instantbird
10:21:34 <-- Tonnes has quit (Connection closed)
10:22:31 --> Tonnes has joined #instantbird
10:31:13 --> Armada has joined #instantbird
10:41:13 <-- Hoony has quit (Client exited)
10:57:26 <-- Widdershins has quit (Ping timeout: 121 seconds)
11:20:14 --> clokep has joined #instantbird
11:20:14 * ChanServ sets mode +o clokep 
11:32:57 <clokep> aleth: I didn't actually review https://hg.mozilla.org/comm-central/rev/0e07208d399f :P
11:38:19 --> clokep_work has joined #instantbird
11:38:19 * ChanServ sets mode +o clokep_work 
11:42:21 <-- aleth has quit (Ping timeout: 121 seconds)
11:59:35 <clokep> http://glandium.org/blog/?p=3318 is an interesting read
12:04:01 --> aleth has joined #instantbird
12:04:01 * ChanServ sets mode +o aleth 
12:04:25 <aleth> clokep: oops, I didn't notice it was flo. That was unexpected.
12:13:06 <aleth> Looks like removing some jquery fixed some TB tests...
12:13:42 <clokep_work> Yep. :)
12:22:34 <clokep_work> aleth: So the interdiff between the 2.10.7 patch and the 2.10.9 patch is insanely small: http://pastebin.instantbird.com/1081018
12:22:39 <clokep_work> So I'm going to push that.
12:23:00 <aleth> indeed :-)
12:23:15 <clokep_work> I think I didn't have interdiff capabilities when I uploaded that code originally.
12:23:32 <aleth> Surprisingly small actually
12:24:41 <clokep_work> aleth: It seem OK if I push http://pastebin.instantbird.com/1081029 too?
12:24:49 <clokep_work> They're changes I need to run that on my system for some reason> :-\
12:24:54 <clokep_work> I'm not a sh expert though.
12:26:18 <-- BWMerlin has quit (Client exited)
12:27:52 <aleth> I'm puzzled by the double brackets
12:29:33 <aleth> But I'm OK with those changes.
12:30:31 <aleth> http://mywiki.wooledge.org/BashFAQ/031
12:32:54 <aleth> I'd understand if you had added either the [[ or the quotes
12:33:22 <aleth> Never mind, as both have the same effect...
12:36:12 <Fallen> clokep_work: what does |which echo| give you?
12:37:06 <Fallen> and |which [|
12:38:43 <clokep_work> Fallen: which echo: echo: shell built-in command
12:38:51 <clokep_work> Fallen: same with which [
12:39:01 <Fallen> clokep_work: what does echo $SHELL give you?
12:39:22 <clokep_work> Fallen: I'm running zsh.
12:39:32 <clokep_work> I don't need to echo it to tell you that. ;)
12:39:39 <Fallen> maybe thats the reason it doesn't work?
12:39:45 <clokep_work>  /bin/zsh is the answer though.
12:39:49 <clokep_work> It likely is.
12:40:04 <Fallen> but as mentioned, if it does the same its fine of course :-)
12:40:50 <clokep_work> aleth: Ah, just the quotes seems to work. :)
12:41:01 <clokep_work> I'll use that then since it's more portable? (o_O)
12:41:37 <Fallen> as long as the first line of that script is #!/bin/bash you shouldn't need to adapt for zsh
12:42:07 <Fallen> (and it has chmod +x)
12:43:02 <clokep_work> Fallen: It's #!/bin/sh
12:43:21 <clokep_work> http://hg.mozilla.org/users/florian_queze.net/purple/file/97fdf172fc98/upgrade-libpurple.sh is the script
12:43:31 <Fallen> that should be enough too. Executing as ./upgrade-libpurple.sh ?
12:43:53 <clokep_work> Yes.
12:44:00 <clokep_work> If i echo $SHELL in it, it still says zsh.
12:44:32 <Fallen> does it work if you change it to #!/bin/bash ?
12:45:25 <clokep_work> Nope, still says it's zsh.
12:45:40 <Fallen> thats...strange...
12:46:06 <Fallen> Well I guess you could execute it as bash upgrade-libpurple.sh
12:46:40 <Fallen> but I'll shut up now, its likely not a major issue :-)
12:46:59 <clokep_work> Hah, I tried that. :) It still runs as zsh.
12:47:37 <Fallen> there.is.only.zsh :-)
12:47:40 <clokep_work> Apparently!
12:58:58 --> Hoony has joined #instantbird
13:03:01 <-- clokep has quit (Connection closed)
13:03:04 --> clokep has joined #instantbird
13:03:04 * ChanServ sets mode +o clokep 
13:08:01 <-- clokep has quit (Ping timeout: 121 seconds)
13:08:10 <-- clokep_work has quit (Ping timeout: 121 seconds)
13:36:31 <aleth> clokep: uh... you pushed before answering my question in comment #15
13:37:31 <aleth> I guess that means the answer is no?
13:46:04 --> clokep_work has joined #instantbird
13:46:04 * ChanServ sets mode +o clokep_work 
13:51:14 <-- Hoony has quit (Ping timeout: 121 seconds)
13:53:07 --> Hoony has joined #instantbird
13:53:46 <-- Hoony has quit (Client exited)
13:55:30 --> Hoony has joined #instantbird
14:10:50 <clokep_work> aleth: I didn't add any TODOs.
14:17:05 --> myk has joined #instantbird
14:37:13 --> flo-retina has joined #instantbird
14:37:14 * ChanServ sets mode +qo flo-retina flo-retina 
14:39:48 <flo-retina> fwiw, imThemes.jsm is one of the files with complicated history where ensuring I have at least seen briefly a patch before it gets checked-in would make sense.
14:39:50 <flo-retina> hello :)
14:42:27 --> hadi has joined #instantbird
14:43:03 <clokep_work> flo-retina: Hello! :) Sorry.
14:51:07 <aleth> flo-retina: good to know
14:54:31 <clokep_work> flo-retina: Any problems with what we added?
14:55:40 <flo-retina> clokep_work: I don't see a compelling reason for adding that, and making our themes even more incompatible with Adium (or other IM applications that implemented support for Adium themes).
14:55:58 <flo-retina> clokep_work: + it seems that's removing the ability to see at which second a message was sent
14:56:15 <clokep_work> Hmm...
14:57:07 <clokep_work> Yes, that doesn't seem good.
14:57:15 * clokep_work would wish we'd close bugs if they were things we don't want though. :(
14:59:36 <flo-retina> I'm not saying the bug isn't something we want
14:59:44 <flo-retina> just that the current patch seems a regression
15:00:08 <flo-retina> ah, I guess what I said was confusing
15:00:32 <flo-retina> "I don't see a compelling reason for adding that" 'that' here = "%datetime% support", not the feature :)
15:02:46 <clokep_work> flo-retina: So you don't think it should be in tooltips? I'm confused.
15:03:04 <aleth> flo-retina: fwiw our default styles won't work on adium anyway. We are only compatible in the sense that we can use their themes.
15:03:19 <aleth> But that's probably what you meant, I just don't see how this patch changes anything about that.
15:04:00 <flo-retina> aleth: the patch changes that someone can create a theme using %datetime% and that won't work on Adium
15:04:14 <flo-retina> if we just used %time{something}% Adium would fallback to something mostly reasonable
15:05:06 <aleth> I don't think that's true, we'd need to add a custom something and that will break in unpredictable ways
15:05:09 <flo-retina> clokep_work: "you don't think it should be in tooltips" seems the opposite of what I said :-S. I'm confused about how I managed to confuse you so much :-S
15:05:23 <flo-retina> why would that break?
15:05:51 <aleth> There is no existing "something" that does what we want.
15:06:10 <clokep_work> aleth: Yes, you can use the time{format} function.
15:06:37 <aleth> clokep_work: As I said in the bug, that does not produce correctly localized results
15:07:03 <aleth> You have to specify the order of things, and that depends on localization.
15:07:40 <flo-retina> aleth: as I said in the bug, you could add a special value there
15:07:46 <clokep_work> Ahhhh.
15:08:03 <aleth> flo-retina: and then it's no longer compatible. Am I misunderstanding you so badly? :-S
15:08:30 <clokep_work> Ah...I re-read the bug at work and then reviewed the code at home, probably a bad idea.
15:09:17 <flo-retina> aleth: do you think date.toLocaleFormat("garbage"); (and it's equivalent in Adium) would throw?
15:09:42 <aleth> flo-retina: I think it's unpredicable how some third party client will treat that.
15:09:57 <aleth> While %garbage% just gets ignored.
15:09:59 <flo-retina> apparently it just returns "garbage" :-/
15:10:24 <flo-retina> by ignored you mean replaced by ""?
15:10:29 <aleth> Yes
15:11:15 <flo-retina> alright
15:11:27 <flo-retina> anyway, what really irked me is removing the seconds from the tooltip ;)
15:11:48 <flo-retina> I probably wouldn't have commented in the bug at all if there wasn't that issue
15:13:34 <clokep_work> flo-retina, aleth: Will adding the seconds back make everyone happy? :-D
15:13:47 <flo-retina> clokep_work: I'll still be hungry
15:13:54 <clokep_work> I can't help you there. :)
15:14:01 <flo-retina> so probably not happy, but it will likely make everyone move on ;)
15:17:24 <clokep_work> I'm hungry too..hm...
15:27:34 <-- myk has quit (Ping timeout: 121 seconds)
15:31:13 <aleth> "15:57:11 * clokep_work would wish we'd close bugs if they were things we don't want though. […]" yes please!
15:31:43 --> gerard-majax_ has joined #instantbird
15:32:03 <aleth> personally I could easily live without the date in tooltips ;)
15:36:11 --> sonny has joined #instantbird
15:36:26 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
15:39:11 * Fallen is now known as Fallen|away 
15:46:07 <clokep_work> aleth: I think we should show them *somewhere* though.
15:46:31 <aleth> Yes, I thought it was a reasonable request too.
15:48:57 --> Hoony1 has joined #instantbird
15:50:20 <-- Hoony has quit (Ping timeout: 121 seconds)
15:53:43 <-- Hoony1 has quit (Connection closed)
15:53:55 --> Defman has joined #instantbird
15:54:19 <-- sonny has quit (Ping timeout: 121 seconds)
15:56:34 --> Hoony has joined #instantbird
15:58:55 --> kapy has joined #instantbird
16:07:23 <-- hadi has quit (Ping timeout: 121 seconds)
16:12:42 <-- Hoony has quit (Ping timeout: 121 seconds)
16:15:13 <-- gerard-majax_ has quit (Ping timeout: 121 seconds)
16:15:34 --> myk has joined #instantbird
16:18:38 --> Bollebib has joined #instantbird
16:28:02 --> hadi has joined #instantbird
16:29:14 --> gerard-majax_ has joined #instantbird
16:30:04 <-- Defman has quit (Ping timeout: 121 seconds)
16:36:11 <-- kapy has quit (Connection closed)
16:36:22 --> Hoony has joined #instantbird
16:42:25 <-- Hoony has quit (Ping timeout: 121 seconds)
16:50:14 --> kapy has joined #instantbird
16:53:10 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:53:14 --> myk has joined #instantbird
16:53:45 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:53:47 --> myk has joined #instantbird
16:58:59 --> mconley has joined #instantbird
16:59:10 <-- kapy has quit (Quit: )
17:04:13 <-- mconley has quit (Quit: NO CARRIER)
17:15:11 * Fallen|away is now known as Fallen 
17:46:07 <-- clokep_work has quit (Ping timeout: 121 seconds)
17:47:53 * Fallen is now known as Fallen|away 
17:48:20 <-- hadi has quit (Ping timeout: 121 seconds)
17:57:46 --> Mook_as has joined #instantbird
18:02:13 --> arlolra has joined #instantbird
18:13:55 --> clokep_work has joined #instantbird
18:13:55 * ChanServ sets mode +o clokep_work 
18:39:20 <-- aleth has quit (Ping timeout: 121 seconds)
18:40:51 --> aleth has joined #instantbird
18:40:51 * ChanServ sets mode +o aleth 
18:52:41 <clokep_work> aleth: I filed bug 1098312 so that we could fix it *without* doing the full update if we wanted. :)
18:52:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1098312 nor, --, ---, nobody, NEW, Port MSN application ID changes to allow MSN to connect again
18:52:49 <clokep_work> But it'll be included. Sorry that wasn't clear!
19:07:16 --> hadi has joined #instantbird
19:14:54 --> mconley has joined #instantbird
19:23:10 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
19:23:16 --> nhnt11 has joined #instantbird
19:23:17 * ChanServ sets mode +h nhnt11 
19:25:18 --> EionRobb has joined #instantbird
19:57:05 <-- mconley has quit (Connection closed)
20:02:02 --> Defman has joined #instantbird
20:16:21 * Fallen|away is now known as Fallen 
20:42:25 --> flo-retina has joined #instantbird
20:42:25 * ChanServ sets mode +qo flo-retina flo-retina 
20:45:25 <flo-retina> FWIW, the behavior I would like is to show the date only when it's different from the current date.
20:46:15 <flo-retina> I had an experiment for that a while ago (with an onpopupshowing event handler to decide if the date should be hidden or shown) but IIRC for some reason that messed up the tooltip sizing (eg. the tooltip didn't shrink when the date got hidden)
20:49:40 <aleth> That's a good idea, but it could be done more easily by having datetime just not include the date if it's today.
20:50:17 <aleth> Could stick that in the followup...
20:50:43 <flo-retina> aleth: it's always today when an IRC message arrives
20:50:51 <flo-retina> aleth: the date is important when you read the scrollback
20:51:57 <aleth> Oh, right.
20:53:07 <aleth> Yes, modifying the tooltip on the fly doesn't work well, I had that issue with the participant tooltips too.
20:55:16 <aleth> It might be possible to do it, but then it would be independent of message styles.
20:56:25 <aleth> And probably a lot of work...
21:01:04 <clokep_work> aleth: I've seen funny things with the typing panels resizing weird too...
21:01:12 <clokep_work> (As in they look HUGE for the name in them.)
21:01:17 <clokep_work> I haven't managed to get a screenshot hough...
21:01:31 <hadi> !!!!!!!!!!!
21:05:36 <-- flo-retina has quit (Connection closed)
21:05:59 --> flo-retina has joined #instantbird
21:05:59 * ChanServ sets mode +qo flo-retina flo-retina 
21:07:43 <aleth> clokep_work: For some reason FX gives the status panels a minimum width
21:07:49 <aleth> We could change that of course.
21:09:32 <-- flo-retina has quit (A TLS packet with unexpected length was received.)
21:10:20 <nhnt11> aleth: Not sure if you saw from the logs, but backing out bug 1105798 still breaks copying from debug log tabs
21:10:23 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105798 nor, --, 1.6, nhnt11, REOP, Copying from a debug log tab loses line breaks
21:10:39 <nhnt11> oh, I commented on the bug too, hmm
21:10:53 <aleth> nhnt11: I guess the question is whether it's a m-c bug
21:11:53 <aleth> If it is, maybe ehsan will fix it too? ;)
21:12:15 <Mook_as> re: tooltips: what's "today"? At 1AM, 11PM (2 hours ago) probably shouldn't have a date.
21:12:51 <nhnt11> It's the same thing that's described in the m-c bug as far as I could tell, so I'll have to investigate
21:13:08 <clokep_work> aleth: Likely we want a SMALLER minimum width. :)
21:13:10 <nhnt11> Hmm, this "Today" discussion sounds oddly like something we were discussing wrt split logs...
21:13:20 <aleth> nhnt11: my thoughts exactly :D
21:13:20 <clokep_work> It is. :)
21:13:29 <aleth> Let's land that first and synchronize!
21:13:30 <clokep_work> nhnt11: BTW Thanks for fixing Not Today!
21:13:37 <clokep_work> aleth: and flo-retina should install that. :-D
21:13:37 * nhnt11 hasn't read the logs yet so I'm not sure what the topic is
21:13:39 <nhnt11> clokep_work: np
21:14:02 * aleth goes to install it too
21:14:22 <aleth> arlolra might want to install it at the same time as OTR and see if it still works ;) Nice test.
21:14:52 <nhnt11> I don't see why it would interfere with OTR, they use different obs notifications
21:15:23 <clokep_work> nhnt11: Ah, arlolra is here. :)
21:15:24 <clokep_work> Go discuss.
21:15:39 <aleth> nhnt11: that's the point, it shouldn't interfere ;)
21:16:31 <arlolra> what am I testing?
21:16:50 <aleth> nhnt11 wrote an add-on using the new message pipeline
21:19:03 <arlolra> oh, nice
21:19:07 <arlolra> is there a link?
21:20:11 <nhnt11> arlolra: https://addons.instantbird.org/en-US/instantbird/addon/344
21:20:42 <arlolra> nhnt11: did you try building with the patches here https://bugzilla.mozilla.org/show_bug.cgi?id=1071166 and running the tests?
21:20:44 <instantbot> Bug 1071166 nor, --, ---, nobody, NEW, Outgoing messages not escaped correctly
21:21:07 <arlolra> clokep_work, aleth: it'd be nice if that landed soon (understandbly flo is still busy)
21:21:49 <aleth> arlolra: I think it already has my r+, so it really is just waiting for flo
21:22:14 <nhnt11> arlolra: Is there a particular reason you're asking /me/ if I've tried it?
21:22:27 <nhnt11> Hmm, I see it has some "message pipeline" api changes..
21:23:47 <arlolra> nhnt11: ya, just so you're aware
21:23:53 <nhnt11> okay, thanks
21:24:03 <arlolra> aleth: i know ... but it's been a month since you signed off
21:24:09 <aleth> :-(
21:29:49 <clokep_work> arlolra: I'll try to remind FLoroian, maybe he can find time on his flight home.
21:29:51 <clokep_work> Sorry. :(
21:30:17 <aleth> arlolra: The next patches should be easier (no API changes)
21:31:02 <nhnt11> arlolra: I haven't seen the changes in the bug you linked me to yet, but did you see what I said about recursion yesterday? (I don't know if you read the logs)
21:31:46 <clokep_work> He doesn't. :)
21:31:48 <clokep_work> Can you link to it?
21:31:51 <nhnt11> Yeah, on it
21:31:56 <clokep_work> Use your extension! :P
21:32:02 <nhnt11> yeah :D
21:33:29 <nhnt11> arlolra: I had a few comments about the API, starting from here: http://log.bezut.info/instantbird/141204/#m34
21:33:47 <nhnt11> If you wait a minute I'll try and pastebin the important bits for you
21:33:54 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:35:27 <arlolra> thanks
21:35:57 <-- clokep_work has quit (Ping timeout: 121 seconds)
21:36:17 <arlolra> clokep_work: i'm not too worried about it. i understand he's busy. but it'd be nice to have the tests in place, especially now that it seems like other people are building off of it
21:36:30 <arlolra> not more clokep :(
21:36:41 <aleth> he'll be back ;)
21:37:18 <aleth> How close is some of that OTR backend to being able to be a patch?
21:38:08 <arlolra> the backend, i think we could land that part today
21:38:25 <arlolra> it feels pretty solid at this point
21:38:32 <arlolra> i've been dogfooding it for a whlie
21:38:41 <aleth> Because it's likely much easier to write the UI as a patch
21:38:43 <nhnt11> arlolra: Well there wasn't as much noise as I expected, but I pasted it anyway: http://pastebin.instantbird.com/1081820
21:38:49 <arlolra> ha
21:39:43 <nhnt11> tl;dr: a) Was it really necessary for there to be two separate notifications? And b) the recursion stuff towards the end of that pastebin
21:39:56 <nhnt11> (line 63)
21:40:43 <nhnt11> It's a small point, but I think that explicitly telling addon authors to split messages the way it is in the comment right now is a bit misleading I think... jmho
21:42:00 <nhnt11> I just realized that I don't know a lot about the OTR stuff that's happening. Is it going to be an addon? :S
21:42:20 <arlolra> sorry, still reading
21:42:21 * nhnt11 was assuming it's going to be merged in to the core
21:42:35 <arlolra> it will hopefully be merged soon
21:42:46 <arlolra> but was prototyped as an addon
21:43:04 <nhnt11> ah, okay
21:47:14 --> unghost has joined #instantbird
21:50:12 <arlolra> alright, i read that backlog
21:50:38 <nhnt11> bit of a long read, sorry :]
21:51:07 <arlolra> np
21:52:11 <arlolra> ok, so why two separate notifications. well, in that long history you didn't read bug 983347
21:52:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=983347 nor, --, 1.6, arlolra, RESO FIXED, Need different paths for displaying to the screen and sending over the wire
21:52:51 <arlolra> i wrote a few different patches that tried to solve more general use cases and, particularly, doing this all async
21:53:35 <arlolra> the powers that be found them all two complex or didn't do things right (ie. prpl's listening for events on the ui conversation)
21:53:37 <arlolra> etc
21:53:49 <arlolra> so, we simplified to 2 use cases
21:53:52 <arlolra> encryption
21:53:56 <arlolra> and addons like pastebin
21:54:24 <arlolra> the pastebin addon would listen for the preparing-message event
21:54:37 <arlolra> encryption for sending-message
21:54:51 <arlolra> any questions about that?
21:55:06 <nhnt11> Nope, I understand the flow as it is now :)
21:55:07 <arlolra> s/two/too/ complex
21:55:25 <nhnt11> I was just a bit surprised that having two notifications was necessary
21:55:37 <nhnt11> I get it though
21:55:48 --> mconley has joined #instantbird
21:55:55 <-- mconley has quit (Connection closed)
21:55:56 <nhnt11> I think the main problem was that it took me a while to realize which notification I should be using
21:56:25 <arlolra> the comments should be improved a bit with the tests
21:56:32 <arlolra> but agreed that could be more so
21:58:18 <arlolra> i'm not sure about your recursion scenario
22:01:36 <nhnt11> I just think it's an easy trap to fall into
22:01:50 <nhnt11> Hard to expect something to wrong when you follow directions ;)
22:02:00 <nhnt11> Anyway, it's just a matter of improving the comment, again
22:02:14 <nhnt11> to go* wrong
22:02:42 <arlolra> i think we only considered addons that would be idempotent
22:05:55 <arlolra> you're definitely right that if otr is enabled, you don't want other addons altering the msg afterwords (ie. listening on sending-message)
22:06:51 <arlolra> when the above patch lands, i'll work on improving the documentation around this stuff
22:07:26 <nhnt11> cool, thanks!
22:08:03 --> mconley has joined #instantbird
22:08:40 <-- Defman has quit (Quit: My Double-Powered Atomic Reactor has gone to sleep. caaBOOOOM! ZZZzzz....)
22:08:50 <-- mconley has quit (Connection closed)
22:09:12 <arlolra> nhnt11: i just read the source of your addon. that's exactly the intended use case for preparing-message. looks great
22:09:13 --> mconley has joined #instantbird
22:09:56 <nhnt11> arlolra: Great, thanks! I'm planning to update my pastebin addon too soon-ish, I'll let you know when I do if you want to take a look :)
22:12:31 <arlolra> i do. ping me when i'm around
22:13:08 <nhnt11> okay, it'll likely be in a few days.
22:13:24 <nhnt11> Thanks for working on the API btw, it was much needed :)
22:13:36 --> mconley_ has joined #instantbird
22:14:19 <arlolra> np. gotta run. have a good one
22:14:21 <-- arlolra has quit (Client exited)
22:15:07 <-- mconley has quit (Ping timeout: 121 seconds)
22:15:24 <nhnt11> Hmm, I actually wanted to change the pastebin addon to hook on (Ctrl|Cmd)+V instead and make it insert the link to the paste in the editor though
22:15:42 <nhnt11> As opposed to pasting while sending...
22:16:23 <aleth> That's a neat idea
22:17:37 <nhnt11> aleth: Another addon that I may work on tonight is to automatically prefix http:// on links
22:18:11 <nhnt11> (that's been a pet peeve of mine for a while)
22:18:19 <Mook_as> how do you define links?
22:18:52 <nhnt11> Mook_as: .*\..*\..*
22:19:58 <nhnt11> um, that^, with a slash or a space at the end.
22:20:13 <nhnt11> I know there are probably cases where that's not a link, but in most cases it is.
22:24:20 <-- nhnt11 has quit (Ping timeout: 121 seconds)
22:28:06 --> clokep has joined #instantbird
22:28:07 * ChanServ sets mode +o clokep 
22:32:50 <clokep> nhnt11: On received messages?
22:42:20 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:43:38 --> nhnt11 has joined #instantbird
22:43:39 * ChanServ sets mode +h nhnt11 
22:43:55 <nhnt11> clokep: No, on outgoing
22:44:08 <nhnt11> Like, when you paste a link, the addon would automatically prefix http:// if it wasn't there already
22:46:33 <clokep> Interesting.
22:46:38 <clokep> You can look for www. ;)
22:46:45 <nhnt11> A lot of links don't have www
22:46:52 <nhnt11> Popular use case: log.bezut.info
22:47:34 <nhnt11> I'm not entirely sure why we only linkify stuff that has a protocol prefix right now btw.
22:48:01 <EionRobb> so that version numbers don't get linked?
22:48:11 <clokep> nhnt11: I know that...but yeah.
22:48:14 <nhnt11> Good point.
22:48:20 <clokep> nhnt11: Because it's *really* hard to do otherwise.
22:48:26 <clokep> I think the Twitter code we have does it though?
22:48:46 * nhnt11 didn't know it was protocol specific
22:49:45 <clokep> nhnt11: It finds links in what you're sending.
22:49:59 <clokep> So it can properly give you the char count.
22:50:07 <nhnt11> Ah! to account for the shortener?
22:50:08 <nhnt11> cool
22:50:20 <clokep> My point was that we have some code that can attempt to find links.
22:50:26 <nhnt11> right
22:50:32 <nhnt11> I'll check it out
22:50:37 <clokep> Which is different than the code we use now to linkify stuff
22:51:22 <nhnt11> I've just realized that there's a whole lot of stuff that's possible with replacing stuff when pasting or sending or whatever.
22:51:45 <clokep> Like what? :)
22:51:58 <nhnt11> Like the protocol-prefixing
22:52:04 * clokep would still like to replace some links w/ images automatically on receive.
22:52:08 <clokep> But there's security issues w/ it.
22:52:17 <clokep> (I.e. replace youtube links w/ the preview + a link w/ the title)
22:52:21 <nhnt11> hmm
22:52:35 <nhnt11> automatic link shortening is another possibility
22:52:44 <nhnt11> (for really long links of course)
22:53:30 <clokep> Meh, I hate link shorteners...
22:53:37 <clokep> Now unshortening links would be neat. ;)
22:53:39 <nhnt11> yeah, you've said it before :P
22:53:49 <clokep> (On receive...which I think is possible.)
22:53:54 <nhnt11> Yeah, quite possible
22:54:03 <nhnt11> The trick would be to detect if it was a shortened link
22:54:08 <clokep> That's not hard.
22:54:11 <nhnt11> I think you could just do the http request only for the header
22:54:13 <nhnt11> and see if it's a redirect
22:54:14 <clokep> You just need a set of URLs you understand.
22:54:21 <clokep> That sounds dangereous. :)
22:54:29 <clokep> Also some URL shorteners don't use headers for the redirect.
22:54:34 <clokep> Some load a page and do it with JS or whatever.
22:54:41 <nhnt11> Yeah, good point
22:54:54 <clokep> Plus that means that someone could send INstantbird a link and voila have your IP address.
22:54:56 <-- Bollebib has quit (Connection closed)
22:54:56 <nhnt11> probably to discourage people from looking at headers ;)
22:55:13 <nhnt11> hmm
22:55:42 <nhnt11> yeah okay I didn't think that through
22:56:09 * nhnt11 was going for a method that would always work :]
22:57:11 <aleth> link detection edge case fixing... rather you than me ;)
22:57:33 <nhnt11> hey, I'm working on an addon, edge cases aren't important :P
22:57:38 <aleth> true :D
22:58:00 <aleth> clokep's idea of looking at that twitter library is good though
22:58:01 * nhnt11 should really look at Cmd+Shift+T edge cases :(
22:58:10 <clokep> :)
22:58:14 <clokep> I'd buy you a cookie for that.
22:58:14 <nhnt11> It just works so well as an addon that I don't care enough to look at all the edge cases :-/
22:59:00 <nhnt11> I haven't actually encountered any edge cases using it though, interestingly
22:59:39 <clokep> Ship it?
22:59:40 <clokep> :P
22:59:55 <nhnt11> flo's review comment on it starts with "The approach in this patch seems fragile to me." :P
22:59:57 <nhnt11> So no :]
23:00:06 <aleth> haha
23:00:11 <aleth> oh dear
23:00:13 --> Hoony has joined #instantbird
23:00:31 <clokep> :-D
23:00:49 <clokep> aleth: So...we going ot land the patch adding seconds or back out completely or do something else?
23:01:40 <aleth> clokep: just a sec, I just wrote something in the last couple of minutes
23:03:01 <clokep> OKkkkkkkkkkk
23:03:44 <-- Tonnes has quit (Connection closed)
23:04:14 <-- Hoony has quit (Ping timeout: 121 seconds)
23:08:42 <aleth> clokep: So I think with that latest patch it should make everyone happy ;)
23:09:10 <clokep> aleth: Will look soon.
23:09:13 <clokep> About to jump in a car. :)
23:09:36 <aleth> Don't review and drive! ;)
23:11:41 <instantbot> aleth@instantbird.org changed the Resolution on bug 955312 from FIXED to ---.
23:11:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955312 enh, --, 1.6, aleth, REOP, Date information should be available for messages
23:13:14 <-- clokep has quit (Ping timeout: 121 seconds)
23:25:56 <-- hadi has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:28:23 * Fallen is now known as Fallen|away 
23:34:02 --> Hoony has joined #instantbird
23:37:44 --> clokep_work has joined #instantbird
23:37:44 * ChanServ sets mode +o clokep_work 
23:41:59 <clokep_work> aleth: Do we need to back things out before doing this or...?
23:42:10 <aleth> No
23:42:30 <aleth> If you're pushing things anyway, you could push the seconds fix too
23:42:47 <aleth> Otherwise we can probably live without seconds in tooltips for a day ;)
23:46:07 <clokep_work> aleth: I don't understand how that relates to the other one, I guess.
23:46:10 <clokep_work> But i Can't look at this ATM.
23:46:27 <aleth> It's technically completely separate.
23:46:37 <aleth> But there's no hurry :-)