#instantbird log on 11 27 2014

All times are UTC.

00:03:54 <-- Armada has quit (Connection closed)
00:08:38 <-- aleth has quit (Ping timeout: 121 seconds)
00:08:51 <-- AR45 has quit (A TLS packet with unexpected length was received.)
00:12:31 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
00:12:34 <-- bernard1 has quit (Quit: Leaving.)
00:14:36 * Fallen is now known as Fallen|away 
00:24:53 --> chrisccoulson has joined #instantbird
00:50:15 <-- Suiseiseki has quit (Ping timeout: 121 seconds)
00:59:55 <-- sherief has quit (Ping timeout: 121 seconds)
01:03:40 <-- DGMurdockIII has quit (Quit: Leaving)
01:05:43 --> Suiseiseki has joined #instantbird
01:09:44 --> Hoony has joined #instantbird
01:26:45 --> Widdershins has joined #instantbird
01:36:34 <-- arlolra has quit (Client exited)
01:39:15 --> mconley has joined #instantbird
02:18:39 <-- myk has quit (Ping timeout: 121 seconds)
02:54:13 --> mpmc has joined #instantbird
03:02:02 <-- EionRobb has quit (Connection closed)
03:02:52 --> EionRobb has joined #instantbird
03:03:40 * Tobin is now known as BinaryOutcast 
03:07:27 --> DGMurdockIII has joined #instantbird
03:26:51 <-- Patrick has quit (Connection closed)
03:26:53 --> Patrick has joined #instantbird
03:46:08 <instant-buildbot> build #2438 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2438
04:10:12 --> myk has joined #instantbird
04:15:19 <-- EionRobb has quit (Quit: Leaving.)
04:22:29 <-- myk has quit (Ping timeout: 121 seconds)
04:30:06 <instant-buildbot> build #1590 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1590
04:56:05 <instant-buildbot> build #1240 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1240
05:02:59 <-- mconley has quit (Connection closed)
05:46:08 --> mconley has joined #instantbird
05:48:33 --> momiga has joined #instantbird
05:49:00 <momiga> anyone in particular working on the thunderbird irc client
05:49:04 <momiga> looking to contribute
05:51:53 --> Bollebib has joined #instantbird
05:52:00 <momiga> oh i see, instantbird is a standalone client that chat support in thunderbird is based upon
05:52:08 <momiga> i was redirected here and didn't know the context
06:09:51 --> Defman has joined #instantbird
06:15:11 --> gerard-majax has joined #instantbird
06:25:55 <-- gerard-majax has quit (Ping timeout: 121 seconds)
06:30:04 <DGMurdockIII> momiga, flo-retina  works on thunderbird chat
06:30:34 <momiga> DGMurdockIII: thanks
06:31:46 <-- Widdershins has quit (Ping timeout: 121 seconds)
06:32:11 --> gerard-majax has joined #instantbird
06:37:53 <-- Bollebib has quit (Connection closed)
06:48:25 <-- gerard-majax has quit (Ping timeout: 121 seconds)
06:49:42 <instant-buildbot> build #136 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/136
06:55:12 <-- momiga has quit (Changing host)
06:55:12 --> momiga has joined #instantbird
06:55:26 <-- momiga has quit (Changing host)
06:55:26 --> momiga has joined #instantbird
07:00:06 <-- momiga has quit (Changing host)
07:00:06 --> momiga has joined #instantbird
07:00:13 <-- momiga has quit (Changing host)
07:00:13 --> momiga has joined #instantbird
07:01:40 --> gerard-majax has joined #instantbird
07:05:03 <momiga> i think i found a bug in chat/protocols/irc/ircCommands.jsm
07:06:05 <momiga> the handler for /mode does a check to make sure you're passing it your own username, and does so by checking against params[0]
07:06:18 <momiga> but params[0] is the mode string you're trying to set, not your username
07:06:28 <Defman> File a bug on bugtracker ;)
07:08:07 <momiga> even if i plan on fixing it myself? :)
07:08:16 <momiga> i suppose i could include the patch in the bug report
07:08:32 <momiga> i'm trying to figure out the patch contribution policy
07:09:22 <momiga> i'd like to pretty much just pull out the nickname check, because there are valid reasons to try to change the mode on another nick (like if you're a sysop)
07:09:37 <-- gerard-majax has quit (Ping timeout: 121 seconds)
07:10:07 <momiga> imo /mode should pretty much just send the whole argument string to the server as-is
07:32:37 --> Armada has joined #instantbird
07:47:16 --> aleth has joined #instantbird
07:47:16 * ChanServ sets mode +o aleth 
07:49:54 --> gerard-majax has joined #instantbird
07:51:33 <-- aleth has quit (Quit: :tiuQ)
07:51:36 --> aleth has joined #instantbird
07:51:36 * ChanServ sets mode +o aleth 
07:59:40 <-- aleth has quit (Ping timeout: 121 seconds)
07:59:43 <-- Patrick has quit (Connection closed)
07:59:48 --> Patrick has joined #instantbird
08:12:24 --> aleth has joined #instantbird
08:12:24 * ChanServ sets mode +o aleth 
08:45:01 <-- mconley has quit (Connection closed)
09:01:52 * Fallen|away is now known as Fallen 
09:05:26 <-- DGMurdockIII has quit (Connection closed)
09:17:37 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
09:19:07 <-- Defman has quit (Quit: My Double-Powered Atomic Reactor has gone to sleep. caaBOOOOM! ZZZzzz....)
09:27:05 <flo-retina> momiga: yes, file a bug even if you plan to fix it yourself (assign it to you in that case). 
09:27:15 <flo-retina> file it in the Chat Core :: IRC component
09:27:26 <flo-retina> I don't know much about the mode thing you are discussing, but clokep and aleth will.
09:27:36 <momiga> flo-retina: will do
09:28:26 <momiga> i was going to wait until i'd finished a patch before filing the bug, but i think i'll go ahead and file it
09:31:35 --> bernard has joined #instantbird
09:32:04 <momiga> i've actually only tested it in thunderbird, so i'm wondering if i should file it under thunderbird or instantbird
09:32:24 <flo-retina> neither
09:32:25 <momiga> i'm assuming if the problem is in thunderbird, it's in instantbird as well
09:32:27 <momiga> oh
09:32:30 <flo-retina> I told you where to file it
09:32:42 <momiga> i mean when it asks for the product name
09:33:03 <flo-retina> the product is "Chat Core"
09:33:29 <momiga> okay i found it
09:38:55 <momiga> it seems there was a bug report already about /mode that led to a large number of changes to the command to handle different cases
09:39:29 <momiga> https://bugzilla.mozilla.org/show_bug.cgi?id=954737
09:39:31 <instantbot> Bug 954737 nor, --, 1.2, clokep, RESO FIXED, /mode messages don't work on JS-IRC
09:45:13 <nhnt11> Hmm, the status "panel" is stuck
09:45:26 <nhnt11> http://puu.sh/d7oc6/a66f0b4ab0.png
09:45:42 <nhnt11> Hovering on a link again gets rid of it
09:45:57 <-- Hoony has quit (Client exited)
09:46:01 <aleth> flo mentioned that too. If you find STR please file a bug
09:46:06 <nhnt11> Yeah, sure thing
09:49:28 <flo-retina> aleth: isn't that a different thing?
09:49:47 <flo-retina> aleth: it already happened with the status bar that a link that had been clicked stayed there until another link was hovered
09:49:58 <flo-retina> the "... is typing" thing I saw this week, I had never seen in the status bar
09:50:03 <aleth> We won't know until we have STR
09:50:10 <nhnt11> flo-retina: I didn't click the link that got stuck, fwiw
09:50:12 <flo-retina> and the fix!
09:50:23 <nhnt11> Or did I..
09:50:33 <flo-retina> s/clicked/shown/ (I wasn't sure about that part actually :))
09:50:59 * nhnt11 goes to the library
09:51:20 --> BWMerlin has joined #instantbird
09:51:36 <nhnt11> oh, I should probably push that windows packaging fix for debug log tabs..
09:55:17 <nhnt11> ah, crap...
09:55:34 <nhnt11> I'd imported the patch to push earlier, and it didn't work because no ssh in the library
09:55:41 <nhnt11> And I forgot about it and pulled over it
09:56:01 <nhnt11> hmm
09:57:24 * nhnt11 discovered hg strip
09:58:56 <-- momiga has quit (Changing host)
09:58:56 --> momiga has joined #instantbird
10:06:33 <instantbot> New Chat Core - IRC bug 1105660 filed by momiga@ratfuck.co.
10:06:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105660 nor, --, ---, nobody, UNCO, /mode command fails in some cases
10:09:26 <momiga> i'll go ahead and assign the bug to myself, but knowing the history of this command i'm not sure if i'll be stepping on anyone's toes
10:12:16 <aleth> If you fix a bug, everyone will be happy ;)
10:14:27 <momiga> it appears i can't actually assign it to myself, probably because i'm a nobody :)
10:15:43 <aleth> You can attach a patch though and request review
10:19:50 <momiga> what if it involves changing the syntax of the command?
10:20:26 <momiga> there's a bit of ambiguity in the current syntax
10:21:37 <momiga> for instance, what is "/mode +v momiga"?
10:21:45 <flo-retina> you can still attach a patch and request review :)
10:22:08 <momiga> give momiga voice in the current channel, or give momiga the umode +v (which there isn't, but the command handler doesn't know that)
10:22:08 <flo-retina> from what I remember, that mode command is much more complicated than it looks at first, so it's possible the reviewers will show you edge cases that you haven't thought about
10:22:22 <-- nhnt11 has quit (Ping timeout: 121 seconds)
10:23:13 <momiga> though i guess it's not ambiguous if using /mode to change someone else's umode is disallowed, which it seems it is now
10:23:37 <aleth> momiga: just checking - have you seen the output of "/help mode" ?
10:24:39 <momiga> aleth: i have, but the command doesn't follow that syntax
10:24:59 <momiga> there are two forms, one that takes a channel and one that does not
10:25:11 <aleth> OK, make sure you add the STR to the bug then
10:26:14 <momiga> but if you do "/mode +v momiga" it will give me voice in the current channel, which is not what the syntax suggests
10:26:28 <momiga> i'm not sure what that is :)
10:26:38 <momiga> i'm kind of new to this
10:26:46 * BinaryOutcast is now known as Tobin 
10:27:08 <momiga> sorry wait, i might be wrong about that
10:27:14 <aleth> STR = steps to reproduce = "From the tab for channel X, I typed Z and Y happened"
10:27:54 <momiga> i was thinking it gives +v in the current channel, because it was giving me this output: "Mode +v for momiga set by momiga."
10:28:03 <momiga> but it seems that's setting the user mode
10:28:09 <momiga> aleth: sure, i'll add that
10:28:29 <aleth> I highly doubt you can give yourself voice here ;)
10:28:40 <momiga> no, it was in another channel ;)
10:28:57 <aleth> OK
10:29:17 <Tobin> isn't what a mode does dependent on if the ircd will allow it
10:29:28 <Tobin> the mode is incidental in a cmd
10:29:31 <aleth> Sure, modes are server dependent
10:30:10 * Tobin gives aleth mode +beer
10:30:35 <Tobin> what an invalid statement
10:30:46 <Tobin> sorry didn't mean to disrupt the flow of the channel
10:31:29 <momiga> oh no wait, i was right
10:31:34 <momiga> "/mode -o momiga" deops me
10:31:59 <Tobin> please see the channel and user modes for the particular ircd you use
10:32:03 <momiga> which is "MODE #channel -o momiga" in the message to the server
10:32:05 <Tobin> though MOST are the same
10:32:17 <aleth> momiga: https://www.alien.net.au/irc/usermodes.html
10:32:47 <momiga> yes yes, i know all this :) i'm saying there's ambiguity in how the client interprets the /mode command
10:33:01 <Tobin> i don't think so
10:33:12 <Tobin> depends on the target
10:33:28 <Tobin> it is pretty standard how it is done in pretty well all clients
10:33:32 <momiga> it interprets "/mode <modestr> <nick>" as a channel mode with an argument
10:34:56 <Tobin> nearly all user modes are dependent on a specific channel
10:34:58 <aleth> momiga, Tobin: : It's quite possible there's a bug in the code.
10:35:00 <momiga> though i think you're right, since it appears using /mode to change the umode of someone other than yourself is not possible
10:35:31 <aleth> That's why precise STR are important.
10:35:49 <aleth> momiga: yes
10:35:50 <momiga> well there is at least one bug: let isOwnNick = account.normalize(params[0]) == account.normalize(account._nickname);
10:36:09 <momiga> params[0] might be a modestring, in which case of course it doesn't equal the nickname
10:36:55 <momiga> though i was trying to verify if that was causing the issue or not
10:37:06 <aleth> I think this'll be easier to discuss once your patch is ready
10:37:25 <Tobin> wouldnt that only be called if there was no target.. assuming you want to set the mode on yourself instead?
10:37:31 <momiga> sure, i'll go ahead and do that. and also put up STR
10:38:10 <Tobin> sorry for not being very helpful.. trying to actially remember the spec :P
10:38:57 <momiga> well the spec is "MODE <target> [modestring] [params]"
10:39:16 <momiga> i think target might be optional, though i don't think so. "/quote MODE" to test
10:39:29 <momiga> appears not
10:39:37 <momiga> target can be a nick or a channel
10:39:43 <Tobin> yeah
10:40:00 <momiga> but then what is "/mode +m"
10:40:06 <Tobin> now the client needs to send your username as the target if you don't specify one
10:40:08 <momiga> in terms of the client, not in terms of the irc spec
10:40:28 <Tobin> and i dont think any of them specify a usermode +m
10:40:40 <Tobin> so it would have to be the channel as the target cause +m IS a channel mode
10:40:46 <Tobin> if i recall MOST ircds
10:40:50 <momiga> right, but how does the client know?
10:40:53 <-- flo-retina has quit (Ping timeout: 121 seconds)
10:41:03 <Tobin> if you don't specify a target it would SEEM it uses you as a target
10:41:04 <momiga> it needs to build a command and infer <target> from the context
10:41:08 <Tobin> via that isOwnNick
10:42:14 <Tobin> and no it doesn't need to infer a target from context.. every client i have used assumes if you don't specify a target .. then YOU are the intended target
10:42:52 <momiga> yeah, that's what makes sense, i'm just trying to see if that's what's happening here
10:42:59 <Tobin> the ircd would be responsible for figuring it if it is valid or not..
10:43:04 <momiga> because actually when i try to do "/mode +x" it doesn't let me send the command
10:43:10 <momiga> "/mode" either
10:43:27 <Tobin> well /mode isn't enough info
10:43:31 <momiga> enter does nothing and the command remains in the textbox
10:43:41 <momiga> i think /mode is supposed to retrieve your own user mode
10:43:45 <Tobin> no
10:44:05 <momiga> that's what the code in ircCommands.jsm is trying to do
10:44:20 <momiga> if (!hasParams) params = [aConv.nick];
10:44:57 <momiga> though thunderbird isn't letting me do it
10:46:03 <Tobin> i wonder what libpurple does
10:46:35 <Tobin> or chatzilla
10:47:03 <momiga> i just know what mirc does (if memory serves), which is force you to always specify the target and then just sends the whole string verbatim to the server
10:47:08 <aleth> It doesn't really matter what other clients do
10:47:15 <Tobin> true
10:47:28 <aleth> momiga is right that the question is whether the IB command works as intended
10:48:13 <Tobin> my guess is it likely does do what it is programmed to do.. just not completely what one may expect..
10:48:49 <Tobin> may be incomplete as to every case it could be used
10:50:15 <Tobin> but momiga if you specify a target either a user or a channel it does work properly?
10:51:19 <momiga> well, if i do "/mode +x  momiga", it sends "MODE #instantbird +x momiga" to the server
10:51:22 <momiga> which isn't proper
10:51:28 <momiga> according to /help it should work: mode (+|-)<new mode> [<nick>]: Set or unset a user's mode.
10:51:56 <Tobin> momiga: it has to send a scope to the server to know what channel the user's mode should be cahnged
10:52:05 <momiga> right, but x is a usermode
10:52:16 <momiga> the scope/target should be momiga
10:52:23 <Tobin> ah
10:52:24 <momiga> MODE momiga +x
10:52:34 <Tobin> but +x should ONLY be set by a server
10:52:38 <Tobin> if i recall correctly
10:52:38 <momiga> if i do "/quote MODE momiga +x" it has the right effect
10:53:03 <Tobin> try doing that from the server tab
10:53:04 <momiga> i'm not sure about other servers, but for irc.mozilla.org +x means "hide the hostname"
10:53:23 <momiga> if i do it from the server tab, it does "MODE levin.mozilla.org +x momiga"
10:53:31 <Tobin> right
10:53:37 <momiga> and says levin.mozilla.org is not online, interpretting it as a nick
10:53:37 <Tobin> incomplete implimentation then
10:54:16 <Tobin> that would seem to assume that you want to set a usermode to a user on a channel.. even if it is your self.. a few usermodes aren't channel dependent
10:54:21 <momiga> so what's going on is "/mode <modestr> <nick>" is setting a channel mode when /help says it sets a user mode
10:55:02 <momiga> i'm trying to think how to fix this so all the expected behaviors work
10:55:50 <Tobin> no it is setting a usermode in the scope of a specific channel.. which normally should be the right case.. but this is one of those exceptions.. but because modes are arbitary there is no real way to anticpate this.. though a good workaround would be to detect a server tab and omit a channel scope from the raw cmd sent to the server
10:56:19 <Tobin> the server tab should assume all cmds are not specified to a channel
10:56:42 <Tobin> momiga: the fix is obvious.. if in server tab.. don't send a possible channel name
10:57:11 <momiga> but what if i want to set my umode without being in the server window?
10:57:31 <Tobin> if it is one of those special cases.. you are out of luck
10:57:33 <momiga> i think pidgin actually provides /mode for channels and /umode for user modes
10:57:42 <Tobin> otherwise it would break more commonly usecases of the mode cmd
10:57:50 <momiga> we could have /mode infer the current channel, and /umode infer the user's nick
10:57:51 <Tobin> now that is possible
10:57:54 <Tobin> and a nice litle solution
10:58:06 <Tobin> i like it
10:58:13 <momiga> there is a /umode already, but it sends a raw MODE command
10:58:28 <momiga> though somehow doesn't seem to work either
10:58:45 <Tobin> but server tab mode cmds should always assume you want to set it on your self and not ever have a specified channel name sent in the raw cmd
10:59:11 <Tobin> unless a target is specified :P
10:59:14 <Tobin> of course
10:59:52 <Tobin> but that is how i think it should be and how i would do it
11:00:14 <momiga> that sounds right, though i'm not sure if it's possible to detect a server tab in thunderbird
11:00:29 <Tobin> well thunderbird is immateral
11:00:37 <Tobin> chat core needs this functionality
11:00:54 <Tobin> that would cover thunderbird and instantbird (assuming ib uses the chat core version of irc)
11:01:35 <-- aleth has quit (Ping timeout: 121 seconds)
11:02:08 <momiga> just to confirm, anyone using ib able to reproduce the /mode problems?
11:02:17 <momiga> since i'm just using thunderbird :)
11:02:32 <Tobin> the bug would be in chat core not thunderbird
11:02:43 <Tobin> so if you did file a bug you would want to have it filed there
11:03:06 <Tobin> but if you have filed a bug can you give me the number so i can cc my self and i can test when i get time
11:03:55 <momiga> sure https://bugzilla.mozilla.org/show_bug.cgi?id=1105660
11:03:57 <instantbot> Bug 1105660 nor, --, ---, nobody, UNCO, /mode command fails in some cases
11:04:16 <Tobin> cc'd
11:04:39 --> hadi has joined #instantbird
11:04:45 --> flo-retina has joined #instantbird
11:04:45 * ChanServ sets mode +qo flo-retina flo-retina 
11:06:59 <momiga> alright, let me go ahead and put together a patch :)
11:07:47 <momiga> the most unfortunate thing is that channels can begin with + in addition to # and &
11:08:36 <momiga> so detecting if the arguments start with a modestring by looking for +/- is complicated because it can be a channel even if there's a + :)
11:09:49 <momiga> the perils of trying to provide users with an easy context-sensitive interface
11:14:05 <momiga> is it okay if i submit more than one independent patch?
11:14:29 <momiga> i'd like to make a change to umode to make it work right, but keep it in a separate patch
11:15:38 <momiga> although it's not really part of the bug report. maybe i'll file it as an enhancement after
11:23:47 <-- momiga has quit (Changing host)
11:23:47 --> momiga has joined #instantbird
11:33:50 --> Hoony has joined #instantbird
11:34:10 <-- Hoony has quit (Client exited)
11:34:16 --> Hoony has joined #instantbird
11:41:44 --> nhnt11 has joined #instantbird
11:42:32 <-- Hoony has quit (Client exited)
11:43:12 --> aleth has joined #instantbird
11:43:13 * ChanServ sets mode +o aleth 
11:47:32 <flo-retina> momiga: sure, several smaller patches are easier to review :)
11:50:10 <-- Armada has quit (Ping timeout: 121 seconds)
11:51:16 --> Armada has joined #instantbird
11:51:19 <aleth> There's quite a bit of confusion in the earlier conversation. The code here is shared between Thunderbird and Instandbird. A "server tab" is a private conversation with a server, not a channel. /mode from there will never "guess" a channel name.
11:52:13 <momiga> it shouldn't, though it appears it does
11:52:43 <aleth> I doubt it
11:52:56 <aleth> Anyway, try writing a small discrete patch for a single issue, then go from there.
11:53:35 <Tobin> aleth: i was gonna test it as well in realworld when i get time but i am not setup for chatcore/instantbird testing atm
11:54:59 <Tobin> aleth: aren't technically all communications either between a specific user or a channel or the server done with PRIVMSG
11:55:21 <Tobin> as far as a window or tab is conserned
11:55:22 <aleth> Tobin: that's actual messages
11:59:11 * Fallen is now known as Fallen|away 
12:06:01 <-- nhnt11 has quit (Connection closed)
12:07:44 --> nhnt11 has joined #instantbird
12:09:49 <-- Tonnes has quit (Quit: ChatZilla 0.9.91 [Firefox 33.1.1/20141113143407])
12:18:58 --> mikk_s has joined #instantbird
12:29:06 <-- BWMerlin has quit (Client exited)
12:32:58 --> sherief has joined #instantbird
12:35:44 <-- Armada has quit (Ping timeout: 121 seconds)
12:35:52 <momiga> i think i'm done with the changes
12:36:08 <momiga> i've changed the semantics of /mode somewhat
12:37:20 <momiga> i don't think /mode should ever infer the current user. that complicates it too much and makes it unintuitive. instead /umode should be used for user mode changes for the current user
12:37:35 <momiga> that's also in-line with what other irc clients do i believe
12:39:19 <momiga> /mode should basically only ever infer the current channel, or otherwise use the user-supplied target, which is the first argument assuming it's not a modestring
12:40:01 <aleth> You're better off explaining this in the bug, so there is a record there of your ideas.
12:40:26 <momiga> i'll do that, i'm just seeing if anyone in here has an immediate opinion
12:40:58 <nhnt11> aleth: "Why did you move this?" Yeah, probably not the best idea I guess
12:41:58 <aleth> My immediate opinion is "I'm not sure there's a good reason not to infer the current user, and I suspect the 'unintuitive' behaviour actually comes from something else"
12:42:50 <aleth> It seems to me the unintuitiveness comes from the system messages being sent to the user in response being unclear/missing
12:43:35 <momiga> to me it's unintuitive, because "/mode +o momiga" affects the channel mode but "/mode +m" affects the user mode
12:44:14 <aleth> momiga: Then put that particular example in the bug
12:49:10 <nhnt11> aleth: Btw, the small advantage of doing the cache check inside indexIMConversation is that all the lastModifiedTime stuff happens in one place.
12:49:21 <nhnt11> I think this line should definitely be moved inside indexIMConversation: http://dxr.mozilla.org/comm-central/source/mail/components/im/modules/index_im.js#366
12:49:41 <nhnt11> So either we need to stat the file twice, or pass the lastModifiedTime around somehow (on the job object?)
12:50:30 <aleth> nhnt11: We have to be careful about the distinction between "last time the file was indexed" and "last time the log file was written to"
12:50:38 <nhnt11> Yes.
12:51:10 <nhnt11> The line I just linked adds the file to the list of already-indexed files prematurely (if I understand correctly)
12:51:48 <nhnt11> in some situations at least...
12:51:52 <nhnt11> let me check something really quick
12:52:08 <aleth> Yes, it's a bit confusing... It may have been correct before more things went async
12:52:32 <nhnt11> Indeed, GlodaIndexer.indexJob simply adds the job to the queue: http://dxr.mozilla.org/comm-central/source/mailnews/db/gloda/modules/indexer.js?from=indexer.js#1308
12:52:49 <nhnt11> I think I had a really bad understanding of what was going on when I made the gloda changes the first time...
12:52:50 <aleth> I'm a bit concerned about using the conv object as the "cache" too. Certainly a misnomer.
12:53:23 <nhnt11> Right, that's a bit of bad naming that's been around before async logs...
12:53:34 <aleth> Yes, let's fix it ;)
12:53:36 <nhnt11> Yeah
12:54:11 <nhnt11> knownFiles really wants to be a Map of Maps ;)
12:54:42 --> clokep_work has joined #instantbird
12:54:42 * ChanServ sets mode +o clokep_work 
12:54:57 <nhnt11> I think it's easier to just use Objects though, free JSON.stringify.
12:55:19 <aleth> Yes, you can't stringify maps, sadly.
12:56:44 <clokep_work> momiga: The mode command is confusing and crappy.
12:57:01 <clokep_work> But I'll need to read the bug before comment more. ;)
12:57:14 <momiga> yeah the original rfc authors made a pretty bad choice overloading it so badly
12:57:16 <-- mikk_s has quit (Connection closed)
12:57:21 --> mikk_s has joined #instantbird
12:57:29 <aleth> Yeah, it's pretty much impossible to get right.
12:57:49 <momiga> it checks user modes, checks channel modes, sets user modes, sets channel mode, and the argument passing is awkward
12:57:51 <clokep_work> momiga: You know there's also a /umode command, right?
12:57:56 <-- mikk_s has quit (Connection closed)
12:58:21 <momiga> "MODE +vvvoool userA userB userC userA userB userC 10"  aaaaa
12:58:25 <aleth> nhnt11: Let's not use logconversation.filename to store the lastmodifiedtime unless there is a good reason to store it there. Can't we add a lastmodifiedtime property on the job, or the gloda conv, or ...
12:59:22 <aleth> Apart from everything else, it will almost certainly break when your followup patches land
12:59:24 --> mikk_s has joined #instantbird
12:59:27 <momiga> yeah, the /umode command is usually provided because it lets you get context-sensitivity at the cost of an extra command
12:59:40 <nhnt11> aleth: What's logconversation.filename? I already suggested storing it on the job..
12:59:45 <momiga> you actually can't have both context sensitive mode setting and one command i believe
13:00:00 <aleth> nhnt11: ok, fine. logconv.filename is where it's currently stored
13:00:00 <momiga> unless the client understands the difference between server modes and user modes just by the mode string
13:00:11 <Tobin> which it can
13:00:28 <momiga> it can but that increases the complexity
13:00:28 <Tobin> that information is provided by the server actually
13:00:37 <momiga> it has to keep a table of all of those and whatnot
13:00:56 <momiga> and actually i'm not sure if the characters used for channel modes and user modes are mutally exclusive
13:01:05 <nhnt11> aleth: Are you talking about setting cache[fileName]?
13:01:09 <nhnt11> cache isn't a logconversation
13:01:10 <aleth> nhnt11: yes
13:01:28 <nhnt11> _knownFiles really needs comments..
13:01:48 <aleth> nhnt11: well, the parameter passed seems to be the result of log.getConversation
13:01:51 <nhnt11> convObj here does /not/ refer to a log conversation or any log-related interface
13:02:17 <aleth> oh? maybe I'm confused then
13:02:29 <nhnt11> aleth: Can you link me to the line you're talking about specifically?
13:02:31 <nhnt11> I think you are.
13:02:52 <clokep_work> momiga: They're not usually mutually exclusive.
13:02:58 <nhnt11> aleth: knownFiles is a map of protoname -> accountObj
13:03:09 <momiga> ah, well there you go
13:03:13 <nhnt11> protoObj*
13:03:18 <momiga> imo best to just have a /mode and a /umode
13:03:28 <nhnt11> protoObj is a map of account name (id?) -> accountObj
13:03:35 <momiga> and make /umode only let you change your own user mode
13:03:39 <nhnt11> accountObj is a map of conv name -> convObj
13:03:52 <nhnt11> convObj is a map of fileName -> lastModifiedTime
13:04:06 <nhnt11> basically a tree where the leaves are last modified times
13:04:15 <aleth> nhnt11: right, sorry.
13:04:53 <clokep_work> Tobin: Please stop saying things like "the fix is obvious". I haven't even seen the problem clearly stated yet.
13:05:49 <aleth> it's this._knownConversations[convId].conObj, which is accountObj[convName]... super confusing
13:05:59 <nhnt11> yeah
13:06:06 <Tobin> i don't recall specifically saying that.. however if you misunderstood i applogize for any apperent disruption
13:06:27 <momiga> i've posted a patch
13:06:38 <momiga> hopefully i did it right, it's just the output of hg diff
13:07:06 <clokep_work> Tobin: http://log.bezut.info/instantbird/today/#m242 ;)
13:07:18 <clokep_work> momiga: Still catching up on logs, I'll look in a moment.
13:07:56 <nhnt11> momiga: What's the bug number?
13:08:05 <momiga> https://bugzilla.mozilla.org/show_bug.cgi?id=1105660
13:08:07 <instantbot> Bug 1105660 nor, --, ---, nobody, UNCO, /mode command fails in some cases
13:08:14 <nhnt11> thanks
13:08:44 <instantbot> aleth@instantbird.org changed the Resolution on bug 1092701 from --- to FIXED.
13:08:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1092701 nor, --, ---, nobody, RESO FIXED, Cannot connect to Google Talk
13:09:00 <nhnt11> ^ :D
13:09:34 <clokep_work> momiga: So I want to ensure you understand the syntax before I even read your patch...
13:10:10 <nhnt11> Is it too much to ask that we trigger new nightlies? :]
13:10:17 <nhnt11> hmm, osx failed last night..
13:10:49 * aleth would like a response to his questions in bug 1105660 before we completely change everything ;)
13:10:51 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105660 nor, --, ---, nobody, UNCO, /mode command fails in some cases
13:11:10 <momiga> clokep_work: you mean the changes to the syntax of the /mode command? or are you talking about the expected coding style?
13:11:34 <clokep_work> momiga: I mean what the *current* syntax is.
13:11:49 <clokep_work> But I'm finding it hard to follow this bug.
13:12:09 <momiga> aleth: i just posted one response, i'll look at the other in a second
13:12:26 <momiga> i think the big problem here is that i'm using thunderbird and i don't know if anyone else in here is
13:12:32 <aleth> momiga: thanks. We all have to get on the same page here, too many things being addressed at once
13:12:33 <clokep_work> momiga: That doesn't matter.
13:12:37 <clokep_work> But what VERSION are you using?
13:12:59 <momiga> 31.2.0
13:13:13 <aleth> Ah, as a developer you should probably use the nightly :)
13:13:30 <aleth> Or the code won't match what you're seeing.
13:13:55 <aleth> (at least not necessarily)
13:13:59 <clokep_work> aleth: Not entirely true, but testing with a nightly is a good idea. :)
13:14:01 <momiga> it might matter, depending, because i think half of the bug report turned out to be something thunderbird specific:
13:14:13 <clokep_work> momiga: That code all looks pretty old, you shouldbe OK.
13:14:18 <clokep_work> How so?
13:14:20 <momiga> if there's an exception thrown in the handler, there's some strange behavior
13:14:52 <aleth> If there's an exception thrown in the handler, that's likely a bug ;)
13:14:54 <momiga> pressing enter causes the command to remain in the chat box, and the command does not get sent
13:15:08 <flo-retina> do we know why the mac build failed?
13:15:15 * flo-retina was hoping to connect to gtalk today ;)
13:15:49 --> Armada has joined #instantbird
13:15:51 <clokep_work> flo-retina: For some reason I thought it was intermittent.
13:15:55 <clokep_work> But I'm clearly not awake yet.
13:16:01 <-- bernard has quit (Quit: Leaving.)
13:16:04 <flo-retina> no turkey yet?
13:16:10 <momiga> the exception came from indexing into an undefined string i think, though i'm not sure. all i know is the exception caused the problem with "/mode" and "/mode +x" where the command wasn't getting sent and the chatbox wasn't getting cleared
13:16:23 <flo-retina> well, if you think it's intermittent you can retrigger; but it's not a failure message I saw before
13:16:34 <clokep_work> No turkey yet. :-D
13:17:01 <clokep_work> nhnt11: Would it be reasonable to add a "Clear" to debug logs?
13:17:11 <flo-retina> yes!
13:17:28 <nhnt11> clokep_work: You just volunteered :P
13:17:29 * nhnt11 hides
13:17:47 <aleth> flo-retina: clokep_work: It's not intermittent, TB is busted too
13:18:09 <aleth> bah, what's this ^^ tab complete failure doing in my IB
13:18:21 <flo-retina> is there a reason why the debug log tab has a "refresh" button?
13:18:34 <nhnt11> flo-retina: It doesn't automatically refresh when there are new messages
13:18:40 <flo-retina> how difficult would it be to add a listener?
13:18:57 <nhnt11> I don't know.
13:19:14 <clokep_work> momiga: So /mode +x should add +x to your hostname, /mode +x foo should add +x to foo in the current channel, /mode #bar +x foo should add +x for foo in the #bar channel.
13:19:22 --> bernard has joined #instantbird
13:19:26 <clokep_work> aleth: ^
13:19:36 <clokep_work> That's what the *intent* is, but there might be bugs in the code.
13:19:48 <flo-retina> do we have / can we add a /debug command to open the debug log for the account of the current tab?
13:19:58 <clokep_work> Now typing /mode +x makes it disappear for me wtih no message sent AND no command sent over the network.
13:20:01 <clokep_work> Which is clearly wrong.
13:20:02 <nhnt11> flo-retina: it exists :)
13:20:38 <flo-retina> "/help debug " -> "No 'debug ' command."
13:20:49 <flo-retina> "/help debug" -> "debugCommand.help"
13:20:55 <flo-retina> is this something already tracked?
13:20:58 <nhnt11> Oh no...
13:21:05 <nhnt11> No it's not
13:21:06 <momiga> clokep_work: that seems like such odd intent, because i feel like if "/mode +o foo" affects the current channel, then so should something like "/mode +m", which would normally moderate the channel, but instead tries to add it to your user mode
13:21:25 <nhnt11> I thought that was only a typo, did I miss the String somehow too? :S
13:21:35 <nhnt11> Filing a bug...
13:21:36 <nhnt11> flo-retina: The command works though
13:21:36 <clokep_work> momiga: As you said the command is somehwat ambiguous, you *have* to give a channel name in that case.
13:21:37 <momiga> in other words, inside the handler, "+o foo" would infer the channel as the target, and "+m" would infer the current user as the target
13:21:51 <clokep_work> momiga: How would it infer?
13:22:24 <clokep_work> momiga: Btw making the command send the raw string to the server is not an option I like.
13:22:46 <clokep_work> Our goal is to make something easy to use, not something that just copies other clients.
13:22:59 <flo-retina> nhnt11: how would you feel about changing the tab title from "Debug log for <account name>" to "<account name> debug log" so that small tabs display the useful part (the account name)?
13:23:15 <clokep_work> momiga: But I agree the mode command isn't the easiest thing to use. I believe we added support for changing your own mode to /mode because of complaints though.
13:23:16 <nhnt11> I don't mind.
13:23:17 <flo-retina> maybe that + a more distinctive favicon so that it's obvious it's a debug tab
13:23:33 <momiga> clokep_work: i'm not sure what you mean. it would know it needs to infer because the target isn't named. it would know what to infer based on the nature of the arguments (channel if arg is given, user if only mode is given)
13:24:00 <clokep_work> momiga: I'm confused at whether you're talking about what it *currently* does or a proposal for what you'd like to see it do.
13:24:16 <momiga> clokep_work: currently :)
13:24:23 <clokep_work> OK, that's not how I read that, one second.
13:24:25 <flo-retina> nhnt11: would https://bugzilla.mozilla.org/extensions/BMO/web/images/favicon.ico be a good icon?
13:24:25 <momiga> my proposal is to make it never infer the user
13:24:31 <-- Armada has quit (Quit: Leaving)
13:24:33 <momiga> only ever infer the current window
13:25:01 * flo-retina wonders if there's a retina version of that somewhere
13:25:05 <instantbot> New Instantbird - Localization bug 1105712 filed by nhnt11@gmail.com.
13:25:06 --> Armada has joined #instantbird
13:25:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105712 nor, --, ---, nobody, NEW, Help text does not exist for debug command
13:25:39 * aleth wonders if there's a nice (de)bug icon somewhere in FX/devtools
13:25:48 <flo-retina> nhnt11: btw, I'm mentioning plenty of things that could be improved... I forgot to say that having the debug logs in a tab is awesome! :-). Thanks for finishing that up! :)
13:26:00 <momiga> imo "/mode +m" and "/mode +o momiga" should both operate on the current window (channel)
13:26:03 <aleth> lol, it's the usual thanks for good work - more work!
13:26:17 <flo-retina> :-]
13:26:37 <flo-retina> aleth: I wouldn't be against working on some of the improvements myself during the end-of-year break
13:26:50 <flo-retina> would be cool for me to start coding ib stuff again at some point
13:26:50 <nhnt11> flo-retina, aleth: I'll file a new bug for "Debug log tab UI improvements", does that sound ok?
13:27:02 <nhnt11> we can collect stuff there...
13:27:06 <momiga> that makes sense to me because i know +m and +o are both channel modes, and if i just opped someone without naming the channel, i should be able to mod the channel without naming the channel
13:27:11 <flo-retina> nhnt11: as a meta bug to track future possible enhancements? sure
13:27:19 <nhnt11> yeah
13:27:21 <flo-retina> you can also just make all these new bugs block the bug where the feature landed
13:27:26 <flo-retina> either way is fine
13:27:43 <nhnt11> ok
13:28:01 <clokep_work> momiga: OK.
13:29:19 <clokep_work> Meh the umode command seems brokent oo.
13:29:23 <instantbot> New Instantbird - Conversation bug 1105716 filed by nhnt11@gmail.com.
13:29:24 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105716 nor, --, ---, nobody, NEW, Debug log tab needs a favicon
13:29:32 <momiga> clokep_work: yeah, i was going to do that in a separate patch :)
13:29:46 <momiga> it would be much easier
13:30:06 <clokep_work> That's fine.
13:30:24 <momiga> basically simpleCommand(aConv, "MODE", [aConv.nick, aMsg])
13:30:24 <instantbot> New Instantbird - Conversation bug 1105717 filed by nhnt11@gmail.com.
13:30:25 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105717 nor, --, ---, nobody, NEW, Debug log tab should listen for new debug messages and show them automatically.
13:30:27 <momiga> and that's the entire change
13:31:34 <instantbot> New Instantbird - Conversation bug 1105718 filed by nhnt11@gmail.com.
13:31:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105718 nor, --, ---, nobody, NEW, Add a way to clear debug logs
13:31:39 <aleth> momiga: Can you file separate bugs for bug fixes to mode, bug fixes to umode, and a bug for "changing the syntax of mode to what I prefer"
13:31:46 <aleth> thanks
13:31:57 <nhnt11> Hmm, that probably isn't a Conversation bug..
13:32:39 <flo-retina> nhnt11: well, close enough. There's also "Chat Core :: Debugging", but it's not really a chat core bug ;).
13:32:49 <flo-retina> hmm, adding support for debug listeners may be a chat core bug
13:33:09 <momiga> aleth: sure
13:33:47 <-- mikk_s has quit (Connection closed)
13:34:42 --> mikk_s has joined #instantbird
13:35:01 <momiga> maybe i should also file a bug about tab completion, because i can't seem to tab complete your name since you're invisible on the user list ;)
13:35:25 <nhnt11> :S
13:35:34 <nhnt11> That sounds like a different bug altogether ^
13:35:40 <clokep_work> momiga: Tab completion in Thunderbird kind of sucks, it's not shared code.
13:35:50 <clokep_work> But someone not being on the userlist is a bug, yes.
13:35:53 * nhnt11 didn't know that^
13:35:57 <momiga> haha i'm just kidding
13:36:00 <clokep_work> Something that was likely fixed recently.
13:36:15 <momiga> but it is kind of annoying, kind of wish thunderbird would know how to handle users that recently spoke but aren't on the list
13:36:26 <momiga> i think it's actually a user mode that causes your name to disappear from the list
13:36:33 <clokep_work> Bug 1078223 and Bug 1080838
13:36:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1078223 nor, --, 1.6, aleth, RESO FIXED, Unhandled IRC messages: 598 and 599
13:36:36 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1080838 nor, --, 1.6, aleth, RESO FIXED, Participants not removed on leaving a channel
13:36:45 <momiga> so, feature not bug :)
13:36:50 <clokep_work> momiga: I'm pretty sure that mode isn't supported on moxnet.
13:36:51 <clokep_work> moznet
13:37:02 <nhnt11> momiga: a.leth is certainly not "invisible"
13:37:19 <momiga> oh, then maybe it is a bug
13:37:24 <momiga> he's not on my user list
13:37:25 <clokep_work> Yeah, it's a bug in the IRC implementation which we fixed recently, the fix is in the next ESR.
13:37:26 <nhnt11> yeah..
13:37:43 <momiga> hrm maybe i'll go back to pidgin
13:37:54 <nhnt11> momiga: Or try Instantbird? ;)
13:38:05 <aleth> Tab completion is better there ;)
13:38:11 <momiga> nhnt11: haha actually i might
13:38:22 <momiga> i can't seem to tab complete your name either :P
13:38:22 --> Tonnes has joined #instantbird
13:39:10 <momiga> okay let me make those bug reports, then i have to go to bed
13:40:12 <instant-buildbot> build #2439 of macosx-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2439
13:41:55 <-- nhnt11 has quit (Ping timeout: 121 seconds)
13:44:06 <momiga> does hg have local commits or some other way to make changes without having my patches get all mixed together
13:44:11 <-- bernard has quit (Quit: Leaving.)
13:44:30 <clokep_work> momiga: Bookmarks or mercurial queues (mq)
13:44:36 <clokep_work> Or...shelve, I think?
13:44:44 <momiga> clokep_work: thanks i'll look into it
13:47:43 <clokep_work> momiga: No problem. :) Thanks for your interest!
13:47:59 <clokep_work> momiga: Btw we do have hopes to make tab complete in TB much better...we just need to port some code...
13:49:07 <clokep_work> (Or abstract some code, actually.)
13:51:31 <aleth> Yes, it just needs me to have an uninterrupted day or two for it
14:02:21 --> nhnt11 has joined #instantbird
14:02:43 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:06:42 --> bernard has joined #instantbird
14:07:05 <instantbot> New Chat Core - IRC bug 1105728 filed by momiga@ratfuck.co.
14:07:06 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105728 nor, --, ---, nobody, UNCO, IRC /umode doesn't set user mode
14:08:43 <momiga> who should i put as a requestee to review my patches
14:09:03 <nhnt11> aleth: So for the next gloda patch, I need to a) check if a file is already indexed /before/ scheduling a job, and b) make the convObj stuff more understandable. Sounds right?
14:09:09 * Fallen|away is now known as Fallen 
14:10:17 <aleth> nhnt11: sounds good
14:10:33 <aleth> momiga: clokep or me
14:10:43 <nhnt11> I'll probably work on it later at night though, fyi
14:10:53 <aleth> np
14:11:26 <aleth> btw, probably a good idea to keep the split logs patch at the back of your mind when you do the changes, just to make sure you don't have to redo it for that
14:11:38 <nhnt11> Yeah
14:12:25 <clokep_work> momiga: Me.
14:15:09 <momiga> thanks
14:17:16 * clokep_work has to step away for a few.
14:26:57 <momiga> i posted some replies in the comments for the first bug
14:30:48 --> mconley has joined #instantbird
14:31:50 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:44:14 <momiga> alright, i have to go now, i'll finish up the remaining changes later tonight
14:44:42 <momiga> nice meeting all of you, i'll be around!
14:44:56 <momiga> at least until life takes me away again :)
14:46:02 <clokep_work> Thanks for the patches. :) I'll respond soon.
14:48:22 <-- nhnt11 has quit (Ping timeout: 121 seconds)
15:04:33 <-- clokep_work has quit (Ping timeout: 121 seconds)
15:07:01 --> mpmc has joined #instantbird
15:24:11 <-- aleth has quit (Quit: :tiuQ)
15:32:05 --> clokep_work has joined #instantbird
15:32:05 * ChanServ sets mode +o clokep_work 
15:32:48 <-- hadi has quit (Connection closed)
15:43:08 --> flo-retina has joined #instantbird
15:43:09 * ChanServ sets mode +qo flo-retina flo-retina 
15:46:15 --> aleth has joined #instantbird
15:46:16 * ChanServ sets mode +o aleth 
15:57:51 --> Hoony has joined #instantbird
16:08:59 --> Defman has joined #instantbird
16:12:00 <-- clokep_work has quit (Ping timeout: 121 seconds)
16:26:40 <-- bernard has quit (Quit: Leaving.)
16:32:04 <-- gerard-majax has quit (Ping timeout: 121 seconds)
16:33:09 <instantbot> New Chat Core - IRC bug 1105797 filed by aleth@instantbird.org.
16:33:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105797 nor, --, ---, nobody, NEW, Unhandled IRC message 501: unknown mode char
16:36:10 <instantbot> New Instantbird - Other bug 1105798 filed by aleth@instantbird.org.
16:36:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105798 nor, --, ---, nobody, NEW, Copying from a debug log tab loses line breaks
16:47:07 --> clokep_work has joined #instantbird
16:47:07 * ChanServ sets mode +o clokep_work 
16:51:46 <clokep_work> aleth: Do you find the wrapping weird for debug logs too?
16:51:51 <clokep_work> I have huge horizontal scrollbars...
16:51:53 <clokep_work> nhnt11 ^
16:52:11 <aleth> clokep_work: I don't see the scrollbars, but I suspect it's the same underlying bug
16:52:28 <clokep_work> Maybe my window is smaller. :)
16:52:35 <aleth>  \n vs \r\n is my guess
16:52:54 <clokep_work> Hmm....no, not what I'm talking about.
16:53:23 <aleth> clokep_work: Ah, I see what you mean now. You're right, different issue
16:53:34 <aleth> There's a max-width missing somewhere ;)
16:54:47 <clokep_work> Yep!
16:57:38 * aleth added some comments to the mode bug
16:57:57 <clokep_work> I saw.
16:59:38 --> nhnt11 has joined #instantbird
17:01:02 --> Bollebib has joined #instantbird
17:03:48 <nhnt11> aleth: That's weird, line breaks shouldn't be lost..
17:04:07 <nhnt11> I remember comparing the result of the existing "Copy debug log" to the copy button in the debug log tab, and they were identical
17:04:07 <nhnt11> I think I mentioned something about trailing newlines too..
17:04:09 * nhnt11 investigates
17:04:39 <aleth> I don't mean using the copy button
17:04:57 <nhnt11> Hmm, indeed...
17:04:57 <nhnt11> yeah, I just realized.
17:04:58 <nhnt11> That's rather annoying...
17:05:12 <Defman> Why you don't give any status on IRC to nhnt11 if he's developer?
17:05:12 <nhnt11> makes copying rather useless
17:05:26 <nhnt11> The copy button works fine :-/
17:05:51 <nhnt11> Defman: There's no need for an extra op ;)
17:06:09 <aleth> Defman: You can't assume only ops are devs anywhere ;) 
17:06:49 <Defman> Okay...
17:06:59 <nhnt11> Defman: This is in general a developer IRC network, many many of the people who lurk here are devs (I'm talking about the network, not just this channel) :)
17:07:09 <Defman> But I never think that nhnt11 is developer
17:07:11 <Defman> WOW
17:07:18 <nhnt11> Can't op all of them ;)
17:07:21 <Defman> It's fun :D
17:07:45 <Defman> okay, in this case I really don't see any reason to give op for all devs...
17:09:08 <nhnt11> I'm going to look at the copying issue in a moment, since it's rather important, but the UI stuff will have to wait I'm afraid...
17:09:15 <nhnt11> (unless someone wants to take over ;))
17:13:29 --> gerard-majax has joined #instantbird
17:13:30 <aleth> nhnt11: if it turns out to be nontrivial to get right (quite possible), maybe leave it until after the gloda/logging stuff lands
17:13:49 <nhnt11> aleth: sure. I've got about 10-15 minutes at the moment, that's hwy I'm looking at it
17:13:58 <nhnt11> I've got some ideas...
17:20:33 <nhnt11> The easiest way to fix this that I can think of at the moment is to simply replace newlines with <br/> :S
17:29:58 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:32:42 * Fallen is now known as Fallen|away 
17:35:28 * clokep_work sets mode +h nhnt11 
17:35:34 <clokep_work> Happy? :P
17:36:55 <Defman> Wow
17:37:10 <Defman> My congratulations :)
17:38:18 <nhnt11> clokep_work: lol, thanks!
17:38:42 <clokep_work> Apparently there's no /hop command though.
17:39:10 <Defman>  /hop-laleyla
17:39:28 <flo-retina> aleth: no purple changeset?
17:39:44 --> gerard-majax has joined #instantbird
17:39:58 <aleth> flo-retina: There is one, but the comment isn't added automatically for that one 
17:39:59 <Defman> Why my nick is always purple?
17:40:14 <nhnt11> Defman: Instantbird calculates nick colour using the nick itself
17:40:18 <nhnt11> so that a nick always has the same colour
17:40:29 <nhnt11> It's great because then you can recognize nicks at a glance
17:40:35 <Defman> Okay
17:40:40 <Defman> I hate my nick in Instantbird.
17:41:20 --> myk has joined #instantbird
17:41:41 <nhnt11> Bah, the text selection thing works in Chrome
17:41:42 <instantbot> aleth@instantbird.org changed the Resolution on bug 955353 from --- to FIXED.
17:41:43 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955353 nor, --, 1.6, clokep, RESO FIXED, Rename imIAccountBuddy to prplIAccountBuddy
17:45:34 <aleth> flo-retina: If you want a gtalk-enabled nightly OSX should build again now.
17:46:06 <nhnt11> \o/
17:46:42 <clokep_work> aleth: I asked you not to push that. :(
17:47:37 <aleth> clokep_work: Sorry, I saw it too late. I only pushed it because I still had the tab open, it wouldn't have shown up in checkin-needed :-/
17:49:57 <aleth> If you attach your improved version I can push the interdiff later if you like.
17:50:49 <clokep_work> aleth: I took care of it.
17:51:13 <aleth> clokep_work: Thanks!
17:52:34 <clokep_work> There was a text fix that should have been pushed too though.
17:52:58 <aleth> checkin-needed was empty.
17:53:21 <-- gerard-majax has quit (Ping timeout: 121 seconds)
17:54:28 <clokep_work> aleth: I see 5 things.
17:54:50 <aleth> uh, did my search break *again*? :-S
17:54:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:56:10 <nhnt11> aleth: bug 116083
17:56:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=116083 nor, --, ---, nobody, NEW, copy paste of CSS "white-space: pre;" content does not preserve whitespace
17:56:33 <nhnt11> I don't think we should necessarily wait for that, but it's interesting..
17:56:41 <nhnt11> s/necessarily//
17:56:50 <aleth> wow, that's been open for a loooong time
17:56:55 <nhnt11> yeah
17:57:20 <clokep_work> aleth: I shared one, just use that. ;)
17:57:37 <clokep_work> nhnt11: Btw that +h won't stick after a restart..I was too lazy to play w/ ChanServ ATM.
17:57:44 <nhnt11> clokep_work: sure
17:58:29 <aleth> clokep_work: yes, I have to modify the keyword in Firefox.
17:58:48 <clokep_work> Ahhh. :)
18:07:48 --> bernard has joined #instantbird
18:08:46 --> gerard-majax has joined #instantbird
18:13:00 <nhnt11> aleth: Okay so after researching this for the last hour or whatever, it seems there's no real easy solution.
18:13:21 <nhnt11> I'm currently leaning towards splitting the message at "\n", and appending these in a loop, each one followed by a <br>
18:13:37 <nhnt11> (Splitting because they will need to be wrapped by a <pre> or something to preserve any html tags in them)
18:13:42 <clokep_work> nhnt11: split() and join()?
18:13:56 <nhnt11> Yeah, or that^
18:13:58 <clokep_work> nhnt11: Did you check how magic copy works?
18:14:01 <nhnt11> I was thinking of using text nodes..
18:14:14 <nhnt11> because that would mean I don't have to manually wrap stuff in <pre> I think
18:14:18 <nhnt11> clokep_work: Nope, good idea
18:14:28 <nhnt11> Though I have a feeling that's a little overkill for this...
18:14:52 <nhnt11> Easier to just format it while adding the text than try parsing it after stuff is selected (which is how magic copy works right? Maybe I shouldn't assume)
18:17:00 <-- Tonnes has quit (Connection closed)
18:17:11 <nhnt11> This definitely works: http://pastebin.instantbird.com/1068248
18:17:18 <nhnt11> aleth: You ok with that^ ?
18:17:23 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:17:42 <nhnt11> ("stuff" is the td element in my test html page btw)
18:19:57 <nhnt11> I know I'll need to account for the extra <br/> at the end, btw
18:19:59 <aleth> nhnt11: If it works, yes. Add a comment too
18:20:16 <nhnt11> yes, I'll do that
18:20:29 <nhnt11> bbl
18:20:47 <-- bernard has quit (Quit: Leaving.)
18:21:29 <aleth> nhnt11: Though if you can just put it into text content and that works too, it may be simpler
18:23:20 <clokep_work> aleth: Was I supposed to start a new nightly?
18:23:31 --> gerard-majax has joined #instantbird
18:23:37 <aleth> clokep_work: If you want gtalk right now, I guess?
18:23:42 <clokep_work> I WANT IT NOW!
18:24:24 <aleth> When we upgrade the release process, we should probably look at giving retrigger/block updates rights to one person per timezone at least
18:24:30 <-- nhnt11 has quit (Ping timeout: 121 seconds)
18:24:49 <clokep_work> aleth: I think we can give them to you pretty easily. :)
18:26:09 <aleth> Usually less important for me though as flo is in the same zone
18:27:14 <flo-retina> aleth: do you seriously not have the rights to do that now?
18:27:20 <aleth> I don't
18:27:37 <flo-retina> people with commit access should also have retrigger access
18:27:47 <flo-retina> and more importantly (but also more difficult) a way to stop broken nightly updates
18:28:09 <aleth> It would have been really useful a couple days ago if nhnt11 could have stopped broken updates, and/or retriggered
18:28:22 <clokep_work> Both actually, youw ant to sto updates first.
18:30:54 <-- gerard-majax has quit (Ping timeout: 121 seconds)
18:46:50 <-- clokep_work has quit (Ping timeout: 121 seconds)
18:59:11 --> nhnt11 has joined #instantbird
18:59:12 * ChanServ sets mode +h nhnt11 
19:22:57 --> EionRobb has joined #instantbird
19:29:37 * nhnt11 agrees with http://log.bezut.info/instantbird/141128/#m724
19:31:54 <Mook_as> Do the logs depend on user time? That's tomorrow for me... and the log.
19:32:12 <aleth> nhnt11 has a special relationship with time
19:32:24 <nhnt11> oh wow
19:32:29 <nhnt11> oop
19:32:29 <nhnt11> s
19:32:36 <nhnt11> http://log.bezut.info/instantbird/141127/#m724 is what I meant
19:32:42 <Mook_as> is he a lord?
19:33:04 <nhnt11> I was changing the "today" in the URL
19:33:08 <nhnt11> and right now it's the 28th here ;)
19:33:18 <nhnt11> I just glanced at the date in the menubar and didn't think twice
19:33:59 <Mook_as> Now we just need to line up the logs tomorrow to make you with agree with whatever :)
19:34:28 <nhnt11> :P
19:38:33 <Defman> Ha
19:38:48 <Defman> For me 27th.
19:40:37 <nhnt11> aleth: http://log.bezut.info/instantbird/today/#m711 Text content won't work with the <br/>'s
19:41:01 <nhnt11> I'll need to use innerHTML then, which means I'll have to excape any html tags in the debug message (or use <pre> or whatever)
19:41:18 <nhnt11> I figured using a text node and br node would be simpler
19:42:12 <aleth> OK, whatever is easiest :)
19:46:22 * Fallen|away is now known as Fallen 
19:47:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:47:53 * nhnt11 hopes he doesn't have to clobber..
19:48:25 <nhnt11> Bah, looks like I do :(
19:48:42 <nhnt11> Should have done a `make -C im/` from objdir instead of using mach...
19:48:54 <aleth> Did you pull m-c?
19:49:11 <nhnt11> aleth: When I built thunderbird the other day, yeah
19:49:15 <nhnt11> Haven't built Ib since then
19:49:25 <aleth> I use a different objdir for each
19:49:32 <nhnt11> So do I
19:49:43 <aleth> ah, I see
19:49:45 <nhnt11> (can you use the same objdir for both? O_o)
19:50:09 <nhnt11> I use the same srcdir for both.
19:50:11 <aleth> No, I was thinking backwards, like you had two separate srcdirs
19:59:27 --> chrisccoulson has joined #instantbird
20:02:29 --> arlolra has joined #instantbird
20:08:12 <instant-buildbot> build #2440 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2440
20:54:46 <-- aleth has quit (Quit: :tiuQ)
20:54:57 --> aleth has joined #instantbird
20:54:58 * ChanServ sets mode +o aleth 
20:55:19 <-- aleth has quit (Quit: :tiuQ)
20:55:22 --> aleth has joined #instantbird
20:55:23 * ChanServ sets mode +o aleth 
20:55:40 <nhnt11> Well, crap
20:55:54 <nhnt11> It appears this thing with the <br/>'s breaks the copy-all button
20:56:00 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
20:56:07 --> nhnt11 has joined #instantbird
20:56:08 * ChanServ sets mode +h nhnt11 
20:56:33 <aleth> Can't copy all use the code that the account manager context menu entry uses?
20:57:49 <nhnt11> Gtalk! \o/
20:58:04 <nhnt11> aleth: Kind of a waste, don't you think?
20:58:06 <nhnt11> Let me see...
21:01:57 <nhnt11> aleth: So I have a dirty hack that works
21:02:03 <nhnt11> Keep the \n as well as the <br>
21:02:14 <nhnt11> And remove the white-space: pre-wrap css
21:02:30 <nhnt11> That way the \n's aren't displayed, but are copied. And the br's are displayed, but not copied.
21:02:33 <aleth> that's ... dirty
21:02:35 <nhnt11> very
21:02:38 <nhnt11> trying other things.
21:03:02 <aleth> It's odd the \n are copied some times but not other times
21:03:11 <aleth> Why is that?
21:03:17 <nhnt11> "Some times but not other times" What are the "some times"?
21:03:26 <aleth> When you copy-all
21:03:28 <nhnt11> ah
21:03:40 <nhnt11> Because when I do copy all, I'm bypassing the browser
21:03:52 <nhnt11> I'm putting the body's textContent into the clipboard manually
21:04:06 <nhnt11> Cmd+C goes through whatever the browser does internally
21:04:09 <aleth> I see
21:04:14 <nhnt11> and that seems to not take CSS into account
21:05:14 <aleth> well, if you do something like that, add lots of comments
21:05:19 <nhnt11> yup
21:05:23 <nhnt11> I'm trying to avoid it though
21:05:34 <nhnt11> Must be an easy way to get the <br>'s to copy
21:05:39 <nhnt11> (as opposed to the \n's..)
21:09:34 <nhnt11> aleth: The only real clean fix here is to fix the upstream bug :(
21:09:50 <aleth> Does body.innerText do the trick?
21:09:59 <nhnt11> aleth: innerText is IE only
21:10:11 <aleth> ah
21:10:12 <nhnt11> well not IE only, but it's not a W3C standard and gecko doesn't suppor tit
21:10:14 <nhnt11> support it*
21:10:41 <aleth> Well, use your hack and refer to the upstream bug so that when it gets fixed in 2024 we can remove it
21:11:27 <nhnt11> \o/
21:11:30 <nhnt11> I found a cleaner hack
21:11:54 <nhnt11> or hmm, maybe not
21:13:11 <nhnt11> Yeah, never mind, false alarm
21:13:47 <nhnt11> Okay, so I think I'll use the hack... it's a bit bad but for a debugging tool... meh
21:14:12 <nhnt11> And if that upstream bug gets fixed, we'll probably notice immediately: we'd start seeing double line breaks when copying logs
21:15:13 <nhnt11> (or maybe not, since pre-wrap isn't enabled, gah)
21:16:29 <aleth> or you could use something like window.getSelection().toString()
21:17:44 <aleth> after building an appropriate selection
21:18:21 --> Rym has joined #instantbird
21:18:28 <nhnt11> aleth: tried that already
21:18:38 <nhnt11> Same behavior as selecting and cmd+C
21:18:48 <nhnt11> oh
21:18:49 <nhnt11> wait
21:18:53 <nhnt11> do you mean for copy-all?
21:18:55 <aleth> yes
21:18:58 <nhnt11> Hmm
21:19:02 <nhnt11> Possibly less dirty...
21:19:12 <nhnt11> I hesitate to "simulate" user interaction though
21:19:28 --> bernard has joined #instantbird
21:19:37 <aleth> You don't simulate it, you build a Selection and then selection.toString()
21:19:46 * nhnt11 doesn't know how that works
21:19:48 <aleth> Not that I have ever done that... but it might work
21:19:51 --> Tonnes has joined #instantbird
21:19:58 <nhnt11> looking it up
21:24:28 <-- Tonnes has quit (Quit: ChatZilla 0.9.91 [Firefox 33.1.1/20141113143407])
21:24:54 --> Tonnes has joined #instantbird
21:25:25 <aleth> maybe let sel = new Selection(); sel.selectAllChildren(document.body); sel.toString()
21:25:55 <nhnt11> aleth: Yeah, it works
21:26:02 <nhnt11> But it clears anything currently selected
21:26:19 <nhnt11> so then I'd have to preserve any existing selection, and reselect it...
21:26:22 * nhnt11 doesn't like it
21:26:28 <aleth> all a bit messy
21:26:42 <nhnt11> I feel like my first dirty hack is cleaner for some reason :]
21:26:50 <aleth> It's a bit odd that new Selection affects the selection on the window
21:26:57 <nhnt11> oh
21:27:01 <nhnt11> I didn't try new Selection()
21:27:06 <nhnt11> Is that possible?
21:27:11 <aleth> no idea
21:27:18 <nhnt11> apparently not
21:30:23 <Mook_as> Would https://developer.mozilla.org/en-US/docs/Web/API/Range help?
21:30:42 <nhnt11> I'm using it at the moment.
21:30:48 <Mook_as> (selections can contain multiple ranges, etc etc)
21:30:55 <Mook_as> Ah, so no.
21:31:54 <nhnt11> aleth: Can I get a green light for the initial dirty hack?
21:32:00 <nhnt11> Seems a little less messy
21:32:02 <aleth> yes
21:32:05 <nhnt11> Thanks
21:32:18 <nhnt11> I'll write a long comment for it
21:34:31 <flo-retina> "line up the logs tomorrow to make you with agree with whatever" sounds like an excellent plan
21:37:07 <nhnt11> http://pastebin.instantbird.com/1068499 :(
21:42:26 <nhnt11> Okay, I can confirm that the copy all button, the Copy Debug Log context menu item, as well as select all and Cmd+C all have the same result.
21:49:45 <-- myk has quit (Ping timeout: 121 seconds)
21:49:54 <-- bernard has quit (Quit: Leaving.)
21:58:39 <instantbot> nhnt11@gmail.com changed the Resolution on bug 1105798 from --- to FIXED.
21:58:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105798 nor, --, 1.6, nhnt11, RESO FIXED, Copying from a debug log tab loses line breaks
22:00:57 <nhnt11> Aha, "typing" panel stuck
22:01:07 <nhnt11> Switching away and back to the tab doesn't help
22:02:29 * nhnt11 will keep an eye out for STR
22:03:44 <aleth> My suspicion is more that switching away and back from the tab may cause it
22:04:22 <nhnt11> aleth: yeah, that's it
22:04:39 <nhnt11> other person starts typing, I switch away, other person sends message, I switch back, typing panel is still there.
22:04:55 <aleth> Yay, STR! File a bug please ;)
22:05:05 <nhnt11> on it
22:06:32 <flo-retina> :)
22:08:30 <-- Defman has quit (Quit: My Double-Powered Atomic Reactor has gone to sleep. caaBOOOOM! ZZZzzz....)
22:13:59 <instantbot> New Instantbird - Conversation bug 1105871 filed by nhnt11@gmail.com.
22:14:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1105871 nor, --, ---, nobody, NEW, "Typing" status panel not cleared if a different tab is selected
22:31:01 <-- mconley has quit (Connection closed)
22:51:06 --> mpmc has joined #instantbird
23:06:04 <-- arlolra has quit (Client exited)
23:09:09 --> arlolra has joined #instantbird
23:09:59 <-- Armada has quit (Connection closed)
23:13:25 --> Fearful has joined #instantbird
23:13:42 <Fearful> I'm using instantbird alpha version I think
23:13:47 <Fearful> I tried setting up a proxy
23:13:51 <Fearful> but it won't let me click ok
23:13:57 <Fearful> any idea why?
23:17:52 <Fearful> Error: NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 0 [purpleICoreService.globalProxy]
23:17:54 <Fearful> Source File: chrome://instantbird/content/proxies.js
23:17:56 <Fearful> Line: 169
23:20:38 <aleth> Fearful: Sounds like a bug :-( Can you file it please?
23:21:19 --> Rym_ has joined #instantbird
23:21:55 <-- Rym has quit (Ping timeout: 121 seconds)
23:23:13 <Fearful> ah
23:23:19 <Fearful> where would I file a bug?
23:23:21 <Fearful> :P
23:24:00 <aleth> bugzilla.mozilla.org
23:24:13 <Fearful> k
23:24:14 <aleth> If you file it, you'll get notified when it's fixed.
23:24:22 <Fearful> alright
23:55:27 <-- arlolra has quit (Client exited)