All times are UTC.
00:02:32 <-- sherief has quit (A TLS packet with unexpected length was received.) 00:05:38 * clokep hates these comments already. 00:05:41 <clokep> Why'd I volunteer fo rthis? 00:09:30 <-- Bollebib has quit (Connection closed) 00:19:02 --> DGMurdockIII has joined #instantbird 00:19:05 <-- DGMurdockIII has quit (Connection closed) 00:42:53 --> Tobin has joined #instantbird 00:44:59 * Tobin to flo-retina or flo-linux .. Hi.. I am trying to track changes in the chat core in comm from gecko/24 to gecko/31 but i am having some issues about what i should be searching for related to target milestone.. what versions corrispond to what gecko releases? 00:45:38 <Tobin> or exactly how is that being done? 00:46:38 <clokep> Tobin: Hi. 00:46:44 <aleth> Tobin: They don't line up, exactly. You'd have to find the revision range corresponding to gecko24-31 and log the changes in /chat 00:46:46 <clokep> That's unfortunately pretty hard. 00:47:23 <Tobin> yeah 00:47:25 <clokep> aleth: Do you know how contacts get IDs? :-S 00:47:36 <Tobin> a real pain.. 00:47:39 <aleth> And you'd have to do that in the releases repo, to catch uplifts 00:47:51 <nhnt11> clokep: I'm pretty sure it's just the auto increment primary key in the database 00:48:04 <aleth> We have some rough plans to change our target milestones to match those of gecko in the future. 00:48:05 <clokep> nhnt11: Yeah, I understand that...but *WHO* adds it? 00:48:14 <Tobin> well.. do you happen to know which target milestone happened to be in gecko/24 that could give me somewhat of an idea 00:48:25 <clokep> Tobin: 1.6 00:48:35 <Tobin> does narrow it down thanks ;) 00:48:37 <clokep> But some of 1.6 is after 31. 00:48:48 <clokep> But I'm *pretty* sure that 1.5 is before 24. 00:49:16 <clokep> nhnt11: Hmm...I see what oyu're saying it' snever assigned, it just happens on create. 00:49:24 <clokep> aleth: Thanks for the review, did those comments help? 00:49:31 <Tobin> about when did instantbird completely merge into comm? wasnt it around 26 or 27? 00:49:38 <aleth> clokep: still reviewing 00:49:49 <aleth> Thanks for taking care of this :) 00:49:49 <clokep> Tobin: It was ~1 year ago. 00:49:52 <clokep> It was last december. 00:50:00 <Tobin> so yeah about then 00:50:18 <Tobin> hindsight of 27 to 28 i think maybe 00:50:31 <aleth> clokep, nhnt11: right, somewhere in imContacts, I guess 00:50:33 <clokep> So there's some scary bugs where I merged huge sets of changesets between IB & c-c before that. :( 00:51:18 <Tobin> i watched it for a bit yeah 00:51:31 <Tobin> well when i was exploring comm-merge on alder 00:51:34 <nhnt11> Bah, building with the 10.9 sdk gave me this: http://puu.sh/cWvSU/db17768fca.png http://puu.sh/cWvTm/e824c79352.png 00:51:41 <nhnt11> What's with the tiny fonts :-/ 00:52:07 <aleth> Tobin: What do you need it for? 00:52:21 <clokep_work> aleth: So...it seems like everywhere we have a convIM we assume that if there's an accountbuddy, that accountbuddy has a corresponding imIBuddy. 00:52:23 <Tobin> what the bug fixes or alder and comm-merge.. 00:52:29 <aleth> nhnt11: Huh, I thought they'd fixed that bug 00:52:36 <nhnt11> Exactly 00:52:43 <nhnt11> Last time I built with the 10.9 sdk /most/ stuff was fine.. 00:52:52 <nhnt11> Maybe I just never checked about:* pages 00:53:20 <aleth> The worst bug was some weird failures due to a change in a l10n library 00:53:23 <nhnt11> No, conversation fonts are messed up too 00:53:39 * nhnt11 will rebuild with the 10.8 sdk later 00:53:42 <aleth> The fonts are merely annoying ;) 00:53:58 <nhnt11> aleth: It's more than just annoying when you're making UI changes 00:54:09 <nhnt11> (but I guess I'm not, at the moment) 00:54:43 <aleth> Do you need the SDK or why aren't you using it? 00:54:58 <nhnt11> 10.8 you mean? 00:55:10 <aleth> yes 00:55:14 <nhnt11> Last time I built, I used 10.9 and it was fine 00:55:21 <nhnt11> Did a clobber just now and everything is messed up again 00:55:26 <aleth> It should hardly get worse :-/ 00:55:34 <nhnt11> Yeah, I'm confused 00:55:37 * nhnt11 shrugs 00:56:03 <Tobin> aleth: I am trying to evaluate bug fixes for chat core relating to a fork of Thunderbird but since chat core is defacto owned by instantbird project you would obviously know the most about it.. And we use a forked version of 24 in our project for.. reasons 00:56:16 <-- myk has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 00:56:19 --> myk has joined #instantbird 00:56:27 --> DGMurdockIII has joined #instantbird 00:56:34 <clokep> Tobin: What fork is this? 00:56:42 <Tobin> FossaMail 00:56:44 <clokep> Tobin: And it isn't "defacto owned", it *is* owned by us. 00:56:58 <Tobin> sorry didn't mean to offend 00:57:19 <clokep> Not offended, "defacto" just makes it sound like no one wants it. :) 00:57:20 <Tobin> i didn't know if chat core orginated with instantbird or not for sure.. 00:57:23 * clokep hugs chat core. 00:57:27 <clokep> It did. 00:57:40 <Tobin> Just wasn't absolutely sure ;) 00:57:44 <aleth> No worries, however you assign it it's just the same people in the end. 00:58:18 <Tobin> well yeah comm-central projects are great at shareing and cooperation unlike mozilla-central 00:58:49 <clokep> But yeah the best way is |hg log chat -r <tb-24>:<tb-31>| 00:59:02 <aleth> Use comm-release for that I guess 00:59:19 <Tobin> could use comm-esr31 as well yeah 00:59:23 <clokep> aleth, nhnt11: So...how do I get a negtative ID? :-D http://dxr.mozilla.org/comm-central/source/chat/components/public/imIContactsService.idl#59 01:00:02 <aleth> iirc they start out as dummies and become "real" when they get a tag 01:00:33 <aleth> http://dxr.mozilla.org/comm-central/source/chat/components/src/imContacts.js#411 01:00:50 <clokep> Thanks. 01:00:56 <clokep> I really don't know the conv or contacts services well. :-\ 01:01:11 <Tobin> how is instantbird as a project doing since merging into comm? 01:01:14 <aleth> I've never looked into id assignment, so take it with a pinch of salt ;) 01:01:18 <nhnt11> clokep: http://dxr.mozilla.org/comm-central/source/chat/components/src/imContacts.js#382 01:01:35 <nhnt11> If the contact is created from a db entry, aId will have a value 01:01:41 <Tobin> has it been a good experence? 01:01:49 <aleth> Tobin: Doing fine, lots of interesting things in the pipeline (try a nightly) 01:01:50 <nhnt11> If not, it'll be undefined: http://dxr.mozilla.org/comm-central/source/chat/components/src/imContacts.js#711 01:01:52 <clokep> Interesting... 01:02:06 <clokep> Tobin: It's all nice except for figuring out how to release. :-S 01:02:35 <clokep> nhnt11: So does it sound sane that I create a "new" contact and assign it not tags and hope that stuff "works" from that? 01:02:54 <nhnt11> clokep: What are you trying to do? 01:03:01 <nhnt11> Is this for a new Skype prpl? 01:03:11 <Tobin> what is the current release scheme for instantbird now.. following rabid release or esr largely? 01:03:16 <nhnt11> (forgive me if I'm totally wrong there) 01:03:25 <Tobin> or your own 01:03:46 <aleth> Tobin: we'd like to rapid release, but the details are not trivial and need working out. 01:04:45 <clokep> nhnt11: IRC conversations having status 01:04:51 <Tobin> imo for rapid release to work .. stable rapid development must follow.. being a slave to an arbitrary calendar date hasn't done other projects well in actual practice even though we pretend it has 01:04:53 <nhnt11> Ah! 01:05:32 <clokep> Tobin: Well, the plan is more of "rapid-er" release...not necessarily rapid release. 01:05:35 <nhnt11> Are you creating database entries for buddies? 01:05:44 <clokep> My goal is not to. 01:06:54 <Tobin> kind of a pick and chose based on what is a good release of backend and when app specific code reaches a particular quality and/or milestone? 01:06:55 <nhnt11> I'm not sure about fake buddies :-/ 01:07:03 <nhnt11> sorry 01:07:18 <clokep> nhnt11: Not a problem. You've been helpful so far! Thank you. 01:07:38 <aleth> Yes, it really shouldn't touch the database :-/ 01:07:44 <aleth> Not sure how easy that is to achieve 01:08:12 <aleth> Tobin: On the other hand you want to avoid releasing to rarely 01:08:25 <nhnt11> aleth: I moved the code that creates a panel and shows it in a new tab to a separate function in ibCore: http://pastebin.instantbird.com/1046254 01:08:38 <nhnt11> I'm wondering if that wants to return a Promise instead of accepting a callback ,what do you think? 01:09:01 <nhnt11> Maybe overkill. 01:09:05 <aleth> What is it for? 01:09:44 <nhnt11> aleth: I added a Show Debug Log context menu item to the account manager window. I wanted to avoid duplicating all that code 01:09:58 <Tobin> aleth: it is hard not to want the latest and greatest advancements in backend and try and balance that with stablity, reliablity, and sanity.. it requires hard choices to be made depending on how you do it.. I know all too well 01:09:59 <aleth> Good idea 01:09:59 <nhnt11> So now accounts.js imports ibCore.jsm and calls Core.showTab() 01:10:27 <nhnt11> Lines 87 to 91 in that diff are still duplicated though 01:12:37 <nhnt11> Well, that's all the time I have for now 01:12:41 <nhnt11> I'll upload a patch 01:13:35 <clokep> Less duplication is good! 01:13:42 * clokep wonders who owes you reviews. 01:13:54 <aleth> There doesn't seem to be a real reason for a Promise, but if you think it simplifies the code to do this.showTab.then() then feel free ;) 01:13:57 <clokep> Tobin: Yeah, stability is important, we're well aware... 01:14:10 <clokep> I think it's over kill for this case personally... 01:14:17 <nhnt11> aleth: Not enough to justify importing Task.jsm ;) 01:14:22 <clokep> Unless you expect insane nesting. 01:14:28 <nhnt11> Awww, crap: https://tbpl.mozilla.org/php/getParsedLog.php?id=52916211&tree=Thunderbird-Try#error0 01:14:32 <nhnt11> How did that sneak past me?? 01:14:35 <aleth> nhnt11: Right! But DOM Promises are free, should you want them 01:15:01 <clokep> nhnt11: That's what try runs are for. :) 01:15:15 <nhnt11> clokep: I should've caught that locally, what a waste of a try build. 01:15:27 <aleth> yay for the try server ;) 01:15:28 <-- Tonnes has quit (Connection closed) 01:16:20 <clokep> nhnt11: aleth: Now...the next question is...any idea where imIBuddy instances are created? :-D 01:16:34 <clokep> Ah, there's a buddy object too. :) 01:17:45 <nhnt11> Ok, I've got test_logger.js passing locally 01:18:00 <nhnt11> I could have sworn the tests were passing last time I tried, I wonder if it's some strict mode thing 01:18:08 <nhnt11> Btw, test_filtering.js is failing, not sure if that's known 01:18:22 <aleth> Yes, someone mentioned it on #maildev, some recent m-c change I guess 01:18:27 <aleth> Nobody has looked into it yet 01:18:34 <nhnt11> ok 01:18:42 <clokep> nhnt11 just volunteered. :) 01:18:58 <aleth> Let him kick off another try build first ;) 01:19:24 <aleth> If that makes sense. 01:19:36 <nhnt11> There should be a way to push an updated test and just run that :( 01:21:13 <-- EionRobb1 has quit (Quit: Leaving.) 01:22:04 * clokep mumbles. 01:22:13 <clokep> imIBuddy doesn't look easy to fake without the database... 01:23:52 <aleth> clokep: random thought: have you considered a "fake" tag? 01:23:53 <nhnt11> clokep: My first idea is to copy the LastDummyContactId thing for buddies.. 01:24:01 <aleth> Or does that just add more mess 01:25:00 <clokep> nhnt11: Yep that's what I've done so far. 01:25:11 <clokep> aleth: There's already a "Fake" tag FWIW, the "Other Contacts tag". 01:25:18 <clokep> We could create another one which doesn't show up in the UI, likely. 01:25:23 <clokep> Not sure how hacky that is though. 01:25:36 <aleth> The other contacts tag is a bit more crazy 01:25:55 * clokep is still waiting for nhnt11's "Awesome people who I always talk to" tag. 01:26:03 <aleth> But a "fake" tag is probably just a roundabout way of adding an isTemporary flag 01:26:16 <clokep> Right. 01:26:31 <clokep> We, of course, want it to be done in such a way that you can "add" the contact as a "real" contact and the history, etc. is all there. 01:26:42 <aleth> If you can avoid touching tags, it will be much easier 01:26:57 <-- myk has quit (Ping timeout: 121 seconds) 01:27:04 <aleth> clokep: I think I've (almost) already done that 01:27:39 <aleth> Try "add contact" from the tag context menu of a PM conv with someone who isn't a buddy, and watch what happens 01:28:00 <clokep> aleth: I meant after my patch. :) 01:28:01 <aleth> But you'll make that more reliable 01:28:01 <-- Armada has quit (Connection closed) 01:28:29 <aleth> I meant in most cases the history is already retained 01:29:01 <clokep> It should be, yeah. 01:29:07 * clokep has flashbacks of normalizations. 01:29:24 <aleth> yeah, *hopefully* that part is done 01:29:53 <aleth> What'll change is that there'll already be a buddy object to inherit. 01:31:37 --> myk has joined #instantbird 01:36:28 <clokep_work> aleth: http://pastebin.instantbird.com/1046318 is my current patch. 01:36:37 <clokep_work> But I'm getting an error that "Buddy is not a constructor", any thoughts? 01:44:52 <nhnt11> clokep: line 60 wants to import imContacts.js 01:44:54 <nhnt11> not imConversations 01:45:25 <nhnt11> clokep_work: ^ 01:45:50 <-- DGMurdockIII has quit (Quit: Leaving) 01:45:58 <clokep> nhnt11: Doh! 01:46:00 <clokep> Thanks. :) 01:46:06 <clokep> I must have been ignoring what that said each time 01:47:33 <clokep> Well no errors anymore! :-D 01:50:46 --> Widdershins has joined #instantbird 01:57:59 <-- myk has quit (Ping timeout: 121 seconds) 01:59:27 <-- aleth has quit (Ping timeout: 121 seconds) 02:07:17 --> EionRobb has joined #instantbird 02:07:19 <clokep> !!!! Woot, it works. :) 02:07:21 <clokep> Mostly. 02:11:11 <-- Mook_as has quit (Client exited) 02:16:24 <Tobin> clokep: source tree REALLY needs to allow logging of a directory but tortoiseHG does so yeah! 02:17:17 <Tobin> has it really been 6 months since the last patch to chat core on ESR31 02:17:40 <Tobin> likely around when it started climbing up through aurora and beta channels 02:18:04 <Tobin> least you guys are AWESOME at depends in bugzilla ;) 02:18:16 <Tobin> not everyone is 02:18:55 <clokep> Tobin: I don't know what you mean by "source tree REALLY needs to allow..."? 02:19:02 <clokep> What do you mean by "source tree"? 02:19:02 <Tobin> sorry 02:19:06 <Tobin> the software SourceTree 02:19:15 <clokep> I hav eno idea what that is. 02:19:16 <Tobin> it is an hg and git front end 02:19:17 <clokep> :) 02:19:21 <clokep> Interesting. 02:19:27 <clokep> Anyway, six months ago sounds vaguely reasonable yeah. 02:19:33 <clokep> A few things were approved recently though, I think. 02:19:38 <clokep> I forget if they were committed or not. 02:20:02 <Tobin> well for chat core it will be mostly cherry-picking relivant enhancements 02:20:18 <clokep> Yep. 02:22:12 <Tobin> I personally don't use the mail client's chat features.. have always prefered a standalone client for that.. .. heh though wouldn't it be neat if for say seamonkey it would load instantbird's contact list in a sidebar sorda like how aol hacked AIM into a sidebar back on Netscape 6/7 02:22:24 <Tobin> yeah unrelated but still would be nifty 02:23:01 <Tobin> one thing i am still a little unclear about.. is where libpurple comes into play these days 02:23:11 <Tobin> are you guys just reimpimenting it in chat core? 02:23:18 <clokep> That sounds pretty much like what chat in TB does...? 02:23:27 <clokep> I don't know what you mnea by "implementing it". 02:23:30 <Tobin> clokep: as i said i haven't explored it THAT much 02:23:33 <clokep> Instantbird uses libpurple for a bunch of protocols. 02:23:40 <clokep> Thunderbird does not use it, it's GPL. 02:24:05 <Tobin> so where is libpurple in the codebase? i assume it isn't in comm is it? 02:25:02 <instantbot> New Chat Core - General bug 1101311 filed by firstname.lastname@example.org. 02:25:04 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1101311 nor, --, ---, nobody, NEW, TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/chat/modules/test/test_filterin 02:25:25 <clokep> Tobin: No. 02:25:39 <clokep> It's in a separate repository. 02:25:46 <clokep> http://hg.mozilla.org/users/florian_queze.net/purple/ 02:26:04 <Tobin> so you would have to clone it in to build instantbird proper 02:26:23 <Tobin> sort of like ldap or domi/chatzilla/venkman 02:27:38 <Tobin> so what protocols in instantbird are handled by libpurple and not handled by chat core 02:29:37 <clokep> Tobin: Build instructions are at https://developer.mozilla.org/en-US/docs/Simple_Instantbird_build 02:29:52 <clokep> Tobin: IRC, Twitter, GTalk, Facebook and Yahoo are in chat core. 02:30:02 <clokep> XMPP is also in it, but we use the libpurple implementation for Instantbird. 02:30:28 <clokep> We also use Gadu-Gadu, AIM/ICQ, SIMPLE, Office Communicator, a bunch of others via libpurple. 02:30:54 <Tobin> gtalk is xmpp.. well after a fasion 02:31:02 <Tobin> but no one has ported oscar to chat core yet? 02:31:17 <clokep_work> Yes, GTalk is XMPP. I did just say we have an implementation of XMPP in chat. 02:31:25 <clokep_work> Tobin: I started work on it, but haven't had time to finish it. 02:31:58 <Tobin> interesting 02:32:18 <Tobin> wish you luck on it 02:33:03 <clokep> Thanks. 02:33:09 <clokep> I'll maybe get around to finishing it at some point. 02:33:18 <clokep> I unfortunately don't use OSCAR as much as I used to. :( 02:33:35 <Tobin> I am sure we would be interested in backporting oscar to our version of chat core 02:34:12 <clokep> I'm not sure what you'd have to backport. 02:34:18 <clokep> Or what "our version" means. 02:34:22 <clokep> Do you actually have changes? 02:34:25 <clokep> Do you not upstream them? 02:35:41 <Tobin> in FossaMail.. some.. but very little it is litle more than an optimised rebuild atm though that is changing 02:35:56 <Tobin> FossaMail is done by the same group (which i am apart of) doing Pale Moon 02:36:25 <Tobin> we broke from upstream at the gecko/24 level (specifically the ESR24 level) 02:36:33 <Tobin> doing our own thing 02:37:21 <clokep> What's that mean? 02:37:28 <-- clokep_work has quit (Ping timeout: 121 seconds) 02:37:46 <clokep> What do you expect to change? 02:37:54 <clokep> And yes, I looked it up and went to the website. 02:40:51 <clokep> Tobin: I'd encourage you not to really fork. It's better to have more people working together than to have 'separate' projects that splits a potential work force. 02:41:58 <Tobin> well the problem is with mozco going in directions we don't want to go 02:42:25 <clokep> I'm confused if you're talking about TB or Fx. 02:42:35 <Tobin> sort of both 02:42:41 <Tobin> not just application specific code 02:42:45 <Tobin> but backend shared code 02:42:53 <clokep> What sort of stuff don't you like? 02:43:05 <clokep> I could see not liking some of the interface changes...but the backend improvements... 02:43:20 <Tobin> the backend isn't acceptably stable anymore to us 02:43:42 <Tobin> also as far as comm projects go we want to build with our backend 02:46:04 <Tobin> as for applicable and desired improvements from mozilla we backport those 02:46:19 <EionRobb> what have you named your mozfork? 02:46:32 <Tobin> but i really didn't come in here to spread the Pale Moon gospel 02:46:55 <EionRobb> "Pale Moon"? aww, I'm sad it didn't start with the word "Fun" :( 02:47:02 <Tobin> Well it isn't mine.. Pale Moon and FossaMail are developed and published by Moonchild Productions 02:47:26 <clokep> Tobin: Well I'd appreciate if you upstream changes to chat, at least. 02:47:50 <Tobin> if we make any independent improvements to chat core of course 02:48:05 <Tobin> open source is a wonderful thing 02:57:09 <-- clokep has quit (Ping timeout: 121 seconds) 03:43:16 --> mconley has joined #instantbird 03:43:23 * redDragon|away is now known as redDragon 03:57:17 <instant-buildbot> build #2427 of macosx-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2427 04:11:59 <-- EionRobb has quit (Quit: Leaving.) 04:15:57 --> Tonnes has joined #instantbird 04:23:35 <instant-buildbot> build #1580 of win32-nightly-default is complete: Failure [4failed shell_6] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1580 04:32:19 <-- Rym has quit (Ping timeout: 121 seconds) 04:36:50 <instant-buildbot> build #1231 of linux-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1231 04:49:46 --> Hoony has joined #instantbird 04:52:19 <Hoony> Hi, All! is there anyway to see history of msgs on instantbird? 04:55:12 <-- Hoony has quit (Quit: ChatZilla 0.9.91 [Firefox 35.0a2/20141118004001]) 04:56:33 --> Hoony has joined #instantbird 04:58:42 --> Rym has joined #instantbird 05:02:24 <-- Hoony has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 05:03:10 <-- Rym has quit (Ping timeout: 121 seconds) 05:05:28 --> Hoony1 has joined #instantbird 05:19:03 <-- mconley has quit (Connection closed) 05:19:32 --> mconley has joined #instantbird 05:23:38 <-- mconley has quit (Ping timeout: 121 seconds) 05:33:59 --> Mook has joined #instantbird 05:45:40 <-- Hoony1 has quit (Client exited) 05:45:50 --> Hoony1 has joined #instantbird 05:46:24 <-- Hoony1 has quit (Client exited) 05:46:41 --> Hoony1 has joined #instantbird 05:48:10 --> EionRobb has joined #instantbird 05:52:50 --> Rym has joined #instantbird 05:57:20 <-- Rym has quit (Ping timeout: 121 seconds) 06:05:33 <-- Tobin has quit (Quit: Our job is to state the truth and let the facts attend to themselves.) 06:47:01 --> Rym has joined #instantbird 06:51:29 <-- Rym has quit (Ping timeout: 121 seconds) 06:58:33 <-- Mook has quit (Client exited) 07:27:16 --> DGMurdockIII has joined #instantbird 07:30:10 <flo-retina> EionRobb: "I'm sad it didn't start with the word "Fun"" lol ! :) 07:31:41 <EionRobb> :P 07:31:42 <EionRobb> hehehe 07:32:43 <EionRobb> I'm glad /someone/ got the joke! :D 07:33:20 <-- Fearful has left #instantbird () 07:34:23 <flo-retina> EionRobb: :) 07:36:54 <flo-retina> I guess understanding that means I've been around for too long? ;) 07:38:22 <flo-retina> EionRobb: btw, the same guy ended up packaging Instantbird for his linux distribution, because it was 'fun' to have an IM client with a 50+MB (or was it 80 or 100 already?) source tarball. 07:39:09 <EionRobb> ouch :) 07:41:07 --> Rym has joined #instantbird 07:45:39 <-- Rym has quit (Ping timeout: 121 seconds) 07:46:21 <instant-buildbot> build #127 of linux64-nightly-default is complete: Failure [4failed shell_5] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/127 07:51:23 <-- DGMurdockIII has quit (Quit: Leaving) 08:02:34 <flo-retina> I r+'ed the fix for the test failure that caused all our nightlies to fail this night 08:25:27 <-- Widdershins has quit (Ping timeout: 121 seconds) 08:26:04 <-- Tonnes has quit (Connection closed) 08:30:50 <-- Hoony1 has quit (Connection closed) 08:33:03 --> Hoony has joined #instantbird 08:35:18 --> Rym has joined #instantbird 08:39:48 <-- Rym has quit (Ping timeout: 121 seconds) 08:41:50 --> Defman has joined #instantbird 08:42:13 <-- Defman has quit (Quit: Bye) 08:42:15 --> Defman has joined #instantbird 08:45:42 * Fallen|away is now known as Fallen 09:12:56 --> Rym has joined #instantbird 09:15:13 --> gerard-majax has joined #instantbird 09:21:51 <-- Rym has quit (Ping timeout: 121 seconds) 09:29:02 --> Rym has joined #instantbird 09:39:17 <-- Hoony has quit (Client exited) 09:49:00 --> Tonnes has joined #instantbird 09:55:47 --> Bollebib has joined #instantbird 09:57:59 <-- Rym has quit (Ping timeout: 121 seconds) 10:05:23 <-- flo-linux has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:08:28 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:13:29 <-- Defman has quit (Quit: Bye) 10:23:26 --> aleth has joined #instantbird 10:23:26 * ChanServ sets mode +o aleth 10:24:46 --> Rym has joined #instantbird 10:26:28 --> Hoony1 has joined #instantbird 10:27:21 <instantbot> New Chat Core - General bug 1101453 filed by email@example.com. 10:27:22 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1101453 nor, --, ---, archaeopteryx, ASSI, unprefix '-moz-text-decoration' usage in /chat 10:29:16 <-- Rym has quit (Ping timeout: 121 seconds) 10:33:43 <-- Tonnes has quit (Ping timeout: 121 seconds) 10:35:24 --> Tonnes has joined #instantbird 10:42:36 * redDragon is now known as redDragon|away 10:43:51 <instantbot> firstname.lastname@example.org changed the Resolution on bug 1101453 from --- to DUPLICATE. 10:43:52 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1101453 nor, --, ---, archaeopteryx, RESO DUPLICATE, unprefix '-moz-text-decoration' usage in /chat 10:46:45 --> flo-retina has joined #instantbird 10:46:45 * ChanServ sets mode +qo flo-retina flo-retina 10:49:20 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:49:25 --> flo-retina has joined #instantbird 10:49:25 * ChanServ sets mode +qo flo-retina flo-retina 10:57:05 * Fallen is now known as Fallen|away 11:02:12 <-- EionRobb has quit (Quit: Leaving.) 11:14:51 * Fallen|away is now known as Fallen 11:18:55 --> Rym has joined #instantbird 11:23:25 <-- Rym has quit (Ping timeout: 121 seconds) 11:33:12 * redDragon|away is now known as redDragon 11:39:11 --> clokep has joined #instantbird 11:39:11 * ChanServ sets mode +o clokep 11:48:03 <clokep> flo-retina: That link he sent makes no sense, right? it's looking at the certificates/ciphers for google.com, not talk.google.com (or xmpp.google.com, which I think are the same) 11:48:25 <flo-retina> makes no sense to me, that's why I asked a question 11:48:32 <aleth> I don't get it either 11:48:42 <clokep> Yeah. OK. :) 11:48:49 <clokep> I wasn't sure if there was some weird XMPP magic I didn't understand. 11:50:00 <clokep> Huh, talk.g.c and xmpp.g.c ARE different servers. 11:50:32 <aleth> Huh indeed. 11:51:03 <aleth> So maybe s/talk/xmpp would actually do something 11:51:28 <clokep> You could try it. I'm going to be late for work. 11:51:45 <aleth> I don't have a gtalk account set up 11:51:48 <clokep> (aleth https://xmpp.net/result.php?domain=xmpp.google.com&type=client still has crappy ciphers) 11:51:54 <clokep> And https://xmpp.net/result.php?domain=talk.google.com&type=client fails, which is interesting to me 11:52:46 <aleth> Yes, I would assume it to fail differently. 11:53:22 <clokep> aleth: Thanks for the review. 11:54:21 <aleth> Using the full url directly is no use either https://xmpp.net/result.php?domain=xmpp.l.google.com&type=client 11:56:02 <clokep> "We currently support open federation with any service provider that supports the industry standard XMPP protocol. This includes Earthlink, Gizmo Project, Tiscali, Netease, Chikka, MediaRing, and thousands of other ISPs, universities, corporations and individual users." That's a lie. :( (from https://developers.google.com/talk/open_communications) 11:56:39 <aleth> "Last updated May 15, 2013" not even an excuse 12:00:27 <flo-retina> btw, now that we have OpenH264, can we hope to do video calls with gtalk? 12:00:38 <flo-retina> I guess I mean with gmail 12:00:44 <clokep> With hangouts? I doubt it. 12:00:47 <clokep> BBut, maybe. 12:01:29 <clokep> We should land that code before we start doing crazy things. :-D 12:13:05 --> Rym has joined #instantbird 12:14:57 <aleth> We should try it! 12:15:11 <aleth> Well, we should try with jitsi first, probably 12:16:16 <-- clokep has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:17:35 <-- Rym has quit (Ping timeout: 121 seconds) 12:37:08 <nhnt11> looks like my try build was green 12:37:31 <nhnt11> Except for os x, but I can confirm it's green locally (does that suffice?) 12:37:43 <-- aleth has quit (Ping timeout: 121 seconds) 12:38:11 <nhnt11> erm, when I say green I mean, the relevant tests passed. 12:41:34 --> aleth has joined #instantbird 12:41:34 * ChanServ sets mode +o aleth 12:42:15 <aleth> nhnt11: What was the problem on OSX? 12:42:42 <nhnt11> aleth: A weird build failure: https://tbpl.mozilla.org/php/getParsedLog.php?id=52931761&tree=Thunderbird-Try 12:42:56 <nhnt11> Not sure if that's the intermittent htat's already filed 12:43:23 <aleth> If TB tests are fine locally, then I think that'll be enough 12:47:58 <nhnt11> Bah, my Tb build is failing :-/ 12:48:19 <nhnt11> (posting a log in a sec..) 12:48:58 <nhnt11> http://pastebin.instantbird.com/1047573 12:49:09 <nhnt11> My purple repo is up to date 12:49:22 <aleth> Don't build TB together with libpurple 12:49:32 <aleth> TB doesn't ship it ;) 12:49:38 <nhnt11> d'oh 12:49:55 <aleth> It's an add-on that clokep has been struggling to update 12:50:03 <nhnt11> yeah, I know 12:50:07 <nhnt11> I just... forgot 12:50:09 <nhnt11> somehow 12:50:11 * nhnt11 should sleep 13:04:46 --> Rym has joined #instantbird 13:04:50 --> clokep_work has joined #instantbird 13:04:50 * ChanServ sets mode +o clokep_work 13:08:26 <clokep_work> aleth: Yes and I'd appreciate help> ;) 13:08:54 <aleth> Wasn't it working apart from Windows? 13:13:43 <clokep_work> aleth: It *built*, but I still need to create the extension. 13:13:52 <clokep_work> I also didn't test it. :-[ 13:15:22 * clokep_work wonders if aleth looked at his IRC buddy patch. ;) 13:17:23 <aleth> I haven't had time to properly think about it 13:23:48 <clokep_work> :) OK! 13:23:55 <-- BillBinkley has quit (Connection closed) 13:29:40 * redDragon is now known as redDragon|away 13:32:18 <nhnt11> Okay, I re-ran the tests after a clobber 13:32:22 <nhnt11> Looks fine 13:33:08 <nhnt11> oh crap, the patch wasn't applied :-/ 13:33:11 <nhnt11> bah 13:33:31 * nhnt11 runs them again 13:34:20 <flo-retina> I'm curious to see what a patch breaking tests when it's not applied would look like :) 13:35:36 <aleth> nhnt11: you should probably also test it looks and works the way you expect in your last comment on that bug by creating some split logs in TB. Maybe add a screenshot if that helps 13:35:39 <aleth> There's also at least one unaddressed nit from flo still in the bug 13:36:51 <clokep_work> aleth: "If you didn't create the fake buddy first, new ircAccountBuddy would create a 13:36:51 <clokep_work> buddy. But either way, the account buddy gets added to the database and never 13:36:51 <clokep_work> removed." I'm not sure I agree with that... 13:37:01 <clokep_work> ircAccountBuddy would not create a imBuddy instance. 13:37:15 <clokep_work> I don't know about the account buddy being stored in the database though, I have to look at that. 13:37:36 <nhnt11> aleth: Yeah, planning to do some manual testing in a bit 13:37:41 <nhnt11> make sure stuff still works as expected 13:37:51 <aleth> clokep_work: I'm thinking of http://dxr.mozilla.org/comm-central/source/chat/components/src/imContacts.js#1354, but maybe I'm misremembering how this works 13:38:12 <clokep_work> aleth: Right, I don't *want* that to get called. 13:38:22 <clokep_work> But I don't think that's run "automatically" anyway. 13:38:33 * clokep_work really has no idea how the contacts service works. :( 13:38:47 --> BillBinkley has joined #instantbird 13:39:47 <aleth> clokep_work: Hmm, you're right. I thought that was called in response to a notification, but it's the other way round 13:40:29 <aleth> So that makes things easier I guess :) 13:42:07 <aleth> The accountbuddy just doesn't get removed from the IRC prpl. 13:45:22 <clokep_work> aleth: Sorry I'm not following "just doesn't get removed from the IRC prpl"? 13:45:30 <clokep_work> You mean it's totally contained within that scope? 13:45:57 <aleth> Yes, I mean when the conversation is closed, that nick is still tracked etc 13:46:44 <aleth> Hmm, I wonder what happens to the fake buddy 13:47:39 <aleth> Hopefully it just gets gc'd 13:48:07 --> Armada has joined #instantbird 13:48:23 <aleth> But I doubt it. 13:48:55 <nhnt11> OK, those tests are done running, same results :) 13:49:39 <clokep_work> aleth: I'm fairly sure it will get removed, but I don't know for sure. Especially since the account has it... 13:50:53 <aleth> Probably also a good idea to look at the actual database with a sql viewer after shutdown 13:51:33 <aleth> (just to double check nothing was added there) 13:56:32 --> iamjayakumars has joined #instantbird 13:58:31 <clokep_work> Yep. :) 13:58:40 <clokep_work> Thanks for the feedback. 13:58:49 <clokep_work> I just wantd to make sure that the approach didn't seem hopeless. 13:59:08 <aleth> Thanks for tackling this :) 13:59:34 <aleth> I don't think it's hopeless, I just expect a lot of edge cases that have to be thought through... 13:59:40 <clokep_work> It was exciting to see it work when I opened a random conversation with nhnt11! 13:59:48 <aleth> :-) 14:00:23 <-- aleth has quit (Quit: :tuiQ) 14:00:26 <nhnt11> :) 14:00:34 <flo-retina> does that mean nhnt11 is not your buddy? :-P 14:00:52 <clokep_work> Not on my test account. ;) 14:00:58 <clokep_work> I have no buddies on this computer w/ gtalk not working. :'( 14:01:45 <flo-retina> sorry for making you feel friendless :( 14:01:55 --> aleth has joined #instantbird 14:01:55 * ChanServ sets mode +o aleth 14:04:39 <clokep_work> It wasn't your fault. :-D 14:04:50 <aleth> clokep_work: If it wasn't clear, I think you probably have to add logic to the imIBuddy that turns a dummy imIBuddy into a real one when appropriate. 14:06:46 <clokep_work> aleth: I agree. :) 14:06:54 <clokep_work> Like the _ensureNotDummyContact or whatever it's called. 14:07:00 <aleth> yeah. 14:09:01 <-- iamjayakumars has quit (Connection closed) 14:13:32 --> iamjayakumars has joined #instantbird 14:30:26 * Fallen is now known as Fallen|away 14:40:16 <-- aleth has quit (Ping timeout: 121 seconds) 14:49:19 --> aleth has joined #instantbird 14:49:19 * ChanServ sets mode +o aleth 14:59:36 --> mconley has joined #instantbird 15:16:01 <-- Hoony1 has quit (Client exited) 15:23:55 --> mpmc has joined #instantbird 15:31:11 --> sonny has joined #instantbird 15:55:10 --> qheaden has joined #instantbird 15:55:13 <qheaden> Hello all. 15:56:25 <clokep_work> Hello! 15:58:07 <-- iamjayakumars has quit (Connection closed) 15:58:13 --> iamjayakumars has joined #instantbird 16:00:09 <-- gerard-majax has quit (A TLS packet with unexpected length was received.) 16:01:56 --> gerard-majax has joined #instantbird 16:33:26 --> Defman has joined #instantbird 16:39:12 --> aleth1 has joined #instantbird 16:39:12 * ChanServ sets mode +o aleth1 16:39:51 <-- aleth has quit (Ping timeout: 121 seconds) 16:39:52 * aleth1 is now known as aleth 16:55:48 --> aleth1 has joined #instantbird 16:55:48 * ChanServ sets mode +o aleth1 16:56:22 <-- aleth has quit (Ping timeout: 121 seconds) 16:56:22 * aleth1 is now known as aleth 17:01:14 * redDragon|away is now known as redDragon 17:05:58 * Fallen|away is now known as Fallen 17:06:20 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 17:16:09 <-- nhnt11 has quit (Connection closed) 17:16:28 <-- iamjayakumars has quit (Connection closed) 17:16:52 --> iamjayakumars has joined #instantbird 17:17:36 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:18:11 <-- aleth has quit (Ping timeout: 121 seconds) 17:27:59 --> flo-retina has joined #instantbird 17:27:59 * ChanServ sets mode +qo flo-retina flo-retina 17:45:49 <-- Armada has quit (Connection closed) 17:52:39 --> myk has joined #instantbird 17:56:47 * redDragon is now known as redDragon|away 18:00:26 --> gerard-majax has joined #instantbird 18:01:49 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:05:26 * redDragon|away is now known as redDragon 18:12:03 --> Mook_as has joined #instantbird 18:20:57 <-- iamjayakumars has quit (Ping timeout: 121 seconds) 18:23:00 --> Even has joined #instantbird 18:23:00 * ChanServ sets mode +o Even 18:23:36 * redDragon is now known as redDragon|away 18:33:01 --> hadi has joined #instantbird 18:41:19 <-- sonny has quit (Ping timeout: 121 seconds) 18:49:22 --> aleth has joined #instantbird 18:49:22 * ChanServ sets mode +o aleth 19:04:04 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:04:29 --> nhnt11 has joined #instantbird 19:07:16 --> gerard-majax has joined #instantbird 19:16:22 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:20:18 --> gerard-majax has joined #instantbird 19:24:21 --> EionRobb has joined #instantbird 19:26:33 <-- gerard-majax has quit (Ping timeout: 121 seconds) 19:45:55 <-- Rym has quit (Ping timeout: 121 seconds) 19:46:24 --> sonny has joined #instantbird 19:46:31 --> Rym has joined #instantbird 19:50:57 <-- Rym has quit (Ping timeout: 121 seconds) 20:27:51 <-- Tonnes has quit (Connection closed) 20:29:56 --> Tonnes has joined #instantbird 20:32:24 --> unghost has joined #instantbird 20:37:24 --> Armada has joined #instantbird 20:39:47 <instantbot> email@example.com changed the Resolution on bug 1101311 from --- to FIXED. 20:39:48 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1101311 nor, --, ---, hiikezoe, RESO FIXED, TEST-UNEXPECTED-FAIL | /builds/slave/test/build/tests/xpcshell/tests/chat/modules/test/test_filterin 20:40:38 --> Rym has joined #instantbird 20:45:07 <-- Rym has quit (Ping timeout: 121 seconds) 20:55:46 <-- Mook_as has quit (Ping timeout: 121 seconds) 20:56:54 --> Mook_as has joined #instantbird 21:00:58 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 21:17:52 <-- clokep_work has quit (Ping timeout: 121 seconds) 21:34:27 --> Rym has joined #instantbird 21:39:23 <-- Rym has quit (Ping timeout: 121 seconds) 21:46:20 <-- Even has quit (Ping timeout: 121 seconds) 21:46:48 <-- myk has quit (Ping timeout: 121 seconds) 21:48:14 <-- Defman has quit (Quit: Bye) 21:48:55 --> myk has joined #instantbird 22:13:06 --> Even has joined #instantbird 22:13:06 * ChanServ sets mode +o Even 22:22:37 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 Ð¸Ð»Ð¸ ÑÑÐ°ÑÑÐµ)) 22:28:46 --> Rym has joined #instantbird 22:33:11 <-- Rym has quit (Ping timeout: 121 seconds) 22:39:36 <-- Bollebib has quit (Connection closed) 22:50:47 <-- hadi has quit (Ping timeout: 121 seconds) 22:55:17 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:00:26 <-- Even has quit (A TLS packet with unexpected length was received.) 23:00:29 --> Even has joined #instantbird 23:00:29 * ChanServ sets mode +o Even 23:01:09 <-- mconley has quit (Connection closed) 23:11:09 --> clokep has joined #instantbird 23:11:09 * ChanServ sets mode +o clokep 23:22:52 --> Rym has joined #instantbird 23:27:24 <-- Rym has quit (Ping timeout: 121 seconds) 23:37:43 <clokep> nhnt11, aleth: http://dutherenverseauborddelatable.wordpress.com/2014/11/19/the-future-of-promise/ 23:38:52 <clokep> As our resident Promise experts. ;) 23:39:09 <-- Armada has quit (Connection closed) 23:39:11 <aleth> we're on the right side of history ;) 23:39:26 <nhnt11> Ah, that's what Yoric was blogging about 23:39:46 <nhnt11> (he submitted a status to that statusbot thing they have on perf) 23:40:41 <clokep> You stalking him now? ;) 23:42:12 <aleth> statusbot pings are a big percentage of #perf traffic