All times are UTC.
00:04:11 <clokep> Meh this stuff has localized strings. 00:04:13 <clokep> That's annoying. 00:04:51 <arlolra> what stuff? 00:05:14 <clokep> libgpg-error 00:05:16 <arlolra> the urls can be found in the config files 00:05:17 <arlolra> https://gitweb.torproject.org/tor-messenger-build.git/blob/HEAD:/projects/libgcrypt/config 00:05:27 <arlolra> oh 00:09:11 <clokep_work> Yep. 00:09:15 <clokep_work> OK maybe tonight was aggressive. ;) 00:13:42 <arlolra> ha 00:13:46 <arlolra> :) 00:17:20 <arlolra> clokep: aleth had their first instantbird otr conversation just now 00:17:56 <aleth> :) 00:18:17 * Fallen|away is now known as Fallen 00:19:16 <-- arlolra has quit (Client exited) 00:19:34 <clokep> :) 00:19:35 <clokep> Sweet! 00:19:39 <clokep> It work? :P 00:20:30 <aleth> yes indeed 00:20:38 * clokep has seen some weird clipping in IB today. 00:20:41 <aleth> found a minor bug too ;) 00:20:45 <aleth> clipping? 00:20:59 <clokep> I'll try to get a screenshot. 00:21:19 <clokep> Well one that doesn't have private info in it. ;) 00:34:22 <-- myk has quit (Ping timeout: 121 seconds) 00:39:18 --> Rym has joined #instantbird 00:40:12 <-- Rym has quit (Quit: WeeChat 1.0) 00:40:23 --> Rym has joined #instantbird 00:44:59 <clokep> Umm...serious.y 00:45:06 <clokep> This uses awk scripts to generate header files? 00:45:06 <clokep> WTF. 00:52:28 <-- Armada has quit (Connection closed) 00:56:24 <-- aleth has quit (Ping timeout: 121 seconds) 01:00:30 <-- clokep_work has quit (Ping timeout: 121 seconds) 01:13:32 <-- sonny has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 01:36:34 <-- Mook_as has quit (Client exited) 02:10:44 <DGMurdockIII> is otr going to be built in to instantbird by defult 02:11:48 <clokep> Yes. 02:14:17 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 02:15:50 <-- clokep has quit (Ping timeout: 121 seconds) 02:36:25 <-- Rym has quit (Ping timeout: 121 seconds) 02:57:27 <DGMurdockIII> yippe 03:01:55 --> Rym has joined #instantbird 03:02:36 --> mconley has joined #instantbird 03:08:50 <-- Rym has quit (Ping timeout: 121 seconds) 03:24:14 <-- mconley has quit (Connection closed) 03:41:40 --> sherief has joined #instantbird 03:44:01 <-- sherief has quit (A TLS packet with unexpected length was received.) 03:52:22 <instant-buildbot> build #1203 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1203 03:56:34 --> Rym has joined #instantbird 03:57:38 <-- EionRobb has quit (Quit: Leaving.) 04:00:47 <-- gerv has quit (Ping timeout: 121 seconds) 04:01:01 <-- Rym has quit (Ping timeout: 121 seconds) 04:02:08 <instant-buildbot> build #2399 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2399 04:07:58 --> gerv has joined #instantbird 04:16:39 <instant-buildbot> build #1561 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1561 04:27:10 --> mconley has joined #instantbird 04:43:03 <-- mconley has quit (Connection closed) 04:50:36 --> Rym has joined #instantbird 04:55:03 <-- Rym has quit (Ping timeout: 121 seconds) 04:55:10 --> Bollebib has joined #instantbird 05:07:13 <instant-buildbot> build #99 of linux64-nightly-default is complete: Failure [4failed compile] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/99 05:19:43 --> EionRobb has joined #instantbird 05:34:47 --> Widdershins has joined #instantbird 05:40:22 <-- Bollebib has quit (Ping timeout: 121 seconds) 05:44:45 --> Rym has joined #instantbird 05:49:14 <-- Rym has quit (Ping timeout: 121 seconds) 05:56:03 --> gerard-majax has joined #instantbird 06:12:05 --> Widders has joined #instantbird 06:13:03 <-- Widdershins has quit (Ping timeout: 121 seconds) 06:19:37 <-- gerv has quit (Ping timeout: 121 seconds) 06:38:52 --> Rym has joined #instantbird 06:43:23 <-- Rym has quit (Ping timeout: 121 seconds) 06:54:42 --> myk has joined #instantbird 07:20:35 <-- gerard-majax has quit (Ping timeout: 121 seconds) 07:23:43 --> sherief has joined #instantbird 07:33:04 --> Rym has joined #instantbird 07:37:14 <-- myk has quit (Ping timeout: 121 seconds) 07:37:32 <-- Rym has quit (Ping timeout: 121 seconds) 07:54:16 --> aleth has joined #instantbird 07:54:16 * ChanServ sets mode +o aleth 07:55:15 --> gerard-majax has joined #instantbird 07:59:53 <-- aleth has quit (Quit: Failures of imagination are mistaken for insights into necessity. -- Dennett) 07:59:56 --> aleth has joined #instantbird 07:59:56 * ChanServ sets mode +o aleth 08:02:02 <aleth> clokep: you starred everything but didn't push? ;) 08:12:06 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:25:55 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:26:02 --> nhnt11 has joined #instantbird 08:27:15 --> Rym has joined #instantbird 08:27:19 <-- Tonnes has quit (Connection closed) 08:28:13 * Fallen is now known as Fallen|away 08:31:41 <-- Rym has quit (Ping timeout: 121 seconds) 08:32:44 <instantbot> New Chat Core - General bug 1088557 filed by aleth@instantbird.org. 08:32:45 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1088557 nor, --, ---, nobody, NEW, Update libpurple up to 2.10.10 08:33:18 --> flo-retina has joined #instantbird 08:33:18 * ChanServ sets mode +qo flo-retina flo-retina 08:43:05 <-- Widders has quit (Ping timeout: 121 seconds) 09:21:24 --> Rym has joined #instantbird 09:25:53 <-- Rym has quit (Ping timeout: 121 seconds) 09:34:00 <aleth> once you don't restart for a few days, you *really* want split logs 09:34:30 <flo-retina> I do! ;) 09:38:50 * redDragon|away is now known as redDragon 09:42:50 * redDragon is now known as redDragon|away 09:45:26 --> BWMerlin has joined #instantbird 09:50:15 --> Tonnes has joined #instantbird 09:51:50 <-- EionRobb has quit (Quit: Leaving.) 10:15:34 --> Rym has joined #instantbird 10:20:03 <-- Rym has quit (Ping timeout: 121 seconds) 10:21:30 --> clokep has joined #instantbird 10:21:30 * ChanServ sets mode +o clokep 10:31:13 <instantbot> clokep@gmail.com changed the Resolution on bug 1088557 from --- to DUPLICATE. 10:31:14 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1088557 nor, --, ---, nobody, RESO DUPLICATE, Update libpurple up to 2.10.10 10:33:36 <flo-retina> clokep: is our plan to update to 2.10.9 and then 2.10.10, or both at once? 10:33:44 <aleth> Huh, I wonder why bugzilla didn't find that for me? :-S 10:34:01 <clokep> flo-retina: Whichever way is easier to review the patches. ;) 10:34:04 <aleth> oh, you retitled it 10:34:07 <clokep> But we can throw it all in one bug IMO. 10:34:11 <clokep> That's what we used to do. :-D 10:36:13 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 10:36:20 --> flo-retina has joined #instantbird 10:36:20 * ChanServ sets mode +qo flo-retina flo-retina 10:36:32 <-- flo-retina has quit (Connection closed) 10:36:39 --> flo-retina has joined #instantbird 10:36:39 * ChanServ sets mode +qo flo-retina flo-retina 10:38:15 <clokep> Anyone have thoughts on? https://bug1084109.bugzilla.mozilla.org/attachment.cgi?id=8510825 10:38:17 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1084109 nor, --, ---, nobody, NEW, displayStatusText() is not implemented in Thunderbird 10:38:29 * clokep should probably ask the TB UI guys. :P 10:39:14 <aleth> For this particular case his suggestion with the reply-to above the input box is actually quite good 10:39:40 <aleth> I'm worried about what else it might be used for if we introduce it though... 10:40:04 <aleth> But that seems a bad reason not to do it 10:40:14 <flo-retina> I'm worried about layout issues, ie. how many bugs could this introduce in small windows. 10:40:26 <flo-retina> but the suggestion makes sense 'on the provided image' 10:40:53 <aleth> I still think light gray text inside the input box on the bottom left is the way to go for this 10:41:15 <aleth> No border or background or anything 10:41:19 <flo-retina> makes more sense to display that above than at the bottom 10:41:49 <aleth> It does - for this particular case his suggestion looks better 10:41:52 <flo-retina> aleth: if we actually add that line of text above the textbox, I wouldn't mind using it for a status reminder 10:42:28 <aleth> We could avoid edge cases with a min-height on the browser 10:42:37 <flo-retina> ie. "Your status is currently set to away, consider setting it to available before talking to avoid training people to ignore your status." 10:42:50 --> mpmc has joined #instantbird 10:43:06 <flo-retina> hopefully someone can come up with a much shorter wording :-S 10:43:15 <aleth> Oh right, that's another thing we wanted to put "somewhere" 10:44:42 --> clokep_work has joined #instantbird 10:44:42 * ChanServ sets mode +o clokep_work 10:44:47 <aleth> And a case where I really disliked how it looked with the text in the input box 10:45:06 <aleth> So I guess if we're all agreed I can reply in the bug that we like his suggestion and point out what to look out for? 10:45:13 <clokep> Sure. 10:46:10 <flo-retina> yeah, we like his suggestion assuming he can get it to work right 10:46:39 <flo-retina> aleth: I liked coloring the background of the input box, but I disliked the text displayed inside the box 10:46:52 <aleth> Same here 10:47:10 <flo-retina> would be cool to finally integrate that feature at some point :) 10:47:42 <aleth> One of Mic's bugs I believe 10:51:01 <flo-retina> ... 11:02:54 --> Rym has joined #instantbird 11:04:36 <clokep_work> arlolra: https://bitbucket.org/clokep/comm-central-patches/raw/83d5268aa63c4138c9bc7b1b90ed5ef84ed87f4a/otr-libs 11:12:54 <aleth> clokep_work: Here's what bitbucket's interview says about that patch: "While impressive, your diff is just too big!" :P 11:13:00 <aleth> s/interview/interface 11:13:23 <clokep> :) 11:14:19 <flo-retina> does that mean I'll have a giant patch in my review queue soon? :-S 11:15:13 <aleth> I don't think you have to review libgcrypt ;) 11:15:18 <flo-retina> I don't think we'll want to include the Makefile.am and Makefile.in.old files 11:15:23 <flo-retina> aleth: I think I do 11:15:45 <flo-retina> aleth: I mean... not fully. But just look at what it does, to ensure it won't mess with other parts of Mozilla 11:16:04 <aleth> Right. 11:16:04 <flo-retina> aleth: especially I/we should look for things involving threads, forks and disk I/O 11:16:26 <clokep> flo-retina: We won't, but it was easier to include them in my mq. ;) 11:16:29 <clokep> That patch also doesn't build. 11:16:40 <flo-retina> that may also be a problem :-D 11:26:32 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:26:36 --> clokep_work has joined #instantbird 11:26:36 * ChanServ sets mode +o clokep_work 11:48:20 --> Armada has joined #instantbird 12:02:02 <-- aleth has quit (Ping timeout: 121 seconds) 12:03:54 --> aleth has joined #instantbird 12:03:54 * ChanServ sets mode +o aleth 12:17:36 <-- aleth has quit (Ping timeout: 121 seconds) 12:29:19 --> clokep_js has joined #instantbird 12:29:32 * clokep_js wonders how many times he can join the same channel. ;) 12:32:33 <-- clokep_js has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 12:32:35 --> clokep_js has joined #instantbird 12:32:57 <-- clokep_js has quit (Connection closed) 12:42:19 --> aleth has joined #instantbird 12:42:19 * ChanServ sets mode +o aleth 12:42:30 <clokep> aleth: Hopefully that's not scary. :) 12:48:56 <aleth> clokep: well, at least searching for 'origin' will be more unique than searching for 'name' ;) 12:54:07 --> Armada651 has joined #instantbird 12:54:13 <-- Armada651 has quit (Connection closed) 12:54:40 <clokep> aleth: True. :) Does "origin" vaguely make sense? 12:54:49 <aleth> clokep: yes 12:55:23 <aleth> The biggest risk here is that some .nickname wasn't picked up or picked up by mistake 12:57:17 <-- Armada has quit (Ping timeout: 121 seconds) 13:01:12 --> chrisccoulson has joined #instantbird 13:09:55 <clokep> Or extensions. 13:16:30 <aleth> I don't think there are many IRC extensions 13:31:58 --> mconley has joined #instantbird 13:47:31 <clokep> Are there (m)any not written by me? ;) 14:02:48 <clokep> Huh, that patch's scope grew a lot 14:02:57 <-- BWMerlin has quit (Client exited) 14:04:47 <-- aleth has quit (Ping timeout: 121 seconds) 14:27:52 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 14:30:48 --> sawrubh has joined #instantbird 14:46:55 --> myk has joined #instantbird 14:47:53 --> aleth has joined #instantbird 14:47:53 * ChanServ sets mode +o aleth 15:00:07 <clokep_work> aleth: Did you not see the change I made inside the constructor? :-S 15:00:23 <clokep_work> I don't understand your comments. 15:00:28 <clokep_work> "if you agree, update the comment" 15:01:25 <aleth> That refers to my suggestion of changing the uninitialized value of currentservername 15:01:33 <aleth> Since you now pass it to the ircMessage constructor. 15:01:54 <aleth> Of course if we prefer the occasional "null" that doesn't matter. 15:02:14 --> iamjayakumars has joined #instantbird 15:02:19 <clokep_work> aleth: But...I set it in the account constructor...? 15:02:21 <clokep_work> I don't understand. 15:02:41 <aleth> aOrigin can be null 15:02:45 <clokep_work> No it cannot. 15:02:49 <aleth> Why? 15:02:58 <clokep_work> I set _currentServerName RIGHT below where you commented. 15:03:18 <clokep_work> this._currentServerName = this._server; 15:03:20 <clokep_work> In that patch. 15:03:35 <aleth> ah sorry I misunderstood the context of that, that's the *account constructor* 15:03:36 --> qheaden has joined #instantbird 15:03:41 <qheaden> Hello all. 15:03:57 <aleth> I thought we only did it on connection 15:04:09 <aleth> OK, so ignore that, sorry. 15:04:52 <aleth> Sometimes the amount of context isn't big enough to see where exactly in the code we are ;) 15:05:20 * aleth too much multitasking 15:05:21 <clokep_work> aleth: No problem, as long as we're both confused. ;) 15:05:52 <clokep_work> aleth: I mean I can still set it to "" instead of null, if you'd like, but I don't see a big difference in those. null might actually be preferred as it will fail harder while "" might hide things. 15:06:05 <aleth> Yeah no, in that case we don't need to change it 15:06:19 <aleth> I misremembered and thought it was set on handling 001 or something 15:06:45 <aleth> The only real r- reason was the "nickname" issue anyway 15:07:21 <clokep_work> aleth: It *is* set in the 001 handler, that's what that comment is referring to! 15:07:26 <clokep_work> Maybe that comment is poorly worded. 15:07:51 <aleth> clokep_work: No, it's fine. Never mind. 15:10:33 <-- myk has quit (Connection closed) 15:10:46 --> myk has joined #instantbird 15:16:48 --> myk1 has joined #instantbird 15:17:00 <-- myk has quit (Ping timeout: 121 seconds) 15:20:58 <aleth> clokep_work: What did you think of bug 1087566? 15:21:01 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1087566 nor, --, ---, aleth, ASSI, Automatically try to get your nick back if it's still in use on connecting 15:21:19 <clokep_work> aleth: I think it's an r-. ;) 15:21:45 <clokep_work> But because you change a string w/o changing the property name. 15:21:53 <clokep_work> I haven't given the rest a good look yet. 15:21:57 <clokep_work> THat's why I didn't comment. :) 15:22:04 --> myk has joined #instantbird 15:22:28 <aleth> Haha. That was intentional actually, I only improved the en-* wording, not the meaning. 15:22:52 <aleth> Well, imho it would be an improvement ;) 15:23:02 <-- myk1 has quit (Ping timeout: 121 seconds) 15:25:13 <flo-retina> I almost made the same comment, and then guessed it was probably intentional 15:25:56 --> myk1 has joined #instantbird 15:26:16 <-- myk has quit (Ping timeout: 121 seconds) 15:26:20 <aleth> Ah, those are more interesting reasons for r- ;) 15:30:00 <clokep_work> aleth: Ah, in that case I guess it's OK. 15:30:08 <clokep_work> But yeah...the other things are the real reason. :) 15:30:32 <aleth> I had the niggling feeling when I wrote it that I must be overlooking some edge case... 15:32:27 <clokep_work> Well...it is IRC. :-D 15:32:34 * redDragon|away is now known as redDragon 15:32:37 <clokep_work> aleth: What about...not using a timer? 15:32:43 <clokep_work> And adding something to the QUIT handler? 15:33:11 <clokep_work> if oldNick quits and message contains "ping timeout" and last login time < 2.5 minutes? 15:33:56 <aleth> I didn't want to rely on "message contains ping timeout" but hmm... maybe old nick quits is actually enough 15:34:04 <aleth> Since we know if we were previously connected with it 15:34:11 <-- myk1 has quit (Ping timeout: 121 seconds) 15:34:20 <clokep_work> Yep. :) 15:34:21 <aleth> Unless it was a restart of IB of course ;) 15:34:33 <clokep_work> Welllllllll your timer won't run there either. :P 15:34:45 <aleth> It will 15:34:49 <clokep_work> Write to a pref? ;) 15:35:09 <aleth> now that's overkill ;) 15:35:36 <aleth> I'm not bothered by restarts actually as those should send QUIT 15:35:55 <aleth> We used to have a bug there but I haven't seen it in a long time 15:36:03 <-- gerard-majax has quit (Ping timeout: 121 seconds) 15:36:31 <clokep_work> Hmm...don't we have a "requested nickname" anyway? 15:36:32 --> Bollebib has joined #instantbird 15:36:36 <clokep_work> So I think you can really do it without the timer. 15:36:40 <clokep_work> I'm not sure if it's worth the effort though. 15:36:46 <aleth> I'll take a look 15:37:01 <clokep_work> Don't waste too much time. 15:41:09 * redDragon is now known as redDragon|away 15:44:06 <-- clokep has quit (Ping timeout: 121 seconds) 15:49:06 <-- clokep_work has quit (Ping timeout: 121 seconds) 15:57:04 <-- DGMurdockIII has quit (Connection closed) 15:57:15 --> DGMurdockIII has joined #instantbird 16:01:12 --> myk has joined #instantbird 16:10:27 --> gerard-majax has joined #instantbird 16:12:55 <-- Bollebib has quit (Ping timeout: 121 seconds) 16:21:09 --> Bollebib has joined #instantbird 16:24:17 --> arlolra has joined #instantbird 16:30:35 <-- gerard-majax has quit (Ping timeout: 121 seconds) 16:34:33 --> gerard-majax has joined #instantbird 16:41:12 <-- chrisccoulson has quit (Ping timeout: 121 seconds) 16:43:42 <-- sawrubh has quit (Quit: Connection closed for inactivity) 16:45:15 <-- Bollebib has quit (Ping timeout: 121 seconds) 16:45:23 --> Mook_as has joined #instantbird 16:45:28 * redDragon|away is now known as redDragon 16:48:25 * redDragon is now known as redDragon|away 16:50:05 <-- arlolra has quit (Client exited) 16:50:44 --> arlolra has joined #instantbird 16:58:40 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:01:45 <instantbot> New Instantbird - Conversation bug 1088772 filed by arlolra@gmail.com. 17:01:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1088772 nor, --, ---, nobody, UNCO, null 17:03:43 --> Bollebib has joined #instantbird 17:08:49 <flo-retina> aleth: I'm surprised we didn't mid-air! :) 17:09:22 <aleth> I was intrigued by the title :) 17:13:13 --> gerard-majax has joined #instantbird 17:30:05 <arlolra> should the test suite be ran with `make -C objdir xpcshell-tests` or `./mozilla/mach xpcshell-test`? 17:30:42 <flo-retina> I think only the former works 17:31:37 <-- gerard-majax has quit (Ping timeout: 121 seconds) 17:33:46 <arlolra> hmm, it seems like it really wants to test purplexpcom even though I built without it 17:34:00 <flo-retina> it does 17:34:03 <arlolra> IOError: Included file 'comm-central/obj-x86_64-apple-darwin14.0.0/_tests/xpcshell/extensions/purple/purplexpcom/src/test/xpcshell.ini' 17:34:13 <flo-retina> nhnt11 had the same problem last week :( 17:34:37 <arlolra> it that something I can easily fix 17:35:02 <arlolra> or is my time better spent elsewhere 17:39:03 <flo-retina> arlolra: just removing the last line of http://mxr.mozilla.org/comm-central/source/im/test/xpcshell.ini should let you run the other tests 17:51:50 <-- iamjayakumars has quit (Quit: ) 17:52:11 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:01:59 * aleth is now known as aleth-build 18:22:09 --> flo-retina has joined #instantbird 18:22:09 * ChanServ sets mode +qo flo-retina flo-retina 18:28:43 <-- mconley has quit (Connection closed) 18:29:16 --> aleth-build1 has joined #instantbird 18:29:42 <-- aleth-build has quit (Ping timeout: 121 seconds) 18:30:44 * aleth-build1 is now known as aleth-build 18:32:32 --> Armada has joined #instantbird 18:34:44 <-- nhnt11 has quit (Connection closed) 18:41:36 * aleth-build is now known as aleth 18:41:37 * ChanServ sets mode +o aleth 18:49:27 --> clokep_wp8 has joined #instantbird 18:50:07 <clokep_wp8> arlolra: Don't bother I spent a while the other day trying to fix this and couldn't. 18:50:12 <-- clokep_wp8 has quit (Connection closed) 18:52:12 * aleth is now known as aleth-build 18:52:25 * aleth-build is now known as aleth 18:56:12 * aleth is now known as aleth-build 18:56:27 * aleth-build is now known as aleth 18:57:03 * aleth is now known as aleth-build 18:57:07 <-- aleth-build has quit (Quit: Failures of imagination are mistaken for insights into necessity. -- Dennett) 18:57:16 --> aleth has joined #instantbird 18:57:16 * ChanServ sets mode +o aleth 19:11:09 <-- myk has quit (Ping timeout: 121 seconds) 19:13:47 <-- arlolra has quit (Client exited) 19:15:47 --> arlolra has joined #instantbird 19:24:30 <-- flo-retina has quit (Ping timeout: 121 seconds) 19:24:33 <-- Armada has quit (Quit: Leaving) 19:25:48 --> Armada has joined #instantbird 19:26:27 --> flo-retina has joined #instantbird 19:26:27 * ChanServ sets mode +qo flo-retina flo-retina 19:28:35 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 19:55:51 <-- Rym has quit (Ping timeout: 121 seconds) 20:01:12 --> mpmc has joined #instantbird 20:05:27 <-- Armada has quit (Quit: Leaving) 20:14:20 --> myk has joined #instantbird 20:15:35 <flo-retina> random guess of the evening: XPC_WN_NoMods_NoCall_Proto_JSClass may be when the prototype of an object has a wrapper because it's coming from another compartment (ie. jsProtoHelper). 20:15:41 <flo-retina> aleth: ^^ 20:16:25 <aleth> interesting idea 20:16:26 * aleth checks 20:16:51 <aleth> Can't explain the roominfo case, at least: http://dxr.mozilla.org/comm-central/source/chat/protocols/irc/ircBase.jsm#36 20:17:12 <flo-retina> if that guess is correct, loading jsProtoHelper as a subscript instead of importing it as a module may make a huge difference 20:17:39 <flo-retina> aleth: how so? ClassInfo is definitely coming from imXPCOMUtils.jsm 20:17:54 <aleth> Now *that* is an idea 20:18:03 <aleth> Subscript-load XPCOMutils? 20:18:10 <flo-retina> and jsProtoHelper 20:19:27 <aleth> I still haven't figured out if we have similar huge memory costs for all the prplIMessage objects we keep references to. If you're right, that would help with those too 20:22:07 <aleth> Well, it would lead to a bug being filed for njn so we don't need the hack ;) 20:22:39 --> Rym has joined #instantbird 20:24:03 <flo-retina> aleth: that bug would become a P2 anyway ;) 20:27:02 <-- Rym has quit (Ping timeout: 121 seconds) 20:27:48 <aleth> Not as trivial to check as it sounds... all sorts of stuff breaks because of stuff like "redeclaration of const Cc" 20:28:49 <flo-retina> aleth: I wonder if we could change that ClassInfo implementation to use https://developer.mozilla.org/en-US/docs/Components.utils.createObjectIn 20:30:42 <flo-retina> or maybe https://developer.mozilla.org/en-US/docs/Components.utils.makeObjectPropsNormal 20:31:43 <aleth> How exactly does the second function achieve that, I wonder 20:31:59 <flo-retina> I'm afraid it doesn't applies to the prototype 20:32:12 <aleth> ah 20:32:19 <flo-retina> aleth: for stuff that's implemented all in JS behind the wrappers, I think it copies the implementation to the object's compartment 20:32:25 --> Armada has joined #instantbird 20:34:36 <aleth> "you can create an object in a different compartment using new" -> maybe we just need to replace ClassInfo with "new Classinfo" where possible, at least to test 20:35:44 <arlolra> aleth, flo-retina: is this on the right track? https://gist.github.com/arlolra/13826d934d02c2e6f379 20:36:59 <aleth> TypeError: redeclaration of const EXPORTED_SYMBOLS - bah, there's just too much to work around trying to use subscriptloader 20:40:31 <aleth> arlolra: Why are you using Tasks there? 20:41:26 --> Rym has joined #instantbird 20:41:28 <aleth> Not that it matters I guess 20:41:39 <arlolra> aleth: oh, I was looking at the logging tests but I suppose that's only using them to yield to the OS 20:41:54 <arlolra> so, for no particular reason 20:42:13 <aleth> The logging tests use them because logging is async (file I/O is async) 20:42:35 <arlolra> yes, that's the yield in the line i wrote above 20:44:55 <aleth> I'm a bit puzzled by test_message_transformation 20:45:14 <arlolra> it's incomplete 20:45:18 <aleth> I guess that's a WIP 20:45:28 <arlolra> yes 20:45:53 <arlolra> was just wondering if I was way off base with this 20:45:56 <aleth> |iMsg.message = ""; equal(iMsg.message, "");| also needs a comment 20:46:02 <aleth> No, it looks like a good start 20:46:43 <arlolra> ok, thanks 20:46:44 <aleth> Ideally you want to test individual functions you have added, and if you can also test their working together 20:47:11 <aleth> chat/irc also has a bunch of tests that might make good examples 20:48:25 <flo-retina> aleth: for a test you can just copy paste the ClassInfo implementation directly to where it's needed 20:53:06 <-- myk has quit (Ping timeout: 121 seconds) 20:59:30 <aleth> flo-retina: So... that doesn't seem to make any difference at all. 21:00:08 <flo-retina> aleth: do you mean in the total amount of memory used, or in the amount of XPC_WN_NoMods_NoCall_Proto_JSClass memory used? 21:01:15 <aleth> Both 21:02:43 <aleth> http://pastebin.mozilla.org/6889833 21:04:59 <flo-retina> would be easier to look at a diff 21:05:16 <flo-retina> assuming you can reliably reproduce the situation before and after 21:05:34 <aleth> The situation before will be in the statsmemory bug 21:06:03 <flo-retina> you need a full about:memory dump to use the diff feature 21:06:03 <aleth> There's some variation between runs of course. 21:06:52 <aleth> Well, I can make a diff, but I don't think it will be interesting. It will take time because freenode keeps timeouting me for too much LIST ;) 21:07:48 <flo-retina> :( 21:08:02 <flo-retina> we really need to make reproducible test cases that can run in xpcshell without internet connexion 21:08:19 <aleth> yes 21:10:54 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 21:24:23 --> myk has joined #instantbird 21:25:33 <aleth> Diff https://pastebin.mozilla.org/6890132 21:26:13 <aleth> Something weird about that... 21:27:06 <flo-retina> looks like there's absolutely no difference there 21:28:02 <aleth> Right, the biggest item in the diff is about:memory 21:47:18 --> EionRobb has joined #instantbird 21:54:41 * redDragon|away is now known as redDragon 22:17:31 * redDragon is now known as redDragon|away 22:21:35 --> BWMerlin has joined #instantbird 22:31:26 * redDragon|away is now known as redDragon 22:32:05 * redDragon is now known as redDragon|away 22:32:15 * redDragon|away is now known as redDragon 23:08:25 <-- myk has quit (Ping timeout: 121 seconds) 23:16:46 <-- aleth has quit (Ping timeout: 121 seconds) 23:17:53 <-- DGMurdockIII has quit (Quit: Leaving) 23:33:14 --> aleth has joined #instantbird 23:33:14 * ChanServ sets mode +o aleth