#instantbird log on 09 22 2014

All times are UTC.

00:07:47 <-- mpmc has quit (Client exited)
00:12:09 --> clokep has joined #instantbird
00:12:09 * ChanServ sets mode +o clokep 
00:25:47 <-- clokep has quit (Ping timeout)
00:27:17 --> myk has joined #instantbird
00:33:07 --> hadi has joined #instantbird
00:35:12 <-- myk has quit (Ping timeout)
00:46:51 --> clokep has joined #instantbird
00:46:51 * ChanServ sets mode +o clokep 
01:25:26 <-- hadi has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:41:30 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
01:42:45 --> mconley_ has joined #instantbird
01:58:36 --> vivekg has joined #instantbird
02:45:43 <-- mconley_ has quit (Input/output error)
02:46:11 --> mconley_ has joined #instantbird
02:47:57 <-- mconley_ has quit (Ping timeout)
03:41:07 <instant-buildbot> build #1525 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1525
03:50:57 <instant-buildbot> build #1167 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1167
03:52:16 <instant-buildbot> build #2357 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2357
04:31:35 <instant-buildbot> build #62 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/62
05:17:20 <-- gerard-majax has quit (Ping timeout)
05:19:25 --> myk has joined #instantbird
05:54:10 <-- EionRobb has quit (Quit: Leaving.)
06:01:33 --> gerard-majax has joined #instantbird
06:06:03 <-- gerard-majax has quit (Ping timeout)
06:13:22 --> gerard-majax has joined #instantbird
06:23:09 <-- gerard-majax has quit (Ping timeout)
06:39:22 --> gerard-majax has joined #instantbird
06:41:18 <-- gerard-majax has quit (Ping timeout)
07:25:04 * Fallen|away is now known as Fallen
07:27:22 --> petunia has joined #instantbird
07:38:30 <-- petunia has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
07:49:07 --> sonny has joined #instantbird
07:59:58 --> Bollebib has joined #instantbird
08:08:55 --> gerard-majax has joined #instantbird
08:16:44 --> sherief has joined #instantbird
08:30:12 * Fallen is now known as Fallen|away
09:01:53 <-- gerard-majax has quit (Quit: Ex-Chat)
09:02:31 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:02:48 --> chrisccoulson has joined #instantbird
09:07:07 --> gerard-majax has joined #instantbird
09:21:20 <-- nhnt11 has quit (Ping timeout)
09:41:27 <-- myk has quit (Ping timeout)
09:52:50 --> flo-retina has joined #instantbird
09:52:50 * ChanServ sets mode +qo flo-retina flo-retina 
10:04:57 * Fallen|away is now known as Fallen
10:11:15 --> nhnt11 has joined #instantbird
10:15:02 --> clokep has joined #instantbird
10:15:02 * ChanServ sets mode +o clokep 
10:21:38 --> mpmc has joined #instantbird
10:25:38 <-- nhnt11 has quit (Ping timeout)
11:14:45 <-- clokep has quit (Ping timeout)
11:22:40 --> hadi has joined #instantbird
12:09:11 --> clokep_work has joined #instantbird
12:09:12 * ChanServ sets mode +o clokep_work 
12:13:38 <-- flo-retina has quit (Ping timeout)
12:14:43 --> flo-retina has joined #instantbird
12:14:43 * ChanServ sets mode +qo flo-retina flo-retina 
12:16:47 <-- BWMerlin has quit (Quit: BWMerlin)
12:25:02 --> aleth has joined #instantbird
12:25:02 * ChanServ sets mode +o aleth 
12:31:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
12:57:39 <instantbot> New Instantbird - Other bug 1070953 filed by aleth@instantbird.org.
12:57:40 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1070953 nor, --, ---, nobody, NEW, Message style preview is broken
12:58:41 <flo-retina> aleth: I'm confused, how can something be a regression from a bug that hasn't landed yet? :)
12:58:59 <aleth> That happens when you make an error with copy/paste ;)
13:02:17 <flo-retina> ah, that makes more sense, thanks! :)
13:02:52 --> hadi1 has joined #instantbird
13:03:18 <-- hadi1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
13:03:40 <-- hadi has quit (Ping timeout)
13:03:46 <flo-retina> btw, aleth++ for writing a comment saying exactly what I would have said in bug 736002 :)
13:03:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=736002 enh, --, ---, nobody, NEW, The editor for twitter should show inputtable character count
13:04:42 <aleth> Glad you agree :)
13:09:01 <clokep_work> Yeah the whole input box sounds excessive.
13:09:06 * clokep_work just caught up on that issue.
13:10:16 <flo-retina> I think we are just trying to be nice here and are restraining ourselves to one negative comment on the approach at each review iteration :-].
13:10:39 <flo-retina> but otherwise it seems all of us are in agreement about what's really desired
13:11:03 <clokep_work> I don't really like the styling of the character counter, but eh. ;)
13:11:11 <clokep_work> Do we care about text being hidden behind it?
13:11:17 <aleth> I'm not sure about the TB UI guys, but hopefully we can get there ;)
13:11:18 <flo-retina> btw, changing the blue focus outline to red in Instantbird too when we are over the max length would be cool :)
13:11:47 <aleth> Ideally the result of that bug would then be to have the same in IB.
13:12:10 <flo-retina> clokep_work: some TB UX person said that text being hidden behind the counter is unlikely because that box is always huge.
13:12:23 <flo-retina> While not an excellent reason, it's mostly true for TB. Probably not as much for Ib :-/
13:12:39 <aleth> flo-retina: It's another case of thinking too much of Twitter
13:14:06 <clokep_work> Anyone have a better variable name besides "limitWarning"?
13:14:32 <flo-retina> we don't need that warning at all
13:14:45 <flo-retina> but maybe that name is used for all cases (I haven't looked recently at the code)
13:14:55 <clokep_work> Ah, was that just for the background color?
13:15:00 <clokep_work> It is used for all cases.
13:15:04 <clokep_work> That's why I want a different name. ;)
13:15:34 * flo-retina doesn't have any good suggestion to offer right now :-/
13:16:14 * clokep_work wants to use something vague like "inputStatus"
13:16:43 <-- sherief has quit (Ping timeout)
13:16:51 <aleth> inputValid = true/false?
13:17:14 <flo-retina> what about just invalid=true or no attribute at all?
13:17:22 <aleth> flo-retina: Good idea
13:17:52 <aleth> The only reason he had it was because of JosiahOne suggesting three possible states
13:19:25 --> sherief has joined #instantbird
13:21:03 <clokep_work> It is three states, I think.
13:21:23 <flo-retina> what's the third state?
13:22:05 <flo-retina> the current patch has a "warning" intermediate step, but neither aleth nor I think it's useful
13:22:18 <clokep_work> Oh?
13:22:23 <clokep_work> Ah, OK.
13:22:46 <clokep_work> So it's < 200 characters shows the input amount then.
13:22:47 <clokep_work> Cool.
13:27:25 --> mconley_ has joined #instantbird
13:31:39 <-- mconley_ has quit (Input/output error)
13:32:07 --> mconley_ has joined #instantbird
13:32:40 <aleth> I looked a bit into the Mac update issue, and just from the code I don't see why this wouldn't be working for our updates http://dxr.mozilla.org/mozilla-central/source/toolkit/xre/nsCommandLineServiceMac.cpp#71
13:33:03 * aleth isn't sure about how to best debug update issues
13:33:53 <-- mconley_ has quit (Ping timeout)
13:34:47 * clokep_work hopes his feedback makes sense in light of the rest of that conversation.
13:35:40 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:43:58 <-- aleth has quit (Ping timeout)
13:51:48 <-- sonny has quit (Ping timeout)
14:06:04 --> sonny has joined #instantbird
14:16:20 --> mconley_ has joined #instantbird
14:30:04 --> hadi has joined #instantbird
14:40:22 * mconley_ is now known as mconley
15:00:51 <clokep_work> We should port bug 1067089.
15:00:53 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1067089 nor, --, ---, richard.marti, ASSI, Port bug 544672 and bug 621873 to Thunderbird - Pin icon on Win8 and don't propose Quick Launch Bar 
15:21:40 --> flo-retina has joined #instantbird
15:21:41 * ChanServ sets mode +qo flo-retina flo-retina 
15:32:35 --> Karandeep96 has joined #instantbird
15:45:43 --> myk has joined #instantbird
15:50:36 <-- gerard-majax has quit (Ping timeout)
15:57:38 <-- myk has quit (Ping timeout)
15:59:00 --> myk has joined #instantbird
16:19:24 --> gerard-majax has joined #instantbird
16:23:43 <-- myk has quit (Ping timeout)
16:24:56 --> myk has joined #instantbird
16:25:52 <-- hadi has quit (Ping timeout)
16:29:43 <-- gerard-majax has quit (Ping timeout)
16:36:51 --> gerard-majax has joined #instantbird
16:39:48 --> Mook_as has joined #instantbird
16:40:35 <-- myk has quit (Ping timeout)
16:43:17 <-- Mook_as has quit (Input/output error)
16:44:38 --> hadi has joined #instantbird
16:46:12 --> Mook_as has joined #instantbird
16:54:06 <-- gerard-majax has quit (Ping timeout)
16:54:17 <-- Karandeep96 has quit (Quit: Bye)
16:58:34 --> myk has joined #instantbird
17:00:50 --> gerard-majax has joined #instantbird
17:02:40 * Fallen is now known as Fallen|away
17:04:03 --> gerard-majax_ has joined #instantbird
17:04:08 <-- gerard-majax has quit (Ping timeout)
17:16:47 <-- gerard-majax_ has quit (Ping timeout)
17:44:38 --> mpmc has joined #instantbird
17:46:51 <-- Mook_as has quit (Quit: Mook_as)
17:47:18 --> Mook_as has joined #instantbird
17:47:43 --> arlolra has joined #instantbird
17:59:08 <Mook_as> Hrm. Tb decided that when I mentioned '<defunct>' in a gtalk conversation, that should be treated as a html tag in my logs :( Incoming text is fine, just outgoing.
18:03:16 <flo-retina> Mook_as: can you expand on what "should be treated as a html tag in my logs" means?
18:03:46 <Mook_as> err, sorry, brain fart
18:03:59 <Mook_as> it _was_ treated as html; but it was passed to the other end as plain text
18:04:32 <flo-retina> I still don't get what "_was_ treated as html" means.
18:04:45 <flo-retina> I don't think there's any error message saying "treated as html"!
18:05:02 <flo-retina> so it would probably clarify if you described what you saw rather than what you guessed (probably right)
18:06:12 <Mook_as> Sorry, let me actually explain things in a saner way :)
18:06:49 <Mook_as> I typed, in the text box, and sent: Try `ps -Af f | grep -B10 -F '<defunct>'`
18:07:02 <Mook_as> The scrollback then showed that, except the <defunct> part was missing.
18:07:15 <Mook_as> From the response, though, it looked like the text got through.
18:08:15 <Mook_as> The log file (json) says: {"date":"2014-09-22T17:54:17.000Z","who":"foo@bar","text":"Try `ps -Af f | grep -B10 -F '<defunct>'` ?\n","flags":["outgoing"],"alias":"mook"}
18:08:39 <Mook_as> (compared to the incoming line, where it's escaped as &lt;defunct&gt; )
18:08:43 <flo-retina> was the \n intentionally part of the message?
18:09:09 <Mook_as> No, it wasn't. Huh.
18:09:25 <flo-retina> are you on a current nightly?
18:10:03 <Mook_as> 20140922030203
18:10:09 * flo-retina wonders if it could be another regression from bug 983347
18:10:12 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=983347 nor, --, 1.6, arlolra, RESO FIXED, Need different paths for displaying to the screen and sending over the wire
18:10:36 <flo-retina> please file a bug :)
18:10:44 <flo-retina> in any case, that should help :)
18:10:49 <Mook_as> :D
18:11:47 <flo-retina> oh, and you said that was gtalk :)
18:12:04 <flo-retina> haven't we removed some HTML special char escaping there "because there was no obvious need"?
18:12:10 <flo-retina> clokep_work, arlolra: ^
18:12:13 <arlolra> https://hg.mozilla.org/comm-central/rev/e2c85d70fda2#l10.24
18:12:39 <flo-retina> this stuff desperately needs tests :(
18:15:46 <arlolra> I think we thought https://github.com/mozilla/releases-comm-central/blob/master/chat/content/convbrowser.xml#L457-L485 does something it doesn't
18:16:53 <arlolra> I'll put that in prepareMessage and attache a patch
18:17:36 --> gerard-majax_ has joined #instantbird
18:22:14 <arlolra> hmm, putting it in prepareMessage would apply it before sending, which isn't what we want. I think we discussed the converse, prepareDisplay, but concluded it wasn't needed because applying this escaping was redundant
18:23:21 <flo-retina> arlolra: thanks for looking into this :)
18:23:29 * flo-retina would still like Mook_as to file a bug ;)
18:24:06 <arlolra> np
18:24:15 <arlolra> are you opposed to adding a prepareDisplay?
18:24:55 <flo-retina> is there another solution?
18:25:00 <flo-retina> I don't remember the context, sorry :(
18:25:31 <instantbot> New Chat Core - XMPP bug 1071166 filed by marky@activestate.com.
18:25:32 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1071166 nor, --, ---, nobody, NEW, Outgoing messages not escaped correctly
18:25:35 <Mook_as> Sorry, was afk.
18:25:58 <flo-retina> thanks! :)
18:34:39 <arlolra> flo-retina: I don't see another solution. it gives the prpl a chance to apply escaping but only after the addon has had a chance to manipulate it. you could use prepareForSending and apply the escaping to both what's displayed and sent, but that's different from what was there before
18:35:19 <flo-retina> arlolra: is it really the prpl's task to escape a plain text message into an HTML one?
18:35:58 <flo-retina> hmm, if we want the IRC prpl to link channel names automatically, maybe it's something the UI can't do.
18:38:49 <arlolra> I suspect it wasn't placed there on a whim
18:39:08 <flo-retina> arlolra: I suspect we just copied libpurple without thinking about it
18:39:23 <arlolra> ha, ok
18:40:15 <Mook_as> wouldn't it be up to the prpl to figure out if it's a plain text message to begin with?
18:41:19 <arlolra> when does the irc prpl link channel names? that sounds problematic
18:41:53 <flo-retina> arlolra: it doesn't; but it's a common feature request
18:42:01 <arlolra> ah
18:42:16 <arlolra> ok, that would also want a prepareForDisplaying
18:42:21 <flo-retina> arlolra: the twitter prpl does stuff like that with hashtags and mentions, but that's irrelevant for OTR :)
18:42:46 <arlolra> flo-retina: unless you supported dms
18:42:55 <arlolra> you could do otr over dm
18:43:04 <flo-retina> I guess :)
18:43:33 * flo-retina doesn't know why DMs never got implemented
18:45:39 * Fallen|away is now known as Fallen
18:45:40 <arlolra> flo-retina: let me know if you want me to prepare a patch or if you want to think about it some more
18:46:01 <flo-retina> preparing a patch seems good :)
18:46:26 <flo-retina> arlolra: tbh, I'm very unlikely to have time to think about it soon.
18:46:40 <arlolra> fair enough
18:46:44 <flo-retina> so reviewing a patch is probably the best I can offer to do
18:47:13 <arlolra> ok
18:47:22 <arlolra> where would I go looking to fix this one?
18:47:22 <arlolra> https://bugzilla.mozilla.org/show_bug.cgi?id=1070953
18:47:25 <instantbot> Bug 1070953 nor, --, ---, nobody, NEW, Message style preview is broken
18:47:41 * arlolra broke a lot of things
18:47:54 <flo-retina> look at what's causing the error message?
18:48:35 <flo-retina> |let msg = aMsg.displayMessage;| is that correct? What's the type of aMsg?
18:49:00 <flo-retina> I'm looking at http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml#472
18:49:34 <arlolra> it means the messages aren't being wrapped in a imIMessage
18:49:55 <flo-retina> the message objects are from: http://mxr.mozilla.org/comm-central/source/im/content/preferences/messagestyle.js#44
18:50:05 <arlolra> probably have to do that trick you did for logging to work
18:50:53 <arlolra> ah, that helps
18:51:12 <arlolra> will see if I can fix that one too
19:04:57 <-- hadi has quit (Ping timeout)
19:23:07 --> nhnt11 has joined #instantbird
19:34:46 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:36:19 <-- Morian has quit (Quit: leaving)
19:36:24 --> Morian has joined #instantbird
19:38:32 --> chrisccoulson has joined #instantbird
20:09:34 <-- arlolra has quit (Quit: arlolra)
20:29:15 --> EionRobb has joined #instantbird
21:46:04 <-- sonny has quit (Ping timeout)
21:51:50 <clokep_work> arlora: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/irc.js#286  might do what you expect?
21:54:27 <-- Tonnes has quit (Ping timeout)
21:55:28 --> Tonnes has joined #instantbird
22:02:03 <-- mconley has quit (Input/output error)
22:27:10 --> arlolra has joined #instantbird
22:34:43 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:42:55 <-- clokep_work has quit (Ping timeout)
22:46:52 <-- flo-retina has quit (Ping timeout)
22:56:09 --> flo-retina has joined #instantbird
22:56:10 * ChanServ sets mode +qo flo-retina flo-retina 
23:06:00 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:06:09 * Fallen is now known as Fallen|away
23:11:54 <-- myk has quit (Ping timeout)
23:21:16 --> clokep has joined #instantbird
23:21:17 * ChanServ sets mode +o clokep 
23:24:39 <clokep> flo-retina: Did we ever make directions of how to make the purple extension?
23:28:20 <clokep> arlolra: Did you see my ocmment?
23:32:03 <arlolra> clokep: nope
23:32:11 <arlolra> I didn't see your comment
23:33:41 <clokep> arlolra: the last comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1071166
23:33:41 --> mconley has joined #instantbird
23:33:43 <instantbot> Bug 1071166 nor, --, ---, nobody, NEW, Outgoing messages not escaped correctly
23:33:45 --> sonny has joined #instantbird
23:36:03 <arlolra> clokep: yup, that should use it too
23:36:45 <clokep> arlolra: my point was more of "Do we need a separate function?"
23:37:26 <arlolra> oh, yes, we do. altering the message there will break the otr extension
23:37:46 <arlolra> it requires the string password the sendMsg be same as what's returned in writeMessage
23:37:58 <arlolra> s/password/passed/
23:38:07 * Mook_as wonders what the filter chain looks like right now
23:38:45 <clokep> Apparently Mook_as wants a diagram. ;)
23:38:51 <clokep> arlolra: Ah, got it... :)
23:38:57 <clokep> We should probably document that somewhere.
23:39:15 <arlolra> in the bug I spoke of a "contract" that the prpl makes
23:39:24 <arlolra> where's the right place to document that?
23:39:33 <Mook_as> Yes, I do. On the other hand, I probably won't be doing very much with it, so don't spend too much effort on my account :p
23:42:08 <clokep> arlolra: Most likely in the idl?
23:44:59 --> myk has joined #instantbird
23:46:29 <arlolra> ok, I'll add that to the patch
23:49:41 <clokep> Thanks. :)
23:53:00 <-- myk has quit (Ping timeout)
23:54:07 --> myk has joined #instantbird
23:55:45 <-- myk has quit (Ping timeout)
23:56:15 --> myk has joined #instantbird