#instantbird log on 08 27 2014

All times are UTC.

00:13:04 <-- sherief has quit (Input/output error)
00:14:07 <-- arlolra has quit (Quit: arlolra)
00:36:22 --> iamjayakumars has joined #instantbird
00:42:24 <-- EionRobb has quit (Ping timeout)
00:47:28 --> EionRobb has joined #instantbird
00:47:29 <-- iamjayakumars has quit (Quit: )
01:22:39 <-- Mook_as has quit (Quit: Mook_as)
01:27:02 --> clokep_work has joined #instantbird
01:27:02 * ChanServ sets mode +o clokep_work 
01:47:31 <-- flo-retina has quit (Ping timeout)
02:11:59 --> mconley has joined #instantbird
02:44:36 <-- wnayes has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
02:58:16 --> sherief has joined #instantbird
02:58:37 <clokep_work> There's a bug in the overlay for the DOM inspector, it's calling setTimeout with a called function instead of the function name to call.
03:01:54 <-- nhnt12 has quit (Ping timeout)
03:05:28 <clokep_work> (The error shows up as aFunction.apply is not a function)
03:22:41 --> jaker has joined #instantbird
03:23:22 <jaker> is there any addons or anything to get otr support for instantbird?
03:24:36 <clokep> jaker: No, but someone is working on adding support.
03:25:11 <jaker> know how long it will take? :D
03:25:20 <clokep> No.
03:25:25 <jaker> okay
03:27:03 <clokep> I think he has a demo working, but we need to modify some APIs that are going through review.
03:27:34 <jaker> ahh
03:32:54 <-- clokep has quit (Ping timeout)
03:33:10 <-- clokep_work has quit (Ping timeout)
03:36:13 <instant-buildbot> build #2321 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2321
03:48:39 <instant-buildbot> build #1141 of linux-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1141
04:10:11 <instant-buildbot> build #1497 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1497
04:20:43 --> BillBinkley1 has joined #instantbird
04:21:11 <-- BillBinkley has quit (Ping timeout)
04:29:41 <-- mconley has quit (Input/output error)
04:33:09 <instant-buildbot> build #36 of linux64-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/36
05:56:06 <-- EionRobb has quit (Quit: Leaving.)
07:02:31 --> mpmc has joined #instantbird
07:10:10 <-- sherief has quit (Ping timeout)
07:11:09 <-- mali has quit (Ping timeout)
07:12:44 --> mali has joined #instantbird
07:13:38 * Fallen|away is now known as Fallen
07:32:53 <-- mali has quit (Ping timeout)
07:33:15 --> mali has joined #instantbird
07:38:16 <-- Suiseiseki has quit (Ping timeout)
07:39:36 --> Suiseiseki has joined #instantbird
07:56:25 --> sonny has joined #instantbird
08:06:08 --> chrisccoulson has joined #instantbird
08:29:27 --> jb has joined #instantbird
08:33:16 --> flo-retina has joined #instantbird
08:33:16 * ChanServ sets mode +qo flo-retina flo-retina 
08:37:19 <flo-retina> bah, bug 727615 was known and nobody fixed it :(
08:38:20 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=727615 nor, --, ---, nobody, NEW, Do small dependent strings effectively leak large strings?
08:38:57 --> Bollebib has joined #instantbird
08:39:11 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
08:39:15 --> flo-retina has joined #instantbird
08:39:15 * ChanServ sets mode +qo flo-retina flo-retina 
09:21:36 <-- mpmc has quit (Connection reset by peer)
09:22:48 --> mpmc has joined #instantbird
09:25:49 <-- Suiseiseki has quit (Ping timeout)
09:26:59 --> Suiseiseki has joined #instantbird
09:27:06 --> nhnt12 has joined #instantbird
09:27:36 * nhnt12 wonders why he's frequently known as nhnt12 these days
09:27:47 <nhnt12> "Could not use the specified nickname. Your nick remains nhnt12.'
09:27:54 <nhnt12> Nothing in the error console..
09:28:01 * nhnt12 checks the debug log
09:28:36 <nhnt12> Oh, it appears nhnt11 is online :S
09:28:59 <nhnt12> irccloud! Bah!
09:30:12 <-- Suiseiseki has quit (Ping timeout)
09:31:00 * nhnt12 is now known as nhnt11
09:31:03 <nhnt11> Much better :)
09:31:12 --> Suiseiseki has joined #instantbird
09:33:02 <-- Suiseiseki has quit (Ping timeout)
09:37:54 <-- mpmc has quit (Ping timeout)
09:38:17 --> mpmc has joined #instantbird
09:43:47 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:04:19 --> BWMerlin has joined #instantbird
10:07:48 --> flo-retina has joined #instantbird
10:07:48 * ChanServ sets mode +qo flo-retina flo-retina 
10:09:07 <-- nhnt11 has quit (Ping timeout)
10:13:06 --> clokep has joined #instantbird
10:13:06 * ChanServ sets mode +o clokep 
10:14:18 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
10:35:32 <clokep> I shuld really fix that password issue.  Although I'd like to brainstorm one day about it. :-\
10:45:03 <flo-retina> I don't see any obvious difference between String.slice and String.substring :-S
10:46:22 <clokep> In terms of memory?
10:46:56 <flo-retina> in terms of why I would want to use one or the other
10:48:35 <clokep> In fact substring seems to do LESS, e.g. it doesn't accept negative indices.
10:51:58 <-- clokep has quit (Ping timeout)
11:08:52 --> Suiseiseki has joined #instantbird
11:13:58 <-- BillBinkley1 has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:14:19 --> BillBinkley has joined #instantbird
11:44:46 * Fallen is now known as Fallen|away
11:47:43 --> clokep_work has joined #instantbird
11:47:43 * ChanServ sets mode +o clokep_work 
12:23:23 <-- flo-retina has quit (Ping timeout)
12:27:37 --> flo-retina has joined #instantbird
12:27:38 * ChanServ sets mode +qo flo-retina flo-retina 
12:29:41 * flo-retina would really appreciated if freenode's nickserv could shut up
12:31:05 <clokep_work> flo-retina: Which messages are these?
12:31:14 <flo-retina> 14:27:59 - NickServ: This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>.
12:31:14 <flo-retina> 14:28:07 - NickServ: You are now identified for fqueze_.
12:32:25 --> rosonline has joined #instantbird
12:32:49 <clokep_work> Oh, I had no idea you were having issues with that.
12:32:51 <clokep_work> That should work.
12:34:45 --> nhnt11 has joined #instantbird
12:35:18 <flo-retina> clokep_work: I see them like 2-3 times per month
12:35:37 <flo-retina> clokep_work: I always assume it's visible when there's a long delay between the 2 messages
12:35:52 <flo-retina> but I'm not sure I actually checked that assumption was correct
12:36:01 <flo-retina> I saw them twice today though.
12:36:42 <clokep_work> Yes, a long delay could do it.
12:36:58 <clokep_work> Although...we should be using SASL for freenode anyway? :-S
12:37:10 <clokep_work> Or...not when your nick is differnet, right.
12:37:29 <flo-retina> yes, SASL failing could be a significant factor to having a longer delay
12:38:54 <clokep_work> No, it can't.
12:39:06 <clokep_work> That all happens before you can ever receive messages from NickServ.
12:39:27 <flo-retina> should we look at a debug log then?
12:39:32 <-- BWMerlin has quit (Quit: BWMerlin)
12:42:56 <clokep_work> Maybe.
12:43:06 <clokep_work> No other way to see what's going on. ;)
12:43:21 <flo-retina> I meant, do you have time to look into this? :)
12:43:36 <flo-retina> we really need a better way to display these logs :(
12:43:52 <flo-retina> just figuring out what's sent and what's received is difficult currently :(
12:45:27 <flo-retina> Looks like we send the password three times
12:45:52 <clokep_work> Depending on the messages, that might not be suprising.
12:46:11 <flo-retina> we send AUTHENTICATE <base64 encoded nick, user and password not logged>
12:46:39 <clokep_work> That's SASL, which will fail for you.
12:47:01 <flo-retina> we receive "SASL authentication failed" and then "SASL authentication aborted"
12:47:14 <flo-retina> after that we send "IDENTIFY <password not logged>"
12:47:34 <flo-retina> and then we join #gsoc _twice_ (we have a bug on file for that, right?)
12:48:25 <flo-retina> then we receive plenty of stuff (likely the MOTD)
12:49:19 <flo-retina> after receiving the MOTD we get ":NickServ!NickServ@services. NOTICE fqueze :This nickname is registered. Please "[blah]
12:49:46 <flo-retina> then we get ":cameron.freenode.net 421 fqueze IDENTIFY :Unknown command"
12:50:03 <flo-retina> then we send "NICKSERV IDENTIFY <password not logged>"
12:50:45 <flo-retina> then we actually enter #gsoc and receive the list of participants
12:51:47 <flo-retina> only after all of that is done we get "NickServ!NickServ@services. NOTICE fqueze :You are now identified"
12:52:10 <clokep_work> I don't think we actually do have a bug about trying to join things twice.
12:53:03 <clokep_work> What's the time difference between "This nickname is not registered..." and "You are now identified"?
12:53:21 <-- nhnt11 has quit (Ping timeout)
12:53:31 <flo-retina> "This nickname is registered." is at 14:27:48
12:53:50 <flo-retina> "You are now identified" is at 14:28:06
12:53:56 <flo-retina> so 18s
12:59:27 <clokep_work> Hmm...I think we display it after 10 seconds.
12:59:30 <flo-retina> would it help if we waited until the end of the MOTD to send the JOIN commands?
13:00:17 <flo-retina> also, would be nice if possible (I really don't know if it is) if we could wait for the end of the identification (either success, or unrecoverable failure) before attempting to join channels.
13:01:05 <flo-retina> indeed, 10s: http://mxr.mozilla.org/comm-central/source/chat/protocols/irc/ircServices.jsm#224
13:01:16 <flo-retina> so my initial assumption that the message showing was just caused by the delay was correct :)
13:02:19 <clokep_work> flo-retina: It probably would, but there's no guarantee a server sends a MOTD.
13:03:37 <flo-retina> we send two "CAP END". is this one per "CAP REQ ..." we sent before?
13:07:30 <clokep_work> No.
13:07:44 <clokep_work> We should only be sending one of those.
13:08:13 <flo-retina> alright. I'm not sure how many bugs I should file now :-)
13:08:23 --> iamjayakumars has joined #instantbird
13:12:03 * Fallen|away is now known as Fallen
13:12:15 <clokep_work> Three?
13:12:38 <flo-retina> duplicated JOIN, duplicated CAP END, and nickserv message showing?
13:13:36 <clokep_work> Yes.
13:14:45 <-- iamjayakumars has quit (Ping timeout)
13:16:10 <flo-retina> our log search is so broken :(
13:18:03 --> aleth has joined #instantbird
13:18:03 * ChanServ sets mode +o aleth 
13:18:22 <-- aleth has quit (Quit: exit stage left)
13:18:24 --> aleth has joined #instantbird
13:18:25 * ChanServ sets mode +o aleth 
13:18:44 <flo-retina> aleth: congrats on getting that LIST leak finally fixed :)
13:18:47 <aleth> clokep_work: Thanks for doing all those checkins!
13:19:17 <aleth> Thanks!
13:19:39 <aleth> Did you see that memshrink bug was duped to one filed in 2012? 
13:19:58 * Fallen is now known as Fallen|away
13:21:59 * aleth hopes nhnt11 can get indexed logs to land soon ;)
13:22:03 * Fallen|away is now known as Fallen
13:22:42 <clokep_work> aleth: Of course!
13:22:45 <clokep_work> I should update my nightly...
13:23:39 --> iamjayakumars has joined #instantbird
13:23:53 <aleth> flo-retina: Considering we now know that the LIST data takes at most 3-4M per account, it seems there should be plenty of opportunities for more savings in the stats service ;)
13:24:40 <flo-retina> aleth: yeah, "5.79 MB (01.94%) ++ class(Function)" and "5.64 MB (01.88%) ++ class(XPC_WN_NoMods_NoCall_Proto_JSClass)" seem to me like mostly wastes
13:27:10 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:27:12 --> clokep_work has joined #instantbird
13:27:12 * ChanServ sets mode +o clokep_work 
13:27:36 <clokep_work> OK, I'm up to YESTERDAY's nightly.
13:27:37 * clokep_work sighs...
13:27:42 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
13:27:43 --> clokep_work has joined #instantbird
13:27:43 * ChanServ sets mode +o clokep_work 
13:27:55 <clokep_work> (And now someone is pissed that I keep quitting / joining. :))
13:28:11 <clokep_work> So what new feature should I be excited for?!
13:28:30 <aleth> I don't know, what landed? I was hoping for split logs but it seems they are not ready
13:28:43 <clokep_work> Aha, Bug 955677
13:28:49 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955677 nor, --, 1.6, clokep, RESO FIXED, Nick truncated if already in use during connection registration
13:29:11 <aleth> Lots of bugfixes :)
13:29:50 <flo-retina> aleth: yeah, it's sad that split logs are not ready get :(
13:30:04 <aleth> What's the holdup there?
13:30:07 <aleth> ah, gloda :-S
13:30:08 <flo-retina> aleth: gloda
13:30:38 <-- iamjayakumars has quit (Client exited)
13:39:33 <flo-retina> what's the meaning of "CAP END"? we don't send it at all on moznet apparently
13:41:33 <instantbot> New Chat Core - General bug 1059288 filed by aleth@instantbird.org.
13:41:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059288 nor, --, ---, nobody, NEW, Investigate moving the joining throbber logic out of the prpls
13:42:34 <instantbot> New Chat Core - IRC bug 1059289 filed by florian@queze.net.
13:42:38 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059289 nor, --, ---, nobody, NEW, JOIN commands are sent twice when reconnecting an account
13:43:05 <instantbot> New Chat Core - IRC bug 1059290 filed by florian@queze.net.
13:43:10 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059290 nor, --, ---, nobody, NEW, CAP END sent twice
13:48:35 <aleth> flo-retina: I'm pretty sure your suspicion regarding the double JOIN is correct
13:48:58 <instantbot> New Chat Core - IRC bug 1059292 filed by florian@queze.net.
13:49:34 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059292 nor, --, ---, nobody, NEW, nickserv messages sometimes displayed
13:53:20 --> nhnt11 has joined #instantbird
13:54:07 <flo-retina> aleth: "check before checking this in that .ib-msg-txt is indeed always (for all message styles) a direct child of the element that gets the .monospaced class." I don't think that's guaranteed :-/
13:55:03 <-- nhnt11 has quit (Ping timeout)
13:55:08 <aleth> I wasn't sure, but I also suspect it's not the case.
13:59:21 --> nhnt11 has joined #instantbird
14:01:29 <clokep_work> flo-retina: moznet doesn't support CAP.
14:01:40 <flo-retina> ah :)
14:01:57 <aleth> The new server might ;)
14:01:57 <-- nhnt11 has quit (Ping timeout)
14:01:58 * flo-retina looks at the new moznet server
14:02:26 <clokep_work> It might.
14:02:31 <flo-retina> clokep_work: the new server does, and we send two CAP END there
14:03:02 <clokep_work> Cool.
14:03:22 <aleth> I'm not sure the double JOIN thing is worth fixing.
14:03:45 <flo-retina> why?
14:03:46 <clokep_work> flo-retina: "CAP END" means "We're done negotiating capabilities with the server."
14:03:48 --> mpmc has joined #instantbird
14:03:59 <flo-retina> clokep_work: thanks
14:04:04 <aleth> The code is complicated enough already, and I can't see it doing any harm
14:04:23 <clokep_work> aleth: WOuldn't it be fixed by the bug you just filed?
14:04:29 <flo-retina> clokep_work: do you want the allizom log or the freenode one in the CAP END bug?
14:05:15 <aleth> clokep_work: it could be
14:05:20 <flo-retina> aleth: what you just said sounds like you don't want to hack a fix for it now but wait until the next refactoring. That's not exactly the same as "not worth fixing".
14:05:22 <clokep_work> flo-retina: Either one, whatever is convenient.
14:05:39 <flo-retina> ok, I have the allizom one currently in front of me ^^
14:05:40 <clokep_work> aleth: " Iirc we use pre-wrap for ib-msg-txt by default. That should also work, but of
14:05:41 <clokep_work> course it will mess up the ASCII art if bubbles are too small... so it seems
14:05:41 <clokep_work> this is a tradeoff you consciously chose." It doesn't work.
14:05:45 <aleth> flo-retina: Yes, that's exactly what I meant. "Not worth fixing separately"
14:06:12 <flo-retina> :)
14:06:24 <aleth> clokep_work: What happens?
14:06:42 <clokep_work> aleth: It wraps.
14:07:12 <aleth> clokep_work: Yes, but only if the bubble is too small, right?
14:07:42 <aleth> Oh, I see, you're looking for a nonexistent "pre-crop" ;)
14:08:06 <aleth> I think "pre" is good enough here.
14:09:07 <aleth> UMich users can resize their windows ;)
14:09:40 <clokep_work> aleth: EIther way they need to resize the window, it's whether we want it to wrap or not.
14:09:52 <aleth> Personally I'd go for the wrapping I think
14:09:53 <clokep_work> I'm not sure I really like that change or not.
14:10:05 <aleth> But I haven't seen screenshots...
14:10:20 <flo-retina> clokep_work: here's your debug log: https://bug1059290.bugzilla.mozilla.org/attachment.cgi?id=8479896
14:10:26 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059290 nor, --, ---, nobody, NEW, CAP END sent twice
14:10:42 <aleth> I think if we *did* find a way to crop the contents that would be potentially misleading, e.g. if the last letter of the captcha is just dropped.
14:11:10 <flo-retina> aleth: overflow: hidden?
14:11:23 <flo-retina> but I agree, seeing the stuff is wrapped is a good hint that resizing is needed
14:12:08 <aleth> I wonder how overflow: scroll would look :P
14:12:33 <flo-retina> aleth: an horizontal scrollbar for each message? Fun :-P
14:12:36 <aleth> But yeah, I think I'd go with pre-wrap
14:12:49 --> mconley has joined #instantbird
14:12:59 <aleth> Also saves a CSS rule ;)
14:13:04 <flo-retina> aleth: don't we already do this to be able to show indented code properly? :-S
14:13:08 <aleth> Yes
14:13:19 <aleth> That's why it saves a rule
14:13:25 <flo-retina> ok :)
14:13:34 <flo-retina> aleth: I didn't see "Also saves a CSS rule ;)" when I typed that question ;)
14:14:05 <aleth> flo-retina: Message order isn't exactly deterministic on IRC anyway ;)
14:14:07 <clokep_work> aleth, flo-retina: http://imgur.com/Ojxv29f,tFayDsX#0
14:14:52 <aleth> clokep_work: Thanks. I'd say wrapping is good.
14:14:59 <flo-retina> clokep_work: what about filing a bug for a parser, and marking it as mentored? :-P
14:15:04 <clokep_work> The first is with the actual pre, the second is without it.
14:15:16 <clokep_work> flo-retina: Haha. I thought about doing it myself, then decided I was lazy. ;)
14:15:42 <aleth> clokep_work: Do you know someone at UMich or did we get a bug report?
14:15:55 <flo-retina> aleth: I think it would look best if we could use overflow:scroll, but join all the messages into one (don't we do this for the MOTD or somewhere else) and use \n to separate lines
14:16:02 <clokep_work> aleth: He came on IRC and talked to us and filed a bug.
14:16:35 <clokep_work> But being unable to connect to a network is a "big deal" IMO.
14:16:41 <aleth> Yes.
14:16:57 <aleth> I mean, yes to clokep_work. Not sure flo-retina's suggestion is worth the effort ;)
14:17:21 <flo-retina> I suggested mentoring a bug :-P
14:17:29 <flo-retina> the message joining thing wasn't really serious
14:18:05 <clokep_work> BUGSPAM!
14:18:07 <aleth> clokep_work: Also the monospace thing might be useful elsewhere some day...
14:18:35 <clokep_work> aleth: I was wondering if MOTD should be monospaced...but then we would actually have issues w/ text being too long.
14:19:00 <aleth> Hmm, I guess that does also often include ASCII art
14:19:43 <clokep_work> flo-retina: Yeah so my guess is we're sending CAP END for both multi-prefix and SASL, we should only send it once when BOTH are done.
14:21:57 <flo-retina> clokep_work: sounds like that all would be easier with promises
14:22:00 <flo-retina> but maybe not :)
14:22:32 <aleth> or DeferredTask maybe ;)
14:22:42 <aleth> possibly overkill.
14:22:57 <flo-retina> aleth: that's likely how we would implement it now
14:24:03 * Fallen is now known as Fallen|away
14:26:13 <-- sonny has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
14:29:14 * Fallen|away is now known as Fallen
14:30:06 <aleth> flo-retina: I can't see Promise.jsm in about:memory... maybe that's a leak that takes some uptime to show up?
14:37:13 <-- aleth has quit (Ping timeout)
14:38:18 --> aleth has joined #instantbird
14:38:18 * ChanServ sets mode +o aleth 
14:38:58 <flo-retina> aleth: it became very visible after 7-10 days of usage IIRC
14:39:32 <flo-retina> errr... "7.24 MB (02.57%) -- compartment([System Principal], resource://gre/modules/Promise.jsm)"
14:42:45 <flo-retina> aleth: https://pastebin.mozilla.org/6179648
14:44:16 <clokep_work> flo-retina: Yes, something like promises could make that easier.
14:44:18 <aleth> Seems a lot. And we only use Promise.jsm indirectly... weird
14:45:28 <aleth> Task.jsm also shows up heavier than I would have expected, that may be the real issue.
14:46:30 <clokep_work> There's probably a few things in the IRC code that can be made simpler w/ Promises.
14:46:30 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:46:42 <flo-retina> clokep_work: and a lot in JS-XMPP
14:46:57 <flo-retina> aleth: so can we blame the log writer, or is there another candidate?
14:48:28 <flo-retina> aleth: Promises.jsm is now down to 0.22 MB. Maybe I just looked at about:memory at a very unfortunate time
14:48:44 <aleth> I don't think there's another candidate, no.
14:48:48 <flo-retina> I'm also wondering if it could be related to looking at the log (ie. opening the log viewer) for an active conversation
14:49:48 --> sonny has joined #instantbird
14:52:11 <clokep_work> Btw...with the short / long strings thing...is that an issue w/ our socket code?
14:52:29 <clokep_work> Do we essentially keep an enormous string in memory and just keep splitting it.
14:53:38 <aleth> That's just what the JS engine does.
14:54:03 <aleth> Usually it's not a problem because messages get handled and that's it.
14:54:41 <flo-retina> aleth: what about debug logs?
14:55:04 <clokep_work> My thought as well. ;)
14:55:05 <aleth> flo-retina: That's the first thing I investigated, but it didn't seem to cause a problem.
14:56:18 <aleth> Not entirely sure why not.
14:57:02 <aleth> Hmm, maybe we could test that further by setting the retain pref to keep all messages
14:57:16 <flo-retina> aleth: maybe the JS engine flattens strings more aggressively when crossing compartment boundaries?
14:57:38 <aleth> flo-retina: Hmm, that could be. I was just going to suggest maybe scripterror.init() flattens.
14:57:55 <flo-retina> oh that's very likely
14:58:15 <flo-retina> I didn't know we used a scripterror object for each debug log message though
14:58:24 <aleth> We do.
15:08:13 * Fallen is now known as Fallen|away
15:08:55 --> iamjayakumars has joined #instantbird
15:11:26 <-- iamjayakumars has quit (Client exited)
15:16:41 <clokep_work> So the patch that just landed: " An important implication of this change is that mozconfigs are now required for comm-central: if they are not provided, Firefox, not Thunderbird, will be built."
15:16:47 <clokep_work> Obviously IB has always needed it, but just a heasd up
15:17:34 <aleth> Good to know.
15:21:02 * Fallen|away is now known as Fallen
15:37:47 <-- rosonline has quit (Client exited)
15:38:54 --> rosonline has joined #instantbird
15:39:35 <-- rosonline has quit (Client exited)
15:41:01 --> rosonline has joined #instantbird
15:50:59 <-- rosonline has quit (Client exited)
15:53:48 --> sherief has joined #instantbird
15:55:34 --> mpmc has joined #instantbird
16:11:44 * Fallen is now known as Fallen|away
16:14:47 <aleth> So that Box issue was just due to differing cookie policies?
16:17:44 --> rosonline has joined #instantbird
16:19:34 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:20:44 <clokep_work> aleth: I think so.
16:20:50 <clokep_work> I wish there was a good way to fix that.
16:20:59 <clokep_work> We also have different settings on TB.
16:21:02 <clokep_work> Which probably makes things break.
16:21:12 <clokep_work> We should check if that's even necessary still?
16:21:12 <aleth> Does an #ifdef TB help?
16:21:23 <aleth> Ah yeah, maybe it's not even needed.
16:22:13 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
16:22:40 <clokep_work> No. The issue is that we need the pref set how it is for Twitter, but need it set the other way for TB.
16:22:47 <aleth> :-S
16:24:10 <clokep_work> (Obviously it wasn't THAT important if we didn't set it for Thunderbird, but is still frustrating...)
16:29:50 --> iamjayakumars has joined #instantbird
16:34:52 * Fallen|away is now known as Fallen
16:34:52 <-- iamjayakumars has quit (Client exited)
16:36:52 <-- sonny has quit (Ping timeout)
16:38:10 --> arlolra has joined #instantbird
16:38:58 <clokep_work> arlolra: Someone was looking for OTR yesterday. ;)
16:40:54 <arlolra> let that be my cue to move things forward again
16:41:39 --> redDragon has joined #instantbird
16:41:53 --> flo-retina has joined #instantbird
16:41:53 * ChanServ sets mode +qo flo-retina flo-retina 
16:41:56 <arlolra> clokep_work: how do I add a password to autojoin irc rooms. google logs here told me something like,  #room1, #room2 pass1,pass2
16:42:25 <aleth> arlolra: It's #room pass1,#room2 #pass2
16:42:39 <arlolra> aleth: ah, thanks
16:42:58 <aleth> Or just join once via the dialog and tick the checkbox there
16:43:06 <-- arlolra has quit (Quit: arlolra)
16:43:38 --> arlolra has joined #instantbird
16:44:17 <-- arlolra has quit (Quit: arlolra)
16:44:23 --> arlolra has joined #instantbird
16:45:00 <arlolra> aleth: success
16:46:13 * clokep_work wonders where in the logs it says that...
16:47:50 * Fallen is now known as Fallen|away
16:48:53 --> Mook_as has joined #instantbird
16:53:23 <arlolra> clokep_work: it's very possible that I misread the logs and it says the very thing aleth just repeated
16:55:11 <-- aleth has quit (Quit: exit stage left)
16:56:08 <clokep_work> Or I was drunk one-day when telling people. ;)
16:56:21 <clokep_work> (Most likely one of us forgot and said the wrong thing though, yeah.)
16:57:11 <-- Mook_as has quit (Quit: Mook_as)
16:57:58 --> Mook_as has joined #instantbird
17:23:39 * Fallen|away is now known as Fallen
17:34:02 --> iamjayakumars has joined #instantbird
17:35:58 <-- jb has quit (Ping timeout)
17:38:26 <-- sherief has quit (Ping timeout)
17:41:43 * clokep_work wonders if flo-retina has been following bug 1041941 and if it is useful to us.
17:41:46 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1041941 nor, --, ---, mh+mozilla, NEW, Define types of programs/shared libraries in moz.build
18:28:36 <clokep_work> Apparently Joshua says we should pay attention to it. :-D
18:38:28 <-- iamjayakumars has quit (Quit: )
18:48:45 --> wnayes has joined #instantbird
18:51:47 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:59:06 <wnayes> flo-retina: I'm going to take a look at the import UI comments soon. I'm wondering what your thoughts are on the general approach the patch takes for the UI.
18:59:52 <wnayes> i.e. is it ready to go through more code review or maybe take a step back and reevaluate the workflow itself?
19:00:00 <clokep_work> wnayes: Do you mean from a UI perspective or a code perspective?
19:02:10 <wnayes> UI perspective. I kinda remember there being a few unresolved concerns (first page always being account search results, how to show/handle multiple importers finding same account, permission to import logs, etc.)
19:04:09 <wnayes> The wizard window is frustrating to work with because it's so tiny :(
19:06:22 <wnayes> Now that tabs can hold content other than conversations, I've thought about whether it would be reasonable to move the account wizard / account creation task into a tab.
19:07:12 <clokep_work> Interesting thought.
19:07:38 <clokep_work> I don't remember concerns about this stuff...I think I did rollback one of your changes though. :-\
19:13:58 <clokep_work> wnayes: Where their screenshots anywhere?
19:15:26 <wnayes> clokep_work: Probably the majority are here: https://github.com/wnayes/instantbird-wizard-gsoc2012
19:15:59 <wnayes> The wizard basically allows repeatedly adding accounts and collects them on a summary page.
19:17:37 <-- GeekShadow has quit (Ping timeout)
19:18:13 --> GeekShadow has joined #instantbird
19:20:01 <clokep_work> Right.
19:20:02 <wnayes> I've been thinking that it could be worth splitting out the "wizard with summary page/multi accounts" feature from the "wizard with importing" to reduce the UI patch scope too.
19:20:36 <flo-retina> clokep_work: the stuff being developed there should simplify (ie. reduce the number of lines) most of our moz.build files in purple/
19:20:55 <flo-retina> but whenever they touch that kind of stuff, I'm always afraid they'll break our dynamic prpl magic
19:22:37 <flo-retina> wnayes: so, I haven't finished reading the code in the UI patch; I skipped the largest file (the .js one) and looked at all the others.
19:22:43 <clokep_work> wnayes: I can't concentrate on this right now, sorry. :-\
19:22:51 <flo-retina> I was intending to do another review session at some point soon for the .js file
19:22:58 * clokep_work finds Bug 1059461 difficult to swallow.
19:23:13 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1059461 nor, --, ---, nobody, NEW, IRC logging in nick when not in use, removed from Thunderbird
19:23:19 * clokep_work checks if that guy is in here. ;)
19:25:10 <flo-retina> clokep_work: the summary doesn't make any sense; let's hope the description is better :)
19:25:28 <flo-retina> wnayes: was it a good idea to look at the UI patch before the Pidgin importer?
19:26:40 <flo-retina> wnayes: "splitting out the "wizard with summary page/multi accounts" feature from the "wizard with importing"" how would you do that? Would it make sense to not be able to import more than one account at once? :-S
19:28:00 <wnayes> flo-retina: I think both pidgin/ui are largely independent of each other, the importer would likely only demonstrate more about the backend code.
19:29:33 <wnayes> I was thinking the multiaccount wizard would just land beforehand as a separate feature
19:30:09 --> sherief has joined #instantbird
19:31:33 <wnayes> The bulk of the UI JS changes are really enabling adding multiple accounts from inside one wizard instance.
19:36:07 --> jb has joined #instantbird
19:45:51 --> tecgirl has joined #instantbird
19:50:47 <-- GeekShadow has quit (Ping timeout)
19:50:51 --> GeekShadow has joined #instantbird
20:12:55 <-- tecgirl has quit (Quit: Leaving.)
20:12:59 --> tecgirl has joined #instantbird
20:14:34 <-- tecgirl has quit (Quit: Leaving.)
20:15:42 <-- jb has quit (Ping timeout)
20:24:58 --> EionRobb has joined #instantbird
20:26:29 <-- clokep_work has quit (Ping timeout)
20:33:00 <flo-retina> wnayes: ah ok. I thought you wanted to land the import stuff first.
20:33:10 <flo-retina> wnayes: yeah, landing the multi-account wizard first is a good idea :)
20:40:02 <wnayes> flo-retina: OK, I'll work on splitting that out.
20:40:05 <wnayes> I think it will be good to redo the summary page account xul binding to be more extensible for that too (not just existingAccount and newAccount separate bindings)
20:45:45 <-- jaker has quit (Quit: )
20:46:14 --> chrisccoulson has joined #instantbird
21:31:27 <-- arlolra has quit (Quit: arlolra)
21:58:18 <-- rosonline has quit (Ping timeout)
22:06:55 <-- Bollebib has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:14:39 <-- wnayes has quit (Ping timeout)
22:15:26 --> wnayes has joined #instantbird
22:21:50 <-- mconley has quit (Input/output error)
22:38:28 --> mikk_s has joined #instantbird
22:48:48 <-- mikk_s has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
22:55:58 --> arlolra has joined #instantbird
23:19:05 <-- flo-retina has quit (Ping timeout)
23:28:26 --> clokep has joined #instantbird
23:28:26 * ChanServ sets mode +o clokep 
23:55:11 <-- sherief has quit (Quit: either an outage or my isp is being <censored>)
23:59:28 * Fallen is now known as Fallen|away