#instantbird log on 08 15 2014

All times are UTC.

01:26:07 <-- Mook_as has quit (Quit: Mook_as)
01:40:51 --> redDragon has joined #instantbird
02:15:11 <instant-buildbot> build #1483 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1483
02:16:19 <clokep_work> :-S
02:35:13 --> mconley has joined #instantbird
02:56:30 <-- mconley has quit (Input/output error)
03:15:50 <instant-buildbot> build #1129 of linux-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1129
03:34:33 <instant-buildbot> build #2307 of macosx-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2307
03:35:41 <clokep> Well at least something was successful...
03:45:37 <-- Rym has quit (Ping timeout)
04:05:37 <-- clokep_work has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
04:07:25 <-- clokep has quit (Ping timeout)
04:13:56 --> Rym has joined #instantbird
04:15:54 <-- Rym has quit (Ping timeout)
04:18:12 --> mpmc has joined #instantbird
04:21:37 <instant-buildbot> build #24 of linux64-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/24
05:08:01 --> Rym has joined #instantbird
05:10:00 <-- Rym has quit (Ping timeout)
05:47:39 <-- EionRobb has quit (Quit: Leaving.)
06:02:11 --> Rym has joined #instantbird
06:04:12 <-- Rym has quit (Ping timeout)
06:14:27 <-- arlolra has quit (Quit: arlolra)
06:56:22 --> Rym has joined #instantbird
06:58:21 <-- Rym has quit (Ping timeout)
07:05:44 <-- douglaswth has quit (Ping timeout)
07:05:52 --> douglaswth has joined #instantbird
07:09:36 --> jb has joined #instantbird
07:21:17 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
07:26:40 <-- jb has quit (Ping timeout)
07:50:31 --> Rym has joined #instantbird
07:51:32 --> EionRobb has joined #instantbird
07:52:31 <-- Rym has quit (Ping timeout)
07:56:18 --> jb has joined #instantbird
08:21:34 --> Rym has joined #instantbird
08:42:53 <-- jb has quit (Ping timeout)
08:53:01 --> Bollebib has joined #instantbird
09:25:39 <-- nhnt11 has quit (Ping timeout)
09:26:57 --> nhnt11 has joined #instantbird
09:29:38 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
09:32:16 --> chrisccoulson has joined #instantbird
09:35:35 <-- Bollebib has quit (Ping timeout)
09:36:51 --> Bollebib has joined #instantbird
09:58:30 --> gerard-majax_ has joined #instantbird
10:23:04 <-- Rym has quit (Ping timeout)
10:27:05 --> BWMerlin has joined #instantbird
10:27:08 <flo-retina> so, now that we have a green tree (the Linux failure is random, the Windows one is just that the VM has rebooted and didn't find the right SDK), what can land?
10:27:11 --> Rym has joined #instantbird
10:27:12 <flo-retina> nhnt11: what's up?
10:28:06 <flo-retina> bah, the Windows reboot was because it installed updates
10:28:09 * flo-retina should disable that
10:28:58 --> clokep has joined #instantbird
10:28:58 * ChanServ sets mode +o clokep 
10:33:13 <clokep>  flo-retina: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=keyword%3Acheckin-needed%20product%3A%22Instantbird%20Servers%22%2CInstantbird%2C%22Chat%20Core%22&list_id=11003052 ?
10:33:37 <flo-retina> is TB also green?
10:35:58 * clokep doubts it.
10:36:02 <flo-retina> instead of restarting buildbot by hand on the Windows VM, I've set the service's startup to "Automatic (delayed start)"
10:36:27 <flo-retina> according to stack overflow that starts it 2 minutes after the last "Automatic" startup service has started
10:38:50 <instant-buildbot> build #1484 of win32-nightly-default is complete: Failure [4failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1484
10:39:02 <flo-retina> ok, so it's not a race condition during startup
10:46:32 <flo-retina> nhnt11: so where is the updated patch for bug 955014?
10:46:37 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=955014 enh, --, ---, nhnt11, ASSI, Indexed logs & efficient search
10:47:31 * clokep tried to fix bug 1030059 last night.
10:47:35 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1030059 maj, --, ---, nobody, NEW, Passwords gone in newest nightly
10:47:35 <clokep> But apparently made no progress. :-\
10:48:54 <flo-retina> nhnt11: is bug 1025522 ready to land? Where is the try push? TB is in compiling shape (and has been for at least a day or two I think)
10:48:57 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1025522 nor, --, ---, nhnt11, ASSI, Split log files to prevent them from growing too large
10:53:04 <flo-retina> nhnt11: also, in which bug is your infinite scroll WIP? There's no attachment in bug 1043902
10:53:07 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1043902 enh, --, ---, nobody, NEW, When a conversation is restored from hold, display only the newest few messages and prepend more as 
10:53:08 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
11:01:35 --> sonny has joined #instantbird
11:02:59 <nhnt11> flo-retina: I didn't get a chance to work on the indexed logs patch yesterday, I've been having trouble merging two prepended message bubbles.
11:03:09 <nhnt11> I've got a holiday today, I'm going to give you patches soon.
11:03:28 <nhnt11> I haven't attached a WIP yet, because I wanted a working use case to demonstrate it
11:03:37 <nhnt11> I did share a pastebin a few days ago
11:03:42 <flo-retina> pastebins get lost
11:03:44 <nhnt11> I'll upload what I've got so far if you'd like
11:04:03 <flo-retina> WIPs (they aren't expected to work, or they wouldn't be WIPs ;)) are better to give feedback
11:04:05 <nhnt11> But I'd like to get bubble-merging working before I do
11:04:08 <nhnt11> Okay
11:04:11 <flo-retina> nhnt11: please push the log splitting stuff to try :)
11:04:49 <nhnt11> Okay, sorry for the delay.
11:05:14 * flo-retina would like to see stuff landing ;)
11:05:44 <nhnt11> flo-retina: Is the tree in good enough shape that I can do a checkout locally?
11:05:59 <nhnt11> I've been working on an old revision out of fear that I won't be able to compile
11:06:04 <flo-retina> nhnt11: IB is all green
11:06:11 <nhnt11> Alright, thanks
11:06:42 <flo-retina> TB seems "buildable"
11:06:47 <flo-retina> tests are orange
11:07:01 <flo-retina> but if they run, that means the code compiled :)
11:07:13 <nhnt11> Yeah, sounds good.
11:07:15 * nhnt11 runs a checkout
11:07:44 <nhnt11> I'll back up my objdir just in case though...
11:20:22 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:20:31 --> nhnt11 has joined #instantbird
11:27:17 <-- EionRobb has quit (Quit: Leaving.)
11:31:32 --> mayanktg has joined #instantbird
11:34:45 --> clokep_work has joined #instantbird
11:34:45 * ChanServ sets mode +o clokep_work 
11:35:13 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
11:35:19 --> nhnt11 has joined #instantbird
11:42:59 <nhnt11> Uh, it appears the DIRS/PARALLEL_DIRS issue hasn't been fixed yet?
11:43:06 * nhnt11 goes to the bug
11:43:16 <clokep_work> nhnt11: Did you pull c-c? and purple?
11:43:40 * nhnt11 forgot to pull purple, duh
11:45:06 <-- redDragon has quit (Client exited)
11:48:13 <-- mayanktg has quit (Ping timeout)
11:48:37 --> mayanktg has joined #instantbird
12:02:58 <clokep_work> nhnt11: That work for  you?
12:03:08 <nhnt11> Yeah, build just finished
12:04:20 --> ogi has joined #instantbird
12:05:47 <clokep_work> :)
12:12:50 <mayanktg> clokep_work: Sorry for that huge diff I gave yesterday., here's a shorter one http://pastebin.instantbird.com/836749. How can I compare and check for the right resource i.e. session-terminate stanza is only from the person I'm in call with?
12:13:20 <mayanktg> Line 15
12:13:22 <clokep_work> mayanktg: I don't understand the question.
12:15:53 <mayanktg> When I get a session-terminate stanza the conversation should be notified about it only if it's from the contact I'm in call with. Else there might be a case in which some other contact sends me a session-terminate stanza and my ongoing call gets disconnected. I want a check for this condition.
12:17:52 <mayanktg> A & B are in video call. But C sends a session-terminate stanza to A which causes call-termination. I want to check that call is disconnected only if the stanza is coming from B.
12:33:21 <clokep_work> mayanktg: What does that have to do with resources? :-S
12:35:26 <clokep_work> mayanktg: If that's in the context of the conversation you should just be able to get the user's JID and check if they match.
12:39:58 <mayanktg> clokep_work: Ok, I was talking in the context of the conversation only, I'm unable to find the user's JID. Is there an example in the code where it has been done? I'm not able to lfind it. :|
12:41:10 <clokep_work> mayanktg: I believe it is http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp.jsm#240
12:41:20 <clokep_work> (Which I just found in less than 20 seconds...I doubt you looked very hard for it.)
12:43:06 <-- BWMerlin has quit (Quit: BWMerlin)
12:43:06 <mayanktg> Using to  ...I was unable to call it from XMPPAccountPrototype. Sorry.
12:43:51 <instant-buildbot> build #1485 of win32-nightly-default is complete: Success [3build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1485
12:44:29 <clokep_work> mayanktg: I'm not entirely sure what you mean, but my guess is you have to get the conversation first.
12:48:28 <clokep_work> mayanktg: Why don't we start with this...what information does the message actually give you?
12:50:12 <mayanktg> clokep_work: Ok. By message you mean the session terminate IQ Stanza right? 
12:50:32 <clokep_work> Yes.
12:51:16 <mayanktg> http://pastebin.instantbird.com/836836 is the stanza received. The iq node contains the from attribute and also the jingle node contains the initiator attribute.
12:52:01 <clokep_work> Alright, so all you need to do is use the sid (f2adaafe-a2e0-4347-9471-6a9f75d8f168) to see if there are open calls, right?
12:52:08 <clokep_work> That's how you're storing calls IIRC.
12:54:45 <mayanktg> No :( I used different SID for the session-initate/accept/terminate stanzas.
12:55:30 <clokep_work> Is that what you're supposed to do?
12:55:33 <clokep_work> flo-retina: ^
12:55:38 <clokep_work> (I don't know XMPP super well.)
12:55:47 <clokep_work> But I thought that was an ID for the session.
12:56:19 <mayanktg> Just a second I'm re-reading the XEP
12:58:50 <mayanktg> I need to store the SID...the seesion-initate/accept/termiante uses the same SID in the examples at XEP-0167 http://xmpp.org/extensions/xep-0167.html :-| 
12:59:24 <mayanktg> Understood what I needs to be done.
13:02:00 <nhnt11> I'm pushing to try
13:02:22 <nhnt11> Hmm actually...
13:02:30 <nhnt11> I'll upload a new patch for indexed logs and push that as well
13:02:44 <-- mayanktg has quit (Ping timeout)
13:02:49 <clokep_work> mayanktg: Alright, you'll probably need a map of session ID -> open calls.
13:04:44 --> mayanktg has joined #instantbird
13:05:32 <flo-retina> "I need to store the SID" I'm pretty sure one of my review comments said that.
13:06:24 <-- mayanktg has quit (Ping timeout)
13:06:55 --> mayanktg has joined #instantbird
13:16:00 * flo-retina doesn't see nhnt11's try push
13:16:22 <flo-retina> more than 2 hours later
13:17:09 <nhnt11> flo-retina: I thought I'd update the indexing patch and then push
13:17:22 <nhnt11> But fine, I'll push just split log files now
13:18:31 <flo-retina> sure, update the indexing patch and push it. Separately ;)
13:18:47 <flo-retina> or on top of the other but in a second push
13:18:54 <nhnt11> ok
13:20:20 <-- mayanktg has quit (Ping timeout)
13:20:30 --> mpmc has joined #instantbird
13:20:58 --> mayanktg has joined #instantbird
13:22:38 <-- mayanktg has quit (Ping timeout)
13:23:28 --> mayanktg has joined #instantbird
13:24:51 --> nhnt12 has joined #instantbird
13:25:09 <-- mayanktg has quit (Ping timeout)
13:25:31 <-- nhnt11 has quit (Ping timeout)
13:25:38 * nhnt12 is now known as nhnt11
13:25:39 --> mayanktg has joined #instantbird
13:27:31 <nhnt11> https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=525928b1a545
13:29:11 <-- nhnt11 has quit (Ping timeout)
13:30:01 <mayanktg> clokep_work: Done. Thanks a lot. :)
13:30:03 --> nhnt11 has joined #instantbird
13:31:38 <flo-retina> nhnt11: is that change affecting gloda?
13:32:11 <nhnt11> flo-retina: No.
13:32:32 <flo-retina> ok
13:32:39 * flo-retina hopes we aren't going to break mozmill tests
13:35:12 <nhnt11> flo-retina: Okay I don't know how I overlooked this, but gloda should have been updated for the split log files patch
13:35:21 <nhnt11> It's trivial-ish, but it needs to be done
13:36:47 <clokep_work> mozmill? :-\
13:42:32 <-- mayanktg has quit (Ping timeout)
13:42:54 <flo-retina> clokep_work: gloda tests are probably in the mozmill suite, right?
13:42:56 --> mayanktg has joined #instantbird
13:53:50 <-- mayanktg has quit (Ping timeout)
13:54:19 --> mayanktg has joined #instantbird
13:57:37 --> mconley has joined #instantbird
14:00:08 <-- mayanktg has quit (Ping timeout)
14:00:37 --> mayanktg has joined #instantbird
14:03:57 <-- mayanktg has quit (Ping timeout)
14:04:21 --> mayanktg has joined #instantbird
14:05:13 --> mayanktg-ph has joined #instantbird
14:05:16 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
14:07:07 <clokep_work> flo-retina: Maybe. Those are two words I avoid. :)
14:15:10 <nhnt11> These are the changes required for gloda to work with split log files: http://pastebin.instantbird.com/837009
14:15:20 <nhnt11> I'm going to get some dinner, I'll upload a patch when I'm bakc
14:54:13 <-- sonny has quit (Ping timeout)
15:24:07 --> sonny has joined #instantbird
15:27:58 --> mayanktg has joined #instantbird
15:28:18 <-- mayanktg-ph has quit (Quit: )
15:30:35 <-- mayanktg has quit (Ping timeout)
15:31:01 --> mayanktg has joined #instantbird
15:32:41 <-- mayanktg has quit (Ping timeout)
15:33:06 --> mayanktg has joined #instantbird
15:45:36 <-- mayanktg has quit (Ping timeout)
15:46:00 --> mayanktg has joined #instantbird
16:01:54 <-- mayanktg has quit (Ping timeout)
16:02:23 --> mayanktg has joined #instantbird
16:15:44 <-- mayanktg has quit (Ping timeout)
16:16:08 --> mayanktg has joined #instantbird
16:23:36 <-- sonny has quit (Ping timeout)
16:34:17 <-- nhnt11 has quit (Ping timeout)
16:36:17 --> arlolra has joined #instantbird
16:39:19 --> Mook_as has joined #instantbird
16:52:41 --> jb has joined #instantbird
17:05:59 <-- Rym has quit (Ping timeout)
17:19:31 --> Rym has joined #instantbird
17:31:43 <-- jb has quit (Quit: jb)
17:42:12 <-- mayanktg has quit (Ping timeout)
17:42:36 --> mayanktg has joined #instantbird
17:50:54 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
17:50:56 --> mpmc has joined #instantbird
17:52:38 <-- mayanktg has quit (Ping timeout)
17:53:01 --> mayanktg has joined #instantbird
17:54:16 <-- mpmc has quit (Connection reset by peer)
17:55:28 --> mpmc has joined #instantbird
18:02:12 <-- mayanktg has quit (Ping timeout)
18:02:41 --> mayanktg has joined #instantbird
18:04:21 <-- mayanktg has quit (Ping timeout)
18:04:47 --> mayanktg has joined #instantbird
18:18:10 --> clokep_w1 has joined #instantbird
18:19:02 <-- clokep_work has quit (Ping timeout)
18:28:14 <-- Rym has quit (Ping timeout)
18:29:06 --> Rym has joined #instantbird
18:29:58 --> mali has joined #instantbird
18:38:16 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:42:26 --> qheaden has joined #instantbird
18:52:12 * clokep_w1 is now known as clokep_work
19:06:19 <-- gerard-majax_ has quit (Quit: Ex-Chat)
19:06:22 --> gerard-majax_ has joined #instantbird
19:11:49 --> nhnt11 has joined #instantbird
19:13:29 <-- nhnt11 has quit (Ping timeout)
19:14:34 --> nhnt11 has joined #instantbird
19:14:54 <nhnt11> Hmm, looks like my try push wasn't very useful
19:16:32 <-- arlolra has quit (Quit: arlolra)
19:23:06 <-- Bollebib has quit (Ping timeout)
19:39:24 --> Bollebib has joined #instantbird
19:42:16 <nhnt11> flo-retina: ping
19:44:10 <clokep_work> nhnt11: What's up?
19:44:42 <nhnt11> clokep_work: There are two ways I see to make gloda work with split log files, and I'm wondering which one is best.
19:45:04 <nhnt11> We either modify getLogPathForConversation to return all the paths instead of just the current one
19:45:05 <clokep_work> Ah, yeah you'll need to talk to Florian. I think.
19:45:09 <nhnt11> yeah
19:45:09 <clokep_work> But leave a message. *BEEP*
19:45:18 <nhnt11> Heh
19:45:38 <nhnt11> Anyway, the second idea is to have an observer notification when a log file is split, but I think that's overkill
19:46:29 * nhnt11 has already implemented the first solution, but observer notifications is maybe not /too/ bad an idea for log files
19:46:38 <nhnt11> Nah, it's overkill I think
19:53:21 <-- clokep_work has quit (Ping timeout)
19:57:55 --> gerard-majax__ has joined #instantbird
19:58:03 <-- gerard-majax_ has quit (Quit: Ex-Chat)
19:58:35 <-- gerard-majax__ has quit (Connection reset by peer)
19:58:38 --> gerard-majax_ has joined #instantbird
20:14:13 <-- mayanktg has quit (Ping timeout)
20:14:52 --> mayanktg has joined #instantbird
20:15:28 <-- ogi has quit (Client exited)
20:19:02 <-- mayanktg has quit (Ping timeout)
20:21:01 --> mayanktg has joined #instantbird
20:36:08 <-- Rym has quit (Ping timeout)
20:49:19 --> clokep has joined #instantbird
20:49:19 * ChanServ sets mode +o clokep 
21:01:39 <-- Bollebib has quit (Ping timeout)
21:12:29 <-- mconley has quit (Input/output error)
21:15:31 --> Rym has joined #instantbird
21:26:27 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
21:33:12 <-- BillBinkley has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com)
21:49:24 --> BWMerlin has joined #instantbird
21:50:29 --> sonny has joined #instantbird
22:22:05 <-- mali has quit (Ping timeout)
22:41:03 --> clokep_work has joined #instantbird
22:41:03 * ChanServ sets mode +o clokep_work 
22:46:59 * Fallen|away is now known as Fallen
23:06:11 <-- clokep_work has quit (Ping timeout)
23:11:35 <-- sonny has quit (Ping timeout)
23:22:46 <-- mayanktg has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com)
23:34:51 <-- Rym has quit (Ping timeout)
23:51:43 --> Rym has joined #instantbird