All times are UTC.
00:06:17 <-- Hadi has quit (Ping timeout) 00:49:00 <-- Armada has quit (Connection reset by peer) 03:09:25 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 03:17:08 --> clokep has joined #instantbird 03:17:08 * ChanServ sets mode +o clokep 03:23:26 <instantbot> New Chat Core - IRC bug 1048678 filed by email@example.com. 03:23:27 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1048678 min, --, ---, nobody, NEW, Implement CTCP Client Info command 03:25:34 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 03:30:05 <instant-buildbot> build #2295 of macosx-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/2295 03:45:19 <instant-buildbot> build #1118 of linux-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/1118 04:16:04 <-- nhnt11 has quit (Ping timeout) 04:34:53 <instant-buildbot> build #13 of linux64-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/linux64-nightly-default/builds/13 04:58:41 <-- gerard-majax__ has quit (Ping timeout) 06:01:25 <instant-buildbot> build #1472 of win32-nightly-default is complete: Success [3build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1472 06:13:56 <-- EionRobb has quit (Quit: Leaving.) 06:14:24 --> jb has joined #instantbird 06:38:00 * Fallen|away is now known as Fallen 07:01:34 --> jb1 has joined #instantbird 07:01:39 <-- jb has quit (Connection reset by peer) 07:38:01 --> mpmc has joined #instantbird 07:44:36 --> aleth has joined #instantbird 07:44:36 * ChanServ sets mode +o aleth 07:45:07 <aleth> Four nightlies again :-) 07:49:27 <-- aleth has quit (Quit: exit stage left) 07:49:30 --> aleth has joined #instantbird 07:49:30 * ChanServ sets mode +o aleth 07:51:10 --> BWMerlin has joined #instantbird 07:53:52 --> gerard-majax__ has joined #instantbird 08:10:14 --> Bollebib has joined #instantbird 08:16:39 <-- aleth has quit (Ping timeout) 08:22:11 --> nhnt11 has joined #instantbird 08:22:40 <flo-retina> aleth: "again"? I think it's a first! :-D 08:23:01 <nhnt11> :) 08:23:41 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:23:47 --> nhnt11 has joined #instantbird 08:24:40 <-- nhnt11 has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 08:24:45 --> nhnt11 has joined #instantbird 08:31:52 <-- jb1 has quit (Ping timeout) 08:34:26 --> jb has joined #instantbird 09:01:09 --> aleth has joined #instantbird 09:01:09 * ChanServ sets mode +o aleth 09:01:35 <-- nhnt11 has quit (Ping timeout) 09:01:52 <aleth> flo-retina: maybe the second time? :) 09:02:11 --> nhnt11 has joined #instantbird 09:02:44 <aleth> TB is still busted on Windows. 09:05:04 <flo-retina> aleth: well, we had 4 "nightlies" on July 24th, but the linux 64 one was started by hand during day time 09:06:12 <flo-retina> aleth: I wonder if the linux failure we saw yesterday is just random 09:06:21 <flo-retina> but it's surprising it failed on both slaves the same night 09:06:48 <aleth> flo-retina: I was wondering if it might be due to something landing on m-c that was backed out again 09:07:08 <aleth> But that sounds a bit random. 09:10:35 <flo-retina> doesn't matter; we have nightlies today 09:10:45 <flo-retina> is there any im/-only patch that should land before it's busted again? 09:10:50 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:10:53 <aleth> nhnt11: Can you please get log indexing landed before flo leaves on holiday? 09:11:04 <aleth> flo-retina: Generic icons maybe? 09:11:40 <nhnt11> aleth: Yeah, it's priority 09:11:46 * nhnt11 has all day today 09:12:06 <nhnt11> Your latest comments are pretty trivial 09:12:30 <nhnt11> I'll upload a new Tb patch soon 09:16:34 <aleth> Iirc there were some comments on the UI patch too 09:21:33 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 09:21:54 <nhnt11> aleth: In the logging test, there are 6 log files, 4 of which are "bad". Both the remaining ones contain the word "Nothing" 09:22:09 <nhnt11> Actually both the remaining ones are pretty much identical except for the dates 09:22:19 --> chrisccoulson has joined #instantbird 09:24:38 * nhnt11 writes a new set of messages for the second day. 09:25:09 <aleth> Or just add another day, whatever is quicker. 09:29:19 --> sonny has joined #instantbird 09:36:35 <nhnt11> Oh, I seem to have not uploaded the UI patch. no wonder 09:38:36 <nhnt11> Bah, duplication 09:40:55 <nhnt11> Hmm, I should check that only one log was returned by the search 09:42:31 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 09:45:04 <aleth> nhnt11: In your filteredLogs test, where are you checking only the right days are returned? 09:45:25 <nhnt11> I just added a line to do that, sorry for rushing the patch 09:45:52 <aleth> No worries, I agree there's not much left to be done ;) 09:46:35 <aleth> Oh, and did you see http://log.bezut.info/instantbird/140804/#m419 09:46:41 <nhnt11> aleth: Can I test the date and leave it (and get rid of the testMsgs call) 09:47:01 <aleth> nhnt11: Yes, that seems OK (you test log reading elsewhere after all) 09:47:59 <nhnt11> Oh yeah, meant to look that up (the pref thing) 09:48:57 <nhnt11> Not really sure where this may be documented 09:49:03 <nhnt11> I don't see anything in the article for nsIPrefBranch 09:49:39 * nhnt11 tests it manually 09:49:59 <aleth> Or you have to ask someone who touched that code ;) 09:50:14 <aleth> Yoric would probably know, come to think of it. 09:50:33 <nhnt11> aleth: I created a new pref and force quit Ib. The pref persisted. 09:50:50 <nhnt11> There's a possibility that it's async of course 09:50:55 <aleth> Right. 09:51:03 <nhnt11> (but it's definitely not written at shutdown) 09:51:06 <aleth> You can't manually test this easily. 09:51:12 <aleth> I know it's not written at shutdown. 09:51:25 <nhnt11> Yoric was last seen 4 days ago 09:52:24 * nhnt11 searches mxr 09:56:00 <nhnt11> Nothing too useful, I think 09:57:49 --> Armada has joined #instantbird 10:36:03 --> flo-retina has joined #instantbird 10:36:03 * ChanServ sets mode +qo flo-retina flo-retina 10:36:34 <flo-retina> aleth: after the update my instantbird restarted in the background :-/. 10:36:36 <flo-retina> there may be something we have to port to fix that 10:49:27 <-- aleth has quit (Ping timeout) 11:03:11 --> mpmc has joined #instantbird 11:05:56 --> aleth has joined #instantbird 11:05:56 * ChanServ sets mode +o aleth 11:06:52 <-- nhnt11 has quit (Ping timeout) 11:18:14 <-- jb has quit (Ping timeout) 11:23:22 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 11:23:24 --> mpmc has joined #instantbird 11:23:38 --> clokep has joined #instantbird 11:23:39 * ChanServ sets mode +o clokep 11:34:50 <clokep> Hello. 11:35:16 <clokep> flo-retina: aleth: I dumped some thoughts into a bug for CLIENTINFO and I'd appreciate comments. ;) 11:38:28 --> nhnt11 has joined #instantbird 11:43:25 <aleth> clokep: Thanks! That, umm, spec is the usual IRC messiness. Human readable, wtf? 11:43:57 <aleth> Thankfully it seems the CLIENTINFO messages we've seen from other clients have ignored that part ;) 11:45:07 <clokep> aleth: Yeah, I tried a couple of people yesterday and it seems to ignore the parameter and just return the list every time. 11:50:47 <nhnt11> aleth: Thanks for asking on #developers 11:50:59 <nhnt11> So I'll get rid of the prefs stuff in indexLogFile 11:51:20 * nhnt11 highly doubts that writing another file for "protection purposes" is worth it there. 12:00:34 <aleth> nhnt11: There may be a better way. 12:00:54 <aleth> How about storing to the pref when a log file is created, and removing it after it is indexed? 12:01:00 <flo-retina> aleth: we do sync pref writes for our crash-on-autologin-detection 12:02:09 <flo-retina> aleth: http://mxr.mozilla.org/comm-central/source/chat/components/src/imAccounts.js#42 12:04:34 <aleth> flo-retina: I don't think we want to force a sync pref write every time we index a log file. 12:04:59 <flo-retina> why would we do that? 12:05:06 <aleth> Indeed :) 12:12:44 <nhnt11> aleth: http://pastebin.instantbird.com/800829 12:13:12 <nhnt11> We wouldn't need to mess with the pending files pref in the AsyncShutdown blocker then 12:14:48 <aleth> nhnt11: That looks much better to me :) 12:18:20 <nhnt11> I don't think we need to yield on the indexing queue and so on anymore either in the AsyncShutdown blocker 12:21:05 <aleth> Hmm, true. You just have to ensure the database is closed after the current operation and then stays closed? 12:21:22 <nhnt11> Yeah 12:21:51 <aleth> It's the db queue that matters. 12:24:30 <nhnt11> I think this is good enough: http://pastebin.instantbird.com/800866 12:24:53 <nhnt11> s/filesToBeIndex/filesToBeIndexed/ on line 47 12:26:18 <aleth> Looks OK to me. 12:26:33 <nhnt11> Tested ok. 12:26:34 <aleth> Nice simplification :) 12:26:44 --> ogi has joined #instantbird 12:27:01 <nhnt11> I'm requesting review from flo-retina 12:27:10 <flo-retina> I'm hiding from nhnt11 12:27:11 <flo-retina> :-P 12:27:23 <aleth> nhnt11: Yup! 12:29:51 * nhnt11 looks at the TB part of the patch 12:29:59 <nhnt11> s/patch/bug/ 12:34:50 <aleth> Mach incremental builds are broken since the recent changes btw, but I suspect pseudo-rework may fix it, so I'm not looking into it yet. 12:35:50 <nhnt11> http://pastebin.instantbird.com/800887 :S 12:35:54 <nhnt11> That's after a clobber.. 12:36:36 <nhnt11> I have no idea how recent my tree is though. 12:36:44 <aleth> nhnt11: try https://hg.mozilla.org/comm-central/rev/9594eef26b92 12:36:48 <nhnt11> I haven't pulled in a while fearing bustages 12:37:09 <nhnt11> Thanks 12:38:10 <aleth> I *think* TB should probably build on Mac currently, but I have not seen it confirmed, so it may not be worth risking a pull. 12:39:41 <flo-retina> aleth: "Mach incremental builds are broken" what does that mean exactly? 12:40:07 * aleth wonders how pseudo-rework can possibly work without eliminating c-c/build 12:40:22 <flo-retina> magic :-P 12:41:39 <aleth> flo-retina: http://pastebin.instantbird.com/800918 (looks like yet another change to that recursivemake.py file would be needed) 12:42:44 <flo-retina> aleth: what about just ./mach build ? 12:42:52 <flo-retina> is mach a symlink to mozilla/mach ? 12:43:01 <aleth> That works, of course. 12:43:06 <aleth> Yes 12:43:15 <flo-retina> that's what I call incremental build 12:43:15 <-- BWMerlin has quit (Quit: BWMerlin) 12:43:38 <flo-retina> I only expect |mach build im| to work if you haven't pulled m-c between the 2 builds 12:43:39 <aleth> Right, that's also incremental, just less incremental ;) 12:44:18 <aleth> flo-retina: Of course it has known limitations. That's not what I'm talking about. 12:52:10 <-- ogi has quit (Client exited) 12:55:45 --> nhnt11-tb has joined #instantbird 12:56:19 <nhnt11-tb> Well there are a few errors in the console, but none of them are related to logger.js :) 12:56:38 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 12:56:59 --> qheaden has joined #instantbird 13:00:23 <nhnt11> So, a module for chatLogTreeView 13:00:29 * nhnt11 creates a new fiel 13:00:31 <nhnt11> file* 13:02:11 <flo-retina> is that really useful? 13:02:24 <flo-retina> aleth: don't we intend to get rid of the Ib log viewer "soon"? 13:02:29 <flo-retina> anyway, whatever :) 13:02:34 <flo-retina> it won't hurt 13:04:09 <aleth> flo-retina: I suggested to only do it if it was almost as fast as manually porting the required changes 13:04:27 <flo-retina> ok :) 13:05:24 <nhnt11> aleth: Should I not bother until the next time changes are required then? 13:05:30 <nhnt11> (that would make sense..) 13:05:47 <-- sonny has quit (Ping timeout) 13:06:20 <aleth> nhnt11: OK (I thought you had to port chatlogtreeview changes anyway) 13:06:46 <nhnt11> aleth: There were two 1-line changes, I've already uploaded a patch 13:06:49 <aleth> Don't spend much time on it, anyway. 13:07:00 <-- gerard-majax__ has quit (Ping timeout) 13:07:04 <aleth> Better to get to the log prepending. 13:07:06 <clokep> But filing a bug might be nice. :) 13:08:22 <flo-retina> where are we with the log prepending? 13:09:25 <aleth> nhnt11: So that TB UI patch you have atm is complete? 13:09:45 <nhnt11> flo-retina: I've got message prepending working nicely. Next thing is to use it for restoring conversations from hold 13:09:57 <nhnt11> aleth: The one I uploaded a few minutes ago is complete, yes. 13:10:00 <nhnt11> I ran a build and tested it 13:10:20 <flo-retina> has that "working nicely" thing been reviewed yet? 13:10:39 <nhnt11> flo-retina: you mean the asyncshutdown thing? 13:10:47 <nhnt11> flo-retina: aleth looked at a pastebin on IRC 13:12:14 <aleth> It can't properly be reviewed until it's in the context of something that is useable. 13:12:17 <flo-retina> I mean message prepending 13:12:35 <nhnt11> oh 13:12:36 <nhnt11> oops 13:12:52 <nhnt11> no it hasn't been reviewed 13:14:31 --> sonny has joined #instantbird 13:17:36 <aleth> It has to get to the point where it's passed the checklist we had in an etherpad first ;) 13:23:57 --> gerard-majax__ has joined #instantbird 13:24:09 <-- sonny has quit (Ping timeout) 13:27:59 --> sonny has joined #instantbird 13:34:00 <-- sonny has quit (Ping timeout) 13:34:09 --> jb has joined #instantbird 13:37:35 --> clokep_work has joined #instantbird 13:37:35 * ChanServ sets mode +o clokep_work 13:38:07 --> sonny has joined #instantbird 13:42:49 <nhnt11> I don't know what to do with the return value of showLogList 13:43:06 * nhnt11 checks consumers 13:43:31 <-- aleth has quit (Ping timeout) 13:43:55 <nhnt11> Okay, I can make it return a promise, never mind. 13:59:42 --> nhnt11-tb has joined #instantbird 14:02:15 * nhnt11 wonders where PROTO_TREE_VIEW comes from 14:03:01 <clokep_work> MXR! 14:03:07 <nhnt11> Already on it 14:05:22 <nhnt11> Hmm, moving chatLogTree to a module means we don't have access to the stuff in jsTreeView.js 14:05:28 <nhnt11> (since it's no longer an overlay..) 14:05:37 * clokep_work wonders if somewhere there's a good reference about what needs to happen for a webrtc handshake. 14:07:11 <flo-retina> clokep_work: can you be a bit more specific? 14:07:55 <clokep_work> flo-retina: So there's this SDP that gets sent back and forth... 14:07:57 <flo-retina> are you asking about what happens under the hood? What the webapp using webrtc is expected to do? something else? 14:08:00 <clokep_work> How does that work? 14:08:31 <flo-retina> clokep_work: so the caller creates an "offer". That's an SDP. 14:08:48 <flo-retina> the callee, if the call is accepted creates an "answer", that's also an SDP string. 14:09:02 <flo-retina> once the 2 have been exchanged, clients are ready to start a P2P connection 14:09:45 <flo-retina> the SDP string contains information about the network, about the type of media in the call (is it audio only or audio/video or only a data channel?) and about available the codecs 14:10:00 <flo-retina> there's also encryption details in the SDP 14:10:07 <flo-retina> clokep_work: does that help? 14:11:03 <clokep_work> flo-retina: Ah, I didn't realize it was that simple. Is there not acking back and forth or anything? 14:11:27 <flo-retina> that's not part of webrtc 14:11:44 <flo-retina> it can be part of xmpp, or any other protocol used by the web app 14:12:09 <clokep_work> Hm. OK. 14:12:23 <flo-retina> xmpp will typically ack any iq stanza 14:15:30 <clokep_work> Alright. 14:19:08 <flo-retina> for IRC, I think you could just skip that 14:19:40 <clokep_work> Yes, most likely. 14:19:53 <clokep_work> I'd still like to see an example SDP that has each line explained. :-D 14:20:13 <clokep_work> Ah, wikipedia to the rescue! http://en.wikipedia.org/wiki/Session_Description_Protocol 14:24:53 <flo-retina> clokep_work: I don't know all the lines myself, but I know enough to be able to figure out the overall meaning of a webrtc sdp 14:26:01 <clokep> flo-retina: So I was wondering if there was a start / end line and if the ordering matters. 14:26:14 <flo-retina> the order matters 14:26:25 <flo-retina> I think lines are \r\n separated 14:28:32 <clokep> Yeah OK. 14:31:46 <-- sonny has quit (Ping timeout) 14:36:08 <-- clokep_work has quit (Ping timeout) 14:40:20 <nhnt11> flo-retina: So chatLogTreeView uses jsTreeView.js, which is included as a script in the relevant XUL file, for its prototype. I'm not clear on the best step forward, since jsTreeView.js seems to be something we control (it exists as (messenger|instantbird)/content/jsTreeView.js). Should I be modifying that file, or importing it into the module somehow or something else? 14:41:03 <flo-retina> nhnt11: I think aleth told you to not spend too much time on this "make the log tree a module" thing 14:41:15 <flo-retina> if it's turning out to be more difficult than expected, just ignore it 14:41:31 <nhnt11> Right, that was an option if there wasn't a simple answer 14:41:32 <nhnt11> thanks 14:42:37 <-- nhnt11-tb has quit (Client exited) 14:48:09 --> mconley has joined #instantbird 14:50:29 --> nhnt11-tb has joined #instantbird 14:50:41 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 14:50:56 --> nhnt11-tb has joined #instantbird 14:51:27 --> sonny has joined #instantbird 14:51:43 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 14:52:08 --> nhnt11-tb has joined #instantbird 14:53:08 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 14:56:15 --> nhnt11-tb has joined #instantbird 14:56:52 <-- nhnt11-tb has quit (Quit: nhnt11-tb) 15:05:44 --> aleth has joined #instantbird 15:05:44 * ChanServ sets mode +o aleth 15:11:41 <-- jb has quit (Connection reset by peer) 15:11:54 --> jb has joined #instantbird 15:18:24 --> iamjayakumars has joined #instantbird 15:34:44 <-- aleth has quit (Ping timeout) 15:35:48 --> aleth has joined #instantbird 15:35:48 * ChanServ sets mode +o aleth 15:35:55 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 15:58:07 <-- gerard-majax__ has quit (Ping timeout) 16:09:14 <-- flo-retina has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 16:13:47 <-- aleth has quit (Ping timeout) 16:21:22 --> aleth has joined #instantbird 16:21:22 * ChanServ sets mode +o aleth 16:25:49 <-- iamjayakumars has quit (Ping timeout) 16:32:32 --> iamjayakumars has joined #instantbird 16:39:00 <-- clokep has quit (Quit: Instantbird 1.5 -- http://www.instantbird.com) 16:48:48 --> gerard-majax__ has joined #instantbird 16:52:11 --> mconley_ has joined #instantbird 16:53:04 <-- mconley has quit (Ping timeout) 16:56:58 * mconley_ is now known as mconley 16:57:40 <aleth> heh, looks like my question on pref writing triggered a discussion on how best to asyncify the pref system 17:07:06 * nhnt11 is intrigued by the word "DelayedTask" 17:07:08 <nhnt11> Is that a thing? 17:07:23 <nhnt11> It would be way cleaner than setting/clearing timeouts 17:08:06 <nhnt11> No mention on dxr, never mind 17:09:25 <-- gerard-majax__ has quit (Ping timeout) 17:09:56 <aleth> There's a bug filed somewhere on something similar, but idk how much traction it has 17:10:33 <-- iamjayakumars has quit (Client exited) 17:11:01 --> iamjayakumars has joined #instantbird 17:11:24 <nhnt11> aleth: Btw re. your review comments, I assumed that since that code was calling showLogList, it indeed wanted to build the tree and not just check if logs existed 17:11:52 <aleth> It's possible that that's important - I was asking you to find out ;) 17:12:14 <aleth> i.e. does it replace or hide the existing tree or something. 17:12:55 <-- iamjayakumars has quit (Ping timeout) 17:17:59 <nhnt11> It appears to be showing a "noPreviousConvScreen" if there are no previous conversations when a contact is clicked 17:18:17 <nhnt11> I don't think the new code is changing any existing behavior 17:20:11 <aleth> OK, let's keep it, it may release some memory early. 17:22:05 <aleth> Looking forward to finally having this in nightlies! 17:22:24 <aleth> (assuming it passed flo and try ;) ) 17:22:36 * nhnt11 looks forward to making progress on the convbrowser 17:22:55 <aleth> nhnt11: bug 1035844 is marked as blocking indexed logs 17:22:58 <instantbot> Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1035844 nor, --, ---, nhnt11, ASSI, logger.js should add its profileBeforeChange blocker on OS.File instead of AsyncShutdown 17:23:31 <nhnt11> aleth: That already has an r+ patch iirc 17:23:34 <nhnt11> Yeah, it does. 17:23:44 <aleth> OK, cool. 17:24:19 <aleth> You may be able to stack all these in a single try push to save time. 17:24:35 <nhnt11> Yeah. 17:24:59 <nhnt11> May be good to have multiple pushes to see where errors are coming from though 17:25:23 <aleth> Sure... it depends on your confidence in the code ;) 17:25:39 * nhnt11 thinks stuff will work, but that doesn't mean it will. 17:26:03 <aleth> Though I suppose you can do multiple pushes at once, in which case it doesn't cost extra time. 17:31:07 --> flo-retina has joined #instantbird 17:31:07 * ChanServ sets mode +qo flo-retina flo-retina 17:34:36 <-- nhnt11 has quit (Ping timeout) 17:48:58 --> mali has joined #instantbird 17:53:44 --> nhnt11 has joined #instantbird 17:56:05 --> rosonline has joined #instantbird 17:56:54 <-- nhnt11 has quit (Ping timeout) 17:57:56 --> nhnt11 has joined #instantbird 18:05:23 <-- jb has quit (Ping timeout) 18:13:09 --> Mook_as has joined #instantbird 18:44:32 <-- qheaden has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 18:49:43 <-- aleth has quit (Quit: exit stage left) 18:52:59 --> mpmc has joined #instantbird 19:55:03 <-- sonny has quit (Ping timeout) 19:56:28 <-- mconley has quit (Connection reset by peer) 19:57:00 --> mconley has joined #instantbird 20:09:06 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 20:14:17 --> chrisccoulson has joined #instantbird 20:19:41 --> EionRobb has joined #instantbird 20:30:27 --> jb has joined #instantbird 20:33:47 --> sonny has joined #instantbird 20:45:47 <-- sonny has quit (Ping timeout) 21:32:58 <-- jb has quit (Ping timeout) 21:35:06 --> aleth has joined #instantbird 21:35:06 * ChanServ sets mode +o aleth 22:02:34 <-- rosonline has quit (Ping timeout) 22:02:51 --> rosonline has joined #instantbird 22:29:11 <flo-retina> nhnt11: ping (although I don't really expect you to be awake now :)) 22:32:13 <flo-retina> aleth: am I reading correctly that to search logs for a contact we 1. Get the relative paths for all the buddies of the contact. 2. Iterate through all these directories to get the whole list of paths. 3. Create a log set with this list of paths, which will then iterate over them to guess with a Set what the relative directory paths are. 4. Query the DB. 5. Rebuild the full paths from the DB results? 22:35:56 <aleth> Yes. (3) is what is passed to the log viewer and displayed there 22:36:21 <flo-retina> doesn't this seem very inefficient? 22:36:52 <flo-retina> I think (2) should only happen the first time .forEach is called on the log set 22:37:41 <aleth> Doesn't (2) only happen once? 22:38:35 <flo-retina> aleth: what I'm saying is that if someone wants to write code using this new API to search the logs for a contact, because we hit the DB, we will do disk I/O to pointlessly list the log files 22:38:50 <aleth> I dislike the many arrays and sets of paths that keep getting constructed, but since paths are basically the IDs for logs... 22:39:04 <flo-retina> I'm expecting infinite scroll with do this. We will want section scroll to scroll to the next result, we won't care about all log files. 22:39:31 <aleth> I have not considered how this code will change later to accommodate infinite scroll. 22:39:43 <aleth> It seemed better to leave that until it is clearer what that will need. 22:40:11 <flo-retina> aleth: I'm just saying the API should make sense, and to things that are related to what is being called ;) 22:40:28 <flo-retina> what I'm suggesting is to move the content of _getLogFolderEntries to somewhere within the LogSet implementation 22:40:41 <flo-retina> s/to things/do things/ 22:41:17 <flo-retina> I don't expect that change to be difficult 22:41:27 <aleth> That sounds OK 22:42:03 <aleth> My point was only that for the *current* use case it's OK to iterate the folders once (as long as it's only once) as that's what the log viewer wants anyway. 22:42:23 <flo-retina> the log viewer wants to die :-P. 22:42:44 <aleth> Yes, but do you really expect it to die in the next week? ;) 22:43:00 <flo-retina> in the next year, yes 22:43:50 <aleth> It just seemed something that could be improved in a followup 22:44:20 <aleth> But if it jumps out at you now, ask for the change ;) 22:44:46 <flo-retina> yeah, I'm going to r- because of this. 22:44:54 <flo-retina> I have several other comments, but they are all very minor details 22:45:32 <flo-retina> aleth: I no longer believe in follow-ups actually being resolved (it's already great if they are actually filed ^^) 22:46:19 * Fallen is now known as Fallen|away 22:57:48 <flo-retina> aleth: out of curiosity, have you tried this indexing patch? 22:57:58 <aleth> No 22:58:31 <flo-retina> would be nice to have tried it at least on a different computer, right? 22:58:33 <aleth> I probably would have if the prerequisites had landed 22:58:48 <flo-retina> what are they? 22:59:01 <aleth> split logs and some shutdown followup 22:59:11 <flo-retina> are they all landed now? 22:59:39 <aleth> No, they touch chat, and the tree has been closed since forever 22:59:44 <aleth> Split logs needs a try push 22:59:53 <flo-retina> grr 23:00:08 <flo-retina> the indexing patch needs a try push too 23:00:14 <aleth> Of course. 23:01:37 <flo-retina> https://tbpl.mozilla.org/?tree=Thunderbird-Trunk looks green enough for a try push 23:02:30 <flo-retina> we won't have windows results, but that's better than nothing 23:02:40 <aleth> Still completely busted on Windows 23:03:21 <flo-retina> they should just use -j1 :-P 23:03:53 <aleth> oh, is that the issue? 23:03:53 <flo-retina> aleth: do you know if there's a bug on file for that windows failure? 23:04:41 <aleth> No, there's been too many bugs... 23:04:42 <flo-retina> aleth: nah, that's more the reason why _we_ aren't busted on Windows ;) 23:06:27 <-- aleth has quit (Ping timeout) 23:07:19 --> aleth has joined #instantbird 23:07:19 * ChanServ sets mode +o aleth 23:18:03 <-- aleth has quit (Ping timeout) 23:32:03 <-- mpmc has quit (Quit: Instantbird 1.6a1pre -- http://www.instantbird.com) 23:49:33 --> iamjayakumars_ has joined #instantbird 23:55:26 <-- iamjayakumars_ has quit (Quit: )